Re: Plasma Welcome Center on KDEReview
On 9/18/22 11:44, Nicolas Fella wrote: Hi, - I'd suggest to rename the repository to plasma-welcome to be consistent with the internal name and also other Plasma repos Requested with https://phabricator.kde.org/T15840 - The version number in KAboutData says "1.0", this should follow the Plasma version Fixed. - There's no Qt6 build yet, please look into that Done. - Some distributions have their own welcome apps, please coordinate with them so that we don't end up greeting the user with two welcome apps That's a good idea. Will do. - The appstream id ends with .desktop, which I understand is deprecated Fixed. - appstreamcli validate --pedantic org.kde.plasma-welcome.appdata.xml has some warnings: P: org.kde.plasma-welcome.desktop:12: screenshot-no-caption P: org.kde.plasma-welcome.desktop:~: releases-info-missing I: org.kde.plasma-welcome.desktop:3: cid-contains-hyphen org.kde.plasma-welcome.desktop P: org.kde.plasma-welcome.desktop:15: screenshot-no-caption I don't think these are real issues. There are no releases yet, the screenshots not having captions is intentional (their content seems totally obvious to me), and the ID having a hyphen seems like it's not actually a problem. - There's a stray .directory file in src/ Fixed. - Please add the ECM clang-format target and commit hook https://invent.kde.org/plasma/welcome-app/-/merge_requests/11 Nate
Re: Plasma Welcome Center on KDEReview
Am 16.09.22 um 17:59 schrieb Nate Graham: Hello folks! I've been working with Aleix on an onboarding wizard for Plasma, based on work originally started by Felipe Kinoshita last year. You can see some screenshots at https://invent.kde.org/websites/product-screenshots/-/commit/e300be66e62263c63d8a85ba391bbcc1de691148. I'd like to target Plasma 5.27 for release and am submitting it for KDEReview. The repo is at https://invent.kde.org/plasma/welcome-app. Hi, - I'd suggest to rename the repository to plasma-welcome to be consistent with the internal name and also other Plasma repos - The version number in KAboutData says "1.0", this should follow the Plasma version - There's no Qt6 build yet, please look into that - Some distributions have their own welcome apps, please coordinate with them so that we don't end up greeting the user with two welcome apps - The appstream id ends with .desktop, which I understand is deprecated - appstreamcli validate --pedantic org.kde.plasma-welcome.appdata.xml has some warnings: P: org.kde.plasma-welcome.desktop:12: screenshot-no-caption P: org.kde.plasma-welcome.desktop:~: releases-info-missing I: org.kde.plasma-welcome.desktop:3: cid-contains-hyphen org.kde.plasma-welcome.desktop P: org.kde.plasma-welcome.desktop:15: screenshot-no-caption - There's a stray .directory file in src/ - Please add the ECM clang-format target and commit hook
Re: Plasma Welcome Center on KDEReview
Not all code is licensing policy compliant (e.g. appdata is missing spdx tags). I'd suggest enabling the reuse linter pipeline. On Fri, Sep 16, 2022 at 6:00 PM Nate Graham wrote: > > Hello folks! > > I've been working with Aleix on an onboarding wizard for Plasma, based > on work originally started by Felipe Kinoshita last year. > > You can see some screenshots at > https://invent.kde.org/websites/product-screenshots/-/commit/e300be66e62263c63d8a85ba391bbcc1de691148. > > I'd like to target Plasma 5.27 for release and am submitting it for > KDEReview. The repo is at https://invent.kde.org/plasma/welcome-app. > > > Nate
Re: Plasma Welcome Center on KDEReview
El dissabte, 17 de setembre de 2022, a les 17:18:18 (CEST), Nate Graham va
escriure:
> On 9/17/22 02:16, Albert Astals Cid wrote:
> > Understanding that this is a standalone app and none of its contents are
> > reused to be shown in other apps a
> >
> >KLocalizedString::setApplicationDomain("welcomecenter");
> >
> > call in its main.cpp will do.
> >
> > Sidenote, given the name of the app is plasma-welcome i'd really suggest
> > changing the catalog name to plasma-welcome too instead of welcomecenter.
>
> Done.
>
> > It's a kirigami app, sadly this means it has too many warnings
> > https://pst.klgrth.io/paste/ydbmz
>
> A few of those are already fixed in git master. For the others, I've
> tried to clean this up a bit by fixing warnings where I can, or at least
> filing bug reports:
> - https://invent.kde.org/frameworks/kirigami/-/merge_requests/748
> - https://invent.kde.org/network/kaccounts-integration/-/merge_requests/42
> https://invent.kde.org/plasma/welcome-app/-/merge_requests/8
> - https://bugs.kde.org/show_bug.cgi?id=459283
> - https://bugs.kde.org/show_bug.cgi?id=459284
>
> > When run on my computer i can't see any buttons on the top "toolbar" (they
> > are there since generally clicking where they should be gets the thing to
> > go next/ prev). What dependency version are you interested in knowing
> > that may be causing this?
>
> This is weird. I don't understand how the toolbar can be invisible but
> interactive for you. I'm at a loss here. Does anyone else have any ideas?
https://invent.kde.org/plasma/welcome-app/-/merge_requests/9
>
>
> Nate
