QDialog on stack+exec and dbus quit crash is no more

2013-11-09 Thread Albert Astals Cid
So in the EBN checks we are checking for places where we create QDailog on the stack and then call exec and suggesting to replace them with a QPointer QDialog, see http://ebn.kde.org/krazy/reports/kde-4.x/kdegames/kmines/index.html and http://blogs.kde.org/node/3919 So people are trying to do

Re: Can we make api.kde.org search better?

2013-11-09 Thread Albert Astals Cid
El Dissabte, 9 de novembre de 2013, a les 16:14:16, Allen Winter va escriure: > On Saturday, November 09, 2013 01:27:12 PM Mark Gaiser wrote: > > On Sat, Nov 9, 2013 at 12:42 PM, Martin Klapetek > > > > wrote: > > > On Fri, Nov 8, 2013 at 3:47 PM, Allen Winter wrote: > > >> > Do you guys know if

Re: Can we make api.kde.org search better?

2013-11-09 Thread Albert Astals Cid
El Divendres, 8 de novembre de 2013, a les 09:47:47, Allen Winter va escriure: > On Saturday, November 02, 2013 12:15:15 AM Albert Astals Cid wrote: > > Hi, yesterday i was talking with someone about the desktop file class we > > have in KDE, he tried to find its

Re: Can we make api.kde.org search better?

2013-11-05 Thread Albert Astals Cid
El Dimarts, 5 de novembre de 2013, a les 15:17:05, Aleix Pol va escriure: > On Sat, Nov 2, 2013 at 5:59 PM, Allen Winter wrote: > > On Saturday, November 02, 2013 12:15:15 AM Albert Astals Cid wrote: > > > Hi, yesterday i was talking with someone about the desktop file clas

Re: Adopting AppData in KDE?

2013-11-03 Thread Albert Astals Cid
El Diumenge, 3 de novembre de 2013, a les 13:24:40, Richard Hughes va escriure: > On 3 November 2013 12:32, Albert Astals Cid wrote: > > I am all for listing "high quality applications", it's just that this just > > doesn't help. > > Sure it does.

Re: Adopting AppData in KDE?

2013-11-03 Thread Albert Astals Cid
El Diumenge, 3 de novembre de 2013, a les 12:22:52, Richard Hughes va escriure: > On 3 Nov 2013 11:59, "Albert Astals Cid" wrote: > > I've never created a standard so I can't comment on how to do it > > properly, but > > > writing it and then &q

Re: Adopting AppData in KDE?

2013-11-03 Thread Albert Astals Cid
El Dissabte, 2 de novembre de 2013, a les 19:48:01, Richard Hughes va escriure: > On 2 November 2013 19:33, Albert Astals Cid wrote: > > What's the point in having an installer that hides more than half of the > > apps in the world that don't ship a file that is not a

Re: Can we make api.kde.org search better?

2013-11-02 Thread Albert Astals Cid
El Dissabte, 2 de novembre de 2013, a les 12:59:00, Allen Winter va escriure: > On Saturday, November 02, 2013 12:15:15 AM Albert Astals Cid wrote: > > Hi, yesterday i was talking with someone about the desktop file class we > > have in KDE, he tried to find its

Re: Adopting AppData in KDE?

2013-11-02 Thread Albert Astals Cid
El Dissabte, 2 de novembre de 2013, a les 09:27:18, John Layt va escriure: > Some recent developments make this a fairly high priority for apps > that wish to target a cross-desktop audience. The new Gnome Software > Centre in Gnome 3.12 which uses AppData will become the default > installer in Fe

Can we make api.kde.org search better?

2013-11-01 Thread Albert Astals Cid
Hi, yesterday i was talking with someone about the desktop file class we have in KDE, he tried to find its api by going to api.kde.org and typing desktop in the Search bar. If you do that http://api.kde.org/index.php?miss=1&class=desktop all you get is No results found! Do you guys kn

Re: Review Request 113471: Fix crash when removing an item while we are adding one

2013-10-28 Thread Albert Astals Cid
--- I can't reproduce it in my desktop but Alex and Michael have been running this patch for weeks and can certainly say that the crashing situation has improved (i.e. no crashes in days with this patch and crashes daily without it). Thanks, Albert Astals Cid

Re: Review Request 104222: Display recent documents in places bookmark by default

2013-10-27 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104222/#review42491 --- kdelibs guys, can anyone review this? - Albert Astals Cid

Re: Review Request 111238: Remove .end() calls from iteration loops in KDirLister

2013-10-27 Thread Albert Astals Cid
> On June 26, 2013, 10:56 a.m., David Faure wrote: > > The change itself looks OK, but all it will do is create a gigantic merge > > conflict for me in frameworks... is that really worth it? > > > > I think it would be better to make such cleanups in frameworks directly. Dawit, David, what sho

Re: Review Request 111050: Fast mime detection speedup.

2013-10-27 Thread Albert Astals Cid
work further on this or shall it be discarded not to clutter the kdelibs group review list? - Albert Astals Cid On June 23, 2013, 9:21 p.m., Mark Gaiser wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 110042: Find Qt5 version of DBusMenuQt

2013-10-27 Thread Albert Astals Cid
> On May 20, 2013, 2:08 a.m., Ian Monroe wrote: > > Ship It! > > Albert Astals Cid wrote: > Janitorial dude question: Has this been commited and you forgot to mark > it as submitted or it does still need submitting? > > > Frederik Gladhorn wrote: &

Re: R: Re: kde review kartesio

2013-10-27 Thread Albert Astals Cid
El Diumenge, 27 d'octubre de 2013, a les 18:48:21, LucaTringali va escriure: > Hi Albert, > I'm working on the points but, since I'm kinda busy with my work, the code I > have written for now is still not stable. I think it'll be ready in the > first week of January 2014. > If you study something,

Re: kde review kartesio

2013-10-27 Thread Albert Astals Cid
El Dijous, 9 de maig de 2013, a les 18:06:16, LucaTringali va escriure: > Hello,I have been working on Kartesio, a program for calculating best fit > curves with experimental points. I think it is ready to be moved in the KDE > Edu main repo now, so I'm asking your approval.I followed the guideline

Re: Review Request 113471: Fix crash when removing an item while we are adding one

2013-10-27 Thread Albert Astals Cid
h, if > > it is needed, in other words, what happens when items do not get removed by > > the timer. > > > > But since this seems to workaround the crash, it should get into 4.11.3. > > Someone else must approve. > > Albert Astals Cid wrote: > Well, t

Re: Review Request 113471: Fix crash when removing an item while we are adding one

2013-10-27 Thread Albert Astals Cid
e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113471/#review42418 --------------- On Oct. 27, 2013, 10:36 a.m., Albert Astals Cid wrote: > > --- > This is an auto

Review Request 113471: Fix crash when removing an item while we are adding one

2013-10-27 Thread Albert Astals Cid
for weeks and can certainly say that the crashing situation has improved (i.e. no crashes in days with this patch and crashes daily without it). Thanks, Albert Astals Cid

Re: Review Request 113413: Improved Keyboard Layout Preview

2013-10-27 Thread Albert Astals Cid
> On Oct. 25, 2013, 7:58 p.m., Xuetian Weng wrote: > > Could you also post a preview for French ? It should have 4 symbol on one > > key, I'd like to how that looks. > > Seems you didn't parse the led information? (It's ok to leave it there) > > > > Some key name doesn't looks correct (F1 - F12

Re: Review Request 113419: Remove the upper-half white gradient from KSplash Minimalistic theme

2013-10-24 Thread Albert Astals Cid
> On Oct. 24, 2013, 3:08 p.m., Mark Gaiser wrote: > > -1 > > > > I have to add some explanation to that. > > > > I'm all OK with plain and simplistic, but not TOO plain and simplistic > > (aka, the Windows 8 and apple route). We don't live in a monochrome age > > anymore so i think the theme

Re: kactivities master becomes Qt5/KF5-based

2013-10-21 Thread Albert Astals Cid
El Dilluns, 21 d'octubre de 2013, a les 18:43:20, Ivan Čukić va escriure: > > I was planning to branch master into KDE/4.12 after October 30 and > > before November 6. > > Forget about it. Decided not to create problems - I'll use the same name > for the branch as kdelibs do for the time being - f

Re: kactivities master becomes Qt5/KF5-based

2013-10-21 Thread Albert Astals Cid
El Dilluns, 21 d'octubre de 2013, a les 14:02:42, Ivan Čukić va escriure: > > Please no. We have a 4.12 release to make in 2 weeks and back when we did > > the 4.12 planning the only agreed repo to be freezed for 4.11 was > > kde-workspace. > > What about doing an early KDE/4.12 branch from master

Re: Dependency to unreleased versions

2013-10-21 Thread Albert Astals Cid
will miss in client applications. > > I will check under OSX and Windows today, but i'm sure that all will > work perfectly... > > Gilles Caulier > > 2013/10/21 Gilles Caulier : > > 2013/10/21 Albert Astals Cid : > >> El Diumenge, 20 d'octubre de 201

Re: Review Request 113366: kio_http: small optimization in response code parsing

2013-10-21 Thread Albert Astals Cid
re. if (!sendErrorPageNotification()) { @@ -3125,6 +3123,7 @@ try_again: // We got 'Continue' - ignore it cont = true; } +} // (m_request.responseCode != 200 && m_request.responseCode != 304) endParsing: bool authRequiresAnothe

Re: kactivities master becomes Qt5/KF5-based

2013-10-21 Thread Albert Astals Cid
> Hi all, > > Following kde-workspace (and stealing a few sentences from that > announcement), > we're planning to merge the frameworks-scratch branch of kactivities into > master later today. That means if you're building 4.x branch of Plasma > yourself from Git, you should switch to the > KD

Re: Dependency to unreleased versions

2013-10-20 Thread Albert Astals Cid
El Diumenge, 20 d'octubre de 2013, a les 22:53:22, Gilles Caulier va escriure: > Soon will be few days. But it will be just a beta release, not a stable. > > I will try to find a way next week to check libraw < 0.16 with cmake > to solve this issue. Does that mean that: * libkdcraw for the 4.12

Re: Dependency to unreleased versions

2013-10-20 Thread Albert Astals Cid
El Diumenge, 20 d'octubre de 2013, a les 10:23:55, Gilles Caulier va escriure: > Hi, > > The first beta of libraw 0.16 will be done soon, accordingly with libraw > team. > > 0.16 release will introduce whole compilation rules driven by cmake > (completed by me). How soon is soon? Are you aware t

Re: KService has regressed

2013-10-19 Thread Albert Astals Cid
El Divendres, 18 d'octubre de 2013, a les 09:49:02, David Faure va escriure: > On Monday 14 October 2013 23:52:49 Albert Astals Cid wrote: > > Hi guys, seems that KService has regressed and now it does not include all > > the mimetypes listed in the .desktop file anymore.

Re: Moving KScreen and libkscreen to extragear

2013-10-17 Thread Albert Astals Cid
El Dijous, 17 d'octubre de 2013, a les 14:37:43, David Edmundson va escriure: > This has been in kdereview for over 3 months now. It is probably safe > to move, though I would still like a reply to my comments > > We should not be recommending to packagers to ship code that is in > playground, it

KService has regressed

2013-10-14 Thread Albert Astals Cid
Hi guys, seems that KService has regressed and now it does not include all the mimetypes listed in the .desktop file anymore. Code to fix BUG 321706 seems to have added a check for // Only add unique mimetypes When that is not the behavior that kservice used to had, and it's not the document

Re: Review Request 113219: Fix struct initialization which is invalid for C++11

2013-10-12 Thread Albert Astals Cid
> On Oct. 12, 2013, 4:47 p.m., Thiago Macieira wrote: > > Ship It! He doesn't have a commiting account afaik, so he'll need someone to commit for him. - Albert --- This is an automatically generated e-mail. To reply, visit: http://git.

Re: Review Request 113218: Enable translation functions for js script loaded through Kross

2013-10-12 Thread Albert Astals Cid
ive a ship it, but if noone does in some time, just ping me and i'll do :D - Albert Astals Cid On Oct. 12, 2013, 3:09 p.m., Luigi Toscano wrote: > > --- > This is an automatically generated e-mail. To r

Re: Review Request 110118: wrong path for plugin. ( doubling the plugin address cause the basepath to "" )

2013-10-10 Thread Albert Astals Cid
> On Oct. 10, 2013, 10:16 a.m., Albert Astals Cid wrote: > > Was this commited? > > Also isn't a whole remove in the middle a bit too dangerous? > > Ömer Fadıl Usta wrote: > I had also some suspicions so i delayed commiting for check it on > different in

Re: Review Request 110118: wrong path for plugin. ( doubling the plugin address cause the basepath to "" )

2013-10-10 Thread Albert Astals Cid
dle a bit too dangerous? - Albert Astals Cid On April 21, 2013, 6:18 p.m., Ömer Fadıl Usta wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard

Re: Review Request 105304: Allow usage of detailedsorry and detailederror in kdialog

2013-10-10 Thread Albert Astals Cid
> On July 12, 2012, 4:17 p.m., David Faure wrote: > > Looks good. For master only, though, given feature+message freeze in 4.9. > > Kai Uwe Broulik wrote: > Totally forgot to commit this :( Will do for master (4.10) once my ssh > key for my new notebook got imported. &

Re: kde-workspace master becomes Qt5-based

2013-09-24 Thread Albert Astals Cid
El Dimarts, 24 de setembre de 2013, a les 11:34:45, Martin Gräßlin va escriure: > On Thursday 19 September 2013 19:30:52 Sebastian Kügler wrote: > > Hi all, > > > > We're planning to merge the frameworks-scratch branch of kde-workspace > > into > > master next Monday. That means if you're buildin

Re: KDE theme colors API for QML

2013-09-21 Thread Albert Astals Cid
El Dimarts, 17 de setembre de 2013, a les 17:54:08, Денис Купляков va escriure: > Hello all! > > I have finished patching kdelibs (added Q_GADGET and Q_ENUMS(...) to > KColorScheme) and have realised KColorSchemeTokken class for QML that > gives access to colors. Do I need to include it to kdelib

Re: Fwd: The Future of Speech Recognition in KDE: Proposal

2013-09-21 Thread Albert Astals Cid
El Dimecres, 18 de setembre de 2013, a les 14:46:12, Peter Grasch va escriure: > Almost 2 weeks have passed since the last reply in this thread. Since > the only "vote" was positive, I'm assuming the membership is okay with > the new extragear group. FWIW I am :D You may also want to drop a quick

Re: KF5 kwallet, kwalletd and wallet manager questions

2013-08-28 Thread Albert Astals Cid
El Diumenge, 25 d'agost de 2013, a les 12:05:11, Valentin Rusu va escriure: > On 08/24/2013 01:43 PM, Albert Astals Cid wrote: > > El Dissabte, 24 d'agost de 2013, a les 12:31:20, Valentin Rusu va escriure: > >> * Another piece of software related to kwallet is KWall

Re: Review request: kde-runtime/kwalletd branch kwalletd-gpg

2013-08-25 Thread Albert Astals Cid
Noone taking a stab at this? Valentin do you know of someone you can annoy to ge the code reviewed? El Dissabte, 17 d'agost de 2013, a les 14:22:35, Valentin Rusu va escriure: > Hello, > > kwalletd now supports GPG encryption. The code is fully functional, at > least on my system, and I pushed i

Re: KDE theme colors API for QML

2013-08-25 Thread Albert Astals Cid
El Dimecres, 14 d'agost de 2013, a les 23:49:23, Денис Купляков va escriure: > Hey all! Hi > I want to implement API to access KDE theme colors from QML to use in > games or other applications. For example it will allow us to implement > KGamePopupItem substitution for QML. > > Now developer nee

Re: KF5 kwallet, kwalletd and wallet manager questions

2013-08-24 Thread Albert Astals Cid
El Dissabte, 24 d'agost de 2013, a les 12:31:20, Valentin Rusu va escriure: > Hello, > > Now that frameworks splitting is almost done ;-) with some people even > running KF5-based sessions on their systems, I'd like to plan kwallet > porting and integration. BTW, I'd like also to announce that I a

Re: Proposed schedule for 4.12

2013-08-20 Thread Albert Astals Cid
El Dissabte, 3 d'agost de 2013, a les 20:19:48, Albert Astals Cid va escriure: > Please let's try to keep this discussion in release-team, I'm just CC'ing > k-c- d because Alex's discussion about changing the release happened there. > > At the Release Team B

Re: Review Request 112144: Smal KXmlGuiWindow documentation improvements

2013-08-20 Thread Albert Astals Cid
> On Aug. 19, 2013, 5:06 p.m., David Faure wrote: > > This patch looks OK. > > > > Deprecating it, I'm not sure. Please investigate porting some kde4 apps > > from createGUI to setupGUI to see what's actually involved in that. > > Albert Astals Cid

Re: Review Request 112144: Smal KXmlGuiWindow documentation improvements

2013-08-19 Thread Albert Astals Cid
git.reviewboard.kde.org/r/112144/#review38159 ------- On Aug. 18, 2013, 2:15 p.m., Albert Astals Cid wrote: > > --- > This is an automatically generated e-mail. To r

Re: Review Request 112144: Smal KXmlGuiWindow documentation improvements

2013-08-18 Thread Albert Astals Cid
/kxmlguiwindow.h 3237b8c Diff: http://git.reviewboard.kde.org/r/112144/diff/ Testing --- N/A Thanks, Albert Astals Cid

Review Request 112144: Smal KXmlGuiWindow documentation improvements

2013-08-18 Thread Albert Astals Cid
://git.reviewboard.kde.org/r/112144/diff/ Testing --- N/A Thanks, Albert Astals Cid

Re: Review request: kde-runtime/kwalletd branch kwalletd-gpg

2013-08-17 Thread Albert Astals Cid
El Dissabte, 17 d'agost de 2013, a les 14:22:35, Valentin Rusu va escriure: > Hello, > > kwalletd now supports GPG encryption. The code is fully functional, at > least on my system, and I pushed it to the kwalletd-gpg branch of > kde-runtime. > See my blog post for more information: > http://www.r

Re: Review Request 112122: Respect user's 12/24 h preference in System Settings

2013-08-16 Thread Albert Astals Cid
> On Aug. 16, 2013, 6:19 p.m., Albert Astals Cid wrote: > > kcontrol/dateandtime/dtime.cpp, line 101 > > <http://git.reviewboard.kde.org/r/112122/diff/1/?file=181483#file181483line101> > > > > Maybe just use KLocale::timeFomat()? > > Christoph Feck

Re: Review Request 112122: Respect user's 12/24 h preference in System Settings

2013-08-16 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112122/#review38008 --- Ship it! Ship It! - Albert Astals Cid On Aug. 16, 2013, 3

Re: Review Request 112122: Respect user's 12/24 h preference in System Settings

2013-08-16 Thread Albert Astals Cid
ttp://git.reviewboard.kde.org/r/112122/#comment28084> Maybe just use KLocale::timeFomat()? - Albert Astals Cid On Aug. 16, 2013, 3:21 p.m., Christoph Feck wrote: > > --- > This is an automatically generated e-mail. To reply

Re: Review Request 111164: Create FavIconsModule namespace in kdebug

2013-08-15 Thread Albert Astals Cid
> On June 21, 2013, 8:29 p.m., David Faure wrote: > > It's all commented out, but if that makes you happy, go for it :) > > > > (yes, make the function file-static first) Janitorial dude question: Has this been commited and you forgot to mark it as submitted or it does still need submitting?

Re: Review Request 110090: Clean up kickoff from stale bits

2013-08-15 Thread Albert Astals Cid
> On May 8, 2013, 2:57 p.m., Raphael Kubo da Costa wrote: > > Thanks for the cleanup. You might also want to remove the references to > > Strigi in DESIGN-GOALS and STATUS-TODO, but I guess they're very outdated > > anyway. Please include a descriptive commit message explaining that this > > p

Re: Review Request 110042: Find Qt5 version of DBusMenuQt

2013-08-15 Thread Albert Astals Cid
> On May 20, 2013, 2:08 a.m., Ian Monroe wrote: > > Ship It! Janitorial dude question: Has this been commited and you forgot to mark it as submitted or it does still need submitting? - Albert --- This is an automatically generated e-ma

Re: Review Request 112099: [kcontrol/locale] update the sample when input changed

2013-08-15 Thread Albert Astals Cid
> On Aug. 15, 2013, 2:16 p.m., Albert Astals Cid wrote: > > Thanks for the patch! > > > > The enum thing seems a bit overkill to me, i mean, how "expensive" is the > > updateSample function after all? Personally, I'd just call it and that's >

Re: Review Request 112099: [kcontrol/locale] update the sample when input changed

2013-08-15 Thread Albert Astals Cid
tp://git.reviewboard.kde.org/r/112099/ > --- > > (Updated Aug. 15, 2013, 2:07 p.m.) > > > Review request for KDE Runtime and Albert Astals Cid. > > > Description > --- > > when the input texts are changed the sample did not update and only was > updated with the 1

Re: Review Request 112099: [kcontrol/locale] update the sample when input changed

2013-08-15 Thread Albert Astals Cid
Albert Astals Cid. Description --- when the input texts are changed the sample did not update and only was updated with the 1 second timer. with applied patch it updates right away. for performance reasons updateSample() was given a flags parameter for filtering out what to update, defaults

Help with 4.11 announcement

2013-08-09 Thread Albert Astals Cid
Come on guys, help our promo guys filling some of the amazing stuff you've done. Cheers, Albert El Dissabte, 3 d'agost de 2013, a les 22:00:45, Jos Poortvliet va escriure: > Heya all, > > We're working on the announcement text here: > https://notes.kde.org/p/release4.11 > > Feel free to add/

Re: Backporting Clang support to KDE 4.11 FindKDE4Internal.cmake

2013-08-05 Thread Albert Astals Cid
El Dilluns, 5 d'agost de 2013, a les 01:34:07, Milian Wolff va escriure: > On Sunday 04 August 2013 16:35:20 Albert Astals Cid wrote: > > El Diumenge, 4 d'agost de 2013, a les 00:29:06, Milian Wolff va escriure: > > > On Sunday 04 August 2013 00:28:17 Milian

Re: Backporting Clang support to KDE 4.11 FindKDE4Internal.cmake

2013-08-04 Thread Albert Astals Cid
El Diumenge, 4 d'agost de 2013, a les 00:29:06, Milian Wolff va escriure: > On Sunday 04 August 2013 00:28:17 Milian Wolff wrote: > > Hey all, > > > > I'd like to backport this comment from kdelibs master to KDE 4.11, is this > > OK? > > Ahum, sorry - accidentally hit "ctrl + enter". > > commit

Re: Broken tests in kdelibs due to kio change

2013-08-04 Thread Albert Astals Cid
unit tests. I > will fix the kde-runtime tests as well. As said, do you know for sure that all the users of kio are creating a qapplication with gui enabled? The fact that we have 7 tests that assumed otherwise make me icky. Albert > > On Sat, Aug 3, 2013 at 1:52 PM, Albert Astals Cid w

Proposed schedule for 4.12

2013-08-03 Thread Albert Astals Cid
Please let's try to keep this discussion in release-team, I'm just CC'ing k-c- d because Alex's discussion about changing the release happened there. At the Release Team BoF at Akademy I was tasked to come up with a proposed schedule for 4.12 with simplified freezes, since it was agreed so many f

Re: Broken tests in kdelibs due to kio change

2013-08-03 Thread Albert Astals Cid
El Dissabte, 3 d'agost de 2013, a les 19:52:28, Albert Astals Cid va escriure: > El Dissabte, 3 d'agost de 2013, a les 13:39:40, Dawit A va escriure: > > OK. I see why those tests failed and I fixed them not to anymore. Updating > > the clibpboard in KIO introduced a depen

Re: Broken tests in kdelibs due to kio change

2013-08-03 Thread Albert Astals Cid
gt; > changing fileundomanager from NoGui to Gui did it? Anyhow, I will try to > > look into it. > > > > On Sat, Aug 3, 2013 at 10:25 AM, Albert Astals Cid wrote: > >> Dawit, kdelibs people, there are 4 tests that broke in > >> very-close-to-release > >&

Re: Review Request 111851: Split KCModules into different Categories in KHelpcenter's navigation tree

2013-08-03 Thread Albert Astals Cid
rings and new code into 4.11 at this very late stage - Albert Astals Cid On Aug. 3, 2013, 11:21 a.m., Burkhard Lück wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard

Broken tests in kdelibs due to kio change

2013-08-03 Thread Albert Astals Cid
Dawit, kdelibs people, there are 4 tests that broke in very-close-to-release 4.11 branch with a change from yesterday to kio. http://build.kde.org/view/KDE%20SC%20stable/job/kdelibs_stable/735/ Can you guys please have a look and fix those failing tests? Also please please please make sure you

Re: Review Request 111852: Ensure MImeType's XML Data is Loaded before Returning Properties

2013-08-03 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111852/#review37019 --- Can this be unit tested? - Albert Astals Cid On Aug. 3

Re: Review Request 111852: Ensure MImeType's XML Data is Loaded before Returning Properties

2013-08-03 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111852/#review37020 --- Can this be unit tested? - Albert Astals Cid On Aug. 3

Re: Proposal for branching policy towards KF5

2013-07-28 Thread Albert Astals Cid
El Diumenge, 28 de juliol de 2013, a les 11:33:58, Torgny Nyblom va escriure: > On Friday 26 July 2013 23.53.07 Michael Pyne wrote: > > On Fri, July 26, 2013 21:11:21 Torgny Nyblom wrote: > > > On Thursday 25 July 2013 18.24.50 Michael Pyne wrote: > > > > The 'logical module groups' might play a ro

Re: Proposal for branching policy towards KF5

2013-07-25 Thread Albert Astals Cid
El Dimecres, 24 de juliol de 2013, a les 23:05:55, Michael Pyne va escriure: > On Fri, July 19, 2013 00:21:21 you wrote: > > After more live discussion with Sebas and Marco plus Aaron over a video > > chat, we came up with the following setup for the workspace repos (*) : > > > > - the development

Re: release schedule BoF

2013-07-23 Thread Albert Astals Cid
Lost in translation, i said kdepim instead of kdelibs. Cheers,   Albert De: David Faure Para: kde-core-devel@kde.org; Albert Astals Cid Enviado: Martes 23 de julio de 2013 14:22 Asunto: Re: release schedule BoF > tsdgeos: >     can someone pleas

Re: Review Request 111633: Update announced KDE version / required Qt version

2013-07-22 Thread Albert Astals Cid
lbert Astals Cid On July 21, 2013, 4:40 p.m., Christoph Feck wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard

Re: Review Request 111633: Update announced KDE version / required Qt version

2013-07-21 Thread Albert Astals Cid
> On July 21, 2013, 4:47 p.m., Albert Astals Cid wrote: > > Is that qt change really needed? Otherwise we are a bit past the dependency > > freeze > > Christoph Feck wrote: > CMakeLists.txt already requires Qt 4.8.0. But isn't the content of CMakeLists.txt f

Re: Review Request 111633: Update announced KDE version / required Qt version

2013-07-21 Thread Albert Astals Cid
the dependency freeze - Albert Astals Cid On July 21, 2013, 4:40 p.m., Christoph Feck wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Proposal for branching policy towards KF5

2013-07-18 Thread Albert Astals Cid
El Divendres, 19 de juliol de 2013, a les 00:21:21, David Faure va escriure: > After more live discussion with Sebas and Marco plus Aaron over a video > chat, we came up with the following setup for the workspace repos (*) : > > - the development branch for their next feature release (based on Qt5

Re: Releases in 3 months

2013-07-17 Thread Albert Astals Cid
El Dimecres, 17 de juliol de 2013, a les 19:34:17, Scott Kitterman va escriure: > On Thursday, July 18, 2013 01:19:12 AM Albert Astals Cid wrote: > > El Dimecres, 17 de juliol de 2013, a les 07:37:16, Luca Beltrame va > > escriure: > > > Albert Astals Cid wrote: > &

Re: release schedule BoF

2013-07-17 Thread Albert Astals Cid
re candence). Cheers, Albert > > Jonathan Riddell escribió: > >Albert Astals Cid: > >idea is to shorten release > >we have now lots of freezes and a branch > > > >alex wants something shorter, suggested 3 months between release with > >only 1 mont

Re: Releases in 3 months

2013-07-17 Thread Albert Astals Cid
El Dimecres, 17 de juliol de 2013, a les 07:37:16, Luca Beltrame va escriure: > Albert Astals Cid wrote: > > Just as a reminder, we have the Release Team BOF tomorrow July 17 at 10:15 > > at Room A2 > > Would it be possible to post the outcome of the discussion here? It wo

Re: Releases in 3 months

2013-07-16 Thread Albert Astals Cid
Just as a reminder, we have the Release Team BOF tomorrow July 17 at 10:15 at Room A2 Cheers, Albert El Dimarts, 16 de juliol de 2013, a les 14:38:47, Scott Kitterman va escriure: > On Monday, July 15, 2013 09:00:27 PM Luca Beltrame wrote: > > Àlex Fiestas wrote: > > > Now that kde-workspace a

Re: Releases in 3 months

2013-07-15 Thread Albert Astals Cid
El Dilluns, 15 de juliol de 2013, a les 09:58:01, Cristian Tibirna va escriure: > Although Inge supposedly bases his analysis on extrapolation and (very) wise > guessing, and despite the obvious lack of hard data (1), I will put my > support behind Inge's view. > > (1) (sadly including here our b

Re: Releases in 3 months

2013-07-15 Thread Albert Astals Cid
El Diumenge, 14 de juliol de 2013, a les 04:19:52, Inge Wallin va escriure: > I think keeping 6 months is a good > figure to ensure both reasonable turn-around *and* actual bugfixes of > versions being used in the real world. It may be a reasonable turn-around for some users, but it is also not d

Re: KDE/4.11 branched what to do with kde-workspace?

2013-07-10 Thread Albert Astals Cid
El Dimecres, 10 de juliol de 2013, a les 15:55:01, Thomas Lübking va escriure: > On Mittwoch, 10. Juli 2013 15:34:43 CEST, Michael Jansen wrote: > > Because of that it should be announced. BIG TIME. > > I'd suggest to keep master as it is and develop PWv2 in a new branch. > > Those who want to de

KDE/4.11 branched what to do with kde-workspace?

2013-07-09 Thread Albert Astals Cid
So the kde-workspace dudes decided they don't want a 4.12 release and that they'll do a LTS 4.11, fine, how do we fix that branch wise? Cheers, Albert

Re: Releases in 3 months

2013-07-08 Thread Albert Astals Cid
El Dilluns, 8 de juliol de 2013, a les 20:40:59, Heinz Wiesinger va escriure: > On Monday 08 July 2013 15:04:40 Àlex Fiestas wrote: > > Now that kde-workspace and kdelibs are going to be frozen (which in theory > > means less work for everybody) I'd like to propose a new release schedule > > to be

Re: openSUSE packagers' take on the 3 month release cycle

2013-07-08 Thread Albert Astals Cid
El Dilluns, 8 de juliol de 2013, a les 20:35:22, Luca Beltrame va escriure: > (apologies for breaking your threading, but I'm not subscribed to k-c-d; in > fact, please CC me with replies, thanks!) > > Currently, the people working on openSUSE packages are against the proposal. > A detailed explan

Re: Releases in 3 months

2013-07-08 Thread Albert Astals Cid
El Dilluns, 8 de juliol de 2013, a les 20:03:14, Nuno Pinheiro va escriure: > A Segunda, 8 de Julho de 2013 20:58:42 Albert Astals Cid escreveu: > > El Dilluns, 8 de juliol de 2013, a les 19:32:13, Nuno Pinheiro va escriure: > > > A Segunda, 8 de Julho de 2013 15:04:40 Àle

Re: Releases in 3 months

2013-07-08 Thread Albert Astals Cid
El Dilluns, 8 de juliol de 2013, a les 19:32:13, Nuno Pinheiro va escriure: > A Segunda, 8 de Julho de 2013 15:04:40 Àlex Fiestas escreveu: > > Now that kde-workspace and kdelibs are going to be frozen (which in theory > > means less work for everybody) I'd like to propose a new release schedule >

Re: Releases in 3 months

2013-07-08 Thread Albert Astals Cid
El Dilluns, 8 de juliol de 2013, a les 14:03:19, Scott Kitterman va escriure: > Albert Astals Cid wrote: > >El Dilluns, 8 de juliol de 2013, a les 11:25:42, Scott Kitterman va > > > >escriure: > >> On Monday, July 08, 2013 04:59:50 PM Àlex Fiestas wrote: > >

Re: Releases in 3 months

2013-07-08 Thread Albert Astals Cid
El Dilluns, 8 de juliol de 2013, a les 11:25:42, Scott Kitterman va escriure: > On Monday, July 08, 2013 04:59:50 PM Àlex Fiestas wrote: > > On Monday 08 July 2013 10:40:21 Scott Kitterman wrote: > > > We've already experienced having some parts of the SC skip releases and > > > it > > > was a real

Re: Releases in 3 months

2013-07-08 Thread Albert Astals Cid
El Dilluns, 8 de juliol de 2013, a les 15:45:13, laurent Montel va escriure: > Hi, > As you know I work a lot on kdepim (but you forgot to ask me if it was a > good idea or I didn’t receive mail... :) ) > > Ok kdelibs and kde-workspace is frozen until KDE SC5 so less work for you > for example. >

Re: Releases in 3 months

2013-07-08 Thread Albert Astals Cid
El Dilluns, 8 de juliol de 2013, a les 15:14:07, Luigi Toscano va escriure: > On Monday 08 of July 2013 15:04:40 Àlex Fiestas wrote: > > Now that kde-workspace and kdelibs are going to be frozen (which in theory > > means less work for everybody) I'd like to propose a new release schedule > > to be

Re: Disable by default KRandR in 4.11

2013-07-08 Thread Albert Astals Cid
El Dilluns, 8 de juliol de 2013, a les 15:10:06, Àlex Fiestas va escriure: > On Thursday 04 July 2013 21:39:03 Albert Astals Cid wrote: > > I agree we are too late. > > > > If KScreen is so much better, i'd make sure packagers know about it and > > they can instal

Re: Moving KScreen and libkscreen to extragear

2013-07-04 Thread Albert Astals Cid
El Dijous, 4 de juliol de 2013, a les 01:13:36, Àlex Fiestas va escriure: > I would like to request a review so we can move KScreen and libkscreen to > extragear/base. Has it been virtually moved to kdereview? Cheers, Albert > > KScreen is a new manager for outputs such: monitors, projectors,

Re: Disable by default KRandR in 4.11

2013-07-04 Thread Albert Astals Cid
El Dijous, 4 de juliol de 2013, a les 01:06:27, Àlex Fiestas va escriure: > Hi there Hi > I want to propose to disable by default KRandR from kde-workspace release > for 4.11. > > While I'm considered the maintainer of KRandR truth is I have never been > it, I just made it "work" around 4.7 time

kentrymaptest broken in master

2013-06-30 Thread Albert Astals Cid
Hi, it seems that https://projects.kde.org/projects/kde/kdelibs/repository/diff?rev=0e934088c5647fe3d56f76fdb28d05c0fdf0f7a4 broke kentrymaptest http://build.kde.org/view/KDE%20SC%20master/job/kdelibs_master/310/testReport/%28root%29/TestSuite/kentrymaptest/ Can anyone have a look at if we eit

Re: Review Request 111261: [KDE-Workspace]: Possible NULL ptr. deref. in KDM and KCheckPass

2013-06-29 Thread Albert Astals Cid
> On June 29, 2013, 11:37 a.m., Oswald Buddenhagen wrote: > > Ship It! Mr Mancha Mancha we're going to need your real name and email before we can submit this for proper attribution. - Albert --- This is an automatically generated e-ma

Re: startkde modifies PATH to add qt4 bin dir to the front

2013-06-25 Thread Albert Astals Cid
El Dimarts, 18 de juny de 2013, a les 19:19:24, Albert Astals Cid va escriure: > El Dimarts, 18 de juny de 2013, a les 09:55:23, David Faure va escriure: > > Le lundi 17 juin 2013 20:15:23 Albert Astals Cid a écrit : > > > Maybe we should just make sure the qdbus calls in star

Re: startkde modifies PATH to add qt4 bin dir to the front

2013-06-18 Thread Albert Astals Cid
El Dimarts, 18 de juny de 2013, a les 09:55:23, David Faure va escriure: > Le lundi 17 juin 2013 20:15:23 Albert Astals Cid a écrit : > > Maybe we should just make sure the qdbus calls in startkde have the full > > qualified path and that's it? > > Ah! This is for the

<    5   6   7   8   9   10   11   12   13   14   >