kdelibs/kio/kssl/kcm

2010-11-23 Thread Jonathan Riddell
KControl modules are best in kdebase, kdelibs is for libraries not UIs. Jonathan

Re: Status of KSecretService

2012-03-21 Thread Jonathan Riddell
On Wed, Mar 21, 2012 at 01:58:53PM +0100, Alex Fiestas wrote: What's the status of KSecretService ? is it stuck because of Frameworks? It is a released part of KDE SC, but nobody seems to have packaged or tested it. I think it should be removed from KDE SC until it is better tested. If I

Re: Status of KSecretService

2012-03-21 Thread Jonathan Riddell
Kubuntu also has a bug asking for KSecretsService added to the kwallet KCM. https://bugs.launchpad.net/kubuntu-ppa/+bug/934448 But I am yet to find how to do that. Jonathan

Review Request 113819: don't install dbus interface file

2013-11-12 Thread Jonathan Riddell
be installed (the debian/kubuntu packages don't install it). Diffs - ktimezoned/CMakeLists.txt ce8f742 Diff: http://git.reviewboard.kde.org/r/113819/diff/ Testing --- Thanks, Jonathan Riddell

Re: Review Request 113819: don't install dbus interface file

2013-11-13 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113819/#review43560 --- On Nov. 12, 2013, 4:47 p.m., Jonathan Riddell wrote: --- This is an automatically

Re: Review Request 113819: don't install dbus interface file

2013-11-13 Thread Jonathan Riddell
without warning and this file clashes with the equivalent file in KDE 4 so it shouldn't be installed (the debian/kubuntu packages don't install it). Diffs - ktimezoned/CMakeLists.txt ce8f742 Diff: http://git.reviewboard.kde.org/r/113819/diff/ Testing --- Thanks, Jonathan Riddell

Review Request 113833: fix include file in kio

2013-11-13 Thread Jonathan Riddell
Description --- Fix include file, all the rest use kio/ directory but this one misses it Diffs - tier4/kde4support/src/includes/KIO/NetAccess 2c06155 Diff: http://git.reviewboard.kde.org/r/113833/diff/ Testing --- Thanks, Jonathan Riddell

Re: Review Request 113833: fix include file in kio

2013-11-13 Thread Jonathan Riddell
/r/113833/diff/ Testing --- Thanks, Jonathan Riddell

Review Request 113839: kcmshell: change internal references to kcmshell5

2013-11-13 Thread Jonathan Riddell
Description --- change references to kcmshell4 to kcmshell5 also change app internal name from kcmshell to kcmshell5 for consistency Diffs - kcmshell/main.cpp 67d7d3f Diff: http://git.reviewboard.kde.org/r/113839/diff/ Testing --- Thanks, Jonathan Riddell

Review Request 113841: kcm locale: use kcmshell5

2013-11-13 Thread Jonathan Riddell
-runtime Description --- trivial patch to use kcmshell5 binary Diffs - kcontrol/locale/language.desktop 9beae5c Diff: http://git.reviewboard.kde.org/r/113841/diff/ Testing --- Thanks, Jonathan Riddell

Review Request 113846: fix kicontheme::list

2013-11-13 Thread Jonathan Riddell
Description --- kicontheme does not find any icon themes because it misses the trailing slash on the directory name Diffs - tier3/kiconthemes/src/kicontheme.cpp 33261fe Diff: http://git.reviewboard.kde.org/r/113846/diff/ Testing --- Thanks, Jonathan Riddell

Re: Review Request 113846: fix kicontheme::list

2013-11-14 Thread Jonathan Riddell
://git.reviewboard.kde.org/r/113846/diff/ Testing --- Thanks, Jonathan Riddell

Re: Review Request 113841: kcm locale: use kcmshell5

2013-11-14 Thread Jonathan Riddell
, Jonathan Riddell

Review Request 113853: port kcm icons to KF5

2013-11-14 Thread Jonathan Riddell
kcontrol/icons/iconthemes.cpp 9899686 kcontrol/icons/main.h 066080d kcontrol/icons/main.cpp c98d78a Diff: http://git.reviewboard.kde.org/r/113853/diff/ Testing --- Thanks, Jonathan Riddell

Re: Review Request 113853: port kcm icons to KF5

2013-11-14 Thread Jonathan Riddell
kcontrol/icons/icons.desktop d594788 kcontrol/icons/icons.h 1217c99 kcontrol/CMakeLists.txt 6e6d593 Diff: http://git.reviewboard.kde.org/r/113853/diff/ Testing --- Thanks, Jonathan Riddell

Re: Review Request 113853: port kcm icons to KF5

2013-11-14 Thread Jonathan Riddell
-mail. To reply, visit: http://git.reviewboard.kde.org/r/113853/#review43666 --- On Nov. 14, 2013, 4:26 p.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail

Re: Review Request 113853: port kcm icons to KF5

2013-11-14 Thread Jonathan Riddell
Diff: http://git.reviewboard.kde.org/r/113853/diff/ Testing --- Thanks, Jonathan Riddell

Re: Review Request 113839: kcmshell: change internal references to kcmshell5

2013-11-14 Thread Jonathan Riddell
://git.reviewboard.kde.org/r/113839/diff/ Testing --- Thanks, Jonathan Riddell

Re: Review Request 114999: Add KF5 namespace to dbus interface

2014-01-14 Thread Jonathan Riddell
8746551 src/org.kde.kf5kglobalaccel.Component.xml PRE-CREATION src/org.kde.kglobalaccel.Component.xml ec21201 Diff: https://git.reviewboard.kde.org/r/114999/diff/ Testing --- Thanks, Jonathan Riddell

Review Request 115056: rename knotifications StatusNotifierItem dbus interface in kde-workspace

2014-01-16 Thread Jonathan Riddell
, Jonathan Riddell

Re: Review Request 115056: rename knotifications StatusNotifierItem dbus interface in kde-workspace

2014-01-16 Thread Jonathan Riddell
Diff: https://git.reviewboard.kde.org/r/115056/diff/ Testing --- Thanks, Jonathan Riddell

Re: Review Request 114999: Add KF5 namespace to dbus interface

2014-01-16 Thread Jonathan Riddell
PRE-CREATION src/org.kde.KGlobalAccel.xml 8746551 src/org.kde.kf5kglobalaccel.Component.xml PRE-CREATION src/org.kde.kglobalaccel.Component.xml ec21201 Diff: https://git.reviewboard.kde.org/r/114999/diff/ Testing --- Thanks, Jonathan Riddell

Re: Review Request 115001: add kf5 namespace to kglobalaccel dbus interface

2014-01-16 Thread Jonathan Riddell
://git.reviewboard.kde.org/r/114999/ https://git.reviewboard.kde.org/r/115000/ Diffs - kcontrol/keys/CMakeLists.txt 072e614 kcontrol/keys/kglobalshortcutseditor.cpp ca11fcd Diff: https://git.reviewboard.kde.org/r/115001/diff/ Testing --- Thanks, Jonathan Riddell

Review Request 115079: don't install dbus interface files in kglobalaccel

2014-01-17 Thread Jonathan Riddell
-workspace Description --- to go with https://git.reviewboard.kde.org/r/115078/ use local dbus interface files Diffs - Diff: https://git.reviewboard.kde.org/r/115079/diff/ Testing --- Thanks, Jonathan Riddell

Re: Review Request 115079: don't install dbus interface files in kglobalaccel

2014-01-21 Thread Jonathan Riddell
--- Thanks, Jonathan Riddell

Re: Review Request 115079: don't install dbus interface files in kglobalaccel

2014-01-21 Thread Jonathan Riddell
kcontrol/keys/CMakeLists.txt 072e614 Diff: https://git.reviewboard.kde.org/r/115079/diff/ Testing --- Thanks, Jonathan Riddell

Re: Review Request 115079: don't install dbus interface files in kglobalaccel

2014-01-21 Thread Jonathan Riddell
/#review47586 --- On Jan. 21, 2014, 12:48 p.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115079

Re: Review Request 115079: don't install dbus interface files in kglobalaccel

2014-01-21 Thread Jonathan Riddell
072e614 Diff: https://git.reviewboard.kde.org/r/115079/diff/ Testing --- Thanks, Jonathan Riddell

Re: Review Request 115079: don't install dbus interface files in kglobalaccel

2014-01-21 Thread Jonathan Riddell
://git.reviewboard.kde.org/r/115079/diff/ Testing --- Thanks, Jonathan Riddell

Review Request 115188: rename dbus interface file for kjobview

2014-01-21 Thread Jonathan Riddell
--- Thanks, Jonathan Riddell

Review Request 115191: use renamed dbus interface files for kstatusnotifier

2014-01-21 Thread Jonathan Riddell
/115191/diff/ Testing --- Thanks, Jonathan Riddell

Re: Review Request 115191: use renamed dbus interface files for kstatusnotifier

2014-01-22 Thread Jonathan Riddell
4e3724b statusnotifierwatcher/CMakeLists.txt d2ffeec Diff: https://git.reviewboard.kde.org/r/115191/diff/ Testing --- Thanks, Jonathan Riddell

Re: Review Request 115188: rename dbus interface file for kjobview

2014-01-25 Thread Jonathan Riddell
/applicationjobs/CMakeLists.txt 393bc13 Diff: https://git.reviewboard.kde.org/r/115188/diff/ Testing --- Thanks, Jonathan Riddell

Review Request 116956: rename kglobalaccel to kglobalaccel5 for co-installability

2014-03-21 Thread Jonathan Riddell
/kglobalaccel5.notifyrc PRE-CREATION kglobalaccel/main.cpp d788b64 Diff: https://git.reviewboard.kde.org/r/116956/diff/ Testing --- Thanks, Jonathan Riddell

Re: Review Request 116956: rename kglobalaccel to kglobalaccel5 for co-installability

2014-03-25 Thread Jonathan Riddell
/kglobalaccel.desktop a61516e kglobalaccel/org.kde.kglobalaccel.service.in d8576b0 Diff: https://git.reviewboard.kde.org/r/116956/diff/ Testing --- Thanks, Jonathan Riddell

Review Request 117081: Switch to Comme font

2014-03-26 Thread Jonathan Riddell
/ Testing --- Thanks, Jonathan Riddell

Re: Review Request 117081: Switch to Comme font

2014-03-26 Thread Jonathan Riddell
/CMakeLists.txt 460755b plasma-workspace/startkde/startkde.cmake e845603 Diff: https://git.reviewboard.kde.org/r/117081/diff/ Testing --- Thanks, Jonathan Riddell

Review Request 117088: Rename kuiserver to kuiserver5 for co-installability with kdelibs4 kde-runtime

2014-03-26 Thread Jonathan Riddell
/kuiserver.desktop 2d7a874 kuiserver/org.kde.kuiserver.service.in a900b64 Diff: https://git.reviewboard.kde.org/r/117088/diff/ Testing --- Thanks, Jonathan Riddell

Re: Review Request 117088: Rename kuiserver to kuiserver5 for co-installability with kdelibs4 kde-runtime

2014-03-26 Thread Jonathan Riddell
, visit: https://git.reviewboard.kde.org/r/117088/#review54206 --- On March 26, 2014, 2:03 p.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit

Review Request 117090: add version to libmolletnetwork

2014-03-26 Thread Jonathan Riddell
: https://git.reviewboard.kde.org/r/117090/diff/ Testing --- Thanks, Jonathan Riddell

Review Request 117092: rename kioslave files for co-installability

2014-03-26 Thread Jonathan Riddell
- kioslave/trash/ktrash.cpp 9d93d15 kioslave/trash/CMakeLists.txt 7c72cdc kioslave/network/mimetypes/CMakeLists.txt c20dc90 kioslave/network/kded/CMakeLists.txt e851f73 Diff: https://git.reviewboard.kde.org/r/117092/diff/ Testing --- Thanks, Jonathan Riddell

Review Request 117093: remove obsolete kconfig_update file

2014-03-26 Thread Jonathan Riddell
://git.reviewboard.kde.org/r/117093/diff/ Testing --- Thanks, Jonathan Riddell

Review Request 117094: remove obsolete drkonqi kconf_update script

2014-03-26 Thread Jonathan Riddell
--- Thanks, Jonathan Riddell

Review Request 117095: rename kdebugdialog to kdebugdialog5 for coinstallability

2014-03-26 Thread Jonathan Riddell
://git.reviewboard.kde.org/r/117095/diff/ Testing --- Thanks, Jonathan Riddell

Review Request 117096: rename khelpcenter to khelpcenter5 for coinstallability

2014-03-26 Thread Jonathan Riddell
khelpcenter/Help.desktop 71505f1 khelpcenter/Help5.desktop PRE-CREATION Diff: https://git.reviewboard.kde.org/r/117096/diff/ Testing --- Thanks, Jonathan Riddell

Review Request 117152: use renamed kf5_entry.desktop file

2014-03-28 Thread Jonathan Riddell
, Jonathan Riddell

Re: Review Request 117081: Switch to Comme font

2014-04-29 Thread Jonathan Riddell
it is ready to use - Jonathan Riddell On March 26, 2014, 12:26 p.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117081

Re: Review Request 117081: Switch to Comme font

2014-04-29 Thread Jonathan Riddell
/startkde/startkde.cmake e845603 Diff: https://git.reviewboard.kde.org/r/117081/diff/ Testing --- Thanks, Jonathan Riddell

Re: Review Request 117096: rename khelpcenter to khelpcenter5 for coinstallability

2014-04-29 Thread Jonathan Riddell
be updated, I couldn't find it alas Diffs - khelpcenter/CMakeLists.txt 01639b4 khelpcenter/Help.desktop 71505f1 khelpcenter/Help5.desktop PRE-CREATION Diff: https://git.reviewboard.kde.org/r/117096/diff/ Testing --- Thanks, Jonathan Riddell

Re: Review Request 117096: rename khelpcenter to khelpcenter5 for coinstallability

2014-04-29 Thread Jonathan Riddell
version is just a new version of the kdelibs4 version, and they should have the same function to the user - Jonathan Riddell On March 26, 2014, 5:57 p.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request 117152: use renamed kf5_entry.desktop file

2014-04-29 Thread Jonathan Riddell
Diff: https://git.reviewboard.kde.org/r/117152/diff/ Testing --- Thanks, Jonathan Riddell

Re: Review Request 117092: rename kioslave files for co-installability

2014-04-29 Thread Jonathan Riddell
/ - Jonathan Riddell On March 26, 2014, 4:36 p.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117092

Re: Review Request 117092: rename kioslave files for co-installability

2014-04-29 Thread Jonathan Riddell
://git.reviewboard.kde.org/r/117092/diff/ Testing --- Thanks, Jonathan Riddell

Re: Review Request 117093: remove obsolete kconfig_update file

2014-04-29 Thread Jonathan Riddell
0874ce2 kurifilter-plugins/ikws/CMakeLists.txt 51294b5 Diff: https://git.reviewboard.kde.org/r/117093/diff/ Testing --- Thanks, Jonathan Riddell

Re: Review Request 117093: remove obsolete kconfig_update file

2014-04-29 Thread Jonathan Riddell
://git.reviewboard.kde.org/r/117861/ - Jonathan Riddell On March 26, 2014, 4:47 p.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117093

Re: Review Request 117094: remove obsolete drkonqi kconf_update script

2014-04-29 Thread Jonathan Riddell
/ - Jonathan Riddell On March 26, 2014, 5:18 p.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117094

Re: Review Request 117094: remove obsolete drkonqi kconf_update script

2014-04-29 Thread Jonathan Riddell
-section.upd 413908f Diff: https://git.reviewboard.kde.org/r/117094/diff/ Testing --- Thanks, Jonathan Riddell

Re: Review Request 117088: Rename kuiserver to kuiserver5 for co-installability with kdelibs4 kde-runtime

2014-04-30 Thread Jonathan Riddell
/ - Jonathan Riddell On March 26, 2014, 2:03 p.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117088

Re: Review Request 117088: Rename kuiserver to kuiserver5 for co-installability with kdelibs4 kde-runtime

2014-04-30 Thread Jonathan Riddell
a724326 kuiserver/kf5_org.kde.kuiserver.service.in PRE-CREATION kuiserver/kuiserver.desktop 2d7a874 kuiserver/org.kde.kuiserver.service.in a900b64 Diff: https://git.reviewboard.kde.org/r/117088/diff/ Testing --- Thanks, Jonathan Riddell

Re: Review Request 118270: [doc] explicitly load external entities (after CVE-2014-0191)

2014-05-28 Thread Jonathan Riddell
://bugs.launchpad.net/ubuntu/+source/kde4libs/+bug/1324066 - Jonathan Riddell On May 23, 2014, 8:24 p.m., Luigi Toscano wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118270

Re: Review Request 118851: Kde-baseapps- KF5 replace generic soversion.

2014-06-23 Thread Jonathan Riddell
.) Review request for Dolphin, KDE Base Apps, Plasma, and Jonathan Riddell. Repository: kde-baseapps Description --- I was ending up with so.SOVERSION when building this, so through some research I have come up with this patch to correct the issue. If there is a better way, please

Oxygen Fonts kdereview remove

2014-07-03 Thread Jonathan Riddell
Plasma 5 is going to default on Oxygen Fonts so we need Oxygen Fonts to move to kde/workspace. It's currently in kdereview and I am using the release-0.4 branch. Please have a look and review. Jonathan

Re: Oxygen Fonts kdereview remove

2014-07-10 Thread Jonathan Riddell
On Wed, Jul 09, 2014 at 11:15:14PM +0200, Albert Astals Cid wrote: El Dijous, 3 de juliol de 2014, a les 15:26:41, Jonathan Riddell va escriure: Plasma 5 is going to default on Oxygen Fonts so we need Oxygen Fonts to move to kde/workspace. It's currently in kdereview and I am using

Re: Oxygen Fonts kdereview remove

2014-07-18 Thread Jonathan Riddell
On Thu, Jul 10, 2014 at 10:29:34PM +0200, Albert Astals Cid wrote: El Dijous, 10 de juliol de 2014, a les 08:58:37, Jonathan Riddell va escriure: On Wed, Jul 09, 2014 at 11:15:14PM +0200, Albert Astals Cid wrote: El Dijous, 3 de juliol de 2014, a les 15:26:41, Jonathan Riddell va escriure

Plasma 5.2 bits for kdereview

2014-12-19 Thread Jonathan Riddell
Plasma 5.2 is due out next month and there's a few KDE projects which would be good to be included. Please review these for inclusion in kde/workspace.. Bluedevil frameworks branch by David Rosca https://projects.kde.org/projects/extragear/base/bluedevil

Re: plasma-mediacenter in kdereview from extragear

2015-02-20 Thread Jonathan Riddell
I took at look at this today and discussed at the Plasma sprint.. - possible legal issues with youtube icon, now fixed - mockcpp pointer to obscure repository cmake message - qtmultimedia needs a this is needed at runtime cmake message - music and video icon are black on black - crashes, at

kio-extras

2015-01-23 Thread Jonathan Riddell
kio-extras is currently released part of Plasma 5. It's need said that it would be better to be part of applications because they're plugins used by applications and typically not by the desktop. With Plasma 5.2 about to go out shall I ask for kio-extras to be moved and if so into which module?

Re: Plasma 5.2 bits for kdereview

2015-01-06 Thread Jonathan Riddell
Updates on this.. I plan to ask for Bluedevil and libbluedevil, libkscreen and kscreen, libmm-qt and ksshaskpass to be moved. I see some comments that the libraries may be used outside of Plasma but there's no problem with that happening, they don't quality for frameworks and they already get

Fwd: Plasma 5.2 bits for kdereview

2015-01-07 Thread Jonathan Riddell
On 6 January 2015 at 15:23, Luigi Toscano luigi.tosc...@tiscali.it wrote: Jonathan Riddell ha scritto: Updates on this.. I plan to ask for Bluedevil and libbluedevil, libkscreen and kscreen, libmm-qt and ksshaskpass to be moved. I see some comments that the libraries may be used

Re: Plasma 5.2 bits for kdereview

2015-01-08 Thread Jonathan Riddell
wrote: Jonathan Riddell ha scritto: On 6 January 2015 at 15:23, Luigi Toscano luigi.tosc...@tiscali.it mailto:luigi.tosc...@tiscali.it wrote: A A Jonathan Riddell ha scritto: Updates on this.. I plan to ask for Bluedevil and libbluedevil

Re: [kde-frameworks-devel] Review request: QBluez

2015-03-11 Thread Jonathan Riddell
On Mon, Feb 16, 2015 at 10:40:44AM +0100, David Rosca wrote: Hi all, I'd like to ask for a review of the QBluez library [1]. Looks like you've been working hard :) The name KF5BluezQt seems inelegant, is has both a prefix and a suffix, how about just KF5Bluez ? The headers get installed into

Re: Review request: QBluez

2015-03-12 Thread Jonathan Riddell
Please file a sysadmin request to move it into kdereview, then after a couple of weeks if there's no objections it can be moved into kde/workspace (for plasma). Jonathan

Re: Review request: QBluez

2015-03-12 Thread Jonathan Riddell
On Thu, Mar 12, 2015 at 08:23:22PM +0100, David Rosca wrote: Done. It's in kdereview now: https://projects.kde.org/projects/kdereview/bluez-qt Woo, lovely. Best post to plasma-devel about that (it's been posted around lots already but best to cover all the bases I guess.) Do you expect the

Re: Release Dates for August

2015-04-14 Thread Jonathan Riddell
/Schedules/Applications/15.08_Release_Schedule Simplified release cycle, beta 3 weeks before release, rc 2 weeks before, tagging 1 week before, all on Wednesdays. release on August 19th Any comments welcome (preferably on release-team@) Jonathan On 30 March 2015 at 17:32, Jonathan Riddell j

Re: Moving User Manager back to playground

2015-04-09 Thread Jonathan Riddell
On Thu, Apr 09, 2015 at 10:31:41PM +0200, Vishesh Handa wrote: On Thu, Apr 9, 2015 at 10:02 PM, Jonathan Riddell j...@jriddell.org wrote: Ug please don't.A It'll mess up my release scripts and the translations.A Stuff in playground shouldn't get releases but this does

kwallet-pam for kdereview

2015-08-20 Thread Jonathan Riddell
This has now moved to kde/workspace and will be released with plasma 5.4 Jonathan

Re: Plasma Applet for Audio Volume for kdereview

2015-08-20 Thread Jonathan Riddell
This has now been moved to kde/workspace and will be released with Plasma 5.4 On Wed, Aug 05, 2015 at 12:45:01PM +, Jonathan Riddell wrote: plasma-pa is a new volume manager and is intended to be a replacement for KMix in Plasma. We plan to ship it as a beta in Plasma 5.4 and it's

Re: kdesudo in git

2015-08-20 Thread Jonathan Riddell
On Thu, Aug 20, 2015 at 01:34:42PM +0200, Luigi Toscano wrote: On Thursday 20 of August 2015 12:16:55 Jonathan Riddell wrote: I've just moved kdesudo into playground playground/utils/kdesudo it has a bunch of translations from its previous home on Launchpad. Could

Re: kdesudo in git

2015-08-20 Thread Jonathan Riddell
On Thu, Aug 20, 2015 at 02:01:58PM +0200, Luigi Toscano wrote: Maybe it's possible to change kdesu to expose a please cache this property between backend and frontend (in a secure way). Better than keeping two programs for exactly the same thing. I couldn't work out a secure and easy way to

Plasma Applet for Audio Volume for kdereview

2015-08-05 Thread Jonathan Riddell
plasma-pa is a new volume manager and is intended to be a replacement for KMix in Plasma. We plan to ship it as a beta in Plasma 5.4 and it's currently in kdereview for your reviewing attention. https://projects.kde.org/projects/kdereview/plasma-pa Please check over it and consider if it

kwallet-pam for kdereview

2015-08-05 Thread Jonathan Riddell
kwallet-pam is a simple PAM module to open your wallet. We'd like to ship it in Plasma 5.4. It was previously in a scratch repository but shipped by distros such as Kubuntu and Fedora. It's about to go into kdereview and we'd appreciate your considered perusal.

Re: New repo for review: Breeze GTK

2015-10-23 Thread Jonathan Riddell
On 23 October 2015 at 14:07, David Edmundson wrote: > Repo contains GTK 2 and GTK 3 themes which are similar to Breeze. awooga :) > i18n - I've not set branches in p.k.o as there are no translations. GTK > theme names seem to be used as-is. seems sensible >

plasma-sdk in kdereview

2015-10-07 Thread Jonathan Riddell
Plasma SDK contains a few handy developers tools for Plasma plasmathemeexplorer, plasmoidviewer, plasmaengineexplorer and the icon browser cuttlefish It gets released with Plasma but is still in extragear. I'd like to move it to kde/workspace in git and I've just asked for it to be moved into

Re: kde-build-metadata for beta branches

2015-11-22 Thread Jonathan Riddell
On Sat, Nov 21, 2015 at 04:28:06PM +0530, Bhushan Shah wrote: > On Sat, Nov 21, 2015 at 4:24 PM, Jonathan Riddell <j...@jriddell.org> wrote: > > Can I change kde-build-metadata to Plasma/5.5 while the branch is in > > stable or will that mess up other uses of kde-build-meta

kde-build-metadata for beta branches

2015-11-21 Thread Jonathan Riddell
I've branched Plasma for the 5.5 beta and will make a final release in a couple of weeks. Before I make the final release I want to check in build.kde.org if it has any complaints in builds of the Plasma/5.5 branch. But build.kde.org currently uses kde-build-metadata points only to master and to

Re: Product versions on bugs.kde.org

2016-03-07 Thread Jonathan Riddell
On Mon, Mar 07, 2016 at 09:25:40AM +0100, Kevin Funk wrote: > Is there a way to batch-modify those versions? Obviously noone wants to go > through the Bugzilla UI, adding versions one-by-one for each(!) framework. > /me found [1]. > > PS: It's not just the case for frameworks, same applies to

Re: announcement: plymouth-kcm in kdereview

2017-01-05 Thread Jonathan Riddell
On 5 January 2017 at 15:03, Marco Martin <notm...@gmail.com> wrote: > On Thursday 05 January 2017 12:30:38 Jonathan Riddell wrote: >> It should rather follow Plasma practice and set these in the top cmake file >> set(PROJECT_VERSION "5.8.90") >> set(P

Re: announcement: plymouth-kcm in kdereview

2017-01-05 Thread Jonathan Riddell
On Thu, Dec 29, 2016 at 12:58:10PM +0100, Marco Martin wrote: > Hi all, > announcing a new KCM module to change the plymouth splash screen > The repository is named plymouth-kcm and is headed for kdereview now. > its final resting place would be the workspace area, to be released in sync > with

Re: imagewriter in kdereview

2017-04-10 Thread Jonathan Riddell
On 8 April 2017 at 17:22, Albert Astals Cid <aa...@kde.org> wrote: > El divendres, 7 d’abril de 2017, a les 15:21:20 CEST, Jonathan Riddell va > escriure: >> Please review imagewriter which I've just had moved to kdereview. > > It doesn't build https://paste.kde.org/p

Re: imagewriter in kdereview

2017-04-08 Thread Jonathan Riddell
On 7 April 2017 at 20:14, Luigi Toscano wrote: > Does it mean that the make-it-cool branch will be merged to master soon? > The current master has no support for KI18n (and not even for > ecm_install_po_files_as_qm). I think that it's better to wait until it's > merged

imagewriter in kdereview

2017-04-07 Thread Jonathan Riddell
Please review imagewriter which I've just had moved to kdereview. It's a simple tool to write ISO images to a USB key. It should be cross platform and work on Linux, mac, windows. It's based on ROSA Image Writer and the ROSA maintainer has agreed to maintain it in KDE. Compared to ROSA I've

libqaccessibilityclient now in kdereview

2017-07-25 Thread Jonathan Riddell
libqaccessibilityclient is now in kdereview. It's in a git repo called libkdeaccessibilityclient but we filed a sysadmin request to rename it. We just released 0.2.0 in unstable (for some reason 0.1.1 was released in stable some years ago). What is it? Since it's hard to grasp all the

Re: Zanshin is in kdereview

2017-06-12 Thread Jonathan Riddell
On 10 June 2017 at 14:08, Kevin Ottens wrote: >> You have a release script in scripts/release.sh, consider using >> kde:releaseme as extracting translations can be quite faffy and >> releaseme does all that for you. > > I tried that recently but didn't manage to get it to work at

Re: clazy is in kdereview

2017-06-21 Thread Jonathan Riddell
On 16 June 2017 at 15:24, Sérgio Martins wrote: > clazy is a clang plugin which allows clang to understand Qt semantics. > You get more than 50 Qt related compiler warnings, ranging from > unneeded memory allocations to misusage of API, including fix-its for > automatic

who is authorised to move repos around?

2017-06-21 Thread Jonathan Riddell
I'm unclear who is authorised to move git repos around, e.g. from playground to kdereview to kde-extra It used to be only sysadmins which seems like a political burden on a tech team. Now anyone can edit repo-metadata. So can anyone move repos around as long as rules and conventions are

Re: kdereview - qtcurve

2017-06-21 Thread Jonathan Riddell
On 16 June 2017 at 16:07, Yichao Yu wrote: > QtCurve is now in kdereview with the intention of being in extragear/base You should set the stable branch to 1.9 in repo-metadata and ask translator admins to make a stable branch for translations Jonathan

Re: Moving AtCore to Extragear

2017-06-21 Thread Jonathan Riddell
On 18 June 2017 at 13:48, Lays Rodrigues wrote: > Hey guys, good morning. =D > Any more comments on AtCore code? > How the moving to Extragear work? As discussed it should already be in kdereview, then it can go into extragear See README.md in

Re: Zanshin is in kdereview

2017-06-19 Thread Jonathan Riddell
On Mon, Jun 19, 2017 at 09:36:39PM +0200, Kevin Ottens wrote: > Hello, > > On Monday, 12 June 2017 16:48:26 CEST Jonathan Riddell wrote: > > On 10 June 2017 at 14:08, Kevin Ottens <er...@kde.org> wrote: > > >> You have a release script in scripts/release.sh, co

Re: Moving AtCore to Extragear

2017-06-23 Thread Jonathan Riddell
On Fri, Jun 23, 2017 at 08:22:39AM +1200, Ben Cooksley wrote: > On Fri, Jun 23, 2017 at 7:56 AM, Luigi Toscano > wrote: > > Albert Astals Cid ha scritto: > >> El diumenge, 18 de juny de 2017, a les 9:48:07 CEST, Lays Rodrigues va > >> escriure: > >>> Hey guys, good

Re: Kirigami in Frameworks

2017-06-21 Thread Jonathan Riddell
On 21 June 2017 at 15:00, Marco Martin wrote: > As there were no replies for quite a while, i assume there are no > particular objections. > > so, how to proceed? what needs to be doe to do the actual move? Does it comply with the policies (as much as they are relevant for

  1   2   >