Re: kdelibs, kdebase moving to Git this Saturday

2011-01-30 Thread Marco Martin
-workspace git://anongit.kde.org/scratch/ianmonroe/konsole in the runtime repository, the pics directory doesn't seem available, but the main CMakelist.txt still looks for it. Cheers, Marco Martin

Re: kdelibs, kdebase moving to Git this Saturday

2011-01-30 Thread Marco Martin
On Sunday 30 January 2011, Tom Albers wrote: - Original Message - On 1/30/2011 1:17 PM, Marco Martin wrote: in the runtime repository, the pics directory doesn't seem available, but the main CMakelist.txt still looks for it. kde-runtime is currently set read-only

Re: the next step on the desktop

2011-01-31 Thread Marco Martin
and things like that in one or two guinea pigs applications ;) Cheers, Marco Martin

Re: the next step on the desktop

2011-01-31 Thread Marco Martin
when closed on a bigger screen gets started on the small one? Cheers, Marco Martin

Re: prison - a barcode library now in kdereview

2011-02-16 Thread Marco Martin
phone) I have also heard of someone with ideas for a barcode flake for calligra. Might it also be useful for downloading plasmoids with plasma-mid? eh, why not :) Cheers, Marco Martin

Re: KShutdown got to kde-runtime without review

2011-02-20 Thread Marco Martin
this things get reviewed? just announcing here that there is the plasma/declarative branch in kdelibs that should be merged? Cheers, Marco Martin

Re: KShutdown got to kde-runtime without review

2011-02-21 Thread Marco Martin
On Monday 21 February 2011, Albert Astals Cid wrote: A Diumenge, 20 de febrer de 2011, Marco Martin va escriure: On Wednesday 16 February 2011, Albert Astals Cid wrote: Why? Albert Speaking of which, what is the policy now? I have in a branch of kdelibs a little library

Re: KShutdown got to kde-runtime without review

2011-02-22 Thread Marco Martin
. that way things come to me with zero effort. OTOH if you volunteer to maintain that wiki as second source of information i don't see a problem. Cheers, Marco Martin

Re: Review of the branch plasma/declarative in kdelibs

2011-02-23 Thread Marco Martin
this implementation detail, yes, the point of qtcomponents is to give a common api to allow platform specific implementations rather than one set of widgets to rule them all Cheers, Marco Martin

Re: Review of the branch plasma/declarative in kdelibs

2011-02-23 Thread Marco Martin
On Tuesday 22 February 2011, Ian Monroe wrote: On Tue, Feb 22, 2011 at 14:41, Marco Martin notm...@gmail.com wrote: Hi all, in kdelibs there is since some time a branch called plasma/declarative that contains a new little library, that depends at the moment on kdecore and kdeui (probably

Re: Review of the branch plasma/declarative in kdelibs

2011-02-23 Thread Marco Martin
On Tuesday 22 February 2011, Stephen Kelly wrote: Marco Martin wrote: Hi all, in kdelibs there is since some time a branch called plasma/declarative that contains a new little library, that depends at the moment on kdecore and kdeui (probably is possible to make it depend only from

Re: Review Request: Add support for building libplasma with GLES2

2011-02-25 Thread Marco Martin
as deprecated, the mobile profile would have it already removed and that's good ;) Cheers, Marco Martin

Re: Profiles for all KDE-applications

2011-02-27 Thread Marco Martin
the workspace kcm directly modifies the kwin config file when the netbook shell is activated, that's not really optimal) Cheers, Marco Martin

Re: Review Request: Add support for building libplasma with GLES2

2011-02-28 Thread Marco Martin
, to me the patch seems good. Cheers, Marco Martin

Re: Review of the branch plasma/declarative in kdelibs

2011-03-28 Thread Marco Martin
On Tuesday 22 February 2011, Stephen Kelly wrote: Marco Martin wrote: Hi all, in kdelibs there is since some time a branch called plasma/declarative that contains a new little library, that depends at the moment on kdecore and kdeui (probably is possible to make it depend only from

Re: Review of the branch plasma/declarative in kdelibs

2011-04-03 Thread Marco Martin
will still be possible until it exits from that folder. going to land monday if no one speaks up Cheers, Marco Martin

Re: Qt5 - KDE5?

2011-05-09 Thread Marco Martin
mean qgraphicsproxywidgets screw up all over again, just worse since would become the *only* way. Cheers, Marco Martin

Re: Qt5 - KDE5?

2011-05-11 Thread Marco Martin
against the mobile profile, that already excludes most of deprecated api, so the day deprecated app will go away from the code it will be less painful ;) (several main kde modules are already covered, some of them still have some issues) -- Marco Martin

Re: Qt5 - KDE5?

2011-05-11 Thread Marco Martin
with a QWidget or directly in OpenGL.) GL it is then :-) but i gather that won't be possible to mix arbitrary opengl scenes with scenegraph items? or will it be? -- Marco Martin

Re: [4.7 Beta1 blocker] plasma depending on kdelibs/experimental

2011-05-21 Thread Marco Martin
tiny, i would say for 4.7 libplasma should just statically link to that couple of cpp files of that library.. -- Marco Martin

Re: [4.7 Beta1 blocker] plasma depending on kdelibs/experimental

2011-05-25 Thread Marco Martin
On Saturday 21 May 2011, Marco Martin wrote: I now discover this to be broken in master: plasma/widgets/declarativewidget.cpp requires kdeclarative.h which comes from libkdedeclarative in kdelibs/experimental Is the previous rule no longer valid? otherwise, how to deal

Re: libkactivities moved to kactivities repository

2011-09-15 Thread Marco Martin
have to be ported to 4.7 if we want to use that branch: the changes to packageStructure, otherwise no launcher, no activity switcher, no recommendations overlay :/ Cheers, Marco Martin

Re: libkactivities moved to kactivities repository

2011-09-15 Thread Marco Martin
On Thursday 15 September 2011, Marco Martin wrote: On Wednesday 14 September 2011, Aaron J. Seigo wrote: hi... the library in kdelibs/experimental/libkactivities has been moved to a separate git repository: kactivities. the reason for this is two fold: ther is still one important

small license problem in kdelibs

2011-09-26 Thread Marco Martin
Hi all, last days, after we asked some more pair of eyes to check the licensing in plasma active, a thing was discovered: many LGPL licensed files had an header like that (you know, power of copy and paste ;) /* * Copyright 2010 Marco Martin notm...@gmail.com * * This program is free

Re: The future of Power Management - together with Activities

2011-10-01 Thread Marco Martin
it? More suggestions? Speak now or shut up forever! yes, i like tying them to activities.. basically the profile config ui would stay, but save only activity-specific settings? Cheers, Marco Martin

Re: The future of Power Management - together with Activities

2011-10-01 Thread Marco Martin
. You can still configure profiles for battery states (namely: Performance, Powersave, Aggressive Powersave) as you were doing before, except now they are tied 1:1 with the battery state. In addition, you can define activity-specific behavior. I think that's a big +1 from here ;) Cheers, Marco

Re: Review Request: Add fromTheme property to QIconItem in QtExtraComponents for theme icons in QML

2011-11-01 Thread Marco Martin
://git.reviewboard.kde.org/r/103009/#comment6740 since here only write makes sense, you need a method - Marco Martin On Oct. 31, 2011, 9:27 p.m., Mark Gaiser wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request: Add fromTheme property to QIconItem in QtExtraComponents for theme icons in QML

2011-11-01 Thread Marco Martin
On Nov. 1, 2011, 3:09 p.m., Aaron J. Seigo wrote: plasma/declarativeimports/qtextracomponents/qiconitem.h, line 31 http://git.reviewboard.kde.org/r/103009/diff/1/?file=39961#file39961line31 could these be automatically detected? e.g. if it can't be resolved into a path to an

Re: Review Request: Improved Button.qml in PlasmaComponents

2011-11-01 Thread Marco Martin
. the leftmargin binding is correct tough - Marco Martin On Nov. 1, 2011, 7:01 p.m., Mark Gaiser wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103020

Re: Review Request: Improved Button.qml in PlasmaComponents

2011-11-01 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103020/#review7844 --- Ship it! - Marco Martin On Nov. 1, 2011, 9:20 p.m., Mark

Re: Review Request: Add fromTheme property to QIconItem in QtExtraComponents for theme icons in QML

2011-11-02 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103009/#review7879 --- Ship it! let's go for it ;) - Marco Martin On Nov. 1, 2011

Introducing components, how to

2011-11-09 Thread Marco Martin
Cheers, Marco Martin

Re: Introducing components, how to

2011-11-10 Thread Marco Martin
and documented it on http://techbase.kde.org/KDE_System_Administration/Environment_Variables if set, it overrides the configuration value -- Marco Martin

Re: Review Request: Fix KStatusNotifierItem not updating its icon when set by pixmap

2011-12-16 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103425/#review8990 --- Ship it! good catch - Marco Martin On Dec. 15, 2011, 11:09

Re: Review Request: Fïx two little bugs: one with default contrast settings and one with plasma popup alignment.

2011-12-26 Thread Marco Martin
the off by one positioning. the contrast value, i don't really get a reason (and should be done in another commit anyways) - Marco Martin On Dec. 24, 2011, 5:35 p.m., Nikita Churaev wrote: --- This is an automatically generated e-mail

Re: Review Request: Make ksmserver not wait for kcminit if compiled with mobile profile

2012-02-23 Thread Marco Martin
that knows better this particular area, also because adding ifdefs is not particularly pretty, so may or may not be an issue - Marco Martin On Feb. 23, 2012, 7:54 p.m., Lamarque Vieira Souza wrote: --- This is an automatically generated e

kdelibs/Qt 4.8

2012-04-10 Thread Marco Martin
;) -- Marco Martin

Re: Proposed adjustments to our release cycles

2012-06-16 Thread Marco Martin
there are a lot of technical details how work out this, like how to manage translations Cheers, Marco Martin

Re: RFC: Moving KWallet Password dialog into Plasma

2012-07-23 Thread Marco Martin
. as already said by others i'm fine with it (nice idea) if the fallback case in which kwallet isn't running in a plasma workspace is considered (or even just if the shell used even if based on plasma doesn't support this feature) Cheers, Marco Martin

Review Request: Use a qml based screen locker in place of the screensaver

2012-08-22 Thread Marco Martin
/screensaver/shell/savercorona.cpp 6f83859 plasma/screensaver/shell/saverview.cpp b6a709e powerdevil/daemon/CMakeLists.txt 35a4fd4 startkde.cmake 36f23f1 Diff: http://git.reviewboard.kde.org/r/106124/diff/ Testing --- Thanks, Marco Martin

Re: Review Request: Use a qml based screen locker in place of the screensaver

2012-08-22 Thread Marco Martin
/shell/savercorona.h 794e50c plasma/screensaver/shell/savercorona.cpp 6f83859 plasma/screensaver/shell/saverview.cpp b6a709e powerdevil/daemon/CMakeLists.txt 35a4fd4 startkde.cmake 36f23f1 Diff: http://git.reviewboard.kde.org/r/106124/diff/ Testing --- Thanks, Marco Martin

Re: Review Request: Use a qml based screen locker in place of the screensaver

2012-08-22 Thread Marco Martin
--- On Aug. 22, 2012, 6:07 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106124

Re: Review Request: Use a qml based screen locker in place of the screensaver

2012-08-27 Thread Marco Martin
, 11:30 a.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106124/ --- (Updated Aug. 24, 2012, 11:30 a.m

Re: Review Request: Use a qml based screen locker in place of the screensaver

2012-09-13 Thread Marco Martin
/diff/ Testing --- Thanks, Marco Martin

Re: Review Request: Use a qml based screen locker in place of the screensaver

2012-09-16 Thread Marco Martin
://git.reviewboard.kde.org/r/106124/#review19008 --- On Sept. 13, 2012, 12:17 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: http

Re: Review Request: Use a qml based screen locker in place of the screensaver

2012-09-19 Thread Marco Martin
locker through D-Bus. Of course for new installations the shortcut needs to be moved to the new architecture. Marco Martin wrote: could a kconfig update script do the trick? Martin Gräßlin wrote: doubt it, have a look at plasma/desktop/shell/plasmaapp.cpp line 134 ff i tried

Re: Review Request: Use a qml based screen locker in place of the screensaver

2012-09-19 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106124/#review18681 --- On Sept. 19, 2012, 4:57 p.m., Marco Martin wrote: --- This is an automatically

Re: Review Request: Use a qml based screen locker in place of the screensaver

2012-09-19 Thread Marco Martin
locker through D-Bus. Of course for new installations the shortcut needs to be moved to the new architecture. Marco Martin wrote: could a kconfig update script do the trick? Martin Gräßlin wrote: doubt it, have a look at plasma/desktop/shell/plasmaapp.cpp line 134 ff Marco Martin

Re: Review Request: Make it possible to use QtCreator QML profiler and debugger with KDE Applications

2012-09-21 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106527/#review19270 --- Ship it! +1 from me - Marco Martin On Sept. 21, 2012, 3:29

Re: Review Request: Use a qml based screen locker in place of the screensaver

2012-09-22 Thread Marco Martin
On Sept. 8, 2012, 12:11 p.m., Oswald Buddenhagen wrote: ksmserver/screenlocker/DESIGN, line 13 http://git.reviewboard.kde.org/r/106124/diff/3/?file=83586#file83586line13 xembe[]ds this sounds funny. the saver window is on top of the greeter? Marco Martin wrote

Re: Review Request: Use a qml based screen locker in place of the screensaver

2012-09-26 Thread Marco Martin
--- On Sept. 19, 2012, 4:57 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106124

Re: Review Request: Use a qml based screen locker in place of the screensaver

2012-10-03 Thread Marco Martin
--- On Sept. 19, 2012, 4:57 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106124

Re: Review Request: miscelaneous things for kdelibs/plasma

2012-10-10 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106782/#review20151 --- Ship it! Ship It! - Marco Martin On Oct. 10, 2012, 3:41

Re: Review Request: QML Plasma Components - fix for bug in ScrollBar anchoring

2012-12-09 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107622/#review23192 --- Ship it! good catch, sorry for the late reply - Marco Martin

Re: Review Request: try fix tooltip shadow problem

2012-12-26 Thread Marco Martin
shadow-removeWindow(tipWidget); just after tipWidget-hide();, that is more correct than removing that line. so ship it (in both KDE/4.10 branch and master) provided this change is done - Marco Martin On Dec. 25, 2012, 12:14 a.m., Xuetian Weng wrote

Re: Review Request: Don't add qml elements twice to the scene, reduce warnings

2013-01-02 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108079/#review24434 --- Ship it! Ship It! - Marco Martin On Jan. 2, 2013, 2:20 p.m

Re: Review Request: qml based kwin shadow

2013-01-07 Thread Marco Martin
advantages and disadvantages so your call ;) - Marco Martin On Jan. 7, 2013, 5:49 p.m., Xuetian Weng wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108243

Re: New lockscreen

2013-01-10 Thread Marco Martin
reproduce them at all. however not all of those are valid i think (the concept is: is a screenlocker, not a screensaver anymore, thus makes behavior changes) Cheers, Marco Martin

Re: New lockscreen

2013-01-11 Thread Marco Martin
On Friday 11 January 2013, Martin Sandsmark wrote: On Thu, Jan 10, 2013 at 09:46:11PM +0100, Marco Martin wrote: 311571 and 312427 should be fixed now Thanks! some bugs seems easy, some i can'r reproduce them at all. Which ones can't you reproduce? I can look at them this evening

Re: New lockscreen

2013-01-11 Thread Marco Martin
supported -- Marco Martin

Re: Plans for SVN infrastructure shutdown

2013-02-07 Thread Marco Martin
.. suggestions for those? Cheers, Marco Martin

Re: Review Request 108860: Plasma QML Components: trigger appearAnimation in InlineDialog properly

2013-02-08 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108860/#review26966 --- Ship it! Ship It! - Marco Martin On Feb. 8, 2013, 4:01 p.m

Re: Review Request 110118: wrong path for plugin. ( doubling the plugin address cause the basepath to )

2013-05-03 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110118/#review31957 --- Ship it! Ship It! - Marco Martin On April 21, 2013, 6:18

Review Request 110482: Move KStatusNotifierItem in KNotifications

2013-05-17 Thread Marco Martin
/ Testing --- Thanks, Marco Martin

Re: Review Request 110482: Move KStatusNotifierItem in KNotifications

2013-05-17 Thread Marco Martin
://git.reviewboard.kde.org/r/110482/diff/ Testing --- Thanks, Marco Martin

Re: Review Request 111992: Activity bar in QML.

2013-08-12 Thread Marco Martin
On Aug. 12, 2013, 8:50 a.m., Marco Martin wrote: plasma/generic/applets/activitybar/package/contents/ui/main.qml, line 37 http://git.reviewboard.kde.org/r/111992/diff/5/?file=178116#file178116line37 whitespace s your friend for (i=0; iactivitySource.sources.length; i

Re: Review Request 111992: Activity bar in QML.

2013-08-12 Thread Marco Martin
be rotated 90° - Marco Martin On Aug. 12, 2013, 3:14 a.m., Bhushan Shah wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111992

Re: Review Request 112129: Make Plasma::PackageStructure look for metadata.desktop files in only subfolder of extracted plasmapkg archives

2013-08-17 Thread Marco Martin
with metadata.desktop in the root, this would basically allow a quirks mode, do we want to support malformed packages? - Marco Martin On Aug. 17, 2013, 3:06 a.m., Jeremy Paul Whiting wrote: --- This is an automatically generated e-mail

Re: Review Request 112128: Fix plasmapkg -t theme -r ThemeName to actually uninstall the theme.

2013-08-21 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112128/#review38285 --- Ship it! looks good to me - Marco Martin On Aug. 17, 2013

Re: QML-using app developers: use private.* imports

2013-09-26 Thread Marco Martin
contract that maintaining a library means -- Marco Martin

Re: Adopting AppData in KDE?

2013-11-05 Thread Marco Martin
of installing from repositories and a semi-automated import of assets based on the metadata of existing applications Cheers, Marco Martin

Re: Adopting AppData in KDE?

2013-11-06 Thread Marco Martin
, this was done to give each device its own store. So stores are done in a way that the definition of a store takes very little space in the database and is very fast to clone (and if the same category is in multiple stores items in it stay in sync between stores) cheers, Marco Martin

Review Request 113885: 3 types of blur

2013-11-15 Thread Marco Martin
/kwindowsystem/src/kwindoweffects_x11.cpp 9e3fba7 Diff: http://git.reviewboard.kde.org/r/113885/diff/ Testing --- Thanks, Marco Martin

Re: Review Request 113885: 3 types of blur

2013-11-20 Thread Marco Martin
--- On Nov. 15, 2013, 2:54 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113885

Re: Nepomuk in 4.13 and beyond

2013-12-13 Thread Marco Martin
was a bit worrying.. however with this moving forward, I'm a good deal less worried now :D That said, I fear there may be features that get lost, especially for active, I'll discuss those in the appropriate branch of the thread Cheers, Marco Martin

Re: Nepomuk in 4.13 and beyond

2013-12-13 Thread Marco Martin
, email metadata etc can be stored wherever is also important having more flexible queries, like sql directly exposed (in plasma active i *need* to have group by, that's the reason we used directly sparql in some queries) Cheers, Marco Martin

Re: Nepomuk in 4.13 and beyond

2013-12-13 Thread Marco Martin
that tells I'm doing way too much javascript lately :p) Cheers, Marco Martin

Re: Splitting kde-workspace and kde-runtime proposal

2014-01-21 Thread Marco Martin
that the more splitting the more not my problem, i'll ignore this bit scenario it may cause -- Marco Martin

Re: Review Request 113885: 3 types of blur

2014-01-25 Thread Marco Martin
78195ac tier1/kwindowsystem/src/kwindoweffects_dummy.cpp ce3b9bf tier1/kwindowsystem/src/kwindoweffects_x11.cpp 9e3fba7 Diff: https://git.reviewboard.kde.org/r/113885/diff/ Testing --- Thanks, Marco Martin

Re: KDE Frameworks Release Cycle

2014-04-28 Thread Marco Martin
, on the other hand, I really like the discipline that this methos requires, it may well drive to a good quality increase -- Marco Martin

Re: KF5 Maintainers: Please get ready for release

2014-04-28 Thread Marco Martin
On Sunday 27 April 2014, Kevin Ottens wrote: Marco Martin: - kdeclarative - plasma-framework I think it's pretty fine on my part, i'll take another review on the metadata files. one thing I think i need are toplevel bugzilla products for each framework, right? (if so i'll open a sysadmin

Re: Compatibility problems with latest GTK+ applications

2014-05-07 Thread Marco Martin
(at least supporting the required hints) * leaving it as is, giving them a last occasion to fix support for non csd windowmanagers, and if this last attempt at communicating fails (likely) simply exposing and making noise about it, that is sad and will work not much, but still.. -- Marco Martin

Re: Compatibility problems with latest GTK+ applications

2014-05-07 Thread Marco Martin
(at least supporting the required hints) * leaving it as is, giving them a last occasion to fix support for non csd windowmanagers, and if this last attempt at communicating fails (likely) simply exposing and making noise about it, that is sad and will work not much, but still.. -- Marco Martin

Fwd: default wallpapers

2014-06-30 Thread Marco Martin
Forwarding here as I was reminded that is more a kde-core-devel topic. -- Forwarded Message -- Subject: default wallpapers Date: Monday 30 June 2014, 19:09:00 From: Marco Martin notm...@gmail.com To: plasma-de...@kde.org Hi all, besides the breeze wallpaper, there will be 3

Re: Fwd: default wallpapers

2014-07-01 Thread Marco Martin
On Monday 30 June 2014, Marco Martin wrote: besides the breeze wallpaper, there will be 3 extra wallpapers shipped by default, that are the ones that won the contest. the real big question, is: *where to put them?* that's one I don't have an answer at the moment. seems that ideally would have

Re: KDE

2014-07-02 Thread Marco Martin
On Wednesday 02 July 2014, Ben Cooksley wrote: SVN commit 1392026 by bcooksley: Create new plasma-workspace-wallpapers module. As requested by Marco Martin in sysadmin ticket #996. CCMAIL: notm...@gmail.com CCMAIL: kde-core-devel@kde.org A plasma-workspace-wallpapers

Re: Review Request 118180: slideshow BUG patch fix

2014-07-21 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/#review62784 --- modulo the indentation, it should be ok - Marco Martin

Re: Review Request 118180: slideshow BUG patch fix

2014-07-21 Thread Marco Martin
complains about it - Marco Martin On Lug. 21, 2014, 1:12 p.m., TOM Harrison wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180

Re: Review Request 114910: Patch for bug 317066 (systray leaves garbage on the panel when resizing )

2014-07-29 Thread Marco Martin
delicate to just commit - Marco Martin On Gen. 8, 2014, 4:25 p.m., Dmitry Ivanov wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114910

Re: Review Request 114910: Patch for bug 317066 (systray leaves garbage on the panel when resizing )

2014-07-29 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114910/#review63466 --- Ship it! Ship It! - Marco Martin On Jan. 8, 2014, 4:25

Re: Review Request 114910: Patch for bug 317066 (systray leaves garbage on the panel when resizing )

2014-07-29 Thread Marco Martin
On July 29, 2014, 10:31 a.m., Marco Martin wrote: this would require some testing before pushing to 4.x, too delicate to just commit Dmitry Ivanov wrote: Well, I've been living with this patch for half a year already, since January 8 :) I used it with a number of KDE 4.x versions

Re: Closing the kde-core-devel mailing list

2014-08-12 Thread Marco Martin
kde stuff. hmm, I would maybe have seen a reason in doing like the other way around, closing kde-frameworks, merge the mails and move all on k-c-d, since frameworks is released and is the main target of development now -- Marco Martin

Re: Review Request 117175: Fix installing new .comic packages from GHNS to appear in the installed packages list in the comic widget.

2014-08-15 Thread Marco Martin
it in line with plasmapkg2. dead code should be removed before shipping plasma/tools/plasmapkg/main.cpp https://git.reviewboard.kde.org/r/117175/#comment45142 never comment dead code, if it should be removed, should just be deleted - Marco Martin On Apr. 23, 2014, 11:05 p.m., Andrei Amuraritei

Re: Using Gerrit for code review in KDE

2014-09-12 Thread Marco Martin
-- both were done already. As part of the experiment i would also like to try to have stricter acls for +2 and submit, like starting from mantainers then slowly adding people (that's also how i understood it would have worked during the bof) -- Marco Martin

Gerrit: merging feature branches

2014-10-28 Thread Marco Martin
doesn't have id (may be the merge commit in this case?) in the end the nearest i could get is https://gerrit.vesnicky.cesnet.cz/r/#/c/130 Can the feature branch workflow work at all in gerrit or is better to just use master? -- Marco Martin

Re: Adventures in Bodega

2014-11-25 Thread Marco Martin
way, so if is the case our code would have to be adapted -- Marco Martin

Re: Adventures in Bodega

2014-11-25 Thread Marco Martin
tried to setup a local bodega instance on my machine. The documentation is As I suspected there were some API changes in both the redis module and express stuff. I now pushed a quick port that makes the thing at least start. Web stuff is always just like that unfortunately :/ -- Marco Martin

New framework to review: KPackage

2014-12-03 Thread Marco Martin
to access files from it there is also a simple little tool called kpackagetool that can be used to install, remove and list packages. I would like to submit it (kpackage repo) for the usual 2 weeks period of review. -- Marco Martin

Re: New framework to review: KPackage

2014-12-10 Thread Marco Martin
a Q_DISABLE_COPY or similar in PackageLoader done Add const foreach (QString prefix, d-contentsPrefixPaths) { done All those char * params make me a bit unhappy, any reason those are not QString or QByteArray? made them QByteArrays -- Marco Martin

Re: New framework to review: KPackage

2014-12-15 Thread Marco Martin
On Thursday 11 December 2014, Kevin Kofler wrote: Marco Martin wrote: In the past weeks I have been working on a new framework, called KPackage. You ARE aware that KPackage was the name of an old frontend for RPM and other package managers that used to be part of the KDE Software

  1   2   >