Retiring

2021-01-13 Thread Christoph Feck
Hello developers, my personal situation allows for much less time for KDE related work, at least during the Corona times. I would like to retire as soon as possible from these responsibilities: - bug triaging - release service - KIconTheme maintainer - KPlotting maintainer - KWidgetAddons

Re: Is kdeinit still actual?

2020-04-27 Thread Christoph Feck
On 04/27/20 12:53, Alexander Volkov wrote: So, does it still makes sense to use kdeinit? https://phabricator.kde.org/T12140

Re: Review Kid3

2020-02-18 Thread Christoph Feck
On 02/13/20 22:14, Albert Astals Cid wrote: You should change the bug reporting to use bugzilla not your email address in KAboutData Right. Urs, could you please request creation of a bugzilla product? Thanks, Christoph

Re: Review Kid3

2020-02-13 Thread Christoph Feck
/doc/trunk-kf5/po/kid3.po/ Kid3 exists since 2003 and I would say that it is quite mature. As it is also available as a Qt-only version (without KDE dependencies) and for macOS, Windows and Android, the build system differs a bit from the typical KDE application. -- Christoph Feck KDE Bug

Re: Recommendation: drop ProvidersUrl entry to rely on default value

2020-01-30 Thread Christoph Feck
into the KNewStuff library as current value. Does it work with all KNewStuff 5.x versions? Otherwise, the required KF5 version would need to be bumped where this change was made. -- Christoph Feck

Re: Keysmith in kdereview

2019-12-28 Thread Christoph Feck
questions. Please refer me to any docs I should read. Our framework is already splitted into dozens of individual libraries, see https://techbase.kde.org/KDE_Frameworks -- Christoph Feck

Re: KDE Frameworks 5.62.0 released

2019-09-14 Thread Christoph Feck
On 09/14/19 13:35, David Faure wrote: 14th September 2019. KDE today announces the release of KDE Frameworks 5.62.0. http://kde.org/announcements/kde-frameworks-5.62.0.php This web page says the release number is 5.1.0.

Re: KDE release

2019-02-18 Thread Christoph Feck
in the under laying code the require a text file. The plan is allow simple is equal comparison with but binaries. However the current comparison code does not respond well to such files. ENOPARSE Christoph Feck

Re: CI System Reorganisation

2018-09-09 Thread Christoph Feck
view all of "stable" Applications on a single page? I remember I asked if it would still be possible after the change, but I cannot see a filter or link to get an overview of all builds. Christoph Feck

Re: Upcoming reorganisation of the CI system

2018-08-14 Thread Christoph Feck
an overview before doing releases. Christoph Feck

Re: kbackup in kdereview

2018-01-10 Thread Christoph Feck
for liquidshell, please; I have some bug reports lying around 8) -- Christoph Feck

Re: libqaccessibilityclient now in kdereview

2017-08-03 Thread Christoph Feck
On 25.07.2017 13:25, Jonathan Riddell wrote: libqaccessibilityclient is now in kdereview. The autotests need Qt5Test, but if the dependency is not installed, building fails silently. Either require Qt5Test, or make the tests optional if Qt5Test was not found. Issue found by Fabian from

Re: Ksysguard dev

2017-06-20 Thread Christoph Feck
On 19.06.2017 20:50, Alexandre Biche wrote: I want to add network I/O stats to ksysguard but I you closed kde-workspace's github repo and I don't find the plasma 5 github repo. Can you give me the way to start contributing please Our repositories are at https://cgit.kde.org/ KSysGuard is

Re: Review Request 129935: Fix build for GCC 7

2017-02-08 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129935/#review102448 --- Ship it! Ship It! - Christoph Feck On Feb. 8, 2017

Re: CI Requirements - Lessons Not Learnt?

2017-01-12 Thread Christoph Feck
How much work would it be to allow contributors to upload new versions to the CI? In openSUSE, for example, we have separate repos that contain new package versions that are not yet in standard distribution repositories, and so are able to build and deploy unstable versions for practically all

Re: Review Request 129423: keditbookmarks: add standard icons and shortcuts to Undo/Redo actions

2016-11-18 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129423/#review100929 --- Ship it! Ship It! - Christoph Feck On Nov. 18, 2016

Re: Kwave is in kdemultimedia now

2016-11-13 Thread Christoph Feck
On 11.11.2016 20:41, Thomas Eschenbacher wrote: as suggested by Ben, I hereby to inform you that today Kwave has been moved to kdemultimedia :) Thanks for your patience :) Did sysadmins also add an entry at reviewboard or phabricator for code reviews? If not, which would you prefer?

Re: Dropping kdelibs4-based applications in KDE Applications 17.12

2016-11-11 Thread Christoph Feck
KTorrent) where the original developer no longer has time for bug handling, and now the regressions pile up. Of course, this would only work if we find enough developers that join such an event. See above. -- Christoph Feck https://kdepepo.wordpress.com/ KDE Quality Team

Re: Review Request 128684: Proofread + update khtml-general kcm docbook

2016-09-14 Thread Christoph Feck
> On Aug. 16, 2016, 9:05 a.m., David Faure wrote: > > doc/kcontrol/khtml-general/index.docbook, line 51 > > > > > > Well, qt5-webkit and kwebkitpart do still exist. They're just not > > really maintained (but

kcharselect maintainership

2016-07-22 Thread Christoph Feck
changed; if there is other stuff that needs to be updated, please notify me. Thanks, Christoph -- Christoph Feck KDE Quality Team https://kdepepo.wordpress.com

Re: kolourpaint now KF5 based

2016-07-13 Thread Christoph Feck
On Wednesday 13 July 2016 20:12:46 Martin Koller wrote: > just wanted to let you know that I have now completed the > kolourpaint port to KF5 and this is now in its master branch. I > have also updated kde-build-metadata Hope I did all correct. The about dialog says it is version 5.25.0

Re: Cervisia?

2016-06-04 Thread Christoph Feck
t; > > not been started yet. > > Just for your information: I have now completed the KF5 port and > master now holds this version Thanks for the porting efforts, Martin! I tried compiling master branch, but get errors about many missing headers, such as klocale.h, kglobalsettings.h, kdemacros.h, kinputdialog.h, kiconloader.h, kdeversion.h, and kstatusbar.h For not yet completed ports, you need to add KF5::KDELibs4Support dependency. -- Christoph Feck KDE Quality Team

Re: Product versions on bugs.kde.org

2016-03-15 Thread Christoph Feck
nnouncements/kde-frameworks-5.6.0.php > [2] https://www.kde.org/announcements/kde-frameworks-5.8.0.php > [3] https://www.kde.org/announcements/kde-frameworks-5.9.0.php > [4] https://www.kde.org/announcements/kde-frameworks-5.13.0.php Thanks Alexander for cleaning this up. Could please also adjust

Re: Qt5 version of qimageblitz

2016-03-09 Thread Christoph Feck
On Wednesday 09 March 2016 08:08:14 Boudewijn Rempt wrote: > On Wed, 9 Mar 2016, Albert Astals Cid wrote: > > I guess for that we need to decide if it should be a framework > > first or not. > > Isn't kolourpaint the only user of qimageblitz at the moment? Krita > used to use it, years and years

Re: Review Request 125910: Fix for Bug 334525 - Gwenview hangs when switching from normal to full screen mode

2015-11-01 Thread Christoph Feck
) <https://git.reviewboard.kde.org/r/125910/#comment60248> I am not sure all compilers support initialization of (non-static) members inside the class declaration. I suggest to move it to the constructor. The same code is also present in knotification-framework. - Christoph Feck On

Re: Review Request 125816: Allow building KF5::ProcessUi without QtWebkit

2015-10-27 Thread Christoph Feck
I find rather useful). We could use QtWebEngine when QtWebKit is not available. - Christoph Feck On Oct. 27, 2015, 12:20 p.m., Alex Richardson wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: Review Request 125816: Allow building KF5::ProcessUi without QtWebkit

2015-10-27 Thread Christoph Feck
> On Oct. 27, 2015, 1:19 p.m., Christoph Feck wrote: > > One script is used to show detailed memory information (which I find rather > > useful). We could use QtWebEngine when QtWebKit is not available. ... or QTextBrowse

Re: Moving KDE Connect out of playground

2015-09-15 Thread Christoph Feck
On Tuesday 15 September 2015 02:13:17 Aleix Pol wrote: > Regarding the documentation, we discussed it briefly during the > sprint and we have the feeling that the documentation for such a > project would look more like a simple placeholder or something > easily outdated than anything. Furthermore,

Re: Bringing back rsibreak from unmaintained

2015-08-18 Thread Christoph Feck
On Monday 17 August 2015 20:04:04 Albert Astals Cid wrote: Hi guys, i just merged the frameworks port of rsibreak to master. rsibreak is in the unmaintained silo, i'd like to bring it back to extragear- utils (i guess kdeutils is too much for this niche app?). Anyone wants to review it?

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-17 Thread Christoph Feck
need to find a name for this option. Christoph Feck wrote: I wouldn't enable this option by default. The default should be pasting what was copied. Also, please do not mix options that affect the actual clipboard contents and the representation in the menu. An option that says

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-17 Thread Christoph Feck
On May 16, 2015, 9:37 p.m., Patrick Eigensatz wrote: klipper/historyitem.cpp, line 91 https://git.reviewboard.kde.org/r/123806/diff/5/?file=369605#file369605line91 I'm not sure if I can access Klipper from here. If I have a look at how this is done at other options then I see

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-16 Thread Christoph Feck
. - Christoph Feck On May 16, 2015, 12:40 p.m., Patrick Eigensatz wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123806

[kmplot][kturtle] merged frameworks to master

2015-02-24 Thread Christoph Feck
I just merged these frameworks porting branches to master: - kmplot - kturtle These applications will be released as KF5 applications (using KDELibs4Support) for the KDE Applications 15.04 release. Please help updating translations, CI etc. Christoph Feck (kdepepo)

Re: Help solving this month's Bug of the Month

2015-02-04 Thread Christoph Feck
On Wednesday 04 February 2015 21:51:53 Albert Astals Cid wrote: El Dimecres, 4 de febrer de 2015, a les 18:06:23, Martin Sandsmark va escriure: On Wed, Feb 04, 2015 at 04:45:26PM +0100, Christoph Feck wrote: According to recent comments, this is bug is still reproducible for some

Re: Review Request 121361: DeviceAutomounter Settings ui texts are misleading, if not plain wrong.

2015-02-04 Thread Christoph Feck
, Christoph Feck, and Helio Castro. Bugs: 243046 and 261376 http://bugs.kde.org/show_bug.cgi?id=243046 http://bugs.kde.org/show_bug.cgi?id=261376 Repository: kde-runtime Description --- automounterrc has four settings: [General] AutomountEnabled=true AutomountOnLogin

Help solving this month's Bug of the Month

2015-02-04 Thread Christoph Feck
or patches to the relevant pages, review requests, or bugzilla pages. Anyone is invited to participate and our users will appreciate this bug getting solved. Suggestions for next month's bug to the kde-gardening mailing list. Thanks in advance! -- Christoph Feck http://kdepepo.wordpress.com/ KDE

Re: Another proposal for modernization of our infrastructure

2015-01-31 Thread Christoph Feck
equivalent steps as described at http://qt-project.org/wiki/Setting-up-Gerrit to contribute, then I predict another big loss of developers. Christoph Feck (kdepepo)

Re: Review Request 122341: Port Thumbnail KIO Slave Away from KDELibs4Support

2015-01-31 Thread Christoph Feck
/122341/#comment51969 Please do not use // on every line to disable a section of code. It touches every line in the git change log. Better use #if on a separate line. - Christoph Feck On Jan. 31, 2015, 6:24 p.m., David Narváez wrote

Re: Feature matrix for future infrastructure

2015-01-29 Thread Christoph Feck
online, then I *want that*. I find it much more time consuming and demotivating to nitpick small style/whitespace changes, than to simply edit them out. Christoph Feck (kdepepo)

[kcalc][kcharselect][kcron] Merged frameworks branch to master, now KF5 based

2015-01-27 Thread Christoph Feck
to find the time while busy with PIM. Christoph Feck (kdepepo)

Help solving this month's Bug of the Month

2015-01-05 Thread Christoph Feck
this bug getting solved. Suggestions for next month's bug to the kde-gardening mailing list. Thanks in advance! -- Christoph Feck http://kdepepo.wordpress.com/ KDE Quality Team

kruler master is now based on KF5

2014-12-17 Thread Christoph Feck
frameworks branch can be deleted. Please rewire CI, translations or whatever else is needed. Merci :) Christoph Feck (kdepepo)

Do we continue releasing kdelibs 4.14?

2014-12-17 Thread Christoph Feck
4.11 or Applications releases, until everything is ported? Christoph Feck (kdepepo)

Re: Review Request for KDecoration

2014-12-10 Thread Christoph Feck
, or as a tooltip. This is a simple accessibility requirement. Christoph Feck (kdepepo)

Help solving this month's Bug of the Month

2014-12-02 Thread Christoph Feck
to the relevant pages, review requests, or bugzilla pages. Anyone is invited to participate and our users will appreciate this bug getting solved. Suggestions for next month's bug to the kde-gardening mailing list. Thanks in advance! -- Christoph Feck http://kdepepo.wordpress.com/ KDE Quality Team

Re: Review Request for KDecoration

2014-11-28 Thread Christoph Feck
On Friday 28 November 2014 12:00:43 Martin Gräßlin wrote: On Sunday 16 November 2014 23:30:35 Christoph Feck wrote: On Friday 31 October 2014 08:22:53 Martin Gräßlin wrote: today I want to start the review process for the new KDecoration Hi Martin, thanks for the work, here

Re: Review Request 120761: Added support for NFSv3, major refactoring, fixed bugs

2014-11-16 Thread Christoph Feck
/r/120343/ David Faure already approved a backport to KDE 4 there, but was not sure if release team is okey with the backport. - Christoph Feck On Nov. 16, 2014, 2:23 p.m., Mathias Tillman wrote: --- This is an automatically generated

Re: Review Request for KDecoration

2014-11-16 Thread Christoph Feck
, how do I get the correct QPaintDevice needed for the QFontMetrics? Otherwise, please provide a QFontMetrics (see QStyleOption). Q_PROPERTY(int smallSpacing Which unit is this property in? Pixels? Christoph Feck (kdepepo)

Help solving this month's Bug of The Month

2014-11-01 Thread Christoph Feck
users will appreciate this bug getting solved. Suggestions for next month's bug to the kde-gardening mailing list. Thanks in advance! -- Christoph Feck http://kdepepo.wordpress.com/ KDE Quality Team

Re: Review Request 120839: Fix solid-device-automounter failing to automount unknown devices

2014-10-29 Thread Christoph Feck
/ --- (Updated Oct. 28, 2014, 11:37 p.m.) Review request for kdelibs, Solid, Christoph Feck, and Helio Castro. Bugs: 243046 and 261376 http://bugs.kde.org/show_bug.cgi?id=243046 http://bugs.kde.org/show_bug.cgi?id=261376 Repository

Re: Review Request 120839: Fix solid-device-automounter failing to automount unknown devices

2014-10-29 Thread Christoph Feck
On Oct. 29, 2014, 12:02 p.m., Helio Castro wrote: Ok, way better than the previous one :-) Frank Schütte wrote: Thanks for your approval. Now who is going to commit my patch? I don't have write access to the repository, as far as I know. Christoph Feck wrote: me. I am just

Re: Review Request 120839: Fix solid-device-automounter failing to automount unknown devices

2014-10-28 Thread Christoph Feck
generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120839/ --- (Updated Oct. 28, 2014, 7:50 p.m.) Review request for kdelibs, Solid and Christoph Feck. Bugs: 243046 and 261376 http://bugs.kde.org

Re: Review Request 120528: [OS X]: respect icon visibility preference in system tray menus

2014-10-08 Thread Christoph Feck
requests on the qt-project.org site: http://qt-project.org/wiki/Gerrit-Introduction - Christoph Feck On Oct. 8, 2014, 11:28 a.m., René J.V. Bertin wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 120528: [OS X]: respect icon visibility preference in system tray menus

2014-10-08 Thread Christoph Feck
On Oct. 8, 2014, 11:47 a.m., Christoph Feck wrote: To get changes into Qt, you directly create the review requests on the qt-project.org site: http://qt-project.org/wiki/Gerrit-Introduction Ignore that comment... :P - Christoph

Re: Fwd: PVS-Studio KDE analysis

2014-10-02 Thread Christoph Feck
here: http://developer.kde.org/~cfeck/ Would be nice if someone hacks a script to format them to readable pages. Thanks Svyatoslav and Boris! -- Christoph Feck http://kdepepo.wordpress.com/ KDE Quality Team

Re: Fwd: PVS-Studio KDE analysis

2014-10-01 Thread Christoph Feck
on KDE site? -- Christoph Feck http://kdepepo.wordpress.com/ KDE Quality Team

Fwd: PVS-Studio KDE analysis

2014-09-29 Thread Christoph Feck
Hi, I got this question from Boris, but do not feel qualified to answer, so forwarding it here. Please CC Boris in reply. -- Forwarded Message -- Subject: PVS-Studio KDE analysis Date: Monday 29 September 2014, 18:04:24 From: Boris Egorov ego...@linux.com To:

Re: Review Request 120120: kmenuedit: do not resize app icons (fixes #338883)

2014-09-28 Thread Christoph Feck
On Sept. 23, 2014, 9:04 p.m., Christoph Feck wrote: No problem if we want to discuss it longer, and eventually change icon sizes to match text sizes (as is done in Skulpture style) or optionally allow configuring icon sizes. But right now, limiting to a hardcoded 20px value

Re: Review Request 120120: kmenuedit: do not resize app icons (fixes #338883)

2014-09-23 Thread Christoph Feck
in KDE code, and could be discussed, but not specific to this bug. - Christoph Feck On Sept. 9, 2014, 8:10 p.m., Boris Egorov wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r

Re: Review Request 120120: kmenuedit: do not resize app icons (fixes #338883)

2014-09-23 Thread Christoph Feck
On Sept. 23, 2014, 9:04 p.m., Christoph Feck wrote: No problem if we want to discuss it longer, and eventually change icon sizes to match text sizes (as is done in Skulpture style) or optionally allow configuring icon sizes. But right now, limiting to a hardcoded 20px value

Re: Review Request 120287: [OS X] make kde-workspace build

2014-09-20 Thread Christoph Feck
On Sept. 20, 2014, 8:20 a.m., Martin Gräßlin wrote: CMakeLists.txt, lines 225-234 https://git.reviewboard.kde.org/r/120287/diff/3/?file=313626#file313626line225 tabs instead of whitespaces René J.V. Bertin wrote: I looked into those yesterday, and cannot find tabs on my end.

Re: Review Request 120287: [OS X] make kde-workspace build

2014-09-19 Thread Christoph Feck
://git.reviewboard.kde.org/r/120287/#comment46757 here - Christoph Feck On Sept. 19, 2014, 10:05 p.m., René J.V. Bertin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120287

Re: Review Request 120120: kmenuedit: do not resize app icons (fixes #338883)

2014-09-09 Thread Christoph Feck
On Sept. 9, 2014, 8:02 p.m., Thomas Lübking wrote: treeview.cpp, line 232 https://git.reviewboard.kde.org/r/120120/diff/2/?file=310611#file310611line232 Maybe rather try to limit to the font height instead? Why? We use Small icon size next to text everywhere (buttons, menu items

Re: Review Request 116481: Calculate remaining battery lifetime considering ALL installed batteries

2014-08-31 Thread Christoph Feck
-of duplicated - and especially provide charge/discharge time reporting for individual batteries. Christoph Feck wrote: What is the status of this review? From what I see, Joschi resolved all raised issues. Kai? - Christoph

Re: [kdepim/frameworks] /: Port khbox

2014-08-12 Thread Christoph Feck
( this ); +QHBoxLayout *hbHBoxLayout = new QHBoxLayout(hb); +hbHBoxLayout-setMargin(0); +hbHBoxLayout-setSpacing( 4 ); Please do not use hard coded spacings. If you feel the default spacing provided by the Qt layouts is too big, use some fraction of the font height as a reference. Christoph Feck

Re: Review Request 119701: Fix bug #334271 : bad display of Dolphin status bar wdgets when a high DPI resolution is used

2014-08-10 Thread Christoph Feck
be too small. - Christoph Feck On Aug. 10, 2014, 9:34 p.m., Mathieu Tarral wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119701

Re: Review Request 118180: slideshow BUG patch fix

2014-07-21 Thread Christoph Feck
On June 5, 2014, 10:12 a.m., Christoph Feck wrote: Please add Plasma developers to the group of reviewers. Btw, you cannot give Ship It to yourself, others have to approve it. TOM Harrison wrote: that just a wrong click :) TOM Harrison wrote: thanks for reminding

Re: Review Request 117957: kcm_fonts: correctly restore default configuration values

2014-07-10 Thread Christoph Feck
On July 9, 2014, 8:26 a.m., Andrea Iacovitti wrote: If there are no objections or other suggestions it would be good to have the bug fixed in 4.11.11 release :) Thanks Andrea. Could you please check if this also affects bug 244857, bug 325868, or bug 326971 ? Their descriptions all seem

Re: Review Request 118851: Kde-baseapps- KF5 replace generic soversion.

2014-06-23 Thread Christoph Feck
On June 23, 2014, 9:16 a.m., Raymond Wooninck wrote: Hmm, now we seem to have a strange situation between KDE4 and KF5/PN. The latest version of libkonq with KDE4 is 5.14.0 (libkonq.so.5.14.0) with libkonq.so.5 pointing to it. With this change libkonq has a lower version

Re: Review Request 118898: KGamma: Apply user setting at login/startup

2014-06-23 Thread Christoph Feck
... Anyway, if the current patch is all that is needed to restore sanity as in KDE 3, the I am all for getting it fixed. - Christoph Feck On June 23, 2014, 5:01 p.m., Wolfgang Bauer wrote: --- This is an automatically generated e-mail

Re: Review Request 118898: KGamma: Apply user setting at login/startup

2014-06-23 Thread Christoph Feck
On June 23, 2014, 10:41 p.m., Christoph Feck wrote: Not sure why you added Marcel to the list of reviewers... Anyway, if the current patch is all that is needed to restore sanity as in KDE 3, the I am all for getting it fixed. (And if the same issue was the cause for the KRandR

Re: Review Request 118858: Fix crashes in KUrlNavigator that are caused by accesses to objects which have been deleted in nested event loops

2014-06-21 Thread Christoph Feck
rid of nested event loops. - Christoph Feck On June 21, 2014, 8:26 a.m., Frank Reininghaus wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118858

Re: Review Request 118180: slideshow BUG patch fix

2014-06-05 Thread Christoph Feck
, you cannot give Ship It to yourself, others have to approve it. - Christoph Feck On June 3, 2014, 5:58 a.m., TOM Harrison wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180

Re: Review Request 112235: Move focus to search field upon typing from result list

2014-05-25 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/112235/#review58424 --- This probably causes bug 335177. - Christoph Feck On Nov

Re: Review Request 112235: Move focus to search field upon typing from result list

2014-05-25 Thread Christoph Feck
On May 25, 2014, 9:03 p.m., Christoph Feck wrote: This probably causes bug 335177. Ignore this, wrong match. - Christoph --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/112235

Re: Review Request 118058: Allow quotation marks in passwords

2014-05-12 Thread Christoph Feck
- kdesu/kdesud/lexer.cpp f2c5db8 Diff: https://git.reviewboard.kde.org/r/118058/diff/ Testing --- Thanks, Christoph Feck

Re: Review Request 103478: Fix crash with --waitforwm

2014-05-12 Thread Christoph Feck
it no longer crashes when invoking with --waitforwm, but I have no idea how to test if it actually works. Diffs - kdeui/kernel/kapplication.cpp cc20f05 Diff: https://git.reviewboard.kde.org/r/103478/diff/ Testing --- Thanks, Christoph Feck

Review Request 118058: Allow quotation marks in passwords

2014-05-08 Thread Christoph Feck
/ Testing --- Thanks, Christoph Feck

Re: Review Request 116481: Calculate remaining battery lifetime considering ALL installed batteries

2014-05-04 Thread Christoph Feck
On March 2, 2014, 12:03 a.m., Kai Uwe Broulik wrote: Thanks for looking into this, I have a few code-styling related issues, see below. In the future I want to get rid of all of this, especially the magic ints instead of enums, and move that stuff to Solid - where it's already

Co-installability

2014-04-29 Thread Christoph Feck
I cannot remember we had these issues with the KDE3-KDE4 transition. Can anyone explain what changed? What's wrong with separate prefixes? Christoph Feck (kdepepo)

Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

2014-04-20 Thread Christoph Feck
On March 26, 2014, 10:07 p.m., Thomas Lübking wrote: you could sighup or sigusr the greeter process and have it setImmediateLock(true); desktopResized(); in return Wolfgang Bauer wrote: I agree, this would be a bit nicer... But I tried it and cannot get it to work.

Re: Review Request 113931: Fix process list to start already sorted

2014-03-26 Thread Christoph Feck
. Diffs - libs/ksysguard/processui/ksysguardprocesslist.cpp ed2c1ff Diff: https://git.reviewboard.kde.org/r/113931/diff/ Testing --- I use this patch since some weeks. Thanks, Christoph Feck

Re: What to test for 4.13?

2014-03-07 Thread Christoph Feck
. Thanks, Christoph Feck (kdepepo)

Re: Review Request 115183: KRunner: reset history when showing (to be consistent with shells)

2014-02-09 Thread Christoph Feck
at this patch, they are busy with Plasma Next. If there are no objections in the next 7 days, please commit it to 4.11 branch. I do not understand the bug fully, but I am using the patch since a few weeks, and did not notice a regression (not that I am a heavy krunner user). - Christoph Feck

Re: KDE Review - Moving Artikulate to KDE Edu

2014-01-26 Thread Christoph Feck
to do with kqmlgraphplugin first, since we can't have a kdeedu app depending on a playground lib. Are there technical reasons why we cannot? Christoph Feck (kdepepo)

Re: Moving Baloo forward

2014-01-17 Thread Christoph Feck
applications can get ported faster this way. Christoph Feck (kdepepo) KDE Quality Team

Re: Moving Baloo and Baloo-widgets into KDE SC

2014-01-09 Thread Christoph Feck
trust you that Baloo offers better performance than Nepomuk. But if the above scenario does not work, we should probably not introduce Baloo for KDE SC 4.x. Christoph Feck (kdepepo) KDE Quality Team

Re: KDE Frameworks: Moving toward 5.0 final and Governance

2014-01-06 Thread Christoph Feck
: - kiconthemes - kimageformats (including webp plugin from kde-runtime) - kplotting - kwidgetsaddons I may also be interested in kconfigwidgets, kcmutils, kcompletion, and kguiaddons in the future (I don't know the code good enough yet). Christoph Feck (kdepepo)

Re: Review Request 114717: Language detection in Sonnet

2013-12-29 Thread Christoph Feck
On Dec. 29, 2013, 4:39 p.m., Àlex Fiestas wrote: I wonder if we could use https://code.google.com/p/chromium-compact-language-detector/, apparently it is known to be really small, fast and contained, what do you think? It probably has better detection (uses quadgraphs instead of

Re: Moving Baloo and Baloo-widgets into KDE SC

2013-12-24 Thread Christoph Feck
-widgets. How does Baloo cooperate with Nepomuk? Note that we have ABI guarantees, so if the metadata is not shared between running instances of two services, but applications would have to be ported to the new ABI, then you cannot introduce Baloo in KDE 4.x, but only for KF5. Christoph Feck

Re: Regression of KItemWidgetDelegate in 4.12

2013-12-11 Thread Christoph Feck
. I do not know of previous bugs reported for the delegate either, so there is no need to delay the release to test the reverted state. Christoph Feck (kdepepo) KDE Quality Team openSUSE Review Team

Re: Review Request 114017: Possibly fix crash with horizontal wheel on tabs

2013-11-26 Thread Christoph Feck
. Someone please confirm it fixes the problem. Diffs - kdeui/widgets/ktabwidget.cpp 49dc293 Diff: http://git.reviewboard.kde.org/r/114017/diff/ Testing (updated) --- Fixes the crash, according to a tester. Thanks, Christoph Feck

Re: Review Request 114017: Fix crash with horizontal wheel on tabs

2013-11-26 Thread Christoph Feck
, because it is not handled by the tabbar code. Someone please confirm it fixes the problem. Diffs - kdeui/widgets/ktabwidget.cpp 49dc293 Diff: http://git.reviewboard.kde.org/r/114017/diff/ Testing --- Fixes the crash, according to a tester. Thanks, Christoph Feck

Re: Review Request 114017: Fix crash with horizontal wheel on tabs

2013-11-26 Thread Christoph Feck
by the tabbar code. Someone please confirm it fixes the problem. Diffs - kdeui/widgets/ktabwidget.cpp 49dc293 Diff: http://git.reviewboard.kde.org/r/114017/diff/ Testing --- Fixes the crash, according to a tester. Thanks, Christoph Feck

Re: Review Request 113965: Possible fix for bug 321100

2013-11-20 Thread Christoph Feck
On Nov. 20, 2013, 6:02 p.m., Albert Astals Cid wrote: I don't see why this should fix anything. Do you think anyone in the bug can provide a valgrind trace to better understand why it's crashing? See also https://git.reviewboard.kde.org/r/102981/ which has some discussion and links to

Re: Review Request 113969: Do not assume every items have the same height

2013-11-20 Thread Christoph Feck
with a patch :P Anyway, nice analysis, and this probably also fixes bug 290971, but have not tested it yet. - Christoph Feck On Nov. 20, 2013, 9:47 p.m., Yichao Yu wrote: --- This is an automatically generated e-mail. To reply, visit

Review Request 113931: Fix process list to start already sorted

2013-11-18 Thread Christoph Feck
://git.reviewboard.kde.org/r/113931/diff/ Testing --- I use this patch since some weeks. Thanks, Christoph Feck

Re: Review Request 110687: DrKonqi should check for disabled version as the very first step in the reporting assistant.

2013-11-17 Thread Christoph Feck
On May 28, 2013, 11:06 a.m., Martin Gräßlin wrote: Could you please get some feedback from packagers. I'm not sure whether they like words like unmaintained and upgrade. The fact that we as upstream don't accept bugs doesn't mean it's unmaintained by the distro and it's not said that

Re: Review Request 113260: Port KTimeZoned to Qt5/KF5

2013-11-15 Thread Christoph Feck
On Nov. 12, 2013, 10:39 a.m., Commit Hook wrote: This review has been submitted with commit 53e8e439af2483c86b21ad4d53ffe4da622e8c44 by Martin Klapetek to branch frameworks. Christoph Feck wrote: Locally, I get this error: AUTOMOC: error: process for /local/build

Re: Review Request 113846: fix kicontheme::list

2013-11-13 Thread Christoph Feck
://git.reviewboard.kde.org/r/113846/#comment31365 Use '/' (single quotes) for single characters. But this line also misses some QLatin1String or QStringLiteral to be NO_ASCII_CAST safe. - Christoph Feck On Nov. 13, 2013, 5:33 p.m., Jonathan Riddell wrote

  1   2   3   >