Re: Review Request: Make mouse cursor size configurable

2012-03-02 Thread Lukas Sommer
back to an image, scaling it, and then converting the image back to a pixmap. This is not a major issue, but it's the reason the image was scaled before it was converted to a pixmap. Lukas Sommer wrote: The problem is that I can't drop createIcon(int size) because I need

Re: Review Request: kcontrol mouse coursor: better performance

2012-02-29 Thread Lukas Sommer
. This patch implements a less expensive behaviour. Diffs - kcontrol/input/xcursor/cursortheme.cpp 2c8c260 kcontrol/input/xcursor/themepage.cpp 0f678ed Diff: http://git.reviewboard.kde.org/r/104077/diff/ Testing --- Thanks, Lukas Sommer

Review Request: kcontrol mouse coursor: better performance

2012-02-26 Thread Lukas Sommer
- kcontrol/input/xcursor/cursortheme.cpp 2c8c260 kcontrol/input/xcursor/themepage.cpp 0f678ed Diff: http://git.reviewboard.kde.org/r/104077/diff/ Testing --- Thanks, Lukas Sommer

Re: Review Request: Make mouse cursor size configurable

2011-11-09 Thread Lukas Sommer
://git.reviewboard.kde.org/r/101701/#review8036 --- On Sept. 2, 2011, 4:40 p.m., Lukas Sommer wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r

Re: Review Request: Make mouse cursor size configurable

2011-11-09 Thread Lukas Sommer
this simultanly? - Lukas --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101701/#review8036 --- On Sept. 2, 2011, 4:40 p.m., Lukas Sommer

Re: Review Request: Make mouse cursor size configurable

2011-10-08 Thread Lukas Sommer
for changes. Fredrik, further comments? Lukas Sommer wrote: Now it's on the feature list. About the position: Is it okay whan I move it to below the list? About the slider: And how do we distinghish between resolution dependend size and manual size, choosen

Re: Review Request: Make mouse cursor size configurable

2011-10-05 Thread Lukas Sommer
for changes. Fredrik, further comments? Lukas Sommer wrote: Now it's on the feature list. About the position: Is it okay whan I move it to below the list? About the slider: And how do we distinghish between resolution dependend size and manual size, choosen

Re: Review Request: Make mouse cursor size configurable

2011-09-23 Thread Lukas Sommer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101701/#review6697 --- On Sept. 2, 2011, 4:40 p.m., Lukas Sommer wrote

Review Request: systemsettings/fonts: DPI setting is X11-only

2011-09-04 Thread Lukas Sommer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102527/ --- Review request for KDE Base Apps, KDE Runtime and kdewin. Summary ---

Re: Review Request: Make mouse cursor size configurable

2011-09-02 Thread Lukas Sommer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101701/ --- (Updated Sept. 2, 2011, 4:40 p.m.) Review request for KDE Base Apps, KDE

Re: Review Request: Make mouse cursor size configurable

2011-07-21 Thread Lukas Sommer
)? Do we need some logic to prevent it saying Available sizes: when only one size is available? But I am not sure if i18n can handle that. Lukas Sommer wrote: It means never empty. This could be a solution to the plural problem: // The translation

Re: Review Request: Make mouse cursor size configurable

2011-07-21 Thread Lukas Sommer
/101701/#review4898 --- On June 20, 2011, 10:04 a.m., Lukas Sommer wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101701

Re: Review Request: Make mouse cursor size configurable

2011-07-20 Thread Lukas Sommer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101701/#review4633 --- On June 20, 2011, 10:04 a.m., Lukas Sommer wrote

Re: Review Request: Make mouse cursor size configurable

2011-07-19 Thread Lukas Sommer
)? Do we need some logic to prevent it saying Available sizes: when only one size is available? But I am not sure if i18n can handle that. Lukas Sommer wrote: It means never empty. This could be a solution to the plural problem: // The translation

Re: Review Request: Make mouse cursor size configurable

2011-07-18 Thread Lukas Sommer
)? Do we need some logic to prevent it saying Available sizes: when only one size is available? But I am not sure if i18n can handle that. Lukas Sommer wrote: It means never empty. This could be a solution to the plural problem: // The translation

Re: Review Request: Make mouse cursor size configurable

2011-07-17 Thread Lukas Sommer
, 10:04 a.m., Lukas Sommer wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101701/ --- (Updated June 20, 2011, 10:04 a.m

Re: Review Request: Make mouse cursor size configurable

2011-07-17 Thread Lukas Sommer
)? Do we need some logic to prevent it saying Available sizes: when only one size is available? But I am not sure if i18n can handle that. Lukas Sommer wrote: It means never empty. This could be a solution to the plural problem: // The translation

Review Request: Make mouse cursor size configurable

2011-06-20 Thread Lukas Sommer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101701/ --- Review request for KDE Base Apps, KDE Runtime, kdelibs, and Christoph Feck.

Help with revert commit

2011-06-12 Thread Lukas Sommer
by peer), and I don't get it reverted. But this commit should be reverted soon - before the i18n scripts run. Could someone help me and revert the commit? Sorry for inconvenience. (Will not happen another time; I promise.) Regards. Lukas Sommer

Re: Help with revert commit

2011-06-12 Thread Lukas Sommer
Finally I've managed to get my git working and revert the commit. Sorry for inconvenience. Lukas Sommer 2011/6/11 Lukas Sommer sommer...@gmail.com Hello. The commit 9e1de272620da40fead11dfdb705cf c3d9a90f10 that I've done this morning should not go to master because this would mean a new

Re: Review Request: startkde.cmake should treat font dpi like kcontrol/krdb/krdb.cpp does

2011-06-08 Thread Lukas Sommer
, 2011, 10:54 a.m., Lukas Sommer wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101410/ --- (Updated June 1, 2011, 10:54 a.m

Re: Review Request: startkde.cmake should treat font dpi like kcontrol/krdb/krdb.cpp does

2011-06-02 Thread Lukas Sommer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101410/ --- (Updated June 1, 2011, 10:04 a.m.) Review request for KDE Base Apps, KDE

Re: Review Request: startkde.cmake should treat font dpi like kcontrol/krdb/krdb.cpp does

2011-06-02 Thread Lukas Sommer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101410/ --- (Updated June 1, 2011, 10:54 a.m.) Review request for KDE Base Apps, KDE

Re: Review Request: startkde.cmake should treat font dpi like kcontrol/krdb/krdb.cpp does

2011-05-27 Thread Lukas Sommer
., Lukas Sommer wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101410/ --- (Updated May 22, 2011, 9:48 a.m.) Review

Review Request: startkde.cmake should treat font dpi like kcontrol/krdb/krdb.cpp does

2011-05-22 Thread Lukas Sommer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101410/ --- Review request for KDE Base Apps, KDE Runtime and kdelibs. Summary

Re: Review Request: Better documentation for KConfigDialog::addPage()

2011-05-22 Thread Lukas Sommer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101409/ --- (Updated May 21, 2011, 11:03 a.m.) Review request for kdelibs. Changes

Review Request: Better documentation for KConfigDialog::addPage()

2011-05-21 Thread Lukas Sommer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101409/ --- Review request for kdelibs. Summary --- The documentation of