---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127815/#review95153
---
Makes sense!
- Thomas Pfeiffer
On May 2, 2016, 7:04 p.m
avoided where possible => this
> > patch factors some information out of a tooltip which in itself is
> > desirable.
> > 4. For the user, the discoverability of the feature after applying this
> > patch is better than before (though not perfect, sure).
>
> Thomas Pfe
avoided where possible => this
> > patch factors some information out of a tooltip which in itself is
> > desirable.
> > 4. For the user, the discoverability of the feature after applying this
> > patch is better than before (though not perfect, sure).
>
> Thomas Pfe
gt; https://git.reviewboard.kde.org/r/122249/
> -------
>
> (Updated April 20, 2015, 10:24 p.m.)
>
>
> Review request for KDE Base Apps, Martin Gräßlin, John Tapsell, and Thomas
> Pfeiffer.
>
>
> Repository:
avoided where possible => this
> > patch factors some information out of a tooltip which in itself is
> > desirable.
> > 4. For the user, the discoverability of the feature after applying this
> > patch is better than before (though not perfect, sure).
>
> Thomas Pfe
> On April 20, 2015, 10:36 p.m., Thomas Pfeiffer wrote:
> > What would likely be confusing is that the two button modes have different
> > interaction flows: The "End Process" mode requires to first select a
> > process and then press the button to work, whereas
On May 17, 2015, 6:22 p.m., Martin Gräßlin wrote:
klipper/generalconfig.ui, lines 36-45
https://git.reviewboard.kde.org/r/123806/diff/5/?file=369604#file369604line36
unrelated to the discussion about how to call the entries: I would call
the config option differently as the code
Replace whitespace
with symbols is highly confusing next to an option that says Trim
whitespace.
Kai Uwe Broulik wrote:
Btw I just pushed the highlight feature to the Klipper plasmoid and I
don't see why that one should be configurable.
Thomas Pfeiffer wrote:
I wouldn't enable
On May 16, 2015, 9:37 p.m., Patrick Eigensatz wrote:
klipper/historyitem.cpp, line 91
https://git.reviewboard.kde.org/r/123806/diff/5/?file=369605#file369605line91
I'm not sure if I can access Klipper from here. If I have a look at
how this is done at other options then I see
://en.wikipedia.org/wiki/X_Window_selection
I assume the timeout and history size items don't belong into that box,
which could then be a checkable groupbox (but some klipper dev should confirm
- or we must lookup the code ;-)
Thomas Pfeiffer wrote:
I do agree with Heiko
://en.wikipedia.org/wiki/X_Window_selection
I assume the timeout and history size items don't belong into that box,
which could then be a checkable groupbox (but some klipper dev should confirm
- or we must lookup the code ;-)
Thomas Pfeiffer wrote:
I do agree with Heiko
On May 16, 2015, 4:37 p.m., Christoph Feck wrote:
klipper/klipper.kcfg, line 32
https://git.reviewboard.kde.org/r/123806/diff/3/?file=369517#file369517line32
It would be immensely useful, if Klipper also showed leading/trailing
whitespace, i.e. for items that aren't completely
://en.wikipedia.org/wiki/X_Window_selection
I assume the timeout and history size items don't belong into that box,
which could then be a checkable groupbox (but some klipper dev should confirm
- or we must lookup the code ;-)
Thomas Pfeiffer wrote:
I do agree with Heiko
in a different color to hint that this is a placeholder?
Patrick Eigensatz wrote:
I think the idea of (colored) placeholders is great! I've started to
create an option in the configuration dialog, we could add an option for
whitespace placeholders, too.
Thomas Pfeiffer wrote
in a different color to hint that this is a placeholder?
Patrick Eigensatz wrote:
I think the idea of (colored) placeholders is great! I've started to
create an option in the configuration dialog, we could add an option for
whitespace placeholders, too.
Thomas Pfeiffer wrote
in a different color to hint that this is a placeholder?
Patrick Eigensatz wrote:
I think the idea of (colored) placeholders is great! I've started to
create an option in the configuration dialog, we could add an option for
whitespace placeholders, too.
Thomas Pfeiffer wrote
On May 15, 2015, 7:31 p.m., Martin Gräßlin wrote:
thanks for rebasing!
I just had a look at the bug report and have to agree with comment #1: I do
from time to time copy on purpose whitespaces (yes I'm weird). I also tend
to copy newlines and I do want to have them in the history.
On April 20, 2015, 10:36 p.m., Thomas Pfeiffer wrote:
What would likely be confusing is that the two button modes have different
interaction flows: The End Process mode requires to first select a
process and then press the button to work, whereas the Kill specific
window mode
On April 20, 2015, 10:36 p.m., Thomas Pfeiffer wrote:
What would likely be confusing is that the two button modes have different
interaction flows: The End Process mode requires to first select a
process and then press the button to work, whereas the Kill specific
window mode
On April 20, 2015, 10:36 p.m., Thomas Pfeiffer wrote:
What would likely be confusing is that the two button modes have different
interaction flows: The End Process mode requires to first select a
process and then press the button to work, whereas the Kill specific
window mode
to kill would be selected. Of course the current flow of ending a
process could and should still work.
- Thomas Pfeiffer
On April 20, 2015, 10:24 p.m., Gregor Mi wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
Hi everyone,
first of all, I think it's a great step in the right direction that we're now
putting our config files in ~/.config instead of ~/.kde(4), we're now finally
standard-compliant.
However, where we still could - and imho should - do better is with where
exactly we put them. If I look
On Jan. 20, 2013, 11:53 a.m., Thomas Pfeiffer wrote:
File Attachment: Icon Dialog with 200dpi
http://git.reviewboard.kde.org/r/108504/#fcomment5
Why is that icon smaller than the others? Is it because the bigger
version of it does not exist?
Kai Uwe Broulik wrote:
Also
23 matches
Mail list logo