API Breakage?: Re: [kcmutils] src: Fix typo in headers generation
On Tuesday 9 December 2014 16:16:23 Martin Klapetek wrote: Git commit 0256b80e9ac7c1459afe0ac021d27e985cba14d3 by Martin Klapetek. Committed on 09/12/2014 at 16:16. Pushed by mklapetek into branch 'master'. Fix typo in headers generation Also install to properly capitalized subdirectory And it seems that we have our first breakage in Frameworks. Programs that compile against Frameworks 5.5, will no longer compile against Frameworks 5.6 and vice versa. The change of the directoryname causes issues as that for 5.5 you need to have the ksettings/includefile.h, but this will fail on 5.6 as that one would require KSettings/includefile.h. I was hoping that the camelcase headers could help out here, but they are installed in the same directoy. Regards Raymond
Re: API Breakage?: Re: [kcmutils] src: Fix typo in headers generation
On Wed, Dec 10, 2014 at 9:56 AM, Raymond Wooninck tittiatc...@gmail.com wrote: On Tuesday 9 December 2014 16:16:23 Martin Klapetek wrote: Git commit 0256b80e9ac7c1459afe0ac021d27e985cba14d3 by Martin Klapetek. Committed on 09/12/2014 at 16:16. Pushed by mklapetek into branch 'master'. Fix typo in headers generation Also install to properly capitalized subdirectory And it seems that we have our first breakage in Frameworks. Programs that compile against Frameworks 5.5, will no longer compile against Frameworks 5.6 and vice versa. The change of the directoryname causes issues as that for 5.5 you need to have the ksettings/includefile.h, but this will fail on 5.6 as that one would require KSettings/includefile.h. I was hoping that the camelcase headers could help out here, but they are installed in the same directoy. Ah hmm...I did this because at some other places there are KSettings/includefile.h and the build was failing. I guess I'll just revert the directory capitalization then, but leave the typo fix itself. Cheers -- Martin Klapetek | KDE Developer
Re: API Breakage?: Re: [kcmutils] src: Fix typo in headers generation
El Dimecres, 10 de desembre de 2014, a les 10:17:23, Martin Klapetek va escriure: On Wed, Dec 10, 2014 at 9:56 AM, Raymond Wooninck tittiatc...@gmail.com wrote: On Tuesday 9 December 2014 16:16:23 Martin Klapetek wrote: Git commit 0256b80e9ac7c1459afe0ac021d27e985cba14d3 by Martin Klapetek. Committed on 09/12/2014 at 16:16. Pushed by mklapetek into branch 'master'. Fix typo in headers generation Also install to properly capitalized subdirectory And it seems that we have our first breakage in Frameworks. Programs that compile against Frameworks 5.5, will no longer compile against Frameworks 5.6 and vice versa. The change of the directoryname causes issues as that for 5.5 you need to have the ksettings/includefile.h, but this will fail on 5.6 as that one would require KSettings/includefile.h. I was hoping that the camelcase headers could help out here, but they are installed in the same directoy. Ah hmm...I did this because at some other places there are KSettings/includefile.h and the build was failing. I guess I'll just revert the directory capitalization then, but leave the typo fix itself. Can we get both the correct and the old way and mark it as deprecated? the correct way is cool since it helps us by having the same way of using stuff on all frameworks, predictibility is awesome. the old way gives us the compatibility we promise. Now, i've no clue what i'm talking about so excuse me if i'm suggesting something stupid :D Cheers, Albert Cheers
Re: API Breakage?: Re: [kcmutils] src: Fix typo in headers generation
On Thu, Dec 11, 2014 at 12:09 AM, Albert Astals Cid aa...@kde.org wrote: Can we get both the correct and the old way and mark it as deprecated? the correct way is cool since it helps us by having the same way of using stuff on all frameworks, predictibility is awesome. And it eases up porting from kdelibs4support but not having to change all the includes. the old way gives us the compatibility we promise. Now, i've no clue what i'm talking about so excuse me if i'm suggesting something stupid :D I was acutally thinking about the same, would mean the headers are duplicated though. Additionally the old headers could have some #pragma message so it tells people while building. The argument against was that whatever would use the correct wouldn't build against older frameworks...which in the cases I know about wouldn't be a problem because they depend on master anyway, so bumping the min version in their find_package(..) wouldn't be a problem. Cheers -- Martin Klapetek | KDE Developer
Re: API Breakage?: Re: [kcmutils] src: Fix typo in headers generation
Martin Klapetek wrote: I was acutally thinking about the same, would mean the headers are duplicated though. Additionally the old headers could have some #pragma message so it tells people while building. And you also have to check whether the file system you're installing to is case-sensitive to begin with, and only install the compatibility headers on case-sensitive file systems. Kevin Kofler
