Re: Review Request: Fix KConfigDialogManager fails to handle subclasses of QComboBox with custom property

2012-02-23 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103909/#review10854 --- Ship it! Only one small spacing issue:

Re: Review Request: Fix KConfigDialogManager fails to handle subclasses of QComboBox with custom property

2012-02-21 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103909/ --- (Updated Feb. 21, 2012, 11:54 p.m.) Review request for kdelibs, Ben

Re: Review Request: Fix KConfigDialogManager fails to handle subclasses of QComboBox with custom property

2012-02-21 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103909/ --- (Updated Feb. 21, 2012, 11:55 p.m.) Review request for kdelibs, Ben

Re: Review Request: Fix KConfigDialogManager fails to handle subclasses of QComboBox with custom property

2012-02-20 Thread Albert Astals Cid
On Feb. 10, 2012, 12:01 a.m., Christoph Feck wrote: Thanks Albert for looking at it. Not sure if I understand everything correctly, but what happens, when I have a subclass of Q/KComboBox, that does not have its own user property? I am considering the following possible cases:

Re: Review Request: Fix KConfigDialogManager fails to handle subclasses of QComboBox with custom property

2012-02-12 Thread Albert Astals Cid
On Feb. 10, 2012, 12:01 a.m., Christoph Feck wrote: Thanks Albert for looking at it. Not sure if I understand everything correctly, but what happens, when I have a subclass of Q/KComboBox, that does not have its own user property? I am considering the following possible cases:

Re: Review Request: Fix KConfigDialogManager fails to handle subclasses of QComboBox with custom property

2012-02-12 Thread Christoph Feck
On Feb. 10, 2012, 12:01 a.m., Christoph Feck wrote: Thanks Albert for looking at it. Not sure if I understand everything correctly, but what happens, when I have a subclass of Q/KComboBox, that does not have its own user property? I am considering the following possible cases:

Re: Review Request: Fix KConfigDialogManager fails to handle subclasses of QComboBox with custom property

2012-02-09 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103909/ --- (Updated Feb. 9, 2012, 11:28 p.m.) Review request for kdelibs, Eike Hein,

Re: Review Request: Fix KConfigDialogManager fails to handle subclasses of QComboBox with custom property

2012-02-09 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103909/ --- (Updated Feb. 9, 2012, 11:28 p.m.) Review request for kdelibs, Ben

Re: Review Request: Fix KConfigDialogManager fails to handle subclasses of QComboBox with custom property

2012-02-09 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103909/#review10470 --- Thanks Albert for looking at it. Not sure if I understand