On Nov. 9, 2011, 6:48 a.m., Fredrik Höglund wrote:
kcontrol/input/xcursor/cursortheme.cpp, line 119
http://git.reviewboard.kde.org/r/101701/diff/2/?file=33417#file33417line119
Scaling a pixmap is more expensive than scaling an image. Internally it
involves converting the pixmap
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101701/#review8071
---
This review has been submitted with commit
On Nov. 9, 2011, 6:48 a.m., Fredrik Höglund wrote:
kcontrol/input/xcursor/cursortheme.cpp, line 119
http://git.reviewboard.kde.org/r/101701/diff/2/?file=33417#file33417line119
Scaling a pixmap is more expensive than scaling an image. Internally it
involves converting the pixmap
On Nov. 9, 2011, 6:48 a.m., Fredrik Höglund wrote:
Sorry for not finding the time to follow up on this until now.
The new design is not quite what I had in mind, but given that the freeze
is tomorrow I'm fine with including it in 4.8.
I have given the code a quick look over, and
On Sept. 21, 2011, 1:05 p.m., Christoph Feck wrote:
What I dislike is the position of the size combo box. Either it should be
below the list, or, when above the list, share the space with the preview.
Regarding the use DPI depended size, what we could do if we use a slider,
is to
On Sept. 21, 2011, 1:05 p.m., Christoph Feck wrote:
What I dislike is the position of the size combo box. Either it should be
below the list, or, when above the list, share the space with the preview.
Regarding the use DPI depended size, what we could do if we use a slider,
is to
On Sept. 21, 2011, 1:05 p.m., Christoph Feck wrote:
What I dislike is the position of the size combo box. Either it should be
below the list, or, when above the list, share the space with the preview.
Regarding the use DPI depended size, what we could do if we use a slider,
is to
On Sept. 21, 2011, 1:05 p.m., Christoph Feck wrote:
What I dislike is the position of the size combo box. Either it should be
below the list, or, when above the list, share the space with the preview.
Regarding the use DPI depended size, what we could do if we use a slider,
is to
On Sept. 21, 2011, 1:05 p.m., Christoph Feck wrote:
What I dislike is the position of the size combo box. Either it should be
below the list, or, when above the list, share the space with the preview.
Regarding the use DPI depended size, what we could do if we use a slider,
is to
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101701/#review6697
---
What I dislike is the position of the size combo box. Either it
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101701/
---
(Updated Sept. 2, 2011, 4:40 p.m.)
Review request for KDE Base Apps, KDE
On July 12, 2011, 8:56 a.m., Christoph Feck wrote:
kcontrol/input/xcursor/xcursortheme.cpp, line 73
http://git.reviewboard.kde.org/r/101701/diff/1/?file=24784#file24784line73
Do you mean the sizes are always 0, or do you mean the number of
entries in the list is 0 (never
On July 20, 2011, 2:46 p.m., Fredrik Höglund wrote:
Lucas, first of all I want to say thank you for working on this.
In good UI design it is important to think about the problem the user
wants to solve from the user's point of view, and not in terms of how
the underlying
On July 12, 2011, 8:56 a.m., Christoph Feck wrote:
kcontrol/input/xcursor/themepage.ui, line 78
http://git.reviewboard.kde.org/r/101701/diff/1/?file=24782#file24782line78
sizePolicyComboBox, there is no Police here ;)
How should I name this?
- Lukas
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101701/#review4898
---
Lucas, first of all I want to say thank you for working on
On July 12, 2011, 8:56 a.m., Christoph Feck wrote:
kcontrol/input/xcursor/xcursortheme.cpp, line 73
http://git.reviewboard.kde.org/r/101701/diff/1/?file=24784#file24784line73
Do you mean the sizes are always 0, or do you mean the number of
entries in the list is 0 (never
On July 12, 2011, 8:56 a.m., Christoph Feck wrote:
kcontrol/input/xcursor/xcursortheme.cpp, line 73
http://git.reviewboard.kde.org/r/101701/diff/1/?file=24784#file24784line73
Do you mean the sizes are always 0, or do you mean the number of
entries in the list is 0 (never
On July 12, 2011, 8:56 a.m., Christoph Feck wrote:
kcontrol/input/xcursor/xcursortheme.cpp, line 73
http://git.reviewboard.kde.org/r/101701/diff/1/?file=24784#file24784line73
Do you mean the sizes are always 0, or do you mean the number of
entries in the list is 0 (never
On July 12, 2011, 8:56 a.m., Christoph Feck wrote:
kcontrol/input/xcursor/xcursortheme.cpp, line 73
http://git.reviewboard.kde.org/r/101701/diff/1/?file=24784#file24784line73
Do you mean the sizes are always 0, or do you mean the number of
entries in the list is 0 (never
On July 12, 2011, 8:56 a.m., Christoph Feck wrote:
kcontrol/input/xcursor/xcursortheme.cpp, line 73
http://git.reviewboard.kde.org/r/101701/diff/1/?file=24784#file24784line73
Do you mean the sizes are always 0, or do you mean the number of
entries in the list is 0 (never
On July 12, 2011, 8:56 a.m., Christoph Feck wrote:
kcontrol/input/xcursor/xcursortheme.cpp, line 73
http://git.reviewboard.kde.org/r/101701/diff/1/?file=24784#file24784line73
Do you mean the sizes are always 0, or do you mean the number of
entries in the list is 0 (never
On July 12, 2011, 8:56 a.m., Christoph Feck wrote:
kcontrol/input/xcursor/xcursortheme.cpp, line 73
http://git.reviewboard.kde.org/r/101701/diff/1/?file=24784#file24784line73
Do you mean the sizes are always 0, or do you mean the number of
entries in the list is 0 (never
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101701/#review4633
---
kcontrol/input/xcursor/cursortheme.h
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101701/
---
Review request for KDE Base Apps, KDE Runtime, kdelibs, and Christoph Feck.
24 matches
Mail list logo