Re: Review Request: New KDE Macro for to wrap the noreturn attribute

2012-04-28 Thread Oswald Buddenhagen
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103832/#review13016 --- it's not necessary to add that _feature_ to 4.8, and for

Re: Review Request: New KDE Macro for to wrap the noreturn attribute

2012-04-27 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103832/#review12946 --- MinGW accepts both __attribute__ and __declspec so we maybe

Re: Review Request: New KDE Macro for to wrap the noreturn attribute

2012-04-26 Thread Allen Winter
On Feb. 13, 2012, 11:30 a.m., David Faure wrote: Out of curiosity, if the method returns void anyway, why is this attribute necessary? It's not like the the compiler is going to warn about the lack of a return value... Allen Winter wrote: From the GNU Compiler documentation: The

Re: Review Request: New KDE Macro for to wrap the noreturn attribute

2012-04-26 Thread Albert Astals Cid
On Feb. 13, 2012, 11:30 a.m., David Faure wrote: Out of curiosity, if the method returns void anyway, why is this attribute necessary? It's not like the the compiler is going to warn about the lack of a return value... Allen Winter wrote: From the GNU Compiler documentation: The

Re: Review Request: New KDE Macro for to wrap the noreturn attribute

2012-02-17 Thread Allen Winter
On Feb. 13, 2012, 11:30 a.m., David Faure wrote: Out of curiosity, if the method returns void anyway, why is this attribute necessary? It's not like the the compiler is going to warn about the lack of a return value... From the GNU Compiler documentation: The noreturn keyword tells the

Re: Review Request: New KDE Macro for to wrap the noreturn attribute

2012-02-13 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103832/#review10589 --- Out of curiosity, if the method returns void anyway, why is

Re: Review Request: New KDE Macro for to wrap the noreturn attribute

2012-02-13 Thread Pau Garcia i Quiles
Hi, The MSDN documentation explains this: http://msdn.microsoft.com/en-us/library/k6ktzx3s%28v=vs.100%29.aspx On Mon, Feb 13, 2012 at 12:30 PM, David Faure fa...@kde.org wrote: This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103832/ Out of

Re: Review Request: New KDE Macro for to wrap the noreturn attribute

2012-02-13 Thread Andreas Pakulat
On 13.02.12 12:49:08, Pau Garcia i Quiles wrote: Hi, The MSDN documentation explains this: http://msdn.microsoft.com/en-us/library/k6ktzx3s%28v=vs.100%29.aspx Hmm, maybe that changed in more recent MSVC's but MSVC6 always error'ed out from the compile if a branch was missing a return

Review Request: New KDE Macro for to wrap the noreturn attribute

2012-01-31 Thread Allen Winter
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103832/ --- Review request for kdelibs. Description --- This diff adds a new