---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110327/#review32564
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110327/
---
(Updated May 15, 2013, 1:54 p.m.)
Status
--
This change has been
On May 7, 2013, 2:50 p.m., Dominik Haumann wrote:
The patch itself is fine and most likely does not introduce regressions in
terms of misbehavior.
Still, is never showing an icon the way to go? Another way to work around
this by default would be an additional function called
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110327/
---
(Updated May 14, 2013, 4:31 p.m.)
Review request for Dolphin, Kate and
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110327/#review32512
---
Ship it!
Given the posted screenshot, setting a unique icon
On May 7, 2013, 12:50 p.m., Dominik Haumann wrote:
The patch itself is fine and most likely does not introduce regressions in
terms of misbehavior.
Still, is never showing an icon the way to go? Another way to work around
this by default would be an additional function called
On May 7, 2013, 12:50 p.m., Dominik Haumann wrote:
The patch itself is fine and most likely does not introduce regressions in
terms of misbehavior.
Still, is never showing an icon the way to go? Another way to work around
this by default would be an additional function called
On May 7, 2013, 8:50 a.m., Dominik Haumann wrote:
The patch itself is fine and most likely does not introduce regressions in
terms of misbehavior.
Still, is never showing an icon the way to go? Another way to work around
this by default would be an additional function called
On May 7, 2013, 12:50 p.m., Dominik Haumann wrote:
The patch itself is fine and most likely does not introduce regressions in
terms of misbehavior.
Still, is never showing an icon the way to go? Another way to work around
this by default would be an additional function called
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110327/#review32194
---
The patch itself is fine and most likely does not introduce
On May 7, 2013, 2:50 p.m., Dominik Haumann wrote:
The patch itself is fine and most likely does not introduce regressions in
terms of misbehavior.
Still, is never showing an icon the way to go? Another way to work around
this by default would be an additional function called
On May 7, 2013, 12:50 p.m., Dominik Haumann wrote:
The patch itself is fine and most likely does not introduce regressions in
terms of misbehavior.
Still, is never showing an icon the way to go? Another way to work around
this by default would be an additional function called
On May 7, 2013, 12:50 p.m., Dominik Haumann wrote:
The patch itself is fine and most likely does not introduce regressions in
terms of misbehavior.
Still, is never showing an icon the way to go? Another way to work around
this by default would be an additional function called
On May 7, 2013, 12:50 p.m., Dominik Haumann wrote:
The patch itself is fine and most likely does not introduce regressions in
terms of misbehavior.
Still, is never showing an icon the way to go? Another way to work around
this by default would be an additional function called
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110327/#review32146
---
I think your patch will fix the bug 304775. ;)
Bug 304775 -
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110327/#review32149
---
Looks very reasonable from my point of view, thanks! And yes,
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110327/#review32154
---
Semi-OT (sorry) - what makes this thing appear on top of
On May 6, 2013, 9:32 p.m., Thomas Lübking wrote:
Semi-OT (sorry) - what makes this thing appear on top of things (below
the toolbar) - and why?
In a NW gravity world, this means the UI is shifted downwards under the
users fingers (no matter where you are, the poaint where your mouse
On May 6, 2013, 8:45 p.m., Frank Reininghaus wrote:
kdeui/widgets/kmessagewidget.cpp, line 253
http://git.reviewboard.kde.org/r/110327/diff/1/?file=142371#file142371line253
I guess you can remove the variable 'icon' from this function now,
right?
Indeed. Removing it.
-
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110327/
---
(Updated May 6, 2013, 10:59 p.m.)
Review request for Dolphin, Kate and
20 matches
Mail list logo
