Re: Review Request 121390: make Qt5 theme build on Linux again

2015-03-01 Thread Yichao Yu
On 十二月 8, 2014, 9:07 a.m., Martin Gräßlin wrote: this is wrong - please have a look at various frameworks on how to do it properly. In the end it should be: #if HAVE_X11 // x11 specific stuff #endif obviously it also needs a runtime check: if (QX11Info::isPlatformX11())

Re: Review Request 121390: make Qt5 theme build on Linux again

2015-03-01 Thread Marko Käning
On Dec. 8, 2014, 3:07 p.m., Martin Gräßlin wrote: this is wrong - please have a look at various frameworks on how to do it properly. In the end it should be: #if HAVE_X11 // x11 specific stuff #endif obviously it also needs a runtime check: if (QX11Info::isPlatformX11())

Re: Review Request 121390: make Qt5 theme build on Linux again

2015-03-01 Thread Yichao Yu
On 十二月 8, 2014, 9:07 a.m., Martin Gräßlin wrote: this is wrong - please have a look at various frameworks on how to do it properly. In the end it should be: #if HAVE_X11 // x11 specific stuff #endif obviously it also needs a runtime check: if (QX11Info::isPlatformX11())

Re: Review Request 121390: make Qt5 theme build on Linux again

2015-03-01 Thread Yichao Yu
On 十二月 8, 2014, 9:07 a.m., Martin Gräßlin wrote: this is wrong - please have a look at various frameworks on how to do it properly. In the end it should be: #if HAVE_X11 // x11 specific stuff #endif obviously it also needs a runtime check: if (QX11Info::isPlatformX11())

Re: Review Request 121390: make Qt5 theme build on Linux again

2015-03-01 Thread Marko Käning
On Dec. 8, 2014, 3:07 p.m., Martin Gräßlin wrote: this is wrong - please have a look at various frameworks on how to do it properly. In the end it should be: #if HAVE_X11 // x11 specific stuff #endif obviously it also needs a runtime check: if (QX11Info::isPlatformX11())

Re: Review Request 121390: make Qt5 theme build on Linux again

2015-03-01 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121390/ --- (Updated March 1, 2015, 10:02 p.m.) Status -- This change has been

Re: Review Request 121390: make Qt5 theme build on Linux again

2014-12-08 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121390/ --- (Updated Dec. 8, 2014, 2:38 p.m.) Review request for KDE Frameworks, Qt

Re: Review Request 121390: make Qt5 theme build on Linux again

2014-12-08 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121390/#review71553 --- this is wrong - please have a look at various frameworks on

Re: Review Request 121390: make Qt5 theme build on Linux again

2014-12-08 Thread René J . V . Bertin
On Dec. 8, 2014, 3:07 p.m., Martin Gräßlin wrote: this is wrong - please have a look at various frameworks on how to do it properly. In the end it should be: #if HAVE_X11 // x11 specific stuff #endif obviously it also needs a runtime check: if (QX11Info::isPlatformX11())

Re: Review Request 121390: make Qt5 theme build on Linux again

2014-12-08 Thread Martin Gräßlin
On Dec. 8, 2014, 3:07 p.m., Martin Gräßlin wrote: this is wrong - please have a look at various frameworks on how to do it properly. In the end it should be: #if HAVE_X11 // x11 specific stuff #endif obviously it also needs a runtime check: if (QX11Info::isPlatformX11())

Re: Review Request 121390: make Qt5 theme build on Linux again

2014-12-08 Thread René J . V . Bertin
On Dec. 8, 2014, 3:07 p.m., Martin Gräßlin wrote: this is wrong - please have a look at various frameworks on how to do it properly. In the end it should be: #if HAVE_X11 // x11 specific stuff #endif obviously it also needs a runtime check: if (QX11Info::isPlatformX11())

Re: Review Request 121390: make Qt5 theme build on Linux again

2014-12-08 Thread Thomas Lübking
On Dez. 8, 2014, 2:07 nachm., Martin Gräßlin wrote: this is wrong - please have a look at various frameworks on how to do it properly. In the end it should be: #if HAVE_X11 // x11 specific stuff #endif obviously it also needs a runtime check: if (QX11Info::isPlatformX11())

Re: Review Request 121390: make Qt5 theme build on Linux again

2014-12-08 Thread Martin Gräßlin
On Dec. 8, 2014, 3:07 p.m., Martin Gräßlin wrote: this is wrong - please have a look at various frameworks on how to do it properly. In the end it should be: #if HAVE_X11 // x11 specific stuff #endif obviously it also needs a runtime check: if (QX11Info::isPlatformX11())

Re: Review Request 121390: make Qt5 theme build on Linux again

2014-12-08 Thread René J . V . Bertin
On Dec. 8, 2014, 3:07 p.m., Martin Gräßlin wrote: this is wrong - please have a look at various frameworks on how to do it properly. In the end it should be: #if HAVE_X11 // x11 specific stuff #endif obviously it also needs a runtime check: if (QX11Info::isPlatformX11())

Re: Review Request 121390: make Qt5 theme build on Linux again

2014-12-08 Thread Martin Gräßlin
On Dec. 8, 2014, 3:07 p.m., Martin Gräßlin wrote: this is wrong - please have a look at various frameworks on how to do it properly. In the end it should be: #if HAVE_X11 // x11 specific stuff #endif obviously it also needs a runtime check: if (QX11Info::isPlatformX11())

Re: Review Request 121390: make Qt5 theme build on Linux again

2014-12-08 Thread René J . V . Bertin
On Dec. 8, 2014, 3:07 p.m., Martin Gräßlin wrote: this is wrong - please have a look at various frameworks on how to do it properly. In the end it should be: #if HAVE_X11 // x11 specific stuff #endif obviously it also needs a runtime check: if (QX11Info::isPlatformX11())

Re: Review Request 121390: make Qt5 theme build on Linux again

2014-12-08 Thread René J . V . Bertin
On Dec. 8, 2014, 3:07 p.m., Martin Gräßlin wrote: this is wrong - please have a look at various frameworks on how to do it properly. In the end it should be: #if HAVE_X11 // x11 specific stuff #endif obviously it also needs a runtime check: if (QX11Info::isPlatformX11())

Re: Review Request 121390: make Qt5 theme build on Linux again

2014-12-08 Thread Thomas Lübking
On Dez. 8, 2014, 2:07 nachm., Martin Gräßlin wrote: this is wrong - please have a look at various frameworks on how to do it properly. In the end it should be: #if HAVE_X11 // x11 specific stuff #endif obviously it also needs a runtime check: if (QX11Info::isPlatformX11())

Re: Review Request 121390: make Qt5 theme build on Linux again

2014-12-08 Thread René J . V . Bertin
On Dec. 8, 2014, 3:07 p.m., Martin Gräßlin wrote: this is wrong - please have a look at various frameworks on how to do it properly. In the end it should be: #if HAVE_X11 // x11 specific stuff #endif obviously it also needs a runtime check: if (QX11Info::isPlatformX11())

Re: Review Request 121390: make Qt5 theme build on Linux again

2014-12-08 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121390/ --- (Updated Dec. 8, 2014, 10:59 p.m.) Review request for KDE Frameworks, Qt