Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2016-01-25 Thread Gregor Mi
> On Jan. 23, 2016, 5:31 p.m., Gregor Mi wrote: > > > If someone has changed the shortcut, they should know what shortcut they > > > set it to, right? So having the tooltip just say "To kill a specific > > > window, press the "Kill Window" shortcut (Ctrl-Alt-Esc by default)" > > > should do

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2016-01-25 Thread Thomas Pfeiffer
> On Jan. 23, 2016, 5:31 p.m., Gregor Mi wrote: > > > If someone has changed the shortcut, they should know what shortcut they > > > set it to, right? So having the tooltip just say "To kill a specific > > > window, press the "Kill Window" shortcut (Ctrl-Alt-Esc by default)" > > > should do

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2016-01-25 Thread Gregor Mi
> On Jan. 23, 2016, 5:31 p.m., Gregor Mi wrote: > > > If someone has changed the shortcut, they should know what shortcut they > > > set it to, right? So having the tooltip just say "To kill a specific > > > window, press the "Kill Window" shortcut (Ctrl-Alt-Esc by default)" > > > should do

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2016-01-25 Thread Martin Gräßlin
> On Jan. 23, 2016, 6:31 p.m., Gregor Mi wrote: > > > If someone has changed the shortcut, they should know what shortcut they > > > set it to, right? So having the tooltip just say "To kill a specific > > > window, press the "Kill Window" shortcut (Ctrl-Alt-Esc by default)" > > > should do

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2016-01-24 Thread Thomas Lübking
> On Jan. 23, 2016, 5:31 p.m., Gregor Mi wrote: > > > If someone has changed the shortcut, they should know what shortcut they > > > set it to, right? So having the tooltip just say "To kill a specific > > > window, press the "Kill Window" shortcut (Ctrl-Alt-Esc by default)" > > > should do

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2016-01-24 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122249/ --- (Updated Jan. 24, 2016, 11:09 a.m.) Review request for KDE Base Apps,

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2016-01-24 Thread Gregor Mi
> On Jan. 23, 2016, 5:31 p.m., Gregor Mi wrote: > > > If someone has changed the shortcut, they should know what shortcut they > > > set it to, right? So having the tooltip just say "To kill a specific > > > window, press the "Kill Window" shortcut (Ctrl-Alt-Esc by default)" > > > should do

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2016-01-24 Thread Thomas Pfeiffer
> On Jan. 23, 2016, 5:31 p.m., Gregor Mi wrote: > > > If someone has changed the shortcut, they should know what shortcut they > > > set it to, right? So having the tooltip just say "To kill a specific > > > window, press the "Kill Window" shortcut (Ctrl-Alt-Esc by default)" > > > should do

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2016-01-23 Thread Gregor Mi
> On Jan. 23, 2016, 5:31 p.m., Gregor Mi wrote: > > > If someone has changed the shortcut, they should know what shortcut they > > > set it to, right? So having the tooltip just say "To kill a specific > > > window, press the "Kill Window" shortcut (Ctrl-Alt-Esc by default)" > > > should do

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2016-01-23 Thread Thomas Pfeiffer
> On Jan. 23, 2016, 5:31 p.m., Gregor Mi wrote: > > > If someone has changed the shortcut, they should know what shortcut they > > > set it to, right? So having the tooltip just say "To kill a specific > > > window, press the "Kill Window" shortcut (Ctrl-Alt-Esc by default)" > > > should do

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2016-01-23 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122249/#review91486 --- > If someone has changed the shortcut, they should know what

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2016-01-23 Thread Gregor Mi
> On April 20, 2015, 10:36 p.m., Thomas Pfeiffer wrote: > > What would likely be confusing is that the two button modes have different > > interaction flows: The "End Process" mode requires to first select a > > process and then press the button to work, whereas the "Kill specific > > window"

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2016-01-23 Thread Thomas Lübking
> On Jan. 23, 2016, 5:31 p.m., Gregor Mi wrote: > > > If someone has changed the shortcut, they should know what shortcut they > > > set it to, right? So having the tooltip just say "To kill a specific > > > window, press the "Kill Window" shortcut (Ctrl-Alt-Esc by default)" > > > should do

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2016-01-23 Thread Gregor Mi
> On Jan. 23, 2016, 5:31 p.m., Gregor Mi wrote: > > > If someone has changed the shortcut, they should know what shortcut they > > > set it to, right? So having the tooltip just say "To kill a specific > > > window, press the "Kill Window" shortcut (Ctrl-Alt-Esc by default)" > > > should do

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2016-01-23 Thread Gregor Mi
> On Jan. 23, 2016, 5:31 p.m., Gregor Mi wrote: > > > If someone has changed the shortcut, they should know what shortcut they > > > set it to, right? So having the tooltip just say "To kill a specific > > > window, press the "Kill Window" shortcut (Ctrl-Alt-Esc by default)" > > > should do

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2016-01-23 Thread Thomas Pfeiffer
> On Jan. 23, 2016, 5:31 p.m., Gregor Mi wrote: > > > If someone has changed the shortcut, they should know what shortcut they > > > set it to, right? So having the tooltip just say "To kill a specific > > > window, press the "Kill Window" shortcut (Ctrl-Alt-Esc by default)" > > > should do

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2016-01-23 Thread Ken Vermette
> On Jan. 23, 2016, 5:31 p.m., Gregor Mi wrote: > > > If someone has changed the shortcut, they should know what shortcut they > > > set it to, right? So having the tooltip just say "To kill a specific > > > window, press the "Kill Window" shortcut (Ctrl-Alt-Esc by default)" > > > should do

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2016-01-23 Thread Ken Vermette
> On Jan. 23, 2016, 5:31 p.m., Gregor Mi wrote: > > > If someone has changed the shortcut, they should know what shortcut they > > > set it to, right? So having the tooltip just say "To kill a specific > > > window, press the "Kill Window" shortcut (Ctrl-Alt-Esc by default)" > > > should do

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2016-01-22 Thread Gregor Mi
> On April 20, 2015, 10:36 p.m., Thomas Pfeiffer wrote: > > What would likely be confusing is that the two button modes have different > > interaction flows: The "End Process" mode requires to first select a > > process and then press the button to work, whereas the "Kill specific > > window"

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2016-01-22 Thread Thomas Pfeiffer
> On April 20, 2015, 10:36 p.m., Thomas Pfeiffer wrote: > > What would likely be confusing is that the two button modes have different > > interaction flows: The "End Process" mode requires to first select a > > process and then press the button to work, whereas the "Kill specific > > window"

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-08-09 Thread Gregor Mi
On April 20, 2015, 10:36 p.m., Thomas Pfeiffer wrote: What would likely be confusing is that the two button modes have different interaction flows: The End Process mode requires to first select a process and then press the button to work, whereas the Kill specific window mode

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-05-21 Thread Gregor Mi
On April 20, 2015, 10:36 p.m., Thomas Pfeiffer wrote: What would likely be confusing is that the two button modes have different interaction flows: The End Process mode requires to first select a process and then press the button to work, whereas the Kill specific window mode

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-05-21 Thread Gregor Mi
On April 20, 2015, 10:36 p.m., Thomas Pfeiffer wrote: What would likely be confusing is that the two button modes have different interaction flows: The End Process mode requires to first select a process and then press the button to work, whereas the Kill specific window mode

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-04-29 Thread Gregor Mi
On April 20, 2015, 10:36 p.m., Thomas Pfeiffer wrote: What would likely be confusing is that the two button modes have different interaction flows: The End Process mode requires to first select a process and then press the button to work, whereas the Kill specific window mode

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-04-27 Thread Thomas Pfeiffer
On April 20, 2015, 10:36 p.m., Thomas Pfeiffer wrote: What would likely be confusing is that the two button modes have different interaction flows: The End Process mode requires to first select a process and then press the button to work, whereas the Kill specific window mode

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-04-27 Thread Gregor Mi
On April 20, 2015, 10:36 p.m., Thomas Pfeiffer wrote: What would likely be confusing is that the two button modes have different interaction flows: The End Process mode requires to first select a process and then press the button to work, whereas the Kill specific window mode

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-04-27 Thread Martin Gräßlin
On April 21, 2015, 12:36 a.m., Thomas Pfeiffer wrote: What would likely be confusing is that the two button modes have different interaction flows: The End Process mode requires to first select a process and then press the button to work, whereas the Kill specific window mode

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-04-27 Thread Thomas Lübking
On April 20, 2015, 10:36 nachm., Thomas Pfeiffer wrote: What would likely be confusing is that the two button modes have different interaction flows: The End Process mode requires to first select a process and then press the button to work, whereas the Kill specific window mode

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-04-27 Thread Thomas Lübking
On April 20, 2015, 10:36 nachm., Thomas Pfeiffer wrote: What would likely be confusing is that the two button modes have different interaction flows: The End Process mode requires to first select a process and then press the button to work, whereas the Kill specific window mode

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-04-26 Thread Thomas Pfeiffer
On April 20, 2015, 10:36 p.m., Thomas Pfeiffer wrote: What would likely be confusing is that the two button modes have different interaction flows: The End Process mode requires to first select a process and then press the button to work, whereas the Kill specific window mode

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-04-24 Thread Gregor Mi
On April 20, 2015, 10:36 p.m., Thomas Pfeiffer wrote: What would likely be confusing is that the two button modes have different interaction flows: The End Process mode requires to first select a process and then press the button to work, whereas the Kill specific window mode

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-04-22 Thread Gregor Mi
On April 20, 2015, 10:36 p.m., Thomas Pfeiffer wrote: What would likely be confusing is that the two button modes have different interaction flows: The End Process mode requires to first select a process and then press the button to work, whereas the Kill specific window mode

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-04-20 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122249/ --- (Updated April 20, 2015, 10:24 p.m.) Review request for KDE Base Apps,

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-04-20 Thread Gregor Mi
On April 20, 2015, 10:36 p.m., Thomas Pfeiffer wrote: What would likely be confusing is that the two button modes have different interaction flows: The End Process mode requires to first select a process and then press the button to work, whereas the Kill specific window mode

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-04-20 Thread Thomas Pfeiffer
On April 20, 2015, 10:36 p.m., Thomas Pfeiffer wrote: What would likely be confusing is that the two button modes have different interaction flows: The End Process mode requires to first select a process and then press the button to work, whereas the Kill specific window mode

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-04-20 Thread Thomas Pfeiffer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122249/#review79262 --- What would likely be confusing is that the two button modes

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-04-17 Thread Gregor Mi
On April 16, 2015, 3:14 p.m., Martin Gräßlin wrote: CMakeLists.txt, lines 22-33 https://git.reviewboard.kde.org/r/122249/diff/9/?file=360665#file360665line22 do we still need all those? I only see GlobalAccel used as a new dependency or am I missing something? Previously those

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-04-17 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122249/#review79097 --- I'm still not sure about the text for the message box: could

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-04-17 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122249/ --- (Updated April 17, 2015, 7:25 a.m.) Review request for KDE Base Apps,

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-04-17 Thread Gregor Mi
On April 17, 2015, 7:31 a.m., Martin Gräßlin wrote: I'm still not sure about the text for the message box: could you please add Thomas Pfeiffer from Usability team to the review to get him comment on it? Sure. I'll add him. - Gregor

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-04-17 Thread Gregor Mi
On April 17, 2015, 7:31 a.m., Martin Gräßlin wrote: I'm still not sure about the text for the message box: could you please add Thomas Pfeiffer from Usability team to the review to get him comment on it? Gregor Mi wrote: Sure. I'll add him. I updated the text. Message box without

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-04-17 Thread Gregor Mi
On April 16, 2015, 3:14 p.m., Martin Gräßlin wrote: processui/ksysguardprocesslist.cpp, line 359 https://git.reviewboard.kde.org/r/122249/diff/9/?file=360668#file360668line359 You could know whether kwin is used - the window manager name is exported to the root window.

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-04-17 Thread Gregor Mi
On April 16, 2015, 3:14 p.m., Martin Gräßlin wrote: processui/ksysguardprocesslist.cpp, line 359 https://git.reviewboard.kde.org/r/122249/diff/9/?file=360668#file360668line359 You could know whether kwin is used - the window manager name is exported to the root window.

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-04-17 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122249/ --- (Updated April 17, 2015, 8:33 a.m.) Review request for KDE Base Apps,

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-04-17 Thread Thomas Lübking
On April 16, 2015, 3:14 nachm., Martin Gräßlin wrote: processui/ksysguardprocesslist.cpp, line 359 https://git.reviewboard.kde.org/r/122249/diff/9/?file=360668#file360668line359 You could know whether kwin is used - the window manager name is exported to the root window.

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-04-17 Thread Thomas Lübking
On April 16, 2015, 3:14 nachm., Martin Gräßlin wrote: processui/ksysguardprocesslist.cpp, line 359 https://git.reviewboard.kde.org/r/122249/diff/9/?file=360668#file360668line359 You could know whether kwin is used - the window manager name is exported to the root window.

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-04-16 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122249/#review79059 --- Approach looks good to me, just a few minor cleanup comments

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-03-16 Thread Gregor Mi
On March 2, 2015, 7:47 a.m., Martin Gräßlin wrote: processui/keyboardshortcututil.cpp, line 46 https://git.reviewboard.kde.org/r/122249/diff/6/?file=351945#file351945line46 This looks to complicated. It should be much easier to do with the KGlobalAccel API: * create a

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-03-16 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122249/#review77589 --- processui/keyboardshortcututil.cpp

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-03-16 Thread Thomas Lübking
On März 2, 2015, 7:47 vorm., Martin Gräßlin wrote: processui/keyboardshortcututil.cpp, line 46 https://git.reviewboard.kde.org/r/122249/diff/6/?file=351945#file351945line46 This looks to complicated. It should be much easier to do with the KGlobalAccel API: * create a

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-03-16 Thread Martin Gräßlin
On March 2, 2015, 8:47 a.m., Martin Gräßlin wrote: processui/keyboardshortcututil.cpp, line 46 https://git.reviewboard.kde.org/r/122249/diff/6/?file=351945#file351945line46 This looks to complicated. It should be much easier to do with the KGlobalAccel API: * create a

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-03-16 Thread Thomas Lübking
On März 2, 2015, 7:47 vorm., Martin Gräßlin wrote: processui/keyboardshortcututil.cpp, line 46 https://git.reviewboard.kde.org/r/122249/diff/6/?file=351945#file351945line46 This looks to complicated. It should be much easier to do with the KGlobalAccel API: * create a

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-03-13 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122249/ --- (Updated March 13, 2015, 7:27 p.m.) Review request for KDE Base Apps,

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-03-13 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122249/ --- (Updated March 13, 2015, 7:29 p.m.) Review request for KDE Base Apps,

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-03-13 Thread Gregor Mi
On March 2, 2015, 7:47 a.m., Martin Gräßlin wrote: processui/keyboardshortcututil.cpp, line 46 https://git.reviewboard.kde.org/r/122249/diff/6/?file=351945#file351945line46 This looks to complicated. It should be much easier to do with the KGlobalAccel API: * create a

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-03-13 Thread Thomas Lübking
On März 2, 2015, 7:47 vorm., Martin Gräßlin wrote: processui/keyboardshortcututil.cpp, line 46 https://git.reviewboard.kde.org/r/122249/diff/6/?file=351945#file351945line46 This looks to complicated. It should be much easier to do with the KGlobalAccel API: * create a

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-03-13 Thread Gregor Mi
On March 2, 2015, 7:47 a.m., Martin Gräßlin wrote: processui/keyboardshortcututil.cpp, line 46 https://git.reviewboard.kde.org/r/122249/diff/6/?file=351945#file351945line46 This looks to complicated. It should be much easier to do with the KGlobalAccel API: * create a

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-03-13 Thread Gregor Mi
On March 2, 2015, 7:47 a.m., Martin Gräßlin wrote: processui/keyboardshortcututil.cpp, line 46 https://git.reviewboard.kde.org/r/122249/diff/6/?file=351945#file351945line46 This looks to complicated. It should be much easier to do with the KGlobalAccel API: * create a

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-03-13 Thread Gregor Mi
On March 2, 2015, 7:47 a.m., Martin Gräßlin wrote: processui/keyboardshortcututil.cpp, line 46 https://git.reviewboard.kde.org/r/122249/diff/6/?file=351945#file351945line46 This looks to complicated. It should be much easier to do with the KGlobalAccel API: * create a

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-03-13 Thread Thomas Lübking
On März 2, 2015, 7:47 vorm., Martin Gräßlin wrote: processui/keyboardshortcututil.cpp, line 46 https://git.reviewboard.kde.org/r/122249/diff/6/?file=351945#file351945line46 This looks to complicated. It should be much easier to do with the KGlobalAccel API: * create a

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-03-13 Thread Gregor Mi
On March 2, 2015, 7:47 a.m., Martin Gräßlin wrote: processui/keyboardshortcututil.cpp, line 46 https://git.reviewboard.kde.org/r/122249/diff/6/?file=351945#file351945line46 This looks to complicated. It should be much easier to do with the KGlobalAccel API: * create a

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-03-13 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122249/ --- (Updated March 13, 2015, 10:08 p.m.) Review request for KDE Base Apps,

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-03-13 Thread Gregor Mi
On March 2, 2015, 7:47 a.m., Martin Gräßlin wrote: processui/keyboardshortcututil.cpp, line 46 https://git.reviewboard.kde.org/r/122249/diff/6/?file=351945#file351945line46 This looks to complicated. It should be much easier to do with the KGlobalAccel API: * create a

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-03-13 Thread Gregor Mi
On March 2, 2015, 7:47 a.m., Martin Gräßlin wrote: processui/keyboardshortcututil.cpp, line 46 https://git.reviewboard.kde.org/r/122249/diff/6/?file=351945#file351945line46 This looks to complicated. It should be much easier to do with the KGlobalAccel API: * create a

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-03-13 Thread Gregor Mi
On March 2, 2015, 7:47 a.m., Martin Gräßlin wrote: processui/keyboardshortcututil.cpp, line 46 https://git.reviewboard.kde.org/r/122249/diff/6/?file=351945#file351945line46 This looks to complicated. It should be much easier to do with the KGlobalAccel API: * create a

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-03-13 Thread Martin Gräßlin
On March 2, 2015, 8:47 a.m., Martin Gräßlin wrote: processui/keyboardshortcututil.cpp, line 46 https://git.reviewboard.kde.org/r/122249/diff/6/?file=351945#file351945line46 This looks to complicated. It should be much easier to do with the KGlobalAccel API: * create a

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-03-13 Thread Gregor Mi
On March 2, 2015, 7:47 a.m., Martin Gräßlin wrote: processui/keyboardshortcututil.cpp, line 46 https://git.reviewboard.kde.org/r/122249/diff/6/?file=351945#file351945line46 This looks to complicated. It should be much easier to do with the KGlobalAccel API: * create a

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-03-13 Thread Gregor Mi
On March 2, 2015, 7:47 a.m., Martin Gräßlin wrote: processui/keyboardshortcututil.cpp, line 46 https://git.reviewboard.kde.org/r/122249/diff/6/?file=351945#file351945line46 This looks to complicated. It should be much easier to do with the KGlobalAccel API: * create a

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-03-13 Thread Gregor Mi
On March 2, 2015, 7:47 a.m., Martin Gräßlin wrote: processui/keyboardshortcututil.cpp, line 46 https://git.reviewboard.kde.org/r/122249/diff/6/?file=351945#file351945line46 This looks to complicated. It should be much easier to do with the KGlobalAccel API: * create a

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-03-13 Thread Martin Gräßlin
On March 2, 2015, 8:47 a.m., Martin Gräßlin wrote: processui/keyboardshortcututil.cpp, line 46 https://git.reviewboard.kde.org/r/122249/diff/6/?file=351945#file351945line46 This looks to complicated. It should be much easier to do with the KGlobalAccel API: * create a

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-03-13 Thread Martin Gräßlin
On March 2, 2015, 8:47 a.m., Martin Gräßlin wrote: processui/keyboardshortcututil.cpp, line 46 https://git.reviewboard.kde.org/r/122249/diff/6/?file=351945#file351945line46 This looks to complicated. It should be much easier to do with the KGlobalAccel API: * create a

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-03-13 Thread Gregor Mi
On March 2, 2015, 7:47 a.m., Martin Gräßlin wrote: processui/keyboardshortcututil.cpp, line 46 https://git.reviewboard.kde.org/r/122249/diff/6/?file=351945#file351945line46 This looks to complicated. It should be much easier to do with the KGlobalAccel API: * create a

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-03-13 Thread Gregor Mi
On March 2, 2015, 7:47 a.m., Martin Gräßlin wrote: processui/keyboardshortcututil.cpp, line 46 https://git.reviewboard.kde.org/r/122249/diff/6/?file=351945#file351945line46 This looks to complicated. It should be much easier to do with the KGlobalAccel API: * create a

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-03-12 Thread Martin Gräßlin
On March 2, 2015, 8:47 a.m., Martin Gräßlin wrote: processui/keyboardshortcututil.cpp, line 46 https://git.reviewboard.kde.org/r/122249/diff/6/?file=351945#file351945line46 This looks to complicated. It should be much easier to do with the KGlobalAccel API: * create a

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-03-11 Thread Thomas Lübking
On März 2, 2015, 7:47 vorm., Martin Gräßlin wrote: processui/keyboardshortcututil.cpp, line 46 https://git.reviewboard.kde.org/r/122249/diff/6/?file=351945#file351945line46 This looks to complicated. It should be much easier to do with the KGlobalAccel API: * create a

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-03-09 Thread Gregor Mi
On March 2, 2015, 7:47 a.m., Martin Gräßlin wrote: processui/keyboardshortcututil.cpp, line 46 https://git.reviewboard.kde.org/r/122249/diff/6/?file=351945#file351945line46 This looks to complicated. It should be much easier to do with the KGlobalAccel API: * create a

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-03-08 Thread Gregor Mi
On March 2, 2015, 7:47 a.m., Martin Gräßlin wrote: processui/keyboardshortcututil.cpp, line 46 https://git.reviewboard.kde.org/r/122249/diff/6/?file=351945#file351945line46 This looks to complicated. It should be much easier to do with the KGlobalAccel API: * create a

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-03-08 Thread Thomas Lübking
On März 2, 2015, 7:47 vorm., Martin Gräßlin wrote: processui/keyboardshortcututil.cpp, line 46 https://git.reviewboard.kde.org/r/122249/diff/6/?file=351945#file351945line46 This looks to complicated. It should be much easier to do with the KGlobalAccel API: * create a

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-02-26 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122249/ --- (Updated Feb. 27, 2015, 1:18 a.m.) Review request for KDE Base Apps,

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-02-23 Thread Thomas Lübking
On Jan. 26, 2015, 7:05 vorm., Martin Gräßlin wrote: My opinion is that this is a feature which should not be exposed in libksysguard. It actually ties libksysguard to KWin, while libksysguard was in the past also used in e.g. kdevelop. If libksysguard wants to offer the

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-02-23 Thread Martin Gräßlin
On Jan. 26, 2015, 8:05 a.m., Martin Gräßlin wrote: My opinion is that this is a feature which should not be exposed in libksysguard. It actually ties libksysguard to KWin, while libksysguard was in the past also used in e.g. kdevelop. If libksysguard wants to offer the

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-02-23 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122249/ --- (Updated Feb. 23, 2015, 9:15 p.m.) Review request for KDE Base Apps,

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-02-23 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122249/#review76499 --- After update to latest master I got a crash (in master) of

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-02-23 Thread Martin Gräßlin
On Jan. 26, 2015, 8:05 a.m., Martin Gräßlin wrote: My opinion is that this is a feature which should not be exposed in libksysguard. It actually ties libksysguard to KWin, while libksysguard was in the past also used in e.g. kdevelop. If libksysguard wants to offer the

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-02-21 Thread Thomas Lübking
On Jan. 26, 2015, 7:05 vorm., Martin Gräßlin wrote: My opinion is that this is a feature which should not be exposed in libksysguard. It actually ties libksysguard to KWin, while libksysguard was in the past also used in e.g. kdevelop. If libksysguard wants to offer the

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-02-21 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122249/ --- (Updated Feb. 20, 2015, 11:35 p.m.) Review request for KDE Base Apps,

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-02-21 Thread Thomas Lübking
On Jan. 26, 2015, 7:05 vorm., Martin Gräßlin wrote: My opinion is that this is a feature which should not be exposed in libksysguard. It actually ties libksysguard to KWin, while libksysguard was in the past also used in e.g. kdevelop. If libksysguard wants to offer the

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-02-21 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122249/#review76389 --- processui/ksysguardprocesslist.cpp

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-02-21 Thread Gregor Mi
On Jan. 26, 2015, 7:05 a.m., Martin Gräßlin wrote: My opinion is that this is a feature which should not be exposed in libksysguard. It actually ties libksysguard to KWin, while libksysguard was in the past also used in e.g. kdevelop. If libksysguard wants to offer the

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-02-21 Thread Gregor Mi
On Feb. 21, 2015, 4:08 p.m., Thomas Lübking wrote: processui/ksysguardprocesslist.cpp, line 367 https://git.reviewboard.kde.org/r/122249/diff/4/?file=350459#file350459line367 leaving aside that the patch is not clean (still contains kglobalaccel stuff, ie. is probably just a

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-02-21 Thread Gregor Mi
On Jan. 26, 2015, 7:05 a.m., Martin Gräßlin wrote: My opinion is that this is a feature which should not be exposed in libksysguard. It actually ties libksysguard to KWin, while libksysguard was in the past also used in e.g. kdevelop. If libksysguard wants to offer the

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-01-29 Thread Martin Gräßlin
On Jan. 26, 2015, 8:05 a.m., Martin Gräßlin wrote: My opinion is that this is a feature which should not be exposed in libksysguard. It actually ties libksysguard to KWin, while libksysguard was in the past also used in e.g. kdevelop. If libksysguard wants to offer the

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-01-29 Thread Gregor Mi
On Jan. 26, 2015, 7:05 a.m., Martin Gräßlin wrote: My opinion is that this is a feature which should not be exposed in libksysguard. It actually ties libksysguard to KWin, while libksysguard was in the past also used in e.g. kdevelop. If libksysguard wants to offer the

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-01-28 Thread Gregor Mi
On Jan. 26, 2015, 7:05 a.m., Martin Gräßlin wrote: My opinion is that this is a feature which should not be exposed in libksysguard. It actually ties libksysguard to KWin, while libksysguard was in the past also used in e.g. kdevelop. If libksysguard wants to offer the

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-01-28 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122249/ --- (Updated Jan. 28, 2015, 8:35 p.m.) Review request for KDE Base Apps,

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-01-27 Thread Gregor Mi
On Jan. 26, 2015, 7:05 a.m., Martin Gräßlin wrote: My opinion is that this is a feature which should not be exposed in libksysguard. It actually ties libksysguard to KWin, while libksysguard was in the past also used in e.g. kdevelop. If libksysguard wants to offer the

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-01-27 Thread Thomas Lübking
On Jan. 26, 2015, 7:05 vorm., Martin Gräßlin wrote: My opinion is that this is a feature which should not be exposed in libksysguard. It actually ties libksysguard to KWin, while libksysguard was in the past also used in e.g. kdevelop. If libksysguard wants to offer the

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-01-26 Thread Gregor Mi
On Jan. 26, 2015, 7:05 a.m., Martin Gräßlin wrote: My opinion is that this is a feature which should not be exposed in libksysguard. It actually ties libksysguard to KWin, while libksysguard was in the past also used in e.g. kdevelop. If libksysguard wants to offer the

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-01-26 Thread Thomas Lübking
On Jan. 26, 2015, 7:05 vorm., Martin Gräßlin wrote: My opinion is that this is a feature which should not be exposed in libksysguard. It actually ties libksysguard to KWin, while libksysguard was in the past also used in e.g. kdevelop. If libksysguard wants to offer the

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-01-26 Thread Martin Gräßlin
On Jan. 26, 2015, 8:05 a.m., Martin Gräßlin wrote: My opinion is that this is a feature which should not be exposed in libksysguard. It actually ties libksysguard to KWin, while libksysguard was in the past also used in e.g. kdevelop. If libksysguard wants to offer the

  1   2   >