Re: Review Request 122270: port kcminit away from kdelibs4support

2015-01-29 Thread Thomas Lübking
On Jan. 29, 2015, 2:36 nachm., Martin Gräßlin wrote: I'm surprised that you pushed the change although the review was not finished and you hadn't a shipit on any of the versions. Nick, though it does not seem as if you had introduced it, the QGuiApplication::screens().count() 1 check

Re: Review Request 122270: port kcminit away from kdelibs4support

2015-01-29 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122270/#review74973 --- I still think this is wrong as

Re: Review Request 122270: port kcminit away from kdelibs4support

2015-01-29 Thread Nick Shaforostoff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122270/ --- (Updated Jan. 29, 2015, 11:58 a.m.) Status -- This change has been

Re: Review Request 122270: port kcminit away from kdelibs4support

2015-01-29 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122270/#review74982 --- I'm surprised that you pushed the change although the review

Re: Review Request 122270: port kcminit away from kdelibs4support

2015-01-29 Thread Nick Shaforostoff
On Січ. 29, 2015, 2:36 після полудня, Martin Gräßlin wrote: I'm surprised that you pushed the change although the review was not finished and you hadn't a shipit on any of the versions. Thomas Lübking wrote: Nick, though it does not seem as if you had introduced it, the

Re: Review Request 122270: port kcminit away from kdelibs4support

2015-01-29 Thread Nick Shaforostoff
On Січ. 29, 2015, 2:36 після полудня, Martin Gräßlin wrote: I'm surprised that you pushed the change although the review was not finished and you hadn't a shipit on any of the versions. Thomas Lübking wrote: Nick, though it does not seem as if you had introduced it, the

Re: Review Request 122270: port kcminit away from kdelibs4support

2015-01-28 Thread Martin Gräßlin
On Jan. 27, 2015, 7:59 a.m., Martin Gräßlin wrote: startkde/kcminit/main.cpp, lines 250-254 https://git.reviewboard.kde.org/r/122270/diff/1/?file=345342#file345342line250 I do not like this. If the only need is to check whether it's X11 multi-head, it should open an

Re: Review Request 122270: port kcminit away from kdelibs4support

2015-01-28 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122270/#review74892 --- startkde/kcminit/main.cpp

Re: Review Request 122270: port kcminit away from kdelibs4support

2015-01-28 Thread Thomas Lübking
On Jan. 27, 2015, 6:59 vorm., Martin Gräßlin wrote: startkde/kcminit/main.cpp, lines 250-254 https://git.reviewboard.kde.org/r/122270/diff/1/?file=345342#file345342line250 I do not like this. If the only need is to check whether it's X11 multi-head, it should open an

Re: Review Request 122270: port kcminit away from kdelibs4support

2015-01-28 Thread Nick Shaforostoff
On Jan. 27, 2015, 6:59 a.m., Martin Gräßlin wrote: startkde/kcminit/main.cpp, lines 250-254 https://git.reviewboard.kde.org/r/122270/diff/1/?file=345342#file345342line250 I do not like this. If the only need is to check whether it's X11 multi-head, it should open an

Re: Review Request 122270: port kcminit away from kdelibs4support

2015-01-28 Thread Martin Gräßlin
On Jan. 27, 2015, 7:59 a.m., Martin Gräßlin wrote: startkde/kcminit/main.cpp, lines 250-254 https://git.reviewboard.kde.org/r/122270/diff/1/?file=345342#file345342line250 I do not like this. If the only need is to check whether it's X11 multi-head, it should open an

Re: Review Request 122270: port kcminit away from kdelibs4support

2015-01-28 Thread Nick Shaforostoff
On Jan. 27, 2015, 6:59 a.m., Martin Gräßlin wrote: startkde/kcminit/main.cpp, lines 250-254 https://git.reviewboard.kde.org/r/122270/diff/1/?file=345342#file345342line250 I do not like this. If the only need is to check whether it's X11 multi-head, it should open an

Re: Review Request 122270: port kcminit away from kdelibs4support

2015-01-28 Thread Nick Shaforostoff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122270/ --- (Updated Jan. 29, 2015, 1:19 a.m.) Review request for kde-workspace,

Re: Review Request 122270: port kcminit away from kdelibs4support

2015-01-28 Thread Nick Shaforostoff
On Jan. 27, 2015, 6:59 a.m., Martin Gräßlin wrote: startkde/kcminit/main.cpp, lines 250-254 https://git.reviewboard.kde.org/r/122270/diff/1/?file=345342#file345342line250 I do not like this. If the only need is to check whether it's X11 multi-head, it should open an

Re: Review Request 122270: port kcminit away from kdelibs4support

2015-01-28 Thread Thomas Lübking
On Jan. 27, 2015, 6:59 vorm., Martin Gräßlin wrote: startkde/kcminit/main.cpp, lines 250-254 https://git.reviewboard.kde.org/r/122270/diff/1/?file=345342#file345342line250 I do not like this. If the only need is to check whether it's X11 multi-head, it should open an

Re: Review Request 122270: port kcminit away from kdelibs4support

2015-01-27 Thread Nick Shaforostoff
On Січ. 27, 2015, 6:59 до полудня, Martin Gräßlin wrote: startkde/kcminit/main.cpp, lines 250-254 https://git.reviewboard.kde.org/r/122270/diff/1/?file=345342#file345342line250 I do not like this. If the only need is to check whether it's X11 multi-head, it should open an

Re: Review Request 122270: port kcminit away from kdelibs4support

2015-01-27 Thread Thomas Lübking
On Jan. 27, 2015, 6:59 vorm., Martin Gräßlin wrote: startkde/kcminit/main.cpp, lines 250-254 https://git.reviewboard.kde.org/r/122270/diff/1/?file=345342#file345342line250 I do not like this. If the only need is to check whether it's X11 multi-head, it should open an

Re: Review Request 122270: port kcminit away from kdelibs4support

2015-01-27 Thread Nick Shaforostoff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122270/ --- (Updated Jan. 28, 2015, 12:47 a.m.) Review request for kde-workspace,

Re: Review Request 122270: port kcminit away from kdelibs4support

2015-01-27 Thread Nick Shaforostoff
On Jan. 27, 2015, 6:59 a.m., Martin Gräßlin wrote: startkde/kcminit/main.cpp, lines 250-254 https://git.reviewboard.kde.org/r/122270/diff/1/?file=345342#file345342line250 I do not like this. If the only need is to check whether it's X11 multi-head, it should open an

Re: Review Request 122270: port kcminit away from kdelibs4support

2015-01-26 Thread Nick Shaforostoff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122270/#review74800 --- googling for KDE_MULTIHEAD revealed the real world use case

Review Request 122270: port kcminit away from kdelibs4support

2015-01-26 Thread Nick Shaforostoff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122270/ --- Review request for kde-workspace, Aleix Pol Gonzalez, Martin Gräßlin, and

Re: Review Request 122270: port kcminit away from kdelibs4support

2015-01-26 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122270/#review74806 --- startkde/kcminit/main.cpp