Re: KDE Review Request: KRDP

2024-05-22 Thread Akseli Lahtinen
Hi, the review period is over for KRDP and we'd like to officially include KRDP in 6.1. Here's the review request issue https://invent.kde.org/plasma/krdp/-/issues/17 Thanks! - Akseli Lahtinen On Thursday 2 May 2024 13:27:20 GMT+3 Akseli Lahtinen wrote: > Hi! > > Arjen H

KDE Review Request: KRDP

2024-05-02 Thread Akseli Lahtinen
request issue: https://invent.kde.org/plasma/krdp/-/issues/17 I'd like to get some reviews in and so on so we can get this in good shape. :) Thank you! - Akseli Lahtinen PS. My first review request, do tell me if I missed something! I followed this documentation for it https://develop.kde.org

Kalm: KDE Review Request

2023-10-16 Thread plata
Hello, Kalm has moved to KDE Review (https://invent.kde.org/plata/kalm/-/issues/2). Please take a look and raise an issue in GitLab if you see something that should be changed. It should probably go to https://invent.kde.org/utilities. Kalm visualizes breathing techniques to help you kalm down.

Re: Review request for MpvQt

2023-08-25 Thread Adriaan de Groot
I'll add to the review request. [ade] signature.asc Description: This is a digitally signed message part.

Re: Review request for MpvQt

2023-08-25 Thread Florea Banus George
Repo link has a comma at the end and I also forgot to link to the review issue, so here it is https://invent.kde.org/libraries/mpvqt/-/issues/1 On 25.08.2023 22:56, Florea Banus George wrote: Hello, please review https://invent.kde.org/libraries/mpvqt, a libmpv wrapper library for qtquick/qml

Review request for MpvQt

2023-08-25 Thread Florea Banus George
Hello, please review https://invent.kde.org/libraries/mpvqt, a libmpv wrapper library for qtquick/qml (no widgets). Here's my mail from kde-devel introducing the library: https://mail.kde.org/pipermail/kde-devel/2023-July/001912.html

Re: Review Request 102657: Show removable media in Dolphin's "Copy To" and "Move To" context menus

2019-09-29 Thread Rajeesh K V
discarded. Review request for Dolphin, KDE Base Apps and David Faure. Bugs: 251151 http://bugs.kde.org/show_bug.cgi?id=251151 Repository: kde-baseapps Description --- The most common usage for "{Copy,Move} To" dolphin context menus is that a user wants to copy/move a sel

Re: Review Request: plasma-thunderbolt

2019-05-21 Thread Jonathan Riddell
On Wed, May 15, 2019 at 03:27:07PM +0200, Daniel Vrátil wrote: > plasma-thunderbolt is a new repo containing, you guessed it, Thunderbolt KCM > for Plasma. I initially submitted the code as a patch against plasma-desktop > [0], where it got reviewed, but it was ultimately decided to better put it

Re: Review Request: plasma-thunderbolt

2019-05-16 Thread Daniel Vrátil
On Wednesday, 15 May 2019 23:08:57 CEST Albert Astals Cid wrote: > El dimecres, 15 de maig de 2019, a les 15:27:07 CEST, Daniel Vrátil va escriure: > > Hi all, > > > > plasma-thunderbolt is a new repo containing, you guessed it, Thunderbolt > > KCM for Plasma. I initially submitted the code as a

Re: Review Request: plasma-thunderbolt

2019-05-16 Thread Daniel Vrátil
On Wednesday, 15 May 2019 15:55:01 CEST Friedrich W. H. Kossebau wrote: > Am Mittwoch, 15. Mai 2019, 15:27:07 CEST schrieb Daniel Vrátil: > > Thus I'd kindly ask you to take one more look at the codebase [1] and let > > me know if there are any more issues to fix, or if we can proceed to > > includ

Re: Review Request: plasma-thunderbolt

2019-05-16 Thread Daniel Vrátil
On Wednesday, 15 May 2019 15:34:58 CEST Nate Graham wrote: > +1 from me; the original was good and this looks good too. > > One minor thing that I don't think should be a blocker: Could we copy > FindBolt.cmake into ECM with an eye towards not needing it here in a > future release? I think having

Re: Review Request: plasma-thunderbolt

2019-05-15 Thread Albert Astals Cid
El dimecres, 15 de maig de 2019, a les 15:27:07 CEST, Daniel Vrátil va escriure: > Hi all, > > plasma-thunderbolt is a new repo containing, you guessed it, Thunderbolt KCM > for Plasma. I initially submitted the code as a patch against plasma-desktop > [0], where it got reviewed, but it was ulti

Re: Review Request: plasma-thunderbolt

2019-05-15 Thread Nate Graham
+1 from me; the original was good and this looks good too. One minor thing that I don't think should be a blocker: Could we copy FindBolt.cmake into ECM with an eye towards not needing it here in a future release? Nate On 5/15/19 7:27 AM, Daniel Vrátil wrote: Hi all, plasma-thunderbolt is

Re: Review Request: plasma-thunderbolt

2019-05-15 Thread Friedrich W. H. Kossebau
Am Mittwoch, 15. Mai 2019, 15:27:07 CEST schrieb Daniel Vrátil: > Thus I'd kindly ask you to take one more look at the codebase [1] and let me > know if there are any more issues to fix, or if we can proceed to include > this in the next Plasma release. Pushed some small fixes to toplevel CMakeLis

Review Request: plasma-thunderbolt

2019-05-15 Thread Daniel Vrátil
Hi all, plasma-thunderbolt is a new repo containing, you guessed it, Thunderbolt KCM for Plasma. I initially submitted the code as a patch against plasma-desktop [0], where it got reviewed, but it was ultimately decided to better put it into a separate repository, since it's not just a KCM but

Re: Review request: plasma-pass

2019-01-04 Thread Daniel Vrátil
Hi Albert, thanks for the review! All the issues you mentioned are fixed in master now. Dan On Sunday, 16 December 2018 20:14:37 CET Albert Astals Cid wrote: > El dilluns, 10 de desembre de 2018, a les 14:49:28 CET, Daniel Vrátil va escriure: > > Hi folks, > > > > back in May I wrote a Plasma

Re: Review Request 101343: remove functions *Command::name() which are not used

2018-12-24 Thread Alexander Potashev
discarded. Review request for KDE Base Apps and David Faure. Repository: kde-baseapps Description --- konq-plugins/domtreeviewer builds without there functions. May be these functions were left for future integration of domtreeviewer undoable commands' into Konqueror's undo

Re: Review Request 101343: remove functions *Command::name() which are not used

2018-12-24 Thread Alexander Potashev
ander Potashev wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/101343/ > --- > > (Updated May 12, 2011, 1

Re: Review request: plasma-pass

2018-12-16 Thread Albert Astals Cid
El dilluns, 10 de desembre de 2018, a les 14:49:28 CET, Daniel Vrátil va escriure: > Hi folks, > > back in May I wrote a Plasma applet that serves as a GUI frontend for the > pass > password manager [0]. I blogged about it [1], but then somewhat forgot to > make > a release etc. Recently I st

Review request: plasma-pass

2018-12-10 Thread Daniel Vrátil
Hi folks, back in May I wrote a Plasma applet that serves as a GUI frontend for the pass password manager [0]. I blogged about it [1], but then somewhat forgot to make a release etc. Recently I started getting some emails from packagers where to get a tarballs so I think it's time to get some t

Re: Review Request 128854: Add a Tools button above the process list of System Monitor

2018-02-04 Thread Gregor Mi
discarded. Review request for KDE Base Apps, Martin Flöser, John Tapsell, Ken Vermette, Thomas Lübking, and Thomas Pfeiffer. Repository: libksysguard Description --- This adds a new "Tools" button to the ksysguard widget which contains entries to related tools: - Run Command

Re: Review Request 128854: Add a Tools button above the process list of System Monitor

2018-02-04 Thread Gregor Mi
org/r/128854/ > --- > > (Updated Aug. 3, 2017, 1:25 nachm.) > > > Review request for KDE Base Apps, Martin Flöser, John Tapsell, Ken Vermette, > Thomas Lübking, and Thomas Pfeiffer. > > > Repository: libksysguard > > > Description > --- > > This adds

Re: Review Request 130239: Exclude kconf_update from catching by uac on Windows

2017-12-27 Thread Ralf Habacker
marked as submitted. Review request for kdelibs and Albert Astals Cid. Changes --- Submitted with commit 246298e57ed7ff7a3cbabe5fc9f95957cb6dc257 by Ralf Habacker to branch KDE/4.14. Bugs: 384334 http://bugs.kde.org/show_bug.cgi?id=384334 Repository: kdelibs Description

Re: Review Request 130239: Exclude kconf_update from catching by uac on Windows

2017-12-26 Thread Ben Cooksley
017, 9:19 a.m., Ralf Habacker wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130239/ > --- > > (Updated Sept. 27, 2017, 9:19 a.m.) > > &g

Re: Review Request 130239: Exclude kconf_update from catching by uac on Windows

2017-12-26 Thread Ralf Habacker
mail. To reply, visit: > https://git.reviewboard.kde.org/r/130239/ > --- > > (Updated Sept. 27, 2017, 11:19 a.m.) > > > Review request for kdelibs and Albert Astals Cid. > > > Bugs: 384334 > http://

Re: Review Request 130239: Exclude kconf_update from catching by uac on Windows

2017-12-26 Thread Alexey Min
н. 27, 2017, 9:19 д.п.) > > > Review request for kdelibs and Albert Astals Cid. > > > Bugs: 384334 > http://bugs.kde.org/show_bug.cgi?id=384334 > > > Repository: kdelibs > > > Description > --- > > This patch fixes an issue that on the

Re: Review Request 130239: Exclude kconf_update from catching by uac on Windows

2017-12-26 Thread Ralf Habacker
org/r/130239/ > --- > > (Updated Sept. 27, 2017, 11:19 a.m.) > > > Review request for kdelibs and Albert Astals Cid. > > > Bugs: 384334 > http://bugs.kde.org/show_bug.cgi?id=384334 > > > Repository: kd

Re: Review Request 129233: [kdelibs] Make Qt4 WebKit optional (default on)

2017-10-21 Thread Michael Pyne
- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129233/ > --- > > (Updated Dec. 11, 2016, 3:07 p.m.) > > > Review request for kdelibs. > > > Repository: kdelibs > > > Description > --- >

Re: Review Request 129233: [kdelibs] Make Qt4 WebKit optional (default on)

2017-10-19 Thread Andreas Sturmlechner
This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129233/ > ----------- > > (Updated Dec. 11, 2016, 3:07 p.m.) > > > Review request for kdelibs. > > > Repository: kdelibs > > >

Re: Review Request 130239: Exclude kconf_update from catching by uac on Windows

2017-10-06 Thread Ralf Habacker
it.reviewboard.kde.org/r/130239/#review103738 --- On Sept. 27, 2017, 11:19 a.m., Ralf Habacker wrote: > > ------- > This is an automatically generated e-mail. To reply, v

Re: Review Request 130239: Exclude kconf_update from catching by uac on Windows

2017-09-29 Thread Luigi Toscano
-- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130239/#review103738 --- On Set. 27, 2017, 11:19 a.m., Ralf Habacker wrote: > > ----------- > This is an automatica

Re: Review Request 130239: Exclude kconf_update from catching by uac on Windows

2017-09-29 Thread Albert Astals Cid
e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130239/#review103738 --- On set. 27, 2017, 9:19 a.m., Ralf Habacker wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: Review Request 130239: Exclude kconf_update from catching by uac on Windows

2017-09-27 Thread Alexey Min
/git.reviewboard.kde.org/r/130239/#review103738 --- On Сен. 27, 2017, 9:19 д.п., Ralf Habacker wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130239/ &g

Re: Review Request 130239: Exclude kconf_update from catching by uac on Windows

2017-09-27 Thread Ralf Habacker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130239/ --- (Updated Sept. 27, 2017, 11:19 vorm.) Review request for kdelibs and

Re: Review Request 130239: Exclude kconf_update from catching by uac on Windows

2017-09-27 Thread Ralf Habacker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130239/ --- (Updated Sept. 27, 2017, 11:18 vorm.) Review request for kdelibs and

Re: Review Request 130239: Exclude kconf_update from catching by uac on Windows

2017-09-27 Thread Ralf Habacker
org/r/130239/ > --- > > (Updated Sept. 26, 2017, 9:54 vorm.) > > > Review request for kdelibs and Albert Astals Cid. > > > Bugs: 384334 > http://bugs.kde.org/show_bug.cgi?id=384334 > > > Reposit

Re: Review Request 130239: Exclude kconf_update from catching by uac on Windows

2017-09-26 Thread Albert Astals Cid
-- On set. 26, 2017, 7:54 a.m., Ralf Habacker wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130239/ > -----

Re: Review Request 130239: Exclude kconf_update from catching by uac on Windows

2017-09-26 Thread Ralf Habacker
ly, visit: > https://git.reviewboard.kde.org/r/130239/ > ------- > > (Updated Sept. 26, 2017, 9:54 a.m.) > > > Review request for kdelibs and Albert Astals Cid. > > > Bugs: 384334 > http://bugs.kde.org/show_bug.cgi?id=384334 > > > Repository: kdelibs >

Re: Review Request 130239: Exclude kconf_update from catching by uac on Windows

2017-09-26 Thread Albert Astals Cid
is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130239/ > --- > > (Updated set. 26, 2017, 7:54 a.m.) > > > Review request for kdelibs and Albert Astals Cid. > > > Bugs

Re: Review Request 130239: Exclude kconf_update from catching by uac on Windows

2017-09-26 Thread Ralf Habacker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130239/ --- (Updated Sept. 26, 2017, 9:54 vorm.) Review request for kdelibs and

Re: Review Request 130245: Fix Crash on JoyStick Config when js device did not contain regular joystick button

2017-09-20 Thread TOM Harrison via Review Board
discarded. Review request for kde-workspace. Repository: plasma-desktop Description --- This patch will fix the joystick config when detect "btnx keyboard" as joystick, It will crash. Due to Btnx keyboard is not a regular joystick. Just add one more if to fix this cras

Re: Review Request 130245: Fix Crash on JoyStick Config when js device did not contain regular joystick button

2017-09-20 Thread TOM Harrison via Review Board
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130245/#review103704 --- On 九月 16, 2017, 7:07 a.m., TOM Harrison wrote: > > --

Re: Review Request 130245: Fix Crash on JoyStick Config when js device did not contain regular joystick button

2017-09-20 Thread Albert Astals Cid
tps://git.reviewboard.kde.org/r/130245/#review103704 --- On set. 16, 2017, 7:07 a.m., TOM Harrison wrote: > > --- > This is an automatically generated e-mail. To reply, vi

Re: Review Request 130245: Fix Crash on JoyStick Config when js device did not contain regular joystick button

2017-09-20 Thread Albert Astals Cid
6, 2017, 7:07 a.m., TOM Harrison wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130245/ > --- > >

Re: Review Request 130245: Fix Crash on JoyStick Config when js device did not contain regular joystick button

2017-09-18 Thread TOM Harrison via Review Board
://git.reviewboard.kde.org/r/130245/#review103704 --- On 九月 16, 2017, 7:07 a.m., TOM Harrison wrote: > > ------- > This is an automatically generated e-mail. To reply, visit:

Re: Review Request 130245: Fix Crash on JoyStick Config when js device did not contain regular joystick button

2017-09-18 Thread Albert Astals Cid
-- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130245/#review103704 --- On set. 16, 2017, 7:07 a.m., TOM Harrison wrote: > > ----------- > This is an aut

Re: Review Request 130245: Fix Crash on JoyStick Config when js device did not contain regular joystick button

2017-09-17 Thread TOM Harrison via Review Board
On 九月 16, 2017, 7:07 a.m., TOM Harrison wrote: > > ------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130245/ > --- > &g

Re: Review Request 130245: Fix Crash on JoyStick Config when js device did not contain regular joystick button

2017-09-17 Thread Albert Astals Cid
- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130245/#review103704 --- On set. 16, 2017, 7:07 a.m., TOM Harrison wrote: > > ------- > This is an automatically generated e-mail.

Re: Review Request 130245: Fix Crash on JoyStick Config when js device did not contain regular joystick button

2017-09-16 Thread TOM Harrison via Review Board
-- On 九月 16, 2017, 7:07 a.m., TOM Harrison wrote: > > ------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130245/ > -

Re: Review Request 130245: Fix Crash on JoyStick Config when js device did not contain regular joystick button

2017-09-16 Thread TOM Harrison via Review Board
--- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130245/ > --- > > (Updated 九月 16, 2017, 7:07 a.m.) > > > Review request for kde-workspace. > > >

Re: Review Request 130245: Fix Crash on JoyStick Config when js device did not contain regular joystick button

2017-09-16 Thread Albert Astals Cid
ly, visit: https://git.reviewboard.kde.org/r/130245/#review103704 --- On set. 16, 2017, 7:07 a.m., TOM Harrison wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r

Re: Review Request 130245: Fix Crash on JoyStick Config when js device did not contain regular joystick button

2017-09-16 Thread TOM Harrison via Review Board
l. To reply, visit: > https://git.reviewboard.kde.org/r/130245/ > --- > > (Updated 九月 16, 2017, 7:07 a.m.) > > > Review request for kde-workspace. > > > Repository: plasma-desktop > > > Descriptio

Re: Review Request 130245: Fix Crash on JoyStick Config when js device did not contain regular joystick button

2017-09-16 Thread TOM Harrison via Review Board
-- On 九月 16, 2017, 7:07 a.m., TOM Harrison wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130245/ >

Re: Review Request 130245: Fix Crash on JoyStick Config when js device did not contain regular joystick button

2017-09-16 Thread Albert Astals Cid
- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130245/ > --- > > (Updated set. 16, 2017, 7:07 a.m.) > > > Review request for kde-workspace. >

Re: Review Request 130245: Fix Crash on JoyStick Config when js device did not contain regular joystick button

2017-09-16 Thread TOM Harrison via Review Board
--- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130245/ > ----------- > > (Updated 九月 16, 2017, 7:07 a.m.) > > > Review reque

Re: Review Request 130245: Fix Crash on JoyStick Config when js device did not contain regular joystick button

2017-09-16 Thread Albert Astals Cid
wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130245/ > --- > > (Updated set. 16, 2017, 7:07 a.m.) > > &

Re: Review Request 130245: Fix Crash on JoyStick Config when js device did not contain regular joystick button

2017-09-16 Thread TOM Harrison via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130245/ --- (Updated 九月 16, 2017, 7:07 a.m.) Review request for kde-workspace

Review Request 130239: Exclude kconf_update from catching by uac on Windows

2017-09-04 Thread Ralf Habacker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130239/ --- Review request for kdelibs. Bugs: 384334 http://bugs.kde.org

Re: Review Request 128854: Add a Tools button above the process list of System Monitor

2017-08-03 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128854/ --- (Updated Aug. 3, 2017, 1:25 p.m.) Review request for KDE Base Apps

Re: Review Request 128854: Add a Tools button above the process list of System Monitor

2017-08-03 Thread Kevin Funk
4/ > ------- > > (Updated Aug. 3, 2017, 11:08 a.m.) > > > Review request for KDE Base Apps, Martin Flöser, John Tapsell, Ken Vermette, > Thomas Lübking, and Thomas Pfeiffer. > > > Repository: libksysguard >

Re: Review Request 128854: Add a Tools button above the process list of System Monitor

2017-08-03 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128854/ --- (Updated Aug. 3, 2017, 11:08 a.m.) Review request for KDE Base Apps

Re: Review Request 128854: Add a Tools button above the process list of System Monitor

2017-08-03 Thread Gregor Mi
July 28, 2017, 12:20 p.m., Gregor Mi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128854/ > ------- > > (Updated July 28, 2017, 12:20 p.m.) > >

Re: Review Request 128854: Add a Tools button above the process list of System Monitor

2017-08-03 Thread Gregor Mi
To reply, visit: > https://git.reviewboard.kde.org/r/128854/ > ------- > > (Updated July 28, 2017, 12:20 p.m.) > > > Review request for KDE Base Apps, Martin Flöser, John Tapsell, Ken Vermette, > Thomas Lübking, and Thomas Pfeiffer. > > > Repository: libksysgua

Re: Review Request 128854: Add a Tools button above the process list of System Monitor

2017-07-31 Thread Kevin Funk
.reviewboard.kde.org/r/128854/ > --- > > (Updated July 28, 2017, 12:20 p.m.) > > > Review request for KDE Base Apps, Martin Flöser, John Tapsell, Ken Vermette, > Thomas Lübking, and Thomas Pfeiffer. > > > Repository: libksysguard >

Re: Review Request 128854: Add a Tools button above the process list of System Monitor

2017-07-28 Thread Gregor Mi
ed e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128854/ > ------- > > (Updated July 28, 2017, 12:20 p.m.) > > > Review request for KDE Base Apps, Martin Flöser, John Tapsell, Ken Vermette, > Th

Re: Review Request 128854: Add a Tools button above the process list of System Monitor

2017-07-28 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128854/ --- (Updated July 28, 2017, 12:20 p.m.) Review request for KDE Base Apps

Re: Review Request 130193: [cmake]: De-duplicate "else" to fix build with cmake-3.9

2017-07-20 Thread Heiko Becker
been marked as submitted. Review request for kdelibs and Frank Osterfeld. Repository: kdelibs Description --- Otherwise it errors out with: "CMake Error at kdeui/CMakeLists.txt:316 (else): A duplicate ELSE command was found inside an IF block." Also adjust indentation to

Re: Review Request 130193: [cmake]: De-duplicate "else" to fix build with cmake-3.9

2017-07-20 Thread Rolf Eike Beer
org/r/130193/ > --- > > (Updated Juli 20, 2017, 7:59 nachm.) > > > Review request for kdelibs and Frank Osterfeld. > > > Repository: kdelibs > > > Description > --- > > Otherwise it errors out with: > "

Review Request 130193: [cmake]: De-duplicate "else" to fix build with cmake-3.9

2017-07-20 Thread Heiko Becker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130193/ --- Review request for kdelibs and Frank Osterfeld. Repository: kdelibs

Re: Review Request 113587: Add support for x-gvfs style options in fstab

2017-04-02 Thread Stefan Bruens
On Montag, 13. März 2017 22:37:51 CEST Albert Astals Cid wrote: > > On March 13, 2017, 2:29 p.m., Kai Uwe Broulik wrote: > > > Sorry for the long wait… I was under the impression it landed a long > > > time ago. > > > > > > Itook your patch and ported it to Frameworks 5, please see the review at >

Re: Review Request 113587: Add support for x-gvfs style options in fstab

2017-03-16 Thread Brüns , Stefan
On Montag, 13. März 2017 22:37:51 CET Albert Astals Cid wrote: > > On March 13, 2017, 2:29 p.m., Kai Uwe Broulik wrote: > > > Sorry for the long wait… I was under the impression it landed a long > > > time ago. > > > > > > Itook your patch and ported it to Frameworks 5, please see the review at >

Re: Review Request 113587: Add support for x-gvfs style options in fstab

2017-03-13 Thread Ben Cooksley
On Tue, Mar 14, 2017 at 11:28 AM, Brüns, Stefan wrote: > On Montag, 13. März 2017 22:37:51 CET Albert Astals Cid wrote: >> > On March 13, 2017, 2:29 p.m., Kai Uwe Broulik wrote: >> > > Sorry for the long wait… I was under the impression it landed a long >> > > time ago. >> > > >> > > Itook your pa

Re: Review Request 113587: Add support for x-gvfs style options in fstab

2017-03-13 Thread Stefan Brüns
discarded. Review request for kdelibs and Solid. Repository: kdelibs Description --- These fstab options allows an administrator to specify names and icons intended for the user, shown in a GUI For details, see https://git.gnome.org/browse/gvfs/tree/monitor/udisks2/what-is-shown.txt

Re: Review Request 113587: Add support for x-gvfs style options in fstab

2017-03-13 Thread Albert Astals Cid
2, 2014, 1:39 a.m., Stefan Brüns wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/113587/ > --- > > (U

Re: Review Request 113587: Add support for x-gvfs style options in fstab

2017-03-13 Thread Kai Uwe Broulik
matically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/113587/ > --- > > (Updated Juni 22, 2014, 1:39 vorm.) > > > Review request for kdelibs and Solid. > > > Repository: kdelibs > &

Re: Review Request 122252: KRecursiveFilterProxyModel: fix emitting superfluous dataChanged signals

2017-02-26 Thread David Faure
- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122252/ > --- > > (Updated Jan. 25, 2015, 6:51 p.m.) > > > Review request for kdeli

Re: Review Request 114448: kjs: reogranize basic math functions & function checking

2017-02-25 Thread Albert Astals Cid
his is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114448/ > --- > > (Updated Dec. 14, 2013, 4:30 p.m.) > > > Review request for kdelibs. > > > Repository: kdelibs

Re: Review Request 113152: kcm_clock: Check for valid return values of QDateTime::toTime_t()

2017-02-25 Thread Martin Bříza
discarded. Review request for kde-workspace. Repository: kde-workspace Description --- Using the date selector in kcm_clock to set any date further than February 7, 2106 resulted in setting the time to ((time_t) (unsigned int) -1). This patch makes setting any date further than this to

Re: Review Request 113152: kcm_clock: Check for valid return values of QDateTime::toTime_t()

2017-02-25 Thread Albert Astals Cid
board.kde.org/r/113152/ > --- > > (Updated Oct. 7, 2013, 4:06 p.m.) > > > Review request for kde-workspace. > > > Repository: kde-workspace > > > Description > --- > > Using the date selector in kcm_clock to set any da

Re: Review Request 127866: Oxygen: Fix QCache usage

2017-02-25 Thread Michael Pyne
marked as submitted. Review request for kde-workspace and Hugo Pereira Da Costa. Repository: oxygen Description --- This should mostly complete the QCache fixes I kicked off in a previous RR, 127837. Hugo noted there were many other similar usages, and boy he wasn't kidding! ;) The

Re: Review Request 125081: Fix build on OS X

2017-02-25 Thread Samuel Gaist
discarded. Review request for KDE Base Apps and Martin Gräßlin. Repository: kde-baseapps Description --- Use kwindowsystem.h to check whether X11 is available and move netwm.h with them since that header is made available with the xcb plugin. added .reviewboardrc Diffs

Re: Review Request 125081: Fix build on OS X

2017-02-25 Thread Albert Astals Cid
rd.kde.org/r/125081/ > --- > > (Updated Sept. 7, 2015, 10:08 p.m.) > > > Review request for KDE Base Apps and Martin Gräßlin. > > > Repository: kde-baseapps > > > Description > --- > > Use k

Re: Review Request 122252: KRecursiveFilterProxyModel: fix emitting superfluous dataChanged signals

2017-02-25 Thread Albert Astals Cid
org/r/122252/ > --- > > (Updated Jan. 25, 2015, 6:51 p.m.) > > > Review request for kdelibs and Christian Mollekopf. > > > Repository: kdelibs > > > Description > --- > > by using an internal cache of the filte

Re: Review Request 127866: Oxygen: Fix QCache usage

2017-02-25 Thread Hugo Pereira Da Costa
-- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127866/#review96029 ----------- On May 22, 2016, 4:20 a.m., Michael Pyne wrote: > > ---

Re: Review Request 127866: Oxygen: Fix QCache usage

2017-02-25 Thread Albert Astals Cid
ail. To reply, visit: https://git.reviewboard.kde.org/r/127866/#review96029 ----------- On May 22, 2016, 4:20 a.m., Michael Pyne wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > htt

Re: Review Request 129917: Add a cache monitor to the System Load Viewer applet

2017-02-23 Thread Pascal VITOUX
marked as submitted. Review request for kde-workspace and Plasma. Changes --- Submitted with commit 9b2d766b2bb41a6725b585eaa8ca11fc9cf36b36 by David Edmundson on behalf of Pascal VITOUX to branch master. Repository: kdeplasma-addons Description --- Add a cache monitor to the

Re: Review Request 129917: Add a cache monitor to the System Load Viewer applet

2017-02-22 Thread Pascal VITOUX
d e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129917/ > --- > > (Updated fév. 7, 2017, 10:20 matin) > > > Review request for kde-workspace and Plasma. > > > Repository: kdeplasma-addons >

Re: Review Request 129917: Add a cache monitor to the System Load Viewer applet

2017-02-21 Thread David Edmundson
ed Feb. 7, 2017, 9:20 a.m.) > > > Review request for kde-workspace and Plasma. > > > Repository: kdeplasma-addons > > > Description > --- > > Add a cache monitor to the System Load Viewer applet using 'cache/dirty' and > 'cach

Re: Review Request 129917: Add a cache monitor to the System Load Viewer applet

2017-02-21 Thread Albert Astals Cid
org/r/129917/ > --- > > (Updated Feb. 7, 2017, 9:20 a.m.) > > > Review request for kde-workspace and Plasma. > > > Repository: kdeplasma-addons > > > Description > --- > > Add a cache monitor to the System Load Viewer applet using 'ca

Re: Review Request 129935: Fix build for GCC 7

2017-02-08 Thread Antonio Larrosa Jimenez
marked as submitted. Review request for kdelibs. Repository: kdelibs Description --- This fixes building with GCC 7 which fails with "ISO C++ forbids comparison between pointer and integer [-fpermissive]" Diffs - kdeui/windowmanagement

Re: Review Request 122653: Set permissions for links in remote:, necessary for correct visualization

2017-02-08 Thread Stefan Brüns
discarded. Review request for kdelibs, Plasma and Christoph Feck. Bugs: 339193 http://bugs.kde.org/show_bug.cgi?id=339193 Repository: kde-runtime Description --- KFileItem uses UDS_ACCESS to determine permissions. Readability is subsequently used to create the list of overlay icons

Re: Review Request 122653: Set permissions for links in remote:, necessary for correct visualization

2017-02-08 Thread Marco Martin
pdated March 17, 2015, 4:49 p.m.) > > > Review request for kdelibs, Plasma and Christoph Feck. > > > Bugs: 339193 > http://bugs.kde.org/show_bug.cgi?id=339193 > > > Repository: kde-runtime > > > Description > --- > > KFileItem uses UD

Re: Review Request 121584: Make the webapp manager run again.

2017-02-08 Thread Marco Martin
> (Updated Feb. 8, 2017, 1:25 p.m.) > > > Review request for Bodega, kdelibs, Aaron J. Seigo, and Marco Martin. > > > Repository: bodega-webapp-manager > > > Description > --- > > Make the webapp manager run again. > > > Diffs > - >

Re: Review Request 121584: Make the webapp manager run again.

2017-02-08 Thread Jeremy Whiting
discarded. Review request for Bodega, kdelibs, Aaron J. Seigo, and Marco Martin. Repository: bodega-webapp-manager Description --- Make the webapp manager run again. Diffs - app.js ceede62c192451f2ac2bba8848a97f9bcc4a2f4a package.json 715d01c3fa9e9f3a890ee9e047093fdfb528095f

Re: Review Request 120149: [OS X] improved menubar experience: protected Preferences menu and cleaner "system tray"

2017-02-08 Thread René J . V . Bertin
discarded. Review request for KDE Software on Mac OS X, kdelibs, KDEPIM, Qt KDE, Marco Martin, and Olivier Goffart. Repository: kdelibs Description --- This review is for 2 sets of changes; an initial one to the way "system tray" are rendered, and a newer set that pr

Re: Review Request 120149: [OS X] improved menubar experience: protected Preferences menu and cleaner "system tray"

2017-02-08 Thread Marco Martin
org/r/120149/ > --- > > (Updated Sept. 25, 2014, 2:03 p.m.) > > > Review request for KDE Software on Mac OS X, kdelibs, KDEPIM, Qt KDE, Marco > Martin, and Olivier Goffart. > > > Repository: kdelibs > > > Description > --- > > This review is for 2 set

Re: Review Request 108862: QML Plasma Components: improve positioning strategy for inline dialog

2017-02-08 Thread Sebastian Gottfried
discarded. Review request for KDE Runtime and Marco Martin. Repository: kde-runtime Description --- This changes the positioning of the inline dialog in two ways: 1) Offset the dialog vertically so the balloon tip won't poke into the visual parent. 2) Make sure the dialog won&#x

Re: Review Request 129935: Fix build for GCC 7

2017-02-08 Thread Christoph Feck
> (Updated Feb. 8, 2017, 10:04 a.m.) > > > Review request for kdelibs. > > > Repository: kdelibs > > > Description > --- > > This fixes building with GCC 7 which fails with > "ISO C++ forbids comparison between pointer and integer [-fpermissiv

Review Request 129935: Fix build for GCC 7

2017-02-08 Thread Antonio Larrosa Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129935/ --- Review request for kdelibs. Repository: kdelibs Description

Re: Review Request 129917: Add a cache monitor to the System Load Viewer applet

2017-02-07 Thread Pascal VITOUX
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129917/ --- (Updated fév. 7, 2017, 10:20 matin) Review request for kde-workspace and

  1   2   3   4   5   6   7   8   9   10   >