Reposting here in case someone has an idea:
Hi all,
I'm working on a fix for a bug we have in KGet, where some files are
downloaded incomplete. I found that at least one of the reasons why
this happens is because of the following use case. when KGet is set up
as the download manager for Rekonq:
Hello List,
On Tuesday 08 January 2013 23:12:01 Albert Astals Cid wrote:
El Dimarts, 8 de gener de 2013, a les 21:08:11, Martin Sandsmark va
escriure:
Dear Sirs and Madams,
Mangonel has just been moved to KDE Review.
Mangonel is a simple and lightweight application launcher in the
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107983/#review25012
---
after I apply the patch, I notice that in some random unknnow
On Jan. 8, 2013, 11:15 p.m., Xuetian Weng wrote:
after I apply the patch, I notice that in some random unknnow case
KWindowSystem will emit the signal, while KSelectionOwner is not. (And I
think KSelectionOwner is correct since I didn't do anything to kwin), and I
notice some strange
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107983/
---
(Updated Jan. 9, 2013, 12:52 a.m.)
Review request for kdelibs, kwin,
On 2013年01月09日 08:09, Martin Sandsmark wrote:
Any reason not to use bugs.kde.org?
Fixed.
Hi, I see you made the change :
-aboutData-setBugAddress(QByteArray(bugs.mango...@tarmack.eu));
+aboutData-setBugAddress(QByteArray(https://bugs.kde.org/;));
Hmm, that is not going to work.
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107983/#review25025
---
kdeui/windowmanagement/kwindowsystem_x11.cpp
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107983/
---
(Updated Jan. 9, 2013, 2 a.m.)
Review request for kdelibs, kwin, Plasma,
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108285/#review25038
---
Code itself looks okay, see issue below though.
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108230/#review25051
---
This review has been submitted with commit
On Jan. 9, 2013, 10:09 a.m., Ben Cooksley wrote:
systemsettings/icons/IconMode.cpp, line 183
http://git.reviewboard.kde.org/r/108285/diff/1/?file=106110#file106110line183
Not sure I like the idea of a hardcoded list of languages... is there a
better way of determining if a
On Wednesday 09 January 2013 08:56:25 Jekyll Wu wrote:
If you plan to
use bugs.kde.org as the tracker, then you don't need to call
setBugAddress() at all. The default value just works.
Fixed.
And don't forget to ask sysadmins to create a mangonel product on
bugs.kde.org :)
Done.
El Dimarts, 8 de gener de 2013, a les 17:17:33, David Narvaez va escriure:
Reposting here in case someone has an idea:
Allan answered you in kde-devel weeks ago.
Cheers,
Albert
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108285/#review25091
---
To be honest i don't think this is the correct fix, the
On Wednesday 09 January 2013 18:35:49 Martin Sandsmark wrote:
On Tuesday 08 January 2013 19:30:45 Allen Winter wrote:
No docbook manual
I guess I'll to contact the doc team for this?
Do you want apidox generated? if so you also need a Mainpage.dox
No need for that (yet, at least, we
El Dimecres, 9 de gener de 2013, a les 01:09:28, Martin Sandsmark va escriure:
Hi, thanks for the review!
On Tuesday 08 January 2013 23:12:01 Albert Astals Cid wrote:
Which is its intended destination extragear-something?
Yes, sorry, I forgot to mention, it is destined for extragear/base.
On Wednesday 09 January 2013 19:49:36 Albert Astals Cid wrote:
You should probably make it look like
i18nc(some context of what stuff is, (%1), application.type)
Just in case someone needs to do something different with the parenthesis.
Okay, fixed. Thanks :-)
--
Martin Sandsmark
KDE
On Jan. 9, 2013, 6:43 p.m., Albert Astals Cid wrote:
To be honest i don't think this is the correct fix, the correct fix is
specifying a minimum space between the items or a minimum size of the items
themselves, not forcing the wordwrapping off
itemsize (spacing would also increase
On Wednesday 09 January 2013 19:45:27 Martin Gräßlin wrote:
There is one mail already on the list, so it is already spread.
Okay, so the proverbial cat's out of the bag I guess, so I just added his
email to the license headers.
--
Martin Sandsmark
KDE
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108308/#review25103
---
Random addendums:
- state hidden is also provided by metacity,
On Jan. 9, 2013, 10:09 a.m., Ben Cooksley wrote:
systemsettings/icons/IconMode.cpp, line 183
http://git.reviewboard.kde.org/r/108285/diff/1/?file=106110#file106110line183
Not sure I like the idea of a hardcoded list of languages... is there a
better way of determining if a
On Jan. 9, 2013, 10:09 a.m., Ben Cooksley wrote:
systemsettings/icons/IconMode.cpp, line 183
http://git.reviewboard.kde.org/r/108285/diff/1/?file=106110#file106110line183
Not sure I like the idea of a hardcoded list of languages... is there a
better way of determining if a
On Jan. 9, 2013, 10:09 a.m., Ben Cooksley wrote:
systemsettings/icons/IconMode.cpp, line 183
http://git.reviewboard.kde.org/r/108285/diff/1/?file=106110#file106110line183
Not sure I like the idea of a hardcoded list of languages... is there a
better way of determining if a
написане Wed, 09 Jan 2013 19:35:49 +0200, Martin Sandsmark
martin.sandsm...@kde.org:
On Tuesday 08 January 2013 19:30:45 Allen Winter wrote:
No docbook manual
I guess I'll to contact the doc team for this?
If there is no Help button and no desktop file, there is not much sense
in making
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108308/
---
Review request for kdelibs, kwin and Aaron J. Seigo.
Description
---
On Jan. 9, 2013, 10:45 p.m., Thomas Lübking wrote:
Random addendums:
- state hidden is also provided by metacity, icewm, openbox and compiz
- mappingState() is part of the public API, thus not cut off (if you
actually want to know it)
- not unmapping windows has more issues than the
On Jan. 9, 2013, 10:45 p.m., Thomas Lübking wrote:
Random addendums:
- state hidden is also provided by metacity, icewm, openbox and compiz
- mappingState() is part of the public API, thus not cut off (if you
actually want to know it)
- not unmapping windows has more issues than the
On Wednesday 09 January 2013 09:07:13 PM Yuri Chornoivan wrote:
написане Wed, 09 Jan 2013 19:35:49 +0200, Martin Sandsmark
martin.sandsm...@kde.org:
On Tuesday 08 January 2013 19:30:45 Allen Winter wrote:
No docbook manual
I guess I'll to contact the doc team for this?
If there is
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108314/#review25109
---
There should be no problem with ths one since WMs are
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108308/#review25110
---
Copied over from https://git.reviewboard.kde.org/r/108308/
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108308/#review25123
---
the big question is whether the code has been like that for
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108308/
---
(Updated Jan. 10, 2013, 6:50 a.m.)
Review request for kdelibs, kwin,
32 matches
Mail list logo
