Re: KTimeTracker in kdereview
вт, 19 нояб. 2019 г. в 15:09, Adriaan de Groot : > > On Tuesday, 19 November 2019 05:20:23 CET Alexander Potashev wrote: > > KTimeTracker is a time tracker desktop application which is well > > suited for tracking labor time you spend on a specific > > project/feature/customer. > > Builds clean on FreeBSD; that's a +1. > > I ran it once, it works nicely .. I'd have a fistful of feature requests for > it before it can replace Charm Time Tracker in my workflow, though. Welcome to https://bugs.kde.org/enter_bug.cgi?product=ktimetracker for feature requests. Or you can tell me what features you need to see if they are already planned. -- Alexander Potashev
Re: KTimeTracker in kdereview
Moved to extragear-pim. @Luigi, please move the translations. вт, 3 дек. 2019 г. в 13:45, Alexander Potashev : > > вт, 19 нояб. 2019 г. в 07:20, Alexander Potashev : > > KTimeTracker [1] has been moved to kdereview. > > > > The project is currently in playground-pim, destination would be > > extragear-pim. > > KTimeTracker had been in kdereview for two weeks already. It is enough > to assume everything is OK and we can move it to final destination > (extragear-pim), according to > https://community.kde.org/Policies/Application_Lifecycle#Releasing > > If no one objects, I will request the move to extragear-pim tomorrow. > > -- > Alexander Potashev -- Alexander Potashev
Re: KTimeTracker in kdereview
вт, 19 нояб. 2019 г. в 07:20, Alexander Potashev : > KTimeTracker [1] has been moved to kdereview. > > The project is currently in playground-pim, destination would be > extragear-pim. KTimeTracker had been in kdereview for two weeks already. It is enough to assume everything is OK and we can move it to final destination (extragear-pim), according to https://community.kde.org/Policies/Application_Lifecycle#Releasing If no one objects, I will request the move to extragear-pim tomorrow. -- Alexander Potashev
Re: KTimeTracker in kdereview
вс, 1 дек. 2019 г. в 19:43, Albert Astals Cid : > > El diumenge, 1 de desembre de 2019, a les 13:09:30 CET, Alexander Potashev va > escriure: > > > clang-tidy says that desktops in Task::Task and sessionStartTiMe in > > > Task::init should be const & > > > > Fixed these [1], however I wasn't able to run clang-tidy myself to get > > the same hints. Tried clang-tidy features in KDevelop and JetBrains' > > CLion. > > clang-tidy has a million checks and almost none are enabled by default (i > think) > > What i do is enable the performance ones manually, i.e. for example this is > what we have in the poppler CI > > cmake > -DCMAKE_CXX_CLANG_TIDY="clang-tidy;-header-filter=.;-checks=-*,performance-*,bugprone-*,readability-inconsistent-declaration-parameter-name,readability-string-compare,modernize-deprecated-headers,-bugprone-narrowing-conversions,-bugprone-macro-parentheses,-bugprone-suspicious-string-compare,-bugprone-incorrect-roundings,-bugprone-undefined-memory-manipulation;-warnings-as-errors=*" > .. > > But this will probably give you lots of errors you don't want, you have to > figure out which are th eones you care about. Thanks! I managed to get that million of warnings by following this tutorial: http://mariobadr.com/using-clang-tidy-with-cmake-36.html Fixed some more, however some others would be nearly useless nitpicking. -- Alexander Potashev
Re: KTimeTracker in kdereview
El diumenge, 1 de desembre de 2019, a les 13:09:30 CET, Alexander Potashev va escriure: > вт, 26 нояб. 2019 г. в 00:31, Albert Astals Cid : > > > > El dimarts, 19 de novembre de 2019, a les 5:20:23 CET, Alexander Potashev > > va escriure: > > > Hi, > > > > > > KTimeTracker [1] has been moved to kdereview. > > > > > > KTimeTracker is a time tracker desktop application which is well > > > suited for tracking labor time you spend on a specific > > > project/feature/customer. > > > > > > Its latest release was made on 2015-07-01 as part of KDE PIM 4.14.10. > > > Since then I ported KTimeTracker to Qt5/KF5, did a lot of refactoring > > > and reworked some dialogs. The major changes since 4.14.10 are listed > > > in [2]. > > > > > > KDE CI is set up at [3]. > > > > > > The project is currently in playground-pim, destination would be > > > extragear-pim. > > > > clang-tidy says that desktops in Task::Task and sessionStartTiMe in > > Task::init should be const & > > Fixed these [1], however I wasn't able to run clang-tidy myself to get > the same hints. Tried clang-tidy features in KDevelop and JetBrains' > CLion. clang-tidy has a million checks and almost none are enabled by default (i think) What i do is enable the performance ones manually, i.e. for example this is what we have in the poppler CI cmake -DCMAKE_CXX_CLANG_TIDY="clang-tidy;-header-filter=.;-checks=-*,performance-*,bugprone-*,readability-inconsistent-declaration-parameter-name,readability-string-compare,modernize-deprecated-headers,-bugprone-narrowing-conversions,-bugprone-macro-parentheses,-bugprone-suspicious-string-compare,-bugprone-incorrect-roundings,-bugprone-undefined-memory-manipulation;-warnings-as-errors=*" .. But this will probably give you lots of errors you don't want, you have to figure out which are th eones you care about. Cheers, Albert > > Thanks Albert! > > > [1] > https://commits.kde.org/ktimetracker/7928253e26d6f6eb2dfe6256fe2cf15fcf9225e4 > >
Re: KTimeTracker in kdereview
вт, 26 нояб. 2019 г. в 00:31, Albert Astals Cid : > > El dimarts, 19 de novembre de 2019, a les 5:20:23 CET, Alexander Potashev va > escriure: > > Hi, > > > > KTimeTracker [1] has been moved to kdereview. > > > > KTimeTracker is a time tracker desktop application which is well > > suited for tracking labor time you spend on a specific > > project/feature/customer. > > > > Its latest release was made on 2015-07-01 as part of KDE PIM 4.14.10. > > Since then I ported KTimeTracker to Qt5/KF5, did a lot of refactoring > > and reworked some dialogs. The major changes since 4.14.10 are listed > > in [2]. > > > > KDE CI is set up at [3]. > > > > The project is currently in playground-pim, destination would be > > extragear-pim. > > clang-tidy says that desktops in Task::Task and sessionStartTiMe in > Task::init should be const & Fixed these [1], however I wasn't able to run clang-tidy myself to get the same hints. Tried clang-tidy features in KDevelop and JetBrains' CLion. Thanks Albert! [1] https://commits.kde.org/ktimetracker/7928253e26d6f6eb2dfe6256fe2cf15fcf9225e4 -- Alexander Potashev
Re: KTimeTracker in kdereview
El dimarts, 19 de novembre de 2019, a les 5:20:23 CET, Alexander Potashev va escriure: > Hi, > > KTimeTracker [1] has been moved to kdereview. > > KTimeTracker is a time tracker desktop application which is well > suited for tracking labor time you spend on a specific > project/feature/customer. > > Its latest release was made on 2015-07-01 as part of KDE PIM 4.14.10. > Since then I ported KTimeTracker to Qt5/KF5, did a lot of refactoring > and reworked some dialogs. The major changes since 4.14.10 are listed > in [2]. > > KDE CI is set up at [3]. > > The project is currently in playground-pim, destination would be > extragear-pim. clang-tidy says that desktops in Task::Task and sessionStartTiMe in Task::init should be const & Cheers, Albert > > > [1] https://cgit.kde.org/ktimetracker.git > [2] https://cgit.kde.org/ktimetracker.git/tree/ChangeLog.md > [3] https://build.kde.org/job/Extragear/job/ktimetracker/ > >
Re: KTimeTracker in kdereview
Licensing looks good :) Jonathan On Tue, 19 Nov 2019 at 04:20, Alexander Potashev wrote: > Hi, > > KTimeTracker [1] has been moved to kdereview. > > KTimeTracker is a time tracker desktop application which is well > suited for tracking labor time you spend on a specific > project/feature/customer. > > Its latest release was made on 2015-07-01 as part of KDE PIM 4.14.10. > Since then I ported KTimeTracker to Qt5/KF5, did a lot of refactoring > and reworked some dialogs. The major changes since 4.14.10 are listed > in [2]. > > KDE CI is set up at [3]. > > The project is currently in playground-pim, destination would be > extragear-pim. > > > [1] https://cgit.kde.org/ktimetracker.git > [2] https://cgit.kde.org/ktimetracker.git/tree/ChangeLog.md > [3] https://build.kde.org/job/Extragear/job/ktimetracker/ > > -- > Alexander Potashev >
Re: KTimeTracker in kdereview
On Tuesday, 19 November 2019 05:20:23 CET Alexander Potashev wrote: > KTimeTracker is a time tracker desktop application which is well > suited for tracking labor time you spend on a specific > project/feature/customer. Builds clean on FreeBSD; that's a +1. I ran it once, it works nicely .. I'd have a fistful of feature requests for it before it can replace Charm Time Tracker in my workflow, though. [ade] signature.asc Description: This is a digitally signed message part.
Re: KTimeTracker in kdereview
вт, 19 нояб. 2019 г. в 11:44, Friedrich W. H. Kossebau : > > Am Dienstag, 19. November 2019, 05:20:23 CET schrieb Alexander Potashev: > > Hi, > > > > KTimeTracker [1] has been moved to kdereview. > > Did some favourite-nitpicks review comments as direct fixes. Thanks! > You want to instruct the Messages.sh to just care for the src/ subdir, and > there also exclude the test/ subdir (just in case and to speed up execution). > Possibly first part can best be handled by moving Messages.sh into the src/ > subdir. Moved Messages.sh into src/, it's enough for now IMO. -- Alexander Potashev
Re: KTimeTracker in kdereview
Am Dienstag, 19. November 2019, 05:20:23 CET schrieb Alexander Potashev: > Hi, > > KTimeTracker [1] has been moved to kdereview. Did some favourite-nitpicks review comments as direct fixes. Otherwise looks nice code on a quick superficial view. Needs other eyes though for proper review. You want to instruct the Messages.sh to just care for the src/ subdir, and there also exclude the test/ subdir (just in case and to speed up execution). Possibly first part can best be handled by moving Messages.sh into the src/ subdir. Cheers Friedrich
