Re: Type=FSDevice desktop files

2020-04-27 Thread David Faure
On lundi 27 avril 2020 12:43:37 CEST Adriaan de Groot wrote:
> On 2020 prilula d. 26id 23:45:09 CEST David Faure wrote:
> > This was useful back then, for USB keys and CDROMs (kids, ask your parents
> > what that was), before Solid, before the plasma device notification
> > popup...
> I have a CDRom drive. It contains an OpenBSD 6.3 install CD, even -- that's
> for testing the very-very-slow-ongoing removal of HAL support code from
> Solid and Plasma, which is consumed only by FreeBSD. (Except I need to get
> a *second* drive, and a linux machine working with it, to cross check the
> user- experience)

I'm glad for you that you have a CDRom drive :-)
But to be clear, you don't have a Type=FSDevice desktop file pointing to it, 
right?

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5





Re: Type=FSDevice desktop files

2020-04-27 Thread Adriaan de Groot
On 2020 prilula d. 26id 23:45:09 CEST David Faure wrote:
> This was useful back then, for USB keys and CDROMs (kids, ask your parents
> what that was), before Solid, before the plasma device notification popup...

I have a CDRom drive. It contains an OpenBSD 6.3 install CD, even -- that's 
for testing the very-very-slow-ongoing removal of HAL support code from Solid 
and Plasma, which is consumed only by FreeBSD. (Except I need to get a 
*second* drive, and a linux machine working with it, to cross check the user-
experience)

[ade]


signature.asc
Description: This is a digitally signed message part.


Re: Type=FSDevice desktop files

2020-04-27 Thread Kai Uwe Broulik

Hi,

> Would it be OK if we dropped support for desktop files that represent 
devices?
> This was a KDE1/KDE2/KDE3? feature, you'd write/ship a desktop file 
with Type=FSDevice and Dev=/dev/sdc and this would give you Mount and 
Unmount in the context menu.


I believe macOS to this day automatically adds storage devices to the 
desktop so I could imagine a use case here.


However, with auto-discovery, device notifier, UDisks, etc, I think it's 
quite a niche, and I'd happily see this feature gone :)


Cheers
Kai Uwe

Am 26.04.20 um 23:45 schrieb David Faure:



This was useful back then, for USB keys and CDROMs (kids, ask your parents
what that was), before Solid, before the plasma device notification popup...

But has anyone been using this in the last 10 years? I kind of doubt it.

Since I'm refactoring KRun and KDesktopFileActions to be asynchronous and
independent from QtWidgets, I need to know what to do with this IMHO very dead
code. Of course these classes will keep providing the feature, but once I
write a KIO::OpenUrlJob as a replacement for KRun and we port the code to
that, we'll lose the feature from a user's point of view.
Not sure this is really a loss though ;)





Re: Type=FSDevice desktop files

2020-04-26 Thread Aleix Pol
On Sun, Apr 26, 2020 at 11:45 PM David Faure  wrote:
>
> Would it be OK if we dropped support for desktop files that represent devices?
> This was a KDE1/KDE2/KDE3? feature, you'd write/ship a desktop file with
> Type=FSDevice and Dev=/dev/sdc
> and this would give you Mount and Unmount in the context menu.
>
> This was useful back then, for USB keys and CDROMs (kids, ask your parents
> what that was), before Solid, before the plasma device notification popup...
>
> But has anyone been using this in the last 10 years? I kind of doubt it.
>
> Since I'm refactoring KRun and KDesktopFileActions to be asynchronous and
> independent from QtWidgets, I need to know what to do with this IMHO very dead
> code. Of course these classes will keep providing the feature, but once I
> write a KIO::OpenUrlJob as a replacement for KRun and we port the code to
> that, we'll lose the feature from a user's point of view.
> Not sure this is really a loss though ;)

I don't think anyone I've ever discussed OSs would miss it.

CCing plasma-devel since people there might know more about different use cases.

Aleix