Re: kio-stash is in KDE Review

2017-06-21 Thread Arnav Dhamija
Thanks. I have fixed this and the kio-stash ioslave passes all the test cases on CI here: https://build-sandbox.kde.org/view/Extragear/job/Extragear%20kio-stash%20kf5-qt5%20SUSEQt5.9/ The build log for the same can be found here: https://build-sandbox.kde.org/view/Extragear/job/Extragear%20kio-sta

Re: kio-stash is in KDE Review

2017-06-19 Thread Albert Astals Cid
El dilluns, 19 de juny de 2017, a les 10:06:35 CEST, Jonathan Riddell va escriure: > Better as kio-extras in KDE Applications no? I've no idea, the original email didn't explain what kio-stash is. Ok, i went and read the README.md to me it really sounds really specialized, but if the world want

Re: kio-stash is in KDE Review

2017-06-19 Thread Albert Astals Cid
El dilluns, 19 de juny de 2017, a les 14:30:22 CEST, Arnav Dhamija va escriure: > Thanks. I have fixed this and the kio-stash ioslave passes all the > test cases on CI here: > https://build-sandbox.kde.org/view/Extragear/job/Extragear%20kio-stash%20kf5 > -qt5%20SUSEQt5.9/ > > The build log for th

Re: kio-stash is in KDE Review

2017-06-19 Thread Jonathan Riddell
Better as kio-extras in KDE Applications no? Jonathan On 19 June 2017 at 10:00, Arnav Dhamija wrote: > Thanks. I have fixed this and the kio-stash ioslave passes all the > test cases on CI here: > https://build-sandbox.kde.org/view/Extragear/job/Extragear%20kio-stash%20kf5-qt5%20SUSEQt5.9/ > >

Re: kio-stash is in KDE Review

2017-06-18 Thread Albert Astals Cid
El dimecres, 14 de juny de 2017, a les 21:42:58 CEST, Arnav Dhamija va escriure: > Just to check I setup a brand new virtualbox with KDE Neon 5.8 LTS and > ran the following commands after cloning the repo and creating a build > directory: > > cmake -DCMAKE_INSTALL_PREFIX=/usr -DKDE_INSTALL_USE_Q

Re: kio-stash is in KDE Review

2017-06-17 Thread Arnav Dhamija
Just to check I setup a brand new virtualbox with KDE Neon 5.8 LTS and ran the following commands after cloning the repo and creating a build directory: cmake -DCMAKE_INSTALL_PREFIX=/usr -DKDE_INSTALL_USE_QT_SYS_PATHS=TRUE .. make sudo make install kdeinit5 ...and then I ran the tests using 'ctes

Re: kio-stash is in KDE Review

2017-06-15 Thread Ben Cooksley
On Thu, Jun 15, 2017 at 9:04 AM, Albert Astals Cid wrote: > El dimecres, 14 de juny de 2017, a les 21:42:58 CEST, Arnav Dhamija va > escriure: >> Just to check I setup a brand new virtualbox with KDE Neon 5.8 LTS and >> ran the following commands after cloning the repo and creating a build >> dire

Re: kio-stash is in KDE Review

2017-06-14 Thread Albert Astals Cid
El dimecres, 14 de juny de 2017, a les 21:42:58 CEST, Arnav Dhamija va escriure: > Just to check I setup a brand new virtualbox with KDE Neon 5.8 LTS and > ran the following commands after cloning the repo and creating a build > directory: > > cmake -DCMAKE_INSTALL_PREFIX=/usr -DKDE_INSTALL_USE_Q

Re: kio-stash is in KDE Review

2017-06-13 Thread Arnav Dhamija
> Do you mean i have to manually start a process for the tests to succeed? If installed correctly with kdeinit restarted and the Stash Daemon is running in kded5, it is not required. However, I cannot recall what steps are needed for this to happen as I think it requires a system restart or logout

Re: kio-stash is in KDE Review

2017-06-13 Thread Arnav Dhamija
Yes, I will file a sysadmin ticket for the same. Until I do so, could you send me the output of the test suite in a screenshot or as plain text? The ioslave works by storing a list of virtual files and folders in a process running in the KDED, communicating with it over D-Bus. Hence, some of the t

Re: kio-stash is in KDE Review

2017-06-13 Thread Arnav Dhamija
Hi everyone I have touched upon any concerns people have had with the ioslave in my previous email. If no one has any objections, I would like to ship this to KDE Extra Modules. More specifically, it will be suited for kde-extragear-utils, if that division is still relevant in KDE extragear. The s

Re: kio-stash is in KDE Review

2017-06-12 Thread Albert Astals Cid
El divendres, 9 de juny de 2017, a les 11:45:14 CEST, Arnav Dhamija va escriure: > > Do you mean i have to manually start a process for the tests to succeed? > > If installed correctly with kdeinit restarted and the Stash Daemon is > running in kded5, it is not required. However, I cannot recall

Re: kio-stash is in KDE Review

2017-06-08 Thread Albert Astals Cid
El dijous, 8 de juny de 2017, a les 16:25:02 CEST, Arnav Dhamija va escriure: > Yes, I will file a sysadmin ticket for the same. Until I do so, could > you send me the output of the test suite in a screenshot or as plain > text? > > The ioslave works by storing a list of virtual files and folders

Re: kio-stash is in KDE Review

2017-06-08 Thread Jonathan Riddell
In the git repo all the files are permission executable, they shouldn't be. There's no documentation. I'm unsure how hard a requirement this is these days. Use title case for name in src/iodaemon/stashnotifier.json When I use Dolphin to copy a file over I get a dialog daying "Could not copy.",

Re: kio-stash is in KDE Review

2017-05-31 Thread Arnav Dhamija
First off, thanks for all the reviews! > We simulate a "virtual://" protocol[*] which can contain virtual > folders containing references to real files and folders. > I did not know that such a feature exists! It seems like this feature is Krusader specific without tapping into KIO as such? It

Re: kio-stash is in KDE Review

2017-05-27 Thread Albert Astals Cid
El dissabte, 27 de maig de 2017, a les 0:29:51 CEST, Boudhayan Gupta va escriure: > Hi, > > On 27 May 2017 at 00:20, Albert Astals Cid wrote: > > El divendres, 26 de maig de 2017, a les 23:48:18 CEST, Boudhayan Gupta va > > > > escriure: > >> Hi, > >> > >> On 26 May 2017 at 20:31, Elvis Angela

Re: kio-stash is in KDE Review

2017-05-26 Thread Boudhayan Gupta
Hi, On 27 May 2017 at 00:20, Albert Astals Cid wrote: > El divendres, 26 de maig de 2017, a les 23:48:18 CEST, Boudhayan Gupta va > escriure: >> Hi, >> >> On 26 May 2017 at 20:31, Elvis Angelaccio wrote: >> > * The dbus adaptor could probably use build-time generation via cmake, >> > rather than

Re: kio-stash is in KDE Review

2017-05-26 Thread Elvis Angelaccio
On venerdì 26 maggio 2017 19:25:11 CEST, Arnav Dhamija wrote: Hi! I had made the kio-stash ioslave last year as part of my GSoC 2016 Project. Now that most of the changes which I wished to make in Dolphin relevant to the ioslave are part of master, I wish to ship the ioslave soon. The project i

Re: kio-stash is in KDE Review

2017-05-26 Thread Albert Astals Cid
El divendres, 26 de maig de 2017, a les 23:48:18 CEST, Boudhayan Gupta va escriure: > Hi, > > On 26 May 2017 at 20:31, Elvis Angelaccio wrote: > > * The dbus adaptor could probably use build-time generation via cmake, > > rather than being committed to the git repo. If you need an example look >

Re: kio-stash is in KDE Review

2017-05-26 Thread Boudhayan Gupta
Hi, On 26 May 2017 at 20:31, Elvis Angelaccio wrote: > * The dbus adaptor could probably use build-time generation via cmake, > rather than being committed to the git repo. If you need an example look at > the CMakeLists.txt in kio/src/kioexec (qt5_add_dbus_adaptor and friends). IIRC we did that