Re: [PATCH 1/3] Drop KDE_NO_PHONON, Phonon works on Qt5 now.

2012-11-21 Thread David Faure
Hi Jon, What's the status on phonon-for-Qt5? If all changes got merged in, maybe this patch can be applied to kdelibs-frameworks? Thanks! On Sunday 07 October 2012 01:27:13 Jon Severinsson wrote: --- CMakeLists.txt| 10 +- interfaces/CMakeLists.txt

Re: Build failure with Qt 5

2012-11-21 Thread David Faure
On Friday 26 October 2012 16:52:29 Stephen Kelly wrote: Hi, A recent patch of mine makes the frameworks branch fail to build with Qt 5: https://codereview.qt-project.org/#change,37624 I made it not possible to emit the aboutToQuit signal, which apparently KApplication tries to do. I

Re: KWallet plugin logic implementation inside frameworks

2012-11-21 Thread David Faure
Hello Valentin, Sorry for the delayed reply, too many conferences this month ;) On Sunday 04 November 2012 16:03:12 Valentin Rusu wrote: Hello, Now that I'm using a plug-in version of the KWallet API on my system, I think it would be the time to put it at the right place inside the

Re: [PATCH 1/3] Drop KDE_NO_PHONON, Phonon works on Qt5 now.

2012-11-21 Thread Stephen Kelly
David Faure wrote: Hi Jon, What's the status on phonon-for-Qt5? If all changes got merged in, maybe this patch can be applied to kdelibs-frameworks? I think KDE_NO_PHONON still has value anyway. It makes it easier to do things in the frameworks branch because you don't have to build all

Re: KWallet plugin logic implementation inside frameworks

2012-11-21 Thread Kevin Ottens
On Wednesday 21 November 2012 13:28:28 David Faure wrote: Beep, incompatibility here. The type functional means it's only a library. Plugins are runtime dependencies, so this is an integration framework (confirmed by the fact that it aims at integrating with the OS wallet service). But anyway,

Re: KWallet plugin logic implementation inside frameworks

2012-11-21 Thread Valentin Rusu
On 11/21/2012 01:28 PM, David Faure wrote: Second issue (and proposal): where should go the kwalletdefaultplugin? This plugin actually contains the old KWallet API implementation, the one which calls the kwalletd. I think the best place for kwalletdefaultplugin should be kde-runtime/kwalletd.

Re: Sonnet status?

2012-11-21 Thread Martin Sandsmark
On Fri, Nov 09, 2012 at 01:15:49AM +0100, David Faure wrote: From a frameworks point of view, sonnet has had its core moved into staging (as you can see in a frameworks checkout). It needs simple porting from i18n to QCoreApplication::translate(, ...) to have no more kdecore dependency, and

Re: cmake 2.8.10.1 will be required in the next days for the frameworks branch

2012-11-21 Thread Alexander Neundorf
On Sunday 18 November 2012, Alexander Neundorf wrote: Hi, in the next days I'll update the required cmake version for e-c-m and the kdelibs framework branch to 2.8.10.1 (http://www.cmake.org/cmake/resources/software.html). 2.8.10.1 is required now, I just pushed it. Alex

Re: Sonnet status?

2012-11-21 Thread Martin Sandsmark
On Wed, Nov 21, 2012 at 09:00:27PM +0100, Martin Sandsmark wrote: https://git.reviewboard.kde.org/r/107412/ Bah, I'm stupid, I didn't see the usage of KLocale to get localized country and language names. Which is going to be much harder to replace, I think it might need improvements in QLocale

Re: Review Request: Don't append 0- when dragging and dropping from trash

2012-11-21 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105078/#review22311 --- Ship it! Starting to look good :-) Just one minor code issue,

ABI break -- kdepimlims 4.9.3

2012-11-21 Thread José Manuel Santamaría Lema
Hello, while packaging kdepimlibs 4.9.3 I found what I think it's an ABI break in libkabc; looks like the ABI break was introduced in this commit: https://projects.kde.org/projects/kde/kdepimlibs/repository/revisions/da16f7d5 The attached patch applies to 4.9.3 and solves the problem. If the

Moving Trojitá to extragear

2012-11-21 Thread Jan Kundrát
Hi, thanks for your encouragement. Trojitá, a fast IMAP e-mail client (homepage [1], more in-depth look [2], the KDE project page [3]) has spent the last week or so under playground and was just moved to kdereview (thanks to sysadmins for their excellent turnaround time). I'd appreciate people

Re: ABI break -- kdepimlims 4.9.3

2012-11-21 Thread Allen Winter
On Wednesday 21 November 2012 12:32:45 PM José Manuel Santamaría Lema wrote: Hello, while packaging kdepimlibs 4.9.3 I found what I think it's an ABI break in libkabc; looks like the ABI break was introduced in this commit:

Review Request: port sonnet away from i18nc

2012-11-21 Thread Martin Tobias Holmedahl Sandsmark
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107412/ --- Review request for kdelibs and David Faure. Description --- port

Re: Review Request: port sonnet away from i18nc

2012-11-21 Thread Martin Tobias Holmedahl Sandsmark
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107412/ --- (Updated Nov. 21, 2012, 7:47 p.m.) Review request for kdelibs and David

Re: Moving Trojitá to extragear

2012-11-21 Thread Albert Astals Cid
El Dimecres, 21 de novembre de 2012, a les 19:43:13, Jan Kundrát va escriure: Hi, thanks for your encouragement. Trojitá, a fast IMAP e-mail client (homepage [1], more in-depth look [2], the KDE project page [3]) has spent the last week or so under playground and was just moved to kdereview

Re: Moving Trojitá to extragear

2012-11-21 Thread Thomas Lübking
On Mittwoch, 21. November 2012 20:53:14 CEST, Albert Astals Cid wrote: I.e. if you don't use i18n() or tr() + kdecore (and actually this one has a missing feature because someone in Qt decided to make a method not virtual) you can't get our .po/.mo system work-flow to work. Not having

Re: Review Request: port sonnet away from i18nc

2012-11-21 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107412/#review22346 --- staging/sonnet/src/core/loader.cpp

Re: Moving Trojitá to extragear

2012-11-21 Thread Yuri Chornoivan
написане Wed, 21 Nov 2012 20:43:13 +0200, Jan Kundrát j...@flaska.net: 1) User's docs. Is it a hard requirement to have a documentation basically describing how the menus look like? No. But it's a good practice [0]. Nobody needs to know how the menu looks like (if you do not mind about

Re: Moving Trojitá to extragear

2012-11-21 Thread Albert Astals Cid
El Dimecres, 21 de novembre de 2012, a les 21:52:43, Thomas Lübking va escriure: On Mittwoch, 21. November 2012 20:53:14 CEST, Albert Astals Cid wrote: I.e. if you don't use i18n() or tr() + kdecore (and actually this one has a missing feature because someone in Qt decided to make a method

Review Request: Use static KNS3::DownloadDialog in PlasmoidPackage

2012-11-21 Thread Jan Grulich
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107413/ --- Review request for kdelibs. Description --- Switch from QWeakPointer

Re: Review Request: Use static KNS3::DownloadDialog in PlasmoidPackage

2012-11-21 Thread Jan Grulich
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107413/ --- (Updated Nov. 22, 2012, 12:25 a.m.) Review request for kdelibs.

Re: Nepomuk Tags kioslave - Please Review

2012-11-21 Thread David Faure
On Wednesday 07 November 2012 02:27:17 Albert Astals Cid wrote: Ahh, you mean copying from file: to tags: Moving from file: to tags:, rather. I see... I'd like to hear David's opinion on how that is going to be fixed at the kio/kioslave level. Not at that level. Apps should be able to call

[PATCH] Fix buttons accessibility in KMenuEdit (Bug296682)

2012-11-21 Thread Julien
Hi, This is a patch for the bug https://bugs.kde.org/show_bug.cgi?id=296682 It prevents to make buttons as inactive after having deleted or cutted an item. Thus, this bug does not only concern the delete button after having deleted an item, but also the following buttons : cut and copy, after

Re: KStandardAction source code

2012-11-21 Thread Kevin Krammer
On Friday, 2012-11-09, Jan Kalcic wrote: On 11/08/2012 07:04 AM, Kevin Krammer wrote: Hi, On Wednesday, 2012-11-07, Jan Kalcic wrote: Hi, I have a Qt app which I am little-by-little moving to KDE, with this I mean I am switching from Qt classes to KDE ones where possible.

Re: Nepomuk Tags kioslave - Please Review

2012-11-21 Thread Albert Astals Cid
El Dimecres, 21 de novembre de 2012, a les 16:15:01, David Faure va escriure: On Wednesday 07 November 2012 02:27:17 Albert Astals Cid wrote: Ahh, you mean copying from file: to tags: Moving from file: to tags:, rather. Right I see... I'd like to hear David's opinion on how that is going

Re: [PATCH] Fix buttons accessibility in KMenuEdit (Bug296682)

2012-11-21 Thread Albert Astals Cid
El Dimecres, 21 de novembre de 2012, a les 19:05:18, Julien va escriure: Hi, This is a patch for the bug https://bugs.kde.org/show_bug.cgi?id=296682 It prevents to make buttons as inactive after having deleted or cutted an item. Thus, this bug does not only concern the delete button

Re: [PATCH] Fix buttons accessibility in KMenuEdit (Bug296682)

2012-11-21 Thread Jekyll Wu
于 2012年11月22日 02:05, Julien 写道: Hi, This is a patch for the bug https://bugs.kde.org/show_bug.cgi?id=296682 It prevents to make buttons as inactive after having deleted or cutted an item. Thus, this bug does not only concern the delete button after having deleted an item, but also the

Re: [PATCH] Fix buttons accessibility in KMenuEdit (Bug296682)

2012-11-21 Thread Christoph Feck
On Wednesday 21 November 2012 19:05:18 Julien wrote: Hi, This is a patch for the bug https://bugs.kde.org/show_bug.cgi?id=296682 It prevents to make buttons as inactive after having deleted or cutted an item. Thus, this bug does not only concern the delete button after having deleted

Re: [Kde-hardware-devel] Review Request: Handle unsupported actions quietly

2012-11-21 Thread Oliver Henshaw
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107257/ --- (Updated Nov. 21, 2012, 7:20 p.m.) Review request for Solid. Changes

Re: [Kde-hardware-devel] Review Request: Silence Profile foo could not activate bar which is a non-existent action message

2012-11-21 Thread Oliver Henshaw
On Nov. 18, 2012, 1:23 p.m., Kai Uwe Broulik wrote: Great! Now that I have tested the Keyboard brightness support patch that is on Review Board atm, I get two error messages simultaneously on startup: One for DPMS, the other for Keyboard brightness. This really needs to be

[Kde-hardware-devel] Review Request: Handle unsupported actions quietly

2012-11-21 Thread xavier Besnard
Hello, I bought a ACER netbook ref 0531H a couple of years ago. I installed the successive versions of Kubuntu without problems, especially with the integrated webcam (Suyin, Crystal Eye). Skype, Cheese and Camorama worked fine with it. After upgrading to Kubuntu Precise (not sure), the

Re: [Kde-hardware-devel] Review Request: Silence Profile foo could not activate bar which is a non-existent action message

2012-11-21 Thread Kai Uwe Broulik
On Nov. 18, 2012, 1:23 p.m., Kai Uwe Broulik wrote: Great! Now that I have tested the Keyboard brightness support patch that is on Review Board atm, I get two error messages simultaneously on startup: One for DPMS, the other for Keyboard brightness. This really needs to be