Re: kcolorscheme needs ksharedconfig.h

2013-02-14 Thread David Faure
On Monday 11 February 2013 14:26:46 Treeve Jelbert wrote: In file included from /var/git/kf5/staging/kguiaddons/src/colors/kcolorscheme.cpp:19:0: /var/git/kf5/staging/kguiaddons/src/colors/kcolorscheme.h:24:27: fatal error: ksharedconfig.h: No such file or directory compilation terminated.

kf5 general build problem (was Re: kcolorscheme needs ksharedconfig.h)

2013-02-14 Thread Treeve Jelbert
On Thu, 14 Feb 2013 11:41:48 +0100, David Faure wrote: On Monday 11 February 2013 14:26:46 Treeve Jelbert wrote: In file included from /var/git/kf5/staging/kguiaddons/src/colors/kcolorscheme.cpp:19:0: /var/git/kf5/staging/kguiaddons/src/colors/kcolorscheme.h:24:27: fatal error:

Re: kf5 general build problem (was Re: kcolorscheme needs ksharedconfig.h)

2013-02-14 Thread David Faure
On Thursday 14 February 2013 12:57:49 Treeve Jelbert wrote: /var/git/kf5/libkdeqt5staging/src/qurlpathinfo.cpp:42:0: /var/git/kf5/libkdeqt5staging/src/qurlpathinfo.h:45:34: fatal error: kdeqt5staging_export.h: No such file or directory Well, let's start with debugging that one, then. cmake

Re: kcolorscheme needs ksharedconfig.h

2013-02-14 Thread Treeve Jelbert
On Thu, 14 Feb 2013 13:50:57 +0100, David Faure wrote: On Thursday 14 February 2013 12:57:49 Treeve Jelbert wrote: /var/git/kf5/libkdeqt5staging/src/qurlpathinfo.cpp:42:0: /var/git/kf5/libkdeqt5staging/src/qurlpathinfo.h:45:34: fatal error: kdeqt5staging_export.h: No such file or directory

Re: kcolorscheme needs ksharedconfig.h

2013-02-14 Thread David Faure
On Thursday 14 February 2013 15:58:17 Treeve Jelbert wrote: +set(CMAKE_INCLUDE_CURRENT_DIR ON) This shouldn't be necessary, it is normally brought in by extra-cmake-modules/kde-modules/KDECMakeSettings.cmake which is itself included by FindKF5.cmake (also part of ECM), which (in

multiple definition of `KViewStateMaintainerBase::~KViewStateMaintainerBase() while linking libkdeui.so.5.11.0

2013-02-14 Thread Treeve Jelbert
I made some small changes to the main CMakeLists.txt and things advance, but I get a link failure on libkdeui.so.5.11.0. The changes: $ git diff diff --git a/CMakeLists.txt b/CMakeLists.txt index 0011ac3..f063007 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -1,5 +1,5 @@ -

Re: Review Request 103682: Fix capacity text in places panel (and possibly unwanted spin-up behavior)

2013-02-14 Thread Lukáš Tinkl
On April 30, 2012, 4:09 p.m., Lukáš Tinkl wrote: Has this been submitted? Christoph Feck wrote: No, I did not get any feedback from maintainers. Not sure if it still makes sense, because Dolphin 4.9 gets a new places panel, not based on KFilePlacesView. The patch probably also

Re: Review Request 108929: khtml/kjs: Implement typed-arrays

2013-02-14 Thread Milian Wolff
On Feb. 13, 2013, 9:13 a.m., Andrea Iacovitti wrote: khtml/ecma/kjs_arraybufferview.h, line 29 http://git.reviewboard.kde.org/r/108929/diff/2/?file=113855#file113855line29 Is this include really necessary or just an accident? (Noticed because a compilation error) Bernd

Review Request 108965: fix kde_infopage css for webkit

2013-02-14 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108965/ --- Review request for kdelibs. Description --- Now a bunch of

Re: Guidance required

2013-02-14 Thread Anne-Marie Mahfouf
Hi Rushi, Here is a link you will find helpful http://community.kde.org/GSoC It would be good for you to get familiar in depth with KDE workspaces and applications and find out what area you like. You can also start fixing a few easy bugs to get a feeling on what it is like to work with our

Re: Guidance required

2013-02-14 Thread Marius Cotofana
On Feb 14, 2013, at 2:05 PM, Anne-Marie Mahfouf annemarie.mahf...@free.fr wrote: Hi Rushi, Here is a link you will find helpful http://community.kde.org/GSoC Are the ideas the same as those last year ? Thank you, Marius Cotofana. Visit

Re: Guidance required

2013-02-14 Thread Myriam Schweingruber
On Thu, Feb 14, 2013 at 1:11 PM, Marius Cotofana marius.c...@gmail.com wrote: On Feb 14, 2013, at 2:05 PM, Anne-Marie Mahfouf annemarie.mahf...@free.fr wrote: Hi Rushi, Here is a link you will find helpful http://community.kde.org/GSoC Are the ideas the same as those last year ?

Re: Guidance required

2013-02-14 Thread Marius Cotofana
Thank you for your help. On Feb 14, 2013, at 2:19 PM, Myriam Schweingruber myr...@kde.org wrote: On Thu, Feb 14, 2013 at 1:11 PM, Marius Cotofana marius.c...@gmail.com wrote: On Feb 14, 2013, at 2:05 PM, Anne-Marie Mahfouf annemarie.mahf...@free.fr wrote: Hi Rushi, Here is a link

Re: [Kde-hardware-devel] Review Request 108894: [Draft] Add Battery OSD that allows the user to quickly peak into the battery percentage any time

2013-02-14 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108894/#review27444 --- I'm not happy with it, UI-wise, for the following reasons: -

Re: [Kde-hardware-devel] Review Request 108894: [Draft] Add Battery OSD that allows the user to quickly peak into the battery percentage any time

2013-02-14 Thread Kai Uwe Broulik
On Feb. 14, 2013, 2:03 p.m., Sebastian Kügler wrote: I'm not happy with it, UI-wise, for the following reasons: - the OSD is an indicator of the user changing a setting, not a status display - the feature is entirely hidden, meaning that nobody will know it, notice it, and use it

Re: [Kde-hardware-devel] Review Request 108894: [Draft] Add Battery OSD that allows the user to quickly peak into the battery percentage any time

2013-02-14 Thread Sebastian Kügler
On Feb. 14, 2013, 2:03 p.m., Sebastian Kügler wrote: I'm not happy with it, UI-wise, for the following reasons: - the OSD is an indicator of the user changing a setting, not a status display - the feature is entirely hidden, meaning that nobody will know it, notice it, and use it

Re: [Kde-hardware-devel] Review Request 103682: Fix capacity text in places panel (and possibly unwanted spin-up behavior)

2013-02-14 Thread Lukáš Tinkl
On April 30, 2012, 4:09 p.m., Lukáš Tinkl wrote: Has this been submitted? Christoph Feck wrote: No, I did not get any feedback from maintainers. Not sure if it still makes sense, because Dolphin 4.9 gets a new places panel, not based on KFilePlacesView. The patch probably also

Re: [Kde-hardware-devel] Review Request 108407: systemd-login1 support for PowerDevil

2013-02-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108407/#review27451 --- This review has been submitted with commit

Re: [Kde-hardware-devel] Releasing KScreen 0.1 RC1

2013-02-14 Thread Daniel Vrátil
On Thursday 14 of February 2013 15:52:16 Alex Fiestas wrote: On Sunday 10 February 2013 13:19:36 Daniel Vrátil wrote: If you'd prefer to delay this for 0.2, I'll just merge Aaron's changes in KCM to master and we can release. Btw, should we branch off before RC? Or right before final? I

Re: [Kde-hardware-devel] Releasing KScreen 0.1 RC1

2013-02-14 Thread Alex Fiestas
On Thursday 14 February 2013 16:20:54 Daniel Vrátil wrote: On Thursday 14 of February 2013 15:52:16 Alex Fiestas wrote: On Sunday 10 February 2013 13:19:36 Daniel Vrátil wrote: If you'd prefer to delay this for 0.2, I'll just merge Aaron's changes in KCM to master and we can release.

Re: [Kde-hardware-devel] Review Request 108894: [Draft] Add Battery OSD that allows the user to quickly peak into the battery percentage any time

2013-02-14 Thread Kai Uwe Broulik
On Feb. 14, 2013, 2:03 p.m., Sebastian Kügler wrote: I'm not happy with it, UI-wise, for the following reasons: - the OSD is an indicator of the user changing a setting, not a status display - the feature is entirely hidden, meaning that nobody will know it, notice it, and use it