D5856: Use KDirWatch removeDir/addDir instead of stopDirScan/restartDirScan

aacid added a comment. It's kind of harmless i guess, but when doing a rename via F2 in dolphin we do stopDirScan on the url twice, one in CopyJobPrivate::startRenameJob and another in CopyJobPrivate::createNextDir that means you get the following warning org.kde.kcoreaddons: doesn't

Re: Review Request 130128: Remove HelperProxy::authorizeAction

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130128/ --- (Updated May 14, 2017, 10:43 p.m.) Status -- This change has been

Re: Review Request 130128: Remove HelperProxy::authorizeAction

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130128/#review103213 --- Ship it! Ship It! - Aleix Pol Gonzalez On mai. 14,

Review Request 130128: Remove HelperProxy::authorizeAction

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130128/ --- Review request for KDE Frameworks, Aleix Pol Gonzalez and David Edmundson.

D5856: Use KDirWatch removeDir/addDir instead of stopDirScan/restartDirScan

dfaure added a comment. Yes, if this is confirmed to work we can deprecate stopDirScan/restartDirScan. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D5856 To: dfaure, aacid Cc: #frameworks

D5856: Use KDirWatch removeDir/addDir instead of stopDirScan/restartDirScan

aacid added a comment. Do we want to mark the "old" methods as deprecated? Update the docu? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D5856 To: dfaure, aacid Cc: #frameworks

Re: Requiem for Pure C++ plasmoid, and QML plugin... again :S

You may wish to note that plasma-devel is a more on-point mailing list for plasma widget questions. Also, you can model xml using qml exclusively [0]. Should you opt not to, what you need to do is write one plugin, not two. If you want to go the custom plugin route have a look at [1] for example.

Qml/Plasma icon coloring issue

Hi all, We are currently porting parts of the Kdenlive UI to Qml, and I have one issue with the Breeze icons when used in a Qml scene embedded in a QQuickWidget. We enforce a color theme in our app using: qApp->setPalette(palette()); QGuiApplication::setPalette(plt); When used in QWidgets,

Requiem for Pure C++ plasmoid, and QML plugin... again :S

I want to make a plasmoid that essentially read an xml of bookmark, displaythem in form of button and execute them once you clikc a button In Pure c++ it would take me 1 or 2 class maybe Now with QML I have to 1)Make 1 QMLPlugin in c++ 2)Make 1 qml code 3)Make a second QMLPlugin in C++

Re: KDirWatch issue

On dimanche 14 mai 2017 19:46:16 CEST Albert Astals Cid wrote: > Should we simply mark stopDirScan as deprecated and make it call > removeDir? Ah, yes, that's an option. Overall it will make things faster compared to unwanted notifications indeed. https://phabricator.kde.org/D5856 seems to

D5856: Use KDirWatch removeDir/addDir instead of stopDirScan/restartDirScan

dfaure created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This fixes notifications happening against our will given that inotify is async. TEST PLAN copying/deleting files in dolphin still

Re: KDirWatch issue

El dissabte, 13 de maig de 2017, a les 14:00:15 CEST, David Faure va escriure: > On lundi 8 mai 2017 17:51:06 CEST Albert Astals Cid wrote: > > El dilluns, 8 de maig de 2017, a les 17:32:35 CEST, David Faure va escriure: > > > On lundi 8 mai 2017 16:14:47 CEST Albert Astals Cid wrote: > > > > > I

D5851: Fix the PID updated in PlasmaWindowedModel

graesslin added a comment. In https://phabricator.kde.org/D5851#109478, @davidedmundson wrote: > It makes absolutely no sense to have a pidChanged signal and then say clients shouldn't be using it. > > Either window has no reason to have a pidChanged signal or we should connect to

D4552: [PreviewJob] Remove maximum size for local files by default

dfaure added a comment. In that case you might want to look at the fixes I just committed for https://bugs.kde.org/show_bug.cgi?id=208625 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D4552 To: broulik, emmanuelp, hein, dfaure Cc: abika, #frameworks

D5851: Fix the PID updated in PlasmaWindowedModel

davidedmundson added a comment. It makes absolutely no sense to have a pidChanged signal and then say clients shouldn't be using it. Either window has no reason to have a pidChanged signal or we should connect to it. It has to be one or the other. REPOSITORY R127 KWayland REVISION

D5851: Fix the PID updated in PlasmaWindowedModel

graesslin added inline comments. INLINE COMMENTS > plasmawindowmodel.cpp:84 > > +QObject::connect(window, ::pidChanged, q, > +[window, this] { this->dataChanged(window, PlasmaWindowModel::Pid); } In the original report I critized that we connect to a pid changed signal. That

D4552: [PreviewJob] Remove maximum size for local files by default

abika added a comment. File preview is also used in Krusader. Please add us to subscribers for behaviour changes. Thanks. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D4552 To: broulik, emmanuelp, hein, dfaure Cc: abika, #frameworks

D5851: Fix the PID updated in PlasmaWindowedModel

davidedmundson created this revision. Restricted Application added projects: Plasma on Wayland, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY Fixes https://phabricator.kde.org/D5747 TEST PLAN Tests now pass REPOSITORY R127 KWayland

D5802: ViewPrivate, KateSearchBar, KateVi::MatchHighlighter: use selection foreground for search highlights

intelfx added a comment. In https://phabricator.kde.org/D5802#109416, @mwolff wrote: > For solarized you showed the screenshots in your original mail. I'm more concerned about backwards compatibility with other schemes. I.e. yes - we do care about the status quo. Can you give an example

D5802: ViewPrivate, KateSearchBar, KateVi::MatchHighlighter: use selection foreground for search highlights

mwolff added a comment. For solarized you showed the screenshots in your original mail. I'm more concerned about backwards compatibility with other schemes. I.e. yes - we do care about the status quo. Can you give an example for a color scheme where this would break stuff? Then I can also

D5802: ViewPrivate, KateSearchBar, KateVi::MatchHighlighter: use selection foreground for search highlights

intelfx added a comment. In https://phabricator.kde.org/D5802#109403, @mwolff wrote: > Hey there, > > sorry for the long delay. In general this sounds like a good idea. But what do you mean by "However, just making that change will make Kate/KDevelop incompatible with all existing

D5802: ViewPrivate, KateSearchBar, KateVi::MatchHighlighter: use selection foreground for search highlights

mwolff added a comment. Hey there, sorry for the long delay. In general this sounds like a good idea. But what do you mean by "However, just making that change will make Kate/KDevelop incompatible with all existing color schemes"? Can you show some before/after screenshots for an

D5747: add pid to plasma window management protocol

hein added a comment. FWIW I did run make test on an earlier revision of the patch during the sprint while doing work on top of it; it must have regressed after. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D5747 To: sebas, #plasma, hein, graesslin Cc: apol,

Re: Next Gen CI Will Be Moving to Production Shortly: Upcoming Changes

On Sun, May 14, 2017 at 12:53 PM, Lays Rodrigues wrote: > Hi Ben, Hi Lays, > We of Atelier, in Extragear, would like to be covered on this next > generation of CI. Slight issue here for Atelier - it's in Playground according to our records. Could we get it through

Re: Next Gen CI Will Be Moving to Production Shortly: Upcoming Changes

On Wed, May 10, 2017 at 2:09 AM, Andrea Scarpino wrote: > On Sat, May 6, 2017 at 11:37 AM, Ben Cooksley wrote: >> Which brings me to the third point of attention. We'll only be adding >> projects to the Next Gen CI system at their request going forward. For