D19396: [kxmlgui] remove deprecated method

2019-02-27 Thread Laurent Montel
mlaurent updated this revision to Diff 52794. mlaurent added a comment. Disable deprecated method until qt5.12 REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19396?vs=52767=52794 BRANCH remove_deprecated_method (branched from master) REVISION DETAIL

D19395: [KJobWidget] remove deprecated method

2019-02-27 Thread Laurent Montel
mlaurent updated this revision to Diff 52793. mlaurent added a comment. Disable deprecated method until 5.12 as requested REPOSITORY R288 KJobWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19395?vs=52765=52793 BRANCH remove_deprecated_method (branched from master)

D19395: [KJobWidget] remove deprecated method

2019-02-27 Thread Laurent Montel
mlaurent marked an inline comment as done. REPOSITORY R288 KJobWidgets REVISION DETAIL https://phabricator.kde.org/D19395 To: mlaurent, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

Is the GSoC Ideas list page still open? YES

2019-02-27 Thread Valorie Zimmerman
We got a question today about the Ideas page - https://community.kde.org/GSoC/2019/Ideas - is open for more ideas. YES! We were accepted as a GSoC org and we are open for business. Prepare to be inundated by students wondering how to make themselves useful to you; please make them welcome and

D19324: Add code-oss icon

2019-02-27 Thread Noah Davis
ndavis added a comment. One last thing, you need to use your real name as your Git user name in order for this patch to pass an automated audit. This page explain how to do that if you need a guide: https://help.github.com/en/articles/setting-your-username-in-git REPOSITORY R266

KDE CI: Frameworks » kded » kf5-qt5 SUSEQt5.10 - Build # 8 - Fixed!

2019-02-27 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kded/job/kf5-qt5%20SUSEQt5.10/8/ Project: kf5-qt5 SUSEQt5.10 Date of build: Thu, 28 Feb 2019 07:26:03 + Build duration: 4 min 27 sec and counting JUnit Tests Name: (root) Failed: 0

D19324: Add code-oss icon

2019-02-27 Thread Noah Davis
ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. In D19324#421552 , @axionl wrote: > This is my first time to contribute plasma/kde project, I feel sorry for my mistakes and thanks for your

KDE CI: Frameworks » kded » kf5-qt5 SUSEQt5.12 - Build # 7 - Fixed!

2019-02-27 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kded/job/kf5-qt5%20SUSEQt5.12/7/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 28 Feb 2019 07:26:02 + Build duration: 4 min 5 sec and counting JUnit Tests Name: (root) Failed: 0

[sysadmin/ci-tooling] pipeline-templates: Make ABI Dump generation failure non-terminal as well until this is corrected for kded.

2019-02-27 Thread Ben Cooksley
Git commit c90b101d10091cfdb06920ca550fd8af123fe443 by Ben Cooksley. Committed on 28/02/2019 at 07:23. Pushed by bcooksley into branch 'master'. Make ABI Dump generation failure non-terminal as well until this is corrected for kded. CCMAIL: kde-frameworks-devel@kde.org M +1-1

KDE CI: Frameworks » kded » kf5-qt5 SUSEQt5.10 - Build # 7 - Still Failing!

2019-02-27 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kded/job/kf5-qt5%20SUSEQt5.10/7/ Project: kf5-qt5 SUSEQt5.10 Date of build: Thu, 28 Feb 2019 07:06:58 + Build duration: 3 min 59 sec and counting JUnit Tests Name: (root) Failed: 0

KDE CI: Frameworks » kded » kf5-qt5 SUSEQt5.12 - Build # 6 - Still Failing!

2019-02-27 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kded/job/kf5-qt5%20SUSEQt5.12/6/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 28 Feb 2019 07:06:56 + Build duration: 2 min 5 sec and counting JUnit Tests Name: (root) Failed: 0

Re: Gitlab Evaluation & Migration

2019-02-27 Thread Ben Cooksley
On Thu, Feb 28, 2019 at 11:24 AM Albert Astals Cid wrote: > > El dimecres, 27 de febrer de 2019, a les 20:12:55 CET, Eike Hein va escriure: > > > > On 2/27/19 4:38 AM, Nate Graham wrote: > > > It's really pretty nice. But Gitlab has a > > > fork-the-repo-and-submit-a-merge-request workflow, so

Re: Gitlab Evaluation & Migration

2019-02-27 Thread Ben Cooksley
On Thu, Feb 28, 2019 at 5:12 PM Michael Pyne wrote: > > On Wed, Feb 27, 2019 at 03:15:58PM -0700, Nate Graham wrote: > > On Wed, 27 Feb 2019 12:12:55 -0700 Eike Hein wrote > > > On 2/27/19 4:38 AM, Nate Graham wrote: > > > > It's really pretty nice. But Gitlab has a > >

[sysadmin/ci-tooling] pipeline-templates: Make ABI checks non-fatal again until the error hit by kded can be corrected.

2019-02-27 Thread Ben Cooksley
Git commit e46a05908d02ca253e8dfbb55905b14f2730eca7 by Ben Cooksley. Committed on 28/02/2019 at 05:33. Pushed by bcooksley into branch 'master'. Make ABI checks non-fatal again until the error hit by kded can be corrected. CCMAIL: skna...@kde.org CCMAIL: kde-frameworks-devel@kde.org M +1-1

D19408: [RFC] Avoid deadlock in use of vi mode searchbar

2019-02-27 Thread loh tar
loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY BUG:368130 TEST PLAN I'm not a vi mode user, so I can't say

Re: Gitlab Evaluation & Migration

2019-02-27 Thread Michael Pyne
On Wed, Feb 27, 2019 at 03:15:58PM -0700, Nate Graham wrote: > On Wed, 27 Feb 2019 12:12:55 -0700 Eike Hein wrote > > On 2/27/19 4:38 AM, Nate Graham wrote: > > > It's really pretty nice. But Gitlab has a > fork-the-repo-and-submit-a-merge-request workflow, so in steps 3 and 4,

D17949: ViewPrivate: Make 'Apply Word Wrap' more comfortable

2019-02-27 Thread loh tar
loh.tar edited the summary of this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17949 To: loh.tar, #ktexteditor, mwolff Cc: dhaumann, cullmann, mwolff, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, ngraham, bruns, demsking, sars

D19407: ModeBase::goToPos: Ensure jump target is valid

2019-02-27 Thread loh tar
loh.tar added a comment. - Is "Fixed in" the right term and number? - I noticed that the cursor jumps one line where I would expect not to move, but I don't use vi-mode REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19407 To: loh.tar, #ktexteditor Cc:

D19407: ModeBase::goToPos: Ensure jump target is valid

2019-02-27 Thread loh tar
loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY BUG:377200 Fixed in: 5.56 REPOSITORY R39 KTextEditor

D18826: Rewrite the taglib extractor to use the generic PropertyMap interface

2019-02-27 Thread Stefan Brüns
bruns added inline comments. INLINE COMMENTS > taglibextractor.cpp:184 > +if (savedProperties.contains("COMPOSER")) { > +const auto composersString = > TStringToQString(savedProperties["COMPOSER"].toString(";")).trimmed(); > +const auto composers =

D19324: Add code-oss icon

2019-02-27 Thread Ariel AxionL
axionl edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19324 To: axionl, #vdg Cc: ndavis, rooty, ngraham, kde-frameworks-devel, michaelh, bruns

D19324: Add code-oss icon

2019-02-27 Thread Krešimir Čohar
rooty added a comment. In D19324#421552 , @axionl wrote: > In D19324#421178 , @ndavis wrote: > > > Great. Now you just need to get rid of the invisible rectangle. You can do that quickly with `sed

D19324: Add code-oss icon

2019-02-27 Thread Ariel AxionL
axionl added a comment. In D19324#421178 , @ndavis wrote: > Great. Now you just need to get rid of the invisible rectangle. You can do that quickly with `sed -i 's|||' code.svg`. After you've done that, I can accept and land this. > > BTW,

D19324: Add code-oss icon

2019-02-27 Thread Ariel AxionL
axionl updated this revision to Diff 52786. axionl added a comment. - Merge branch 'master' into code-oss Remove the invisible rectangle. REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19324?vs=52721=52786 BRANCH code-oss (branched from

D18915: Fix batchrename changing extension to lower case

2019-02-27 Thread Stefan Brüns
bruns added inline comments. INLINE COMMENTS > cfoster wrote in batchrenamejob.cpp:165 > Just making sure I understand you correctly. > Are you saying I should change the function to take the filename as a QString > and extract the filename from the QUrl outside of the function or change >

D19326: [Kconfig] Compile without foreach

2019-02-27 Thread David Faure
dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Did you check that unittests still pass? (please mention this in the "Test Plan:" field of the commit when using arc diff) INLINE COMMENTS > ksharedconfig.cpp:93 > > -

D18915: Fix batchrename changing extension to lower case

2019-02-27 Thread cfoster
cfoster added inline comments. INLINE COMMENTS > bruns wrote in batchrenamejob.cpp:165 > I think you can use `QUrl::filename()`, and you should do it from the calling > code. Just making sure I understand you correctly. Are you saying I should change the function to take the filename as a

Re: Gitlab Evaluation & Migration

2019-02-27 Thread Nicolas Fella
Hey, I've been part of the evaluation with KDE Connect. My experience has been mostly good with a small exception: I personally prefer the push-to-branch model over the fork model, but when trying it with KDE Connect pushing to a branch created IRC commit notifications which caused a lot of

D19396: [kxmlgui] remove deprecated method

2019-02-27 Thread David Faure
dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Same comment as in https://phabricator.kde.org/D19395, the rest looks good. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D19396 To: mlaurent, dfaure

Re: Gitlab Evaluation & Migration

2019-02-27 Thread Albert Astals Cid
El dimecres, 27 de febrer de 2019, a les 20:12:55 CET, Eike Hein va escriure: > > On 2/27/19 4:38 AM, Nate Graham wrote: > > It's really pretty nice. But Gitlab has a > > fork-the-repo-and-submit-a-merge-request workflow, so in steps 3 and 4, > > people without commit access won't just be able

D19395: [KJobWidget] remove deprecated method

2019-02-27 Thread David Faure
dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > CMakeLists.txt:47 > SOVERSION 5) > - > +#add_definitions(-DQT_DISABLE_DEPRECATED_BEFORE=0x06) > Since it's commented out, it's

Re: Gitlab Evaluation & Migration

2019-02-27 Thread Nate Graham
On Wed, 27 Feb 2019 12:12:55 -0700 Eike Hein wrote > On 2/27/19 4:38 AM, Nate Graham wrote: > > It's really pretty nice. But Gitlab has a > > fork-the-repo-and-submit-a-merge-request workflow, so in steps 3 and 4, > > people without commit access won't just be able to start

D12336: Replace several Q_ASSERTs with proper checks

2019-02-27 Thread Stefan Brüns
bruns edited reviewers, added: ngraham, poboiko; removed: michaelh. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12336 To: bruns, #baloo, #frameworks, ngraham, poboiko Cc: ngraham, apol, sitter, kde-frameworks-devel, broulik, #frameworks, domson, ashaposhnikov,

KDE CI: Frameworks » kcrash » kf5-qt5 WindowsMSVCQt5.11 - Build # 27 - Aborted!

2019-02-27 Thread CI System
BUILD ABORTED Build URL https://build.kde.org/job/Frameworks/job/kcrash/job/kf5-qt5%20WindowsMSVCQt5.11/27/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sun, 24 Feb 2019 09:50:46 + Build duration: 3 days 10 hr and counting

KDE CI: Frameworks » kded » kf5-qt5 SUSEQt5.12 - Build # 5 - Failure!

2019-02-27 Thread CI System
ed connection to :90[2019-02-27T19:27:53.585Z] Cannot find file: /home/jenkins/workspace/Frameworks/kded/kf5-qt5 SUSEQt5.12/build/DartConfiguration.tcl[2019-02-27T19:27:53.585Z]Site: [2019-02-27T19:27:53.585Z]Build name: (empty)[2019-02-27T19:27:53.585Z] Create new tag: 20190227-1927 -

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.12 - Build # 11 - Still Unstable!

2019-02-27 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.12/11/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 27 Feb 2019 19:25:18 + Build duration: 3 min 21 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kded » kf5-qt5 SUSEQt5.10 - Build # 6 - Failure!

2019-02-27 Thread CI System
orks/kded/kf5-qt5 SUSEQt5.10/build/DartConfiguration.tcl[2019-02-27T19:27:05.310Z]Site: [2019-02-27T19:27:05.310Z]Build name: (empty)[2019-02-27T19:27:05.310Z] Create new tag: 20190227-1927 - Experimental[2019-02-27T19:27:05.310Z] Cannot find file: /home/jenkins/workspace/Frameworks/kded/k

D18793: Handle text completion with block selection mode

2019-02-27 Thread Ahmad Samir
ahmadsamir added a comment. In D18793#420599 , @loh.tar wrote: > Fix this patch also Bug 382213 ? No, it doesn't fix it. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D18793 To: ahmadsamir, #ktexteditor,

D19396: [kxmlgui] remove deprecated method

2019-02-27 Thread Laurent Montel
mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY remove deprecated method REPOSITORY R263 KXmlGui BRANCH

D19395: [KJobWidget] remove deprecated method

2019-02-27 Thread Laurent Montel
mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY remove deprecated method REPOSITORY R288 KJobWidgets BRANCH

Re: Gitlab Evaluation & Migration

2019-02-27 Thread Eike Hein
On 2/27/19 4:38 AM, Nate Graham wrote: It's really pretty nice. But Gitlab has a fork-the-repo-and-submit-a-merge-request workflow, so in steps 3 and 4, people without commit access won't just be able to start hacking with the source checkout that kdesrc-build downloads, or else they

D19371: Tags ioslave: Do not crash for the "tags:/" URL

2019-02-27 Thread Stefan Brüns
bruns added a comment. Thanks for the fix! I think it is quite alarming that code causing a crash landed in the repo without review ... REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D19371 To: marten, #baloo, ngraham Cc: bruns, kde-frameworks-devel, domson,

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 28 - Still Unstable!

2019-02-27 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/28/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 27 Feb 2019 17:53:49 + Build duration: 11 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 20 - Still Unstable!

2019-02-27 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/20/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 27 Feb 2019 17:53:49 + Build duration: 3 min 49 sec and counting BUILD ARTIFACTS

D19394: Show a warning if a plugin requires a newer version

2019-02-27 Thread Fabian Vogt
This revision was automatically updated to reflect the committed changes. Closed by commit R242:02ec1b77c23e: Show a warning if a plugin requires a newer version (authored by fvogt). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 32 - Still Unstable!

2019-02-27 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/32/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 27 Feb 2019 17:53:49 + Build duration: 3 min 54 sec and counting JUnit Tests

D19394: Show a warning if a plugin requires a newer version

2019-02-27 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D19394 To: fvogt, #plasma, davidedmundson Cc: kde-frameworks-devel, plasma-devel, michaelh,

D19394: Show a warning if a plugin requires a newer version

2019-02-27 Thread Fabian Vogt
fvogt created this revision. fvogt added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. fvogt requested review of this revision. REVISION SUMMARY Currently it just fails silently. TEST PLAN Loaded a plasmoid with an incompatible

D19387: Remove deprecated QSignalMapper

2019-02-27 Thread Laurent Montel
This revision was automatically updated to reflect the committed changes. Closed by commit R235:8856dfad857b: Remove deprecated QSignalMapper (authored by mlaurent). REPOSITORY R235 Attica CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19387?vs=52722=52735 REVISION DETAIL

D19387: Remove deprecated QSignalMapper

2019-02-27 Thread Dan Leinir Turthra Jensen
leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. Much simpler code run, there, lgtm :) REPOSITORY R235 Attica BRANCH remove_deprecated_qsignalmapper (branched from master) REVISION DETAIL https://phabricator.kde.org/D19387 To:

D19324: Add code-oss icon

2019-02-27 Thread Noah Davis
ndavis added a comment. Great. Now you just need to get rid of the invisible rectangle. You can do that quickly with `sed -i 's|||' code.svg`. After you've done that, I can accept and land this. BTW, you're meant to put the comment for the diff update at the top, but it's not a huge

D19367: [RFC]SearchBar: Don't block GUI when enter incremental pattern

2019-02-27 Thread loh tar
loh.tar updated this revision to Diff 52728. loh.tar edited the summary of this revision. loh.tar set the repository for this revision to R39 KTextEditor. loh.tar added a comment. - Don't trigger onIncPatternChanged when update search history - Only save search history on some change

D19388: improve documentation on global config cascading

2019-02-27 Thread Harald Sitter
sitter added a reviewer: kde-frameworks-devel. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D19388 To: sitter, kde-frameworks-devel Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19388: improve documentation on global config cascading

2019-02-27 Thread Harald Sitter
sitter created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY the previous description of IncludeGlobals was a bit lackluster. the new description should make it more obvious what

D19161: Use QTextFormat::TextUnderlineStyle instead of QTextFormat::FontUnderline

2019-02-27 Thread Ahmad Samir
ahmadsamir added a comment. > ! In D19161#415702 , @dhaumann wrote: > Btw, searching in lxr.kde.org for FontUnderline reveals some more hits: https://lxr.kde.org/ident?_i=FontUnderline&_remember=1 Turns out these are false positives; I

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 39 - Still Unstable!

2019-02-27 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/39/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 27 Feb 2019 12:22:58 + Build duration: 13 min and counting JUnit Tests Name: projectroot

D19387: Remove deprecated QSignalMapper

2019-02-27 Thread Laurent Montel
mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY QSignalMapper is deprecated in Qt5 REPOSITORY R235 Attica BRANCH

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 10 - Still Unstable!

2019-02-27 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/10/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 27 Feb 2019 12:22:31 + Build duration: 9 min 3 sec and counting BUILD ARTIFACTS

D19324: Add code-oss icon

2019-02-27 Thread Ariel AxionL
axionl updated this revision to Diff 52719. axionl added a comment. - Merge branch 'master' into code-oss 1. Updating D19324 : Add code-oss icon # 2. Enter a brief description of the changes included in this update. 3. The first line is used as

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.10 - Build # 14 - Still Unstable!

2019-02-27 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.10/14/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 27 Feb 2019 12:22:31 + Build duration: 4 min 26 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.12 - Build # 16 - Still Unstable!

2019-02-27 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.12/16/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 27 Feb 2019 12:22:31 + Build duration: 4 min 50 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.12 - Build # 14 - Still Unstable!

2019-02-27 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.12/14/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 27 Feb 2019 12:22:38 + Build duration: 3 min 57 sec and counting JUnit Tests

D19324: Add code-oss icon

2019-02-27 Thread Ariel AxionL
axionl updated this revision to Diff 52721. axionl added a comment. - Merge branch 'master' into code-oss 1. Updating D19324 : Add code-oss icon # 2. Enter a brief description of the changes included in this update. 3. The first line is used as

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.10 - Build # 9 - Still Unstable!

2019-02-27 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.10/9/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 27 Feb 2019 11:25:45 + Build duration: 5 min 29 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.12 - Build # 6 - Still Unstable!

2019-02-27 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.12/6/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 27 Feb 2019 11:25:47 + Build duration: 1 min 42 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.12 - Build # 5 - Still Unstable!

2019-02-27 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.12/5/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 27 Feb 2019 11:23:16 + Build duration: 2 min 30 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.10 - Build # 8 - Still Unstable!

2019-02-27 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.10/8/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 27 Feb 2019 11:23:16 + Build duration: 2 min 28 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.12 - Build # 9 - Still Unstable!

2019-02-27 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.12/9/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 27 Feb 2019 11:23:16 + Build duration: 1 min 15 sec and counting JUnit Tests Name:

D19384: extend documentation of kpackage_install_bundled_package

2019-02-27 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes. Closed by commit R290:8040f07625fc: extend documentation of kpackage_install_bundled_package (authored by sitter). REPOSITORY R290 KPackage CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19384?vs=52715=52718

D19383: remove kpackage_install_package deprecation warning

2019-02-27 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes. Closed by commit R290:90d9be331715: remove kpackage_install_package deprecation warning (authored by sitter). REPOSITORY R290 KPackage CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19383?vs=52714=52717

D19385: use KPackage::fileUrl to support rcc KCMs packages

2019-02-27 Thread Harald Sitter
sitter created this revision. sitter added a reviewer: mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY the previous code would construct file:// URIs. instead, leave the url construction to

D19383: remove kpackage_install_package deprecation warning

2019-02-27 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R290 KPackage BRANCH no-deprecate REVISION DETAIL https://phabricator.kde.org/D19383 To: sitter, mart Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19384: extend documentation of kpackage_install_bundled_package

2019-02-27 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R290 KPackage BRANCH docs REVISION DETAIL https://phabricator.kde.org/D19384 To: sitter, mart Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19384: extend documentation of kpackage_install_bundled_package

2019-02-27 Thread Harald Sitter
sitter added a dependency: D19383: remove kpackage_install_package deprecation warning. REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D19384 To: sitter, mart Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19383: remove kpackage_install_package deprecation warning

2019-02-27 Thread Harald Sitter
sitter added a dependent revision: D19384: extend documentation of kpackage_install_bundled_package. REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D19383 To: sitter, mart Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19384: extend documentation of kpackage_install_bundled_package

2019-02-27 Thread Harald Sitter
sitter created this revision. sitter added a reviewer: mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY explains how it is different from the other function and also what to watch out for when

D19383: remove kpackage_install_package deprecation warning

2019-02-27 Thread Harald Sitter
sitter created this revision. sitter added a reviewer: mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY an ad-hoc discussion on #plasma-devel suggests the science isn't quite in on whether

Re: Gitlab Evaluation & Migration

2019-02-27 Thread Ben Cooksley
On Wed, Feb 27, 2019 at 5:18 AM Harald Sitter wrote: > > On Mon, Feb 25, 2019 at 2:38 PM Boudewijn Rempt wrote: > > > > On zaterdag 23 februari 2019 12:08:05 CET Boudewijn Rempt wrote: > > > > > * Is there anything we can have that can replace tasks and workboards? We > > > usually have some

D19338: New location for KNSRC files

2019-02-27 Thread Dan Leinir Turthra Jensen
leinir added a comment. In D19338#420303 , @apol wrote: > +1 cool stuff! > > this opens the possibility for files being both in /usr and /etc, can you make sure hell doesn't break loose when that happens? > > Was these files look up was

D19324: Add code-oss icon

2019-02-27 Thread Noah Davis
ndavis added a comment. In D19324#420982 , @axionl wrote: > Just I like it as a modern design style and also avoiding some problems for the similarity of official icon, but if you mind that I can remove it. I think that even though the

D19324: Add code-oss icon

2019-02-27 Thread Ariel AxionL
axionl added a comment. In D19324#420976 , @ndavis wrote: > I see you've kept the green on the light theme version instead of using the same icon for both versions. Is there a reason for this or do you just prefer it? > > This looks just

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.12 - Build # 22 - Still Unstable!

2019-02-27 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.12/22/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 27 Feb 2019 08:08:30 + Build duration: 10 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.10 - Build # 29 - Still Unstable!

2019-02-27 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.10/29/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 27 Feb 2019 08:08:30 + Build duration: 9 min 44 sec and counting BUILD ARTIFACTS

D19371: Tags ioslave: Do not crash for the "tags:/" URL

2019-02-27 Thread Jonathan Marten
This revision was automatically updated to reflect the committed changes. Closed by commit R293:604a2f402da7: Check string length to avoid crash for tags:/ URL (authored by marten). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D19371?vs=52681=52703#toc REPOSITORY R293 Baloo CHANGES