D24652: Add folder-recent, extend hand of clock in folder-temp

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24652 To: ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24652: Add folder-recent, extend hand of clock in folder-temp

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY folder-recent is merely a symlink to folder-temp since they both normally use the same

D24627: [icons/media.svg] Add 16 & 32px icons, update style

This revision was automatically updated to reflect the committed changes. Closed by commit R242:15ed55b4cb71: [icons/media.svg] Add 16 32px icons, update style (authored by ndavis). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D24627: [icons/media.svg] Add 16 & 32px icons, update style

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Heh, I never noticed that these were blurry, but now I can't un-see it! REPOSITORY R242 Plasma Framework (Library) BRANCH media-icons (branched from master) REVISION DETAIL

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.13 - Build # 28 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/28/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 15 Oct 2019 01:15:44 + Build duration: 1 min 58 sec and counting JUnit Tests Name:

D24651: Use ECMGenerateExportHeader to manage deprecated API better

kossebau created this revision. kossebau added reviewers: Frameworks, mirko. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Allows - projects linking to ThreadWeaver to hide deprecated API up

D24650: Use ECMGenerateExportHeader to manage deprecated API better

kossebau created this revision. kossebau added reviewers: Frameworks, gladhorn, leinir. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Allows - projects linking to Attica to hide deprecated

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 149 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/149/ Project: kf5-qt5 SUSEQt5.13 Date of build: Mon, 14 Oct 2019 20:15:46 + Build duration: 3 hr 43 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.13 - Build # 47 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.13/47/ Project: kf5-qt5 SUSEQt5.13 Date of build: Mon, 14 Oct 2019 14:33:17 + Build duration: 8 hr 56 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kbookmarks » kf5-qt5 WindowsMSVCQt5.13 - Build # 14 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kbookmarks/job/kf5-qt5%20WindowsMSVCQt5.13/14/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Mon, 14 Oct 2019 21:23:47 + Build duration: 31 min and counting JUnit Tests Name:

D24621: [RFC] New Konsole and Yakuake icons

mglb edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24621 To: mglb, #vdg, #konsole, #yakuake, trickyricky26 Cc: trickyricky26, ndavis, cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24621: [RFC] New Konsole and Yakuake icons

mglb added a comment. Please note that Konsole icon is intended to be personalized icon/"logo" (see T10243 ). The prompt symbol is thick as it is main symbol (like symbols in e.g Plasma, Akregator, Kile, "K" icons/logos) - the window-like background (or

Re: Can we agree to change gitlab default behaviour from merge to fast-forward merge for all repos?

On 14.10.2019 21:22, Frederik Schwarzer wrote: > If however, master had seen commits as well, fast-forwarding is > performing a rebase ... is that correct? The workflow would be: whenever master is updated, you rebase your local feature/work branch and force-push to the remote copy of the

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 135 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/135/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 14 Oct 2019 17:37:41 + Build duration: 3 hr 2 min and counting JUnit Tests Name:

D24621: [RFC] New Konsole and Yakuake icons

mglb updated this revision to Diff 67926. mglb added a comment. Brighten background REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24621?vs=67871=67926 BRANCH mglb/add-konsole-yakuake-icons REVISION DETAIL https://phabricator.kde.org/D24621

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 148 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/148/ Project: kf5-qt5 SUSEQt5.13 Date of build: Mon, 14 Oct 2019 13:58:31 + Build duration: 6 hr 17 min and counting BUILD ARTIFACTS

D24643: Use ECMGenerateExportHeader to manage deprecated API better

kossebau created this revision. kossebau added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Allows - projects linking to KGlobalAccel to hide deprecated API up to a

D24466: Use ECMGenerateExportHeader to manage deprecated API better

dfaure added a comment. For the record, I get WARNING: QObject::connect|main QObject::connect: Connecting from COMPAT signal (Object::signalIt()) But indeed that's because I build my Qt in debug mode. The only mode that truly matters for developers :-) Maybe Qt shouldn't use

D24628: Fix incorrect margins in 16/22px media icons

This revision was automatically updated to reflect the committed changes. Closed by commit R266:83c8768b2a70: Fix incorrect margins in 16/22px media icons (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24628?vs=67887=67924 REVISION

D24641: Collect more information from version control systems

thomasfischer edited the summary of this revision. thomasfischer added reviewers: sitter, kossebau. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D24641 To: thomasfischer, sitter, kossebau Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2,

D24466: Use ECMGenerateExportHeader to manage deprecated API better

kossebau added a comment. In D24466#547084 , @dfaure wrote: > check_and_warn_compat does not warn for this testcase because the slot is deprecated too. > Try a deprecated signal and a non-deprecated slot :-) > > 2714│ if

D24641: Collect more information from version control systems

thomasfischer created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. thomasfischer requested review of this revision. REVISION SUMMARY In KBibTeX, there is a `getgit.cmake`

Re: Can we agree to change gitlab default behaviour from merge to fast-forward merge for all repos?

On 14.10.2019 21:22, Frederik Schwarzer wrote: Hi, just asking in case I didn't get it. I branch off of master and do a few commits in that new branch. If I now merge the branch back to master and master had not seen any commits in between, it's just relocating the master "tag" and all is

D24466: Use ECMGenerateExportHeader to manage deprecated API better

dfaure added a comment. Thanks for the investigation. check_and_warn_compat does not warn for this testcase because the slot is deprecated too. Try a deprecated signal and a non-deprecated slot :-) 2714│ if (signal.attributes() & QMetaMethod::Compatibility) { 2715│

D24465: Use ECMGenerateExportHeader to manage deprecated API better

This revision was automatically updated to reflect the committed changes. Closed by commit R278:7dc38306b5b6: Use ECMGenerateExportHeader to manage deprecated API better (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24465?vs=67718=67921#toc REPOSITORY R278

Re: Can we agree to change gitlab default behaviour from merge to fast-forward merge for all repos?

Hi, just asking in case I didn't get it. I branch off of master and do a few commits in that new branch. If I now merge the branch back to master and master had not seen any commits in between, it's just relocating the master "tag" and all is fine. If however, master had seen commits as

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 266 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/266/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 14 Oct 2019 17:35:06 + Build duration: 45 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 134 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/134/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 14 Oct 2019 12:09:16 + Build duration: 5 hr 28 min and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 265 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/265/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 14 Oct 2019 15:44:14 + Build duration: 1 hr 50 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.13 - Build # 111 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.13/111/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Mon, 14 Oct 2019 17:22:07 + Build duration: 13 min and counting

D24590: Port KSslErrorUiData to QSslError

This revision was automatically updated to reflect the committed changes. Closed by commit R241:77fce361d9ba: Port KSslErrorUiData to QSslError (authored by vkrause). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24590?vs=67828=67918#toc REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 70 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/70/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 14 Oct 2019 14:50:55 + Build duration: 2 hr 19 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 94 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/94/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 14 Oct 2019 14:50:53 + Build duration: 2 hr 11 min and counting BUILD ARTIFACTS

Re: Get Hot New Stuff Dead or Alive?

On Sunday, October 13, 2019 1:57:06 PM EDT Ben Cooksley wrote: > On Mon, Oct 14, 2019 at 6:06 AM Allen Winter wrote: > > > > or maybe renamed? > > Hi Allen, > > > > > How do I find out if there are any GHNS for KOrganizer. > > The Import->GHNS menu in KOrganizer starts and I see the import

Re: Can we agree to change gitlab default behaviour from merge to fast-forward merge for all repos?

Yes, please, pretty please with cherry on top. :) Regards, -Johan On Sun, Oct 13, 2019 at 10:57 PM Albert Astals Cid wrote: > > I find the merge behavior to be not what we've been doing in phabricator so > given the idea is to maintain our workflows i'd appreciate if we can agree on >

D24466: Use ECMGenerateExportHeader to manage deprecated API better

kossebau added a comment. In D24466#546952 , @dfaure wrote: > Maybe Qt doesn't have any deprecated signals? That would be nice :) A few there are though, e.g. see here some for QComboBox, only using `QT_DEPRECATED_SINCE` &

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 264 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/264/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 14 Oct 2019 13:58:31 + Build duration: 1 hr 45 min and counting BUILD ARTIFACTS

D24628: Fix incorrect margins in 16/22px media icons

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH media-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D24628 To: ndavis, #vdg, ngraham Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D24466: Use ECMGenerateExportHeader to manage deprecated API better

dfaure added a comment. Maybe Qt doesn't have any deprecated signals? REPOSITORY R263 KXmlGui BRANCH deprecatedapi REVISION DETAIL https://phabricator.kde.org/D24466 To: kossebau, #frameworks, dfaure, mlaurent Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.13 - Build # 110 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.13/110/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Mon, 14 Oct 2019 13:58:31 + Build duration: 13 min and counting CONSOLE OUTPUT

D24631: exclude ioslaves directory from api docs

This revision was automatically updated to reflect the committed changes. Closed by commit R241:d05d03f2f13e: exclude ioslaves directory from api docs (authored by sitter). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24631?vs=67895=67900 REVISION DETAIL

D24631: exclude ioslaves directory from api docs

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH no-slave-dox REVISION DETAIL https://phabricator.kde.org/D24631 To: sitter, dfaure, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 147 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/147/ Project: kf5-qt5 SUSEQt5.13 Date of build: Mon, 14 Oct 2019 12:09:15 + Build duration: 1 hr 10 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 263 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/263/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 14 Oct 2019 12:09:15 + Build duration: 1 hr 6 min and counting BUILD ARTIFACTS

D24466: Use ECMGenerateExportHeader to manage deprecated API better

kossebau added inline comments. INLINE COMMENTS > kossebau wrote in kactioncollection.h:314 > Okay, so "QT_MOC_COMPAT" is still a (just undocumented) thing, and thus > something we should use for deprecated signal/slots then as before, right? > > Had now another look based on your info, and

D24466: Use ECMGenerateExportHeader to manage deprecated API better

kossebau added inline comments. INLINE COMMENTS > dfaure wrote in kactioncollection.h:314 > Taking this from the other side: warnings when connecting to deprecated > signals actually work. They happen in check_and_warn_compat in qobject.cpp > > ... this does support warning about connecting to

D24631: exclude ioslaves directory from api docs

ahmadsamir added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24631 To: sitter, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24263: edit mode action

mart marked an inline comment as done. REPOSITORY R242 Plasma Framework (Library) BRANCH phab/editModeActionwq! REVISION DETAIL https://phabricator.kde.org/D24263 To: mart, #plasma, #vdg, ngraham Cc: broulik, GB_2, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D24263: edit mode action

mart updated this revision to Diff 67896. mart added a comment. - add ellipsis REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24263?vs=67557=67896 BRANCH phab/editModeActionwq! REVISION DETAIL https://phabricator.kde.org/D24263

D24629: RFC: Introduce KClockSkewNotifier class

zzag abandoned this revision. zzag added a comment. Okay REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D24629 To: zzag, #frameworks Cc: apol, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24629: RFC: Introduce KClockSkewNotifier class

apol added a comment. It feels weird to create a class directly into KF5 when it hasn't even started to be used. It could make sense to develop it within some of the apps and when we are sure the API is stable and it wants to be used on other components/products, we can promote it to the

D24630: Replace all qWarning and related calls with categorised logging

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R249 KI18n BRANCH categorised_logging REVISION DETAIL https://phabricator.kde.org/D24630 To: ahiemstra, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24631: exclude ioslaves directory from api docs

sitter created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY they do not feature (public) api TEST PLAN kapidox_generate no longer lists slave classes that happen to have

D19504: Extend KHtmlView::print() to use a predefined QPrinter instance

ahmadsamir added reviewers: dfaure, vkrause. REPOSITORY R313 KHtml REVISION DETAIL https://phabricator.kde.org/D19504 To: habacker, dfaure, vkrause Cc: aacid, tbaumgart, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24621: [RFC] New Konsole and Yakuake icons

trickyricky26 requested changes to this revision. trickyricky26 added a comment. This revision now requires changes to proceed. Before this is can be landed, you will have to also add/change the Konsole and Yakuake icons in the icons-dark directory. While I think these icons do look nice

D19504: Extend KHtmlView::print() to use a predefined QPrinter instance

habacker updated this revision to Diff 67894. habacker added a comment. - Another attempt after 9 minor releases have elapsed. REPOSITORY R313 KHtml CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19504?vs=53327=67894 BRANCH master REVISION DETAIL

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 133 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/133/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 14 Oct 2019 10:58:37 + Build duration: 14 min and counting JUnit Tests Name: projectroot

D24630: Replace all qWarning and related calls with categorised logging

ahiemstra created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ahiemstra requested review of this revision. REVISION SUMMARY This replaces all uncategorised qWarning() calls with calls to qCWarning(), using the kf5.ki18n category for

D24629: RFC: Introduce KClockSkewNotifier class

davidedmundson added a comment. We have similar code in plasma-workspace/dataengines/time that has a faux BSD implementation by using a combination of the legacy, but working: QDBusConnection dbus = QDBusConnection::sessionBus(); dbus.connect(QString(), QString(),

D24588: [SslUi] Add api docs for askIgnoreSslErrors()

This revision was automatically updated to reflect the committed changes. Closed by commit R241:c38591b9d2a9: [SslUi] Add api docs for askIgnoreSslErrors() (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24588?vs=67834=67892 REVISION

D24627: [icons/media.svg] Add 16 & 32px icons, update style

ndavis edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D24627 To: ndavis, #vdg, #plasma Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24629: RFC: Introduce KClockSkewNotifier class

zzag created this revision. zzag added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. zzag requested review of this revision. REVISION SUMMARY The new class provides a way for monitoring system clock changes. This class can be

D19504: Extend KHtmlView::print() to use a predefined QPrinter instance

habacker added a comment. ping ? REPOSITORY R313 KHtml REVISION DETAIL https://phabricator.kde.org/D19504 To: habacker Cc: aacid, tbaumgart, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24628: Fix incorrect margins in 16/22px media icons

ndavis edited the summary of this revision. ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24628 To: ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24628: Fix incorrect margins in 16/22px media icons

ndavis added a dependent revision: D24627: [icons/media.svg] Add 16 & 32px icons, update style. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24628 To: ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24627: [icons/media.svg] Add 16 & 32px icons, update style

ndavis added a dependency: D24628: Fix incorrect margins in 16/22px media icons. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D24627 To: ndavis, #vdg, #plasma Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24628: Fix incorrect margins in 16/22px media icons

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY For some reason, the margins on these icons were 1 px larger on each side than they were

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 261 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/261/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 14 Oct 2019 10:11:56 + Build duration: 18 min and counting BUILD ARTIFACTS

D24627: [icons/media.svg] Add 16 & 32px icons, update style

ndavis edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D24627 To: ndavis, #vdg, #plasma Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24627: [icons/media.svg] Add 16 & 32px icons, update style

ndavis created this revision. ndavis added reviewers: VDG, Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY Fixes blurry icons in the desktop shell REPOSITORY R242 Plasma Framework

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 145 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/145/ Project: kf5-qt5 SUSEQt5.13 Date of build: Mon, 14 Oct 2019 10:11:56 + Build duration: 10 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.13 - Build # 107 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.13/107/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Mon, 14 Oct 2019 10:11:56 + Build duration: 10 min and counting

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 132 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/132/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 14 Oct 2019 10:11:56 + Build duration: 9 min 22 sec and counting JUnit Tests Name:

D24558: fix proxy setting loading

This revision was automatically updated to reflect the committed changes. Closed by commit R241:d1a3b9d08158: fix proxy setting loading (authored by sitter). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24558?vs=67702=67880 REVISION DETAIL

D24559: simplify the url parsing

This revision was automatically updated to reflect the committed changes. Closed by commit R241:c904cbcb9876: simplify the url parsing (authored by sitter). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24559?vs=67703=67881 REVISION DETAIL

D24560: remove legacy space handling code

This revision was automatically updated to reflect the committed changes. Closed by commit R241:c372fa3c4236: remove legacy space handling code (authored by sitter). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24560?vs=67704=67882 REVISION DETAIL

D23579: port ftp slave to new error reporting system

This revision was automatically updated to reflect the committed changes. sitter marked 3 inline comments as done. Closed by commit R241:c86eedf0f92d: port ftp slave to new error reporting system (authored by sitter). CHANGED PRIOR TO COMMIT

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.13 - Build # 106 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.13/106/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Mon, 14 Oct 2019 10:03:06 + Build duration: 3 min 24 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 144 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/144/ Project: kf5-qt5 SUSEQt5.13 Date of build: Mon, 14 Oct 2019 10:03:06 + Build duration: 1 min 27 sec and counting CONSOLE OUTPUT [...truncated 311

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 260 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/260/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 14 Oct 2019 10:03:06 + Build duration: 1 min 32 sec and counting CONSOLE OUTPUT [...truncated 311

D24465: Use ECMGenerateExportHeader to manage deprecated API better

zzag accepted this revision. This revision is now accepted and ready to land. REPOSITORY R278 KWindowSystem BRANCH useECMGenerateExportHeader REVISION DETAIL https://phabricator.kde.org/D24465 To: kossebau, #frameworks, #kwin, dfaure, zzag Cc: kde-frameworks-devel, LeGast00n, GB_2,

Re: Can we agree to change gitlab default behaviour from merge to fast-forward merge for all repos?

On zondag 13 oktober 2019 22:57:20 CEST Albert Astals Cid wrote: > I find the merge behavior to be not what we've been doing in phabricator so > given the idea is to maintain our workflows i'd appreciate if we can agree on > continue doing the same. > >

D24625: Fill middle mouse button area

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24625 To: ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24625: Fill middle mouse button area

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY The negative space in the middle didn't quite look right REPOSITORY R266 Breeze Icons

D24560: remove legacy space handling code

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. If you say so :-) REPOSITORY R241 KIO BRANCH remove-dead-proxy-load-code REVISION DETAIL https://phabricator.kde.org/D24560 To: sitter, dfaure Cc: kde-frameworks-devel, LeGast00n,

D24590: Port KSslErrorUiData to QSslError

vkrause added a comment. In D24590#546528 , @aacid wrote: > Do we have tests for the thing you discovered breaks? Do we need them? There's almost no test coverage for this unfortunately, and yes, I'd feel much better if we had that. I

D24588: [SslUi] Add api docs for askIgnoreSslErrors()

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH ahmad/ktcpsocket-qsslsocket (branched from master) REVISION DETAIL https://phabricator.kde.org/D24588 To: ahmadsamir, dfaure, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2,

Re: Can we agree to change gitlab default behaviour from merge to fast-forward merge for all repos?

On Пн, окт 14, 2019 at 02:42, Aleix Pol wrote: On Sun, Oct 13, 2019 at 10:57 PM Albert Astals Cid wrote: I find the merge behavior to be not what we've been doing in phabricator so given the idea is to maintain our workflows i'd appreciate if we can agree on continue doing the same.

D24612: Use the text rather than highlight color for rating/star emblem

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. This icon never needed to be blue. I think I just kept it blue because that's what it was originally. REPOSITORY R266 Breeze Icons BRANCH monochrome-rating-emblem (branched from