D26412: [Kuit] Port QRegExp to QRegularExpression

This revision was automatically updated to reflect the committed changes. Closed by commit R249:7e20f49520d9: [Kuit] Port QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26412?vs=72756=72764 REVISION

D26366: [Kuit] Port QRegExp to QRegularExpression, third pass

This revision was automatically updated to reflect the committed changes. Closed by commit R249:a9f4cbdda790: [Kuit] Port QRegExp to QRegularExpression, third pass (authored by ahmadsamir). REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26366?vs=72748=72763

D26412: [Kuit] Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 72756. ahmadsamir added a comment. Rebase after unit test commits REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26412?vs=72727=72756 BRANCH l-salvageMarkup (branched from master) REVISION DETAIL

D26366: [Kuit] Port QRegExp to QRegularExpression, third pass

ahmadsamir updated this revision to Diff 72748. ahmadsamir added a comment. Rebase after the unit tests commits REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26366?vs=72710=72748 BRANCH l-parseUiM (branched from master) REVISION DETAIL

D26412: [Kuit] Port QRegExp to QRegularExpression

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, ilic, dfaure, mlaurent, aacid. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY Port salvageMarkup() to QRegularExpression. Remove one redundant QRegExp #include.

D26366: [Kuit] Port QRegExp to QRegularExpression, third pass

ahmadsamir added a comment. In D26366#587313 , @dfaure wrote: > See D26408 for a unittest. But maybe the code can just be killed... My 2p, keep it as it looks like a way to override the default

D26366: [Kuit] Port QRegExp to QRegularExpression, third pass

ahmadsamir added a comment. About the unit test, I couldn't think of a way to test it, unless I use a snippet to check the regex (like you did in D26332 ), which doesn't seem to fit in a unit test for KLocalizedString... REPOSITORY R249 KI18n REVISION

D26366: [Kuit] Port QRegExp to QRegularExpression, third pass

ahmadsamir updated this revision to Diff 72709. ahmadsamir added a comment. Use a meaningful name for the QRegularExpression object Explain the (my) logic behind the changes in parseUiMarker() in the commit message REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE

D26366: [Kuit] Port QRegExp to QRegularExpression, third pass

ahmadsamir updated this revision to Diff 72710. ahmadsamir edited the summary of this revision. ahmadsamir added a comment. Verbatim REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26366?vs=72709=72710 BRANCH l-parseUiM (branched from master) REVISION

D26123: Port QRegExp to QRegularExpression

ahmadsamir added a comment. FTR; in one of my inline comments I said: > And I found that: > > - {,3} in QRegExp is equivalent to {0,3} > - {,3} in QRegularExpression is equivalent to {1,3} The second part is actually wrong (as I was told by dfaure who was told by upstream

D26366: [Kuit] Port QRegExp to QRegularExpression, third pass

ahmadsamir added inline comments. INLINE COMMENTS > dfaure wrote in kuitmarkup.cpp:90 > Interesting idea, this simplifies the code. > > However the name "wsRx" no longer matches what this regexp does. > > Also, the old trimming is missing here, isn't it? > I guess \s*:?\s* is needed, and

D26376: [Kuit] Use const and QList::at() as need be

This revision was automatically updated to reflect the committed changes. Closed by commit R249:54170b448924: [Kuit] Use const and QList::at() as need be (authored by ahmadsamir). REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26376?vs=72649=72660 REVISION

D26376: [Kuit] Use const and QList::at() as need be

ahmadsamir created this revision. ahmadsamir added a reviewer: apol. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY toInterfacePath(), toKeyCombo(): use const and QList::at() where possible. TEST PLAN make && ctest REPOSITORY R249 KI18n

D26360: [Kuit] Port QRegExp to QRegularExpression, second pass

This revision was automatically updated to reflect the committed changes. Closed by commit R249:52cb9a5c2aaa: [Kuit] Port QRegExp to QRegularExpression, second pass (authored by ahmadsamir). REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26360?vs=72647=72648

D26360: [Kuit] Port QRegExp to QRegularExpression, second pass

ahmadsamir updated this revision to Diff 72647. ahmadsamir added a comment. Make the diff less noisy, split unrelated optimisations in a separate commit REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26360?vs=72601=72647 BRANCH l-toKeyCombo (branched from

D26374: [Attica] Port QRegExp to QRegularExpression

This revision was automatically updated to reflect the committed changes. Closed by commit R235:094968d5648f: [Attica] Port QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R235 Attica CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26374?vs=72643=72645 REVISION

D26374: [Attica] Port QRegExp to QRegularExpression

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, apol. Herald added a project: Frameworks. ahmadsamir requested review of this revision. TEST PLAN make && ctest REPOSITORY R235 Attica BRANCH l-qregularexpression (branched from master) REVISION DETAIL

D26285: [KuitFormatterPrivate] Start porting QRegExp to QRegularExpression

ahmadsamir added inline comments. INLINE COMMENTS > dfaure wrote in kuitmarkup.cpp:1597 > I thought it was the resolved version, without entities (if they were > successfully resolved). If the entity is unknown it'll be left as is, I don't know how often that actually happens though.

D26366: [Kuit] Port QRegExp to QRegularExpression, third pass

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, ilic, dfaure, mlaurent, aacid. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY Port parseUiMarker() and determineIsStructured(). TEST PLAN make && ctest REPOSITORY

D26208: [KEmailAddress] Remove redundant bool var

This revision was automatically updated to reflect the committed changes. Closed by commit R270:9e8f0306b549: [KEmailAddress] Remove redundant bool var (authored by ahmadsamir). REPOSITORY R270 KCodecs CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26208?vs=72142=72611 REVISION

D26360: [Kuit] Port QRegExp to QRegularExpression, second pass

ahmadsamir added inline comments. INLINE COMMENTS > apol wrote in kuitmarkup.cpp:412 > Why did you change [i] to at(i)? According to the QList docs, at() should be used for read-only access, it could be faster than [] and it never causes a detach. REPOSITORY R249 KI18n REVISION DETAIL

D26359: Port QRegExp to QRegularExpression

This revision was automatically updated to reflect the committed changes. Closed by commit R290:ab6743ffc5f3: Port QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R290 KPackage CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26359?vs=72598=72603 REVISION DETAIL

D26360: [Kuit] Port QRegExp to QRegularExpression, second pass

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, ilic, dfaure, mlaurent, aacid. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY Port KuitStaticData::toKeyCombo() and KuitStaticData::toInterfacePath() to

D26359: Port QRegExp to QRegularExpression

ahmadsamir created this revision. ahmadsamir added a reviewer: Plasma. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY With QRegularExpression, a "-" character inside a character class, [], indicates a range; one way to match a literal "-"

D26285: [KuitFormatterPrivate] Start porting QRegExp to QRegularExpression

ahmadsamir added a task: T12279: Port frameworks away from QRegExp. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D26285 To: ahmadsamir, #frameworks, ilic, dfaure, mlaurent, aacid Cc: kde-frameworks-devel, ltoscano, LeGast00n, GB_2, michaelh, ngraham, bruns

D26339: [KFileWidgets] Port QRegExp to QRegularExpression

ahmadsamir added a task: T12279: Port frameworks away from QRegExp. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26339 To: ahmadsamir, dfaure, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26285: [KuitFormatterPrivate] Start porting QRegExp to QRegularExpression

This revision was automatically updated to reflect the committed changes. Closed by commit R249:f9b932d254c4: [KuitFormatterPrivate] Start porting QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE

D26292: [KSambaShare] Port QRegExp to QRegularExpression

ahmadsamir added a comment. In D26292#586025 , @dfaure wrote: > Now I'm completely confused. Did you just argue *against* your own change? > > You seem to say the old name was better... The original code, before I put my paws on it,

D26339: [KFileWidgets] Port QRegExp to QRegularExpression

This revision was automatically updated to reflect the committed changes. Closed by commit R241:c930030308cc: [KFileWidgets] Port QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26339?vs=72564=72568 REVISION

D26285: [KuitFormatterPrivate] Start porting QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 72567. ahmadsamir added a comment. Ternary that doesn't return a value is weird, better avoid. "Grammar fixes" in comments add noise to the diff, be kind to reviewers. REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE

D26339: [KFileWidgets] Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 72564. ahmadsamir added a comment. Declare QRegularExpression before for-loop REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26339?vs=72527=72564 BRANCH l-kfilewidgets-regexp (branched from master) REVISION DETAIL

D26332: [KURISearchFilterEngine] Port QRegExp to QRegularExpression

This revision was automatically updated to reflect the committed changes. Closed by commit R241:411df4148937: [KURISearchFilterEngine] Port QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26332?vs=72528=72562

D26332: [KURISearchFilterEngine] Port QRegExp to QRegularExpression

ahmadsamir added a comment. In D26332#585913 , @dfaure wrote: > Tested with http://www.davidfaure.fr/2020/qregularexpr_replace.cpp This is also covered by kurifiltertest. REPOSITORY R241 KIO BRANCH l-ikws (branched from master)

D26292: [KSambaShare] Port QRegExp to QRegularExpression

ahmadsamir added inline comments. INLINE COMMENTS > dfaure wrote in ksambashare.cpp:259 > badPattern was a bad name? ;-) !notToMatchRx.match() -> "not notToMatchRx" double negative, slightly weird/heavy on the ear. !badPattern.match() -> "not badPattern" -> valid share name; there's method to

D26292: [KSambaShare] Port QRegExp to QRegularExpression

This revision was automatically updated to reflect the committed changes. Closed by commit R241:4965c4f9e2a2: [KSambaShare] Port QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26292?vs=72543=72559 REVISION

D26292: [KSambaShare] Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 72543. ahmadsamir edited the summary of this revision. ahmadsamir added a comment. Address comments (from other reviews) REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26292?vs=72386=72543 BRANCH

D26285: [KuitFormatterPrivate] Start porting QRegExp to QRegularExpression

ahmadsamir added inline comments. INLINE COMMENTS > dfaure wrote in kuitmarkup.cpp:1342 > Duplication :-) > > Dangerous, if the actual char* is modified one day. Personally, I needed to see the actual regex spelled out like that to understand the rest of the code in this function, this:

D26285: [KuitFormatterPrivate] Start porting QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 72539. ahmadsamir edited the summary of this revision. ahmadsamir added a comment. Address comments REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26285?vs=72363=72539 BRANCH l-finalizeVisualText (branched from

D26118: Port QRegExp to QRegularExpression

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R283:b2975d8e630c: Port QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R283 KAuth CHANGES SINCE

D26332: [KURISearchFilterEngine] Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 72528. ahmadsamir added a comment. Address comments: Search offset can't be +=, since the position is moves with capturedStart(). More compact code, always declare where used (don't micro-optimise?) REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D26339: [KFileWidgets] Port QRegExp to QRegularExpression

ahmadsamir added inline comments. INLINE COMMENTS > dfaure wrote in kfilewidget.cpp:2458 > declare where used Declaring rx before the for-loop isn't more efficient? then inside the for-loop it's the same QRegularExpression object and setPattern() is called. REPOSITORY R241 KIO REVISION

D26339: [KFileWidgets] Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 72527. ahmadsamir added a comment. Use const REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26339?vs=72522=72527 BRANCH l-kfilewidgets-regexp (branched from master) REVISION DETAIL

D26207: Port QRegExp to QRegularExpression

This revision was automatically updated to reflect the committed changes. Closed by commit R306:2b4279cd9dd2: Port QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R306 KParts CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26207?vs=72134=72524 REVISION DETAIL

D26193: KNotifyConfig: port QRegExp to QRegularExpression

This revision was automatically updated to reflect the committed changes. Closed by commit R305:99b0074734e4: KNotifyConfig: port QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R305 KNotifyConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26193?vs=72107=72523

D26339: [KFileWidgets] Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 72522. ahmadsamir added a comment. Address comments REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26339?vs=72517=72522 BRANCH l-kfilewidgets-regexp (branched from master) REVISION DETAIL

D26339: [KFileWidgets] Port QRegExp to QRegularExpression

ahmadsamir created this revision. ahmadsamir added reviewers: dfaure, apol. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY Optimise the code in checkPreviewInternal(): use const where possible, and use range-for instead of iterator-based

D26332: [KURISearchFilterEngine] Port QRegExp to QRegularExpression

ahmadsamir created this revision. ahmadsamir added reviewers: dfaure, apol. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY Use const as need be. Use QList::at() where possible. TEST PLAN make && ctest REPOSITORY R241 KIO BRANCH

D26177: Port QRegExp to QRegularExpression

ahmadsamir added inline comments. INLINE COMMENTS > dfaure wrote in kconfig_compiler.cpp:646 > I do, and they were, that was always a big selling point for Qt ;) > > (I started contributing to KDE at the time of Qt 1.1, in 1998) :D REPOSITORY R237 KConfig BRANCH l-qregularexpression

D26292: [KSambaShare] Port QRegExp to QRegularExpression

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY Use QRegularExpression::anchoredPattern() to port QRegExp::exactMatch(). TEST PLAN make && ctest REPOSITORY

D26208: [KEmailAddress] Remove redundant bool var

ahmadsamir added a comment. Ping. REPOSITORY R270 KCodecs REVISION DETAIL https://phabricator.kde.org/D26208 To: ahmadsamir, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26118: Port QRegExp to QRegularExpression

ahmadsamir added reviewers: dfaure, apol. REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D26118 To: ahmadsamir, #frameworks, mlaurent, dfaure, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26285: [KuitFormatterPrivate] Start porting QRegExp to QRegularExpression

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, ilic, dfaure, mlaurent, aacid. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY Port toVisualText() and finalizeVisualText() to use QRegularExpression. Replace

D25877: [KColorschemeManager] Add option to reenable following global theme

ahmadsamir added inline comments. INLINE COMMENTS > ahmadsamir wrote in kcolorschememanager.h:111 > I would say yes (your question made me search for an answer since I wanted > too:)), from > https://community.kde.org/Guidelines_and_HOWTOs/API_Documentation: > > > The @since tag tells users

D25877: [KColorschemeManager] Add option to reenable following global theme

ahmadsamir added inline comments. INLINE COMMENTS > davidre wrote in kcolorschememanager.h:111 > Would I need to add @since for a new overload? I would say yes (your question made me search for an answer since I wanted too:)), from

D26236: Port QRegExp to QRegularExpression (and some QStringRef optimisation)

ahmadsamir updated this revision to Diff 72266. ahmadsamir edited the summary of this revision. ahmadsamir added a comment. Address comments REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26236?vs=72213=72266 BRANCH l-qregularexpression (branched from

D26236: Port QRegExp to QRegularExpression (and some QStringRef optimisation)

This revision was automatically updated to reflect the committed changes. Closed by commit R241:ee88418ec827: Port QRegExp to QRegularExpression (and some QStringRef optimisation) (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D26099: Port QRegExp to QRegularExpression

ahmadsamir added a comment. Ping. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D26099 To: ahmadsamir, #baloo, meven, bruns, astippich, mlaurent Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh,

D26118: Port QRegExp to QRegularExpression

ahmadsamir added a comment. Ping. REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D26118 To: ahmadsamir, #frameworks, mlaurent Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26236: Port QRegExp to QRegularExpression (and some QStringRef optimisation)

ahmadsamir added a task: T12279: Port frameworks away from QRegExp. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26236 To: ahmadsamir, #frameworks, dfaure, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26226: [KListOpenFilesJob] Use QString::splitRef()

ahmadsamir added a task: T12279: Port frameworks away from QRegExp. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D26226 To: ahmadsamir, #frameworks, mpyne, dfaure, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26226: [KListOpenFilesJob] Use QString::splitRef()

This revision was automatically updated to reflect the committed changes. Closed by commit R244:4bcf55e06c2f: [KListOpenFilesJob] Use QString::splitRef() (authored by ahmadsamir). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26226?vs=72207=72216

D26236: Port QRegExp to QRegularExpression (and some QStringRef optimisation)

ahmadsamir updated this revision to Diff 72213. ahmadsamir retitled this revision from "Port QRegExp to QRegularExpression (and some QStringRef) optimisation" to "Port QRegExp to QRegularExpression (and some QStringRef optimisation)". ahmadsamir added a comment. Fix commit message typo

D26236: Port QRegExp to QRegularExpression (and some QStringRef) optimisation

ahmadsamir added inline comments. INLINE COMMENTS > kurlcompletion.cpp:503 > // no protocol. (QUrl does this only for absolute paths) > -if (protocol_regex.indexIn(url_copy) == 0) { > +if (protocol_regex.match(url_copy).hasMatch()) { > m_kurl = QUrl(url_copy); hasMatch()

D26236: Port QRegExp to QRegularExpression (and some QStringRef) optimisation

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, apol. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY First pass. TEST PLAN make && ctest REPOSITORY R241 KIO BRANCH l-qregularexpression (branched from

D26226: [KListOpenFilesJob] Use QString::splitRef()

ahmadsamir updated this revision to Diff 72207. ahmadsamir added a comment. Make it const... :/ REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26226?vs=72206=72207 BRANCH l-splitref (branched from master) REVISION DETAIL

D26226: [KListOpenFilesJob] Use QString::splitRef()

ahmadsamir added a comment. One more thing, since this is `lsof -t` it's only 52 entries on my system (not +10 of `lsof`), so it's not as big of an optimisation as I first thought (see D26226 for context). REPOSITORY R244 KCoreAddons REVISION

D26226: [KListOpenFilesJob] Use QString::splitRef()

ahmadsamir updated this revision to Diff 72206. ahmadsamir added a comment. Remove the call to std::unique: - It doesn't work like that - it's not needed as `lsof -t` already produces a sorted and unique list of pid's REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE

D26226: [KListOpenFilesJob] Use QString::splitRef()

ahmadsamir planned changes to this revision. ahmadsamir marked an inline comment as done. ahmadsamir added inline comments. INLINE COMMENTS > dfaure wrote in klistopenfilesjob_unix.cpp:71 > This does not work the way you think it does. > > "A call to std::unique is typically followed by a call

D26226: [KListOpenFilesJob] Use QString::splitRef()

ahmadsamir requested review of this revision. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D26226 To: ahmadsamir, #frameworks, mpyne, dfaure, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26226: [KListOpenFilesJob] Use QString::splitRef()

ahmadsamir planned changes to this revision. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D26226 To: ahmadsamir, #frameworks, mpyne, dfaure, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26226: [KListOpenFilesJob] Use QString::splitRef()

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, mpyne, dfaure, apol. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY As per apol's suggestion in D26210 , use splitRef(). And Since

D26210: [KCoreAddons] Port QRegExp to QRegularExpression

This revision was automatically updated to reflect the committed changes. Closed by commit R244:9578a7d875f1: [KCoreAddons] Port QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26210?vs=72147=72186

D26210: [KCoreAddons] Port QRegExp to QRegularExpression

ahmadsamir added inline comments. INLINE COMMENTS > apol wrote in klistopenfilesjob_unix.cpp:69 > splitRef? I didn't even know there was a splitRef... It'll have to be something like: QVector pidList = out.splitRef(QRegularExpression(QStringLiteral("\\s+")), QString::SkipEmptyParts); //

D26211: Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 72149. ahmadsamir added a comment. Use capturedRef(), cheaper REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26211?vs=72148=72149 BRANCH l-qregularexpression (branched from master) REVISION DETAIL

D26211: Port QRegExp to QRegularExpression

ahmadsamir created this revision. ahmadsamir added reviewers: cullmann, apol. Herald added a project: Frameworks. ahmadsamir requested review of this revision. TEST PLAN make && ctest REPOSITORY R246 Sonnet BRANCH l-qregularexpression (branched from master) REVISION DETAIL

D26106: Port QRegExp to QRegularExpression

ahmadsamir added a task: T12279: Port frameworks away from QRegExp. REPOSITORY R269 BluezQt REVISION DETAIL https://phabricator.kde.org/D26106 To: ahmadsamir, drosca, #frameworks, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26099: Port QRegExp to QRegularExpression

ahmadsamir added a task: T12279: Port frameworks away from QRegExp. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D26099 To: ahmadsamir, #baloo, meven, bruns, astippich, mlaurent Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson,

D26210: [KCoreAddons] Port QRegExp to QRegularExpression

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, mpyne, dfaure, apol. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY Port QRegExp::exactMatch() by using QRegularExpression::anchoredPattern() to match the entire

D26205: KWallet: Port QRegExp to QRegularExpression

This revision was automatically updated to reflect the committed changes. Closed by commit R311:bb4eed3bfda0: KWallet: Port QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R311 KWallet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26205?vs=72132=72146 REVISION

File missing license header in KCoreAddons

2e6be4ae05. -- Ahmad Samir

D26195: Port QRegExp to QRegularExpression

This revision was automatically updated to reflect the committed changes. Closed by commit R236:84d17cbde725: Port QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26195?vs=72115=72143 REVISION

D26208: [KEmailAddress] Remove redundant bool var

ahmadsamir created this revision. ahmadsamir added a reviewer: dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY It looks like 'bool tooManyAtsFlag' was copied over from isValidAddress() (where it's actually used/useful) to

D26123: Port QRegExp to QRegularExpression

This revision was automatically updated to reflect the committed changes. Closed by commit R270:7310a343212a: Port QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R270 KCodecs CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26123?vs=72139=72141 REVISION DETAIL

D26123: Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 72139. ahmadsamir marked an inline comment as done. ahmadsamir edited the summary of this revision. ahmadsamir added a comment. Fix coding style REPOSITORY R270 KCodecs CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26123?vs=72045=72139

D26177: Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 72138. ahmadsamir edited the summary of this revision. ahmadsamir added a comment. Ver-blinking-batim REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26177?vs=72137=72138 BRANCH l-qregularexpression (branched from

D26177: Port QRegExp to QRegularExpression

ahmadsamir added inline comments. INLINE COMMENTS > dfaure wrote in kconfig_compiler.cpp:646 > I wonder if qMax(path.lastIndexOf('/'), path.lastIndexOf('\\')) wouldn't be > simpler and faster :-) > > But yes you're right, might as well just delete this function. > I bet someone didn't realize,

D26177: Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 72137. ahmadsamir marked an inline comment as done. ahmadsamir added a comment. Remove fileNameOnly() as per discussion in the review REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26177?vs=72049=72137 BRANCH

D26207: Port QRegExp to QRegularExpression

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, mlaurent, apol. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY make && ctest REPOSITORY R306 KParts BRANCH l-qregularexpression (branched from master)

D26205: KWallet: Port QRegExp to QRegularExpression

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, aacid. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY Port QRegExp::exactMatch() with QRegularExpression::anchoredPattern() Port QRegExp::Wildcard with

D26194: Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 72116. ahmadsamir marked an inline comment as done. ahmadsamir added a comment. More const REPOSITORY R308 KRunner CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26194?vs=72113=72116 BRANCH l-qregularexpression (branched from master)

D26195: Port QRegExp to QRegularExpression

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, apol, dfaure, vkrause. Herald added a project: Frameworks. ahmadsamir requested review of this revision. TEST PLAN make && ctest; all unit tests pass except for two tests but the fail on master too. REPOSITORY R236

D26194: Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 72113. ahmadsamir added a comment. use const (QRegularExpressionMatch is an object too) REPOSITORY R308 KRunner CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26194?vs=72112=72113 BRANCH l-qregularexpression (branched from master)

D26194: Port QRegExp to QRegularExpression

ahmadsamir created this revision. ahmadsamir added reviewers: Plasma, davidedmundson, apol. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY One instance of QString::remove(QRegExp... was replaced to use the replace overload that takes a

D26193: KNotifyConfig: port QRegExp to QRegularExpression

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, apol. Herald added a project: Frameworks. ahmadsamir requested review of this revision. TEST PLAN the code compiles... no unit tests. REPOSITORY R305 KNotifyConfig BRANCH master REVISION DETAIL

D26106: Port QRegExp to QRegularExpression

This revision was automatically updated to reflect the committed changes. Closed by commit R269:85774a83b403: Port QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R269 BluezQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26106?vs=72042=72084 REVISION DETAIL

D26136: Port QRegExp to QRegularExpression

ahmadsamir added a comment. In D26136#582140 , @ahmadsamir wrote: > Verbatim, take 2, with Summary: added manually In D26136#582140 , @ahmadsamir wrote: > Verbatim, take 2, with

D26136: Port QRegExp to QRegularExpression

ahmadsamir edited the summary of this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D26136 To: ahmadsamir, #frameworks Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26136: Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 72083. ahmadsamir added a comment. Verbatim, take 2, with Summary: added manually REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26136?vs=72081=72083 BRANCH l-qregularexpression (branched from master)

D26136: Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 72081. ahmadsamir added a comment. Verbatim REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26136?vs=72035=72081 BRANCH l-qregularexpression (branched from master) REVISION DETAIL

D26156: [KDocTools] Port QRegExp to QRegularExpression

This revision was automatically updated to reflect the committed changes. ahmadsamir marked an inline comment as done. Closed by commit R238:36fae9517502: [KDocTools] Port QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE

<    2   3   4   5   6   7   8   9   10   11   >