D27617: [breeze-icons] Add telegram-desktop tray icons

2020-03-18 Thread Alexey Min
alexeymin added a comment. F8182957: изображение.png Without badge... Same problem? I'm using dark plasma theme (but not Breeze-dark specifically, it is Sweet KDE) and normal Breeze for apps REPOSITORY R266 Breeze Icons REVISION DETAIL

D26701: Add KFileCustomDialog constructor with a startDir parameter.

2020-01-15 Thread Alexey Min
alexeymin added inline comments. INLINE COMMENTS > kfilecustomdialog.h:40 > +/** > + * Constructors a custom file dialog > + */ Constructs? > kfilecustomdialog.h:45 > +/** > + * Constructors a custom file dialog > + * @param startDir see the KFileWidget constructor for

D26101: Port away from Qt 5.14 deprecated QList methods

2019-12-19 Thread Alexey Min
alexeymin added a comment. Partially looks similar to what I did in D26069 , although that's not framework REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D26101 To: ahmadsamir, #baloo, meven, bruns, astippich Cc: alexeymin,

Re: plasma-nano and plasma-phone-components are now in kdereview

2019-11-12 Thread Alexey Min
Are there plans to finally fix all those nasty QML errors listed at https://invent.kde.org/kde/plasma-phone-components/issues ? вс, 10 нояб. 2019 г. в 04:07, Albert Astals Cid : > > El divendres, 8 de novembre de 2019, a les 8:09:33 CET, Bhushan Shah va > escriure: > > Hello! > > > >

D24363: Fix several build system errors

2019-10-04 Thread Alexey Min
This revision was automatically updated to reflect the committed changes. Closed by commit R858:731b85008c21: Fix several build system errors (authored by alexeymin). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE

D24363: Fix several build system errors

2019-10-02 Thread Alexey Min
alexeymin marked an inline comment as done. alexeymin added a comment. Right, so I was fooled by having qqc2-desktop-style listed as Tier 1 on our main documentation page https://api.kde.org/frameworks/index.html . If it is really Tier 3, then maybe it does not even make sense to make

D24363: Fix several build system errors

2019-10-02 Thread Alexey Min
alexeymin updated this revision to Diff 67233. alexeymin added a comment. - Bring back missing KF5_DEP_VERSION REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24363?vs=67207=67233 BRANCH alexeymin/fix-cmake-errors REVISION

D24363: Fix several build system errors

2019-10-02 Thread Alexey Min
alexeymin reopened this revision. alexeymin added a comment. Phabricator, you're drunk, it is not pushed to master REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D24363 To: alexeymin, mart, #plasma, dfaure Cc: kde-frameworks-devel,

D24363: Fix several build system errors

2019-10-02 Thread Alexey Min
alexeymin retitled this revision from "Fix several builsystem errors" to "Fix several build system errors". REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D24363 To: alexeymin, mart, #plasma, dfaure Cc: kde-frameworks-devel, plasma-devel,

D24363: Fix several builsystem errors

2019-10-02 Thread Alexey Min
alexeymin edited the summary of this revision. REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D24363 To: alexeymin, mart, #plasma, dfaure Cc: kde-frameworks-devel, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2,

D24363: Fix several builsystem errors

2019-10-02 Thread Alexey Min
alexeymin added reviewers: mart, Plasma, dfaure. alexeymin added a subscriber: kde-frameworks-devel. REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D24363 To: alexeymin, mart, #plasma, dfaure Cc: kde-frameworks-devel, plasma-devel, LeGast00n,

D23707: Fix crash on teardown with Applet's ConfigLoader

2019-09-03 Thread Alexey Min
alexeymin accepted this revision. alexeymin added a comment. This revision is now accepted and ready to land. Indeed, I could reproduce the crash again with `kquitapp5 plasmashell`. I've applied this patch on top of plasma-framework-5.16.4, built, installed, `kquitapp5 plasmashell` no

Re: RFC: Running clang-format across all Plasma (and more?) repos

2019-07-14 Thread Alexey Min
> There's one comment about constructor initialisers, which seems resolvable. If that solvable, then it's great. I'm in favour of this idea, maybe even extend to frameworks repos? > So if there's anything else, then yes, please be more specific. No, so far that was the only problem we've

Re: RFC: Running clang-format across all Plasma (and more?) repos

2019-07-13 Thread Alexey Min
Aren't the problems described in task https://phabricator.kde.org/T11214 specific enough? сб, 13 июл. 2019 г. в 14:18, Vlad Zagorodniy : > Can you be more specific about it? What parts of the kdelibs/Frameworks > coding style can't be implemented/enforced with clang-format? >

D20193: Expose locked keystates on KModifierKeyInfo when on wayland

2019-06-22 Thread Alexey Min
alexeymin added inline comments. INLINE COMMENTS > dfaure wrote in kmodifierkeyinfoprovider.cpp:90 > Calling this an "abuse" is very arguable, see > https://herbsutter.com/2013/08/12/gotw-94-solution-aaa-style-almost-always-auto/ > I'm not aware of a KF5 policy about this, so it's fine as is.

D21604: Fix building with Qt 5.13

2019-06-05 Thread Alexey Min
alexeymin added inline comments. INLINE COMMENTS > regexpcache.cpp:81 > // Combine all suffixes into one large RE: "^.*(foo|bar|baz)$" > -auto suffixMatch = QLatin1String("^.*\\.("); > +QString suffixMatch = QLatin1String("^.*\\.("); > suffixMatch += suffixes.join(QChar('|'));

D21599: Disable valgrind detection when compiling with MSVC

2019-06-05 Thread Alexey Min
alexeymin accepted this revision as: Windows. alexeymin added a comment. This should work. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21599 To: bruns, #baloo, #windows, bcooksley Cc: alexeymin, kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh,

D17718: Use ECMGeneratePkgConfigFile to create the pkgconfig file.

2018-12-21 Thread Alexey Min
alexeymin accepted this revision. alexeymin added a comment. This revision is now accepted and ready to land. I tested this, it indeed fixes 390225 Withoug this patch, generated pkgconfig file was: prefix=/usr exec_prefix=bin libdir=lib/x86_64-linux-gnu includedir=include

D16744: Fix crash if XDG_CACHE_HOME directory is too small or out of space

2018-11-07 Thread Alexey Min
This revision was automatically updated to reflect the committed changes. Closed by commit R244:eb916c305a5c: Fix crash if XDG_CACHE_HOME directory is too small or out of space (authored by alexeymin). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE

D16744: Fix crash if XDG_CACHE_HOME directory is too small or out of space

2018-11-07 Thread Alexey Min
alexeymin added a comment. In D16744#355899 , @cfeck wrote: > Would a switch be more readable? Did you mean a block with `if (result == ENOSPC) {` ? Strictly speaking this whole block is not necessary, but it can provide some useful info

D16744: Fix crash if XDG_CACHE_HOME directory is too small or out of space

2018-11-07 Thread Alexey Min
alexeymin updated this revision to Diff 45077. alexeymin added a comment. - Fix typo "in" -> "on" REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16744?vs=45074=45077 BRANCH bug400610 REVISION DETAIL https://phabricator.kde.org/D16744 AFFECTED

D16744: Fix crash if XDG_CACHE_HOME directory is too small or out of space

2018-11-07 Thread Alexey Min
alexeymin edited the test plan for this revision. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D16744 To: alexeymin, dfaure, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16744: Fix crash if XDG_CACHE_HOME directory is too small or out of space

2018-11-07 Thread Alexey Min
alexeymin added a reviewer: Frameworks. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D16744 To: alexeymin, dfaure, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16744: Fix crash if XDG_CACHE_HOME directory is too small or out of space

2018-11-07 Thread Alexey Min
alexeymin edited the summary of this revision. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D16744 To: alexeymin, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16744: Fix crash if XDG_CACHE_HOME directory is too small or out of space

2018-11-07 Thread Alexey Min
alexeymin edited the test plan for this revision. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D16744 To: alexeymin, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16744: Fix crash if XDG_CACHE_HOME directory is too small or out of space

2018-11-07 Thread Alexey Min
alexeymin edited the test plan for this revision. alexeymin added a reviewer: dfaure. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D16744 To: alexeymin, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16744: Fix crash if XDG_CACHE_HOME directory is too small or out of space

2018-11-07 Thread Alexey Min
alexeymin created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. alexeymin requested review of this revision. REVISION SUMMARY Incorrect checking for error return code of posix_fallocate() causes function to think that all is OK while it is

D15084: Change documentation to reflect the real toolchain CMake name

2018-08-25 Thread Alexey Min
alexeymin accepted this revision. alexeymin added a comment. This revision is now accepted and ready to land. Looks harmless and correct REPOSITORY R240 Extra CMake Modules BRANCH fix_android_toolchain_documentation REVISION DETAIL https://phabricator.kde.org/D15084 To: bport, apol,

D14544: Android: Don't hardcode a random version of the Android SDK

2018-08-02 Thread Alexey Min
alexeymin added a comment. From all of my installed build tools: `19.1.0, 20.0.0, 21.1.2, 22.0.1, 23.0.1, 23.0.2, 23.0.3, 24.0.0, 26.0.1` it selects _default_sdk as `19.1.0`, is it fine?  REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D14544 To: apol,

D14397: Support libcanberra for audio notification

2018-07-27 Thread Alexey Min
alexeymin added a comment. But `Currently, libcanberra is tested on Linux only.`  Plasma-pa and plasma-whatever can use anything and be Linux-centric, KNotifications is a framework, isn't it? ++vote for QtMultimedia option... REPOSITORY R289 KNotifications REVISION DETAIL

D14000: qqc2-desktop-style: basic support for QGuiApplication-based apps (WIP/PoC)

2018-07-16 Thread Alexey Min
alexeymin added a comment. Don't know how much offtopic will be what I'm going to say, but I recently ran into an issue while packaging QQC2 application in flatpak with org.kde.Platform//5.9 runtime. My app was functioning perfectly fine in system, but under flatpak it failed to start with

D13198: Android toolchain: allow to specify extra libs manually

2018-05-31 Thread Alexey Min
This revision was automatically updated to reflect the committed changes. Closed by commit R240:0dc051905ae9: Android toolchain: allow to specify extra libs manually (authored by Alexey Minnekhanov a.minnekha...@omprussia.ru, committed by alexeymin). REPOSITORY R240 Extra CMake Modules

D13198: Android toolchain: allow to specify extra libs manually

2018-05-30 Thread Alexey Min
alexeymin added a comment. http://doc.qt.io/qt-5/deployment-android.html at the bottom of the page there is an example of usage scenario for `qmake` project: > ANDROID_EXTRA_LIBS: A list of external libraries that will be copied into your application's library folder and loaded on

D13198: Android toolchain: allow to specify extra libs manually

2018-05-29 Thread Alexey Min
alexeymin created this revision. alexeymin added a reviewer: apol. Restricted Application added projects: Frameworks, Build System. Restricted Application added a subscriber: kde-buildsystem. alexeymin requested review of this revision. REVISION SUMMARY Add new variable ANDROID_EXTRA_LIBS,

D12389: Filepicker reads thumbs preview from Dolphin settings

2018-04-21 Thread Alexey Min
alexeymin added a comment. Stupid question, what happens if dolphin is not installed? REPOSITORY R241 KIO BRANCH dolphin_thumbs (branched from master) REVISION DETAIL https://phabricator.kde.org/D12389 To: anemeth, #frameworks, #vdg, ngraham, #dolphin Cc: alexeymin, ngraham,

D12145: autotests: Do not use QScopedPointer for plugins

2018-04-12 Thread Alexey Min
alexeymin added a comment. Just curious, why is this needed? To avoid dynamic memory allocations? REPOSITORY R286 KFileMetaData BRANCH plugin-simple (branched from master) REVISION DETAIL https://phabricator.kde.org/D12145 To: michaelh, #baloo, #frameworks, mgallien, bruns Cc:

D12149: Improve grid spacing in icons-on-top mode for open/save dialogs

2018-04-12 Thread Alexey Min
alexeymin added a comment. New version looks much better, no doubt. The only thing you may be asked about here is magical number 120, what is it? Some minimum width for item? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12149 To: ngraham, #frameworks, #vdg, rkflx

D12130: Use the more user-friendly string "File format" in the open/save dialogs

2018-04-12 Thread Alexey Min
alexeymin accepted this revision. alexeymin added a comment. +1, looks better REPOSITORY R241 KIO BRANCH file-format-label (branched from master) REVISION DETAIL https://phabricator.kde.org/D12130 To: ngraham, #frameworks, #vdg, bruns, alexeymin Cc: alexeymin, abetts, bruns,

D11882: extractortest: Use built executable instead of installed

2018-04-04 Thread Alexey Min
alexeymin added a comment. Code looks fine, but I did not test if it actually works. ;) INLINE COMMENTS > filemetadatawidgettest.cpp:58 > +const auto extractorPath = QDir( > QStringLiteral("%1/baloo_filemetadata_temp_extractor").arg(QFINDTESTDATA("../src"))).absolutePath(); > + >

D11882: extractortest: Use built executable instead of installed

2018-04-04 Thread Alexey Min
alexeymin added inline comments. INLINE COMMENTS > filemetadatawidgettest.cpp:60 > +qputenv("PATH", qPrintable(QStringLiteral("%1;%2").arg(np).arg(op))); > +#endif > +const auto extractorPath = QDir( >

D11552: [WIP] Handle CJK characters

2018-03-21 Thread Alexey Min
alexeymin added a comment. Regarding this - `I don't know if it is really chinese look foreign enough to me anyway.` Some lines of text in your test script surely look like Japanese Hiragana to me, especially this one (and tests related to this) echo "otto东到宛平路anna">

D10829: Use DocumentId class

2018-02-25 Thread Alexey Min
alexeymin added a comment. In D10829#213553 , @michaelh wrote: > That's great. Any clues to solve this? > > [ 35%] Building CXX object src/file/extractor/autotests/CMakeFiles/extractorIOTest.dir/__/iohandler.cpp.o > [ 35%] Linking CXX

D10829: Use DocumentId class

2018-02-25 Thread Alexey Min
alexeymin added a comment. To solve this warning you need to fix DocumentId class, add operator<<() for QDebug. In D10826 add: `QDebug operator<<(QDebug stream, const Baloo::DocumentId );` outside of baloo namespace, don't forget to `#include ` in

D10825: Introduce aliases DocId, DeviceId and Inode

2018-02-25 Thread Alexey Min
alexeymin added a comment. This gives a bunch of warnings like src/engine/idutils.h:48:43: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] return *(reinterpret-cast(arr)); Were these before...? REPOSITORY R293

D10823: idutils: Fix typo

2018-02-25 Thread Alexey Min
alexeymin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH typo (branched from flexible-docid) REVISION DETAIL https://phabricator.kde.org/D10823 To: michaelh, adridg, #baloo, #frameworks, alexeymin Cc: alexeymin, ashaposhnikov,

D10823: idutils: Fix typo

2018-02-25 Thread Alexey Min
alexeymin added a comment. Maybe such kinds of changes can be committed without review? ;) REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10823 To: michaelh, adridg, #baloo, #frameworks Cc: alexeymin, ashaposhnikov, michaelh, kmorwinski, spoorun, nicolasfella

D10807: fileindexerconfig: Exclude Vaults by default

2018-02-24 Thread Alexey Min
alexeymin added a comment. Maybe when a new vault is configured, it should add itself to baloo exceptions. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10807 To: michaelh, #baloo, #frameworks, ngraham, #plasma Cc: alexeymin, plasma-devel, ivan, nicolasfella,

D10578: balooctl monitor: Wait for dbus interface

2018-02-17 Thread Alexey Min
alexeymin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH wait-for-dbus (branched from master) REVISION DETAIL https://phabricator.kde.org/D10578 To: michaelh, dfaure, alexeymin Cc: alexeymin, #frameworks, ashaposhnikov, michaelh,

D10578: balooctl monitor: Wait for dbus interface

2018-02-17 Thread Alexey Min
alexeymin added a comment. There is also https://techbase.kde.org/Policies/Frameworks_Coding_Style. Guess I was wrong about `#include`s order, but honestly I've never seen commas at the start of the line. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10578 To:

D10578: balooctl monitor: Wait for dbus interface

2018-02-17 Thread Alexey Min
alexeymin added a comment. Looks almost fine, just fix these: INLINE COMMENTS > monitorcommand.cpp:45 > +, QDBusConnection::sessionBus() > +, this > +); Strange formatting of commas in above 3 lines. It looks OK in constructor, where member initialization may be added

D10578: balooctl monitor: Wait for dbus interface

2018-02-16 Thread Alexey Min
alexeymin added a comment. Can you add simple instructions how to reproduce full testing scenario? INLINE COMMENTS > monitorcommand.cpp:75 > +//TODO: Wait again for dbus interface > +QCoreApplication::instance()->exit(0); > +}); No need to call `instance()`

D10335: balooctl monitor: Exit w/o valid dbus interface

2018-02-06 Thread Alexey Min
alexeymin added a comment. `quit()` and `exit(0)` do the same thing - they all stop event loop, caused by `QCoreApplication::exec()`. And I don't understand how does timer help? What is happening without singleshot timer? INLINE COMMENTS > monitorcommand.cpp:55 > +m_out <<

Re: Adding application to KDE and getting image of current

2018-02-04 Thread Alexey Min
No, this way (with export to Kolourpaint) you have to save edited image to separate file and upload it, for example, to imgur manually. With a seprate edit window in spectacle you can do the changes you need, press apply, return to main window and continue to work from main window. There are

Re: Adding application to KDE and getting image of current

2018-02-03 Thread Alexey Min
What refactoring? Just add a separate window for editiong annotations and a small "Edit" button to the bottom row, that opens this separate window. I had some work in progress in this direction, but currently lacking time to finish it... 2018-02-03 23:15 GMT+03:00 Damir Porobic

D10245: Add more default user locations to Places model/panel

2018-02-03 Thread Alexey Min
alexeymin added a comment. +1 very positive! There should be as many default places as possible, scrollbars are not awful; at least `Desktop`, `Documents`, `Downloads`, `Pictures`, `Music` fit perfectly fine. User can easily remove unneeded entries (it's easier to remove than to add I

D9928: Fix one source of log spam referenced in Bug 388389 (Empty filename passed to function)

2018-01-17 Thread Alexey Min
alexeymin added a comment. There was a similar fix commited somewhere (don't remember, in KIO?) related to QFile in newer Qt complaining about empty filenames passed, so this is probably fine too... REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

Re: Review Request 130239: Exclude kconf_update from catching by uac on Windows

2017-12-26 Thread Alexey Min
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130239/#review103848 --- Ship it! Ship It! - Alexey Min On Сен. 27, 2017, 9:19

D9018: Don't cause circular linking on Windows

2017-11-27 Thread Alexey Min
alexeymin added a comment. So it resulted in something like aspell.dll reuiring aspell.dll? What is the fastest way to test this? REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D9018 To: leinir, #frameworks Cc: alexeymin, apol, #frameworks

D8536: Add more hashing algorithms to KPropertiesDialog

2017-10-28 Thread Alexey Min
alexeymin added a comment. Which repository it is...? For me it looks fine on the latest screenshots, combobox is less convenient. REVISION DETAIL https://phabricator.kde.org/D8536 To: petermajchrak, elvisangelaccio Cc: alexeymin, ngraham, elvisangelaccio, #frameworks

Re: Review Request 130239: Exclude kconf_update from catching by uac on Windows

2017-09-27 Thread Alexey Min
> On Сен. 26, 2017, 6:02 п.п., Albert Astals Cid wrote: > > cmake/modules/Win32Macros.cmake > > Lines 61 (patched) > > > > > > I don't think it makes sense adding a new public-ish macro in 4.14.lots > > Ralf

D7668: Add Tags browser places item to Dolphin and file pickers by default if Baloo is enabled

2017-09-11 Thread Alexey Min
alexeymin added a comment. Maybe https://phabricator.kde.org/D7700 is better? We should choose one here, I guess REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7668 To: ngraham, #frameworks, #dolphin, dfaure, davidedmundson, ltoscano, broulik, elvisangelaccio, aacid,

D1231: Add Remote Access interface to KWayland

2017-08-26 Thread Alexey Min
alexeymin added a comment. In https://phabricator.kde.org/D1231#39191, @Kanedias wrote: > ... > Besides, I didn't find any mentions of multi-screen capabilities in Krfb at all. It currently works like this: > > d->framebufferImage = XGetImage(QX11Info::display(), >

D7478: Escape hyphen in rest.xml regular expressions

2017-08-23 Thread Alexey Min
alexeymin added a comment. Is it a fix for bug https://bugs.kde.org/show_bug.cgi?id=383632 ? REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D7478 To: heikobecker, #framework_syntax_hightlighting, kfunk Cc: alexeymin, #frameworks

Re: Threadweaver compilation failure: Windows

2017-04-21 Thread Alexey Min
GMT+05:00 Alexey Min <alexey@gmail.com>: > Ok, I created "Debug" caft build environment and repeated build with > cmake parameters you asked, and I guess it shows exactly the same > build log with exactly the same error in the end - > https://paste.kde.org/p8wj1dqzf &

Re: Threadweaver compilation failure: Windows

2017-04-21 Thread Alexey Min
Ok, I created "Debug" caft build environment and repeated build with cmake parameters you asked, and I guess it shows exactly the same build log with exactly the same error in the end - https://paste.kde.org/p8wj1dqzf Looks like a problem in STL header with debug iterator? Compiler unable to find

Re: Threadweaver compilation failure: Windows

2017-04-20 Thread Alexey Min
some time to craft debug build of the whole environment, starting with zlib, openssl, dbus, icu, .. ending with qtbase. 2017-04-20 16:03 GMT+05:00 Ben Cooksley <bcooks...@kde.org>: > On Thu, Apr 20, 2017 at 10:54 PM, Alexey Min <alexey@gmail.com> wrote: >> Again, I don't ha

Re: Threadweaver compilation failure: Windows

2017-04-20 Thread Alexey Min
7 at 7:24 PM, Alexey Min <alexey@gmail.com> wrote: >> Built fine for me with "Build Tools for Visual Studio 2017" >> (https://www.visualstudio.com/downloads/ "Other Tools And Frameworks" >> section) which contains only compiler and libs without IDE.

D5516: balooctl, baloosearch, balooshow: Fix order of QCoreApplication object creation

2017-04-19 Thread Alexey Min
alexeymin updated this revision to Diff 13616. alexeymin added a comment. Removed spaces at the beginning of the blank line REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5516?vs=13615=13616 REVISION DETAIL https://phabricator.kde.org/D5516 AFFECTED

D5516: balooctl, baloosearch, balooshow: Fix order of QCoreApplication object creation

2017-04-19 Thread Alexey Min
alexeymin retitled this revision from "balooshow: Fix order of QApplication object creation" to "balooctl, baloosearch, balooshow: Fix order of QCoreApplication object creation". alexeymin edited the summary of this revision. REPOSITORY R293 Baloo REVISION DETAIL

D5516: balooshow: Fix order of QApplication object creation

2017-04-19 Thread Alexey Min
alexeymin updated this revision to Diff 13615. alexeymin added a comment. Fixed this also in balooctl and baloosearch. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5516?vs=13613=13615 REVISION DETAIL https://phabricator.kde.org/D5516 AFFECTED FILES

D5516: balooshow: Fix order of QApplication object creation

2017-04-19 Thread Alexey Min
alexeymin updated this revision to Diff 13613. alexeymin added a comment. Moved QCoreApplication object creation before KAboutData object creation. But, in neighbour directories, src/tools/ baloosearch and balooctl also have this problem then - QCoreApplication object is created right

D5516: balooshow: Fix order of QApplication object creation

2017-04-19 Thread Alexey Min
alexeymin retitled this revision from "Fix order of QApplication object creation" to "balooshow: Fix order of QApplication object creation". alexeymin edited the test plan for this revision. alexeymin added a reviewer: aacid. REPOSITORY R293 Baloo REVISION DETAIL

D5516: Fix order of QApplication object creation

2017-04-19 Thread Alexey Min
alexeymin created this revision. alexeymin added a project: Frameworks. REVISION SUMMARY QCoreApplicaion object should exist at the moment when KAboutData::setApplicationData() is called. BUG: 378539 REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D5516 AFFECTED

Re: Threadweaver compilation failure: Windows

2017-04-19 Thread Alexey Min
Built fine for me with "Build Tools for Visual Studio 2017" (https://www.visualstudio.com/downloads/ "Other Tools And Frameworks" section) which contains only compiler and libs without IDE. I used part of the environment provided by craft, for cmake to able to find ECM (my KDEROOT is E:\KDE, or