Re: Gwenview maintainership

2014-10-15 Thread Aurélien Gâteau
On Tue, Oct 14, 2014, at 22:10, Lukáš Tinkl wrote: Dne 14.10.2014 v 17:51 Aurélien Gâteau napsal(a): For the past few months, I haven't been doing any work on KDE projects, and I don't see this changing for now. It's time for me to step down from the projects I maintain. This includes

Re: Gwenview maintainership

2014-10-15 Thread Aurélien Gâteau
in these details, specially since I was fooling around on a gallery application based on the VDG mockups [1] [1] https://forum.kde.org/viewtopic.php?f=285t=122869 On Wed, Oct 15, 2014 at 8:56 AM, Aurélien Gâteau agat...@kde.org wrote: On Tue, Oct 14, 2014, at 22:10, Lukáš Tinkl wrote: Dne

Gwenview maintainership

2014-10-14 Thread Aurélien Gâteau
For the past few months, I haven't been doing any work on KDE projects, and I don't see this changing for now. It's time for me to step down from the projects I maintain. This includes Gwenview. Awesome David Edmundson did the grunt work of porting it to KDE Frameworks 5 (Thanks again David!), but

Re: Review Request 118514: Add KColumnResizer to KWidgetsAddons

2014-08-05 Thread Aurélien Gâteau
--- Manual test program behaves as expected. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118514: Add KColumnResizer to KWidgetsAddons

2014-08-04 Thread Aurélien Gâteau
On juin 7, 2014, 3:10 après-midi, David Faure wrote: Very nice. The question of why not in Qt hasn't been answered though :) Aurélien Gâteau wrote: If you think this has a chance to get in, I can propose it. Aleix Pol Gonzalez wrote: I think it would be accepted. I'm

Re: Review Request 118879: Revert to old shell script code for parsing rgb.txt

2014-06-24 Thread Aurélien Gâteau
On June 23, 2014, 10:28 a.m., Aurélien Gâteau wrote: Out of curiosity: why is it necessary to skip colors with spaces? Alexander Potashev wrote: I guess it's a heuristic to remove duplicate entries for same {R,G,B}. However, it doesn't work perfectly, e.g. we have two entries navy

Re: Review Request 118639: KCMultiDialog: Fix crash when clicking OK

2014-06-13 Thread Aurélien Gâteau
anymore Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118698: Use correct type for QDBusReply when calling Activate.

2014-06-13 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118698/#review59997 --- Ship it! Ship It! - Aurélien Gâteau On June 12, 2014, 7

Re: Loading Qt 5 translations

2014-06-10 Thread Aurélien Gâteau
On Sun, Jun 8, 2014, at 15:04, Albert Astals Cid wrote: El Dimarts, 27 de maig de 2014, a les 07:08:45, Aurélien Gâteau va escriure: On Mon, May 26, 2014, at 9:41, Alexander Potashev wrote: 2014-05-26 18:17 GMT+04:00 Aurélien Gâteau agat...@kde.org: Not sure where we could put

Re: Review Request 118514: Add KColumnResizer to KWidgetsAddons

2014-06-10 Thread Aurélien Gâteau
generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118514/#review59506 --- On June 5, 2014, 2:38 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail

Review Request 118639: KCMultiDialog: Fix crash when clicking OK

2014-06-10 Thread Aurélien Gâteau
/kcmultidialog.cpp 478c25a Diff: https://git.reviewboard.kde.org/r/118639/diff/ Testing --- Configuring virtual desktops does not crash anymore Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Re: Review Request 118639: KCMultiDialog: Fix crash when clicking OK

2014-06-10 Thread Aurélien Gâteau
*after* the methods connected to the button box signals has executed. Diffs - src/kcmultidialog.h 72e45a5 src/kcmultidialog.cpp 478c25a Diff: https://git.reviewboard.kde.org/r/118639/diff/ Testing --- Configuring virtual desktops does not crash anymore Thanks, Aurélien Gâteau

Re: Review Request 118639: KCMultiDialog: Fix crash when clicking OK

2014-06-10 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118639/#review59723 --- On June 10, 2014, 10:45 p.m., Aurélien Gâteau wrote

Re: Review Request 118566: KAcceleratorManager: ignore Designer text fields

2014-06-06 Thread Aurélien Gâteau
to set the name of a widget would result in '' chars being inserted. Diffs - src/kacceleratormanager.cpp 6d4c0d4 Diff: https://git.reviewboard.kde.org/r/118566/diff/ Testing --- Text fields in designer property editor are now editable as expected. Thanks, Aurélien Gâteau

Re: Review Request 118514: Add KColumnResizer to KWidgetsAddons

2014-06-05 Thread Aurélien Gâteau
/118514/diff/ Testing --- Manual test program behaves as expected. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 118565: Mark kdelibs4support widgets as deprecated

2014-06-05 Thread Aurélien Gâteau
--- Widgets groups are suffixed with (KDE - Deprecated) in the toolbox. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 118566: KAcceleratorManager: ignore Designer text fields

2014-06-05 Thread Aurélien Gâteau
/kacceleratormanager.cpp 6d4c0d4 Diff: https://git.reviewboard.kde.org/r/118566/diff/ Testing --- Text fields in designer property editor are now editable as expected. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks

Re: Review Request 118565: Mark kdelibs4support widgets as deprecated

2014-06-05 Thread Aurélien Gâteau
/kdedeprecated.widgets 79cf726 Diff: https://git.reviewboard.kde.org/r/118565/diff/ Testing --- Widgets groups are suffixed with (KDE - Deprecated) in the toolbox. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks

Re: Is plasma-framework not in tier 3?

2014-06-04 Thread Aurélien Gâteau
On Tue, Jun 3, 2014, at 17:04, Marko Käning wrote: I was wondering why I couldn't find plasma-framework in tier 3 on api.kde.org not below frameworks [1] although it is actually shown as part of tier 3 in the dependency graph in [2] ... The name on the landing page are based on the CMake

Re: Is plasma-framework not in tier 3?

2014-06-04 Thread Aurélien Gâteau
On Wed, Jun 4, 2014, at 1:11, Marko Käning wrote: Hi Aurélien, On 04 Jun 2014, at 09:15 , Aurélien Gâteau agat...@kde.org wrote: The name on the landing page are based on the CMake project name: this cause plasma-framework to be listed as Plasma there. but why does plasma and plasma

Review Request 118514: Add KColumnResizer to KWidgetsAddons

2014-06-04 Thread Aurélien Gâteau
/kcolumnresizertest.cpp PRE-CREATION tests/kcolumnresizertest.ui PRE-CREATION Diff: https://git.reviewboard.kde.org/r/118514/diff/ Testing --- Manual test program behaves as expected. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing

Re: Review Request 118514: Add KColumnResizer to KWidgetsAddons

2014-06-04 Thread Aurélien Gâteau
. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118514: Add KColumnResizer to KWidgetsAddons

2014-06-04 Thread Aurélien Gâteau
, 11:52 a.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118514/ --- (Updated June 4, 2014, 11:52 a.m

Re: Review Request 118514: Add KColumnResizer to KWidgetsAddons

2014-06-04 Thread Aurélien Gâteau
: https://git.reviewboard.kde.org/r/118514/#review59145 --- On June 4, 2014, 11:52 a.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 118514: Add KColumnResizer to KWidgetsAddons

2014-06-04 Thread Aurélien Gâteau
a.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118514/ --- (Updated June 4, 2014, 11:52 a.m

Re: Review Request 118514: Add KColumnResizer to KWidgetsAddons

2014-06-04 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118514/#review59163 --- On June 4, 2014, 11:52 a.m., Aurélien Gâteau wrote

Re: Review Request 118514: Add KColumnResizer to KWidgetsAddons

2014-06-04 Thread Aurélien Gâteau
, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118253: Port KWindowSystem::raiseWindow and ::lowerWindow to XCB

2014-05-28 Thread Aurélien Gâteau
people except you are, I am going to give it a try. Based on reading xcb API doc and checking XCB defines are the same as the XLib defines they replace, and since it still builds, I am going to say ship it. - Aurélien Gâteau On May 22, 2014, 8:56 a.m., Martin Gräßlin wrote

Re: Review Request 118193: Use the macros provided by KDesignerPlugin

2014-05-28 Thread Aurélien Gâteau
that kf5designerplugin_add_plugin() does not exist. If I replace it with kf5designerplugin_add_widget_files() then it says Cannot specify link libraries for target kdedeprecated which is not built by this project. - Aurélien Gâteau On May 18, 2014, 2:13 p.m., Alex Merry wrote

Re: Review Request 118193: Use the macros provided by KDesignerPlugin

2014-05-28 Thread Aurélien Gâteau
On May 28, 2014, 2:23 p.m., Aurélien Gâteau wrote: Does not build here: CMake complains that kf5designerplugin_add_plugin() does not exist. If I replace it with kf5designerplugin_add_widget_files() then it says Cannot specify link libraries for target kdedeprecated which

Re: Review Request 118193: Use the macros provided by KDesignerPlugin

2014-05-28 Thread Aurélien Gâteau
On May 28, 2014, 2:23 p.m., Aurélien Gâteau wrote: Does not build here: CMake complains that kf5designerplugin_add_plugin() does not exist. If I replace it with kf5designerplugin_add_widget_files() then it says Cannot specify link libraries for target kdedeprecated which

Re: Review Request 118264: Switch to PolkitQt5-1

2014-05-28 Thread Aurélien Gâteau
^ compilation terminated. - Aurélien Gâteau On May 22, 2014, 8:01 p.m., Hrvoje Senjan wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118264

Re: Review Request 118193: Use the macros provided by KDesignerPlugin

2014-05-28 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118193/#review58667 --- Ship it! Ship It! - Aurélien Gâteau On May 18, 2014, 2:13

Re: Review Request 118192: Do not set the INSTALL_RPATH_USE_LINK_PATH and INSTALL_RPATH properties

2014-05-28 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118192/#review58666 --- Ship it! Ship It! - Aurélien Gâteau On May 28, 2014, 2:54

Re: Loading Qt 5 translations

2014-05-27 Thread Aurélien Gâteau
On Mon, May 26, 2014, at 9:41, Alexander Potashev wrote: 2014-05-26 18:17 GMT+04:00 Aurélien Gâteau agat...@kde.org: Not sure where we could put this. Frameworks load their translations, I believe it should be up to Qt to load its own translations. The only framework where it could maybe

Re: Loading Qt 5 translations

2014-05-26 Thread Aurélien Gâteau
On Sun, May 25, 2014, at 2:05, Albert Astals Cid wrote: El Dissabte, 17 de maig de 2014, a les 18:21:16, Lasse Liehu va escriure: Hi Translations for frameworks are loaded automatically when they are used, but what about Qt 5 itself? Are those translations loaded and if not, how should

Re: Review Request 118216: Skip non-directory files inside the po/ directory

2014-05-26 Thread Aurélien Gâteau
have a .pot file in there. Added a file to be ignored to the po/ dir of the unit test. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118216: Skip non-directory files inside the po/ directory

2014-05-22 Thread Aurélien Gâteau
/r/118216/#review58198 --- On May 20, 2014, 3:05 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118216

Review Request 118216: Skip non-directory files inside the po/ directory

2014-05-20 Thread Aurélien Gâteau
. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118216: Skip non-directory files inside the po/ directory

2014-05-20 Thread Aurélien Gâteau
--- kwidgetsaddons now build even if I have a .pot file in there. Added a file to be ignored to the po/ dir of the unit test. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman

Re: Review Request 118158: Always set src_dir to a not-empty value ('.')

2014-05-16 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118158/#review58045 --- Ship it! Ship It! - Aurélien Gâteau On May 16, 2014, 1:43

Framework Localization Policy

2014-05-16 Thread Aurélien Gâteau
Hi, Finally took the time to document framework localization. You can find the documentation here: http://community.kde.org/Frameworks/Frameworks_Localization_Policy . Feedback is welcome. Aurélien ___ Kde-frameworks-devel mailing list

Review Request 118127: KDEInstallDirs: fix support for normal variables

2014-05-14 Thread Aurélien Gâteau
not fail anymore. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118127: KDEInstallDirs: fix support for normal variables

2014-05-14 Thread Aurélien Gâteau
://git.reviewboard.kde.org/r/118127/diff/ Testing --- Added test case to reproduce the issue. Does not fail anymore. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Review Request 118114: More complete testing of ECMPoQmTools

2014-05-13 Thread Aurélien Gâteau
://git.reviewboard.kde.org/r/118114/diff/ Testing --- ecm tests still pass. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118114: More complete testing of ECMPoQmTools

2014-05-13 Thread Aurélien Gâteau
-and-install.po PRE-CREATION tests/ECMPoQmToolsTest/test.po 107d1b0 Diff: https://git.reviewboard.kde.org/r/118114/diff/ Testing --- ecm tests still pass. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Removing Sonnet documentation?

2014-05-12 Thread Aurélien Gâteau
Hi, While working on installing translated docbooks in frameworks, I realized Sonnet comes with some documentation, but it is not installed right now because Sonnet is tier 1 and kdoctools is tier 2. That's quite a waste of translator time. We can either turn Sonnet into a tier 3 module, remove

Re: Removing Sonnet documentation?

2014-05-12 Thread Aurélien Gâteau
On Mon, May 12, 2014, at 3:26, Kevin Ottens wrote: Hello, On Monday 12 May 2014 03:15:22 Aurélien Gâteau wrote: We can either turn Sonnet into a tier 3 module, remove the documentation or move it somewhere else. Bumping Sonnet from tier 1 to tier 3 sounds bad to me. Since

Review Request 118096: Remove unbuilt doc

2014-05-12 Thread Aurélien Gâteau
0921d20 Diff: https://git.reviewboard.kde.org/r/118096/diff/ Testing --- Builds and install as before. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks

Re: Removing Sonnet documentation?

2014-05-12 Thread Aurélien Gâteau
On Mon, May 12, 2014, at 6:00, Burkhard Lück wrote: Am Montag, 12. Mai 2014, 05:31:40 schrieb Aurélien Gâteau: On Mon, May 12, 2014, at 3:26, Kevin Ottens wrote: Hello, On Monday 12 May 2014 03:15:22 Aurélien Gâteau wrote: We can either turn Sonnet into a tier 3 module, remove

Re: Review Request 118096: Remove unbuilt doc

2014-05-12 Thread Aurélien Gâteau
. Diffs - docs/index.docbook a7559e7 CMakeLists.txt 69e8fd9 docs/CMakeLists.txt 0921d20 Diff: https://git.reviewboard.kde.org/r/118096/diff/ Testing --- Builds and install as before. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel

Re: Review Request 118004: Fix support for installing files named the same in different directories with kdoctools_install

2014-05-07 Thread Aurélien Gâteau
tests/kdoctools_install-test/po/fr/docs/index.docbook PRE-CREATION tests/kdoctools_install-test/po/fr/docs/man-kjscmd.1.docbook PRE-CREATION Diff: https://git.reviewboard.kde.org/r/118004/diff/ Testing --- Tested with supplied test project. Thanks, Aurélien Gâteau

Re: Review Request 117997: Fix processing of multiple .po files with the same name

2014-05-06 Thread Aurélien Gâteau
- cmake/KF5I18NMacros.cmake 4549fb8 Diff: https://git.reviewboard.kde.org/r/117997/diff/ Testing --- Copied two .po files from l10n-kf5 in kconfigwidgets. Built and installed as expected. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel

Re: Review Request 118004: Fix support for installing files named the same in different directories with kdoctools_install

2014-05-06 Thread Aurélien Gâteau
project. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118004: Fix support for installing files named the same in different directories with kdoctools_install

2014-05-06 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118004/#review57363 --- On May 6, 2014, 10:56 a.m., Aurélien Gâteau wrote: --- This is an automatically

Re: Review Request 118004: Fix support for installing files named the same in different directories with kdoctools_install

2014-05-06 Thread Aurélien Gâteau
://git.reviewboard.kde.org/r/118004/#review57363 --- On May 6, 2014, 10:56 a.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r

Re: Review Request 118004: Fix support for installing files named the same in different directories with kdoctools_install

2014-05-06 Thread Aurélien Gâteau
/kdoctools_install-test/po/fr/docs/index.docbook PRE-CREATION tests/kdoctools_install-test/po/fr/docs/man-kjscmd.1.docbook PRE-CREATION Diff: https://git.reviewboard.kde.org/r/118004/diff/ Testing --- Tested with supplied test project. Thanks, Aurélien Gâteau

Re: Review Request 118004: Fix support for installing files named the same in different directories with kdoctools_install

2014-05-06 Thread Aurélien Gâteau
: the KDOCTOOLS_ENABLE_HTMLHANDBOOK block. What should be done with it? The option is not documented: is it obsolete? If I understand it correctly, the code generates .html files in the source directory, and does not install them. Is this the intended behavior? - Aurélien Gâteau On May 6, 2014, 10:59 a.m., Aurélien

Re: Review Request 117823: Add ecm_install_po_files_as_qm() function

2014-05-05 Thread Aurélien Gâteau
On May 4, 2014, 10 p.m., Commit Hook wrote: This review has been submitted with commit 73992f139276b75aeddf78f476644a2d82f9e802 by Alex Merry on behalf of Aurélien Gâteau to branch master. Thanks for committing. Note that I do intend to improve the unit tests, was just busy with other

Review Request 117997: Fix processing of multiple .po files with the same name

2014-05-05 Thread Aurélien Gâteau
/ Testing --- Copied two .po files from l10n-kf5 in kconfigwidgets. Built and installed as expected. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks

Review Request 118004: Fix support for installing files named the same in different directories with kdoctools_install

2014-05-05 Thread Aurélien Gâteau
tests/kdoctools_install-test/po/fr/docs/man-kjscmd.1.docbook PRE-CREATION Diff: https://git.reviewboard.kde.org/r/118004/diff/ Testing --- Tested with supplied test project. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde

Re: Review Request 117823: Add ecm_install_po_files_as_qm() function

2014-05-04 Thread Aurélien Gâteau
. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117823: Add ecm_install_po_files_as_qm() function

2014-05-02 Thread Aurélien Gâteau
ecm_install_po_files_as_qm(). Works as expected. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117823: Add ecm_install_po_files_as_qm() function

2014-05-02 Thread Aurélien Gâteau
(). Works as expected. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117805: Introduce kdoctools_install()

2014-05-02 Thread Aurélien Gâteau
of a released tarball by creating/copying a po/ directory in their working copy. Diffs - KF5DocToolsMacros.cmake c4e33bd Diff: https://git.reviewboard.kde.org/r/117805/diff/ Testing --- Tested with fake content on kiconthemes, with and without the po dir. Thanks, Aurélien Gâteau

Re: Review Request 117858: don't install unused kconfig update files, clashes with kdelibs4 and unused as KF5 starts from a fresh config

2014-04-30 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117858/#review56955 --- Ship it! Ship It! - Aurélien Gâteau On April 29, 2014, 1

Re: Review Request 117895: rename kdebugdialog5 internally and move documentation for co-installability

2014-04-30 Thread Aurélien Gâteau
instead of kdebudialog. It also seems to me that src/kdebugdialog/main.cpp needs to be changed to pass kdebugdialog5 to K4AboutData, otherwise khelpcenter will try to load the old doc. - Aurélien Gâteau On April 30, 2014, 12:39 p.m., Jonathan Riddell wrote

Re: Review Request 117895: rename kdebugdialog5 internally and move documentation for co-installability

2014-04-30 Thread Aurélien Gâteau
: https://git.reviewboard.kde.org/r/117895/ --- (Updated April 30, 2014, 12:39 p.m.) Review request for KDE Frameworks and Aurélien Gâteau. Repository: kdelibs4support Description --- rename kdebugdialog5 internally

Re: Review Request 117895: rename kdebugdialog5 internally and move documentation for co-installability

2014-04-30 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117895/#review56977 --- Ship it! Ship It! - Aurélien Gâteau On April 30, 2014, 1

Re: Review Request 117805: Introduce kdoctools_install()

2014-04-30 Thread Aurélien Gâteau
--- Tested with fake content on kiconthemes, with and without the po dir. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117805: Introduce kdoctools_install()

2014-04-30 Thread Aurélien Gâteau
--- On April 30, 2014, 2:33 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117805

Re: Review Request 117805: Introduce kdoctools_install()

2014-04-30 Thread Aurélien Gâteau
--- On April 30, 2014, 2:33 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117805

Re: Review Request 117805: Introduce kdoctools_install()

2014-04-30 Thread Aurélien Gâteau
by creating/copying a po/ directory in their working copy. Diffs (updated) - KF5DocToolsMacros.cmake c4e33bd Diff: https://git.reviewboard.kde.org/r/117805/diff/ Testing --- Tested with fake content on kiconthemes, with and without the po dir. Thanks, Aurélien Gâteau

Re: Review Request 117823: Add ecm_install_po_files_as_qm() function

2014-04-30 Thread Aurélien Gâteau
On None, Aurélien Gâteau wrote: (commenting my own RR to split the discussion from the description) I expect this function to become the most used one from this CMake module (together with ecm_create_qm_loader()) and the ecm_create_qm_from_po_files() to be less relevant. It is odd

Re: Review Request 117823: Add ecm_install_po_files_as_qm() function

2014-04-30 Thread Aurélien Gâteau
/ECMPoQmToolsTest/po/fr/install-test.po PRE-CREATION tests/ECMPoQmToolsTest/test.po PRE-CREATION Diff: https://git.reviewboard.kde.org/r/117823/diff/ Testing --- Modified kbookmarks to call ecm_install_po_files_as_qm(). Works as expected. Thanks, Aurélien Gâteau

Re: Review Request 117804: Introduce ki18n_install and refresh ki18n_install_ts_files

2014-04-29 Thread Aurélien Gâteau
/ directory. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117805: Introduce kdoctools_install()

2014-04-28 Thread Aurélien Gâteau
. To reply, visit: https://git.reviewboard.kde.org/r/117805/#review56700 --- On April 27, 2014, 8:50 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply

Review Request 117823: Add ecm_install_po_files_as_qm() function

2014-04-28 Thread Aurélien Gâteau
/r/117823/diff/ Testing --- Modified kbookmarks to call ecm_install_po_files_as_qm(). Works as expected. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Re: Review Request 117688: Do not skip a language if there is no application catalog for it

2014-04-27 Thread Aurélien Gâteau
for it. - Ran kicondialogtest: with the patch the dialog is translated, without the patch it is not. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117795: Adapt to yaml file renaming ($framework.yaml = metainfo.yaml)

2014-04-27 Thread Aurélien Gâteau
and Aurélien Gâteau. Repository: kapidox Description --- The dependency diagram code used to extract the framework name from the name of the yaml file, but that is not possible anymore. We can't use the name of the directory containing the code because build.kde.org stores the framework

Re: Review Request 117795: Adapt to yaml file renaming ($framework.yaml = metainfo.yaml)

2014-04-27 Thread Aurélien Gâteau
marked as submitted. Review request for KDE Frameworks and Aurélien Gâteau. Repository: kapidox Description --- The dependency diagram code used to extract the framework name from the name of the yaml file, but that is not possible anymore. We can't use the name of the directory

Review Request 117804: Introduce ki18n_install and refresh ki18n_install_ts_files

2014-04-27 Thread Aurélien Gâteau
. Diffs - cmake/KF5I18NMacros.cmake 2fe800b Diff: https://git.reviewboard.kde.org/r/117804/diff/ Testing --- Applied the changes locally to KIconThemes, tested with and without the po/ directory. Thanks, Aurélien Gâteau ___ Kde

Review Request 117805: Introduce kdoctools_install()

2014-04-27 Thread Aurélien Gâteau
- KF5DocToolsMacros.cmake c4e33bd Diff: https://git.reviewboard.kde.org/r/117805/diff/ Testing --- Tested with fake content on kiconthemes, with and without the po dir. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde

Re: Update your copy of extra-cmake-modules

2014-04-26 Thread Aurélien Gâteau
Alex Merry wrote: On 21/04/14 16:26, šumski wrote: On Friday 18 of April 2014 10:37:50 Aurélien Gâteau wrote: ... I made it that way intentionally because I consider it bad to have different code generated depending on whether you have the framework is built from a release tarball or from

Review Request 117795: Adapt to yaml file renaming ($framework.yaml = metainfo.yaml)

2014-04-26 Thread Aurélien Gâteau
the frameworks. - Ran kgenapidox on one framework. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117629: ECMCreateQmFromPoFiles: Plural form support

2014-04-22 Thread Aurélien Gâteau
created a tool to test plural support. It is available from this repository: g...@git.kde.org:scratch/gateau/qmpluraltest . Instructions to test are in the README.md. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel

Review Request 117688: Do not skip a language if there is no application catalog for it

2014-04-22 Thread Aurélien Gâteau
it is not. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117688: Do not skip a language if there is no application catalog for it

2014-04-22 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117688/#review56183 --- On April 22, 2014, 3:39 p.m., Aurélien Gâteau wrote: --- This is an automatically

Re: Update your copy of extra-cmake-modules

2014-04-18 Thread Aurélien Gâteau
šumski wrote: On Wednesday 16 of April 2014 07:36:57 Aurélien Gâteau wrote: Hi, I just pushed some changes to frameworks using Qt for translations which requires a recent version of extra-cmake-modules (you need to have 071581a3f899c881c9938efd082fd32589822b45). If you get build failures

Review Request 117629: ECMCreateQmFromPoFiles: Plural form support

2014-04-18 Thread Aurélien Gâteau
...@git.kde.org:scratch/gateau/qmpluraltest . Instructions to test are in the README.md. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117560: ECMCreateQmFromPoFiles: adjust API to make it usable from within trunk/l10n-kf5

2014-04-16 Thread Aurélien Gâteau
/ECMCreateQmFromPoFiles.cmake 92d0d1a modules/ECMQmLoader.cpp.in 4fd9c11 Diff: https://git.reviewboard.kde.org/r/117560/diff/ Testing --- Built translations for KF5 from within frameworks source and from a patched l10n-kf5. Thanks, Aurélien Gâteau

Review Request 117560: ECMCreateQmFromPoFiles: adjust API to make it usable from within trunk-kf5

2014-04-14 Thread Aurélien Gâteau
://git.reviewboard.kde.org/r/117560/diff/ Testing --- Built translations for KF5 from within frameworks source and from a patched l10n-kf5. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org

Re: kcoreaddons: is src/mimetypes/kde.xml still in use?

2014-04-11 Thread Aurélien Gâteau
On Thu, Apr 10, 2014, at 8:43, Burkhard Lück wrote: Am Donnerstag, 10. April 2014, 08:28:51 schrieb Aurélien Gâteau: On Thu, Apr 10, 2014, at 6:36, Burkhard Lück wrote: Am Donnerstag, 10. April 2014, 00:25:21 schrieb Aurélien Gâteau: On Wed, Apr 9, 2014, at 9:57, Burkhard Lück wrote

Re: Kioslave repos

2014-04-11 Thread Aurélien Gâteau
The problem is manpower, we do not have the manpwoer to maintain half o the things we have in the workspace, most of the things in there are half-cooked or they do not even work (kglobalaccel kcm) and instead of taking a breath and decide what we want and what we do not want (like we

Re: Postfixing .po that come from Qt::tr() with a _qt.po

2014-04-11 Thread Aurélien Gâteau
On Thu, Apr 10, 2014, at 14:17, Albert Astals Cid wrote: Hi, do you think it makes sense to use that postfix? We are using this currently for stuff like marble and trojita so our translators know they can't use advanced stuff like JS scripting for the translations. What do you think?

Re: Kioslave repos

2014-04-11 Thread Aurélien Gâteau
On Fri, Apr 11, 2014, at 1:51, Àlex Fiestas wrote: On Friday 11 April 2014 01:33:54 Aurélien Gâteau wrote: The problem is manpower, we do not have the manpwoer to maintain half o the things we have in the workspace, most of the things in there are half-cooked or they do not even

Re: How do we want to ship framework translations

2014-04-11 Thread Aurélien Gâteau
On Thu, Apr 10, 2014, at 14:12, Albert Astals Cid wrote: El Dijous, 10 d'abril de 2014, a les 09:06:40, Aurélien Gâteau va escriure: Hi, Until now, kdelibs translations have always been released as part of the kde-l10n-$lang tarballs. I was wondering whether it should still

Re: kcoreaddons: is src/mimetypes/kde.xml still in use?

2014-04-10 Thread Aurélien Gâteau
On Wed, Apr 9, 2014, at 9:57, Burkhard Lück wrote: Am Mittwoch, 9. April 2014, 06:59:08 schrieb Aurélien Gâteau: Hi, I am trying to figure out which code is responsible for loading xml_mimetypes.po. This file is produced by scripty when running on kcoreaddons, but I can't find any code

Re: kcoreaddons: is src/mimetypes/kde.xml still in use?

2014-04-10 Thread Aurélien Gâteau
On Wed, Apr 9, 2014, at 9:57, Burkhard Lück wrote: Am Mittwoch, 9. April 2014, 06:59:08 schrieb Aurélien Gâteau: Hi, I am trying to figure out which code is responsible for loading xml_mimetypes.po. This file is produced by scripty when running on kcoreaddons, but I can't find any code

Re: Writing a Frameworks book at Randa

2014-04-10 Thread Aurélien Gâteau
On Wed, Apr 9, 2014, at 6:05, Kevin Funk wrote: On Wednesday 09 April 2014 02:25:18 Valorie Zimmerman wrote: Hello folks, I know that August is months away, but if you want your Frameworks book, now is the time to step forward. Here are some things to think about: Most of this book

  1   2   3   4   5   6   7   >