D28909: smb: port to Result system to force serialization of error/finish condition

dfaure added inline comments. INLINE COMMENTS > sitter wrote in kio_smb.h:96 > Sure, if you think it's solid enough from an API POV. > > I was thinking that we should amend the slavebase API for KF6 in general. > Instead of having error/finished/opened all functions on an API level should >

D27216: [KProcessRunner] Improve error messages on failure

dfaure added a comment. Done in D29170 . Now we can start discussing the other part of the bug, executable doesn't launch due to missing libs. Ah BTW the unittest leads to "cp" failing because it deletes the temporary dir under cp's feet. This could

D29170: Detect executables without +x permission in $PATH to improve error message

dfaure created this revision. dfaure added a reviewer: ahmadsamir. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY QStandardPaths::findExecutable will not return to us a non-executable binary. So

D29153: Move handling of untrusted programs to ApplicationLauncherJob.

dfaure added inline comments. INLINE COMMENTS > broulik wrote in untrustedprogramhandlerinterface.h:79 > I was wondering if this should be done async? Nested event loops are quite a > problem when QML is involved. I don't see a nested event loop in makeServiceFileExecutable. I guess your

D27216: [KProcessRunner] Improve error messages on failure

dfaure added a comment. Please ignore my previous comment. When launching gwenview by clicking on an image (and not on the gwenview executable itself), we indeed do end up with KProcessRunner failing to find the executable because of the missing -x. I'll implement the proper investigation

D29153: Move handling of untrusted programs to ApplicationLauncherJob.

dfaure updated this revision to Diff 81158. dfaure added a comment. Also set a KIO::JobUiDelegate in KRun itself (which simplifies its code) REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29153?vs=8=81158 BRANCH 2020_04_UntrustedProgramHandler REVISION

D27216: [KProcessRunner] Improve error messages on failure

dfaure added a comment. Note that D29153 affects this since it will detect the lack of +x ahead of time in ApplicationLauncherJob and prompt the user [if the application uses KIOWidgets' JobUiDelegate -- oh I need to do this in KRun, will do right away].

D28765: KSettings::Dialog: add support for KPluginInfos without a KService

dfaure added a comment. Thanks for the review! I was getting desperate to get one ;-) INLINE COMMENTS > svuorela wrote in kcmoduleinfo.cpp:73 > At a later point, I*m not sure what the purpose is for these members are - > but that's probably for another changeset. Right, I was wondering the

D29153: Move handling of untrusted programs to ApplicationLauncherJob.

dfaure added a reviewer: mdlubakowski. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D29153 To: dfaure, ahmadsamir, broulik, ngraham, mdlubakowski Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29153: Move handling of untrusted programs to ApplicationLauncherJob.

dfaure updated this revision to Diff 8. dfaure added a comment. Fix error message box after the user clicks Cancel. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29153?vs=81108=8 BRANCH 2020_04_UntrustedProgramHandler REVISION DETAIL

D29153: Move handling of untrusted programs to ApplicationLauncherJob.

dfaure updated this revision to Diff 81108. dfaure added a comment. improve docu, add test in kruntest REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29153?vs=81101=81108 BRANCH 2020_04_UntrustedProgramHandler REVISION DETAIL

D29153: Move handling of untrusted programs to ApplicationLauncherJob.

dfaure created this revision. dfaure added reviewers: ahmadsamir, broulik, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY This was still in KRun so the porting to ApplicationLauncherJob

D29149: Fix kio-extras compilation with -DQT_NO_CAST_TO_ASCII

dfaure closed this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D29149 To: dfaure, thiago, sitter Cc: meven, kde-frameworks-devel, kfm-devel, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, cblack, fbampaloukas, alexde, Codezela,

D29149: Fix kio-extras compilation with -DQT_NO_CAST_TO_ASCII

dfaure added inline comments. INLINE COMMENTS > CMakeLists.txt:60 > > -add_definitions(-DQT_NO_URL_CAST_FROM_STRING) > +add_definitions(-DQT_NO_URL_CAST_FROM_STRING -DQT_NO_CAST_TO_ASCII) > Isn't that what I did here? Now all of kio-extras gets that flag. And BTW everything built by

D29149: Fix kio-extras compilation with -DQT_NO_CAST_TO_ASCII

dfaure created this revision. dfaure added reviewers: thiago, sitter. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY D27804 broke compilation

D29138: [Solid] Replace foreach (deprecated) with range/index for

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Wow those iterations over map.keys() were awful. REPOSITORY R245 Solid BRANCH l-foreach (branched from master) REVISION DETAIL https://phabricator.kde.org/D29138 To: ahmadsamir,

D29065: [KFontChooser] Add new DisplayFlag; modify how flags are used

dfaure added a comment. I agree, it's now common practice to have a final comma. REPOSITORY R236 KWidgetsAddons BRANCH l-kfontchooser-onlyfixed-display-flag (branched from master) REVISION DETAIL https://phabricator.kde.org/D29065 To: ahmadsamir, #frameworks, dfaure, cfeck, bport Cc:

D29065: [KFontChooser] Add new DisplayFlag; modify how flags are used

dfaure added inline comments. INLINE COMMENTS > kfontchooser.h:87 > +NoDisplayFlags = 0, ///< No flags set > +FixedFontsOnly = 1, ///< Only show fixed fonts, excluding > proportional fonts > +DisplayFrame = 2, ///< Show a visual frame around the chooser

D29065: [KFontChooser] Add new DisplayFlag; modify how flags are used

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R236 KWidgetsAddons BRANCH l-kfontchooser-onlyfixed-display-flag (branched from master) REVISION DETAIL https://phabricator.kde.org/D29065 To: ahmadsamir, #frameworks, dfaure, cfeck, bport Cc:

D29126: KNewStuff: port from KRun::runApplication to KIO::ApplicationLauncherJob

dfaure closed this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D29126 To: dfaure, ngraham, broulik, leinir Cc: leinir, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29126: KNewStuff: port from KRun::runApplication to KIO::ApplicationLauncherJob

dfaure added a comment. And KRun was widgets based too. At least now you can get rid of widgets completely (for this bit about starting apps) by connecting to the result() signal yourself instead of using a dialog ui delegate. There's also a knotifications based ui delegate, but not sure

D29126: KNewStuff: port from KRun::runApplication to KIO::ApplicationLauncherJob

dfaure created this revision. dfaure added reviewers: ngraham, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY The plan is to deprecate KRun::run* TEST PLAN Builds REPOSITORY R304

D29061: [KCharSelect] Minor code optimisation

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R236 KWidgetsAddons BRANCH l-general-code-opti (branched from master) REVISION DETAIL https://phabricator.kde.org/D29061 To: ahmadsamir, #frameworks, cfeck, dfaure Cc: kde-frameworks-devel,

D29017: WIP: Introduce three new methods that return all "entries" in a folder

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kwallet.cpp:219 > +KSecretsService::ReadItemPropertyJob *readLabelJob = > item->label(); > +if (readLabelJob->exec()) { > +

D29065: [KFontChooser] Add a DisplayFlag to allow not showing fixedOnly checkbox

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kfontchooser.h:90 > +ShowDifferences = 4,///< Display the font differences interfaces > +NoFixedOnlyToggle = 5 ///< Show a checkbox to

D29061: [KCharSelect] Minor code optimisation

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kcharselectdata.cpp:870 > +const QRegularExpressionMatch match = hexExp.match(s); > +const QString cap = match.captured(1); > if

D29003: Use Q_EMIT and build with QT_NO_KEYWORDS

dfaure accepted this revision. REPOSITORY R275 KItemModels REVISION DETAIL https://phabricator.kde.org/D29003 To: junghans, kossebau, dfaure, apol Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28919: Drop delayed second phase

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. I trust your analysis ;) REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D28919 To: broulik, #plasma, dfaure, davidedmundson, apol Cc: apol, kde-frameworks-devel,

D28986: API dox: document Q_DECLARE_FLAGS-based flags

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons BRANCH documentFlags REVISION DETAIL https://phabricator.kde.org/D28986 To: kossebau, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28986: API dox: document Q_DECLARE_FLAGS-based flags

dfaure added a comment. Sure. REPOSITORY R244 KCoreAddons BRANCH documentFlags REVISION DETAIL https://phabricator.kde.org/D28986 To: kossebau, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28986: API dox: document Q_DECLARE_FLAGS-based flags

dfaure added inline comments. INLINE COMMENTS > kjob.h:99 > +/** > + * Stores an OR combination of #Capability values. > + */ Inexperienced developers might be confused by the OR in there. In English it sounds like exclusive or, while the whole point of Q_DECLARE_FLAGS is that

D28979: Mark ancient KLibFactory typedef as deprecated

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons BRANCH tagKLibFactorydeprecated REVISION DETAIL https://phabricator.kde.org/D28979 To: kossebau, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham,

D28973: Fix cache directory calculation when adding to trash

dfaure added a comment. Thanks. >0 is already something :-) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28973 To: meven, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28968: [KRichTextEdit] Make sure headings don't mess with undo stack

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Oh I see. Thanks, I didn't know that method. REPOSITORY R310 KTextWidgets BRANCH heading-undo-stack (branched from master) REVISION DETAIL https://phabricator.kde.org/D28968 To:

D28974: [KFontChooser] Make styleIdentifier() more precise by adding font styleName

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. You're like a bugfixing machine, very impressive :-) REPOSITORY R236 KWidgetsAddons BRANCH l-tightenStyleId (branched from master) REVISION DETAIL https://phabricator.kde.org/D28974

D28968: [KRichTextEdit] Make sure headings don't mess with undo stack

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > krichtextedit.cpp:572 > setHeadingLevel(0); > -} > - > -// If a line was merged with previous one, with different heading level, > -//

D28966: [KRichTextEdit] Fix scroll jumping around when horizontal rule is added

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Nice work. REPOSITORY R310 KTextWidgets BRANCH dont-scroll-rule (branched from master) REVISION DETAIL https://phabricator.kde.org/D28966 To: poboiko, #frameworks, dfaure Cc:

D28952: [KNewStuff] Port QRegExp to QRegularExpression

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff BRANCH l-QRE (branched from master) REVISION DETAIL https://phabricator.kde.org/D28952 To: ahmadsamir, #frameworks, dfaure, apol Cc: kde-frameworks-devel, LeGast00n, cblack,

D28973: Fix cache directory calculation when adding to trash

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Good catch. I wonder if the unittest could be extended so it would have caught this. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D28973 To:

D28909: smb: port to Result system to force serialization of error/finish condition

dfaure added inline comments. INLINE COMMENTS > meven wrote in kio_smb.h:96 > KF6 ? > Or once we want to use it in KIO ? Whenever we port a 3rd slave to it ;-) REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D28909 To: sitter, dfaure Cc: meven,

D28880: [KWallet] Port last usage of QRegExp to QRegularExpression

dfaure added a comment. In D28880#651209 , @ahmadsamir wrote: > There are only two places in KDE code where readEntryList() is used, falkon and kwalletmanager; in both cases readEntryList() was used with "*" which means "read all entries",

D28964: [KRichTextWidget] Remove ancient workaround and fix regression (commit 1d1eb6f)

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. In any case it makes sense to remove a workaround for a known-to-be-fixed bug. Good find. REPOSITORY R310 KTextWidgets BRANCH remove-workaround (branched from master) REVISION DETAIL

D28964: [KRichTextWidget] Remove ancient workaround and fix regression (commit 1d1eb6f)

dfaure added a comment. The qt4 task was probably Nokia-internal before the issue tracker was open. But here are more details if you didn't have them: commit 3eb65f48c97dc5e1a8980afa35bea8e4b16f08ba Author: Eskil Abrahamsen Blomfeldt Date: Fri Sep 4 15:05:46 2009 +0200

D6794: assert the testpackage appstream data validates

dfaure added a comment. No, I've seen this error for longer than that. REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D6794 To: sitter, sebas, apol Cc: bcooksley, dfaure, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28947: File protocol: ensure KIO::StatAcl works without implicitely depending on KIO::StatBasic

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH fine-grain-stat REVISION DETAIL https://phabricator.kde.org/D28947 To: meven, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28901: Add KIO::StatRecursiveSize detail value so kio_trash only does this on demand

dfaure closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28901 To: dfaure, meven, ngraham Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28909: smb: port to Result system to force serialization of error/finish condition

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kio_smb.cpp:162 > +{ > +#warning this was finishing before but in sftp and fish we do not finish so > I guess not finishing is the way to go > +

Re: Fwd: KDE CI: Administration » Dependency Build Plasma stable-kf5-qt5 FreeBSDQt5.14 - Build # 7 - Still Failing!

On Saturday, April 18, 2020 5:06:43 PM CEST Friedrich W. H. Kossebau wrote: > Am Samstag, 18. April 2020, 16:26:57 CEST schrieb David Faure: > > On Saturday, April 18, 2020 7:09:25 AM CEST Ben Cooksley wrote: > > > Hi all, > > > > > > Please see below - any i

D28765: KSettings::Dialog: add support for KPluginInfos without a KService

dfaure added a comment. Any idea who could review this? REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D28765 To: dfaure, pino, broulik, mart, davidedmundson, ngraham Cc: cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D28765: KSettings::Dialog: add support for KPluginInfos without a KService

dfaure added a reviewer: ngraham. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D28765 To: dfaure, pino, broulik, mart, davidedmundson, ngraham Cc: cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

Re: Fwd: KDE CI: Administration » Dependency Build Plasma stable-kf5-qt5 FreeBSDQt5.14 - Build # 7 - Still Failing!

y Jazeix in commit 220a959bf150966f807ed. Cheers, David. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

D6794: assert the testpackage appstream data validates

dfaure added a comment. Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks. @sitter the error message in this commit shows up now in CI, can you investigate?

D28020: New class ProcessLauncherJob in KIOGui

dfaure added a comment. > Would it be possible to expose the finished signal of QProcess in KIO::ApplicationLauncherJob? By design the job finishes before the subprocess finishes (which could be in 3 days, if the user keeps the window open that long). Also this would only help you for

D28880: [KWallet] Port last usage of QRegExp to QRegularExpression

dfaure added a comment. Fair point. For searches made by users, that's arguable, but indeed here if it's a search made by C++ code, then we could very well have a readEntryList(QRegularExpression) overload for that use case [or a method with another name, especially if DBus is involved].

D28819: [KRichTextEdit] Always treat key press as single modification in undo stack

dfaure added a comment. The *ideal* way of proceeding is to submit a Qt bug report with your testcase (after searching for an existing Qt bug report for the same issue), then turn it into a Qt autotest and make a gerrit merge request for Qt with both the test and a fix for it. And then, and

D28854: [KRichTextWidget] Add support for headings

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. I see, thanks for the explanations. I don't mind 6 levels if that's what HTML does. REPOSITORY R310 KTextWidgets BRANCH textwidget-heading (branched from master) REVISION DETAIL

D28880: [KWallet] Port last usage of QRegExp to QRegularExpression

dfaure added a comment. A Qt change request for something like QRegularExpression::wildcardToRegularExpression(str, QRegularExpression::AllowSlashes) REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D28880 To: ahmadsamir, #frameworks, dfaure, blaze Cc:

D28880: [KWallet] Port last usage of QRegExp to QRegularExpression

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. This keeps happening so I wonder if we need a QRegularExpression::wildcardToRegularExpression flag... REPOSITORY R311 KWallet BRANCH l-wildcard (branched from master) REVISION DETAIL

D28880: [KWallet] Port last usage of QRegExp to QRegularExpression

dfaure added a comment. And what's the value of `key`? I wonder where/how the use of globbing/regexps comes in... REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D28880 To: ahmadsamir, #frameworks, dfaure, blaze Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh,

D28880: [KWallet] Port last usage of QRegExp to QRegularExpression

dfaure added a comment. Annoying feature of QRegularExpression :( *.txt doesn't seem like a good example for wallet search.. any idea how this code is typically used? REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D28880 To: ahmadsamir, #frameworks, dfaure,

D28647: Fix KIO::Scheduler::emitReparseSlaveConfiguration() to work if called twice in same process

dfaure resigned from this revision. This revision now requires review to proceed. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28647 To: marten, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28647: Fix KIO::Scheduler::emitReparseSlaveConfiguration() to work if called twice in same process

dfaure added a comment. Something like that, but in your pseudo-code I'm missing the call to emit self()->reparseSlaveConfiguration(QString()); "Other slaves" confuses me. This is about broadcasting to "other processes" (applications), and that each process/application (this one,

D28902: CopyJob: when stat'ing the dest, use StatBasic.

dfaure added a comment. In D28902#650160 , @meven wrote: > So the `settings:/` , `remote:/` should return UDS_LOCAL_PATH for KIO::StatBasic, but file:/ should not . That's for sure, it's redundant for kio_file. > The code here uses

D28902: CopyJob: when stat'ing the dest, use StatBasic.

dfaure updated this revision to Diff 80462. dfaure added a comment. update comment REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28902?vs=80338=80462 BRANCH 2020_use_StatDetails REVISION DETAIL https://phabricator.kde.org/D28902 AFFECTED FILES

D28902: CopyJob: when stat'ing the dest, use StatBasic.

dfaure closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28902 To: dfaure, meven Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28221: Don't write default value to configuration file when default value came from /etc/* file

dfaure added a comment. In D28221#643799 , @bport wrote: > In D28221#641971 , @dfaure wrote: > > > I have a hard time accepting that the documentation was wrong -- and if it was, then this commit

D28910: [KFileBookMarkHandler] Port to new KBookmarkMenu-5.69

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Thanks. Well, all of KF5 is supposed to always be the same version. You don't need the ifdef for old kbookmarks version. KIO 5.70 requires KBookmarks 5.70. REPOSITORY R241 KIO

D28901: Add KIO::StatRecursiveSize detail value so kio_trash only does this on demand

dfaure updated this revision to Diff 80428. dfaure added a comment. Remove comment change above StatBasic REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28901?vs=80335=80428 BRANCH 2020_optimize_recursive_size REVISION DETAIL

D28901: Add KIO::StatRecursiveSize detail value so kio_trash only does this on demand

dfaure added inline comments. INLINE COMMENTS > meven wrote in trashimpl.cpp:1105 > Maybe, check for `details & KIO::StatTime` > Down the rabbit hole... Well, if StatRecursiveSize is set, we have the info, so we might as well provide it. If it's not set, then this would mean we need to do the

D28901: Add KIO::StatRecursiveSize detail value so kio_trash only does this on demand

dfaure added inline comments. INLINE COMMENTS > meven wrote in global.h:323 > I don't think we should assume that, it defeats quite the purpose. > For instance even if we the ioslave gets the filename or type for its needs > it may just not include it in the UDSEntry if StatBasic was not

D28902: CopyJob: when stat'ing the dest, use StatBasic.

dfaure created this revision. dfaure added a reviewer: meven. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY However the StatDetail enum doesn't specify which enum value will get us UDS_LOCAL_PATH

D28901: Add KIO::StatRecursiveSize detail value so kio_trash only does this on demand

dfaure created this revision. dfaure added reviewers: meven, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY This indirectly fixes the testtrash unittest which noticed that the directory

D24773: kio_trash: Add size, modification, access and create date for trash:/

dfaure added a comment. Yep, that's it. Renaming trash:/A to trash:/B calls KIO::moveAs which stats trash:/ [useful to resolve desktop:/ to a local dir for instance], which now updates the on-disk cache... with 'A', before it gets renamed to 'B'. I think I know what the best solution

D24773: kio_trash: Add size, modification, access and create date for trash:/

dfaure added inline comments. INLINE COMMENTS > trashimpl.cpp:1092 > +TrashSizeCache trashSize(trashPath); > +TrashSizeCache::SizeAndModTime res = > trashSize.calculateSizeAndLatestModDate(); > +size += res.size; It's actually this call which triggers the unittest

D24773: kio_trash: Add size, modification, access and create date for trash:/

dfaure added a comment. TestTrash::renameDirInTrash makes the dir cache invalid (it still lists trashDirFromHome). I think because of the optimization that we don't always care about the size... but this had the side effect of keeping the cache uptodate I wonder if the test is too

D26034: Replace KLocalSocket with QLocalSocket

dfaure added a comment. It built but apparently the unittests for KIO are disabled on CI :( REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26034 To: nicolasfella, #frameworks, dfaure Cc: cullmann, vonreth, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham,

D28854: [KRichTextWidget] Add support for headings

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > krichtextedit.cpp:346 > +// level=2 look the same > +int sizeAdjustment = boundedLevel > 0 ? 5 - boundedLevel: 0; > + If boundedLevel is 6, the size

D28851: Mark KStatusBarOfflineIndicator as deprecated

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Yeah, it's from before Solid existed... KIO was the only place for this kind of stuff back then. REPOSITORY R241 KIO BRANCH offl REVISION DETAIL https://phabricator.kde.org/D28851

D26034: Replace KLocalSocket with QLocalSocket

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Let's give this a try. In the absence of human testers on Windows, CI will tell us... REPOSITORY R241 KIO BRANCH klocalsocket REVISION DETAIL https://phabricator.kde.org/D26034

D10989: Check for nullptr in indexForNode

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Herald added a subscriber: kde-frameworks-devel. I pushed https://commits.kde.org/kio/d219f304319cb61aa51aae78c46872cbe49f8ff0 instead, you can drop this. REPOSITORY R241 KIO

D5173: Fix 'Installation of ksendbugmail.exe conflicts with related KDE4 package'.

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks. Ben's question was never answered... REPOSITORY R263 KXmlGui REVISION DETAIL

D3548: Add begin/end insert/remove columns to RearrangeColumns

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. This has been fixed with beginResetModel/endResetModel meanwhile, see D27876

D28765: KSettings::Dialog: add support for KPluginInfos without a KService

dfaure added a dependent revision: D28848: Port kontact plugin loading to KPluginLoader. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D28765 To: dfaure, pino, broulik, mart, davidedmundson Cc: cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D24887: WIP slave command behavior assertion system

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. After much delay some replies but there are yet more questions in here INLINE COMMENTS > commands_p.h:27 > { > +#pragma message "this is awkward since this causes

D28765: KSettings::Dialog: add support for KPluginInfos without a KService

dfaure added a comment. For KF6 we could also just replace KCModuleInfo with KPluginInfo. It really doesn't provide anything on top REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D28765 To: dfaure, pino, broulik, mart, davidedmundson Cc: cblack,

D24025: Don't use KCrash on Android

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. see Volker's comment REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24025 To: nicolasfella, dfaure Cc: vkrause, apol, broulik, kde-frameworks-devel,

D19913: [plasma-desktop] make it compiles without foreach

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Looks like this got lost/abandoned? It's painful to review (because it's so long), but it shouldn't be lost work... Can you rebase and see if it still applies? Maybe in the future

D22705: Deprecate KRun::runService

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Should now point to ApplicationLauncherJob. And please consider porting the users, not just deprecating and letting others do the porting. I'm taking care of run() and

D24695: Add a KF6 TODO to make KXMLGUIClient generic over a state enum

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Can go in, but I'd still suggest starting the separate class now. REPOSITORY R263 KXmlGui BRANCH master REVISION DETAIL https://phabricator.kde.org/D24695 To: meven, #frameworks,

D26131: Braces around for, break early.

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. I'd remove the space after '!' and make the bool const, but I'm nitpicking, you can also push as is. cbegin/cend wouldn't change anything on a const container. REPOSITORY R237

D27385: [RFC] Return error instead of aborting when receiving an unexpected answer

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. I don't understand what these "external causes" might be. The bug report doesn't say more other than "happens after a suspend". This needs further debugging IMHO.

D28819: [KRichTextEdit] Always treat key press as single modification in undo stack

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R310 KTextWidgets BRANCH single-undo (branched from master) REVISION DETAIL https://phabricator.kde.org/D28819 To: poboiko, #frameworks, mlaurent, dfaure Cc: ahmadsamir, kde-frameworks-devel,

D28831: Add note about porting loadMimeTypeIcon

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. OK, for the simple case (no overlays, no extraction of path). More complete documentation would include the args for QIcon::pixmap but OK, very often we just port to QIcon instead.

D25443: [chmodjob] Port away from QLinkedList

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. (remember to s/list/stack/ in the commit log) REPOSITORY R241 KIO BRANCH ll REVISION DETAIL https://phabricator.kde.org/D25443 To: nicolasfella, #frameworks, dfaure Cc: dfaure,

D28803: [KDirOperator] Use new "Show/Hide Hidden Files" standard shortcut

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Please land approx 20mn after D28802 to give CI time to update KConfig first ;) (or check when build.kde.org says it got rebuilt) REPOSITORY R241

D28802: Add standard shortcut for "Show/Hide Hidden Files"

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig BRANCH add-show-hide-hidden-files-shortcut (branched from master) REVISION DETAIL https://phabricator.kde.org/D28802 To: ngraham, dfaure, #frameworks Cc: kde-frameworks-devel,

D28800: Always create actioncollection

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Thanks. (but now konqueror creates another one, so the konqueror patch needs to changed to "if exactly 5.69" only, right?) REPOSITORY R294 KBookmarks BRANCH emptycoll REVISION

D24773: kio_trash: Add size, modification, access and create date for trash:/

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH arcpatch-D24773_1 REVISION DETAIL https://phabricator.kde.org/D24773 To: meven, #frameworks, ngraham, elvisangelaccio, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh,

D28793: [KBookMarksMenu] Set objectName for newBookmarkFolderAction

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R294 KBookmarks BRANCH l-new-folder-action (branched from master) REVISION DETAIL https://phabricator.kde.org/D28793 To: ahmadsamir, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack,

D28774: [KFontRequester] Port from QFontDialog to KFontChooserDialog

dfaure added a comment. I mean, the user can press cancel, that's when QColorDialog returns an invalid color. If there was a concept like an invalid font we could do the same here, but there's no such concept in QFont. So yep, no better way. REPOSITORY R236 KWidgetsAddons REVISION

<    1   2   3   4   5   6   7   8   9   10   >