D10747: Implement zwp_linux_dmabuf_v1

fredrik added a comment. In D10747#237235 , @romangg wrote: > Regarding the "drm_fourcc.h" file: do we want to copy it in KWayland's code base or could we use the system one? It's only available on Linux? In this case could we include it as a

D10251: [RFC] Use mipmap filtering in window thumbnails

fredrik updated this revision to Diff 29832. fredrik added a comment. Rebase on master. REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10251?vs=26374=29832 REVISION DETAIL https://phabricator.kde.org/D10251 AFFECTED FILES

D10251: [RFC] Use mipmap filtering in window thumbnails

fredrik added a comment. In D10251#227092 , @broulik wrote: > What's the state of this? Bug 391915 just cropped up There are still some issues with the cubic filter, and I've been distracted by other things lately. I think we should

D10747: Implement zwp_linux_dmabuf_v1

fredrik updated this revision to Diff 28986. fredrik added a comment. Import the context. REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10747?vs=27735=28986 REVISION DETAIL https://phabricator.kde.org/D10747 AFFECTED FILES

D10747: Implement zwp_linux_dmabuf_v1

fredrik added inline comments. Restricted Application edited projects, added Plasma; removed Plasma on Wayland. INLINE COMMENTS > linuxdmabuf_v1_interface.h:39 > + > +namespace LinuxDmabuf > +{ Do we want these nested namespaces? We could have LinuxDmabufFlags, LinuxDmabufBuffer etc. instead.

D10747: Implement zwp_linux_dmabuf_v1

fredrik created this revision. fredrik added reviewers: KWin, Plasma, graesslin, davidedmundson, mart. Restricted Application added projects: Plasma on Wayland, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. fredrik requested review of this revision. Restricted

D10251: [RFC] Use mipmap filtering in window thumbnails

fredrik added a comment. Before and after: F5688790: before-after.png REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10251 To: fredrik, #plasma, #vdg Cc: plasma-devel, #frameworks, michaelh, ZrenBot,

D10251: [RFC] Use mipmap filtering in window thumbnails

fredrik created this revision. fredrik added reviewers: Plasma, VDG. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. fredrik requested review of this revision. REVISION SUMMARY Blit the contents of the window texture

D10173: windowthumbnail: Fix the GLXFBConfig selection code

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R242:46121d58484c: windowthumbnail: Fix the GLXFBConfig selection code (authored by fredrik). REPOSITORY R242 Plasma

D10173: windowthumbnail: Fix the GLXFBConfig selection code

fredrik created this revision. fredrik added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. fredrik requested review of this revision. REVISION SUMMARY Check that the sizes of the color channels

D10090: Downgrade not finding smb.conf from warning to debug

fredrik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D10090 To: aacid, fredrik Cc: #frameworks

Re: Finding contributor email is imposible - was - Re: Phabricator: All repositories registered - upcoming workflow changes

On Monday 06 February 2017, Albert Astals Cid wrote: > El diumenge, 29 de gener de 2017, a les 8:32:21 CET, Ben Cooksley va escriure: > > Hi everyone, > > > > From this point forward, communities should be moving away from > > Reviewboard to Phabricator for conducting code review. Sysadmin will >

[Differential] [Abandoned] D4228: Add an image/ktx mimetype

fredrik abandoned this revision. fredrik added a comment. Closing as the upstream patch has been pushed. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D4228 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: fredrik,

[Differential] [Commented On] D4228: Add an image/ktx mimetype

fredrik added a comment. I've created a bug report in the freedesktop bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99483 I'll leave this revision open until the bug report is closed. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D4228 EMAIL

[Differential] [Commented On] D4228: Add an image/ktx mimetype

fredrik added a comment. In https://phabricator.kde.org/D4228#78967, @ltoscano wrote: > Was the request submitted to shared-mime-info too? It was not. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D4228 EMAIL PREFERENCES

[Differential] [Request, 9 lines] D4228: Add an image/ktx mimetype

fredrik created this revision. fredrik added a reviewer: Frameworks. fredrik set the repository for this revision to R244 KCoreAddons. Restricted Application added a project: Frameworks. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D4228 AFFECTED FILES

Re: Review Request 126131: Don't delete gl texture twice in thumbnail

texture ID's are silently ignored by glDeleteTextures(). That doesn't mean it's a good idea to do it, since a texture ID can be reused for a different texture after it's been passed to glDeleteTextures(). But regardless, it shouldn't crash as long as the textures pointer is valid. - Fredrik

Re: Review Request 121575: FindEpoxy.cmake

On Dec. 18, 2014, 8:47 a.m., Martin Gräßlin wrote: find-modules/Findepoxy.cmake, line 14 https://git.reviewboard.kde.org/r/121575/diff/1/?file=333638#file333638line14 I just need to point out that I consider epoxy as a bad dependency for usage in a cross platform library (like

Re: Review Request 118252: Port KWindowSystem::minimizeWindow and unminizeWindow to XCB

for WM_CHANGE_STATE as the create_atoms() function is not yet ported to xcb. I actually have a port of that function that I forgot to push. I should see if I can find that patch. - Fredrik Höglund On May 22, 2014, 6:53 a.m., Martin Gräßlin wrote

Re: Review Request 115137: Provide information about the active screen in KWindowSystem

On Jan. 20, 2014, 5 p.m., Thomas Lübking wrote: given the ratio by this property is set (often) and read (rarely), i wonder whether we could establish a semi-async functionality, where the client sends a message to have the property updated, then syncs, reads and returns the updated

Re: Review Request 115137: Provide information about the active screen in KWindowSystem

multiple outputs. An output represents a section of the screen geometry that's visible on a monitor. The ID returned by activeScreen() is an output ID. The documentation should explain how the active output relates to the primary output, and how the client is expected to use each. - Fredrik

Re: Review Request 113885: 3 types of blur

://git.reviewboard.kde.org/r/113885/#comment31577 An unfortunate side effect of this is that this API becomes incompatible with the equivalent API on Windows. - Fredrik Höglund On Nov. 15, 2013, 2:54 p.m., Marco Martin wrote

Re: Review Request 112755: Reimplement KXUtils::createPixmapFromHandle with XCB

On Oct. 29, 2013, 2:42 a.m., Fredrik Höglund wrote: Looks much better, but it doesn't handle depth 30 pixmaps. Martin Gräßlin wrote: I'm lacking ideas on how to test this. Do you know any application which uses 30 bit pixmaps? Fredrik Höglund wrote: The default depth is 30

Re: Review Request 112755: Reimplement KXUtils::createPixmapFromHandle with XCB

On Oct. 29, 2013, 2:42 a.m., Fredrik Höglund wrote: Looks much better, but it doesn't handle depth 30 pixmaps. Martin Gräßlin wrote: I'm lacking ideas on how to test this. Do you know any application which uses 30 bit pixmaps? The default depth is 30 when you're using the NVIDIA

Re: Review Request 112755: Reimplement KXUtils::createPixmapFromHandle with XCB

What if the host byte order is not little endian? - Fredrik Höglund On Oct. 24, 2013, 10:22 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112755

Re: Review Request 113415: Port KSplashQML to Qt5 + remove XLib stuff + replace x11eventFilter with DBus interface (Wayland++)

to KSplashX? Let's not forget that the reason KPlash was rewritten to only depend on X + libjpeg + libpng was so that the startup time would be limited by the time it takes to load the images for the theme. - Fredrik Höglund On Oct. 24, 2013, 2:19 p.m., Martin Klapetek wrote

Re: Review Request 113415: Port KSplashQML to Qt5 + remove XLib stuff + replace x11eventFilter with DBus interface (Wayland++)

On Oct. 24, 2013, 4:17 p.m., Fredrik Höglund wrote: What's the cold startup time like for KSplashQML compared to KSplashX? Let's not forget that the reason KPlash was rewritten to only depend on X + libjpeg + libpng was so that the startup time would be limited by the time it takes

Re: Review Request 113415: Port KSplashQML to Qt5 + remove XLib stuff + replace x11eventFilter with DBus interface (Wayland++)

to KSplashX? Let's not forget that the reason KPlash was rewritten to only depend on X + libjpeg + libpng was so that the startup time would be limited by the time it takes to load the images for the theme. - Fredrik Höglund On Oct. 24, 2013, 2:19 p.m., Martin Klapetek wrote

Re: Review Request 113415: Port KSplashQML to Qt5 + remove XLib stuff + replace x11eventFilter with DBus interface (Wayland++)

On Oct. 24, 2013, 4:17 p.m., Fredrik Höglund wrote: What's the cold startup time like for KSplashQML compared to KSplashX? Let's not forget that the reason KPlash was rewritten to only depend on X + libjpeg + libpng was so that the startup time would be limited by the time it takes

Re: Review Request 112896: Rework NETWM classes

On Sept. 26, 2013, 2:27 a.m., Fredrik Höglund wrote: I'm just going to point out something I know you already know since we've discussed it many times; that an xcb port of the NETWM classes already exists in a branch. Martin Gräßlin wrote: my aim was to write the unit test

Re: Review Request 112896: Rework NETWM classes

since we've discussed it many times; that an xcb port of the NETWM classes already exists in a branch. - Fredrik Höglund On Sept. 23, 2013, 1:11 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 112755: Reimplement KXUtils::createPixmapFromHandle with XCB

On Sept. 16, 2013, 12:16 p.m., Fredrik Höglund wrote: tier1/kwindowsystem/src/kxutils_p.h, line 49 http://git.reviewboard.kde.org/r/112755/diff/1/?file=189772#file189772line49 This statement is no longer true. If the pixmap is not an ARGB32 pixmap, the function will crash

Re: Review Request 112755: Reimplement KXUtils::createPixmapFromHandle with XCB

/#comment29676 This statement is no longer true. If the pixmap is not an ARGB32 pixmap, the function will crash. It will also fail if the image byte order doesn't match the CPU byte order, if the mask has the wrong size, or the mask isn't a bitmap. - Fredrik Höglund On Sept. 16, 2013

Re: Review Request 110649: add kimgio WebP image format plugin

should look into using lossless WebP for images in KDE, since WebP has faster decompression than libpng, and produces smaller files. I've done some tests with Oxygen icons that confirms this. - Fredrik Höglund On June 16, 2013, 11:58 a.m., Martin Koller wrote

Re: kxerrorhandler duplicate

On Friday 14 June 2013, Benjamin Port wrote: In the kdeui crumble I'm currently on: KWindowsSystem, there is a task for ./util/kxerrorhandler.h but KWindowsSystem have already one kxerrorhandler. So I don't know what I need to do. The 2 files are really similar only one deprecated constructor

Re: Review Request 110649: add kimgio WebP image format plugin

/#comment24527 This is not particularly efficient. WebPDecodeBGRAInto() can decode directly into a QImage without using an intermediate buffer. - Fredrik Höglund On May 26, 2013, 12:20 p.m., Martin Koller wrote

Re: Review Request 110339: Drop cursor font support and convert KDE Classic into an image-based theme

://git.reviewboard.kde.org/r/110339/#comment23953 This will probably segfault if images is null. kcontrol/input/xcursor/xcursortheme.cpp http://git.reviewboard.kde.org/r/110339/#comment23954 Same issue here. - Fredrik Höglund On May 6, 2013, 8:55 p.m., Eike Hein wrote

Re: Review Request 110339: Drop cursor font support and convert KDE Classic into an image-based theme

LGTM. - Fredrik Höglund On May 6, 2013, 11:04 p.m., Eike Hein wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110339

Re: plasma and new shadow mess

On Monday 07 January 2013, Martin Gräßlin wrote: handing over the pixmap id intenrally to the shadow system is exactly what we do in plasma. granted, it is outside of kwin and we're doing this with an xatom ... but this is precisely how plasma is doing it now: we rely on kwin (or another

Re: Review Request: Fix KSelectionWatcher / KWindowSystem::compositingChanged signal

that the event should be delivered to winId(). KSelectionOwner does not send XFixes events; they are generated by the X server. - Fredrik Höglund On Jan. 5, 2013, 2:38 p.m., Thomas Lübking wrote: --- This is an automatically generated e

Re: Review Request: Fix KWindowSystem::compositingChanged signal

On Jan. 5, 2013, 3:13 p.m., Fredrik Höglund wrote: Because the XFixesSelectSelectionInput() call specifies that the event should be delivered to winId(). KSelectionOwner does not send XFixes events; they are generated by the X server. Thomas Lübking wrote: Ok, problem

Re: Fwd: [kdelibs/frameworks] tier1/kidletime/src: Port the native event filtering to XCB, to fix compilation with Qt5.

On Thursday 26 July 2012, David Faure wrote: On Wednesday 25 July 2012 17:10:57 Fredrik Höglund wrote: They use the freedesktop bugzilla, and there's also an xcb mailinglist there. Actually the bug has been reported to the freedesktop bugzilla 3 years ago... https://bugs.freedesktop.org

Re: xlib plugin is dead (for Qt5)

On Wednesday 28 March 2012, Rick Stockton wrote: In a merge earlier today, Qt-Project removed the xlib support code form Qt5. (I was not the Approver, but I did vote +1 on the change). For X11 environments, xcb will be it's replacement. Wayland is also a primary platform, but IMO not

Porting the NETWM classes to xcb

/kdelibs/fredrik/kdelibs.git netwm-xcb Please review. Fredrik Höglund (32): cmake: Add FindXCB.cmake and FindX11XCB.cmake kdeui: Link to libxcb and libX11-xcb kdeui: Store a pointer to the xcb connection in NETRootInfoPrivate kdeui: Store a pointer to the xcb connection

Re: Porting the NETWM classes to xcb

On Sunday 25 March 2012, Christoph Feck wrote: Is it really required to expose xcb headers to applications, that wish to use the netwm header file? If not, please move to netwm_p.h file. The idea is to eventually replace the Xlib types used in the parameters to the constructors and methods in

Re: Review Request: Make mouse cursor size configurable

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101701/#review4898 --- Lucas, first of all I want to say thank you for working on

Re: Git Worflow, branch creation.

On Tuesday 17 May 2011, Ivan Cukic wrote: On Tuesday, 17. May 2011. 11.42.41 Maksim Orlovich wrote: Testing. If everyone is working on branches on cool new stuff, the release will be crap. I don't agree. Freezes just stop the development - it doesn't improve the bugfixing as much.