Re: Review Request 122493: Use math.h round rather than C++11 std::lround.

2015-02-08 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122493/#review75646 --- `qRound`? - Kevin Funk On Feb. 8, 2015, 11:12 p.m., Jeremy

Re: Build dependency issues with kdesrc-build

2015-02-07 Thread Kevin Funk
On Friday 06 February 2015 19:46:28 Michael Pyne wrote: On Fri, February 6, 2015 15:11:22 Kevin Funk wrote: On Thursday 05 February 2015 22:16:54 Michael Pyne wrote: However as of now it only reorders modules you pull into the build list, so you still need to specify dependencies

Re: Build dependency issues with kdesrc-build

2015-02-06 Thread Kevin Funk
make your own kdesrc-buildrc that does the same thing; you can consider them as maintained sample files. Regards, - Michael Pyne -- Kevin Funk | kf...@kde.org | http://kfunk.org signature.asc Description: This is a digitally signed message part.

Re: Review Request 122359: Create an uninstall target by default in KDE projects.

2015-02-03 Thread Kevin Funk
giving their +1, too modules/ecm_uninstall.cmake.in https://git.reviewboard.kde.org/r/122359/#comment52112 I'd remove the text inside the condition of `elseif`, `endif` and `endforeach` (I know it is copied code, but still ...) - Kevin Funk On Feb. 3, 2015, 8:19 p.m., Alex Merry wrote

Re: make uninstall

2015-01-30 Thread Kevin Funk
, if they don't know they cannot use it and cause harm to their files anyway. Also, the name uninstall indicates it's a destructive operation, so you have been warned. +1 for defining this by default Alex -- Kevin Funk | kf...@kde.org | http://kfunk.org

Re: Review Request 122204: Mark results as required.

2015-01-22 Thread Kevin Funk
On Jan. 22, 2015, 11:11 p.m., Aleix Pol Gonzalez wrote: +1 This change is not source-compatible though... 8-) or is it? Milian Wolff wrote: It's _meant_ to be source-incompatible. All places where it doesn't compile are doing it wrong™. If you mean abi-incompatible,

Re: Review Request 122105: Fix KgDifficulty saving on app close

2015-01-19 Thread Kevin Funk
()` in order to make sure people don't do that? - Kevin Funk On Jan. 17, 2015, 9:48 p.m., Albert Astals Cid wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122105

Review Request 121991: New porting helper: convert-to-cmake-automoc.pl

2015-01-11 Thread Kevin Funk
information inside the documentation of the script Diffs - kf5/convert-to-cmake-automoc.pl PRE-CREATION Diff: https://git.reviewboard.kde.org/r/121991/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks

Re: Review Request 121991: New porting helper: convert-to-cmake-automoc.pl

2015-01-11 Thread Kevin Funk
/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121991: New porting helper: convert-to-cmake-automoc.pl

2015-01-11 Thread Kevin Funk
'#include moc_basename.cpp' as fallback. More information inside the documentation of the script Diffs - kf5/convert-to-cmake-automoc.pl PRE-CREATION Diff: https://git.reviewboard.kde.org/r/121991/diff/ Testing --- Thanks, Kevin Funk

Re: Review Request 121991: New porting helper: convert-to-cmake-automoc.pl

2015-01-11 Thread Kevin Funk
, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121931: Unbreak KRecursiveFilterProxyModel for Qt 5.5.0+.

2015-01-08 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121931/#review73523 --- Ship it! Ship It! - Kevin Funk On Jan. 8, 2015, 6:10 p.m

Re: Some more projects in need of respecting KF5_INSTALL_TARGETS_DEFAULT_ARGS

2015-01-06 Thread Kevin Funk
no LIBRARY DESTINATION for shared library target KF5KMahjongglib. --- ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel -- Kevin Funk | kf...@kde.org | http://kfunk.org

Re: OSX/CI: kde-baseapps fails to build on branch frameworks

2014-12-19 Thread Kevin Funk
/CMakeFiles/kfileitemlistviewtest.dir/kfileitemlistviewte st.cpp.o] Error 1 make[1]: *** [dolphin/src/tests/CMakeFiles/kfileitemlistviewtest.dir/all] Error 2 -- Kevin Funk | kf...@kde.org | http://kfunk.org ___ Kde-frameworks-devel mailing list Kde

Re: AppData/AppStream progress in KDE

2014-12-19 Thread Kevin Funk
to unsubscribe -- Kevin Funk | kf...@kde.org | http://kfunk.org Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe

Re: kubuntu plasma 5 login error

2014-12-18 Thread Kevin Funk
issue with Polkit, it hangs in 'polkit_authority_check_authorization'. Did anyone else see this already and could provide some pointers where to look at? Backtrace attached Greets -- Kevin Funk | kf...@kde.org | http://kfunk.org#0 syscall () at ../sysdeps/unix/sysv/linux/x86_64/syscall.S:38 #1

Re: kubuntu plasma 5 login error

2014-12-18 Thread Kevin Funk
On Thursday 18 December 2014 09:15:14 Kevin Funk wrote: On Thursday 18 December 2014 05:12:10 anu mittal wrote: Okay I will give it a try. Thanks. On Thu, Dec 18, 2014, 6:43 AM Aleix Pol aleix...@kde.org wrote: On Wed, Dec 17, 2014 at 7:35 PM, anu mittal anu22mit...@gmail.com wrote

Re: Announcing heaptrack - a Heap Memory Profiler for Linux

2014-12-10 Thread Kevin Funk
-libraries-i n-cmakelists-txt) Bye Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe -- Kevin Funk | kf...@kde.org | http://kfunk.org Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe

Re: Where are my systray icons cont'd

2014-11-28 Thread Kevin Funk
On Thursday 27 November 2014 21:10:10 Kevin Funk wrote: Heya, I'm still missing my beloved systray icons for a few applications in Plasma 5 on Ubuntu 14.10 (using distro provided packages). I have every package installed according to [1] (sni-qt, libindicator*), but still, systray icons

Re: Review Request 121276: KPluginInfo::category() instead of property(X-KDE-PluginInfo-Category)

2014-11-27 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121276/#review71029 --- Ship it! Ship It! - Kevin Funk On Nov. 27, 2014, 6:07 p.m

Where are my systray icons cont'd

2014-11-27 Thread Kevin Funk
] https://developer.pidgin.im/ticket/16456 -- Kevin Funk | kf...@kde.org | http://kfunk.org ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121172: Move libgit2-related macro defs into config.h

2014-11-24 Thread Kevin Funk
e1c9f34cf24eb516c540db3288c93ad5bd093df3 src/document/katedocument.cpp aac17c719cbabf78c2135062fe566671713cea02 src/utils/kateglobal.cpp 473240514eaeb7f108a5bc0a06e182d4aacc7a80 Diff: https://git.reviewboard.kde.org/r/121172/diff/ Testing --- Thanks, Kevin Funk ___ Kde

Re: Triggering rebuild after changing a *.json file

2014-11-23 Thread Kevin Funk
for providing a kdevplatform_add_plugin macro (awesome!) -- Kevin Funk | kf...@kde.org | http://kfunk.org

Re: Triggering rebuild after changing a *.json file

2014-11-23 Thread Kevin Funk
On Sunday 23 November 2014 23:37:45 Kevin Funk wrote: On Sunday 23 November 2014 17:54:21 Milian Wolff wrote: On Sunday 23 November 2014 10:39:02 Andreas Pakulat wrote: Hi, On Sun, Nov 23, 2014 at 4:36 AM, Milian Wolff m...@milianw.de wrote: Hey all, in my quest

Re: Review Request 121173: Use correct version in kbuildsycoca5 executable

2014-11-19 Thread Kevin Funk
/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 121172: Move libgit2-related macro defs into config.h

2014-11-18 Thread Kevin Funk
/utils/kateglobal.cpp 473240514eaeb7f108a5bc0a06e182d4aacc7a80 Diff: https://git.reviewboard.kde.org/r/121172/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman

Review Request 121173: Use correct version in kbuildsycoca5 executable

2014-11-18 Thread Kevin Funk
--- Use correct version in kbuildsycoca5 executable Diffs - src/kbuildsycoca/kbuildsycoca.cpp 69b142745863218169d7da5a048293d6ab6b1978 Diff: https://git.reviewboard.kde.org/r/121173/diff/ Testing --- Thanks, Kevin Funk ___ Kde

Re: desktoptojson and list properties / i18n of JSON files

2014-11-18 Thread Kevin Funk
, generated from kdevpatchreview.desktop via kcoreaddons_desktop_to_json(...) during the CMake run. Cheers -- Kevin Funk | kf...@kde.org | http://kfunk.org

Review Request 121160: Add libgit2 compile-time check for threads support

2014-11-17 Thread Kevin Funk
://git.reviewboard.kde.org/r/121160/diff/ Testing --- Should fix the CI failure. Compiles fine for me (with threads support) Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks

Re: Review Request 121160: Add libgit2 compile-time check for threads support

2014-11-17 Thread Kevin Funk
src/utils/kateglobal.cpp 6e3362802c213c914430a4775ab15e3515729474 Diff: https://git.reviewboard.kde.org/r/121160/diff/ Testing --- Should fix the CI failure. Compiles fine for me (with threads support) Thanks, Kevin Funk ___ Kde-frameworks

Re: Review Request 121082: Add TODO for private signals in KJob

2014-11-11 Thread Kevin Funk
--- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: How to port KTabBar::mouseMiddleClick?

2014-11-11 Thread Kevin Funk
(); 596-} Worth trying to patch this into QTabBar right away, I think. Cheers -- Kevin Funk | kf...@kde.org | http://kfunk.org ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 121082: Add TODO for private signals in KJob

2014-11-09 Thread Kevin Funk
--- Can't change that now because it would be BIC. Diffs - src/lib/jobs/kjob.h d4b7abd3774626f450aadb4e43185ed5bb654792 Diff: https://git.reviewboard.kde.org/r/121082/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel

Re: Review Request 121007: Fix warning when using newer upower backend.

2014-11-06 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121007/#review69967 --- Ship it! Finally! - Kevin Funk On Nov. 6, 2014, 1:05 a.m

Replacement for KMimeType::isBinaryData?

2014-10-28 Thread Kevin Funk
Heya, I didn't find a suitable replacement for KMimeType::isBinaryData in KF5. Is there some? http://lxr.kde.org/ident?v=kf5-qt5_i=isBinaryData_remember=1 shows exactly two users of this function. Worth considering upstreaming to Qt? -- Kevin Funk | kf...@kde.org | http://kfunk.org

Re: Review Request 120435: Declare InheritanceChecker before actual use

2014-10-11 Thread Kevin Funk
/kpluginfactory.h 70ffade3e071b839245b9b0d6468f7b804478178 Diff: https://git.reviewboard.kde.org/r/120435/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo

Re: Review Request 120435: Declare InheritanceChecker before actual use

2014-10-03 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120435/#review67849 --- Bump. This is a super trivial patch. :) - Kevin Funk

Review Request 120435: Declare InheritanceChecker before actual use

2014-09-30 Thread Kevin Funk
/120435/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: OSX/CI: plasmate fails to build on branch frameworks

2014-09-15 Thread Kevin Funk
-frameworks-devel Note: Plasmate needs to be fixed to work on the current kdevplatform. We've done the invasive KUrl-QUrl port there which of course broke source compatibility. Greets -- Kevin Funk | kf...@kde.org | http://kfunk.org ___ Kde-frameworks

Porting uses of 'accuracy' in KMimeType API

2014-09-12 Thread Kevin Funk
[1] http://api.kde.org/frameworks-api/frameworks5-apidocs/kdelibs4support/html/classKMimeType.html#a3417e83a30cff614a01a29ca2a615443 -- Kevin Funk | kf...@kde.org | http://kfunk.org ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Re: Porting uses of 'accuracy' in KMimeType API

2014-09-12 Thread Kevin Funk
On Friday 12 September 2014 10:50:36 David Faure wrote: On Friday 12 September 2014 09:39:42 Kevin Funk wrote: Heya, Context: Forward-porting some patches in KDevelop involving KMimeType API. I've just noticed that in Qt5, QMimeDataBase/QMimeType doesn't allow me to retrieve

Re: Maintaining KAppTemplate

2014-09-11 Thread Kevin Funk
in KDevelop/KDevplatform, so it'd only make sense to let him take care of kapptemplate a bit. Cheers -- Kevin Funk | kf...@kde.org | http://kfunk.org Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe

Re: kio_trash

2014-08-27 Thread Kevin Funk
slave because it's part of different module) Greets [1] http://build.kde.org/view/kdevelop/job/kdevplatform_frameworks_qt5/154/testReport/(root)/TestSuite/test_kdevgit/ -- Kevin Funk | kf...@kde.org | http://kfunk.org ___ Kde-frameworks-devel mailing

Re: Review Request 119564: Add define to re-enable Qt functionality we depend on.

2014-08-05 Thread Kevin Funk
: agreed. Kevin Funk wrote: Yep. I'm also *strongly* in favor of adjusting the code instead of enabling the define. In fact, I thought I've fixed all of KF5. (It isn't?). There are some compile errors in code *using* KF5, which I'm trying to port ASAP. Axel Rasmussen

Re: Review Request 119152: Do not define QT_DISABLE_DEPRECATED_BEFORE

2014-08-05 Thread Kevin Funk
] Is there any reason for it to be there? Diffs - cmake/modules/ECMQt4To5Porting.cmake 4204fa541790aa38c74b9d6f0b2111af2157b2bc Diff: https://git.reviewboard.kde.org/r/119152/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel

Review Request 119622: Make compile for me

2014-08-05 Thread Kevin Funk
4972a570ca9ef9e8e1d191ffee7f011747adbcf4 Diff: https://git.reviewboard.kde.org/r/119622/diff/ Testing --- Thanks, Kevin Funk Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe

Re: Review Request 119564: Add define to re-enable Qt functionality we depend on.

2014-08-04 Thread Kevin Funk
On Aug. 2, 2014, 9:04 a.m., Alex Merry wrote: I would rather change the code. The Qt behaviour was changed for a reason, to prevent accidental use of dangerous behaviour, and I'm not too keen on undoing that move for all software that uses KDECompilerSettings. Sune Vuorela wrote:

Re: Review Request 119241: Fix QExplicitlySharedDataPointer usage

2014-07-15 Thread Kevin Funk
://git.reviewboard.kde.org/r/119241/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119242: Fix QExplicitlySharedDataPointer usage

2014-07-15 Thread Kevin Funk
-with-qexplicitlyshareddatapointer-ksharedptr-successor/ Diffs - src/widgets/kopenwithdialog.cpp 8cb659fde2028892de82bad64e0ea3ff285b5e3a Diff: https://git.reviewboard.kde.org/r/119242/diff/ Testing --- Thanks, Kevin Funk ___ Kde

Review Request 119241: Fix QExplicitlySharedDataPointer usage

2014-07-12 Thread Kevin Funk
7599c4c73220b2aca366f41ac5cd7d05abfa8afc src/sycoca/ksycocadict.cpp a584f933bff10f44bc257ab996aaee3ad38cc79c tests/ksycocatest.cpp d51d80a691427fa4295dd06802de2fb87112f0ff Diff: https://git.reviewboard.kde.org/r/119241/diff/ Testing --- Thanks, Kevin Funk

Review Request 119242: Fix QExplicitlySharedDataPointer usage

2014-07-12 Thread Kevin Funk
/kopenwithdialog.cpp 8cb659fde2028892de82bad64e0ea3ff285b5e3a Diff: https://git.reviewboard.kde.org/r/119242/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Re: Review Request 119241: Fix QExplicitlySharedDataPointer usage

2014-07-12 Thread Kevin Funk
--- On July 12, 2014, 9:41 a.m., Kevin Funk wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119241/ --- (Updated July

Re: Review Request 119152: Do not define QT_DISABLE_DEPRECATED_BEFORE

2014-07-08 Thread Kevin Funk
(5, 0, 0) (qglobal.h). That means basic functions such as QString::fromAscii are disabled because they're marked as deprecated since 5.0. Question is: Do we really want to override the default value for QT_DISABLE_DEPRECATED_BEFORE? - Kevin Funk On July 6, 2014, 10:17 p.m., Kevin Funk wrote

Review Request 119152: Do not define QT_DISABLE_DEPRECATED_BEFORE

2014-07-06 Thread Kevin Funk
/ECMQt4To5Porting.cmake 4204fa541790aa38c74b9d6f0b2111af2157b2bc Diff: https://git.reviewboard.kde.org/r/119152/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Re: Review Request 118816: Don't crash konsole when a container destructs

2014-06-18 Thread Kevin Funk
=331724. - Kevin Funk On June 18, 2014, 9:51 p.m., Jeremy Whiting wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118816

Review Request 117951: trash: Fix KUrl-QUrl porting bug

2014-05-02 Thread Kevin Funk
91c671332dd9545486c2086944c247e0defe8bba Diff: https://git.reviewboard.kde.org/r/117951/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117952: Fix KIO::suggestName() for the case of leading dots, and no other dot.

2014-05-02 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117952/#review57150 --- Ship it! LGTM - Kevin Funk On May 2, 2014, 4:12 p.m

Re: Review Request 117951: trash: Fix KUrl-QUrl porting bug

2014-05-02 Thread Kevin Funk
--- On May 2, 2014, 4:10 p.m., Kevin Funk wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117951

Re: Review Request 117951: trash: Fix KUrl-QUrl porting bug

2014-05-02 Thread Kevin Funk
411c7913193dbbb527edfe3601b91dd1f7af99e6 trash/trashimpl.cpp 91c671332dd9545486c2086944c247e0defe8bba Diff: https://git.reviewboard.kde.org/r/117951/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks

Re: Hitting assertion in kio-trash (KF5KIOCore)

2014-05-02 Thread Kevin Funk
On Wednesday 16 April 2014 21:31:01 Kevin Funk wrote: Hey, While running unit tests from kdevplatform I hit the following assert in trash/trashimpl.cpp (from workspace/kio-extras) Output of the unit test (which attempts to trash some folders): trying to create /home/krf/.local/share

Re: Review Request 117695: change where dynamic replace tabs is performed

2014-04-23 Thread Kevin Funk
://git.reviewboard.kde.org/r/117695/#comment39333 Early-return? if (!replacetabs) return str; ... - Kevin Funk On April 23, 2014, 8:49 a.m., Sven Brauch wrote: --- This is an automatically generated e-mail. To reply, visit: https

Hitting assertion in kio-trash (KF5KIOCore)

2014-04-16 Thread Kevin Funk
KIO::RenameDialog::suggestName change? Reproducable with: ./plugins/git/tests/kdevgit-test testRemoveEmptyFolder from kdevplatform.git. Greets -- Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman

Re: Writing a Frameworks book at Randa

2014-04-09 Thread Kevin Funk
they're amended alongside of source code changes. Opinions? What do the frameworks devs think about it? Greets [1] http://qt-project.org/doc/qt-5/index.html [2] http://qt-project.org/doc/qt-5/overviews-main.html [3] http://qt-project.org/doc/qt-5/qtexamplesandtutorials.html -- Kevin Funk

Re: Writing a Frameworks book at Randa

2014-04-09 Thread Kevin Funk
On Wednesday 09 April 2014 15:42:47 Aleix Pol wrote: On Wed, Apr 9, 2014 at 3:05 PM, Kevin Funk kf...@kde.org wrote: On Wednesday 09 April 2014 02:25:18 Valorie Zimmerman wrote: Hello folks, I know that August is months away, but if you want your Frameworks book, now is the time to step

Review Request 117017: Remove forward headers for KTextEditor

2014-03-24 Thread Kevin Funk
/includes/KTextEditor/SearchInterface f7dffc91739e82cceffea35de0632cb19e92ab0a src/includes/KTextEditor/Plugin 1016b2e5c5f930afcceb1110b00468ee1158cf7e Diff: https://git.reviewboard.kde.org/r/117017/diff/ Testing --- Thanks, Kevin Funk ___ Kde

Re: Review Request 117017: Remove forward headers for KTextEditor

2014-03-24 Thread Kevin Funk
--- On March 24, 2014, 10:48 a.m., Kevin Funk wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117017/ --- (Updated March

Re: Review Request 117017: Remove forward headers for KTextEditor

2014-03-24 Thread Kevin Funk
/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115351: Use kDebug instead of qDebug in QSpellEnchantDict

2014-03-05 Thread Kevin Funk
. Noone worked on this for years now. Personally I'd just get rid off the debug output, seems like noone cares anyway. (I'm also annoyed by the useless output) - Kevin Funk On Jan. 28, 2014, 1 p.m., Milian Wolff wrote

Re: kdesrc-build: stop after failure? --truly-verbose?

2014-02-28 Thread Kevin Funk
Am Donnerstag, 27. Februar 2014, 21:15:54 schrieb Michael Pyne: On Thu, February 27, 2014 11:35:16 Kevin Funk wrote: Am Mittwoch, 26. Februar 2014, 23:27:08 schrieb Michael Pyne: On Wed, February 26, 2014 22:30:48 Milian Wolff wrote: Also, while at it, could we get a truly verbose flag

Re: kdesrc-build: stop after failure? --truly-verbose?

2014-02-27 Thread Kevin Funk
build kdesrc-build it should install a man page to $KDEDIR/share/man/man1 or thereabouts. I've recently become a big fan of --resume-from (or -after), --stop-before (or -after) and --ignore-modules options myself. And always --pretend. Regards, - Michael Pyne Cheers -- Kevin Funk

Compile errors originating from libKF5XsltKde.a

2014-02-27 Thread Kevin Funk
. Greets -- Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Compile errors originating from libKF5XsltKde.a

2014-02-27 Thread Kevin Funk
Am Donnerstag, 27. Februar 2014, 13:06:38 schrieb Kevin Funk: Hey, I get the following compile errors when compiling anything that depends on libKF5XsltKde.a from kdoctools: When compiling kio: [ 53%] Built target kio_file /home/krf/bin/ld: error: /home/krf/devel/install/kf5/lib/x86_64

Re: Compile errors originating from libKF5XsltKde.a

2014-02-27 Thread Kevin Funk
Am Donnerstag, 27. Februar 2014, 15:24:30 schrieb Kevin Funk: Am Donnerstag, 27. Februar 2014, 13:06:38 schrieb Kevin Funk: Hey, I get the following compile errors when compiling anything that depends on libKF5XsltKde.a from kdoctools: When compiling kio: [ 53%] Built target

Review Request 116124: Always compile static lib with -fPIC

2014-02-27 Thread Kevin Funk
--- Always compile static lib with -fPIC See http://mail.kde.org/pipermail/kde-frameworks-devel/2014-February/012375.html Diffs - src/CMakeLists.txt 0329bd383415b4fa265c1edd7f0f7d384fd17395 Diff: https://git.reviewboard.kde.org/r/116124/diff/ Testing --- Thanks, Kevin Funk

Re: KZoneAllocator static in KCompletion crashes on exit

2014-02-10 Thread Kevin Funk
the allocator (along its provided memory pool) being deleted too early. I also replaced the qDebug usage with printfs because I got similar crashes at shutdown. Greets -- Kevin Funk

Re: KZoneAllocator static in KCompletion crashes on exit

2014-02-10 Thread Kevin Funk
Am Montag, 10. Februar 2014, 20:38:15 schrieb Albert Astals Cid: El Dilluns, 10 de febrer de 2014, a les 12:14:31, Kevin Funk va escriure: Am Montag, 10. Februar 2014, 01:28:03 schrieb Thomas Lübking: On Sonntag, 9. Februar 2014 22:16:16 CEST, Albert Astals Cid wrote: So while exiting

Re: Review Request 115347: Remove Qt5Xml dependency

2014-01-28 Thread Kevin Funk
--- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: add test for QFileDialog::getExistingDirectory / bug?

2014-01-28 Thread Kevin Funk
execute ./qfiledialogtest --staticFunction getExistingDirectory then a dialog opens that lets the user select files but not directories. This seems to be a bug. Greetings Gregor -- Kevin Funk ___ Kde-frameworks-devel mailing list Kde

Review Request 115347: Remove Qt5Xml dependency

2014-01-27 Thread Kevin Funk
--- Remove Qt5Xml dependency Not needed, no? Diffs - CMakeLists.txt 94afe9f5f414a437e519242026ebaf2a838ffc88 Diff: https://git.reviewboard.kde.org/r/115347/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing

Re: Review Request 114715: Attempt to fix KZoneAllocator issue

2014-01-26 Thread Kevin Funk
--- On Jan. 3, 2014, 5:52 p.m., Kevin Funk wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114715

Re: Coding style: block braces in switch cases

2014-01-13 Thread Kevin Funk
into your way when reading or writing code. Your compiler is clever enough to error out when they're missing, and it doesn't harm (semantically) if they're redundant. Any thoughts anyone? Cheers, Kevin Just my two cents. Greets -- Kevin Funk

Re: KTextEditor Frameworks question

2014-01-07 Thread Kevin Funk
IMPORTED) he KF5 suffix should be dropped, no? I'd fix myself but atm I don't know where that magic line is generated from. Cheers -- Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo

Re: KTextEditor Frameworks question

2014-01-07 Thread Kevin Funk
Am Dienstag, 7. Januar 2014, 21:20:40 schrieb Kevin Funk: Am Dienstag, 7. Januar 2014, 19:57:56 schrieb Christoph Cullmann: Hi, I just tried to fix the naming issues. Does that try here look better http://quickgit.kde.org/?p=scratch%2Fcullmann%2Fktexteditor.git If yes, I

Re: KTextEditor Frameworks question

2014-01-06 Thread Kevin Funk
find_package(KF5 ... COMPONENTS TextEditor), then, I suppose. Makes sense? -- Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 114715: Attempt to fix KZoneAllocator issue

2014-01-03 Thread Kevin Funk
/util/kcompletion.cpp 340aa92b900d670e2ad73f70a63d5221d0feed1d kdeui/util/kcompletion_p.h 1cf31db3f16fe3421415cd54265eee20bb998710 Diff: https://git.reviewboard.kde.org/r/114715/diff/ Testing --- Thanks, Kevin Funk

Re: Problem with KCompTreeNode on Windows (or: destruction order of static objects?)

2013-12-12 Thread Kevin Funk
Am Donnerstag, 12. Dezember 2013, 11:27:07 schrieb Frank Reininghaus: Hi, 2013/12/11 Kevin Funk: [...] Just using K_GLOBAL_STATIC for the KZoneAllocator instance doesn't help either. I get the same destruction order + crash with that on Windows. Dynamic allocation

Re: Problem with KCompTreeNode on Windows (or: destruction order of static objects?)

2013-12-11 Thread Kevin Funk
Am Mittwoch, 4. Dezember 2013, 16:36:12 schrieb Milian Wolff: On Wednesday 04 December 2013 16:01:03 Frank Reininghaus wrote: Hi, 2013/11/30 Kevin Funk: Hey guys, My recent attempts to make KDevelop shine on Windows revealed some odd behaviour inside kdelibs. I need

Problem with KCompTreeNode on Windows (or: destruction order of static objects?)

2013-11-30 Thread Kevin Funk
. Any ideas? Greets [1] https://bugs.kde.org/show_bug.cgi?id=243375 (initial bug report) [2] https://bugs.kde.org/show_bug.cgi?id=327599 (contains stack traces) -- Kevin Funk Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe

Re: Review Request 113858: Add .reviewboardrc

2013-11-28 Thread Kevin Funk
marked as submitted. Review request for kdelibs. Repository: kdelibs Description --- Add .reviewboardrc Diffs - .reviewboardrc PRE-CREATION Diff: http://git.reviewboard.kde.org/r/113858/diff/ Testing --- Thanks, Kevin Funk

Re: Review Request 113857: Get rid off ifdefs for windows driver kit

2013-11-19 Thread Kevin Funk
ce6c2c45338edbe470ba8f040dd3a3e829073d9c solid/solid/backends/win/winopticaldrive.cpp fd87eb982a75ff2cff48f9f5ab5e13ac400d9a5e Diff: http://git.reviewboard.kde.org/r/113857/diff/ Testing --- Thanks, Kevin Funk

Review Request 113954: Remove dead code related to kompare support

2013-11-19 Thread Kevin Funk
://git.reviewboard.kde.org/r/113954/diff/ Testing --- Thanks, Kevin Funk

Review Request 113857: Get rid off ifdefs for windows driver kit

2013-11-14 Thread Kevin Funk
fd87eb982a75ff2cff48f9f5ab5e13ac400d9a5e Diff: http://git.reviewboard.kde.org/r/113857/diff/ Testing --- Thanks, Kevin Funk

Review Request 113858: Add .reviewboardrc

2013-11-14 Thread Kevin Funk
--- Add .reviewboardrc Diffs - .reviewboardrc PRE-CREATION Diff: http://git.reviewboard.kde.org/r/113858/diff/ Testing --- Thanks, Kevin Funk

Re: Review Request 106501: Port some uses of KUrl to QUrl

2013-02-07 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106501/#review26876 --- On Sept. 19, 2012, 10:19 p.m., Kevin Funk wrote

Re: Review Request 108770: Fix double-free in ~KCompositeJobPrivate

2013-02-06 Thread Kevin Funk
/108770/diff/ Testing --- Thanks, Kevin Funk

Re: Review Request 108770: Fix double-free in ~KCompositeJobPrivate

2013-02-06 Thread Kevin Funk
--- Thanks, Kevin Funk

Re: Review Request 108770: Fix double-free in ~KCompositeJobPrivate

2013-02-05 Thread Kevin Funk
6ca8eed3ebf8c6f0f5c68d8843bd09a3ea928bbd kdecore/jobs/kcompositejob.cpp 5ddabd71e5bbb5f0a555a201223a52950b85e786 kdecore/jobs/kcompositejob_p.h bef06e9bff532b45a8d66380a65117737275be9e Diff: http://git.reviewboard.kde.org/r/108770/diff/ Testing --- Thanks, Kevin Funk

Re: Review Request 108770: Fix double-free in ~KCompositeJobPrivate

2013-02-05 Thread Kevin Funk
kdecore/tests/kcompositejobtest.h PRE-CREATION kdecore/tests/kcompositejobtest.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/108770/diff/ Testing --- Thanks, Kevin Funk

Review Request 108770: Fix double-free in ~KCompositeJobPrivate

2013-02-04 Thread Kevin Funk
kdecore/jobs/kcompositejob_p.h bef06e9bff532b45a8d66380a65117737275be9e Diff: http://git.reviewboard.kde.org/r/108770/diff/ Testing --- Thanks, Kevin Funk

Re: Review Request: Port some uses of KUrl to QUrl

2012-09-19 Thread Kevin Funk
/krununittest.cpp 314da79b9ee4f95bcc9f768a95810f7de3125ac1 Diff: http://git.reviewboard.kde.org/r/106501/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo

<    1   2   3   4   5   6   7   >