D27848: Remove the tooltip icon

niccolove accepted this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH remove-tooltip-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D27848 To: ngraham, #vdg, #plasma, cblack, niccolove Cc: cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D27695: WIP: Create a new TopArea element using widgets/toparea svg

niccolove added a comment. Two questions: - I know we should not assume it's a Layout, but margins should be defined inside the file as they compensate the inset; is it possible to both define them with Layout and anchors, or something that would work with both? - Is code on line 51

D27695: WIP: Create a new TopArea element using widgets/toparea svg

niccolove updated this revision to Diff 76947. niccolove added a comment. Moved TopArea to PlasmoidHeading and various fixes in it REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27695?vs=76862=76947 BRANCH master REVISION DETAIL

D27807: Changed style of pressed list item to be consistent

niccolove abandoned this revision. niccolove added a comment. Actually, there is a proper way to do this. Gimme a sec. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27807 To: niccolove, #vdg, #plasma Cc: ngraham, plasma-devel, ndavis,

D27695: WIP: Create a new TopArea element using widgets/toparea svg

niccolove marked an inline comment as done. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27695 To: niccolove, mart Cc: davidedmundson, ahiemstra, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27695: WIP: Create a new TopArea element using widgets/toparea svg

niccolove updated this revision to Diff 76862. niccolove added a comment. Replace test with widgets/toparea REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27695?vs=76860=76862 BRANCH master REVISION DETAIL

D27695: WIP: Create a new TopArea element using widgets/toparea svg

niccolove added a comment. In D27695#621305 , @davidedmundson wrote: > PC3 is designed to be only a theme for QQC2 That's why I moved it to plasmaextracomponent with the last commit, actually REPOSITORY R242 Plasma Framework (Library)

D27695: WIP: Create a new TopArea element using widgets/toparea svg

niccolove updated this revision to Diff 76860. niccolove added a comment. Moved the file to Extra components REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27695?vs=76822=76860 BRANCH master REVISION DETAIL

D27807: Changed style of pressed list item to be consistent

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27807 To: niccolove, #vdg, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27807: Changed style of pressed list item to be consistent

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27807 To: niccolove, #vdg, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27807: Changed style of pressed list item to be consistent

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27807 To: niccolove Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27807: Changed style of pressed list item to be consistent

niccolove added reviewers: VDG, Plasma. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27807 To: niccolove, #vdg, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27807: Changed style of pressed list item to be consistent

niccolove created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. niccolove requested review of this revision. REVISION SUMMARY The style of pressed- listitem (which is actually often used for hover as well, while the hover- listitem is never

D27695: WIP: Create a new TopArea element using widgets/toparea svg

niccolove marked an inline comment as done. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27695 To: niccolove, mart Cc: ahiemstra, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27695: WIP: Create a new TopArea element using widgets/toparea svg

niccolove updated this revision to Diff 76822. niccolove added a comment. Width is fill anyway, no need to calculate it REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27695?vs=76572=76822 BRANCH master REVISION DETAIL

D27695: WIP: Create a new TopArea element using widgets/toparea svg

niccolove updated this revision to Diff 76572. niccolove marked an inline comment as done. niccolove added a comment. Fixed margin REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27695?vs=76534=76572 BRANCH master REVISION DETAIL

D27444: Added top area

niccolove updated this revision to Diff 76562. niccolove added a comment. Hardcoded colors REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27444?vs=76378=76562 BRANCH top_area (branched from master) REVISION DETAIL

D27695: WIP: Create a new TopArea element using widgets/toparea svg

niccolove edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27695 To: niccolove, mart Cc: ahiemstra, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27695: WIP: Create a new TopArea element using widgets/toparea svg

niccolove marked an inline comment as done. niccolove added inline comments. INLINE COMMENTS > ahiemstra wrote in TopArea.qml:40 > This conditional is wrong. The syntax is `condition ? true_case : false_case` > so you want to write `flipped ? -topAreaSvg.margins.top : >

D27695: WIP: Create a new TopArea element using widgets/toparea svg

niccolove updated this revision to Diff 76534. niccolove added a comment. Fixed conditionals REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27695?vs=76531=76534 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27695

D27695: WIP: Create a new TopArea element using widgets/toparea svg

niccolove edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27695 To: niccolove, mart Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27695: WIP: Create a new TopArea element using widgets/toparea svg

niccolove updated this revision to Diff 76531. niccolove added a comment. Fixed svg path REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27695?vs=76528=76531 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27695 AFFECTED

D27695: WIP: Create a new TopArea element using widgets/toparea svg

niccolove added a dependent revision: D27189: Created a top area based on widgets/toparea.svg. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27695 To: niccolove, mart Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27695: WIP: Create a new TopArea element using widgets/toparea svg

niccolove updated this revision to Diff 76528. niccolove added a comment. Added licence REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27695?vs=76527=76528 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27695 AFFECTED

D27695: WIP: Create a new TopArea element using widgets/toparea svg

niccolove added a reviewer: mart. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27695 To: niccolove, mart Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27695: WIP: Create a new TopArea element using widgets/toparea svg

niccolove created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. niccolove requested review of this revision. REVISION SUMMARY This creates a new component that uses the widgets/toparea svg. First time I try to add something to

D27444: Added top area

niccolove added a dependent revision: D27695: WIP: Create a new TopArea element using widgets/toparea svg. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27444 To: niccolove, #vdg, ngraham, ndavis Cc: mart, kde-frameworks-devel, LeGast00n, cblack,

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove updated this revision to Diff 76382. niccolove added a comment. re-tweaked commits REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27122?vs=76381=76382 BRANCH contrast_effect_background_color (branched from master) REVISION

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove updated this revision to Diff 76381. niccolove added a comment. Rebase REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27122?vs=76373=76381 BRANCH contrast_effect_background_color (branched from master) REVISION DETAIL

D27444: Added top area

niccolove updated this revision to Diff 76378. niccolove added a comment. Rebase REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27444?vs=76376=76378 BRANCH top_area (branched from master) REVISION DETAIL

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove added a comment. In D27122#617614 , @trmdi wrote: > Hmm, I think you need to rebase to remove unrelated files in this patch e.g. `dropjob.cpp` ... ? Definitively. *sigh* REPOSITORY R242 Plasma Framework (Library) REVISION

D27444: Added top area

niccolove updated this revision to Diff 76376. niccolove added a comment. Added toparea margins REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27444?vs=75824=76376 BRANCH top_area (branched from master) REVISION DETAIL

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove added a comment. I felt that the transparency was not working very well with the headerbar on some wallpapers, so I toned down the transparency a bit, going from F8131395: image.png to F8131397: image.png

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove updated this revision to Diff 76373. niccolove added a comment. Tweaked values REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27122?vs=75787=76373 BRANCH contrast_effect_background_color (branched from master) REVISION

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove added a comment. Couple of screenshots more from this patch: F8115905: Screenshot_20200220_194559.png F8115907: Screenshot_20200220_194611.png F8115910: Screenshot_20200220_194622.png

D27444: Added top area

niccolove added a comment. In D27444#614762 , @mart wrote: > - i would provide one single svg with top and bottom areas so one can use something like that as a footer as well (and probably a frame that has nothing rounded) > - if you have a

D27445: Move tasks from 3px to 2px

niccolove added a comment. With big panels this is not really a problem, but I feel like a 3px lines takes too much space from the icon space, making it a bit cramped. Here's an example of a theme using a 2px line as well (Sweet KDE, the most downloaded Plasma theme): F8108529:

D27444: Added top area

niccolove added a comment. In D27444#612582 , @ngraham wrote: > This will need CMake changes to actually install it. Isn't this automatically done by the glob? FILE(GLOB widgets widgets/*.svg)

D27444: Added top area

niccolove marked an inline comment as done. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27444 To: niccolove, #vdg, ngraham, ndavis Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27444: Added top area

niccolove updated this revision to Diff 75824. niccolove added a comment. Remove hardcoded values REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27444?vs=75796=75824 BRANCH top_area (branched from master) REVISION DETAIL

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove edited the summary of this revision. niccolove added dependencies: D27189: Created a top area based on widgets/toparea.svg, D27439: Replaced isDock check with !hasDecoration. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27122 To:

D27445: Move tasks from 3px to 2px

niccolove requested review of this revision. niccolove added a comment. Nope, that does not work. Let's stick to 2px. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27445 To: niccolove, #vdg Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2,

D27445: Move tasks from 3px to 2px

niccolove planned changes to this revision. niccolove added a comment. I do prefer the 2px version, but I think a compromise would look best. I will try a 2.5px version, although I'm not sure how good .5 pixel are displayed. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D27445: Move tasks from 3px to 2px

niccolove updated this revision to Diff 75798. niccolove added a comment. Used scour REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27445?vs=75797=75798 BRANCH 2px_tasks (branched from master) REVISION DETAIL

D27445: Move tasks from 3px to 2px

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27445 To: niccolove, #vdg Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27445: Move tasks from 3px to 2px

niccolove added a reviewer: VDG. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27445 To: niccolove, #vdg Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27445: Move tasks from 3px to 2px

niccolove edited the summary of this revision. niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27445 To: niccolove Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27445: Move tasks from 3px to 2px

niccolove created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. niccolove requested review of this revision. REVISION SUMMARY *gimme a sec* REPOSITORY R242 Plasma Framework (Library) BRANCH 2px_tasks (branched from master) REVISION

D27444: Added top area

niccolove added a dependent revision: D27189: Created a top area based on widgets/toparea.svg. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27444 To: niccolove, #vdg, ngraham, ndavis Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

D27444: Added top area

niccolove added reviewers: VDG, ngraham, ndavis. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27444 To: niccolove, #vdg, ngraham, ndavis Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27444: Added top area

niccolove created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. niccolove requested review of this revision. REVISION SUMMARY Adds top area for D27189 REPOSITORY R242 Plasma Framework (Library) BRANCH

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove added a comment. Regarding maximized windows: I don't think it's possible to make the dialog and panel feel united in this case; windows has this problem as well: F8107248: image.png I'd say this is the expected behavior for a theme with

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27122 To: niccolove, ndavis, ngraham, cblack Cc: cblack, ndavis, filipf, ngraham, davidedmundson, kde-frameworks-devel, manueljlin, Orage, LeGast00n,

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove updated this revision to Diff 75787. niccolove added a comment. Make the panel always as transparent as the dialogs REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27122?vs=75786=75787 BRANCH contrast_effect_background_color

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove updated this revision to Diff 75786. niccolove added a comment. - Merge branch 'master' into contrast_effect_background_color REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27122?vs=75277=75786 BRANCH

D27354: Remove hardcoded colors

This revision was automatically updated to reflect the committed changes. Closed by commit R242:1ed47e7c4188: Remove hardcoded colors (authored by niccolove). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27354?vs=75572=75629 REVISION

D27354: Remove hardcoded colors

niccolove added a reviewer: ndavis. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27354 To: niccolove, ndavis Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27354: Remove hardcoded colors

niccolove created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. niccolove requested review of this revision. REVISION SUMMARY Fixes https://www.reddit.com/r/kde/comments/f2mxd3/517_seeing_weird_white_corners_on_my_autohiding/

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove added a comment. In D27122#609276 , @ndavis wrote: > I think rather than adjusting hardcoded opacity in the SVGs, we need to make configurable plasmashell opacity a reality. Then, if we want to do an effect like what Nate described,

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove added a comment. - Breeze panel and dialog being different when using a dark theme - Avoiding controls to be used in ViewBackground areas / using Background Breeze color without it looking gray I have no idea how these could be fixed without just using a color file-d theme

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27122 To: niccolove, ndavis, ngraham, cblack Cc: cblack, ndavis, filipf, ngraham, davidedmundson, kde-frameworks-devel, manueljlin, Orage, LeGast00n,

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27122 To: niccolove, ndavis, ngraham, cblack Cc: cblack, ndavis, filipf, ngraham, davidedmundson, kde-frameworks-devel, manueljlin, Orage, LeGast00n,

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove added a comment. In D27122#608324 , @ndavis wrote: > Still uses ViewBackground on panels. For panel popups, you wanted to use a header area like the systray mockups, right? If so, the dialog SVG could use ViewBackground and you should

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27122 To: niccolove, ndavis, ngraham Cc: ndavis, filipf, ngraham, davidedmundson, kde-frameworks-devel, manueljlin, Orage, LeGast00n, The-Feren-OS-Dev,

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove updated this revision to Diff 75277. niccolove added a comment. Changed saturation to 6.0 REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27122?vs=75145=75277 BRANCH contrast_effect_background_color (branched from master)

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove added a comment. In D27122#608074 , @ngraham wrote: > But ultimately, don't let this become design-by-committee. This is your patch, and your proposal. It's good to take into account feedback, but not to the extent that it compromises

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove added a comment. I personally choose 0.4 for opacity, but I was now thinking whether higher or lower values could be better. I took 50 screenshots in different conditions, but since those are a bit difficult to upload to Phab, I also made a website which helps you pick a value:

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove added a comment. In D27122#607167 , @ngraham wrote: > Please add a comment in the Description section of this patch explaining why the previously disabled Intensity value is now enabled. ✓ REPOSITORY R242 Plasma Framework

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27122 To: niccolove, ndavis, ngraham Cc: ndavis, filipf, ngraham, davidedmundson, kde-frameworks-devel, manueljlin, Orage, LeGast00n, The-Feren-OS-Dev,

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27122 To: niccolove, ndavis, ngraham Cc: ndavis, filipf, ngraham, davidedmundson, kde-frameworks-devel, manueljlin, Orage, LeGast00n, The-Feren-OS-Dev,

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove marked an inline comment as done. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27122 To: niccolove, ndavis, ngraham Cc: ndavis, filipf, ngraham, davidedmundson, kde-frameworks-devel, manueljlin, Orage, LeGast00n, The-Feren-OS-Dev,

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove updated this revision to Diff 75145. niccolove added a comment. Fixed mistakes in breeze dark cmakelist REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27122?vs=75019=75145 BRANCH contrast_effect_background_color (branched

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove added a comment. Nope, I'm absolutely unable to build plasma-framework right now, I have many problems that I don't understand :-/ Also, I have 0 Cmake experience If somebody has time, can they look into how to make Cmake read that file? REPOSITORY R242 Plasma Framework

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove added a comment. I'm unable to build anything right now unluckly so I tried to use code from the breeze folder but I'm not good at cmake. I will try to make cmake for me tomorrow REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27122

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove updated this revision to Diff 75019. niccolove added a comment. Replace dialogs with widgets as that's the actual one REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27122?vs=75018=75019 BRANCH

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove updated this revision to Diff 75018. niccolove added a comment. Fix cmake REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27122?vs=75017=75018 BRANCH contrast_effect_background_color (branched from master) REVISION DETAIL

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove updated this revision to Diff 75017. niccolove added a comment. Updated cmake REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27122?vs=75010=75017 BRANCH contrast_effect_background_color (branched from master) REVISION

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove added a comment. I've done the dark theme again, should be nice now REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27122 To: niccolove, ndavis Cc: ndavis, filipf, ngraham, davidedmundson, kde-frameworks-devel, manueljlin, Orage,

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27122 To: niccolove, ndavis Cc: ndavis, filipf, ngraham, davidedmundson, kde-frameworks-devel, manueljlin, Orage, LeGast00n, The-Feren-OS-Dev, cblack,

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove updated this revision to Diff 75010. niccolove added a comment. Tweaked contrast effect for dark and light versions, added new panel file for dark REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27122?vs=74911=75010 BRANCH

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove added a comment. In D27122#605987 , @ndavis wrote: > Don't make a color file for the breeze desktop theme. It doesn't have one so that it can use any system color scheme. Uhm; but then, there's no way for the default theme to

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove added a comment. In D27122#605981 , @ndavis wrote: > In D27122#605976 , @niccolove wrote: > > > In D27122#605975 , @ndavis wrote: > > > > >

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove added a comment. In D27122#605975 , @ndavis wrote: > Also, you can set contrast effects per desktop theme. If you do that, you may be able to improve the look of breeze light without hurting breeze dark. Let the Breeze desktop theme

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove added a comment. In D27122#605973 , @ndavis wrote: > In D27122#605969 , @niccolove wrote: > > > In D27122#605804 , @ndavis wrote: > > > > >

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove added a comment. In D27122#605804 , @ndavis wrote: > Using View Background is semantically incorrect. If you want to change the color, you should patch the color scheme. But in order to change ColorScheme-Background I should

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove added a comment. I agree that the dark variant needs a bit of work still. I had focused on the light version. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27122 To: niccolove Cc: ngraham, davidedmundson, kde-frameworks-devel,

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove added inline comments. INLINE COMMENTS > davidedmundson wrote in metadata.desktop.cmake:98 > There's an explicit comment on why this is as it is. > > That needs some addressing as to why it no longer applies or is less > important that some other change. Simply put, it doesn't work.

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27122 To: niccolove Cc: davidedmundson, kde-frameworks-devel, manueljlin, Orage, LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon,

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27122 To: niccolove Cc: davidedmundson, kde-frameworks-devel, manueljlin, Orage, LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon,

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove marked an inline comment as done. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27122 To: niccolove, davidedmundson Cc: davidedmundson, kde-frameworks-devel, manueljlin, Orage, LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian,

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove updated this revision to Diff 74911. niccolove added a comment. Fixed accidental changes REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27122?vs=74907=74911 BRANCH contrast_effect_background_color (branched from master)

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove edited the summary of this revision. niccolove added projects: Plasma, VDG. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27122 To: niccolove, davidedmundson Cc: davidedmundson, kde-frameworks-devel, manueljlin, Orage, LeGast00n,

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27122 To: niccolove, davidedmundson Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. niccolove requested review of this revision. REVISION SUMMARY I tweaked the contrast effect values to make Breeze a bit prettier (also similiarly to what's described here

D27075: Fixed tooltip corners and removed useless color attributes

This revision was automatically updated to reflect the committed changes. Closed by commit R242:f7b4bbf86177: Fixed tooltip corners and removed useless color attributes (authored by niccolove). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D27075: Fixed tooltip corners and removed useless color attributes

niccolove added a reviewer: ndavis. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27075 To: niccolove, ndavis Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27075: Fixed tooltip corners and removed useless color attributes

niccolove created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. niccolove requested review of this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D27075 AFFECTED FILES

D26968: Removed hardcoded colors in background SVGs

niccolove added a comment. In D26968#602035 , @ndavis wrote: > In D26968#602034 , @niccolove wrote: > > > Okay! I'm installing Inkscape 1, for future patches. May I ask you to land this, as I don't

D26968: Removed hardcoded values

niccolove added a comment. Okay! I'm installing Inkscape 1, for future patches. May I ask you to land this, as I don't have access rights? REPOSITORY R242 Plasma Framework (Library) BRANCH fix_panel_color REVISION DETAIL https://phabricator.kde.org/D26968 To: niccolove, #vdg,

D26968: Removed hardcoded values

niccolove added a comment. In D26968#601998 , @ndavis wrote: > You should remove the color field instead of using `color:currentColor` and `fill:currentColor` I tried to do that, but for some reason the "color:#effeff" automatically

<    1   2   3   >