Re: Flathub and Snap Store entries for KGeoTag

2024-01-04 Thread Simon Redman
Pedantically, my reading of LicenseRef-KDE-Accepted-GPL, it does not allow distributing software under LicenseRef-KDE-Accepted-GPL. The text is here: https://community.kde.org/Policies/Licensing_Policy#LicenseRef-KDE-Accepted-GPL """ you can redistribute it and/or modify it under the terms of

Re: Using Screen sharing to extend monitor to tablets on Gnome 42

2023-09-28 Thread Simon Redman
The feature has existed in Plasma for around a year: https://invent.kde.org/plasma/kwin/-/merge_requests/1495 I've never tried to use it so I don't know how it's triggered. There's a KDE Connect plugin to orchestrate it which I've also never used, and which only works desktop-to-desktop, but

What happened to "Allow commits from members who can merge to the target branch."?

2022-06-27 Thread Simon Redman
Hi all, Previously when making a PR, I was able to select a checkbox to allow others to merge to my PR branch: Now, that box seems to have vanished. Did I miss a discussion about removing this feature? It's super useful so that I can do small fixups to a stale PR and then merge it.

Re: Project suggestion for the Google summer of code

2021-03-10 Thread Simon Redman
Hi Felipe, GSoC ideas should go on our ideas page: https://community.kde.org/GSoC/2021/Ideas From the Phabricator task, it sounds like this might be too much for a GSoC project. Google shrunk the timeline a lot this year so the scope needs to be much narrower. Have you spoken with Martin

Re: Disabling akonadi test runner infrastructure across all repositories

2019-11-16 Thread Simon Redman
My only thought about this is, is it possible to disable the tests in a way which leaves a warning so that at least it isn't silently "passing"? On 11/15/19 10:02 PM, Ben Cooksley wrote: > Hi all, > > For some time now the Akonadi Test Runner infrastructure has had > issues on the CI system where

Re: How to prevent users from opening GitLab issues?

2019-10-09 Thread Simon Redman
You can add templates by following the directions here: https://docs.gitlab.com/ee/user/project/description_templates.html#creating-issue-templates (Similar steps for pull requests, check out the kdeconnect-kde repo if you want the templates I made) Unfortunately regular developers can't set the

Re: Retirement of notes.kde.org

2019-09-16 Thread Simon Redman
On September 15, 2019 11:03:31 PM PDT, Ben Cooksley wrote: >On Mon, Sep 16, 2019 at 5:14 AM Valorie Zimmerman > wrote: >> >> Hey Ben, > >Hi Valorie, > >> >> On Sun, Sep 15, 2019 at 11:58 AM Ben Cooksley >wrote: >>> >>> Good evening all, >>> >>> Currently we're in the situation where the

D22727: allow kio-extras to build with mingw on win32 and remove unnecessary includes

2019-08-18 Thread Simon Redman
sredman added a comment. In D22727#513842 , @dfaure wrote: > The truth is stronger than "I would not recommend". > put() in SlaveBase-derived classes is called by the KIO library (TransferJob), so you CANNOT change the meaning of the

D23196: have the app icon as fallback icon in Snore

2019-08-17 Thread Simon Redman
sredman accepted this revision. sredman added a comment. This revision is now accepted and ready to land. Since KNotifications on Windows is so far only used by you anyway, I say it's fine to merge. @broulik, any objections? INLINE COMMENTS > notifybysnore.cpp:157 > +

D22727: allow kio-extras to build with mingw on win32 and remove unnecessary includes

2019-08-17 Thread Simon Redman
sredman added a comment. In D22727#510698 , @brute4s99 wrote: > In D22727#505540 , @dfaure wrote: > > > But, wait, this code is mixing "int permissions" (*) with the QFileDevice enum, that doesn't

Re: Unified git commit message guideline

2019-08-14 Thread Simon Redman
On 8/12/19 12:44 AM, David Faure wrote: > Hello Roman, > > On dimanche 11 août 2019 23:52:55 CEST Roman Gilg wrote: >> [1] https://www.conventionalcommits.org >> >> >> I would also like to keep the "Test Plan" field from phab even after we move >> to gitlab, it pushes people to write down how

D21661: add snoretoast backend for KNotifications on Windows

2019-08-11 Thread Simon Redman
sredman accepted this revision. sredman added a comment. This revision is now accepted and ready to land. I noticed a couple of places where the cmake file could be simplified so make those changes and then let's land this monster INLINE COMMENTS > CMakeLists.txt:76 > +if (NOT WIN32) > +

Re: Signing keys for commercial app stores

2019-06-10 Thread Simon Redman
Mon, Jun 10, 2019 at 2:03 PM Simon Redman wrote: >> Hello, > Hi Simon, > >> I am Simon, and I work on KDE Connect. This summer, KDE Connect has two >> excellent GSoC students, one working on a MacOS port and one working on >> a Windows port, with the end goal of bringing

Signing keys for commercial app stores

2019-06-09 Thread Simon Redman
Hello, I am Simon, and I work on KDE Connect. This summer, KDE Connect has two excellent GSoC students, one working on a MacOS port and one working on a Windows port, with the end goal of bringing those ports to feature pairity with our Linux version and doing an official release. While we could

D21661: add snoretoast backend for KNotifications on Windows

2019-06-08 Thread Simon Redman
sredman added a comment. In D21661#476571 , @pino wrote: > In D21661#476156 , @pino wrote: > > > how is snoretoast actually used here? you are requiring the library for building and linking, but

D21661: add snoretoast backend for KNotifications on Windows

2019-06-07 Thread Simon Redman
sredman added inline comments. INLINE COMMENTS > CMakeLists.txt:43 > +if (WIN32) > + if (MSVC) > + find_package(LibSnoreToast REQUIRED) Do you know whether this requires MSVC, or can SnoreToast.exe be built with MSVC and KNotifications be built with an unspecified compiler? >

D21369: [WIP] Add AbstractContact properties for KContact::PhoneNumber objects

2019-05-24 Thread Simon Redman
sredman added a comment. In D21369#469389 , @apol wrote: > Seems like a clear layer break to spill KContacts over KPeople :P. > Let's discuss it at the sprint? Or earlier. Let's discuss it? ^^' Sounds good REPOSITORY R307 KPeople

D21369: [WIP] Add AbstractContact properties for KContact::PhoneNumber objects

2019-05-23 Thread Simon Redman
sredman edited the summary of this revision. REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D21369 To: sredman, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21369: [WIP] Add AbstractContact properties for KContact::PhoneNumber objects

2019-05-23 Thread Simon Redman
sredman updated this revision to Diff 58565. sredman added a comment. - Hack on QMetaType support REPOSITORY R307 KPeople CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21369?vs=58561=58565 BRANCH kcontacts-phonenumber REVISION DETAIL https://phabricator.kde.org/D21369

D21369: [WIP] Add AbstractContact properties for KContact::PhoneNumber objects

2019-05-23 Thread Simon Redman
sredman added a dependent revision: D21374: WIP: Add support for KContacts::PhoneNumber-related custom data fields. REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D21369 To: sredman, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21369: [WIP] Add AbstractContact properties for KContact::PhoneNumber objects

2019-05-23 Thread Simon Redman
sredman updated this revision to Diff 58561. sredman added a comment. - Add link_library target to backends as well REPOSITORY R307 KPeople CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21369?vs=58556=58561 BRANCH kcontacts-phonenumber REVISION DETAIL

D21369: [WIP] Add AbstractContact properties for KContact::PhoneNumber objects

2019-05-23 Thread Simon Redman
sredman added a reviewer: apol. REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D21369 To: sredman, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21369: [WIP] Add AbstractContact properties for KContact::PhoneNumber objects

2019-05-23 Thread Simon Redman
sredman updated this revision to Diff 58556. sredman added a comment. - Move KF5::Contacts to PUBLIC library REPOSITORY R307 KPeople CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21369?vs=58553=58556 BRANCH kcontacts-phonenumber REVISION DETAIL

D21369: [WIP] Add AbstractContact properties for KContact::PhoneNumber objects

2019-05-23 Thread Simon Redman
sredman created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sredman requested review of this revision. REVISION SUMMARY - Add phone number getters to PersonData - Add KContact::PhoneNumber properties to AbstractContact Does not

D16692: A QApplication object needs to be instantiated for kio-kdeconnect to work on KDE Neon

2018-11-05 Thread Simon Redman
sredman added a comment. This is going to be our cleanest patch ever once we've had everybody and their grandmother look at it. I guess this is what happens when you fix a hot bug!  In D16692#354783 , @jriddell wrote: > I can recreate the