D12371: fix always reproducible crash

dfaure accepted this revision. dfaure added a comment. Patch looks good, but please update the first line of the commit message so that it gives more context (think about the changelog, where the rest of the description won't be visible...) REPOSITORY R241 KIO REVISION DETAIL

Re: Changes to Phabricator review subscriptions

On Wed, May 9, 2018 at 10:45 PM, Timothée Giet wrote: > Le 09/05/2018 à 12:11, Ben Cooksley a écrit : >> >> On Wed, May 9, 2018 at 9:25 PM, Timothée Giet wrote: >>> >>> Le 09/05/2018 à 10:33, Boudewijn Rempt a écrit : On Wednesday, May 9, 2018

Re: Changes to Phabricator review subscriptions

On Wednesday, May 9, 2018 10:08:28 AM CEST you wrote: > Hi all, > > To improve the user experience around email and in-application > notifications from Phabricator, sysadmin have made some changes to the > configuration of our Herald rules. > > Going forward, instead of subscribing projects to

D9794: Provide access to data returned by helper even on error replies

apol added a comment. Restricted Application added a subscriber: kde-frameworks-devel. What are you trying to fix? Why isn't the error text enough? REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D9794 To: volkov, #frameworks Cc: kde-frameworks-devel, apol,

D12765: Use a more intuitive, user-friendly name for Samba share access

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH friendlier-samba-share-name (branched from master) REVISION DETAIL https://phabricator.kde.org/D12765 To: ngraham, #frameworks, #dolphin, #vdg, apol Cc: ltoscano,

Re: Changes to Phabricator review subscriptions

On Wed, May 9, 2018 at 9:47 PM, Milian Wolff wrote: > On Mittwoch, 9. Mai 2018 10:08:28 CEST Ben Cooksley wrote: >> Hi all, >> >> To improve the user experience around email and in-application >> notifications from Phabricator, sysadmin have made some changes to the >>

D12768: Allow wrapping selection off top/bottom of autocomplete results

brauch added a comment. What happens if the overload selection window is open in addition (like in KDevelop)? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12768 To: sraizada, #ktexteditor Cc: brauch, #ktexteditor, #frameworks, michaelh, kevinapavew, ngraham,

Re: Changes to Phabricator review subscriptions

On Wed, May 9, 2018 at 8:33 PM, Boudewijn Rempt wrote: > On Wednesday, May 9, 2018 10:08:28 AM CEST you wrote: >> Hi all, >> >> To improve the user experience around email and in-application >> notifications from Phabricator, sysadmin have made some changes to the >>

Re: Changes to Phabricator review subscriptions

On Wed, May 9, 2018 at 9:25 PM, Timothée Giet wrote: > Le 09/05/2018 à 10:33, Boudewijn Rempt a écrit : >> >> On Wednesday, May 9, 2018 10:08:28 AM CEST you wrote: >>> >>> Hi all, >>> >>> To improve the user experience around email and in-application >>> notifications from

Re: Changes to Phabricator review subscriptions

Le 09/05/2018 à 10:33, Boudewijn Rempt a écrit : On Wednesday, May 9, 2018 10:08:28 AM CEST you wrote: Hi all, To improve the user experience around email and in-application notifications from Phabricator, sysadmin have made some changes to the configuration of our Herald rules. Going

Re: Changes to Phabricator review subscriptions

Le 09/05/2018 à 12:11, Ben Cooksley a écrit : On Wed, May 9, 2018 at 9:25 PM, Timothée Giet wrote: Le 09/05/2018 à 10:33, Boudewijn Rempt a écrit : On Wednesday, May 9, 2018 10:08:28 AM CEST you wrote: Hi all, To improve the user experience around email and in-application

D12744: Add null pointer check when creating SocketAddress

dfaure accepted this revision. This revision is now accepted and ready to land. Restricted Application edited subscribers, added: kde-frameworks-devel; removed: Frameworks. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D12744 To: chinmoyr, dfaure, ossi

D12371: fix always reproducible crash

jtamate updated this revision to Diff 33872. jtamate marked an inline comment as done. jtamate edited the summary of this revision. jtamate added a comment. Restricted Application added a subscriber: kde-frameworks-devel. The crash after the redirection in fish://127.0.0.1 was due to a

D12696: Use the new uds implementation

jtamate updated this revision to Diff 33889. jtamate edited the summary of this revision. jtamate added a comment. Restricted Application added a subscriber: kde-frameworks-devel. Direct friendship with the operators. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D12696: Use the new uds implementation

bruns added inline comments. INLINE COMMENTS > kfileitem.cpp:198 > const QByteArray pathBA = QFile::encodeName(path); > if (QT_LSTAT(pathBA.constData(), ) == 0) { > +m_entry.replace(KIO::UDSEntry::UDS_DEVICE_ID, > buf.st_dev);

D12696: Use the new uds implementation

bruns added inline comments. INLINE COMMENTS > bruns wrote in kfileitem.cpp:198 > Wouldn't it be better to call m_entry.clear() and m_entry.insert(...) here? > > For the call from the constructor, m_entry is empty, so you save the > std::find_if() in the replace method calls. > > For any

Re: Changes to Phabricator review subscriptions

On woensdag 9 mei 2018 12:45:35 CEST Timothée Giet wrote: > Thanks a lot Ben for the clarification :) > So it seems we are unaffected by the change and can continue to work > like we do. Yes, indeed. No need for us to worry :-) > Our devel mailing list is now mostly used for occasional wider

D12765: Use a more intuitive, user-friendly name for Samba share access

markg accepted this revision. markg added a comment. Please do note that you have more protocols with shared folders that likely deserve a name change in the same fashion. REPOSITORY R320 KIO Extras BRANCH friendlier-samba-share-name (branched from master) REVISION DETAIL

Re: Changes to Phabricator review subscriptions

1. What is the canonical way to be notified of Phabricator changes for projects you're interested in? Subscribe to that project's mailing list? Can you clarify what this means for someone who joins or "watches" a project in Phabricator? Should we stop doing that? 2. If someone is subscribed

D12765: Use a more intuitive, user-friendly name for Samba share access

This revision was automatically updated to reflect the committed changes. Closed by commit R320:80429a0ed768: Use a more intuitive, user-friendly name for Samba share access (authored by ngraham). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE

D12513: CVE-2018-10361: privilege escalation

mgerstner added a comment. Restricted Application edited subscribers, added: kde-frameworks-devel, kwrite-devel; removed: Frameworks. In D12513#258565 , @aacid wrote: > > Honestly i don't understand why i have to care about

D9794: Provide access to data returned by helper even on error replies

volkov added a comment. The error text is nonlocalized because a helper doesn't know a locale of a user process. With this change the helper may return data that can be composed into a translated message in the user process. REPOSITORY R283 KAuth REVISION DETAIL

D12765: Use a more intuitive, user-friendly name for Samba share access

ngraham added a comment. Which ones, and where do they live? REPOSITORY R320 KIO Extras BRANCH friendlier-samba-share-name (branched from master) REVISION DETAIL https://phabricator.kde.org/D12765 To: ngraham, #frameworks, #dolphin, #vdg, apol, markg Cc: markg, ltoscano,

D12765: Use a more intuitive, user-friendly name for Samba share access

markg added a comment. In D12765#260054 , @ngraham wrote: > Which ones, and where do they live? I would have expected it for NFS (same repository), but it apparently doesn't have a .desktop file at all. FTP (lives in the mina kio repo

D12768: Allow wrapping selection off top/bottom of autocomplete results

sraizada updated this revision to Diff 33884. sraizada added a comment. Restricted Application edited subscribers, added: kde-frameworks-devel, kwrite-devel; removed: Frameworks. Removed unnecessary modifications to code REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

Re: kdesrc-build: cmake should take local (instead of system-wide) cmake modules

Am 09.05.2018 08:19 schrieb Ben Cooksley: On Wed, May 9, 2018 at 9:28 AM, gregor.mi.sw wrote: On 08.05.2018 23:15, Milian Wolff wrote: On Dienstag, 8. Mai 2018 22:40:39 CEST gregor.mi.sw wrote: Hello, I have a question regarding kdesrc-build and CMake. I setup

D12768: Allow wrapping selection off top/bottom of autocomplete results

sraizada added a comment. I only use Kate/KWrite so didn't test it on the others previously - sorry. It actually only works in Kate and KWrite, and has no effect on Kile/KDevelop. KDevelop is obviously doing some special stuff, but visually the Kile autocompletion seems identical to the

D8007: popplerextractor: don't try to guess the title if there isn't one.

ngraham added a comment. Restricted Application added subscribers: Baloo, kde-frameworks-devel. So... are we landing this? REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D8007 To: flameeyes, #frameworks, mgallien Cc: kde-frameworks-devel, #baloo, bruns,

D12197: autotests: Test for multiple values

ngraham added a comment. Restricted Application added a subscriber: kde-frameworks-devel. @michaelh Ping! Can we land this? REPOSITORY R286 KFileMetaData BRANCH multi-value-test (branched from master) REVISION DETAIL https://phabricator.kde.org/D12197 To: michaelh, #baloo,

D10937: Retouching of Screen Layout Selection OSD Icons

pstefan added a comment. Restricted Application edited subscribers, added: kde-frameworks-devel; removed: Frameworks. Hello again, I was just wondering if there's something left I have to do now? Like some button I have to press or something. REPOSITORY R266 Breeze Icons REVISION

D12787: Ignore more types of source files

ngraham edited the summary of this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12787 To: ngraham Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns

D10937: Retouching of Screen Layout Selection OSD Icons

ngraham added a subscriber: VDG. ngraham added a comment. Someone will need to land the changes for you. I'd prefer a few more thumbs up first. @abetts, are you good with these? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10937 To: pstefan, #breeze,

D12538: Allow accepting by double-click in save dialog

anemeth updated this revision to Diff 33900. anemeth added a comment. Restricted Application added a subscriber: kde-frameworks-devel. - Merge branch 'master' of git://anongit.kde.org/kio into arcpatch-D12538 - Double clicking to save only works on files REPOSITORY R241 KIO CHANGES SINCE

D12787: Ignore more types of source files

ngraham created this revision. Restricted Application added projects: Frameworks, Baloo. Restricted Application added subscribers: Baloo, kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY Add more types of development-related files to the exclusion lists. Thhese

D10937: Retouching of Screen Layout Selection OSD Icons

ngraham edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10937 To: pstefan, #breeze, ngraham Cc: #vdg, kde-frameworks-devel, emateli, abetts, mart, ngraham, davidc, michaelh, crozbo, firef, bruns, alexeymin, skadinna,

Re: Changes to Phabricator review subscriptions

On Thu, 10 May 2018, 02:08 Nate Graham, wrote: > 1. What is the canonical way to be notified of Phabricator changes for > projects you're interested in? Subscribe to that project's mailing list? > Can you clarify what this means for someone who joins or "watches" a > project in

D10937: Retouching of Screen Layout Selection OSD Icons

abetts added a comment. In D10937#260277 , @ngraham wrote: > Someone will need to land the changes for you. I'd prefer a few more thumbs up first. @abetts, are you good with these? I am linking these a lot. I am "almost" there with the

D12696: Use the new uds implementation

dfaure added a comment. Starting to look good ;-) INLINE COMMENTS > udsentry.h:143 > /** > * insert field with string value > * @param field numeric field id The old insert() should be documented that it asserts if the entry already exists, and that one should use

Re: Changes to Phabricator review subscriptions

Thanks for the responses, Ben. I'm a bit concerned that all of this raises the barrier to entry for new contributors. Now they'll have to match up Phabricator projects with mailing lists, which do not have a 1:1 mapping. How is someone interested in Dolphin supposed to know that they need to

Re: Changes to Phabricator review subscriptions

Nate Graham ha scritto: > Thanks for the responses, Ben. > > I'm a bit concerned that all of this raises the barrier to entry for new > contributors. Now they'll have to match up Phabricator projects with mailing > lists, which do not have a 1:1 mapping. How is someone interested in Dolphin >

D12538: Allow accepting by double-click in save dialog

ngraham added a comment. Nice! Behaviorally, this works well now and I didn't find any regressions. Just some code style comments below: INLINE COMMENTS > kfilewidget.cpp:1189 > } > + > } Unnecessary unrelated whitespace change > kfilewidget.cpp:1866 > + > +

Re: Changes to Phabricator review subscriptions

On Wed, 09 May 2018 12:46:30 -0700 Luigi Toscano wrote > Nate Graham ha scritto: > > Thanks for the responses, Ben. > > > > I'm a bit concerned that all of this raises the barrier to entry for new > > contributors. Now they'll have to match up

D12538: Allow accepting by double-click in save dialog

ngraham added inline comments. INLINE COMMENTS > rkflx wrote in kfilewidget.cpp:1866 > Is this even possible without a lot of refactoring (which would be > out-of-scope for this patch)? Not for everything, just this one. REPOSITORY R241 KIO REVISION DETAIL

D12197: autotests: Test for multiple values

bruns requested changes to this revision. bruns added a comment. This revision now requires changes to proceed. This depends on the pending discussion how "Subject" and "Keyword" should be handled, see D10694 REPOSITORY R286 KFileMetaData REVISION

D12538: Allow accepting by double-click in save dialog

anemeth marked 2 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12538 To: anemeth, #frameworks, #vdg, ngraham, rkflx Cc: kde-frameworks-devel, ltoscano, rkflx, broulik, jtamate, ngraham, #frameworks, michaelh, bruns

D10694: epubextractor: Handle multiple subjects better

bruns requested changes to this revision. bruns added a comment. This revision now requires changes to proceed. Restricted Application edited subscribers, added: Baloo, kde-frameworks-devel; removed: Frameworks. Discussion regarding subject vs keywords is still pending, i.e. no conclusion.

D12114: Revive 'Description' property

bruns added a comment. Restricted Application added a subscriber: kde-frameworks-devel. @michaelh - are you still working on this? I think using Property::Description for dc::description and the like is very sensible, so I would welcome if you pushed this forward. Regarding the

D12787: Ignore more types of source files

ngraham edited the summary of this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12787 To: ngraham Cc: cfeck, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns

Re: kdesrc-build: cmake should take local (instead of system-wide) cmake modules

On Wed, May 09, 2018 at 01:12:10PM +0200, gregor.mi.sw wrote: > Am 09.05.2018 08:19 schrieb Ben Cooksley: > > On Wed, May 9, 2018 at 9:28 AM, gregor.mi.sw > > wrote: > >> On 08.05.2018 23:15, Milian Wolff wrote: > >>> On Dienstag, 8. Mai 2018 22:40:39 CEST gregor.mi.sw

D12538: Allow accepting by double-click in save dialog

ngraham added inline comments. INLINE COMMENTS > anemeth wrote in kfilewidget.cpp:1866 > I'm having a lot of trouble finding the correct syntax... > And the compiler is giving me 100 lines of cryptic error message. > Could you help me out on this one? Hmm, you're right, I can't get it to work

D8007: popplerextractor: don't try to guess the title if there isn't one.

bruns accepted this revision. bruns added a comment. I think this is sensible, to much code for questionable results. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D8007 To: flameeyes, #frameworks, mgallien, bruns Cc: kde-frameworks-devel, #baloo, bruns,

D12513: CVE-2018-10361: privilege escalation

aacid added a comment. I meant dropping privileges to the user that is running the ktexteditor program, not to the user that owns the target directory, but now that i think about it that's pretty stupid since otherwise we wouldn't be needing root :D I'll try to go over this with a fresh

D12787: Ignore more types of source files

cfeck added inline comments. INLINE COMMENTS > fileexcludefilters.cpp:142 > +"text/csx", > +"text/vnd.trolltech.linguist" > "application/x-awk", , REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12787 To: ngraham Cc: cfeck, kde-frameworks-devel, #baloo,

D12538: Allow accepting by double-click in save dialog

rkflx added inline comments. INLINE COMMENTS > ngraham wrote in kfilewidget.cpp:1866 > Let's use new-style signal/slot syntax for new code. See > https://wiki.qt.io/New_Signal_Slot_Syntax Is this even possible without a lot of refactoring (which would be out-of-scope for this patch)? >

D12787: Ignore more types of source files

ngraham marked an inline comment as done. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12787 To: ngraham Cc: cfeck, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns

D12787: Ignore more types of source files

ngraham updated this revision to Diff 33912. ngraham added a comment. add missing comma REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12787?vs=33903=33912 BRANCH more-excluded-source-files (branched from master) REVISION DETAIL

D12538: Allow accepting by double-click in save dialog

anemeth updated this revision to Diff 33914. anemeth added a comment. - Remove QFileInfo REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12538?vs=33900=33914 BRANCH arcpatch-D12538 (branched from master) REVISION DETAIL https://phabricator.kde.org/D12538

D11155: handle zip files embedded within zip files

dfaure accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://phabricator.kde.org/D11155 To: sandsmark, dfaure, #frameworks Cc: ngraham, #frameworks, michaelh, bruns

D12538: Allow accepting by double-click in save dialog

anemeth added inline comments. INLINE COMMENTS > rkflx wrote in kfilewidget.cpp:1866 > Well, how should that line look like then? I'm having a lot of trouble finding the correct syntax... And the compiler is giving me 100 lines of cryptic error message. Could you help me out on this one?

Crash on windows when resetting the toolbar items to the default values

Hi, https://bugs.kde.org/show_bug.cgi?id=387610 we've got this bug reported, happens on windows only. Can somebody check this with another KF5-application on windows? Any ideas what is causing this crash? Thanks and Regards, Alexander

D12787: Ignore more types of source files

ngraham updated this revision to Diff 33920. ngraham added a comment. Also omit node_packages folders REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12787?vs=33919=33920 BRANCH more-excluded-source-files (branched from master) REVISION DETAIL

D12538: Allow accepting by double-click in save dialog

rkflx added inline comments. INLINE COMMENTS > ngraham wrote in kfilewidget.cpp:1866 > Not for everything, just this one. Well, how should that line look like then? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12538 To: anemeth, #frameworks, #vdg, ngraham, rkflx Cc:

D12538: Allow accepting by double-click in save dialog

ngraham accepted this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12538 To: anemeth, #frameworks, #vdg, ngraham, rkflx Cc: kde-frameworks-devel, ltoscano, rkflx, broulik, jtamate, ngraham, #frameworks, michaelh, bruns

D12787: Ignore more types of source files

ngraham edited the summary of this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12787 To: ngraham Cc: cfeck, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns

D12787: Ignore more types of source files

ngraham updated this revision to Diff 33919. ngraham added a comment. Add more to also fix 39093 REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12787?vs=33915=33919 BRANCH more-excluded-source-files (branched from master) REVISION DETAIL

D12787: Ignore more types of source files

ngraham updated this revision to Diff 33915. ngraham added a comment. Revert unintentional change REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12787?vs=33912=33915 BRANCH more-excluded-source-files (branched from master) REVISION DETAIL

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10 - Build # 9 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.10/9/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10 Date of build: Thu, 10 May 2018 03:26:10 + Build duration: 2 min 31 sec and counting

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 157 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/157/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Thu, 10 May 2018 03:26:10 + Build duration: 5 min 7 sec and counting

D8007: popplerextractor: don't try to guess the title if there isn't one.

This revision was automatically updated to reflect the committed changes. Closed by commit R286:1491c4a2d9fd: popplerextractor: dont try to guess the title if there isnt one. (authored by flameeyes, committed by ngraham). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE