Review Request 129078: Don't load containment actions for embedded containments (system trays)

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129078/
---

Review request for KDE Frameworks and Plasma.


Repository: plasma-framework


Description
---

Also load the correct default actions for custom panels.


Diffs
-

  src/plasma/containment.cpp 803887d2038719028ef424883619d416c120740e 

Diff: https://git.reviewboard.kde.org/r/129078/diff/


Testing
---


Thanks,

David Edmundson

Re: Scrap baloo?

[David Edmundson]

​Sort of related to this: Does anyone know what the status of baloo-widgets
is?

According to dependency-data-kf5-qt5 it's in kdelibs.
Not frameworks, kdelibs, but as a Qt5 library with a KF5 prefix.

David

Jenkins-kde-ci: breeze-icons master stable-kf5-qt5 » Linux,gcc - Build # 319 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/breeze-icons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/319/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 30 Sep 2016 21:53:42 +
Build duration: 4 min 11 sec

CHANGE SET
Revision 8501038b041bafe5d66e91d49f410be4a42adeb2 by kainz.a: (sync colors 
between different sizes)
  change: edit icons/mimetypes/22/libreoffice-drawing.svg
  change: edit icons/mimetypes/22/application-vnd.iccprofile.svg
  change: edit icons/mimetypes/16/libreoffice-drawing.svg
  change: edit icons/mimetypes/32/application-x-ms-shortcut.svg


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 
test(s)Failed: TestSuite.dupe

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 105/132 
(80%)CONDITIONAL 46/78 (59%)

By packages
  
default>
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 42/57 (74%)CONDITIONAL 
14/26 (54%)
autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 63/75 (84%)CONDITIONAL 
32/52 (62%)

Re: Scrap baloo?

[David Edmundson]

On Wed, Sep 28, 2016 at 10:22 PM, Christoph Cullmann 
wrote:

> Hi,
>
> > Generally speaking, in terms of Plasma feedback, Baloo doesn't come up
> > /that/ much.
> > I'm sure there's stuff in the bug tracker, but we don't have the big
> public
> > problem that we used to have.
> >
> > I think your problems are exagerrated because of the NFS mount.
> >
> > The only problem we have is the runner bringing down the shell when we
> have
> > the corrupt database - and from the comments above, that should be
> > catchable.
> You can catch that, by rewriting all current code, as there is no error
> handling,
> but yes, that is true. One can write lmdb code that handles corrupted DBs
> and
> catch all error cases. lmdb is no bad database in that aspect.
>
>


> >
> > 
> >
>



> > Questions:
> >
> > Tracker doesn't look at xattrs at all.
> >
> > At which point we would need to think about migration.
> >
> > This is possibly solvable with a patch in tracker. The tracker maintainer
> > (in 2014) sounds like he would be in support of it:
> https://mail.gnome.org/
> > archives/tracker-list/2014-September/msg00045.html
> > and there is a writeback module in tracker.
> A one way migration would be to write a tracker "miner" (if don't use the
> wrong word)
> and move the tags into the tracker tag db, or what you cite above.
>
>
Have you tried using tags in tracker?
Using tracker-needle, and adding a tag I get:

Could not update tags
GDBus.Error.freedesktop.Track1.Sparql.Internal no such column:
nie:DataObject1.ID

Even after wiping the database.

Same for using "tracker tag -a"

Am I missing a package?

David

Jenkins-kde-ci: breeze-icons master kf5-qt5 » Linux,gcc - Build # 322 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/breeze-icons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/322/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 30 Sep 2016 21:53:42 +
Build duration: 2 min 14 sec

CHANGE SET
Revision 8501038b041bafe5d66e91d49f410be4a42adeb2 by kainz.a: (sync colors 
between different sizes)
  change: edit icons/mimetypes/22/application-vnd.iccprofile.svg
  change: edit icons/mimetypes/32/application-x-ms-shortcut.svg
  change: edit icons/mimetypes/22/libreoffice-drawing.svg
  change: edit icons/mimetypes/16/libreoffice-drawing.svg


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 
test(s)Failed: TestSuite.dupe

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 105/132 
(80%)CONDITIONAL 46/78 (59%)

By packages
  
default>
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 42/57 (74%)CONDITIONAL 
14/26 (54%)
autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 63/75 (84%)CONDITIONAL 
32/52 (62%)

Re: kdereview

[Albert Astals Cid]

El divendres, 30 de setembre de 2016, a les 21:17:56 CEST, Ben Cooksley va 
escriure:
> On Fri, Sep 30, 2016 at 11:27 AM, Albert Astals Cid  wrote:
> > El dimecres, 21 de setembre de 2016, a les 11:01:18 CEST, Allen Winter va
> > 
> > escriure:
> >> kwave is now moved to kdemultimedia.
> > 
> > Why did that happen?
> 
> It was moved at the request of it's maintainer and Allen.
> 
> > Did i miss the emails to k-c-d about reviewing it?
> 
> I've just searched my mail - you didn't miss it. When the repository
> was moved to KDE Review the Sysadmin ticket would have expressly
> requested that the review process on kde-core-devel be started by the
> maintainer now that we'd processed the move. It appears that didn't
> happen.
> 
> Thoughts on what should be done in regards to KWave here?

Following the rules strictly I'd say to move it back to kdereview until we do 
the usual steps, i.e. email to k-c-d and the module list and get the review.

Now, moving stuff around is a bit of a pain, so if Thomas can get those emails 
sent *NOW* I guess we can do the discussion with the kwave repo still in the 
kdemultimedia location and if nothing critical is found we save ourselves 
moving things back and forth.

Cheers,
  Albert

> 
> > Cheers,
> > 
> >   Albert
> 
> Cheers,
> Ben
> 
> >> No response from anyone else.
> >> 
> >> I suggest we remove bodega-client, kdev-perforce, kdots, kor and kpeg
> >> from
> >> kde_projects.xml and virtually move them into scratch.
> >> 
> >> On Sunday, September 18, 2016 12:08:41 PM Allen Winter wrote:
> >> > Howdy,
> >> > 
> >> > there's some stuff that's been in kdereview for a long time.
> >> > 
> >> > according to kde_projects.xml, the kdereview programs are:
> >> >   bodega-client (at least since Dec 2013)
> >> >   kdev-perforce
> >> >   kdots (at least since Nov 2015)
> >> >   kor (at least since Oct 2014)
> >> >   kpeg
> >> >   kwave
> >> > 
> >> > some of these (eg kwave) are actively developed.
> >> > 
> >> > Can the owners of these please move them to a final location,
> >> > clean them out, or let me know if they are really still under review?
> >> > 
> >> > And by "move" I mean change their virtual location according to
> >> > kde_projects or whatever "moving" means these days.
> >> > 
> >> > -Allen

Jenkins-kde-ci: breeze-icons master stable-kf5-qt5 » Linux,gcc - Build # 318 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/breeze-icons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/318/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 30 Sep 2016 21:34:36 +
Build duration: 6 min 32 sec

CHANGE SET
Revision dcf405fdabf79d23aadd9e75920a6e3ad01f73cd by kainz.a: (update 22px mime 
(finalize))
  change: edit icons-dark/mimetypes/22/text-x-c++hdr.svg
  change: edit icons/mimetypes/22/application-x-ruby.svg
  change: edit icons/mimetypes/22/application-x-macbinary.svg
  change: edit icons/mimetypes/22/image-tiff.svg
  change: edit 
icons/mimetypes/22/application-vnd.ms-excel.addin.macroenabled.12.svg
  change: edit icons/mimetypes/22/image-bmp.svg
  change: edit icons-dark/mimetypes/22/application-msword-template.svg
  change: edit icons/mimetypes/22/application-x-javascript.svg
  change: edit icons-dark/mimetypes/22/android-package-archive.svg
  change: edit 
icons-dark/mimetypes/22/application-vnd.ms-powerpoint.template.macroenabled.12.svg
  change: edit icons-dark/mimetypes/22/application-x-executable.svg
  change: edit icons-dark/mimetypes/22/application-vnd.visio.svg
  change: edit icons/mimetypes/22/application-x-zerosize.svg
  change: edit icons-dark/mimetypes/22/application-x-ruby.svg
  change: edit 
icons-dark/mimetypes/22/application-vnd.ms-excel.template.macroenabled.12.svg
  change: edit icons-dark/mimetypes/22/application-vnd.ms-infopath.svg
  change: edit icons/mimetypes/22/package-x-generic.svg
  change: edit icons/mimetypes/22/application-x-krita.svg
  change: edit 
icons-dark/mimetypes/22/application-vnd.ms-excel.addin.macroenabled.12.svg
  change: edit icons-dark/mimetypes/22/application-x-apple-diskimage.svg
  change: edit icons/mimetypes/22/application-x-java-archive.svg
  change: edit icons/mimetypes/22/application-msoutlook.svg
  change: edit icons-dark/mimetypes/22/application-x-php.svg
  change: edit 
icons/mimetypes/22/application-vnd.ms-excel.template.macroenabled.12.svg
  change: edit icons/mimetypes/22/image-x-vnd.trolltech.qpicture.svg
  change: edit icons/mimetypes/22/application-x-partial-download.svg
  change: edit icons-dark/mimetypes/22/application-pgp-encrypted.svg
  change: edit icons-dark/mimetypes/22/application-vnd.ms-access.svg
  change: edit icons/mimetypes/22/image-svg+xml-compressed.svg
  change: edit icons-dark/mimetypes/22/application-x-skg.svg
  change: edit icons/mimetypes/22/application-x-pem-key.svg
  change: edit icons-dark/mimetypes/22/application-ogg.svg
  change: edit icons-dark/mimetypes/22/image-x-xcf.svg
  change: edit icons-dark/mimetypes/22/image-svg+xml-compressed.svg
  change: edit icons/mimetypes/22/image-x-xcf.svg
  change: edit icons-dark/mimetypes/22/application-x-cd-image.svg
  change: edit icons-dark/mimetypes/22/application-x-macbinary.svg
  change: edit icons-dark/mimetypes/22/application-msword.svg
  change: edit icons/mimetypes/22/application-msword.svg
  change: edit icons-dark/mimetypes/22/application-zip.svg
  change: edit icons-dark/mimetypes/22/application-x-javascript.svg
  change: edit icons-dark/mimetypes/22/application-illustrator.svg
  change: edit icons-dark/mimetypes/22/text-x-csrc.svg
  change: edit icons-dark/mimetypes/22/application-atom+xml.svg
  change: edit icons/mimetypes/22/application-x-bzip.svg
  change: edit icons-dark/mimetypes/22/application-x-lzma-compressed-tar.svg
  change: edit icons-dark/mimetypes/22/application-x-skgc.svg
  change: edit 
icons-dark/mimetypes/22/application-vnd.oasis.opendocument.formula.svg
  change: edit icons-dark/mimetypes/22/application-x-ms-dos-executable.svg
  change: edit icons/mimetypes/22/text-x-csrc.svg
  change: edit icons/mimetypes/22/application-x-executable.svg
  change: edit icons/mimetypes/22/x-office-address-book.svg
  change: edit icons-dark/mimetypes/22/image-x-vnd.trolltech.qpicture.svg
  change: edit icons-dark/mimetypes/22/libreoffice-drawing.svg
  change: edit icons-dark/mimetypes/22/text-rtf.svg
  change: edit 
icons/mimetypes/22/application-vnd.oasis.opendocument.spreadsheet-template.svg
  change: edit icons-dark/mimetypes/22/application-dicom.svg
  change: edit icons-dark/mimetypes/22/application-x-zerosize.svg
  change: edit icons/mimetypes/22/application-vnd.ms-infopath.svg
  change: edit icons/mimetypes/22/text-xml.svg
  change: edit icons/mimetypes/22/text-rust.svg
  change: edit 
icons-dark/mimetypes/22/application-vnd.oasis.opendocument.web-template.svg
  change: edit icons/mimetypes/22/application-x-cda.svg
  change: edit 
icons-dark/mimetypes/22/application-vnd.oasis.opendocument.spreadsheet-template.svg
  change: edit icons/mimetypes/22/image-x-generic.svg
  change: edit icons/mimetypes/22/audio-x-wav.svg
  change: edit icons/mimetypes/22/text-x-chdr.svg
  change: edit icons-dark/mimetypes/22/application-x-wmf.svg
  change: edit icons-dark/mimetypes/22/text-xml.svg
  change: edit icons-dark/mimetypes/22/application-x-python-bytecode.svg
  change: edit 

Jenkins-kde-ci: breeze-icons master kf5-qt5 » Linux,gcc - Build # 321 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/breeze-icons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/321/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 30 Sep 2016 21:34:35 +
Build duration: 2 min 20 sec

CHANGE SET
Revision dcf405fdabf79d23aadd9e75920a6e3ad01f73cd by kainz.a: (update 22px mime 
(finalize))
  change: edit icons/mimetypes/22/x-office-presentation.svg
  change: edit 
icons-dark/mimetypes/22/application-vnd.ms-powerpoint.template.macroenabled.12.svg
  change: edit icons/mimetypes/22/application-x-php.svg
  change: edit icons-dark/mimetypes/22/text-html.svg
  change: edit 
icons/mimetypes/22/application-vnd.oasis.opendocument.web-template.svg
  change: edit icons/mimetypes/22/application-zip.svg
  change: edit icons-dark/mimetypes/22/application-pgp-encrypted.svg
  change: edit icons/mimetypes/22/application-epub+zip.svg
  change: edit icons/mimetypes/22/application-x-macbinary.svg
  change: edit icons-dark/mimetypes/22/application-x-wmf.svg
  change: edit icons-dark/mimetypes/22/application-dicom.svg
  change: edit icons/mimetypes/22/image-x-vnd.trolltech.qpicture.svg
  change: edit icons-dark/mimetypes/22/application-vnd.ms-infopath.svg
  change: edit icons/mimetypes/22/application-x-python-bytecode.svg
  change: edit icons/mimetypes/22/application-vnd.ms-publisher.svg
  change: edit icons-dark/mimetypes/22/application-x-python-bytecode.svg
  change: edit icons/mimetypes/22/application-x-skg.svg
  change: edit icons-dark/mimetypes/22/application-x-bittorrent.svg
  change: edit icons-dark/mimetypes/22/x-office-spreadsheet.svg
  change: edit icons-dark/mimetypes/22/application-msoutlook.svg
  change: edit icons-dark/mimetypes/22/virtualbox-vmdk.svg
  change: edit icons-dark/mimetypes/22/application-zip.svg
  change: edit icons/mimetypes/22/image-x-tga.svg
  change: edit icons/mimetypes/22/application-x-skgc.svg
  change: edit icons-dark/mimetypes/22/x-office-address-book.svg
  change: edit icons/mimetypes/22/application-dicom.svg
  change: edit icons/mimetypes/22/application-ogg.svg
  change: edit icons/mimetypes/22/text-x-c++hdr.svg
  change: edit icons-dark/mimetypes/22/image-svg+xml-compressed.svg
  change: edit icons/mimetypes/22/application-pgp-encrypted.svg
  change: edit icons/mimetypes/22/package-x-generic.svg
  change: edit icons-dark/mimetypes/22/application-x-skgc.svg
  change: edit 
icons/mimetypes/22/application-vnd.ms-powerpoint.addin.macroenabled.12.svg
  change: edit 
icons/mimetypes/22/application-vnd.oasis.opendocument.presentation-template.svg
  change: edit icons/mimetypes/22/text-x-c++src.svg
  change: edit icons/mimetypes/22/text-html.svg
  change: edit icons-dark/mimetypes/22/application-x-cd-image.svg
  change: edit icons-dark/mimetypes/22/application-vnd.ms-publisher.svg
  change: edit icons/mimetypes/22/virtualbox-vmdk.svg
  change: edit icons/mimetypes/22/text-rtf.svg
  change: edit 
icons/mimetypes/22/application-vnd.oasis.opendocument.formula-template.svg
  change: edit icons/mimetypes/22/text-css.svg
  change: edit icons-dark/mimetypes/22/application-x-java-archive.svg
  change: edit icons-dark/mimetypes/22/application-x-bzip.svg
  change: edit icons/mimetypes/22/application-x-partial-download.svg
  change: edit icons-dark/mimetypes/22/text-xml.svg
  change: edit icons/mimetypes/22/text-rust.svg
  change: edit icons/mimetypes/22/android-package-archive.svg
  change: edit icons/mimetypes/22/application-x-executable.svg
  change: edit icons-dark/mimetypes/22/application-msword.svg
  change: edit icons/mimetypes/22/x-office-address-book.svg
  change: edit icons-dark/mimetypes/22/application-x-ms-dos-executable.svg
  change: edit icons-dark/mimetypes/22/application-vnd.visio.svg
  change: edit icons/mimetypes/22/application-vnd.ms-infopath.svg
  change: edit 
icons-dark/mimetypes/22/application-vnd.oasis.opendocument.presentation-template.svg
  change: edit icons/mimetypes/22/audio-x-wav.svg
  change: edit icons/mimetypes/22/application-x-ms-dos-executable.svg
  change: edit icons-dark/mimetypes/22/android-package-archive.svg
  change: edit 
icons/mimetypes/22/application-vnd.oasis.opendocument.text-template.svg
  change: edit icons-dark/mimetypes/22/application-x-apple-diskimage.svg
  change: edit icons-dark/mimetypes/22/text-css.svg
  change: edit icons-dark/mimetypes/22/application-x-php.svg
  change: edit icons-dark/mimetypes/22/image-x-generic.svg
  change: edit icons-dark/mimetypes/22/application-x-zerosize.svg
  change: edit icons-dark/mimetypes/22/application-x-executable.svg
  change: edit icons-dark/mimetypes/22/application-x-cda.svg
  change: edit 
icons/mimetypes/22/application-vnd.ms-powerpoint.template.macroenabled.12.svg
  change: edit icons-dark/mimetypes/22/image-x-tga.svg
  change: edit icons/mimetypes/22/application-vnd.oasis.opendocument.formula.svg
  change: edit icons/mimetypes/22/application-x-java-archive.svg
  change: edit icons-dark/mimetypes/22/text-x-csrc.svg
  change: edit 

Re: sleeper design bug in the installation layout due to assumptions about filesystem case sensitivity

[Albert Astals Cid]

El divendres, 30 de setembre de 2016, a les 11:05:19 CEST, René J.V. Bertin va 
escriure:
> Hello,
> 
> I think I've tried to raise some awareness about this already in the past.
> The issue has come up again among KDE/Mac users, and this time I decided to
> file a ticket on BKO. Finding the right category wasn't trivial, so I
> picked what seemed the best compromise and relay it here:
> 
> https://bugs.kde.org/show_bug.cgi?id=369554
> 
> I don't really know how invasive it would be to address this issue properly,
> or rather, how to fix this without being overly invasive. Looking at
> KPeople I see
> 
> /opt/local/include/KF5/KPeople/KPeople/Widgets/Actions
> /opt/local/include/KF5/KPeople/kpeople/widgets/actions.h
> 
> which means that on a case-insensitive-but-preserving FS (HFS, NTFS) you can
> end up with 4 different situations:
> 
> /opt/local/include/KF5/KPeople/kpeople/widgets/{Actions,actions.h}
> /opt/local/include/KF5/KPeople/KPeople/widgets/{Actions,actions.h}
> /opt/local/include/KF5/KPeople/kpeople/Widgets/{Actions,actions.h}
> /opt/local/include/KF5/KPeople/KPeople/Widgets/{Actions,actions.h}
> 
> and that's presuming that the case preservations works reliably. Transfer
> such a tree via a FAT32 thumbdrive and all bets are off. 

Why would you do that? 

Honestly I think you're trying to fix a corner case that noone is really 
facing.

Cheers,
  Albert

> Evidently that's
> less likely to happen with a headerfile directory (and just shouldn't be
> done) but I'm concerned that the underlying implicit assumption about the
> FS has been made elsewhere too. And as I note in the ticket: Mac OS app
> bundles should support being transferred to and from case-insensitive
> volumes and still be usable on a case-sensitive volume (idem for KF5
> framework bundles if they ever see the light).
> 
> The most straightforward fix would be to use only CamelCase OR lowercase
> header directories, i.e. one of
> /opt/local/include/KF5/KPeople/kpeople/widgets/{Actions,actions.h}
> /opt/local/include/KF5/KPeople/KPeople/Widgets/{Actions,actions.h}
> 
> This is also what Qt5 does, and one can presume they have seen a lot more
> testing of this approach on many more platforms. NB: one could create the
> appropriate symlinks when installing to a case-sensitive FS, but evidently
> that makes it impossible to copy the result to a case-insensitive FS.
> 
> I realise that doing this is an invasive change that requires patching lots
> of dependent code, and even if those patches could be generated
> automatically the patched code would then no longer build against older
> versions of the frameworks. Still, it'd be an almost perfect way to force
> people to look for other places where the assumption about FS
> case-sensitivity could lead to problems.
> 
> R

Jenkins-kde-ci: breeze-icons master kf5-qt5 » Linux,gcc - Build # 320 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/breeze-icons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/320/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 30 Sep 2016 20:44:59 +
Build duration: 3 min 46 sec

CHANGE SET
Revision f7ab0d2a44af595f2f1ff27483d5643201e94f96 by alessandro.longo: (Update 
for mimetypes colors)
  change: edit icons/mimetypes/32/application-certificate.svg
  change: edit icons/mimetypes/32/image-x-psd.svg
  change: edit icons/mimetypes/32/image-x-ico.svg


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 
test(s)Failed: TestSuite.dupe

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 105/132 
(80%)CONDITIONAL 46/78 (59%)

By packages
  
default>
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 42/57 (74%)CONDITIONAL 
14/26 (54%)
autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 63/75 (84%)CONDITIONAL 
32/52 (62%)

Jenkins-kde-ci: breeze-icons master stable-kf5-qt5 » Linux,gcc - Build # 317 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/breeze-icons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/317/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 30 Sep 2016 20:44:59 +
Build duration: 2 min 41 sec

CHANGE SET
Revision f7ab0d2a44af595f2f1ff27483d5643201e94f96 by alessandro.longo: (Update 
for mimetypes colors)
  change: edit icons/mimetypes/32/application-certificate.svg
  change: edit icons/mimetypes/32/image-x-ico.svg
  change: edit icons/mimetypes/32/image-x-psd.svg


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 
test(s)Failed: TestSuite.dupe

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 105/132 
(80%)CONDITIONAL 46/78 (59%)

By packages
  
default>
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 42/57 (74%)CONDITIONAL 
14/26 (54%)
autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 63/75 (84%)CONDITIONAL 
32/52 (62%)

Jenkins-kde-ci: breeze-icons master kf5-qt5 » Linux,gcc - Build # 319 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/breeze-icons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/319/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 30 Sep 2016 20:22:38 +
Build duration: 4 min 58 sec

CHANGE SET
Revision 5a4bbdf1c83d3279a240c0ed653a9b4fc75e5509 by alessandro.longo: (Update 
for mimetypes colors)
  change: edit icons/mimetypes/64/text-x-scala.svg
  change: edit icons/mimetypes/64/application-x-python-bytecode.svg
  change: edit icons/mimetypes/64/application-x-m4.svg
  change: edit icons/mimetypes/64/x-office-address-book.svg
  change: edit icons/mimetypes/64/text-x-hex.svg
  change: edit icons/mimetypes/64/text-x-po.svg
  change: edit icons/mimetypes/64/text-x-rpm-spec.svg
  change: edit icons/mimetypes/64/text-x-csharp.svg
  change: edit icons/mimetypes/64/text-x-haskell.svg
  change: edit icons/mimetypes/64/text-x-apport.svg
  change: edit icons/mimetypes/64/text-x-patch.svg
  change: edit icons/mimetypes/64/application-x-theme.svg
  change: edit icons/mimetypes/64/x-kde-nsplugin-generated.svg
  change: edit icons/mimetypes/64/application-vnd.iccprofile.svg
  change: edit icons/mimetypes/64/application-vnd.ms-publisher.svg
  change: edit icons/mimetypes/64/text-x-authors.svg
  change: edit icons/mimetypes/64/x-office-calendar.svg
  change: edit icons/mimetypes/64/text-x-tcl.svg


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 
test(s)Failed: TestSuite.dupe

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 105/132 
(80%)CONDITIONAL 46/78 (59%)

By packages
  
default>
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 42/57 (74%)CONDITIONAL 
14/26 (54%)
autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 63/75 (84%)CONDITIONAL 
32/52 (62%)

Jenkins-kde-ci: breeze-icons master stable-kf5-qt5 » Linux,gcc - Build # 316 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/breeze-icons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/316/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 30 Sep 2016 20:22:38 +
Build duration: 5 min 7 sec

CHANGE SET
Revision 5a4bbdf1c83d3279a240c0ed653a9b4fc75e5509 by alessandro.longo: (Update 
for mimetypes colors)
  change: edit icons/mimetypes/64/x-office-address-book.svg
  change: edit icons/mimetypes/64/text-x-tcl.svg
  change: edit icons/mimetypes/64/text-x-po.svg
  change: edit icons/mimetypes/64/x-kde-nsplugin-generated.svg
  change: edit icons/mimetypes/64/text-x-rpm-spec.svg
  change: edit icons/mimetypes/64/text-x-csharp.svg
  change: edit icons/mimetypes/64/x-office-calendar.svg
  change: edit icons/mimetypes/64/text-x-authors.svg
  change: edit icons/mimetypes/64/application-x-python-bytecode.svg
  change: edit icons/mimetypes/64/application-x-theme.svg
  change: edit icons/mimetypes/64/text-x-hex.svg
  change: edit icons/mimetypes/64/application-x-m4.svg
  change: edit icons/mimetypes/64/text-x-haskell.svg
  change: edit icons/mimetypes/64/text-x-scala.svg
  change: edit icons/mimetypes/64/application-vnd.ms-publisher.svg
  change: edit icons/mimetypes/64/application-vnd.iccprofile.svg
  change: edit icons/mimetypes/64/text-x-apport.svg
  change: edit icons/mimetypes/64/text-x-patch.svg


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 
test(s)Failed: TestSuite.dupe

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 105/132 
(80%)CONDITIONAL 46/78 (59%)

By packages
  
default>
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 42/57 (74%)CONDITIONAL 
14/26 (54%)
autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 63/75 (84%)CONDITIONAL 
32/52 (62%)

baloo metadata scrapers

[Martin Bednar]

Hi,

having very fond memories of the potential I saw in the tvshows:// 
experimental kioslave (from the days of nepomuk), so I was left wondering 
whether something like that would be possible with baloo.

I currently have a working scraper (currently for movies, tvshows should be 
easy to tack on) and am wondering if there is a way to use baloo to store the 
metadata. I read a bit about baloo on api.kde.org, but am not able to find any 
indication how (if) such a project would be feasible.

Thanks,

Martin.


-- 
Why top posting?
Why are forums read from top to bottom?

Jenkins-kde-ci: breeze-icons master stable-kf5-qt5 » Linux,gcc - Build # 315 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/breeze-icons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/315/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 30 Sep 2016 19:36:38 +
Build duration: 5 min 24 sec

CHANGE SET
Revision 5b264b7b04c9da771b1a8634de92b346f024cdb7 by alessandro.longo: (Update 
for mimetypes colors)
  change: edit icons/mimetypes/64/text-rust.svg
  change: edit icons/mimetypes/64/x-media-podcast.svg
  change: edit icons/mimetypes/64/message-rfc822.svg
  change: edit icons/mimetypes/64/text-x-texinfo.svg
  change: edit icons/mimetypes/64/text-x-tex.svg
  change: edit icons/mimetypes/64/text-x-authors.svg
  change: edit icons/mimetypes/64/text-x-qml.svg
  change: edit icons/mimetypes/64/text-x-pascal.svg


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 
test(s)Failed: TestSuite.dupe

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 105/132 
(80%)CONDITIONAL 46/78 (59%)

By packages
  
default>
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 42/57 (74%)CONDITIONAL 
14/26 (54%)
autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 63/75 (84%)CONDITIONAL 
32/52 (62%)

Jenkins-kde-ci: breeze-icons master kf5-qt5 » Linux,gcc - Build # 318 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/breeze-icons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/318/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 30 Sep 2016 19:36:38 +
Build duration: 5 min 26 sec

CHANGE SET
Revision 5b264b7b04c9da771b1a8634de92b346f024cdb7 by alessandro.longo: (Update 
for mimetypes colors)
  change: edit icons/mimetypes/64/text-x-pascal.svg
  change: edit icons/mimetypes/64/text-x-qml.svg
  change: edit icons/mimetypes/64/text-x-texinfo.svg
  change: edit icons/mimetypes/64/message-rfc822.svg
  change: edit icons/mimetypes/64/text-x-tex.svg
  change: edit icons/mimetypes/64/x-media-podcast.svg
  change: edit icons/mimetypes/64/text-rust.svg
  change: edit icons/mimetypes/64/text-x-authors.svg


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 
test(s)Failed: TestSuite.dupe

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 105/132 
(80%)CONDITIONAL 46/78 (59%)

By packages
  
default>
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 42/57 (74%)CONDITIONAL 
14/26 (54%)
autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 63/75 (84%)CONDITIONAL 
32/52 (62%)

Jenkins-kde-ci: breeze-icons master kf5-qt5 » Linux,gcc - Build # 317 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/breeze-icons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/317/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 30 Sep 2016 19:01:12 +
Build duration: 5 min 12 sec

CHANGE SET
Revision 28dcc0a9d65fd1ea4c228b806b7e90dc22003434 by alessandro.longo: (Update 
for mimetypes colors)
  change: edit icons/mimetypes/64/application-x-srt.svg
  change: edit icons/mimetypes/64/application-x-designer.svg
  change: edit icons/mimetypes/64/application-x-kvtml.svg
  change: edit icons/mimetypes/64/audio-midi.svg
  change: edit icons/mimetypes/64/application-postscript.svg
  change: edit icons/mimetypes/64/image-x-ico.svg
  change: edit icons/mimetypes/64/application-x-font-type1.svg
  change: edit icons/mimetypes/64/image-vnd.djvu.svg
  change: edit icons/mimetypes/64/application-x-kplato.svg
  change: edit icons/mimetypes/64/application-x-trash.svg
  change: edit icons/mimetypes/64/application-vnd.iccprofile.svg
  change: edit icons/mimetypes/64/application-x-ms-shortcut.svg
  change: edit icons/mimetypes/64/image-x-psd.svg
  change: edit icons/mimetypes/64/image-vnd.dgn.svg
  change: edit icons/mimetypes/64/application-xmind.svg
  change: edit icons/mimetypes/64/application-x-font-ttf.svg
  change: edit icons/mimetypes/64/application-vnd.ms-infopath.svg
  change: edit icons/mimetypes/64/application-x-lyx.svg
  change: edit icons/mimetypes/64/application-x-xliff.svg
  change: edit icons/mimetypes/64/application-x-font-otf.svg
  change: edit icons/mimetypes/64/application-x-font-bdf.svg
  change: edit icons/mimetypes/64/application-x-plasma.svg
  change: edit icons/mimetypes/64/application-vnd.ms-access.svg
  change: edit icons/mimetypes/64/application-x-python-bytecode.svg
  change: edit icons/mimetypes/64/application-x-perl.svg
  change: edit icons/mimetypes/64/image-x-adobe-dng.svg
  change: edit icons/mimetypes/64/x-office-contact.svg
  change: edit icons/mimetypes/64/application-x-font-afm.svg
  change: edit icons/mimetypes/64/application-pgp-signature.svg


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 
test(s)Failed: TestSuite.dupe

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 105/132 
(80%)CONDITIONAL 46/78 (59%)

By packages
  
default>
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 42/57 (74%)CONDITIONAL 
14/26 (54%)
autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 63/75 (84%)CONDITIONAL 
32/52 (62%)

Jenkins-kde-ci: breeze-icons master stable-kf5-qt5 » Linux,gcc - Build # 314 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/breeze-icons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/314/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 30 Sep 2016 19:01:12 +
Build duration: 5 min 19 sec

CHANGE SET
Revision 28dcc0a9d65fd1ea4c228b806b7e90dc22003434 by alessandro.longo: (Update 
for mimetypes colors)
  change: edit icons/mimetypes/64/application-x-ms-shortcut.svg
  change: edit icons/mimetypes/64/audio-midi.svg
  change: edit icons/mimetypes/64/application-x-designer.svg
  change: edit icons/mimetypes/64/application-x-kplato.svg
  change: edit icons/mimetypes/64/application-x-python-bytecode.svg
  change: edit icons/mimetypes/64/application-x-srt.svg
  change: edit icons/mimetypes/64/application-vnd.ms-infopath.svg
  change: edit icons/mimetypes/64/application-x-lyx.svg
  change: edit icons/mimetypes/64/image-x-ico.svg
  change: edit icons/mimetypes/64/application-xmind.svg
  change: edit icons/mimetypes/64/application-x-font-ttf.svg
  change: edit icons/mimetypes/64/application-vnd.iccprofile.svg
  change: edit icons/mimetypes/64/image-vnd.dgn.svg
  change: edit icons/mimetypes/64/application-x-font-bdf.svg
  change: edit icons/mimetypes/64/image-vnd.djvu.svg
  change: edit icons/mimetypes/64/image-x-psd.svg
  change: edit icons/mimetypes/64/image-x-adobe-dng.svg
  change: edit icons/mimetypes/64/application-x-font-type1.svg
  change: edit icons/mimetypes/64/x-office-contact.svg
  change: edit icons/mimetypes/64/application-x-kvtml.svg
  change: edit icons/mimetypes/64/application-x-font-otf.svg
  change: edit icons/mimetypes/64/application-x-font-afm.svg
  change: edit icons/mimetypes/64/application-postscript.svg
  change: edit icons/mimetypes/64/application-pgp-signature.svg
  change: edit icons/mimetypes/64/application-x-xliff.svg
  change: edit icons/mimetypes/64/application-vnd.ms-access.svg
  change: edit icons/mimetypes/64/application-x-plasma.svg
  change: edit icons/mimetypes/64/application-x-perl.svg
  change: edit icons/mimetypes/64/application-x-trash.svg


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 
test(s)Failed: TestSuite.dupe

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 105/132 
(80%)CONDITIONAL 46/78 (59%)

By packages
  
default>
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 42/57 (74%)CONDITIONAL 
14/26 (54%)
autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 63/75 (84%)CONDITIONAL 
32/52 (62%)

Re: Review Request/New Framework: KF5::SyntaxHighlighting

[Scarlett Clark]

On Fri, Sep 30, 2016 at 10:32 AM, Volker Krause  wrote:

> Thanks!
>
> On Friday 30 September 2016 10:08:27 David Faure wrote:
> > On samedi 10 septembre 2016 17:47:00 CEST Volker Krause wrote:
> > > Hi,
> > >
> > > please review KF5::SyntaxHighlighting (syntax-highlighting in Git) for
> > > becoming a framework :)
> >
> > Looks good. I found a few things though.
> >
> > I see that a Jenkins job exists, but it's missing from this view
> > https://build.kde.org/view/Frameworks%20kf5-qt5/
>
> Is that something I can do directly, or is this done via a ticket for the
> CI?
>

This is now fixed.
Cheers,
Scarlett


>
> > Fully missing API docs in :
> >   DefinitionDownloader
> >   HtmlHighlighter
>
> Both are not installed, they are only exported for the CLI tool.
>
> > Also seen in HtmlHighlighter:
> > void setOutputFile(FILE *fileHandle);
> > Shouldn't this use QFile or QIODevice instead?
> > Or QTextStream, looking at the implementation.
>
> Possible, the reason for this was supporting output to stdout in the CLI
> tool.
> But as mentioned above, this is not installed/public API anway.
>
> > I'm also concerned that this class has direct member vars rather than a d
> > pointer.
> >
> > SyntaxHighligher: missing API docs on methods; missing d pointer.
>
> The d pointer is in the base class already, so I don't think we need
> another
> one here, do we?
>
> > Once these issues are solved you can set the release flag to true in the
> > yaml file, from my point of view.
>
> Regards,
> Volker

Re: Review Request/New Framework: KF5::SyntaxHighlighting

[Volker Krause]

Thanks!

On Friday 30 September 2016 10:08:27 David Faure wrote:
> On samedi 10 septembre 2016 17:47:00 CEST Volker Krause wrote:
> > Hi,
> > 
> > please review KF5::SyntaxHighlighting (syntax-highlighting in Git) for
> > becoming a framework :)
> 
> Looks good. I found a few things though.
> 
> I see that a Jenkins job exists, but it's missing from this view
> https://build.kde.org/view/Frameworks%20kf5-qt5/

Is that something I can do directly, or is this done via a ticket for the CI?

> Fully missing API docs in :
>   DefinitionDownloader
>   HtmlHighlighter

Both are not installed, they are only exported for the CLI tool.

> Also seen in HtmlHighlighter:
> void setOutputFile(FILE *fileHandle);
> Shouldn't this use QFile or QIODevice instead?
> Or QTextStream, looking at the implementation.

Possible, the reason for this was supporting output to stdout in the CLI tool. 
But as mentioned above, this is not installed/public API anway.

> I'm also concerned that this class has direct member vars rather than a d
> pointer.
>
> SyntaxHighligher: missing API docs on methods; missing d pointer.

The d pointer is in the base class already, so I don't think we need another 
one here, do we?

> Once these issues are solved you can set the release flag to true in the
> yaml file, from my point of view.

Regards,
Volker

signature.asc
Description: This is a digitally signed message part.

Jenkins-kde-ci: breeze-icons master stable-kf5-qt5 » Linux,gcc - Build # 313 - Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/breeze-icons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/313/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 30 Sep 2016 17:09:40 +
Build duration: 3 min 55 sec

CHANGE SET
Revision ebb9d403278f7fa815f174fcbe9dc75472f0b39c by alessandro.longo: (Update 
for mimetypes colors)
  change: edit icons/mimetypes/64/application-x-font-afm.svg
  change: edit icons/mimetypes/64/application-certificate.svg
  change: edit icons/mimetypes/32/x-office-drawing.svg
  change: edit icons/mimetypes/64/x-office-drawing.svg
  change: edit icons/mimetypes/64/application-msoutlook.svg
  change: edit icons/mimetypes/64/application-octet-stream.svg
  change: edit icons/mimetypes/64/application-dicom.svg
  change: edit icons/mimetypes/22/x-office-drawing.svg
  change: edit icons/mimetypes/64/application-msonenote.svg
  change: edit icons/mimetypes/16/x-office-drawing.svg


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 
test(s)Failed: TestSuite.dupe

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 105/132 
(80%)CONDITIONAL 46/78 (59%)

By packages
  
default>
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 42/57 (74%)CONDITIONAL 
14/26 (54%)
autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 63/75 (84%)CONDITIONAL 
32/52 (62%)

Jenkins-kde-ci: breeze-icons master kf5-qt5 » Linux,gcc - Build # 316 - Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/breeze-icons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/316/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 30 Sep 2016 17:09:39 +
Build duration: 2 min 15 sec

CHANGE SET
Revision ebb9d403278f7fa815f174fcbe9dc75472f0b39c by alessandro.longo: (Update 
for mimetypes colors)
  change: edit icons/mimetypes/64/x-office-drawing.svg
  change: edit icons/mimetypes/64/application-msoutlook.svg
  change: edit icons/mimetypes/64/application-msonenote.svg
  change: edit icons/mimetypes/64/application-dicom.svg
  change: edit icons/mimetypes/64/application-x-font-afm.svg
  change: edit icons/mimetypes/64/application-certificate.svg
  change: edit icons/mimetypes/64/application-octet-stream.svg
  change: edit icons/mimetypes/22/x-office-drawing.svg
  change: edit icons/mimetypes/16/x-office-drawing.svg
  change: edit icons/mimetypes/32/x-office-drawing.svg


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 
test(s)Failed: TestSuite.dupe

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 105/132 
(80%)CONDITIONAL 46/78 (59%)

By packages
  
default>
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 42/57 (74%)CONDITIONAL 
14/26 (54%)
autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 63/75 (84%)CONDITIONAL 
32/52 (62%)

Re: Review Request 127822: address the potential name/case clash of the Attica/Attica and Attica/attica header dirs

[René J . V . Bertin]

> On May 11, 2016, 4:05 p.m., René J.V. Bertin wrote:
> > src/CMakeLists.txt, lines 160-163
> > 
> >
> > This change is problematic, and apparently needs to be 
> > platform-specific (if done here):
> > 
> > - on OS X it works as intended, despite the fact one should use 
> > `INCLUDES DESTINATION` instead of `INCLUDES` alone
> > - on Linux, it adds an additional path to the search path 
> > ($PREFIX/INCLUDES), which raises an error if inexistent. The intended 
> > behaviour is obtained by removing the `INCLUDES` keyword.
> > 
> > This is probably because of this extract from 
> > `ECM/KDEInstallDirs.cmake`:
> > 
> > ```
> > set(KF5_INSTALL_TARGETS_DEFAULT_ARGS  RUNTIME DESTINATION 
> > "${CMAKE_INSTALL_BINDIR}"
> >   LIBRARY DESTINATION 
> > "${CMAKE_INSTALL_LIBDIR}"
> >   ARCHIVE DESTINATION 
> > "${CMAKE_INSTALL_LIBDIR}" COMPONENT Devel
> >   INCLUDES DESTINATION 
> > "${CMAKE_INSTALL_INCLUDEDIR_KF5}"
> > )
> > 
> > # on the Mac support an extra install directory for application bundles
> > if(APPLE)
> > set(KDE_INSTALL_TARGETS_DEFAULT_ARGS  
> > ${KDE_INSTALL_TARGETS_DEFAULT_ARGS}
> >   BUNDLE DESTINATION 
> > "${BUNDLE_INSTALL_DIR}" )
> > set(KF5_INSTALL_TARGETS_DEFAULT_ARGS  
> > ${KF5_INSTALL_TARGETS_DEFAULT_ARGS}
> >   BUNDLE DESTINATION 
> > "${BUNDLE_INSTALL_DIR}" )
> > endif()
> > ```
> > 
> > IOW, it *may* be that OS X ("APPLE") requires a dedicated change to 
> > `src/CMakelists.txt`, or else there'd be special cases for OS X, MSWin and 
> > the default (anything that always has a case-sensitive platform).
> > 
> > I don't see an alternative, except possibly at the level of 
> > `CMAKE_INSTALL_INCLUDEDIR_KF5`, but I cannot find where that variable is 
> > defined.

I realise that the above comment isn't very clear. First: the INSTALL() 
documentation instructs to use `INCLUDES DESTINATION` while what works (on Mac 
OS) is to use `INCLUDES` alone, as written in the patch. Why is unclear to me.

The difference with Linux becomes clear when we look at 
`KF5_INSTALL_TARGETS_DEFAULT_ARGS`:
- Linux : 
`RUNTIME;DESTINATION;bin;LIBRARY;DESTINATION;lib/x86_64-linux-gnu;ARCHIVE;DESTINATION;lib/x86_64-linux-gnu;COMPONENT;Devel;INCLUDES;DESTINATION;include/KF5`
- OS X : 
`RUNTIME;DESTINATION;bin;LIBRARY;DESTINATION;lib;ARCHIVE;DESTINATION;lib;COMPONENT;Devel;INCLUDES;DESTINATION;include/KF5;BUNDLE;DESTINATION;/Applications/MacPorts/KF5`

IOW, on Linux the additional path can be appended directly to the preexisting 
`INCLUDES DESTINATION`, whereas on OS X there are additional elements in the 
list which make that impossible. 

I tried adding the `BUNDLE DESTINATION` to `KF5_INSTALL_TARGETS_DEFAULT_ARGS` 
unconditionally and that makes the attached patch work as expected on Linux too.

Of course it would be more elegant to have a macro to modify 
`KF5_INSTALL_TARGETS_DEFAULT_ARGS` and add additional paths to `INCLUDES 
DESTINATION`.

Or some other method to add elements to the `INTERFACE_INCLUDE_DIRECTORIES` 
variable defined by the frameworks' `KF5*Targets.cmake` module.


- René J.V.


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127822/#review95384
---


On May 3, 2016, 3:29 p.m., René J.V. Bertin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127822/
> ---
> 
> (Updated May 3, 2016, 3:29 p.m.)
> 
> 
> Review request for Build System, KDE Software on Mac OS X and KDE Frameworks.
> 
> 
> Repository: attica
> 
> 
> Description
> ---
> 
> Attica has long adhered to an install layout that relies on case to 
> distinguish directories. For instance:
> 
> ```
> include/KF5/Attica/Attica/AccountBalance
> include/KF5/Attica/attica/accountbalance.h
> ```
> 
> Depending on the order in which those files are installed on a FS like HFS+ 
> (in case-insensitive-but-case-preserving mode), you will end up with 
> `Attica/Attica` or `Attica/attica` directories; the directory name case 
> changes to reflect the last write.
> 
> Basic calls like fopen() will succeed regardless of case because the 
> filesystem ignores case in such operations. However, compilers (clang at 
> least) do not simply try to open a requested include file in each element of 
> the header directory search path. They use a search algorithm to locate the 
> file first ... and that algorithm takes case into account. So `#include 
> ` 

Re: Review Request 127822: address the potential name/case clash of the Attica/Attica and Attica/attica header dirs

[René J . V . Bertin]

> On May 3, 2016, 2:42 p.m., Aleix Pol Gonzalez wrote:
> > Is this specific to Attica or it will happen on other frameworks? I have a 
> > memory of having such an issue worked on at some point.
> 
> René J.V. Bertin wrote:
> Hah...
> 
> The principal applies universally of course, to all filesystems that will 
> silently accept to replace an existing directory entry with another one of 
> the same type that differs only in name case.
> 
> I was going to reply that I'd only seen the issue express itself with 
> attica (and in bug reports only; I use a case-sensitive HFS partition for 
> development). But a quick check shows that Solid and Sonnet follow the same 
> unreliable install layout, and they're not exactly alone:
> 
> ``` > find /opt/local/include/KF5/ -mindepth 2 -maxdepth 2 -a -type d
> /opt/local/include/KF5/KDNSSD/dnssd
> /opt/local/include/KF5/KDNSSD/DNSSD
> /opt/local/include/KF5/BalooWidgets/baloo
> /opt/local/include/KF5/BalooWidgets/Baloo
> /opt/local/include/KF5/Attica/attica
> /opt/local/include/KF5/Attica/Attica
> /opt/local/include/KF5/KIOGui/KIO
> /opt/local/include/KF5/KIOGui/kio
> /opt/local/include/KF5/Solid/solid
> /opt/local/include/KF5/Solid/Solid
> /opt/local/include/KF5/KUnitConversion/KUnitConversion
> /opt/local/include/KF5/KUnitConversion/kunitconversion
> /opt/local/include/KF5/KIOWidgets/KIO
> /opt/local/include/KF5/KIOWidgets/kio
> /opt/local/include/KF5/KDeclarative/QuickAddons
> /opt/local/include/KF5/KDeclarative/quickaddons
> /opt/local/include/KF5/KDeclarative/kdeclarative
> /opt/local/include/KF5/KDeclarative/calendarevents
> /opt/local/include/KF5/KDeclarative/KQuickAddons
> /opt/local/include/KF5/KDeclarative/KDeclarative
> /opt/local/include/KF5/KDeclarative/CalendarEvents
> /opt/local/include/KF5/KDeclarative/kquickaddons
> /opt/local/include/KF5/KNewStuff3/KNS3
> /opt/local/include/KF5/KNewStuff3/kns3
> /opt/local/include/KF5/KPackage/KPackage
> /opt/local/include/KF5/KPackage/kpackage
> /opt/local/include/KF5/KXmlRpcClient/KXmlRpcClient
> /opt/local/include/KF5/KXmlRpcClient/kxmlrpcclient
> /opt/local/include/KF5/ThreadWeaver/ThreadWeaver
> /opt/local/include/KF5/ThreadWeaver/threadweaver
> /opt/local/include/KF5/KExiv2/kexiv2
> /opt/local/include/KF5/KExiv2/KExiv2
> /opt/local/include/KF5/SonnetUi/sonnet
> /opt/local/include/KF5/SonnetUi/Sonnet
> /opt/local/include/KF5/KActivities/KActivities
> /opt/local/include/KF5/KActivities/kactivities
> /opt/local/include/KF5/KIOCore/kio
> /opt/local/include/KF5/KIOCore/KIO
> /opt/local/include/KF5/SonnetCore/sonnet
> /opt/local/include/KF5/SonnetCore/Sonnet
> /opt/local/include/KF5/KParts/KParts
> /opt/local/include/KF5/KParts/kparts
> /opt/local/include/KF5/purpose/purpose
> /opt/local/include/KF5/purpose/Purpose
> /opt/local/include/KF5/Baloo/baloo
> /opt/local/include/KF5/Baloo/Baloo
> /opt/local/include/KF5/KRunner/KRunner
> /opt/local/include/KF5/KRunner/krunner
> /opt/local/include/KF5/KFileMetaData/kfilemetadata
> /opt/local/include/KF5/KFileMetaData/KFileMetaData
> /opt/local/include/KF5/KTextEditor/KTextEditor
> /opt/local/include/KF5/KTextEditor/ktexteditor
> /opt/local/include/KF5/KDESu/KDESu
> /opt/local/include/KF5/KDESu/kdesu
> /opt/local/include/KF5/KPeople/kpeoplebackend
> /opt/local/include/KF5/KPeople/KPeople
> /opt/local/include/KF5/KPeople/kpeople
> /opt/local/include/KF5/KPeople/KPeopleBackend
> /opt/local/include/KF5/purposewidgets/PurposeWidgets
> /opt/local/include/KF5/purposewidgets/purposewidgets
> ```
> 
> I started a topic on the KDE-Frameworks ML ("case in filenames"), this RR 
> is a result of that.
> Maybe a general solution should be discussed on there before I or anyone 
> else starts patching all those frameworks, esp. if I'm not the only one who's 
> run into it.
> 
> Maybe it'd be possible to wrap the "CamelCase" logic in ECM? Attica's 
> build system was easy enough to patch; I doubt things will be so trivial in 
> all cases.

FYI:
https://bugs.kde.org/show_bug.cgi?id=369554


- René J.V.


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127822/#review95135
---


On May 3, 2016, 3:29 p.m., René J.V. Bertin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127822/
> ---
> 
> (Updated May 3, 2016, 3:29 p.m.)
> 
> 
> Review request for Build System, KDE Software on Mac OS X and KDE Frameworks.
> 
> 
> Repository: attica
> 
> 
> Description
> ---
> 
> Attica 

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 120 - Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/120/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 30 Sep 2016 11:30:17 +
Build duration: 1 min 50 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.kservicetest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5463/7983 
(68%)CONDITIONAL 2953/6138 (48%)

By packages
  
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1442/1530 
(94%)CONDITIONAL 884/1768 (50%)
src.kbuildsycoca
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 
15/20 (75%)
src.kdeinit
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 
(0%)
src.plugin
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 
36/96 (38%)
src.services
FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1761/3042 
(58%)CONDITIONAL 757/1888 (40%)
src.sycoca
FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2044/2798 
(73%)CONDITIONAL 1227/2054 (60%)
tests.pluginlocator
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 
34/50 (68%)

sleeper design bug in the installation layout due to assumptions about filesystem case sensitivity

[René J . V . Bertin]

Hello,

I think I've tried to raise some awareness about this already in the past. The 
issue has come up again among KDE/Mac users, and this time I decided to file a 
ticket on BKO. Finding the right category wasn't trivial, so I picked what 
seemed the best compromise and relay it here:

https://bugs.kde.org/show_bug.cgi?id=369554

I don't really know how invasive it would be to address this issue properly, or 
rather, how to fix this without being overly invasive. Looking at KPeople I see

/opt/local/include/KF5/KPeople/KPeople/Widgets/Actions
/opt/local/include/KF5/KPeople/kpeople/widgets/actions.h

which means that on a case-insensitive-but-preserving FS (HFS, NTFS) you can 
end up with 4 different situations:

/opt/local/include/KF5/KPeople/kpeople/widgets/{Actions,actions.h}
/opt/local/include/KF5/KPeople/KPeople/widgets/{Actions,actions.h}
/opt/local/include/KF5/KPeople/kpeople/Widgets/{Actions,actions.h}
/opt/local/include/KF5/KPeople/KPeople/Widgets/{Actions,actions.h}

and that's presuming that the case preservations works reliably. Transfer such 
a tree via a FAT32 thumbdrive and all bets are off. Evidently that's less 
likely to happen with a headerfile directory (and just shouldn't be done) but 
I'm concerned that the underlying implicit assumption about the FS has been 
made elsewhere too. And as I note in the ticket: Mac OS app bundles should 
support being transferred to and from case-insensitive volumes and still be 
usable on a case-sensitive volume (idem for KF5 framework bundles if they ever 
see the light).

The most straightforward fix would be to use only CamelCase OR lowercase header 
directories, i.e. one of
/opt/local/include/KF5/KPeople/kpeople/widgets/{Actions,actions.h}
/opt/local/include/KF5/KPeople/KPeople/Widgets/{Actions,actions.h}

This is also what Qt5 does, and one can presume they have seen a lot more 
testing of this approach on many more platforms.
NB: one could create the appropriate symlinks when installing to a 
case-sensitive FS, but evidently that makes it impossible to copy the result to 
a case-insensitive FS.

I realise that doing this is an invasive change that requires patching lots of 
dependent code, and even if those patches could be generated automatically the 
patched code would then no longer build against older versions of the 
frameworks. Still, it'd be an almost perfect way to force people to look for 
other places where the assumption about FS case-sensitivity could lead to 
problems.

R

Re: kdereview

[Ben Cooksley]

On Fri, Sep 30, 2016 at 11:27 AM, Albert Astals Cid  wrote:
> El dimecres, 21 de setembre de 2016, a les 11:01:18 CEST, Allen Winter va
> escriure:
>> kwave is now moved to kdemultimedia.
>
> Why did that happen?

It was moved at the request of it's maintainer and Allen.

>
> Did i miss the emails to k-c-d about reviewing it?

I've just searched my mail - you didn't miss it. When the repository
was moved to KDE Review the Sysadmin ticket would have expressly
requested that the review process on kde-core-devel be started by the
maintainer now that we'd processed the move. It appears that didn't
happen.

Thoughts on what should be done in regards to KWave here?

>
> Cheers,
>   Albert

Cheers,
Ben

>
>> No response from anyone else.
>>
>> I suggest we remove bodega-client, kdev-perforce, kdots, kor and kpeg from
>> kde_projects.xml and virtually move them into scratch.
>>
>> On Sunday, September 18, 2016 12:08:41 PM Allen Winter wrote:
>> > Howdy,
>> >
>> > there's some stuff that's been in kdereview for a long time.
>> >
>> > according to kde_projects.xml, the kdereview programs are:
>> >   bodega-client (at least since Dec 2013)
>> >   kdev-perforce
>> >   kdots (at least since Nov 2015)
>> >   kor (at least since Oct 2014)
>> >   kpeg
>> >   kwave
>> >
>> > some of these (eg kwave) are actively developed.
>> >
>> > Can the owners of these please move them to a final location,
>> > clean them out, or let me know if they are really still under review?
>> >
>> > And by "move" I mean change their virtual location according to
>> > kde_projects or whatever "moving" means these days.
>> >
>> > -Allen
>
>

Re: Review Request 129042: Replace all blocking calls when initializing properties by just one blocking call to get them all

[Jan Grulich]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129042/
---

(Updated Sept. 30, 2016, 11:15 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, Network Management, Aleix Pol Gonzalez, and 
Lamarque Souza.


Changes
---

Submitted with commit 00acf17a2071d86e218d3d49a0e53157eaa265dd by Jan Grulich 
to branch master.


Repository: networkmanager-qt


Description
---

Uses "GetAll" method from o.f.DBus.Properties interface to get all properties 
at once, instead of initializing them one by one, which should significantly 
reduce number of blocking calls. Initialy I wanted to make this call 
asynchronous as well, but delayed initialization causes problems across the 
library so this is the easiest way how to do this.


Diffs
-

  src/accesspoint.cpp 60a284b 
  src/activeconnection.cpp 1b66fc5 
  src/activeconnection_p.h 60697e6 
  src/adsldevice.cpp 8f9bbff 
  src/bluetoothdevice.cpp eb839e0 
  src/bonddevice.cpp 6d1899f 
  src/bridgedevice.cpp 3c347af 
  src/device.cpp 57538eb 
  src/genericdevice.cpp 8f26617 
  src/gredevice.cpp c1a59c5 
  src/infinibanddevice.cpp 9bfa76f 
  src/macvlandevice.cpp 9b3c75f 
  src/manager.cpp d2f706e 
  src/manager_p.h 50c3c34 
  src/modemdevice.cpp 4bb4a23 
  src/olpcmeshdevice.cpp 6f1212d 
  src/settings.cpp 90e7267 
  src/teamdevice.cpp d07b145 
  src/tundevice.cpp 2a73012 
  src/vethdevice.cpp 77b48b4 
  src/vlandevice.cpp fdfa297 
  src/vpnconnection.cpp 5dee6fc 
  src/vpnconnection_p.h a8195ad 
  src/wimaxdevice.cpp 6118f2f 
  src/wireddevice.cpp 66bb649 
  src/wirelessdevice.cpp 3f2972b 

Diff: https://git.reviewboard.kde.org/r/129042/diff/


Testing
---


Thanks,

Jan Grulich

Re: Review Request/New Framework: KF5::SyntaxHighlighting

[David Faure]

On samedi 10 septembre 2016 17:47:00 CEST Volker Krause wrote:
> Hi,
> 
> please review KF5::SyntaxHighlighting (syntax-highlighting in Git) for
> becoming a framework :)

Looks good. I found a few things though.

I see that a Jenkins job exists, but it's missing from this view
https://build.kde.org/view/Frameworks%20kf5-qt5/

Fully missing API docs in :
  DefinitionDownloader
  HtmlHighlighter
  
Also seen in HtmlHighlighter:
void setOutputFile(FILE *fileHandle);
Shouldn't this use QFile or QIODevice instead?
Or QTextStream, looking at the implementation.
I'm also concerned that this class has direct member vars rather than a d 
pointer.

SyntaxHighligher: missing API docs on methods; missing d pointer.

Once these issues are solved you can set the release flag to true in the yaml 
file, from my point of view.

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

Jenkins-kde-ci: breeze-icons master kf5-qt5 » Linux,gcc - Build # 315 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/breeze-icons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/315/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 30 Sep 2016 07:59:41 +
Build duration: 2 min 14 sec

CHANGE SET
Revision 320a4171e44c78def7bf61b6d2e8482ae95058cb by kainz.a: (update 
x-office-drawing icon to the lo-drawing color)
  change: edit icons-dark/mimetypes/64/x-office-drawing.svg


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 98/132 
(74%)CONDITIONAL 40/78 (51%)

By packages
  
default>
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 42/57 (74%)CONDITIONAL 
14/26 (54%)
autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 56/75 (75%)CONDITIONAL 
26/52 (50%)

Jenkins-kde-ci: breeze-icons master kf5-qt5 » Linux,gcc - Build # 315 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/breeze-icons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/315/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 30 Sep 2016 07:59:41 +
Build duration: 2 min 14 sec

CHANGE SET
Revision 320a4171e44c78def7bf61b6d2e8482ae95058cb by kainz.a: (update 
x-office-drawing icon to the lo-drawing color)
  change: edit icons-dark/mimetypes/64/x-office-drawing.svg


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 98/132 
(74%)CONDITIONAL 40/78 (51%)

By packages
  
default>
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 42/57 (74%)CONDITIONAL 
14/26 (54%)
autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 56/75 (75%)CONDITIONAL 
26/52 (50%)

Jenkins-kde-ci: breeze-icons master stable-kf5-qt5 » Linux,gcc - Build # 312 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/breeze-icons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/312/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 30 Sep 2016 07:59:41 +
Build duration: 3 min 42 sec

CHANGE SET
Revision 320a4171e44c78def7bf61b6d2e8482ae95058cb by kainz.a: (update 
x-office-drawing icon to the lo-drawing color)
  change: edit icons-dark/mimetypes/64/x-office-drawing.svg


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 98/132 
(74%)CONDITIONAL 40/78 (51%)

By packages
  
default>
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 42/57 (74%)CONDITIONAL 
14/26 (54%)
autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 56/75 (75%)CONDITIONAL 
26/52 (50%)

Jenkins-kde-ci: breeze-icons master stable-kf5-qt5 » Linux,gcc - Build # 312 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/breeze-icons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/312/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 30 Sep 2016 07:59:41 +
Build duration: 3 min 42 sec

CHANGE SET
Revision 320a4171e44c78def7bf61b6d2e8482ae95058cb by kainz.a: (update 
x-office-drawing icon to the lo-drawing color)
  change: edit icons-dark/mimetypes/64/x-office-drawing.svg


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 98/132 
(74%)CONDITIONAL 40/78 (51%)

By packages
  
default>
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 42/57 (74%)CONDITIONAL 
14/26 (54%)
autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 56/75 (75%)CONDITIONAL 
26/52 (50%)

Jenkins-kde-ci: breeze-icons master stable-kf5-qt5 » Linux,gcc - Build # 311 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/breeze-icons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/311/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 30 Sep 2016 07:43:19 +
Build duration: 5 min 24 sec

CHANGE SET
Revision c1003c1fe9e2403491e8b892fceaad4e28f9f890 by kainz.a: (remove 
duplicates)
  change: edit icons/mimetypes/64/x-office-drawing.svg
  change: edit icons/mimetypes/32/x-office-drawing.svg
  change: delete icons/devices/22/transform-browse.svg
  change: edit icons/mimetypes/22/libreoffice-drawing.svg
  change: edit icons/mimetypes/16/libreoffice-drawing.svg
  change: edit icons-dark/mimetypes/16/libreoffice-drawing.svg
  change: edit icons/mimetypes/16/x-office-drawing.svg
  change: edit icons-dark/actions/32/archive-insert-directory.svg
  change: edit icons/mimetypes/22/x-office-drawing.svg
  change: edit icons-dark/actions/16/archive-insert-directory.svg
  change: edit icons-dark/actions/22/archive-insert-directory.svg
  change: edit icons-dark/mimetypes/16/x-office-drawing.svg
  change: edit icons-dark/actions/24/archive-insert-directory.svg


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 
test(s)Failed: TestSuite.dupe

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 105/132 
(80%)CONDITIONAL 45/78 (58%)

By packages
  
default>
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 42/57 (74%)CONDITIONAL 
14/26 (54%)
autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 63/75 (84%)CONDITIONAL 
31/52 (60%)

Jenkins-kde-ci: breeze-icons master kf5-qt5 » Linux,gcc - Build # 314 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/breeze-icons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/314/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 30 Sep 2016 07:43:19 +
Build duration: 2 min 15 sec

CHANGE SET
Revision c1003c1fe9e2403491e8b892fceaad4e28f9f890 by kainz.a: (remove 
duplicates)
  change: edit icons-dark/mimetypes/16/x-office-drawing.svg
  change: edit icons-dark/actions/22/archive-insert-directory.svg
  change: edit icons/mimetypes/32/x-office-drawing.svg
  change: edit icons/mimetypes/22/libreoffice-drawing.svg
  change: edit icons-dark/actions/16/archive-insert-directory.svg
  change: edit icons-dark/actions/24/archive-insert-directory.svg
  change: edit icons/mimetypes/16/x-office-drawing.svg
  change: delete icons/devices/22/transform-browse.svg
  change: edit icons-dark/actions/32/archive-insert-directory.svg
  change: edit icons/mimetypes/16/libreoffice-drawing.svg
  change: edit icons/mimetypes/64/x-office-drawing.svg
  change: edit icons/mimetypes/22/x-office-drawing.svg
  change: edit icons-dark/mimetypes/16/libreoffice-drawing.svg


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 
test(s)Failed: TestSuite.dupe

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 105/132 
(80%)CONDITIONAL 45/78 (58%)

By packages
  
default>
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 42/57 (74%)CONDITIONAL 
14/26 (54%)
autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 63/75 (84%)CONDITIONAL 
31/52 (60%)

Re: Shipping prison with next frameworks version

[David Faure]

On dimanche 18 septembre 2016 20:03:00 CEST Sune Vuorela wrote:
> Hi
> 
> Other than asking sysadmin to move prison from kdesupport to
> kdeframeworks, are there other bits I'm supposed to do?
> 
> I *think* I have followed the checklists.

I see no .yaml file in g...@git.kde.org:prison branch master.

I still see kdesupport/prison rather than frameworks/prison in 
kde_projects.xml

It's also missing on https://build.kde.org/view/Frameworks%20kf5-qt5/

No autotests ?

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

Jenkins-kde-ci: syntax-highlighting master stable-kf5-qt5 » Linux,gcc - Build # 1 - Successful!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/syntax-highlighting%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/1/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 30 Sep 2016 07:33:59 +
Build duration: 1 min 47 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 8 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 3/3 (100%)FILES 32/34 (94%)CLASSES 32/34 (94%)LINE 1867/2186 
(85%)CONDITIONAL 1407/2022 (70%)

By packages
  
autotests
FILES 7/7 (100%)CLASSES 7/7 (100%)LINE 386/392 (98%)CONDITIONAL 
226/400 (57%)
src.indexer
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 53/71 (75%)CONDITIONAL 
73/92 (79%)
src.lib
FILES 24/26 (92%)CLASSES 24/26 (92%)LINE 1428/1723 
(83%)CONDITIONAL 1108/1530 (72%)

Jenkins-kde-ci: breeze-icons master kf5-qt5 » Linux,gcc - Build # 313 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/breeze-icons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/313/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 30 Sep 2016 07:14:29 +
Build duration: 3 min 39 sec

CHANGE SET
Revision 58913d5b95eb463b7dc168c4ec6e7927410de3f4 by kainz.a: (update some 
kstars icons BUG: 364981)
  change: edit icons/actions/22/kstars_deepsky.svg
  change: edit icons/actions/22/kstars_stars.svg
  change: edit icons/actions/22/kstars_supernovae.svg
  change: edit icons/actions/22/kstars_constellationart.svg
  change: edit icons/actions/22/kstars_planets.svg


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 
test(s)Failed: TestSuite.dupe

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 105/132 
(80%)CONDITIONAL 46/78 (59%)

By packages
  
default>
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 42/57 (74%)CONDITIONAL 
14/26 (54%)
autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 63/75 (84%)CONDITIONAL 
32/52 (62%)

Jenkins-kde-ci: breeze-icons master stable-kf5-qt5 » Linux,gcc - Build # 310 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/breeze-icons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/310/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 30 Sep 2016 07:14:29 +
Build duration: 4 min 22 sec

CHANGE SET
Revision 58913d5b95eb463b7dc168c4ec6e7927410de3f4 by kainz.a: (update some 
kstars icons BUG: 364981)
  change: edit icons/actions/22/kstars_deepsky.svg
  change: edit icons/actions/22/kstars_supernovae.svg
  change: edit icons/actions/22/kstars_stars.svg
  change: edit icons/actions/22/kstars_constellationart.svg
  change: edit icons/actions/22/kstars_planets.svg


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 
test(s)Failed: TestSuite.dupe

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 105/132 
(80%)CONDITIONAL 46/78 (59%)

By packages
  
default>
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 42/57 (74%)CONDITIONAL 
14/26 (54%)
autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 63/75 (84%)CONDITIONAL 
32/52 (62%)

Re: Scrap baloo?

[Kevin Funk]

On Wednesday, 28 September 2016 23:38:08 CEST Christoph Cullmann wrote:
> Hi,
> 
> first of all: I appreciate all your work and don't want to attack you
> personally in any way, if my last mail felt that way, I am sorry!
> 
> > Hi,
> > 
> > On 28 September 2016 at 20:33, Christoph Cullmann  
wrote:
> >> Hi,
> >> 
> >>> Hi,
> >>> 
> >>> On 28 September 2016 at 02:36, Christoph Cullmann  
wrote:
>  any update?
> >>> 
> >>> Yep. In all the happennings of the week I just forgot to write this
> >>> email.
> >>> 
> >>> If Baloo is going to be an integral part of the Plasma experience, do
> >>> we really want to depend on an external project where we don't have
> >>> control (and indeed, sentiments may prevent unrestricted contributions
> >>> based only on merit). This is the political reason why I don't want to
> >>> depend against Tracker. The technical reason is that it's based on
> >>> SQLite, which is incredibly slow compared to what we do now.
> >> 
> >> I don't see really that it is slow compared to what we do, if you have
> >> benchmarks
> >> for that, I would be pleased to see them.
> > 
> > So would I. You already have Tracker based code, could you spare some
> > time and run some?
> 
> Not really, I would not even known what to benchmark.
> But if you have no benchmarks available, I am interested to know why there
> is that idea we are that much faster? LMDB is fast, as key value storage,
> but we do not just lookup a key but do a lot more on top, that means only
> because we use a faster DB, we don't need to end up with faster overall
> performance than other solutions.
> >>> At the same time, LMDB needs to be replaced, and fast. I'm building a
> >>> new KVDB as an university project (it should be able to do 256GB
> >>> indexes on 32bit machines), and if that doesn't work out there's
> >>> Sophia (http://sophia.systems/). I'll be evaluating both as a
> >>> replacement to LMDB.
> >> 
> >> Do we really want to maintain a own DB system?
> >> IMHO that will never work out, all DB systems around need more
> >> maintenance power than we have.
> > 
> > This is something I'm not sure about. The DB will be build anyway, my
> > graduation depends on it :D And if I'm going to do something I will do
> > it well, so it'll be simple and clean.
> 
> I don't doubt that you are capable to write clean and working code.
> 
> The only problem is: there is a big difference between a academic
> implementation and a product ready thing. Any existing key value database
> that is usable for general consumption is a multi man year effort, even if
> you start today, that is a solution we can use in some years, if at all.
> 
> Actually the most work is to handle all different environments and corner
> cases, which is something that more or less can only be done by getting
> feedback over several years, and I doubt we want to incubate a new DB in
> baloo as playground on our user production machines.
> 
> > If it doesn't work out, there's always Sophia to fall back on.
> 
> Sophia is again designed to be used in server environments, just from their
> start page:
> 
> "For server environment, which requires lowest latency access (both read and
> write), predictable behaviour, optimized storage schema and transaction
> guarantees."
> 
> This means, like lmdb, most likely (at least google doesn't tell that it
> will do it) real usable for nfs (or other network) home mounts, which is
> very common on large scale installations.
> 
> (sophia doesn't get away to well after the opinion of the lmdb author, too:
> https://www.mail-archive.com/cyrus-devel@lists.andrew.cmu.edu/msg03653.html
> )
> >>> Vishesh also wanted to separate out the engine and make it public API
> >>> (apparently other projects want to make use of it as a general data
> >>> storage library - and the engine offers fulltext search capabilities
> >>> and other fancy logical operators that make it particularly
> >>> attractive. My plan is to move towards that, and eventually also not
> >>> only index files but also other kinds of objects - contacts, or
> >>> people, for example.
> >>> 
> >>> I don't want to move back into the "semantic desktop" idea at all, but
> >>> I do want some sort of infrastructure that allows for an "action on
> >>> object" metaphor - file objects can be opened with an application,
> >>> people objects can be sent mails, and so on.
> >>> 
> >>> Hope this makes sense.
> >> 
> >> I still not see how that should work out, atm, IMHO facts are:
> >> 
> >> 1) baloo is not maintained
> > 
> > It will, now.
> > 
> >> 2) lmdb will e.g. never work for us on NFS homes and the code needs major
> >> overhaul
> >> to handle errors (which you confirm)
> > 
> > LMDB goes away, either way.
> > 
> >> 3) you said you have "some time" left to maintain it, but you now propose
> >> in addition to maintain
> >> Baloo to write a DB system from scratch, I don't really see that working
> > 
> > I have a personal interest, an