D7968: Forward QComboBox signals instead of QComboBox lineedit signals

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  Looks good, but aren't there unittests missing for the non-editable combo 
case?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7968

To: mwolff, apol, dfaure
Cc: #frameworks

Re: DragonPlayer

[pointedstick]

 On Fri, 08 Dec 2017 13:04:12 -0800 Harald Sittersit...@kde.org 
wrote  
It's maintained just fine 
https://phabricator.kde.org/R259:b06cd9e1fbacefabdd2c0fa61f9af39cead25d8e. 
It's not getting better, it's not getting worse it's getting 
maintained at the level it is at. What Nate is asking for is an active 
developer... and that is an entirely different problem which speaks 
more to the community investment in our applications than anything 
else. 


Sorry Harald, I hope I haven't offended you! I want to be clear that I'm not 
trying to dump on DragonPlayer at all or call for its execution. Rather, I'd 
like to make the case that it doesn't serve our users to continue distributing 
software that's degrading over time due to bit rot--the fate of all software 
that's not receiving active development. Bug reports become a black hole of 
frustration for users ("Hello! Why isn't this fixed yet? Why hasn't anyone 
even looked at it!?") and become a source of overwhelm and depression for the 
developers ("Oh no, another bug that I don't have the time or energy to 
fix..."). If we aren't going to get rid of DragonPlayer, then we need to 
rehabilitate or rewrite it! Anything to inject some new energy into the system. 
For that matter the same is true of Baloo...



VLC is already a do-everything kitchen sink program, and yeah, with a Qt UI, 
it's right at home on Plasma, though of course some KDE contribution to further 
refine the UI would be great. DragonPlayer can't compete with it on the basis 
of features, so I think it does make sense to get back to basics and make it or 
its successor a really lightweight minimal program that only does one thing and 
does it well. We would need to aggressively resist feature creep, directing 
users to VLC or something else when they make requests for additional features.


If there's not enough support or development time for that, then we might 
indeed want to consider contributing more to VLC instead. Those contributions 
would have a huge impact, and there's certainly a lot to do! For example, in 
Plasma, VLC is still unable to play media on password-protected Samba shares 
without using the command line or resorting to entering the share's credentials 
in VLC's own config module: https://trac.videolan.org/vlc/ticket/18993


Nate

Re: DragonPlayer

[Harald Sitter]

It's maintained just fine
https://phabricator.kde.org/R259:b06cd9e1fbacefabdd2c0fa61f9af39cead25d8e.
It's not getting better, it's not getting worse it's getting
maintained at the level it is at. What Nate is asking for is an active
developer... and that is an entirely different problem which speaks
more to the community investment in our applications than anything
else.

>From where I am standing dragon's purity of purpose has been ripped
apart, put back together, than ripped apart again. Making it a
frankenmonster in so many ways that I would find it hard to imageine
anyone wanting to actually iterate on the current code instead of just
rewriting the entire damn thing to go back to the basics (being the
simplest UI possible for video) or making a competitive product to VLC
(and let's be honest why would anyone do that considering VLC's
default UI is Qt, so one might as well spend time on that).

As far as feature development is concerned it's a bit of a dead-end,
unless you are out for fights. You can neither take all advanced
features out lest you piss off people, nor can you graft more features
on and throw its entire selling point out the window making it yet
more complicated.

To that end if there is community support for killing dragon, I won't
stand in anyone's way.
KDE is already good friends with VideoLAN and I would only find it
fitting if we threw some of our experience in making GUIs behind VLC
to make it even better and let it shine in a plasma-desktop &
plasma-mobile context.

That being said though. If anyone wants to start from scratch with a
super simple video player UI to replace the current dragon they can
get in touch with me. Jens and I worked on a really kickass concept
already. There is value in the simple use case, it's just not going to
take over the world.

HS


On Fri, Dec 8, 2017 at 5:36 PM, Sebastian Kügler  wrote:
> On vrijdag 8 december 2017 15:25:06 CET Nate Graham wrote:
>> Sad to say, DragonPlayer seems dead-ish. It hasn't gotten any code
>> changes since January of this year. Kubuntu has stopped shipping it by
>> default, replacing it with VLC. Bugzilla tickets continue to pile up.
>>
>> What's the way forward here? Should we look for a new maintainer or
>> admit defeat and just recommend VLC or MPV or something else?
>
> Looking for a new maintainer sounds like the way to go.
>
> Cheers,
> --
> sebas
>
> http://www.kde.org | http://vizZzion.org
>
>

D9175: Migrate some more QRegExps to QRegularExpression

[Christoph Cullmann]

cullmann added a comment.


  For the QLatin1String on the right side in some contructors: should it not be 
always QStringLiteral? Not that it will matter a lot.

INLINE COMMENTS

> dhaumann wrote in kateview.cpp:3595
> Now that's a good point: I don't completely.
> It appends a leading and trailing space, and the searches with \b%1 once, and 
> with %1\b again. But isn't that always true? This is about the highlight 
> selection feature, and I couldn't spot any difference in behavior. Still 
> maybe I missed something...

I think the old code tried to ensure we only add word-boundary if we still can 
find the string then. e.g. if the string that you highlight contains spaces or 
stuff like that at the borders, you don't add \b.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D9175

To: dhaumann, cullmann, kfunk, mwolff
Cc: #frameworks, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann

D8371: Support for underscores in numeric literals (Python 3.6)

[Christoph Cullmann]

cullmann added a comment.


  Hi,
  I assume the regex are right ;=)
  
  For the patch:
  a) I think the version number must be increased
  b) an extended unit test would be nice, to really show that the regex are 
right.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D8371

To: januz, #kate
Cc: cullmann, #frameworks, genethomas, vkrause, dhaumann

D9219: WIP: Extend Scripting API

[Christoph Cullmann]

cullmann requested changes to this revision.
cullmann added a comment.
This revision now requires changes to proceed.


  I think that extension idea is good.
  The functions won't really fit to document or view and an editor object could 
be used for other global things, too, without further polluting the global 
namespace with free functions.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D9219

To: dhaumann, cullmann, mwolff
Cc: #frameworks, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann

D9257: MessageInterface: Add CenterInView as additional position

[Christoph Cullmann]

cullmann added a comment.


  For the "KateMessageWidget *m_topMessageWidget" and Co. members: Would it 
make sense to have just an array of pointers with index == the matching 
MessagePosition enum value?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D9257

To: dhaumann, cullmann, neundorf
Cc: #frameworks, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann

D9076: Have an application that can cross-check if the promised platforms are correct

[Ben Cooksley]

bcooksley added a comment.


  The FreeBSD platform name was changed this week yes. I can't see any explicit 
handling for 'All' being specified as a platform in the metainfo file here 
though, unless one is always required to list the platforms explicitly?

REPOSITORY
  R857 CI System Tooling

REVISION DETAIL
  https://phabricator.kde.org/D9076

To: apol, #frameworks
Cc: adridg, bcooksley, dfaure

D9258: Disconnect shortcutedit slot on widget destruction

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R263:037a4ffa467d: Disconnect shortcutedit slot on widget 
destruction (authored by davidedmundson).

REPOSITORY
  R263 KXmlGui

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9258?vs=23656=23660

REVISION DETAIL
  https://phabricator.kde.org/D9258

AFFECTED FILES
  src/kshortcuteditwidget.cpp

To: davidedmundson, #plasma, broulik
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Re: DragonPlayer

[Sebastian Kügler]

On vrijdag 8 december 2017 15:25:06 CET Nate Graham wrote:
> Sad to say, DragonPlayer seems dead-ish. It hasn't gotten any code
> changes since January of this year. Kubuntu has stopped shipping it by
> default, replacing it with VLC. Bugzilla tickets continue to pile up.
> 
> What's the way forward here? Should we look for a new maintainer or
> admit defeat and just recommend VLC or MPV or something else?

Looking for a new maintainer sounds like the way to go.

Cheers,
-- 
sebas

http://www.kde.org | http://vizZzion.org

D9258: Disconnect shortcutedit slot on widget destruction

[Kai Uwe Broulik]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R263 KXmlGui

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9258

To: davidedmundson, #plasma, broulik
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9258: Disconnect shortcutedit slot on widget destruction

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  If the widget is destroyed the connect still exists with a dangling
  capture.
  
  BUG: 387307

TEST PLAN
  Compiles.

REPOSITORY
  R263 KXmlGui

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9258

AFFECTED FILES
  src/kshortcuteditwidget.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9257: MessageInterface: Add CenterInView as additional position

[Dominik Haumann]

dhaumann created this revision.
dhaumann added reviewers: cullmann, neundorf.
Restricted Application added projects: Kate, Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  This patch extends the message interface to support CenterInView.
  This should be binary compatible, since an enum is only added at
  the end.
  
  The search messages "Search wrapped at bottom/top" now use
  CenterInView to be more visible (see recent discussion on
  kwrite-devel). In order to support his, a custom layout called
  KateMessageLayout was added that only supports the positions
  allowed by KTextEditor::Messate::MessagePosition.

TEST PLAN
  make test, manual testing

REPOSITORY
  R39 KTextEditor

BRANCH
  MessageInterface (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D9257

AFFECTED FILES
  src/include/ktexteditor/message.h
  src/search/katesearchbar.cpp
  src/search/katesearchbar.h
  src/view/kateview.cpp
  src/view/kateview.h
  src/view/kateviewhelpers.cpp
  src/view/kateviewhelpers.h

To: dhaumann, cullmann, neundorf
Cc: #frameworks, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann

DragonPlayer

[Nate Graham]

Hello all,
Sad to say, DragonPlayer seems dead-ish. It hasn't gotten any code 
changes since January of this year. Kubuntu has stopped shipping it by 
default, replacing it with VLC. Bugzilla tickets continue to pile up.


What's the way forward here? Should we look for a new maintainer or 
admit defeat and just recommend VLC or MPV or something else?


Nate Graham

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 26 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/26/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.7
 Date of build:
Fri, 08 Dec 2017 13:58:18 +
 Build duration:
7 min 0 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 54 test(s), Skipped: 0 test(s), Total: 56 test(s)Failed: TestSuite.kiowidgets-kurifiltersearchprovideractionstestFailed: TestSuite.kiowidgets-kurifiltertest

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 25 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/25/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.7
 Date of build:
Fri, 08 Dec 2017 13:39:35 +
 Build duration:
18 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 54 test(s), Skipped: 0 test(s), Total: 56 test(s)Failed: TestSuite.kiowidgets-kurifiltersearchprovideractionstestFailed: TestSuite.kiowidgets-kurifiltertest
   CONSOLE OUTPUT
  [...truncated 2.02 MB...]-- Installing: /home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.7/install-divert/home/jenkins/install-prefix/share/kservices5/useragentstrings/firefox16oncurrent.desktop-- Installing: /home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.7/install-divert/home/jenkins/install-prefix/share/kservices5/useragentstrings/firefox20oncurrent.desktop-- Installing: /home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.7/install-divert/home/jenkins/install-prefix/share/kservices5/useragentstrings/firefox30oncurrent.desktop-- Installing: /home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.7/install-divert/home/jenkins/install-prefix/share/kservices5/useragentstrings/firefox36oncurrent.desktop-- Installing: /home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.7/install-divert/home/jenkins/install-prefix/share/kservices5/useragentstrings/firefox520oncurrent.desktop-- Installing: /home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.7/install-divert/home/jenkins/install-prefix/share/kservices5/useragentstrings/googlebot.desktop-- Installing: /home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.7/install-divert/home/jenkins/install-prefix/share/kservices5/useragentstrings/ie401onwinnt4.desktop-- Installing: /home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.7/install-divert/home/jenkins/install-prefix/share/kservices5/useragentstrings/ie50onppc.desktop-- Installing: /home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.7/install-divert/home/jenkins/install-prefix/share/kservices5/useragentstrings/ie55onwinnt5.desktop-- Installing: /home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.7/install-divert/home/jenkins/install-prefix/share/kservices5/useragentstrings/ie60oncurrent.desktop-- Installing: /home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.7/install-divert/home/jenkins/install-prefix/share/kservices5/useragentstrings/ie60onwinnt51.desktop-- Installing: /home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.7/install-divert/home/jenkins/install-prefix/share/kservices5/useragentstrings/ie70onwinnt51.desktop-- Installing: /home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.7/install-divert/home/jenkins/install-prefix/share/kservices5/useragentstrings/ie80onwinnt60.desktop-- Installing: /home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.7/install-divert/home/jenkins/install-prefix/share/kservices5/useragentstrings/ie90onwinnt71.desktop-- Installing: /home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.7/install-divert/home/jenkins/install-prefix/share/kservices5/useragentstrings/lynxoncurrent.desktop-- Installing: /home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.7/install-divert/home/jenkins/install-prefix/share/kservices5/useragentstrings/nn301oncurrent.desktop-- Installing: /home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.7/install-divert/home/jenkins/install-prefix/share/kservices5/useragentstrings/nn475oncurrent.desktop-- Installing: /home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.7/install-divert/home/jenkins/install-prefix/share/kservices5/useragentstrings/nn475onwin95.desktop-- Installing: /home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.7/install-divert/home/jenkins/install-prefix/share/kservices5/useragentstrings/ns71oncurrent.desktop-- Installing: /home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.7/install-divert/home/jenkins/install-prefix/share/kservices5/useragentstrings/ns71onwinnt51.desktop-- Installing: /home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.7/install-divert/home/jenkins/install-prefix/share/kservices5/useragentstrings/op1162oncurrent.desktop-- Installing: /home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.7/install-divert/home/jenkins/install-prefix/share/kservices5/useragentstrings/op1202oncurrent.desktop-- Installing: /home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.7/install-divert/home/jenkins/install-prefix/share/kservices5/useragentstrings/op403onwinnt4.desktop-- Installing: /home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.7/install-divert/home/jenkins/install-prefix/share/kservices5/useragentstrings/op85oncurrent.desktop-- Installing: /home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.7/install-divert/home/jenkins/install-prefix/share/kservices5/useragentstrings/op90oncurrent.desktop-- Installing: /home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.7/install-divert/home/jenkins/install-prefix/share/kservices5/useragentstrings/op962oncurrent.desktop-- Installing: 

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 26 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/26/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 08 Dec 2017 13:49:13 +
 Build duration:
7 min 4 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 54 test(s), Skipped: 0 test(s), Total: 56 test(s)Failed: TestSuite.kiowidgets-kurifiltersearchprovideractionstestFailed: TestSuite.kiowidgets-kurifiltertest

D9252: Created 'GroupHiddenRole' for KPlacesModel

[Milian Wolff]

mwolff added a comment.


  thanks lgtm

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9252

To: renatoo, mwolff
Cc: #frameworks

D9252: Created 'GroupHiddenRole' for KPlacesModel

[Phabricator]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:561210cd18c9: Created GroupHiddenRole for 
KPlacesModel (authored by Renato Araujo Oliveira Filho 
renato.ara...@kdab.com).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9252?vs=23647=23649

REVISION DETAIL
  https://phabricator.kde.org/D9252

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  src/filewidgets/kfileplacesmodel.cpp
  src/filewidgets/kfileplacesmodel.h

To: renatoo, mwolff
Cc: #frameworks

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 25 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/25/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 08 Dec 2017 13:39:35 +
 Build duration:
9 min 16 sec and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 56 test(s)Failed: TestSuite.kiofilewidgets-kfilewidgettestFailed: TestSuite.kiowidgets-kurifiltersearchprovideractionstestFailed: TestSuite.kiowidgets-kurifiltertest

D9249: forward socket error string to KTcpSocket

[Martin Koller]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:84f290a2659d: forward socket error string to KTcpSocket 
(authored by mkoller).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9249?vs=23638=23648

REVISION DETAIL
  https://phabricator.kde.org/D9249

AFFECTED FILES
  src/core/ktcpsocket.cpp

To: mkoller, dfaure
Cc: #frameworks

D9252: Created 'GroupHiddenRole' for KPlacesModel

[Renato Oliveira Filho]

renatoo marked an inline comment as done.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9252

To: renatoo, mwolff
Cc: #frameworks

D9252: Created 'GroupHiddenRole' for KPlacesModel

[Renato Oliveira Filho]

renatoo updated this revision to Diff 23647.
renatoo added a comment.


  Refactored unit test

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9252?vs=23644=23647

REVISION DETAIL
  https://phabricator.kde.org/D9252

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  src/filewidgets/kfileplacesmodel.cpp
  src/filewidgets/kfileplacesmodel.h

To: renatoo, mwolff
Cc: #frameworks

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 24 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/24/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 08 Dec 2017 13:19:55 +
 Build duration:
14 min and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 56 test(s)Failed: TestSuite.kiofilewidgets-kfilewidgettestFailed: TestSuite.kiowidgets-kurifiltersearchprovideractionstestFailed: TestSuite.kiowidgets-kurifiltertest

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 24 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/24/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.7
 Date of build:
Fri, 08 Dec 2017 13:19:55 +
 Build duration:
12 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 54 test(s), Skipped: 0 test(s), Total: 56 test(s)Failed: TestSuite.kiowidgets-kurifiltersearchprovideractionstestFailed: TestSuite.kiowidgets-kurifiltertest

D9252: Created 'GroupHiddenRole' for KPlacesModel

[Milian Wolff]

mwolff accepted this revision.
mwolff added a comment.
This revision is now accepted and ready to land.


  you could reduce the code duplication by adding a loop. Note that you can 
even write something like this:
  
for (auto type : {type1, type2, type3}) {
   
}

INLINE COMMENTS

> kfileplacesmodeltest.cpp:1242
> +m_places->setGroupHidden(KFilePlacesModel::SearchForType, true);
> +for (auto index : 
> m_places->groupIndexes(KFilePlacesModel::SearchForType)) {
> +QCOMPARE(index.data(KFilePlacesModel::GroupHiddenRole).toBool(), 
> true);

nest this in an outer loop over the group types to share most of the code

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9252

To: renatoo, mwolff
Cc: #frameworks

D9252: Created 'GroupHiddenRole' for KPlacesModel

[Renato Oliveira Filho]

renatoo added a dependent revision: D9242: Implemented support for hide/show 
groups.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9252

To: renatoo, mwolff
Cc: #frameworks

D9252: Created 'GroupHiddenRole' for KPlacesModel

[Renato Oliveira Filho]

renatoo edited the summary of this revision.
renatoo added a reviewer: mwolff.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9252

To: renatoo, mwolff
Cc: #frameworks

D9252: Created 'GroupHiddenRole' for KPlacesModel

[Renato Oliveira Filho]

renatoo created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  Created new role for KPlacesModel

TEST PLAN
  unit test

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9252

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  src/filewidgets/kfileplacesmodel.cpp
  src/filewidgets/kfileplacesmodel.h

To: renatoo
Cc: #frameworks

D8619: Refactor and remove duplicate code in kfileplacesview

[Laurent Montel]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:5f7e892cb79f: Refactor and remove duplicate code in 
kfileplacesview (authored by mlaurent).
Restricted Application added a project: Frameworks.

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D8619?vs=23071=23642#toc

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8619?vs=23071=23642

REVISION DETAIL
  https://phabricator.kde.org/D8619

AFFECTED FILES
  src/filewidgets/kfileplacesview.cpp

To: mlaurent, #frameworks, ervin, dfaure
Cc: dfaure, ngraham

D9249: forward socket error string to KTcpSocket

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9249

To: mkoller, dfaure
Cc: #frameworks

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 23 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/23/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 08 Dec 2017 12:42:45 +
 Build duration:
19 min and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 56 test(s)Failed: TestSuite.kiofilewidgets-kfilewidgettestFailed: TestSuite.kiowidgets-kurifiltersearchprovideractionstestFailed: TestSuite.kiowidgets-kurifiltertest

D8519: do not make the context menu a Window

[Martin Koller]

mkoller retitled this revision from "do not make the context menu a Window; do 
not force raise a window" to "do not make the context menu a Window".
mkoller edited the summary of this revision.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D8519

To: mkoller, davidedmundson, graesslin
Cc: #frameworks

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 23 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/23/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.7
 Date of build:
Fri, 08 Dec 2017 12:42:44 +
 Build duration:
7 min 28 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 54 test(s), Skipped: 0 test(s), Total: 56 test(s)Failed: TestSuite.kiowidgets-kurifiltersearchprovideractionstestFailed: TestSuite.kiowidgets-kurifiltertest

D9249: forward socket error string to KTcpSocket

[Martin Koller]

mkoller created this revision.
mkoller added a reviewer: dfaure.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  KTcpSocket is a QIODevice, internally using a Qt socket - however it does not 
set the error string of itself when the internal socket signals some error 
condition.
  
  The original problem I had with this was the PIM maildispatcher -  in the 
lack of any error string - just showing an error number when notifying the 
user. But a "Failed to transport message. 3" does not really say much to the 
user.
  
  Now at least I get "Failed to transport message. Host not found"

TEST PLAN
  using maildispatcher sending mail to an unknown host

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9249

AFFECTED FILES
  src/core/ktcpsocket.cpp

To: mkoller, dfaure
Cc: #frameworks

D9241: Emit 'groupHiddenChanged' signal.

[Phabricator]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:f1185dc10acf: Emit groupHiddenChanged signal. 
(authored by Renato Araujo Oliveira Filho renato.ara...@kdab.com).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9241?vs=23617=23639

REVISION DETAIL
  https://phabricator.kde.org/D9241

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  src/filewidgets/kfileplacesmodel.cpp
  src/filewidgets/kfileplacesmodel.h

To: renatoo, franckarrecot, mwolff, mlaurent
Cc: ngraham, mwolff, #frameworks

D9241: Emit 'groupHiddenChanged' signal.

[Milian Wolff]

mwolff accepted this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9241

To: renatoo, franckarrecot, mwolff, mlaurent
Cc: mwolff, #frameworks

D9123: reuse KPackage instance between PluginLoader and Applet

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/kpackageinctor

REVISION DETAIL
  https://phabricator.kde.org/D9123

To: mart, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9247: Extend Scripting API to allow executing commands

[Christoph Cullmann]

cullmann added a comment.


  > Well, the scripting commands are also available on the command line as 
commands, aren't they? So you could essentially call yourself.
  
  Yeah, that is true, but that is no difference to you are calling yourself 
indirectly in javascript itself. Perhaps a bit more hidden.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D9247

To: dhaumann, cullmann, mwolff, kfunk
Cc: #frameworks, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann

D9247: Extend Scripting API to allow executing commands

[Dominik Haumann]

dhaumann added a comment.


  Well, the scripting commands are also available on the command line as 
commands, aren't they? So you could essentially call yourself.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D9247

To: dhaumann, cullmann, mwolff, kfunk
Cc: #frameworks, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann

D9123: reuse KPackage instance between PluginLoader and Applet

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> davidedmundson wrote in applet.cpp:98
> If anyone uses the old argument list syntax (where the first argument was a 
> string or a kpluginmetadata)  this will break.
> 
> Can we be sure that the PluginLoader was the only user? 
> It was a somewhat undocumented thing right?

yes, was completely undocumented.
it was the only user and safe-ish to assume it continues to as is protected

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D9123

To: mart, #plasma
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 22 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/22/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.7
 Date of build:
Fri, 08 Dec 2017 10:58:34 +
 Build duration:
18 min and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 56 test(s)Failed: TestSuite.kiofilewidgets-kfilewidgettestFailed: TestSuite.kiowidgets-kurifiltersearchprovideractionstestFailed: TestSuite.kiowidgets-kurifiltertest

D9247: Extend Scripting API to allow executing commands

[Christoph Cullmann]

cullmann added a comment.


  How can we have infinite recursion? By calling a command that triggers again 
the script function we did call the command in? If that is the only problem, I 
see no issue, that can happen with normal function calls already, perhaps we 
could guard chained command calls inside executeCommand, thought (aka guard 
that not twice the same "command" string arrives via set)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D9247

To: dhaumann, cullmann, mwolff, kfunk
Cc: #frameworks, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 22 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/22/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 08 Dec 2017 10:58:34 +
 Build duration:
13 min and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 56 test(s)Failed: TestSuite.kiofilewidgets-kfilewidgettestFailed: TestSuite.kiowidgets-kurifiltersearchprovideractionstestFailed: TestSuite.kiowidgets-kurifiltertest

D8450: User can now hide an entire places group from KFilePlacesView

[Franck Arrecot]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:b8bd61c3650c: User can now hide an entire places group 
from KFilePlacesView (authored by franckarrecot).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8450?vs=23630=23633

REVISION DETAIL
  https://phabricator.kde.org/D8450

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  src/filewidgets/kfileplacesmodel.cpp
  src/filewidgets/kfileplacesmodel.h
  src/filewidgets/kfileplacesview.cpp

To: franckarrecot, ngraham, renatoo, ervin, mwolff, mlaurent
Cc: mwolff, #frameworks

D8367: Hidding place groups implementation in KFilePlacesModel

[Franck Arrecot]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:cd9856d14552: Hidding place groups implementation in 
KFilePlacesModel (authored by franckarrecot).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8367?vs=23629=23632

REVISION DETAIL
  https://phabricator.kde.org/D8367

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  src/filewidgets/kfileplacesitem.cpp
  src/filewidgets/kfileplacesitem_p.h
  src/filewidgets/kfileplacesmodel.cpp
  src/filewidgets/kfileplacesmodel.h
  src/tests/placesitemmodeltest.cpp

To: franckarrecot, renatoo, ngraham, ervin, mwolff, mlaurent
Cc: mwolff, ngraham, mlaurent, #frameworks

D9015: Refactoring the hidding/showing animation use within KFilePlacesView

[Franck Arrecot]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:2cd35636bbf9: Refactoring the hidding/showing animation 
use within KFilePlacesView (authored by franckarrecot).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9015?vs=23631=23634

REVISION DETAIL
  https://phabricator.kde.org/D9015

AFFECTED FILES
  src/filewidgets/kfileplacesview.cpp

To: franckarrecot, ervin, renatoo, mlaurent, ngraham
Cc: #frameworks

D9015: Refactoring the hidding/showing animation use within KFilePlacesView

[Franck Arrecot]

franckarrecot updated this revision to Diff 23631.
franckarrecot added a comment.


  rebased

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9015?vs=23411=23631

REVISION DETAIL
  https://phabricator.kde.org/D9015

AFFECTED FILES
  src/filewidgets/kfileplacesview.cpp

To: franckarrecot, ervin, renatoo, mlaurent, ngraham
Cc: #frameworks

D8450: User can now hide an entire places group from KFilePlacesView

[Franck Arrecot]

franckarrecot updated this revision to Diff 23630.
franckarrecot added a comment.


  corrected and rebased

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8450?vs=23410=23630

REVISION DETAIL
  https://phabricator.kde.org/D8450

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  src/filewidgets/kfileplacesmodel.cpp
  src/filewidgets/kfileplacesmodel.h
  src/filewidgets/kfileplacesview.cpp

To: franckarrecot, ngraham, renatoo, ervin, mwolff, mlaurent
Cc: mwolff, #frameworks

D8367: Hidding place groups implementation in KFilePlacesModel

[Franck Arrecot]

franckarrecot updated this revision to Diff 23629.
franckarrecot added a comment.


  rebase

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8367?vs=23409=23629

REVISION DETAIL
  https://phabricator.kde.org/D8367

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  src/filewidgets/kfileplacesitem.cpp
  src/filewidgets/kfileplacesitem_p.h
  src/filewidgets/kfileplacesmodel.cpp
  src/filewidgets/kfileplacesmodel.h
  src/tests/placesitemmodeltest.cpp

To: franckarrecot, renatoo, ngraham, ervin, mwolff, mlaurent
Cc: mwolff, ngraham, mlaurent, #frameworks

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.7 - Build # 8 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.7/8/
 Project:
Frameworks baloo kf5-qt5 SUSEQt5.7
 Date of build:
Fri, 08 Dec 2017 10:45:24 +
 Build duration:
9 min 15 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 39 test(s), Skipped: 0 test(s), Total: 39 test(s)

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.10 - Build # 8 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.10/8/
 Project:
Frameworks baloo kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 08 Dec 2017 10:45:24 +
 Build duration:
6 min 43 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: TestSuite.kinotifytest

D9247: Extend Scripting API to allow executing commands

[Dominik Haumann]

dhaumann retitled this revision from "Extend Scripting API to allow executong 
commands" to "Extend Scripting API to allow executing commands".

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D9247

To: dhaumann, cullmann, mwolff, kfunk
Cc: #frameworks, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann

D9247: Extend Scripting API to allow executing commands

[Dominik Haumann]

dhaumann edited the summary of this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D9247

To: dhaumann, cullmann, mwolff, kfunk
Cc: #frameworks, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann

Re: Failing KTextEditor unit tests

[Dominik Haumann]

On Fri, Dec 8, 2017 at 10:21 AM, Ben Cooksley  wrote:
> On Wed, Dec 6, 2017 at 9:24 PM, David Faure  wrote:
>> On lundi 4 décembre 2017 18:38:50 CET Ben Cooksley wrote:
>>> If someone has a list of common font packages for SUSE then I can add
>>> those to the image relatively easy, which will probably fix those
>>> tests.
>>
>> dejavu-fonts might be enough.
>>
>> But otherwise here's a more complete list, from my Leap 42.3 system.
>>
>> adobe-sourcecodepro-fonts
>> adobe-sourcesanspro-fonts
>> adobe-sourceserifpro-fonts
>> cantarell-fonts
>> dejavu-fonts
>> google-carlito-fonts
>> google-droid-fonts
>> google-opensans-fonts
>> google-roboto-fonts
>> hack-fonts
>> kde-oxygen-fonts
>> liberation-fonts
>> lilypond-century-schoolbook-l-fonts
>> lilypond-emmentaler-fonts
>> noto-coloremoji-fonts
>> noto-emoji-fonts
>> noto-sans-fonts
>> stix-fonts
>> xorg-x11-fonts
>
> Thanks for that list David.
>
> adobe-sourcecodepro-fonts has since been installed in the SUSE images
> (all three variations).
>
> Dominik, can you check to see whether the tests are now happy with the
> font setup?

Since yesterday, ktexteditor is green again (cf. https://build.kde.org/).
Thanks for the fixes!

Best regards,
Dominik

D9247: Extend Scripting API to allow executong commands

[Dominik Haumann]

dhaumann created this revision.
dhaumann added reviewers: cullmann, mwolff, kfunk.
Restricted Application added projects: Kate, Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  This patch adds the following JavaScript API:
  
  object view.executeCommand(String command,
  
String args = String(),
Range range = Rante::invalid())
  
  The returned object indicates whether execution of the command
  was successful:
  
  - object.ok [bool] is true on success, otherwise false.
  - object.status [String] contains the result of the command (e.g. "31 
replacements made", or an error message)
  
  Examples:
  
view.executeCommand("sort"); // all, or seletcion
view.executeCommand("sort", "", new Range(1, 0, 4, 0); // sort lines 1-4
view.executeCommand("set-indent-width", "4");
  
  Unfortunately, we do not have any getters, e.g. "indent-width".
  This is a shortcoming of the KTextEditor::Command API. We should
  consider to change KTextEditor::Command as follows:
  
// old:
virtual bool exec(KTextEditor::View *view, const QString , QString ,
  const KTextEditor::Range  = 
KTextEditor::Range::invalid()) = 0;

// new:
virtual QVariant exec(const QVariant & args,
  const KTextEditor::Range  = 
KTextEditor::Range::invalid(),
  KTextEditor::View * view = nullptr) = 0;
  
  or similar. This way, Commands would be much more usabe in general
  (and also better chainable, which could result in: command 1 | command 2 | 
...).
  
  What is missing in this patch:
  
  - infinite recursion is very easily possible
  - guard against some special commands: reload-scripts, anything else?
  - should the API be more smart? E.g. we could support both:
- view.executeCommand("sort", "", new Range(1,0, 3, 0))
- view.executeCommand("sort", new Range(1,0, 3, 0)) -> we'd have to lookup 
the type of the passed QJSValues (would work)...
  - Maybe only return a bool instead of object with "ok" and "status" ? -> The 
status could be helpful as a return value, but to be honest, this is a hack 
(see shortcoming of KTextEditor::Command above). We could also add 
KTextEditor::CommandExtension, provide an improved interface, and then do this 
properly here... Comments?

TEST PLAN
  make test, manual testing

REPOSITORY
  R39 KTextEditor

BRANCH
  CommandScript (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D9247

AFFECTED FILES
  src/script/katescriptview.cpp
  src/script/katescriptview.h

To: dhaumann, cullmann, mwolff, kfunk
Cc: #frameworks, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.10 - Build # 6 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.10/6/
 Project:
Frameworks kpackage kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 08 Dec 2017 10:22:29 +
 Build duration:
4 min 32 sec and counting
   JUnit Tests
  Name: (root) Failed: 4 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: TestSuite.plasma-querytestFailed: TestSuite.testfallbackpackage-appstreamFailed: TestSuite.testpackage-appstreamFailed: TestSuite.testpackage-nodisplay-appstream

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.7 - Build # 6 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.7/6/
 Project:
Frameworks kpackage kf5-qt5 SUSEQt5.7
 Date of build:
Fri, 08 Dec 2017 10:22:29 +
 Build duration:
1 min 11 sec and counting
   JUnit Tests
  Name: (root) Failed: 4 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: TestSuite.plasma-querytestFailed: TestSuite.testfallbackpackage-appstreamFailed: TestSuite.testpackage-appstreamFailed: TestSuite.testpackage-nodisplay-appstream

D9076: Have an application that can cross-check if the promised platforms are correct

[Adriaan de Groot]

adridg added a comment.


  To understand the expected output better: suppose something says "platforms: 
All", like kcontacts. If there's no actual build configured in CI for that 
something, for FreeBSD, it will say "FreeBS is a disabled platform". The 
message can probably be improved, then. And how about checking the reverse, 
too? CI builds that are not listed in the metainfo? (if that can even happen)

INLINE COMMENTS

> check-platform.py:15
> +'SUSEQt5.7': 'Linux',
> +'FreeBSDQt5.7': 'FreeBSD',
> +'WindowsMSVCQt5.9': 'Windows',

I think this was just renamed ,  to Qt5.9 (check with Ben though)

REPOSITORY
  R857 CI System Tooling

REVISION DETAIL
  https://phabricator.kde.org/D9076

To: apol, #frameworks
Cc: adridg, bcooksley, dfaure

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.10 - Build # 7 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.10/7/
 Project:
Frameworks baloo kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 08 Dec 2017 09:47:39 +
 Build duration:
6 min 42 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 39 test(s), Skipped: 0 test(s), Total: 39 test(s)

KDE CI: Frameworks baloo kf5-qt5 WindowsMSVCQt5.9 - Build # 28 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20WindowsMSVCQt5.9/28/
 Project:
Frameworks baloo kf5-qt5 WindowsMSVCQt5.9
 Date of build:
Fri, 08 Dec 2017 09:47:39 +
 Build duration:
3 min 2 sec and counting

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.7 - Build # 7 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.7/7/
 Project:
Frameworks baloo kf5-qt5 SUSEQt5.7
 Date of build:
Fri, 08 Dec 2017 09:47:39 +
 Build duration:
2 min 33 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: TestSuite.kinotifytest

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.10 - Build # 6 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.10/6/
 Project:
Frameworks baloo kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 08 Dec 2017 09:41:54 +
 Build duration:
4 min 50 sec and counting
   CONSOLE OUTPUT
  [...truncated 275.94 KB...][ 32%] Building CXX object tests/engine/CMakeFiles/writeiotest.dir/writeiotest.cpp.oScanning dependencies of target databasebenchmark[ 32%] Building CXX object autotests/benchmarks/CMakeFiles/databasebenchmark.dir/databasebenchmark.cpp.o[ 33%] Building CXX object src/file/extractor/CMakeFiles/baloo_file_extractor.dir/__/priority.cpp.o[ 33%] Building CXX object tests/engine/CMakeFiles/writeiotest.dir/writeiotest_autogen/mocs_compilation.cpp.o[ 33%] Linking CXX executable ../../bin/writeiotest[ 33%] Built target writeiotest[ 34%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/queryrunnable.cpp.o[ 34%] Building CXX object src/file/extractor/CMakeFiles/baloo_file_extractor.dir/__/basicindexingjob.cpp.o[ 34%] Building CXX object autotests/benchmarks/CMakeFiles/databasebenchmark.dir/databasebenchmark_autogen/mocs_compilation.cpp.o[ 35%] Linking CXX executable ../../bin/databasebenchmark[ 36%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/xattrindexer.cpp.o[ 36%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/resultiterator.cpp.o[ 36%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/newfileindexer.cpp.o[ 36%] Built target databasebenchmark[ 36%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/advancedqueryparser.cpp.o[ 36%] Building CXX object src/file/extractor/CMakeFiles/baloo_file_extractor.dir/__/fileindexerconfig.cpp.o[ 37%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/file.cpp.o[ 37%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/filemonitor.cpp.o[ 37%] Building CXX object src/file/extractor/CMakeFiles/baloo_file_extractor.dir/__/storagedevices.cpp.o[ 37%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/modifiedfileindexer.cpp.o[ 37%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/unindexedfileindexer.cpp.o[ 37%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/taglistjob.cpp.o[ 38%] Building CXX object src/file/extractor/CMakeFiles/baloo_file_extractor.dir/__/regexpcache.cpp.o[ 38%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/indexerconfig.cpp.o[ 39%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/__/file/fileindexerconfig.cpp.o[ 39%] Building CXX object src/file/extractor/CMakeFiles/baloo_file_extractor.dir/__/fileexcludefilters.cpp.o[ 40%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/filecontentindexer.cpp.o[ 40%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/__/file/storagedevices.cpp.o[ 40%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/__/file/regexpcache.cpp.o[ 40%] Building CXX object src/file/extractor/CMakeFiles/baloo_file_extractor.dir/baloo_file_extractor_autogen/mocs_compilation.cpp.oScanning dependencies of target writetransactiontest[ 41%] Building CXX object autotests/integration/CMakeFiles/writetransactiontest.dir/writetransactiontest.cpp.o[ 41%] Building CXX object autotests/integration/CMakeFiles/writetransactiontest.dir/writetransactiontest_autogen/mocs_compilation.cpp.o[ 41%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/filecontentindexerprovider.cpp.o[ 41%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/extractorprocess.cpp.o[ 42%] Linking CXX executable ../../../bin/baloo_file_extractor[ 42%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/__/file/fileexcludefilters.cpp.o[ 42%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/timeestimator.cpp.oCMakeFiles/baloo_file_extractor.dir/__/storagedevices.cpp.o: In function `Baloo::StorageDevices::slotSolidDeviceAdded(QString const&)':/home/jenkins/workspace/Frameworks baloo kf5-qt5 SUSEQt5.10/src/file/storagedevices.cpp:95: undefined reference to `BALOO()'/home/jenkins/workspace/Frameworks baloo kf5-qt5 SUSEQt5.10/src/file/storagedevices.cpp:95: undefined reference to `BALOO()'CMakeFiles/baloo_file_extractor.dir/__/storagedevices.cpp.o: In function `Baloo::StorageDevices::slotSolidDeviceRemoved(QString const&)':/home/jenkins/workspace/Frameworks baloo kf5-qt5 SUSEQt5.10/src/file/storagedevices.cpp:107: undefined reference to `BALOO()'/home/jenkins/workspace/Frameworks baloo kf5-qt5 SUSEQt5.10/src/file/storagedevices.cpp:107: undefined reference to `BALOO()'CMakeFiles/baloo_file_extractor.dir/__/storagedevices.cpp.o: In function `Baloo::StorageDevices::slotAccessibilityChanged(bool, QString const&)':/home/jenkins/workspace/Frameworks baloo kf5-qt5 SUSEQt5.10/src/file/storagedevices.cpp:116: undefined reference to `BALOO()'CMakeFiles/baloo_file_extractor.dir/__/storagedevices.cpp.o:/home/jenkins/workspace/Frameworks baloo kf5-qt5 SUSEQt5.10/src/file/storagedevices.cpp:116: more undefined references to `BALOO()' followcollect2: error: ld returned 1 exit statusmake[2]: 

[baloo] /: Revert "Autogenerate debug file"

[Ben Cooksley]

Git commit afc01f1c5048d294b0676403a18744dde0a53d3a by Ben Cooksley.
Committed on 08/12/2017 at 09:46.
Pushed by bcooksley into branch 'master'.

Revert "Autogenerate debug file"
I'm backing all of this out for now as fixing this properly is non-trivial and 
the build is broken on at least one platform due to this change.

This reverts commit 1e4bb4e9ac37ef3b38975b3ea65df4c066f5e506.

CCMAIL: mon...@kde.org
CCMAIL: kde-frameworks-devel@kde.org

M  +0-3CMakeLists.txt
D  +0-1baloo.categories
M  +1-2src/file/CMakeLists.txt
A  +24   -0src/file/baloodebug.cpp [License: LGPL (v2+)]
A  +29   -0src/file/baloodebug.h [License: LGPL (v2+)]

https://commits.kde.org/baloo/afc01f1c5048d294b0676403a18744dde0a53d3a

diff --git a/CMakeLists.txt b/CMakeLists.txt
index a138922e..5ec72f38 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -44,7 +44,6 @@ include(KDEFrameworkCompilerSettings NO_POLICY_SCOPE)
 include(ECMInstallIcons)
 include(ECMAddTests)
 include(ECMAddQch)
-include(ECMQtDeclareLoggingCategory)
 
 option(BUILD_QCH "Build API documentation in QCH format (for e.g. Qt 
Assistant, Qt Creator & KDevelop)" OFF)
 add_feature_info(QCH ${BUILD_QCH} "API documentation in QCH format (for e.g. 
Qt Assistant, Qt Creator & KDevelop)")
@@ -145,7 +144,5 @@ install(FILES
 COMPONENT Devel
 )
 
-install(FILES baloo.categories DESTINATION ${KDE_INSTALL_CONFDIR})
-
 # and we're done
 feature_summary(WHAT ALL INCLUDE_QUIET_PACKAGES 
FATAL_ON_MISSING_REQUIRED_PACKAGES)
diff --git a/baloo.categories b/baloo.categories
deleted file mode 100644
index 5610e217..
--- a/baloo.categories
+++ /dev/null
@@ -1 +0,0 @@
-org.kde.baloo Baloo File debug
diff --git a/src/file/CMakeLists.txt b/src/file/CMakeLists.txt
index de4dc85c..ca463456 100644
--- a/src/file/CMakeLists.txt
+++ b/src/file/CMakeLists.txt
@@ -32,6 +32,7 @@ set(file_static_lib_SRCS
 filtereddiriterator.cpp
 unindexedfileiterator.cpp
 migrator.cpp
+baloodebug.cpp
 fileinfo.cpp
 
  # File Watcher
@@ -42,8 +43,6 @@ set(file_static_lib_SRCS
 kinotify.cpp
 )
 
-ecm_qt_declare_logging_category(file_static_lib_SRCS HEADER baloodebug.h 
IDENTIFIER BALOO CATEGORY_NAME org.kde.baloo)
-
 add_library(baloofilecommon STATIC ${file_static_lib_SRCS})
 target_link_libraries(baloofilecommon
 Qt5::DBus
diff --git a/src/file/baloodebug.cpp b/src/file/baloodebug.cpp
new file mode 100644
index ..ef36cc2b
--- /dev/null
+++ b/src/file/baloodebug.cpp
@@ -0,0 +1,24 @@
+/*  This file is part of the KDE project
+Copyright (C) 2014 Vishesh Handa 
+
+This library is free software; you can redistribute it and/or
+modify it under the terms of the GNU Library General Public
+License as published by the Free Software Foundation; either
+version 2 of the License, or (at your option) any later version.
+
+This library is distributed in the hope that it will be useful,
+but WITHOUT ANY WARRANTY; without even the implied warranty of
+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+Library General Public License for more details.
+
+You should have received a copy of the GNU Library General Public License
+along with this library; see the file COPYING.LIB.  If not, write to
+the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
+Boston, MA 02110-1301, USA.
+*/
+
+#include "baloodebug.h"
+
+Q_LOGGING_CATEGORY(BALOO, "org.kde.baloo")
+
+
diff --git a/src/file/baloodebug.h b/src/file/baloodebug.h
new file mode 100644
index ..9e395e2a
--- /dev/null
+++ b/src/file/baloodebug.h
@@ -0,0 +1,29 @@
+/*  This file is part of the KDE project
+Copyright (C) 2014 Vishesh Handa 
+
+This library is free software; you can redistribute it and/or
+modify it under the terms of the GNU Library General Public
+License as published by the Free Software Foundation; either
+version 2 of the License, or (at your option) any later version.
+
+This library is distributed in the hope that it will be useful,
+but WITHOUT ANY WARRANTY; without even the implied warranty of
+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+Library General Public License for more details.
+
+You should have received a copy of the GNU Library General Public License
+along with this library; see the file COPYING.LIB.  If not, write to
+the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
+Boston, MA 02110-1301, USA.
+*/
+
+#ifndef BALOO_DEBUG_H
+#define BALOO_DEBUG_H
+
+#include 
+#include 
+
+Q_DECLARE_LOGGING_CATEGORY(BALOO)
+
+#endif 
+

KDE CI: Frameworks baloo kf5-qt5 WindowsMSVCQt5.9 - Build # 27 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20WindowsMSVCQt5.9/27/
 Project:
Frameworks baloo kf5-qt5 WindowsMSVCQt5.9
 Date of build:
Fri, 08 Dec 2017 09:41:54 +
 Build duration:
3 min 10 sec and counting
   CONSOLE OUTPUT
  [...truncated 214.96 KB...]mocs_compilation.cpp[ 59%] Linking CXX shared library ..\..\bin\KF5BalooEngine.dll   Creating library ..\..\lib\KF5BalooEngine.lib and object ..\..\lib\KF5BalooEngine.exp   Creating library ..\..\lib\KF5BalooEngine.lib and object ..\..\lib\KF5BalooEngine.exp[ 59%] Built target KF5BalooEngineScanning dependencies of target KF5Baloo_autogen[ 60%] Automatic MOC for target KF5BalooGenerating MOC source YH6BUZA3PE/moc_fileindexerconfig.cppGenerating MOC source YH6BUZA3PE/moc_storagedevices.cppGenerating MOC source EWIEGA46WW/moc_filemonitor.cppGenerating MOC source EWIEGA46WW/moc_queryrunnable.cppGenerating MOC source EWIEGA46WW/moc_taglistjob.cppGenerating MOC compilation mocs_compilation.cpp[ 60%] Built target KF5Baloo_autogenScanning dependencies of target KF5Baloo[ 63%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/query.cpp.obj[ 63%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/term.cpp.obj[ 67%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/queryrunnable.cpp.obj[ 67%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/resultiterator.cpp.obj[ 68%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/advancedqueryparser.cpp.obj[ 68%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/file.cpp.obj[ 70%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/filemonitor.cpp.obj[ 71%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/taglistjob.cpp.objterm.cppqueryrunnable.cpp[ 72%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/indexerconfig.cpp.objfilemonitor.cpp[ 74%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/__/file/fileindexerconfig.cpp.objresultiterator.cpp[ 75%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/__/file/storagedevices.cpp.objadvancedqueryparser.cppquery.cppindexerconfig.cppstoragedevices.cppfile.cppfileindexerconfig.cpptaglistjob.cpp[ 77%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/__/file/regexpcache.cpp.obj[ 78%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/__/file/fileexcludefilters.cpp.objregexpcache.cppfileexcludefilters.cpp[ 79%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/searchstore.cpp.obj[ 81%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/__/dbus/maininterface.cpp.objsearchstore.cppmaininterface.cpp[ 82%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/KF5Baloo_autogen/mocs_compilation.cpp.objC:\CI\workspace\Frameworks baloo kf5-qt5 WindowsMSVCQt5.9\src\file\storagedevices.cpp(24): fatal error C1083: Cannot open include file: 'baloodebug.h': No such file or directoryjom: C:\CI\workspace\Frameworks baloo kf5-qt5 WindowsMSVCQt5.9\build\src\lib\CMakeFiles\KF5Baloo.dir\build.make [src\lib\CMakeFiles\KF5Baloo.dir\__\file\storagedevices.cpp.obj] Error 2mocs_compilation.cppC:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\VC\Tools\MSVC\14.11.25503\include\algorithm(2764): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of dataC:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\VC\Tools\MSVC\14.11.25503\include\algorithm(2781): note: see reference to function template instantiation 'void std::_Guess_median_unchecked<_RanIt,_Pr>(_RanIt,_RanIt,_RanIt,_Pr &)' being compiledwith[_RanIt=QTypedArrayData::iterator,_Pr=Baloo::SearchStore::exec::]C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\VC\Tools\MSVC\14.11.25503\include\algorithm(2882): note: see reference to function template instantiation 'std::pair<_RanIt,_RanIt> std::_Partition_by_median_guess_unchecked<_RanIt,_Pr>(_RanIt,_RanIt,_Pr &)' being compiledwith[_RanIt=QTypedArrayData::iterator,_Pr=Baloo::SearchStore::exec::]C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\VC\Tools\MSVC\14.11.25503\include\algorithm(2913): note: see reference to function template instantiation 'void std::_Sort_unchecked1<_RanIt,int,_Pr>(_RanIt,_RanIt,_Diff,_Pr &)' being compiledwith[_RanIt=QTypedArrayData::iterator,_Pr=Baloo::SearchStore::exec::,_Diff=int]C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\VC\Tools\MSVC\14.11.25503\include\algorithm(2921): note: see reference to function template instantiation 'void std::_Sort_unchecked<_Iter,_Pr>(_RanIt,_RanIt,_Pr &)' being compiledwith[_Iter=QTypedArrayData::iterator,_Pr=Baloo::SearchStore::exec::,_RanIt=QTypedArrayData::iterator]C:\CI\workspace\Frameworks baloo kf5-qt5 WindowsMSVCQt5.9\src\lib\searchstore.cpp(99): note: see reference to function template instantiation 'void 

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.7 - Build # 6 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.7/6/
 Project:
Frameworks baloo kf5-qt5 SUSEQt5.7
 Date of build:
Fri, 08 Dec 2017 09:41:54 +
 Build duration:
1 min 39 sec and counting
   CONSOLE OUTPUT
  [...truncated 261.85 KB...][ 32%] Building CXX object autotests/integration/CMakeFiles/writetransactiontest.dir/writetransactiontest.cpp.o[ 32%] Building CXX object autotests/integration/CMakeFiles/writetransactiontest.dir/writetransactiontest_autogen/mocs_compilation.cpp.o[ 32%] Building CXX object autotests/integration/CMakeFiles/querytest.dir/querytest_autogen/mocs_compilation.cpp.o[ 32%] Building CXX object src/file/extractor/CMakeFiles/baloo_file_extractor.dir/result.cpp.o[ 32%] Building CXX object src/file/extractor/CMakeFiles/baloo_file_extractor.dir/iohandler.cpp.o[ 33%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/queryrunnable.cpp.o[ 34%] Linking CXX executable ../../bin/querytest[ 34%] Building CXX object src/file/extractor/CMakeFiles/baloo_file_extractor.dir/idlestatemonitor.cpp.o[ 34%] Built target querytestScanning dependencies of target documentdatadbtest[ 34%] Building CXX object autotests/unit/engine/CMakeFiles/documentdatadbtest.dir/documentdatadbtest.cpp.o[ 34%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/resultiterator.cpp.o[ 34%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/advancedqueryparser.cpp.o[ 35%] Building CXX object src/file/extractor/CMakeFiles/baloo_file_extractor.dir/__/priority.cpp.o[ 35%] Linking CXX executable ../../bin/writetransactiontest[ 36%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/file.cpp.o[ 36%] Built target writetransactiontestScanning dependencies of target documenttimedbtest[ 36%] Building CXX object autotests/unit/engine/CMakeFiles/documenttimedbtest.dir/documenttimedbtest.cpp.o[ 36%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/filemonitor.cpp.o[ 36%] Building CXX object src/file/extractor/CMakeFiles/baloo_file_extractor.dir/__/basicindexingjob.cpp.o[ 37%] Building CXX object autotests/unit/engine/CMakeFiles/documentdatadbtest.dir/singledbtest.cpp.o[ 37%] Building CXX object src/file/extractor/CMakeFiles/baloo_file_extractor.dir/__/fileindexerconfig.cpp.o[ 37%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/taglistjob.cpp.o[ 37%] Building CXX object autotests/unit/engine/CMakeFiles/documentdatadbtest.dir/documentdatadbtest_autogen/mocs_compilation.cpp.o[ 38%] Building CXX object autotests/unit/engine/CMakeFiles/documenttimedbtest.dir/singledbtest.cpp.oScanning dependencies of target documentiddbtest[ 38%] Building CXX object autotests/unit/engine/CMakeFiles/documentiddbtest.dir/documentiddbtest.cpp.o[ 38%] Building CXX object autotests/unit/engine/CMakeFiles/documenttimedbtest.dir/documenttimedbtest_autogen/mocs_compilation.cpp.o[ 38%] Linking CXX executable ../../../bin/documentdatadbtest[ 38%] Building CXX object autotests/unit/engine/CMakeFiles/documentiddbtest.dir/singledbtest.cpp.o[ 38%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/indexerconfig.cpp.o[ 38%] Built target documentdatadbtest[ 39%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/__/file/fileindexerconfig.cpp.o[ 39%] Linking CXX executable ../../../bin/documenttimedbtest[ 39%] Built target documenttimedbtest[ 39%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/__/file/storagedevices.cpp.o[ 39%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/__/file/regexpcache.cpp.o[ 39%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/__/file/fileexcludefilters.cpp.o[ 39%] Building CXX object src/file/extractor/CMakeFiles/baloo_file_extractor.dir/__/storagedevices.cpp.o[ 40%] Building CXX object src/file/extractor/CMakeFiles/baloo_file_extractor.dir/__/regexpcache.cpp.o[ 41%] Building CXX object autotests/unit/engine/CMakeFiles/documentiddbtest.dir/documentiddbtest_autogen/mocs_compilation.cpp.o[ 41%] Building CXX object src/file/extractor/CMakeFiles/baloo_file_extractor.dir/__/fileexcludefilters.cpp.o[ 42%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/searchstore.cpp.o[ 42%] Building CXX object src/file/extractor/CMakeFiles/baloo_file_extractor.dir/baloo_file_extractor_autogen/mocs_compilation.cpp.o[ 42%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/__/dbus/maininterface.cpp.o[ 42%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/KF5Baloo_autogen/mocs_compilation.cpp.o[ 42%] Linking CXX executable ../../../bin/documentiddbtestScanning dependencies of target phraseanditeratortest[ 43%] Building CXX object autotests/unit/engine/CMakeFiles/phraseanditeratortest.dir/phraseanditeratortest.cpp.o[ 43%] Built target documentiddbtest[ 44%] Linking CXX executable ../../../bin/baloo_file_extractorScanning dependencies of target documentdbtest[ 45%] Building CXX object autotests/unit/engine/CMakeFiles/documentdbtest.dir/documentdbtest.cpp.o[ 45%] Building CXX object autotests/unit/engine/CMakeFiles/documentdbtest.dir/singledbtest.cpp.o[ 45%] 

[baloo] src: Complete removal of references to baloodebug.cpp which was deleted in the previous commit

[Ben Cooksley]

Git commit a7ebc07cad22e3c581960969e779940f992ba320 by Ben Cooksley.
Committed on 08/12/2017 at 09:41.
Pushed by bcooksley into branch 'master'.

Complete removal of references to baloodebug.cpp which was deleted in the 
previous commit

CCMAIL: mon...@kde.org
CCMAIL: kde-frameworks-devel@kde.org

M  +0-1src/file/extractor/CMakeLists.txt
M  +0-1src/lib/CMakeLists.txt

https://commits.kde.org/baloo/a7ebc07cad22e3c581960969e779940f992ba320

diff --git a/src/file/extractor/CMakeLists.txt 
b/src/file/extractor/CMakeLists.txt
index 60c55cc2..945310ee 100644
--- a/src/file/extractor/CMakeLists.txt
+++ b/src/file/extractor/CMakeLists.txt
@@ -13,7 +13,6 @@ set(EXTRACTOR_SRCS
   ../storagedevices.cpp
   ../regexpcache.cpp
   ../fileexcludefilters.cpp
-  ../baloodebug.cpp
 )
 
 add_executable(baloo_file_extractor ${EXTRACTOR_SRCS})
diff --git a/src/lib/CMakeLists.txt b/src/lib/CMakeLists.txt
index 08dabdf9..54dcf31b 100644
--- a/src/lib/CMakeLists.txt
+++ b/src/lib/CMakeLists.txt
@@ -22,7 +22,6 @@ set(BALOO_LIB_SRCS
 ../file/storagedevices.cpp
 ../file/regexpcache.cpp
 ../file/fileexcludefilters.cpp
-../file/baloodebug.cpp
 
 searchstore.cpp
 

D9076: Have an application that can cross-check if the promised platforms are correct

[Ben Cooksley]

bcooksley added a comment.


  In principle I think this code is doing the right thing as it's comparing 
what's enabled on CI vs. what's enabled in the Framework's own metadata files.
  Any comments in that regard David?

REPOSITORY
  R857 CI System Tooling

REVISION DETAIL
  https://phabricator.kde.org/D9076

To: apol, #frameworks
Cc: bcooksley, dfaure

Re: Failing KTextEditor unit tests

[Ben Cooksley]

On Wed, Dec 6, 2017 at 9:24 PM, David Faure  wrote:
> On lundi 4 décembre 2017 18:38:50 CET Ben Cooksley wrote:
>> If someone has a list of common font packages for SUSE then I can add
>> those to the image relatively easy, which will probably fix those
>> tests.
>
> dejavu-fonts might be enough.
>
> But otherwise here's a more complete list, from my Leap 42.3 system.
>
> adobe-sourcecodepro-fonts
> adobe-sourcesanspro-fonts
> adobe-sourceserifpro-fonts
> cantarell-fonts
> dejavu-fonts
> google-carlito-fonts
> google-droid-fonts
> google-opensans-fonts
> google-roboto-fonts
> hack-fonts
> kde-oxygen-fonts
> liberation-fonts
> lilypond-century-schoolbook-l-fonts
> lilypond-emmentaler-fonts
> noto-coloremoji-fonts
> noto-emoji-fonts
> noto-sans-fonts
> stix-fonts
> xorg-x11-fonts

Thanks for that list David.

adobe-sourcecodepro-fonts has since been installed in the SUSE images
(all three variations).

Dominik, can you check to see whether the tests are now happy with the
font setup?

>
> --
> David Faure, fa...@kde.org, http://www.davidfaure.fr
> Working on KDE Frameworks 5
>
>
>

Thanks,
Ben

D9241: Emit 'groupHiddenChanged' signal.

[Laurent Montel]

mlaurent accepted this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9241

To: renatoo, franckarrecot, mwolff, mlaurent
Cc: mwolff, #frameworks