D11132: Avoid an asan runtime error

[Jaime Torres Amate]

jtamate added inline comments.

INLINE COMMENTS

> apol wrote in kiconeffect.cpp:44
> To what does this initialize the array?

effect: 0 
value: 0
color: QColor(Invalid)
trans: false
key: ""
color2: QColor(Invalid)

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D11132

To: jtamate, #frameworks
Cc: apol, anthonyfieroni, michaelh

D11038: balooctl: Add prune option to remove stale file index entries

[James Smith]

smithjd retitled this revision from "balooctl: Add pruneDb option to remove 
stale file index entries." to "balooctl: Add prune option to remove stale file 
index entries".

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11038

To: smithjd, #baloo, #frameworks, michaelh
Cc: michaelh, ashaposhnikov, spoorun, nicolasfella, alexeymin

D11038: balooctl: Add pruneDb option to remove stale file index entries.

[James Smith]

smithjd updated this revision to Diff 28987.
smithjd added a comment.


  - balooctl: Clarify the prune option description.

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11038?vs=28747=28987

BRANCH
  master-purgeDb (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11038

AFFECTED FILES
  src/engine/transaction.cpp
  src/engine/transaction.h
  src/tools/balooctl/main.cpp

To: smithjd, #baloo, #frameworks, michaelh
Cc: michaelh, ashaposhnikov, spoorun, nicolasfella, alexeymin

D11038: balooctl: Add pruneDb option to remove stale file index entries.

[James Smith]

smithjd added a comment.


  In D11038#220486 , @michaelh wrote:
  
  > In D11038#219353 , @smithjd 
wrote:
  >
  > > All mounts must be manually made available by the user before running 
this option, or all files on a previously available mount will be removed from 
the index.
  >
  >
  > It is much too easy for users to accidentally ruin their database with 
this. There should at least be a warning message including the advice to mount 
all external items. And users must confirm execution. 
  >  This command also should have a --dry-run option to show users what would 
happen to their database.
  
  
  Adding paths to index on top of the user's home directory requires manual 
modification of the config file, or symlinks into the user's home directory. It 
can be assumed that the user is reasonably competent about destructive options 
if he/she does this. Adding a --dry-run modifier is overkill for regeneratable 
data. Requiring that the user confirm execution is bad practice.
  
  I've changed the option description to more clearly convey that it will 
remove any entry that doesn't have a resolveable file path.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11038

To: smithjd, #baloo, #frameworks, michaelh
Cc: michaelh, ashaposhnikov, spoorun, nicolasfella, alexeymin

D10747: Implement zwp_linux_dmabuf_v1

[Fredrik Höglund]

fredrik updated this revision to Diff 28986.
fredrik added a comment.


  Import the context.

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10747?vs=27735=28986

REVISION DETAIL
  https://phabricator.kde.org/D10747

AFFECTED FILES
  src/client/protocols/linux-dmabuf-unstable-v1.xml
  src/server/CMakeLists.txt
  src/server/buffer_interface.cpp
  src/server/buffer_interface.h
  src/server/display.cpp
  src/server/display.h
  src/server/drm_fourcc.h
  src/server/linuxdmabuf_v1_interface.cpp
  src/server/linuxdmabuf_v1_interface.h

To: fredrik, #kwin, #plasma, graesslin, davidedmundson, mart
Cc: romangg, plasma-devel, #frameworks, schernikov, michaelh, ZrenBot, 
alexeymin, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, 
apol, mart, hein

D10747: Implement zwp_linux_dmabuf_v1

[Roman Gilg]

romangg added a comment.


  Please import the context. This makes reviews more easy. Either via -U9 
flag to git diff or (for future diffs) by using arc directly on a feature 
branch.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D10747

To: fredrik, #kwin, #plasma, graesslin, davidedmundson, mart
Cc: romangg, plasma-devel, #frameworks, schernikov, michaelh, ZrenBot, 
alexeymin, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, 
apol, mart, hein

KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.10 - Build # 15 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.10/15/
 Project:
Frameworks kio kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Wed, 07 Mar 2018 16:13:52 +
 Build duration:
2 hr 12 min and counting
   JUnit Tests
  Name: (root) Failed: 24 test(s), Passed: 29 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: TestSuite.kiocore-deletejobtestFailed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kfileitemtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiocore-ktcpsockettestFailed: TestSuite.kiocore-mkpathjobtestFailed: TestSuite.kiofilewidgets-kfilecopytomenutestFailed: TestSuite.kiofilewidgets-kfilecustomdialogtestFailed: TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: TestSuite.kiofilewidgets-kfileplacesviewtestFailed: TestSuite.kiofilewidgets-kfilewidgettestFailed: TestSuite.kiofilewidgets-knewfilemenutestFailed: TestSuite.kiofilewidgets-kurlnavigatortestFailed: TestSuite.kiowidgets-accessmanagertestFailed: TestSuite.kiowidgets-accessmanagertest-qnamFailed: TestSuite.kiowidgets-dropjobtestFailed: TestSuite.kiowidgets-fileundomanagertestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltestFailed: TestSuite.kiowidgets-krununittestFailed: TestSuite.kiowidgets-kurifiltertestFailed: TestSuite.kiowidgets-kurlcompletiontestFailed: TestSuite.kiowidgets-kurlcompletiontest-nowaitFailed: TestSuite.kpasswdservertest

D10494: update handle- icons for kirigami

[Marco Martin]

mart added a comment.


  As discussed on the channel, the icon should be one of these forms, for me 
are both ok
  F5744901: handle-right.png 
  
  F5744903: handle-left.png 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10494

To: andreask, alex-l, mart
Cc: colomar, matheusm, mmustac, ngraham, #frameworks, michaelh

D11137: overflow-menu as view-more-symbolic, and horizontal

[Marco Martin]

mart changed the visibility from "No One" to "Public (No Login Required)".

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D11137

To: mart, #vdg
Cc: #frameworks, michaelh

D11137: overflow-menu as view-more-symbolic, and horizontal

[Marco Martin]

mart created this revision.
mart added a reviewer: VDG.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
mart requested review of this revision.

REVISION SUMMARY
  use the 3 dots icons as view-more-symbolic, as traditionally in
  the iconography of most systems those are for menus of actions
  that didn't fit in a toolbar (as the overflow-menu name tells)
  while the 3 lines one means the main menu of an application and
  should always appear at most in a single place in a whole app
  this makes it less confusing as users will use our apps together
  apps written in other toolkits, web pages where this is common as
  well, as well apps on their phones which will all use this paradigm.
  
  adapt the horizontal version too, to look like what firefox uses
  tough i would make it black as well, as now it may always look disabled

TEST PLAN
  shown the mixer applet (which will need its own rr) which looks lighter
  and causes less confusion between the global panel menu icon and the little
  overflow menus of the mixer items

REPOSITORY
  R266 Breeze Icons

BRANCH
  phab/overflow

REVISION DETAIL
  https://phabricator.kde.org/D11137

AFFECTED FILES
  icons-dark/actions/symbolic/view-more-horizontal-symbolic.svg
  icons-dark/actions/symbolic/view-more-symbolic.svg
  icons/actions/symbolic/view-more-horizontal-symbolic.svg
  icons/actions/symbolic/view-more-symbolic.svg

To: mart, #vdg
Cc: #frameworks, michaelh

D11132: Avoid an asan runtime error

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> kiconeffect.cpp:44
> +KIconEffectPrivate():
> +effect{{}}
> +   ,value{{}}

To what does this initialize the array?

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D11132

To: jtamate, #frameworks
Cc: apol, anthonyfieroni, michaelh

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 14 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/14/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.9
 Date of build:
Wed, 07 Mar 2018 16:13:52 +
 Build duration:
17 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(296/444)67%
(296/444)53%
(31615/59630)38%
(18554/48882)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8570/9118)48%
(5233/10797)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)59%
(8417/14351)50%
(4900/9726)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(31/39)79%
(31/39)49%
(3897/7874)33%
(1644/4942)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(511/982)41%
(412/996)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1783/4338)35%
(1375/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1333)55%
(648/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%
(8/12)52%

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 143 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/143/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
 Date of build:
Wed, 07 Mar 2018 16:13:52 +
 Build duration:
13 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 56 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest

D11132: Avoid an asan runtime error

[Jaime Torres Amate]

jtamate updated this revision to Diff 28946.
jtamate added a comment.


  Cleaner initialization, thanks anthonyfieroni.

REPOSITORY
  R302 KIconThemes

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11132?vs=28943=28946

REVISION DETAIL
  https://phabricator.kde.org/D11132

AFFECTED FILES
  src/kiconeffect.cpp

To: jtamate, #frameworks
Cc: anthonyfieroni, michaelh

D11132: Avoid an asan runtime error

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> kiconeffect.cpp:44-49
> +effect{{0}}
> +   ,value{{0.0}}
> +   ,color{{QColor()}}
> +   ,trans{{false}}
> +   ,key{{QString()}}
> +   ,color2{{QColor()}}

You can use {{}} to all

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D11132

To: jtamate, #frameworks
Cc: anthonyfieroni, michaelh

D11132: Avoid an asan runtime error

[Jaime Torres Amate]

jtamate created this revision.
jtamate added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
jtamate requested review of this revision.

REVISION SUMMARY
  Initialize the arrays to the maximum size of the enums and use c++11 
initialization to ensure that all values are set to zero (or equivalent).

TEST PLAN
  execute kdialog --getexistingdirectory smb://
  
  before the patch, the following messages from gcc asan are displayed:
  
  kdesrc/frameworks/kiconthemes/src/kiconeffect.cpp:170:51: runtime error: 
index 3 out of bounds for type 'int [3]'
  kdesrc/frameworks/kiconthemes/src/kiconeffect.cpp:172:51: runtime error: 
index 3 out of bounds for type 'float [3]'
  kdesrc/frameworks/kiconthemes/src/kiconeffect.cpp:174:40: runtime error: 
index 3 out of bounds for type 'bool [3]'
  kdesrc/frameworks/kiconthemes/src/kiconeffect.cpp:176:35: runtime error: 
index 3 out of bounds for type 'int [3]'
  kdesrc/frameworks/kiconthemes/src/kiconeffect.cpp:176:74: runtime error: 
index 3 out of bounds for type 'int [3]'
  kdesrc/frameworks/kiconthemes/src/kiconeffect.cpp:180:35: runtime error: 
index 3 out of bounds for type 'int [3]'
  
  This runtime error is not shown any more.

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D11132

AFFECTED FILES
  src/kiconeffect.cpp

To: jtamate, #frameworks
Cc: michaelh

D11123: Add X-KDE-OnlyShowOnQtPlatforms to KDEDModule servicetype definition

[Friedrich W . H . Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R297:665c3dd5b248: Add X-KDE-OnlyShowOnQtPlatforms to 
KDEDModule servicetype definition (authored by kossebau).

REPOSITORY
  R297 KDED

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11123?vs=28931=28941

REVISION DETAIL
  https://phabricator.kde.org/D11123

AFFECTED FILES
  src/kdedmodule.desktop

To: kossebau, #plasma, mart, apol
Cc: #frameworks, michaelh

D11125: Add X-KDE-OnlyShowOnQtPlatforms to KCModule servicetype definition

[Friedrich W . H . Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R295:0182bc404807: Add X-KDE-OnlyShowOnQtPlatforms to KCModule 
servicetype definition (authored by kossebau).

REPOSITORY
  R295 KCMUtils

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11125?vs=28932=28939

REVISION DETAIL
  https://phabricator.kde.org/D11125

AFFECTED FILES
  src/kcmodule.desktop

To: kossebau, #plasma, mart, apol
Cc: #frameworks, michaelh

D11125: Add X-KDE-OnlyShowOnQtPlatforms to KCModule servicetype definition

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R295 KCMUtils

BRANCH
  addmissingdefinitionX-KDE-OnlyShowOnQtPlatforms

REVISION DETAIL
  https://phabricator.kde.org/D11125

To: kossebau, #plasma, mart, apol
Cc: #frameworks, michaelh

D11123: Add X-KDE-OnlyShowOnQtPlatforms to KDEDModule servicetype definition

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R297 KDED

BRANCH
  addmissingdefinitionX-KDE-OnlyShowOnQtPlatforms

REVISION DETAIL
  https://phabricator.kde.org/D11123

To: kossebau, #plasma, mart, apol
Cc: #frameworks, michaelh

D11130: Disable deprecation warning from kpackage_install_package for now

[Friedrich W . H . Kossebau]

kossebau added a project: Plasma.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D11130

To: kossebau, mart, apol
Cc: #frameworks, michaelh, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11129: Mark kpackage_install_package undeprecated for plasma_install_package

[Friedrich W . H . Kossebau]

kossebau added a dependent revision: D11130: Disable deprecation warning from 
kpackage_install_package for now.

REPOSITORY
  R290 KPackage

REVISION DETAIL
  https://phabricator.kde.org/D11129

To: kossebau, mart, apol
Cc: #frameworks, michaelh

D11130: Disable deprecation warning from kpackage_install_package for now

[Friedrich W . H . Kossebau]

kossebau added a dependency: D11129: Mark kpackage_install_package undeprecated 
for plasma_install_package.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D11130

To: kossebau, mart, apol
Cc: #frameworks, michaelh

D11130: Disable deprecation warning from kpackage_install_package for now

[Friedrich W . H . Kossebau]

kossebau created this revision.
kossebau added reviewers: mart, apol.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
kossebau requested review of this revision.

REVISION SUMMARY
  Using a private flag just added for plasma_install_package, until
  there is a new official replacement for kpackage_install_package for
  its needs

TEST PLAN
  kdeplasma-addons & Co still build and now have clean cmake log again.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  allowdeprecatedwarningdisabling

REVISION DETAIL
  https://phabricator.kde.org/D11130

AFFECTED FILES
  KF5PlasmaMacros.cmake

To: kossebau, mart, apol
Cc: #frameworks, michaelh

D11129: Mark kpackage_install_package undeprecated for plasma_install_package

[Friedrich W . H . Kossebau]

kossebau created this revision.
kossebau added reviewers: mart, apol.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
kossebau requested review of this revision.

REVISION SUMMARY
  While no-one is working on porting plasma_install_package away from
  kpackage_install_package, and given this results in long logs of
  deprecation warnings for Plasma repo, for now enable
  plasma_install_package to disable the deprecation warning with a
  undocumented flag.

REPOSITORY
  R290 KPackage

BRANCH
  allowdeprecatedwarningdisabling

REVISION DETAIL
  https://phabricator.kde.org/D11129

AFFECTED FILES
  KF5PackageMacros.cmake

To: kossebau, mart, apol
Cc: #frameworks, michaelh

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 90 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/90/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 07 Mar 2018 14:54:12 +
 Build duration:
7 min 18 sec and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(55/159)35%
(55/159)27%
(3560/13344)19%
(1979/10565)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)53%
(609/1139)28%
(421/1490)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/447)0%
(0/239)src.declarativeimports.core22%
(4/18)22%
(4/18)11%
(254/2235)7%
(102/1492)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/522)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1442/3488)28%
(827/2913)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)42%
(671/1612)28%
(318/1121)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)28%
(553/2009)17%
(306/1771)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1158)0%
(0/1056)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%
(0/2)tests.kplugins0%
  

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 65 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/65/
 Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9
 Date of build:
Wed, 07 Mar 2018 14:54:12 +
 Build duration:
3 min 12 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest

D11125: Add X-KDE-OnlyShowOnQtPlatforms to KCModule servicetype definition

[Friedrich W . H . Kossebau]

kossebau added a comment.


  And seems there is also code for handling X-KDE-NotShowOnQtPlatforms in 
`KService::showOnCurrentPlatform()` (but not in kded custom code).
  lxr.kde.org tells that method is used by
  
  - plasma-phone-components/containments/homescreen/applicationlistmodel.cpp -> 
seems to use it as custom key extension to "Application" type, so would need 
custom documentation, ignoring for now
  - powerdevil/daemon/powerdevilactionpool.cpp -> PowerDevil/Action 
servicetype, without any definition, though also no service plugins found, 
ignoring for now
  
  Just mentioning for completeness, perhaps interesting to someone.

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D11125

To: kossebau, #plasma, mart
Cc: #frameworks, michaelh

D1231: Add Remote Access interface to KWayland

[Oleg Chernovskiy]

Kanedias added a comment.


  @graesslin , @davidedmundson , please approve this once again, this was 
updated numerous times after initial review

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D1231

To: Kanedias, graesslin, davidedmundson, romangg
Cc: jgrulich, romangg, ngraham, alexeymin, #frameworks, davidedmundson, 
plasma-devel, schernikov, michaelh, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, eliasp, sebas, apol, mart, hein

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.10 - Build # 41 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.10/41/
 Project:
Frameworks baloo kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 07 Mar 2018 13:49:12 +
 Build duration:
5 min 7 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: TestSuite.kinotifytest

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.9 - Build # 8 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.9/8/
 Project:
Frameworks baloo kf5-qt5 SUSEQt5.9
 Date of build:
Wed, 07 Mar 2018 13:49:12 +
 Build duration:
3 min 9 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: TestSuite.kinotifytest

D10712: balooctl monitor: Resume to wait for service

[Michael Heidelbach]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:add3284efdca: balooctl monitor: Resume to wait for 
service (authored by michaelh).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10712?vs=28909=28933

REVISION DETAIL
  https://phabricator.kde.org/D10712

AFFECTED FILES
  src/tools/balooctl/monitorcommand.cpp
  src/tools/balooctl/monitorcommand.h

To: michaelh, #baloo, #frameworks, dfaure, alexeymin, mwolff
Cc: mwolff, ashaposhnikov, michaelh, spoorun, nicolasfella, alexeymin

D11125: Add X-KDE-OnlyShowOnQtPlatforms to KCModule servicetype definition

[Friedrich W . H . Kossebau]

kossebau created this revision.
kossebau added reviewers: Plasma, mart.
Restricted Application added a project: Frameworks.
kossebau requested review of this revision.

REVISION SUMMARY
  KCoreAddons' DesktopFileParser needs a definition of the types of all
  possible entries to do a proper conversion to JSON types.
  It is also nicer for plugin developers to have that type documented.

REPOSITORY
  R295 KCMUtils

BRANCH
  addmissingdefinitionX-KDE-OnlyShowOnQtPlatforms

REVISION DETAIL
  https://phabricator.kde.org/D11125

AFFECTED FILES
  src/kcmodule.desktop

To: kossebau, #plasma, mart
Cc: #frameworks, michaelh

D10712: balooctl monitor: Resume to wait for service

[Milian Wolff]

mwolff accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  resume-wait (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10712

To: michaelh, #baloo, #frameworks, dfaure, alexeymin, mwolff
Cc: mwolff, ashaposhnikov, michaelh, spoorun, nicolasfella, alexeymin

D11123: Add X-KDE-OnlyShowOnQtPlatforms to KDEDModule servicetype definition

[Friedrich W . H . Kossebau]

kossebau created this revision.
kossebau added reviewers: Plasma, mart.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
kossebau requested review of this revision.

REVISION SUMMARY
  KCoreAddons' DesktopFileParser needs a definition of the types of all
  possible entries to do a proper conversion to JSON types.

TEST PLAN
  kded no longer complains
  
Expected JSON property "X-KDE-OnlyShowOnQtPlatforms" to be a string list.
  
  when loading kded_touchpad module which has in the metadata
  
X-KDE-OnlyShowOnQtPlatforms=xcb;

REPOSITORY
  R297 KDED

BRANCH
  addmissingdefinitionX-KDE-OnlyShowOnQtPlatforms

REVISION DETAIL
  https://phabricator.kde.org/D11123

AFFECTED FILES
  src/kdedmodule.desktop

To: kossebau, #plasma, mart
Cc: #frameworks, michaelh

Re: GSOC 2018: KDE Season Website

[Kanishkar J]

Hello
This is a gentle reminder to kindly look into my request to allow me to
work under you in this summer of code.
I shall be highly obliged.

Thank you

On 04-Mar-2018 2:10 AM, "Kanishkar J"  wrote:

> Hello,
>
> I am Kanishkar J, I am looking forward to contribute to KDE and be part of
> GSOC 2018. I have worked quite heavily on full stack web application
> development. I am really excited about working with the re-build of the KDE
> Season Website. My GitHub profile :
> https://github.com/kanishkarj
> As this project is to start off from scratch I would like to know how to
> get started contributing to the code-base. I need some guidance to start
> off with contributing. Any help would be highly appreciated.
>
> Thank You
>
> regards
> Kanishkar J
> Department of Computer Science and Engineering
> Indian Institute of Technology Indore, India
>
>

D11107: [KProtocolInfoFactory] Don't clear cache if it had just been built

[Kai Uwe Broulik]

broulik added a comment.


  +1

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11107

To: hein, #frameworks, broulik
Cc: michaelh

D11107: [KProtocolInfoFactory] Don't clear cache if it had just been built

[Eike Hein]

hein updated this revision to Diff 28916.
hein added a comment.


  Slightly cleaner approach.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11107?vs=28885=28916

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11107

AFFECTED FILES
  src/core/kprotocolinfofactory.cpp
  src/core/kprotocolinfofactory_p.h

To: hein, #frameworks, broulik
Cc: michaelh

D11107: [KProtocolInfoFactory] Don't clear cache if it had just been built

[Eike Hein]

hein commandeered this revision.
hein edited reviewers, added: broulik; removed: hein.
hein added a comment.


  Commandeering as agreed upon with Kai, new rev in a moment.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11107

To: hein, #frameworks, broulik
Cc: michaelh

D10712: balooctl monitor: Resume to wait for service

[Michael Heidelbach]

michaelh added inline comments.

INLINE COMMENTS

> mwolff wrote in monitorcommand.cpp:45
> just make it i18n("Baloo died"), though I personally think that message 
> should be improved - maybe "Baloo became unavailable" ?
> 
> also, call `balooIsNotAvailable()` from the slot here, that way you safe one 
> connection. Or just move the m_err output to the `balooIsNotAvailable` slot.

Can be removed completely.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D10712

To: michaelh, #baloo, #frameworks, dfaure, alexeymin, mwolff
Cc: mwolff, ashaposhnikov, michaelh, spoorun, nicolasfella, alexeymin

D10712: balooctl monitor: Resume to wait for service

[Michael Heidelbach]

michaelh updated this revision to Diff 28909.
michaelh marked 8 inline comments as done.
michaelh edited the test plan for this revision.
michaelh added a comment.


  - Apply suggested changes

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10712?vs=27678=28909

BRANCH
  resume-wait (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10712

AFFECTED FILES
  src/tools/balooctl/monitorcommand.cpp
  src/tools/balooctl/monitorcommand.h

To: michaelh, #baloo, #frameworks, dfaure, alexeymin, mwolff
Cc: mwolff, ashaposhnikov, michaelh, spoorun, nicolasfella, alexeymin

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 89 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/89/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 07 Mar 2018 10:16:56 +
 Build duration:
13 min and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(55/159)35%
(55/159)27%
(3560/13344)19%
(1979/10565)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)53%
(609/1139)28%
(421/1490)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/447)0%
(0/239)src.declarativeimports.core22%
(4/18)22%
(4/18)11%
(254/2235)7%
(102/1492)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/522)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1442/3488)28%
(827/2913)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)42%
(671/1612)28%
(318/1121)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)28%
(553/2009)17%
(306/1771)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1158)0%
(0/1056)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%
(0/2)tests.kplugins0%

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 64 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/64/
 Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9
 Date of build:
Wed, 07 Mar 2018 10:16:56 +
 Build duration:
11 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest

D11107: [KProtocolInfoFactory] Don't clear cache if it had just been built

[Eike Hein]

hein added a comment.


  Good idea, but every time one of those state tracking bools get copied my 
mind screams "BAD PATTERN". It's not the fault of your patch but I don't like 
how this cache handling is written - it'd be cleaner if fillCache had a return 
value for "I actually did work" and if the meaning of m_allProtocolsLoaded got 
inverted to being a dirty bit, so fillCache() itself can take care of the cache 
eviction code (qDeleteAll etc.) if dirty is set. Doing this instead creates a 
"now every time you want to change things you have to read site first and copy 
some boiler plate" situation.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11107

To: broulik, #frameworks, hein
Cc: michaelh

D10776: Make it possible to generate po files in parallel

[Harald Sitter]

sitter added inline comments.

INLINE COMMENTS

> build-tsfiles.cmake:75
>  ${pmapc_file}
>  RESULT_VARIABLE code
>  )

This doesn't belong here, does it? It's also defined in execute_process() and 
from looking at the docs it would only be set once.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D10776

To: apol, #frameworks, sitter
Cc: michaelh

D11112: Hide KUrlNavigatorProtocolCombo if there is just one protocol supported

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
broulik requested review of this revision.

REVISION SUMMARY
  There's no point in showing a drop down selection for exactly one protocol.

TEST PLAN
  Follow-up to D1 
  
  - Verified that it shows up when all protocols are allowed
  - Verified that it doesn't show up when there is just file protocol (e.g. 
just "file") allowed

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D2

AFFECTED FILES
  src/filewidgets/kurlnavigator.cpp

To: broulik, #frameworks
Cc: michaelh

D10712: balooctl monitor: Resume to wait for service

[Milian Wolff]

mwolff requested changes to this revision.
mwolff added a comment.
This revision now requires changes to proceed.


  some minor comments, otherwise lgtm

INLINE COMMENTS

> monitorcommand.cpp:45
> +connect(m_dbusServiceWatcher, ::serviceUnregistered, 
> [this]() {
> +m_err << i18nc("Application", "%1 died", "Baloo") << endl;
> +});

just make it i18n("Baloo died"), though I personally think that message should 
be improved - maybe "Baloo became unavailable" ?

also, call `balooIsNotAvailable()` from the slot here, that way you safe one 
connection. Or just move the m_err output to the `balooIsNotAvailable` slot.

> monitorcommand.cpp:61
> +if (m_dbusInterface->isValid()) {
> +m_err << i18n("Press ctrl+c to exit monitor") << endl;
> +balooIsAvailable();

`Press Ctrl + C to stop monitoring`

> monitorcommand.cpp:65
> +balooIsNotAvailable();
> +}
> +}

add a

  m_dbusServiceWatcher->setWatchMode(QDBusServiceWatcher::WatchForOwnerChange);

> monitorcommand.cpp:71
> +m_dbusInterface->unregisterMonitor();
> +m_err << i18nc("Application", "Waiting for %1 to start", "Baloo") << 
> endl;
> +m_err << i18n("Press ctrl+c to exit monitor") << endl;

see above: `i18n("Waiting for Baloo to start")`

> monitorcommand.cpp:72
> +m_err << i18nc("Application", "Waiting for %1 to start", "Baloo") << 
> endl;
> +m_err << i18n("Press ctrl+c to exit monitor") << endl;
> +

see above

> monitorcommand.cpp:74
> +
> +
> m_dbusServiceWatcher->setWatchMode(QDBusServiceWatcher::WatchForRegistration);
> +}

remove this

> monitorcommand.cpp:80
> +m_dbusInterface->registerMonitor();
> +m_err << i18nc("Application", "%1 is running", "Baloo") << endl;
> +

see above: i18n("Baloo is running")

> monitorcommand.cpp:82
> +
> +
> m_dbusServiceWatcher->setWatchMode(QDBusServiceWatcher::WatchForUnregistration);
> + 

remove this

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D10712

To: michaelh, #baloo, #frameworks, dfaure, alexeymin, mwolff
Cc: mwolff, ashaposhnikov, michaelh, spoorun, nicolasfella, alexeymin

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 88 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/88/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 07 Mar 2018 09:34:06 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(55/159)35%
(55/159)27%
(3560/13344)19%
(1979/10565)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)53%
(609/1139)28%
(421/1490)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/447)0%
(0/239)src.declarativeimports.core22%
(4/18)22%
(4/18)11%
(254/2235)7%
(102/1492)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/522)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1442/3488)28%
(827/2913)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)42%
(671/1612)28%
(318/1121)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)28%
(553/2009)17%
(306/1771)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1158)0%
(0/1056)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%
(0/2)tests.kplugins0%

D11038: balooctl: Add pruneDb option to remove stale file index entries.

[Michael Heidelbach]

michaelh requested changes to this revision.
michaelh added a comment.
This revision now requires changes to proceed.


  In D11038#219353 , @smithjd wrote:
  
  > All mounts must be manually made available by the user before running this 
option, or all files on a previously available mount will be removed from the 
index.
  
  
  It is much too easy for users to accidentally ruin their database with this. 
There should at least be a warning message including the advice to mount all 
external items. And users must confirm execution. 
  This command also should have a --dry-run option to show users what would 
happen to their database.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11038

To: smithjd, #baloo, #frameworks, michaelh
Cc: michaelh, ashaposhnikov, spoorun, nicolasfella, alexeymin

D11054: Add media status icons

[Roman Gilg]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:a8e858933ab9: Add media status icons (authored by 
romangg).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11054?vs=28704=28900

REVISION DETAIL
  https://phabricator.kde.org/D11054

AFFECTED FILES
  icons-dark/status/16/media-playback-paused.svg
  icons-dark/status/16/media-playback-playing.svg
  icons-dark/status/16/media-playback-stopped.svg
  icons-dark/status/22/media-playback-paused.svg
  icons-dark/status/22/media-playback-playing.svg
  icons-dark/status/22/media-playback-stopped.svg
  icons-dark/status/24/media-playback-paused.svg
  icons-dark/status/24/media-playback-playing.svg
  icons-dark/status/24/media-playback-stopped.svg
  icons/status/16/media-playback-paused.svg
  icons/status/16/media-playback-playing.svg
  icons/status/16/media-playback-stopped.svg
  icons/status/22/media-playback-paused.svg
  icons/status/22/media-playback-playing.svg
  icons/status/22/media-playback-stopped.svg
  icons/status/24/media-playback-paused.svg
  icons/status/24/media-playback-playing.svg
  icons/status/24/media-playback-stopped.svg

To: romangg, #plasma, #frameworks, #vdg, andreask, ngraham
Cc: ngraham, michaelh

D11038: balooctl: Add pruneDb option to remove stale file index entries.

[Michael Heidelbach]

michaelh added a reviewer: michaelh.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11038

To: smithjd, #baloo, #frameworks, michaelh
Cc: michaelh, ashaposhnikov, spoorun, nicolasfella, alexeymin

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 63 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/63/
 Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9
 Date of build:
Wed, 07 Mar 2018 09:34:05 +
 Build duration:
5 min 20 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-dialogstatetestFailed: TestSuite.plasma-packagestructuretest

D11050: Remove frames around media buttons

[Roman Gilg]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:812b32fb0559: Remove frames around media buttons 
(authored by romangg).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11050?vs=28692=28899

REVISION DETAIL
  https://phabricator.kde.org/D11050

AFFECTED FILES
  src/desktoptheme/breeze/icons/media.svgz

To: romangg, #frameworks, #plasma, ngraham
Cc: ngraham, mart, michaelh

D11037: balooctl: checkDb should also verify the last known url for the documentId.

[Michael Heidelbach]

michaelh accepted this revision as: michaelh.
michaelh added a comment.
This revision is now accepted and ready to land.


  In D11037#219358 , @smithjd wrote:
  
  > This change includes orphan file entries as invalid database entries in 
checkFsTree().
  
  
  Currently it is unreachable, because the 'checkDb' options has been removed 
in D10778 . Please consider to create an 
executable for checkdb in `tests/` folder.

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11037

To: smithjd, #baloo, michaelh
Cc: michaelh, #frameworks, ashaposhnikov, spoorun, nicolasfella, alexeymin

D11049: Remove frame around media action icons

[Roman Gilg]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:106b27347125: Remove frame around media action icons 
(authored by romangg).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D11049?vs=28689=28898#toc

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11049?vs=28689=28898

REVISION DETAIL
  https://phabricator.kde.org/D11049

AFFECTED FILES
  icons-dark/actions/16/media-playback-pause.svg
  icons-dark/actions/16/media-playback-start.svg
  icons-dark/actions/16/media-playback-stop.svg
  icons-dark/actions/16/media-record.svg
  icons-dark/actions/16/media-seek-backward.svg
  icons-dark/actions/16/media-seek-forward.svg
  icons-dark/actions/16/media-skip-backward.svg
  icons-dark/actions/16/media-skip-forward.svg
  icons-dark/actions/22/media-playback-pause.svg
  icons-dark/actions/22/media-playback-start.svg
  icons-dark/actions/22/media-playback-stop.svg
  icons-dark/actions/22/media-seek-backward.svg
  icons-dark/actions/22/media-seek-forward.svg
  icons-dark/actions/22/media-skip-backward.svg
  icons-dark/actions/22/media-skip-forward.svg
  icons-dark/actions/24/media-playback-pause.svg
  icons-dark/actions/24/media-playback-start.svg
  icons-dark/actions/24/media-playback-stop.svg
  icons-dark/actions/24/media-record.svg
  icons-dark/actions/24/media-seek-backward.svg
  icons-dark/actions/24/media-seek-forward.svg
  icons-dark/actions/24/media-skip-backward.svg
  icons-dark/actions/24/media-skip-forward.svg
  icons-dark/actions/32/media-playback-pause.svg
  icons-dark/actions/32/media-playback-start.svg
  icons-dark/actions/32/media-playback-stop.svg
  icons-dark/actions/32/media-record.svg
  icons-dark/actions/32/media-seek-backward.svg
  icons-dark/actions/32/media-seek-forward.svg
  icons-dark/actions/32/media-skip-backward.svg
  icons-dark/actions/32/media-skip-forward.svg
  icons/actions/16/media-playback-pause.svg
  icons/actions/16/media-playback-start.svg
  icons/actions/16/media-playback-stop.svg
  icons/actions/16/media-record.svg
  icons/actions/16/media-seek-backward.svg
  icons/actions/16/media-seek-forward.svg
  icons/actions/16/media-skip-backward.svg
  icons/actions/16/media-skip-forward.svg
  icons/actions/22/media-playback-pause.svg
  icons/actions/22/media-playback-start.svg
  icons/actions/22/media-playback-stop.svg
  icons/actions/22/media-seek-backward.svg
  icons/actions/22/media-seek-forward.svg
  icons/actions/22/media-skip-backward.svg
  icons/actions/22/media-skip-forward.svg
  icons/actions/24/media-playback-pause.svg
  icons/actions/24/media-playback-start.svg
  icons/actions/24/media-playback-stop.svg
  icons/actions/24/media-record.svg
  icons/actions/24/media-seek-backward.svg
  icons/actions/24/media-seek-forward.svg
  icons/actions/24/media-skip-backward.svg
  icons/actions/24/media-skip-forward.svg
  icons/actions/32/media-playback-pause.svg
  icons/actions/32/media-playback-start.svg
  icons/actions/32/media-playback-stop.svg
  icons/actions/32/media-record.svg
  icons/actions/32/media-seek-backward.svg
  icons/actions/32/media-seek-forward.svg
  icons/actions/32/media-skip-backward.svg
  icons/actions/32/media-skip-forward.svg

To: romangg, #breeze, #vdg, andreask, ngraham
Cc: ngraham, mart, #frameworks, michaelh

D11037: balooctl: checkDb should also verify the last known url for the documentId.

[Michael Heidelbach]

michaelh added a reviewer: michaelh.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11037

To: smithjd, #baloo, michaelh
Cc: michaelh, #frameworks, ashaposhnikov, spoorun, nicolasfella, alexeymin

D11111: Only show supported schemes in KUrlNavigatorProtocolCombo

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
broulik requested review of this revision.

TEST PLAN
  Cleared address bar, clicked the protocol selector.
  Before I would get all protocols regardless of whether I could actually 
navigate to them, now only supported ones are listed.
  In `getopenfilename` I only get "file" now, but `getopenurl` is unaffected 
and can still access and navigate to all protocols
  F5744318: Screenshot_20180307_102049.png 


REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D1

AFFECTED FILES
  src/filewidgets/kfilewidget.cpp
  src/filewidgets/kurlnavigator.h

To: broulik, #frameworks
Cc: michaelh

Phabricator Notification Mails

[Ben Cooksley]

Hi all,

It has been brought to my attention that some find that they are
receiving too much mail or other notifications from Phabricator. For
those who are unaware there are numerous options available within
Phabricator to allow you to control how much it notifies you of
changes.

To customise the notices you receive, open your account settings
(available from the dropdown menu beside your avatar in the top
menubar, or at https://phabricator.kde.org/settings/) and select the
"Email Preferences" section.

You can choose to receive email, just receive an in-Phabricator
notification, or receive nothing at all for the various categories
provided there.

In the case of mailing lists, Sysadmin also has the option of
customising these for the list itself as well. Should people wish to
have this changed please bring it up on the list itself then file a
ticket once a consensus has been reached. Unfortunately Community
Admins do not have the ability to change these settings.

If you are receiving duplicate email for a project (because you are
also subscribed to it's mailing list) then Phabricator also allows you
to disable this by opening the Project, browsing to Members and
selecting the "Disable Mail" option.

If a large number of people find themselves needing to use the
"Disable Mail" option then we may need to reconsider how we are
currently setting up Herald rules (currently we subscribe the Project
and rely on the mailing list being a member of the Project to send
mail to the list - this also has the added benefit of looping the list
in on changes to tasks without needing an additional Herald rule).

Cheers,
Ben

Phabricator Notification Mails

[Ben Cooksley]

Hi all,

It has been brought to my attention that some find that they are
receiving too much mail or other notifications from Phabricator. For
those who are unaware there are numerous options available within
Phabricator to allow you to control how much it notifies you of
changes.

To customise the notices you receive, open your account settings
(available from the dropdown menu beside your avatar in the top
menubar, or at https://phabricator.kde.org/settings/) and select the
"Email Preferences" section.

You can choose to receive email, just receive an in-Phabricator
notification, or receive nothing at all for the various categories
provided there.

In the case of mailing lists, Sysadmin also has the option of
customising these for the list itself as well. Should people wish to
have this changed please bring it up on the list itself then file a
ticket once a consensus has been reached. Unfortunately Community
Admins do not have the ability to change these settings.

If you are receiving duplicate email for a project (because you are
also subscribed to it's mailing list) then Phabricator also allows you
to disable this by opening the Project, browsing to Members and
selecting the "Disable Mail" option.

If a large number of people find themselves needing to use the
"Disable Mail" option then we may need to reconsider how we are
currently setting up Herald rules (currently we subscribe the Project
and rely on the mailing list being a member of the Project to send
mail to the list - this also has the added benefit of looping the list
in on changes to tasks without needing an additional Herald rule).

Cheers,
Ben

Phabricator Notification Mails

[Ben Cooksley]

Hi all,

It has been brought to my attention that some find that they are
receiving too much mail or other notifications from Phabricator. For
those who are unaware there are numerous options available within
Phabricator to allow you to control how much it notifies you of
changes.

To customise the notices you receive, open your account settings
(available from the dropdown menu beside your avatar in the top
menubar, or at https://phabricator.kde.org/settings/) and select the
"Email Preferences" section.

You can choose to receive email, just receive an in-Phabricator
notification, or receive nothing at all for the various categories
provided there.

In the case of mailing lists, Sysadmin also has the option of
customising these for the list itself as well. Should people wish to
have this changed please bring it up on the list itself then file a
ticket once a consensus has been reached. Unfortunately Community
Admins do not have the ability to change these settings.

If you are receiving duplicate email for a project (because you are
also subscribed to it's mailing list) then Phabricator also allows you
to disable this by opening the Project, browsing to Members and
selecting the "Disable Mail" option.

If a large number of people find themselves needing to use the
"Disable Mail" option then we may need to reconsider how we are
currently setting up Herald rules (currently we subscribe the Project
and rely on the mailing list being a member of the Project to send
mail to the list - this also has the added benefit of looping the list
in on changes to tasks without needing an additional Herald rule).

Cheers,
Ben

D11099: Fix compilation on Android

[Volker Krause]

vkrause added a comment.


  I also needed API level 21 to make this work, but this changes seemed 
necessary independent of that, and matches what the above method does for 
KSDC_TIMEOUTS_SUPPORTED.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D11099

To: vkrause, #frameworks
Cc: apol, michaelh

D10712: balooctl monitor: Resume to wait for service

[Michael Heidelbach]

michaelh added a comment.


  *ping*

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D10712

To: michaelh, #baloo, #frameworks, dfaure, alexeymin
Cc: ashaposhnikov, michaelh, spoorun, nicolasfella, alexeymin