D10492: add 64px media icons for elisa

[Henrik Fehlauer]

rkflx added a comment.


  @astippich FWIW, I also think the current approach of using different icon 
styles per size under the same name is problematic, not only for HiDPI. More in 
D10770#213782  and D10770#215069 
. Not sure how to best approach 
fixing this, though :/
  
  Also, make sure to check out what will become 5.45 of `breeze-icons`. You 
might be in for a surprise (at least if you like fine and thin lines).

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10492

To: andreask
Cc: rkflx, astippich, ngraham, #frameworks, michaelh

D10309: device: define StateChangeReason and MeteredStatus as Q_ENUMs

[Christoph Feck]

This revision was automatically updated to reflect the committed changes.
Closed by commit R282:cf483541f6a1: device: define StateChangeReason and 
MeteredStatus as Q_ENUMs (authored by Aleksander Morgado Juez 
aleksander_morg...@mm.st, committed by cfeck).

REPOSITORY
  R282 NetworkManagerQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10309?vs=26534=29637

REVISION DETAIL
  https://phabricator.kde.org/D10309

AFFECTED FILES
  src/device.h

To: aleksanderm, #frameworks, jgrulich
Cc: michaelh, ngraham

D11331: add gaming_input devices and others to Battery

[Florian Dollinger]

dollinger updated this revision to Diff 29636.
dollinger added a comment.


  I'm not sure where to add that enum you mentioned since there is already one 
in `frontend\battery.h`:
  
enum BatteryType { UnknownBattery, PdaBattery, UpsBattery,
   PrimaryBattery, MouseBattery, KeyboardBattery,
   KeyboardMouseBattery, CameraBattery,
   PhoneBattery, MonitorBattery
 };
  
  But what we need is:
  
typedef enum {
UP_DEVICE_KIND_UNKNOWN,
UP_DEVICE_KIND_LINE_POWER,
UP_DEVICE_KIND_BATTERY,
UP_DEVICE_KIND_UPS,
UP_DEVICE_KIND_MONITOR,
UP_DEVICE_KIND_MOUSE,
UP_DEVICE_KIND_KEYBOARD,
UP_DEVICE_KIND_PDA,
UP_DEVICE_KIND_PHONE,
UP_DEVICE_KIND_MEDIA_PLAYER,
UP_DEVICE_KIND_TABLET,
UP_DEVICE_KIND_COMPUTER,
UP_DEVICE_KIND_GAMING_INPUT,
UP_DEVICE_KIND_LAST
} UpDeviceKind;

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11331?vs=29504=29636

REVISION DETAIL
  https://phabricator.kde.org/D11331

AFFECTED FILES
  src/solid/devices/backends/upower/upowerdevice.cpp

To: dollinger, broulik, #plasma
Cc: aleksejshilin, #frameworks, michaelh, ngraham

D11360: provide sample rate in kHz

[Nathaniel Graham]

ngraham added a reviewer: Baloo.

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D11360

To: astippich, #frameworks, #baloo
Cc: elvisangelaccio, ashaposhnikov, astippich, spoorun, nicolasfella, alexeymin

D11360: provide sample rate in kHz

[Elvis Angelaccio]

elvisangelaccio added inline comments.

INLINE COMMENTS

> widgetfactory.cpp:126
>  valueString = i18nc("@label bitrate (per second)", "%1/s", 
> form.formatByteSize(value.toInt(), 1, KFormat::MetricBinaryDialect));
> +} else if (prop == QStringLiteral("sampleRate")) {
> +valueString = i18nc("@label samplerate in kilohertz", "%1 kHz", 
> QLocale().toString(value.toDouble()/1000,'f', 1));

Please use `QLatin1String` for comparisons.

> widgetfactory.cpp:127
> +} else if (prop == QStringLiteral("sampleRate")) {
> +valueString = i18nc("@label samplerate in kilohertz", "%1 kHz", 
> QLocale().toString(value.toDouble()/1000,'f', 1));
>  } else if (prop == QLatin1String("releaseYear")) {

This could show "48,0 kHz". Is that what we want?

Also, please add spaces before/after the division operator.

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D11360

To: astippich, #frameworks
Cc: elvisangelaccio, ashaposhnikov, astippich, spoorun, nicolasfella, alexeymin

D9871: Add partial busy-widget support

[Oleg Chernovskiy]

Kanedias abandoned this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D9871

To: Kanedias, apol, colomar, andreask
Cc: #frameworks, michaelh, ngraham

Re: GSOC 2018 Application

[Harindu Dilshan]

Thank you, I will do that.

On Thu, Mar 15, 2018, 12:14 PM Sagar Hani  wrote:

>
>
> On Thu, Mar 15, 2018 at 9:09 AM, Harindu Dilshan <
> harindudilsha...@gmail.com> wrote:
>
>>
>> Hi
>> I am planning to apply for KGpg project for GSOC 2018. I would be
>> grateful if you could review my application.
>>
>> https://docs.google.com/document/d/1P9KuR2kS7moH77jDJwLePbr9XjaHSFC0QJxMsKONb-E/edit?usp=sharing
>>
>> Thank you.
>> Kavinda
>>
>>
> Hi  Kavinda,
>
> You can submit your draft on GSoC web app for review.
> Please make sure you provide permission to *view *and *comment *for
> others so that mentors can provide their feedback.
>
> Cheers,
> Sagar
>
>
>

D11365: also test for value types in taglibextractortest and fix errors

[Alexander Stippich]

astippich added reviewers: Frameworks, Baloo.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D11365

To: astippich, #frameworks, #baloo
Cc: #frameworks, ashaposhnikov, michaelh, spoorun, nicolasfella, ngraham, 
alexeymin

D11365: also test for value types in taglibextractortest and fix errors

[Alexander Stippich]

astippich created this revision.
Restricted Application added projects: Frameworks, Baloo.
Restricted Application added a subscriber: Frameworks.
astippich requested review of this revision.

REVISION SUMMARY
  taglib tests never tested for the expected value type. add this to the tests 
and fix the resulting errors. also add some more metadata to the samplefiles

TEST PLAN
  Thorough testing with baloo and all users of KFileMetaData

REPOSITORY
  R286 KFileMetaData

BRANCH
  taglib_test

REVISION DETAIL
  https://phabricator.kde.org/D11365

AFFECTED FILES
  autotests/samplefiles/test.flac
  autotests/samplefiles/test.m4a
  autotests/samplefiles/test.mp3
  autotests/samplefiles/test.mpc
  autotests/samplefiles/test.ogg
  autotests/samplefiles/test.opus
  autotests/taglibextractortest.cpp
  src/extractors/taglibextractor.cpp
  src/propertyinfo.cpp

To: astippich
Cc: #frameworks, ashaposhnikov, michaelh, spoorun, nicolasfella, ngraham, 
alexeymin

D11361: add a version containmentForScreen with activity

[Marco Martin]

mart edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D11361

To: mart, #plasma
Cc: #frameworks, michaelh, ngraham

D11361: add a version containmentForScreen with activity

[Marco Martin]

mart added a dependent revision: D11333: introduce the function 
containmentGraphicsItemPreview.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D11361

To: mart, #plasma
Cc: #frameworks, michaelh, ngraham

D11361: add a version containmentForScreen with activity

[Marco Martin]

mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
mart requested review of this revision.

REVISION SUMMARY
  add a version of containmentForScreen which it has the activity.
  which is correct as the activity id of containments in in libplasma side.
  this ensure the correctness of shellCorona createContainmentForActivity
  as now it works also for activities different from the current one

TEST PLAN
  tried with an old plasmashell and is perfectly retrocompatible

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/containmentForScreen

REVISION DETAIL
  https://phabricator.kde.org/D11361

AFFECTED FILES
  src/plasma/corona.cpp
  src/plasma/corona.h
  src/plasma/private/corona_p.h

To: mart, #plasma
Cc: #frameworks, michaelh, ngraham

D11360: provide sample rate in kHz

[Alexander Stippich]

astippich added a reviewer: Frameworks.

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D11360

To: astippich, #frameworks
Cc: ashaposhnikov, spoorun, nicolasfella, alexeymin

D11331: add gaming_input devices and others to Battery

[Алексей Шилин]

aleksejshilin added a comment.


  In D11331#226428 , @dollinger 
wrote:
  
  > Okay :) But what's about the other entries, like `UP_DEVICE_KIND_TABLET`,  
`UP_DEVICE_KIND_MEDIA_PLAYER`?
  >  Is there a reason why they are excluded?
  
  
  The reason is probably that they are missing in the documentation 
 (which is likely 
a bug).

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D11331

To: dollinger, broulik, #plasma
Cc: aleksejshilin, #frameworks, michaelh, ngraham

Re: GSOC 2018 Application

[Sagar Hani]

On Thu, Mar 15, 2018 at 9:09 AM, Harindu Dilshan  wrote:

>
> Hi
> I am planning to apply for KGpg project for GSOC 2018. I would be grateful
> if you could review my application.
> https://docs.google.com/document/d/1P9KuR2kS7moH77jDJwLePbr9
> XjaHSFC0QJxMsKONb-E/edit?usp=sharing
>
> Thank you.
> Kavinda
>
>
Hi  Kavinda,

You can submit your draft on GSoC web app for review.
Please make sure you provide permission to *view *and *comment *for others
so that mentors can provide their feedback.

Cheers,
Sagar

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.9 - Build # 16 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.9/16/
 Project:
Frameworks baloo kf5-qt5 SUSEQt5.9
 Date of build:
Thu, 15 Mar 2018 17:39:08 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 39 test(s), Skipped: 0 test(s), Total: 39 test(s)

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.10 - Build # 48 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.10/48/
 Project:
Frameworks baloo kf5-qt5 SUSEQt5.10
 Date of build:
Thu, 15 Mar 2018 17:39:08 +
 Build duration:
4 min 55 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: TestSuite.kinotifytest

D10910: Add unshadowed opaque variants for Breeze Light and Dark desktop themes

[Nathaniel Graham]

ngraham added a comment.


  Yeah, if you abandon this patch, requesting that the feature be natively 
added would probably be sane.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10910

To: achauvel
Cc: ngraham, #frameworks, michaelh

D10809: autotests: Refactor fileindexerconfigtest

[Michael Heidelbach]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:5bacac6b7f03: autotests: Refactor fileindexerconfigtest 
(authored by michaelh).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10809?vs=29472=29618

REVISION DETAIL
  https://phabricator.kde.org/D10809

AFFECTED FILES
  autotests/unit/file/fileindexerconfigtest.cpp
  autotests/unit/file/fileindexerconfigtest.h

To: michaelh, #baloo, #frameworks, ngraham
Cc: broulik, ashaposhnikov, michaelh, spoorun, nicolasfella, ngraham, alexeymin

D10910: Add unshadowed opaque variants for Breeze Light and Dark desktop themes

[Mélanie Chauvel]

achauvel added a comment.


  To add an option to use the fallback of a Plasma theme (i.e. to disable 
shadows and transparency).

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10910

To: achauvel
Cc: ngraham, #frameworks, michaelh

D10918: taglibextractor: Refactor for better readability

[Michael Heidelbach]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:a97308cf9ab8: taglibextractor: Refactor for better 
readability (authored by michaelh).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10918?vs=28268=29617

REVISION DETAIL
  https://phabricator.kde.org/D10918

AFFECTED FILES
  src/extractors/taglibextractor.cpp
  src/extractors/taglibextractor.h

To: michaelh, mgallien, #baloo, #frameworks, astippich
Cc: astippich, ashaposhnikov, michaelh, spoorun, nicolasfella, ngraham, 
alexeymin

D10910: Add unshadowed opaque variants for Breeze Light and Dark desktop themes

[Nathaniel Graham]

ngraham added a comment.


  What bug would you be reporting?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10910

To: achauvel
Cc: ngraham, #frameworks, michaelh

Invoice Corrections for #79/64

[laysrodriguessilva]

Good Morning,



Inserted is the paid invoice for 79/64 03/15/2018 and the credit card receipt 
for the prepay
for m/k 03/15/2018. Thanks!

> http://littlecrafthut.com.au/Summit-Companies-Invoice-1703200/




Many Thanks
laysrodriguessi...@gmail.com

D10910: Add unshadowed opaque variants for Breeze Light and Dark desktop themes

[Mélanie Chauvel]

achauvel added a comment.


  Should I open a bug report on https://bugs.kde.org?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10910

To: achauvel
Cc: ngraham, #frameworks, michaelh

D10492: add 64px media icons for elisa

[Alexander Stippich]

astippich added a comment.


  Sorry for being so late to the party, but I just found this while reading the 
Frameworks 5.44 release notes.
  First of all, I am really grateful for the new icon. Actually, it would be 
really cool if we could also get a colorized version of a "media-artist" icon, 
since we are using a monochrome one there throughout Elisa :)
  
  However, I think how the new icons are implemented here is problematic. You 
added icons with the same name as the monochrome ones, but the new ones look 
totally different. Depending on the icon size Elisa is requesting, we now get a 
different icon. This is also the reason why I created D10293 
.
  Elisa is also using some color overlay effects, which now totally brake. I 
upgraded to Frameworks 5.44, and now Elisa looks like this:
  
  F5755115: Screenshot_20180315_174420.png 

  
  F5755117: Screenshot_20180315_174431.png 

  
  The icon for the tracks view looks now out of place, and doesn't work with 
the color overlay.
  
  Again, thanks for the icons, but I think they should be implemented with 
different names, so that we must add explicit support for them in Elisa. This 
may also effect other applications similarly.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10492

To: andreask
Cc: astippich, ngraham, #frameworks, michaelh

D11331: add gaming_input devices and others to Battery

[Kai Uwe Broulik]

broulik added a comment.


  If you can update your patch to the whitelist you suggested, this could go in.
  If you want you can also look at adding a new type enum (separate to this 
patch I would say), I could guide you through if you want, or just tell me that 
I should do it

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D11331

To: dollinger, broulik, #plasma
Cc: aleksejshilin, #frameworks, michaelh, ngraham

D11331: add gaming_input devices and others to Battery

[Kai Uwe Broulik]

broulik added a comment.


  > Is there a reason why they are excluded?
  
  I don't think there's a particular reason, but there's no type enum in it 
either, so I suppose HAL didn't have it and it wasns't adjusted for when UPower 
came around. I also don't think they're as /common, gamepads are much more 
common. Let's first fix gamepads fully (ie. this patch, then we need a new enum 
in `Solid::Battery` and the powermanagement dataengine in Plasma adjusted as 
well as a new battery icon in the theme etc etc) and then we can look at what 
else makes sense :)

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D11331

To: dollinger, broulik, #plasma
Cc: aleksejshilin, #frameworks, michaelh, ngraham

D10918: taglibextractor: Refactor for better readability

[Alexander Stippich]

astippich accepted this revision.
astippich added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> michaelh wrote in taglibextractor.cpp:331
> I think it is. At this point only `ogg`, `flac` and `opus` should be left.
> Also I only refactored and didn't change the logic, unless I made a mistake 
> that is.

you're right, it was the same way before and it already bugged me there ;)
but since this is a only refactoring, it's probably okay.
note that quite not all mimetypes are handled here compared with the mimetype 
list above (line 58)

REPOSITORY
  R286 KFileMetaData

BRANCH
  taglibextractor (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10918

To: michaelh, mgallien, #baloo, #frameworks, astippich
Cc: astippich, ashaposhnikov, michaelh, spoorun, nicolasfella, ngraham, 
alexeymin

D11320: Fix QVariantMapList operator >> implementation

[Kai Uwe Broulik]

broulik accepted this revision.

REPOSITORY
  R281 ModemManagerQt

BRANCH
  fix-qvariantmaplist-demarshalling

REVISION DETAIL
  https://phabricator.kde.org/D11320

To: aleksanderm, #frameworks, jgrulich, broulik
Cc: broulik, michaelh, ngraham

D10918: taglibextractor: Refactor for better readability

[Michael Heidelbach]

michaelh added inline comments.

INLINE COMMENTS

> taglibextractor.cpp:219
>  
> -// Handling multiple tags in Ogg containers.
> -{

No `if` here

> astippich wrote in taglibextractor.cpp:331
> Yes, but imho we shouldn't even enter the function for mimetypes not having 
> ogg tags. Maybe that is overly careful

I think it is. At this point only `ogg`, `flac` and `opus` should be left.
Also I only refactored and didn't change the logic, unless I made a mistake 
that is.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D10918

To: michaelh, mgallien, #baloo, #frameworks, astippich
Cc: astippich, ashaposhnikov, michaelh, spoorun, nicolasfella, ngraham, 
alexeymin

Re: Would it be good if I became baloo's maintainer?

[Michael Heidelbach]

On 15.03.2018 11:07, Milian Wolff wrote:

On Thursday, March 15, 2018 9:40:34 AM CET Michael Heidelbach wrote:

Hi!

Getting the stuff I do for baloo reviewed takes a lot of time and poking
others. That is considerably slowing me down.

I think it's good to make you the maintainer officially. But while waiting for
reviews my slow you down, it is also usually an extremely valuable source for
learning C++. So independent of of whether you are a maintainer or not, if you
don't yet feel extremely confident with C++, still try to get reviews on
"bigger" stuff. Stuff that you consider harmless you can commit directly.
Milian, I see that exactly the same way! Reviews as a means to learn, 
yes, yes, yes. That is also the reason why I get impatient so easily, 
because I want to learn (faster).

And reviews, the more nit-picky the better, are very gratifying to me.
What I'm pretty confident about, is the decision, when a review is 
needed. But even when I consider something as harmless there's still 
room for improvement (doxygen comments, 'no c-style casts' and the like).

If there's bigger stuff that needs to be reviewed but noone does it in time,
ping us via mailing lists and/or IRC. I don't have a lot of time and don't
follow all review requests. But I learned most of my skills through reviews in
my early KDE times. Thus I feel obliged to give that back to others new to C++
and KDE. I bet this is the same for many others that are around for a long
time!

That's good news.

I'm seriously thinking of becoming the maintainer for baloo (and maybe
baloowidgets). Then it would be easier for me to commit those patches I
consider as harmless e.g unit tests. Unless somebody else jumped in I
intended to maintain baloo eventually anyway. I would do it now(!)
mainly for practical reasons. Due to my lack of experience with c++, the
KDE way of using it and the KDE infrastructure in general I'm somewhat
reluctant. Questions arise:

   * What exactly does it mean to be the maintainer of a project and what
 tasks come with it?
   * What responsibilities come with it?
   * How is that done practically?
   * Do you think it's a good idea to have a newbie maintaining a project
 as deeply integrated into KDE as baloo?
   * What should be my general attitude towards that task?

D11320: Fix QVariantMapList operator >> implementation

[Jan Grulich]

jgrulich accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R281 ModemManagerQt

BRANCH
  fix-qvariantmaplist-demarshalling

REVISION DETAIL
  https://phabricator.kde.org/D11320

To: aleksanderm, #frameworks, jgrulich
Cc: broulik, michaelh, ngraham

D11342: Include the "stdcpp-path" in the json file

[Aleix Pol Gonzalez]

apol added a comment.


  In D11342#226449 , @vkrause wrote:
  
  > Looks sane to me. Probably needs to be adjusted for clang support 
eventually though.
  
  
  Correct, it needs a full refactoring of the script though.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D11342

To: apol, #frameworks, vkrause
Cc: vkrause, #build_system, michaelh, ngraham

D11285: Introduce sanitizer class

[Michael Heidelbach]

michaelh added inline comments.

INLINE COMMENTS

> databasesanitizer.cpp:163
> +/**
> +* Create a list of \a FileInfo items to stdout.
> +* 

Before landing this will become

  Create a list of \a FileInfo items and print it to stdout.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11285

To: michaelh, #baloo, #frameworks, ngraham, mlaurent
Cc: mlaurent, ngraham, smithjd, ashaposhnikov, michaelh, spoorun, nicolasfella, 
alexeymin

D11342: Include the "stdcpp-path" in the json file

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R240:7f865cf2b2c3: Include the stdcpp-path in the 
json file (authored by apol).

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11342?vs=29537=29598

REVISION DETAIL
  https://phabricator.kde.org/D11342

AFFECTED FILES
  toolchain/deployment-file.json.in

To: apol, #frameworks, vkrause
Cc: vkrause, #build_system, michaelh, ngraham

D11320: Fix QVariantMapList operator >> implementation

[Aleksander Morgado]

aleksanderm added a comment.


  In D11320#225486 , @broulik wrote:
  
  > Is that custom marshaller even neccessary? I thought Qt could resolve QList 
and QVariantMap (even nested) automatically? Can you try just removing that 
entire thing?
  
  
  Unless I'm missing something, it seems that it really is needed, this is what 
I got when removing the custom marshallers for QVariantMapList:
  
CMakeFiles/KF5ModemManagerQt.dir/bearer.cpp.o: In function 
`QList > qdbus_cast > 
>(QDBusArgument const&, QList >*)':

bearer.cpp:(.text._Z10qdbus_castI5QListI4QMapI7QString8QVariantEEET_RK13QDBusArgumentPS6_[_Z10qdbus_castI5QListI4QMapI7QString8QVariantEEET_RK13QDBusArgumentPS6_]+0x3e):
 undefined reference to `operator>>(QDBusArgument const&, QList >&)'
CMakeFiles/KF5ModemManagerQt.dir/generictypes.cpp.o: In function `void 
qDBusMarshallHelper > >(QDBusArgument&, 
QList > const*)':

generictypes.cpp:(.text._Z19qDBusMarshallHelperI5QListI4QMapI7QString8QVariantEEEvR13QDBusArgumentPKT_[_Z19qDBusMarshallHelperI5QListI4QMapI7QString8QVariantEEEvR13QDBusArgumentPKT_]+0x1f):
 undefined reference to `operator<<(QDBusArgument&, QList > const&)'
CMakeFiles/KF5ModemManagerQt.dir/generictypes.cpp.o: In function `void 
qDBusDemarshallHelper > >(QDBusArgument const&, 
QList >*)':

generictypes.cpp:(.text._Z21qDBusDemarshallHelperI5QListI4QMapI7QString8QVariantEEEvRK13QDBusArgumentPT_[_Z21qDBusDemarshallHelperI5QListI4QMapI7QString8QVariantEEEvRK13QDBusArgumentPT_]+0x1f):
 undefined reference to `operator>>(QDBusArgument const&, QList >&)'
collect2: error: ld returned 1 exit status

REPOSITORY
  R281 ModemManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D11320

To: aleksanderm, #frameworks, jgrulich
Cc: broulik, michaelh, ngraham

D11285: Introduce sanitizer class

[Michael Heidelbach]

michaelh added a comment.


  In D11285#226298 , @mlaurent wrote:
  
  > Is it possible to create an autotest for this class ?
  
  
  This is where it gets complicated.
  Essentially I can test only for sane databases, but that's useless.
  Or I need to mock an external drive and have control over its device id, 
which seems to be very difficult if at all possible.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11285

To: michaelh, #baloo, #frameworks, ngraham, mlaurent
Cc: mlaurent, ngraham, smithjd, ashaposhnikov, michaelh, spoorun, nicolasfella, 
alexeymin

D11285: Introduce sanitizer class

[Michael Heidelbach]

michaelh marked 4 inline comments as done.
michaelh added a comment.


  There were some conflicts I had to solve with this. Because it is not 
completely clear to me where this is going I wanted to be safe and used a 
d-pointer.
  As a consequence this class does the printing which I prefer to be in the cli.
  Secondly I can't make DatabaseSanitizerImpl a friend of the Transaction 
class. Which leads to the `getDocuments()` in DatabaseSanitizer, which should 
not be part of the interface. In the future more of similar functions will be 
needed.
  Is there a better way to accomplish this?

INLINE COMMENTS

> mlaurent wrote in databasesanitizer.cpp:165
> use qCDebug(BALOO)

I get a linker error
`databasesanitizer.cpp:189: undefined reference to `BALOO()'`
Currently its not worth the trouble fixing it, because that method is going to 
change anyway.
Also I don't like to mix debug statement and printing to stderr.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11285

To: michaelh, #baloo, #frameworks, ngraham, mlaurent
Cc: mlaurent, ngraham, smithjd, ashaposhnikov, michaelh, spoorun, nicolasfella, 
alexeymin

D11353: manager: add support to R/W the GlobalDnsConfiguration property

[Jan Grulich]

jgrulich accepted this revision.
jgrulich added a comment.
This revision is now accepted and ready to land.


  Looks good to me . Thank you.

REPOSITORY
  R282 NetworkManagerQt

BRANCH
  globaldnsconfiguration

REVISION DETAIL
  https://phabricator.kde.org/D11353

To: aleksanderm, #frameworks, jgrulich
Cc: michaelh, ngraham

D11346: Only set iconText() if actually changed

[Christoph Feck]

cfeck added inline comments.

INLINE COMMENTS

> apol wrote in kacceleratormanager.cpp:792
> What happens when iconText.isEmpty()?

Qt returns QAction::text() when QAction::iconText() is empty. Apparently Qt 
also strips some text, so to check if there was no iconText(), we need this 
weird check instead of using isEmpty().

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D11346

To: cfeck, #frameworks, chehrlic
Cc: apol, chehrlic, michaelh, ngraham

D11285: Introduce sanitizer class

[Michael Heidelbach]

michaelh updated this revision to Diff 29594.
michaelh added a comment.


  - Apply suggested changes
  - Put method descriptions in their correct place

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11285?vs=29405=29594

BRANCH
  sanitize-class (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11285

AFFECTED FILES
  src/engine/CMakeLists.txt
  src/engine/Messages.sh
  src/engine/databasesanitizer.cpp
  src/engine/databasesanitizer.h
  src/engine/documenturldb.cpp
  src/engine/transaction.h

To: michaelh, #baloo, #frameworks, ngraham, mlaurent
Cc: mlaurent, ngraham, smithjd, ashaposhnikov, michaelh, spoorun, nicolasfella, 
alexeymin

D11353: manager: add support to R/W the GlobalDnsConfiguration property

[Aleksander Morgado]

aleksanderm created this revision.
aleksanderm added reviewers: Frameworks, jgrulich.
aleksanderm added a project: Frameworks.
aleksanderm requested review of this revision.

REPOSITORY
  R282 NetworkManagerQt

BRANCH
  globaldnsconfiguration

REVISION DETAIL
  https://phabricator.kde.org/D11353

AFFECTED FILES
  src/CMakeLists.txt
  src/dnsconfiguration.cpp
  src/dnsconfiguration.h
  src/dnsdomain.cpp
  src/dnsdomain.h
  src/manager.cpp
  src/manager.h
  src/manager_p.h

To: aleksanderm, #frameworks, jgrulich
Cc: michaelh, ngraham

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 73 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/73/
 Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9
 Date of build:
Thu, 15 Mar 2018 12:08:01 +
 Build duration:
23 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest

D11342: Include the "stdcpp-path" in the json file

[Volker Krause]

vkrause accepted this revision.
vkrause added a comment.
This revision is now accepted and ready to land.


  Looks sane to me. Probably needs to be adjusted for clang support eventually 
though.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11342

To: apol, #frameworks, vkrause
Cc: vkrause, #build_system, michaelh, ngraham

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 98 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/98/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Thu, 15 Mar 2018 12:08:01 +
 Build duration:
12 min and counting
   JUnit Tests
  Name: (root) Failed: 8 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-dialogstatetestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(55/159)35%
(55/159)26%
(3523/13404)18%
(1954/10571)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)51%
(585/1140)27%
(406/1492)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/453)0%
(0/241)src.declarativeimports.core22%
(4/18)22%
(4/18)11%
(254/2243)7%
(102/1494)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/525)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1441/3500)28%
(825/2913)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)41%
(671/1622)28%
(318/1121)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)27%
(541/2009)17%
(298/1771)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1177)0%
(0/1056)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%

D11102: [Dialog] Allow setting outputOnly for NoBackground dialog

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:049aa5677de3: [Dialog] Allow setting outputOnly for 
NoBackground dialog (authored by broulik).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11102?vs=28869=29590

REVISION DETAIL
  https://phabricator.kde.org/D11102

AFFECTED FILES
  src/plasmaquick/dialog.cpp

To: broulik, #plasma, mart
Cc: #frameworks, michaelh, ngraham

D11102: [Dialog] Allow setting outputOnly for NoBackground dialog

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D11102

To: broulik, #plasma, mart
Cc: #frameworks, michaelh, ngraham

D11331: add gaming_input devices and others to Battery

[Florian Dollinger]

dollinger added a comment.


  Okay :) But what's about the other entries, like `UP_DEVICE_KIND_TABLET`,  
`UP_DEVICE_KIND_MEDIA_PLAYER`?
  Is there a reason why they are excluded?

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D11331

To: dollinger, broulik, #plasma
Cc: aleksejshilin, #frameworks, michaelh, ngraham

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 72 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/72/
 Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9
 Date of build:
Thu, 15 Mar 2018 11:17:36 +
 Build duration:
28 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest

D11346: Only set iconText() if actually changed

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> kacceleratormanager.cpp:792
>  // Check if iconText was generated by Qt. In that case ignore it (no 
> support for CJK accelerators) and set it from the text.
>  if (iconText == copy_of_qt_strippedText(oldText)) {
>  iconText = removeAcceleratorMarker(oldText);

What happens when iconText.isEmpty()?

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D11346

To: cfeck, #frameworks, chehrlic
Cc: apol, chehrlic, michaelh, ngraham

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 97 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/97/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Thu, 15 Mar 2018 11:17:36 +
 Build duration:
8 min 57 sec and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(55/159)35%
(55/159)27%
(3560/13408)19%
(1979/10573)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)53%
(609/1140)28%
(421/1492)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/453)0%
(0/241)src.declarativeimports.core22%
(4/18)22%
(4/18)11%
(254/2243)7%
(102/1494)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/525)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1442/3500)28%
(827/2913)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)41%
(671/1622)28%
(318/1121)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)27%
(553/2013)17%
(306/1773)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1177)0%
(0/1056)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%
(0/2)tests.kplugins0%
  

D11326: [ToolTip] Check file name in KDirWatch handler

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:77bac859bcec: [ToolTip] Check file name in KDirWatch 
handler (authored by broulik).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11326?vs=29492=29584

REVISION DETAIL
  https://phabricator.kde.org/D11326

AFFECTED FILES
  src/declarativeimports/core/tooltip.cpp
  src/declarativeimports/core/tooltip.h

To: broulik, #plasma, mart
Cc: #frameworks, michaelh, ngraham

D11326: [ToolTip] Check file name in KDirWatch handler

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D11326

To: broulik, #plasma, mart
Cc: #frameworks, michaelh, ngraham

D11323: [UDevManager] Also explicitly query for cameras

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R245:9a54ef65305f: [UDevManager] Also explicitly query for 
cameras (authored by broulik).

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11323?vs=29489=29583

REVISION DETAIL
  https://phabricator.kde.org/D11323

AFFECTED FILES
  src/solid/devices/backends/udev/udevmanager.cpp

To: broulik, #frameworks, davidedmundson
Cc: michaelh, ngraham

D11323: [UDevManager] Also explicitly query for cameras

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D11323

To: broulik, #frameworks, davidedmundson
Cc: michaelh, ngraham

D11331: add gaming_input devices and others to Battery

[Kai Uwe Broulik]

broulik added a comment.


  But then, using headers probably relies on recent upower versions being 
present, so numbers is fine, but please change it to be a whitelist, then this 
can surely go in. Thanks for taking care of this!

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D11331

To: dollinger, broulik, #plasma
Cc: aleksejshilin, #frameworks, michaelh, ngraham

D11331: add gaming_input devices and others to Battery

[Kai Uwe Broulik]

broulik added a comment.


  I would still prefer a whitelist instead of a balcklist. Recently my mouse 
has started showing up twice, who knows what else might happen with newer 
release.
  Also, can we use the defines/enums from upower there rather than adding 
seemingly random numbers?

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D11331

To: dollinger, broulik, #plasma
Cc: aleksejshilin, #frameworks, michaelh, ngraham

D11282: less expensive findByUrl in KCoreDirListerCache

[Milian Wolff]

mwolff added a comment.


  I'm not into the code base, just adding some comments to ensure everything is 
taken into account - maybe your initial attempt was better after all...

INLINE COMMENTS

> kcoredirlister.cpp:852
> +if (refresh) {
> +(*it).refresh();
>  }

is it OK that you operate on a copy of the item here? the item in the hash 
won't be modified, is that on purpose?

> kcoredirlister.cpp:1970
>  // Delete all remaining items
> -QMutableListIterator it(lstItems);
> +QMutableHashIterator it(hashItems);
>  while (it.hasNext()) {

O(N) iteration over a large hash is extremely slow, is this done elsewhere? if 
so, then you may need to find an alternative approach - potentially via 
multiple containers or by using a sorted vector after all like you proposed 
initially

> kcoredirlister.cpp:2532
>  // Of course if there is no filter and we can do a range-insertion 
> instead of a loop, that might be good.
> -QList::const_iterator kit = items.begin();
> -const QList::const_iterator kend = items.end();
> +auto kit = items.begin();
> +const auto kend = items.end();

this can be slow, see above

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11282

To: jtamate, #frameworks, dfaure
Cc: mwolff, michaelh, ngraham

D10742: get rid of the raw KFileItem pointers in KCoreDirListerCache

[Milian Wolff]

mwolff added a comment.


  no real review, just want to mention that you'll still have heap allocations 
for every item - now once per container it is in (due to QList and QSet and 
sizeof the KFileItem)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10742

To: jtamate, #frameworks, dfaure
Cc: mwolff, markg, michaelh, ngraham

Re: Would it be good if I became baloo's maintainer?

[Milian Wolff]

On Thursday, March 15, 2018 9:40:34 AM CET Michael Heidelbach wrote:
> Hi!
> 
> Getting the stuff I do for baloo reviewed takes a lot of time and poking
> others. That is considerably slowing me down.

I think it's good to make you the maintainer officially. But while waiting for 
reviews my slow you down, it is also usually an extremely valuable source for 
learning C++. So independent of of whether you are a maintainer or not, if you 
don't yet feel extremely confident with C++, still try to get reviews on 
"bigger" stuff. Stuff that you consider harmless you can commit directly.

If there's bigger stuff that needs to be reviewed but noone does it in time, 
ping us via mailing lists and/or IRC. I don't have a lot of time and don't 
follow all review requests. But I learned most of my skills through reviews in 
my early KDE times. Thus I feel obliged to give that back to others new to C++ 
and KDE. I bet this is the same for many others that are around for a long 
time!

> I'm seriously thinking of becoming the maintainer for baloo (and maybe
> baloowidgets). Then it would be easier for me to commit those patches I
> consider as harmless e.g unit tests. Unless somebody else jumped in I
> intended to maintain baloo eventually anyway. I would do it now(!)
> mainly for practical reasons. Due to my lack of experience with c++, the
> KDE way of using it and the KDE infrastructure in general I'm somewhat
> reluctant. Questions arise:
> 
>   * What exactly does it mean to be the maintainer of a project and what
> tasks come with it?
>   * What responsibilities come with it?
>   * How is that done practically?
>   * Do you think it's a good idea to have a newbie maintaining a project
> as deeply integrated into KDE as baloo?
>   * What should be my general attitude towards that task?


-- 
Milian Wolff
m...@milianw.de
http://milianw.de

D11282: less expensive findByUrl in KCoreDirListerCache

[Jaime Torres Amate]

jtamate updated this revision to Diff 29574.
jtamate edited the summary of this revision.
jtamate edited the test plan for this revision.
jtamate added a comment.


  Depends on https://phabricator.kde.org/D10742, including the diff.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11282?vs=29388=29574

REVISION DETAIL
  https://phabricator.kde.org/D11282

AFFECTED FILES
  src/core/kcoredirlister.cpp
  src/core/kcoredirlister_p.h

To: jtamate, #frameworks, dfaure
Cc: mwolff, michaelh, ngraham

D11285: Introduce sanitizer class

[Laurent Montel]

mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> databasesanitizer.cpp:44
> +struct FileInfo {
> +quint32 deviceId; 
> +quint32 inode;

initialize value by default please

> databasesanitizer.cpp:107
> +};
> +if ((includeIds.count() > 0  && 
> !includeIds.contains(info.deviceId))
> +|| (excludeIds.count() > 0  && 
> excludeIds.contains(info.deviceId))

includeIds.count() > 0  => use !isEmpty

> databasesanitizer.cpp:153
> +const bool missingOnly, 
> +const QSharedPointer urlFilter)
> +{

const QSharedPointer &
--^

> databasesanitizer.cpp:165
> +} else {
> +qDebug()  << "Skipping" << info.url;
> +Q_ASSERT(false);

use qCDebug(BALOO)

> databasesanitizer.cpp:174
> +}
> +err << i18n("Found %1 matching items", infos.count()) << endl;
> +

as you add a i18n in engine directory you need to extract them.
you missed to add a Message.sh in this subdirectory and loading message file.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11285

To: michaelh, #baloo, #frameworks, ngraham, mlaurent
Cc: mlaurent, ngraham, smithjd, ashaposhnikov, michaelh, spoorun, nicolasfella, 
alexeymin

D11285: Introduce sanitizer class

[Laurent Montel]

mlaurent added a comment.


  Is it possible to create an autotest for this class ?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11285

To: michaelh, #baloo, #frameworks, ngraham, mlaurent
Cc: mlaurent, ngraham, smithjd, ashaposhnikov, michaelh, spoorun, nicolasfella, 
alexeymin

D11323: [UDevManager] Also explicitly query for cameras

[Kai Uwe Broulik]

broulik added a comment.


  > didn't we establish that devicesByProperty didn't work?
  
  It didn't work for media players where we query for `QVariant()` which turns 
into `nullptr` since there is no documentation on what that actually does 
(remove filter or check for property existance). Explicitly checking for `1` 
which we do here works fine, though.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D11323

To: broulik, #frameworks, davidedmundson
Cc: michaelh, ngraham

Would it be good if I became baloo's maintainer?

[Michael Heidelbach]

Hi!

Getting the stuff I do for baloo reviewed takes a lot of time and poking 
others. That is considerably slowing me down.


I'm seriously thinking of becoming the maintainer for baloo (and maybe 
baloowidgets). Then it would be easier for me to commit those patches I 
consider as harmless e.g unit tests. Unless somebody else jumped in I 
intended to maintain baloo eventually anyway. I would do it now(!) 
mainly for practical reasons. Due to my lack of experience with c++, the 
KDE way of using it and the KDE infrastructure in general I'm somewhat 
reluctant. Questions arise:


 * What exactly does it mean to be the maintainer of a project and what
   tasks come with it?
 * What responsibilities come with it?
 * How is that done practically?
 * Do you think it's a good idea to have a newbie maintaining a project
   as deeply integrated into KDE as baloo?
 * What should be my general attitude towards that task?


Please give me your advice,

Michael

D10742: get rid of the raw KFileItem pointers in KCoreDirListerCache

[Jaime Torres Amate]

jtamate updated this revision to Diff 29572.
jtamate edited the summary of this revision.
jtamate edited the test plan for this revision.
jtamate added a comment.


  Pass all the unittests, without modifications, finally.
  Use as much as possible the recently added move semantics in KFileItem.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10742?vs=27909=29572

REVISION DETAIL
  https://phabricator.kde.org/D10742

AFFECTED FILES
  src/core/kcoredirlister.cpp
  src/core/kcoredirlister_p.h

To: jtamate, #frameworks, dfaure
Cc: markg, michaelh, ngraham

D10918: taglibextractor: Refactor for better readability

[Alexander Stippich]

astippich added inline comments.

INLINE COMMENTS

> michaelh wrote in taglibextractor.cpp:157
> This is an example for what we're discussing. Why the join??? We might lose 
> info, when the album artist contains a comma.

Yeah, I've seen that as well. Looks unnecessary, since we could also just 
directly add it to a stringlist. This is something I would like to change (at 
least for the taglibextractor)

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D10918

To: michaelh, mgallien, #baloo, #frameworks, astippich
Cc: astippich, ashaposhnikov, michaelh, spoorun, nicolasfella, ngraham, 
alexeymin

D10918: taglibextractor: Refactor for better readability

[Alexander Stippich]

astippich added inline comments.

INLINE COMMENTS

> michaelh wrote in taglibextractor.cpp:331
> You mean other than lines 225, 233, 240?

Yes, but imho we shouldn't even enter the function for mimetypes not having ogg 
tags. Maybe that is overly careful

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D10918

To: michaelh, mgallien, #baloo, #frameworks, astippich
Cc: astippich, ashaposhnikov, michaelh, spoorun, nicolasfella, ngraham, 
alexeymin

D11346: Only set iconText() if actually changed

[Christian Ehrlicher]

chehrlic accepted this revision.
chehrlic added a comment.
This revision is now accepted and ready to land.


  This should at least fix the most cases as described in the bug report :)

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D11346

To: cfeck, #frameworks, chehrlic
Cc: chehrlic, michaelh, ngraham