Re: Review Request 124213: Add standard shortcut for new tab action

that used for that purpose, just incognito mode, or new window in applications like Konsole. src/gui/kstandardshortcut.h (line 372) https://git.reviewboard.kde.org/r/124213/#comment56244 Isn't Ctrl+Tab usually next tab? - Kai Uwe Broulik On Juni 30, 2015, 9:13 vorm., Simon Persson wrote

Re: Review Request 124212: kwindowsystem: Change source file layout

On Juni 30, 2015, 8:30 vorm., Kai Uwe Broulik wrote: Doesn't build on OSX: [ 24%] Building CXX object src/CMakeFiles/KF5WindowSystem.dir/platforms/osx/kkeyserver_mac.cpp.o [ 27%] Building CXX object src/CMakeFiles/KF5WindowSystem.dir/KF5WindowSystem_automoc.cpp.o In file

Re: Review Request 124014: Add QQC clone of KColorButton

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124014/#review82011 --- Ship it! Ship It! - Kai Uwe Broulik On Juni 7, 2015, 7:30

Re: Review Request 123890: Don't show KDE Frameworks version in the About KDE dialog

://git.reviewboard.kde.org/r/123890/#comment55377 I suppose you can also remove the HTML stuff since KTitleWidget now uses an increased font size anyway. - Kai Uwe Broulik On Mai 24, 2015, 4:26 vorm., Albert Astals Cid wrote

Re: Minimum supported version of MSVC for frameworks

‎Hi, My experience with MSVC 2013 was that you even need at least Update 4 for initializer lists to work properly, which was released quite recently iirc. Cheers, Kai Uwe   Originalnachricht   Von: Kevin Funk Gesendet: Donnerstag, 13. August 2015 10:48 An: kde-frameworks-devel Antwort an:

Re: [Kde-hardware-devel] Review Request 124778: Suspend using UPower in case of ConsoleKit 1

marked as submitted. Review request for Solid and Eric Koegel. Changes --- Submitted with commit 41d369f7c57b31f13cb120d09b3e9f71119d86f4 by Kai Uwe Broulik to branch Plasma/5.4. Bugs: 351365 https://bugs.kde.org/show_bug.cgi?id=351365 Repository: powerdevil Description

Where are kdeglobals defaults?

Hi all, I tried to find out why the default colorscheme was still Oxygen, which unfortunately slipped into the Applications 15.08 promo screenshots, and found that all the colors KCM does is KConfig::sharedConfig(Kdeglobals); setReadDefaults(true); read(); setReadDefalts(false) but I just

Review Request 124872: Default to Breeze colors

decoration which is set in the WM section of kdeglobals by the breeze.colors but KWin defaults to highlight colors, so it stays blue. Thanks, Kai Uwe Broulik ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman

Re: Review Request 124872: Default to Breeze colors

/diff/ Testing --- Seems to look right, typos reserved :) Only thing missing now is the window decoration which is set in the WM section of kdeglobals by the breeze.colors but KWin defaults to highlight colors, so it stays blue. Thanks, Kai Uwe Broulik

Re: Where are kdeglobals defaults?

‎Yup, thanks! :) And I desperately grep'd all of Frameworks for clues about colorScheme   Originalnachricht   Von: Albert Astals Cid Gesendet: Freitag, 21. August 2015 23:05 An: kde-devel@kde.org Cc: Kai Uwe Broulik Betreff: Re: Where are kdeglobals defaults? El Divendres, 21 d'agost de 2015

Re: [Kde-hardware-devel] Review Request 124730: [solid-device-automounter] Port to KF5

even when I re-attach the same device. Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: Review Request 124746: [KDesktopFile] add readMimeType

://git.reviewboard.kde.org/r/124746/#review84020 --- On Aug. 15, 2015, 5:38 nachm., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org

Re: [Kde-hardware-devel] Review Request 124730: [solid-device-automounter] Port to KF5

. Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: Review Request 124902: Delay starting kglobalaccel5 till it's needed

://git.reviewboard.kde.org/r/124902/#comment58351 No non trivial global static in a lib? - Kai Uwe Broulik On Aug. 24, 2015, 11:35 vorm., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: [Kde-hardware-devel] Review Request 124730: [solid-device-automounter] Port to KF5

marked as submitted. Review request for Plasma, Solid and Torrie Fischer. Changes --- Submitted with commit e8a571f09557e9cb597b466c1f61bdb4b68a6913 by Kai Uwe Broulik to branch master. Bugs: 351003 https://bugs.kde.org/show_bug.cgi?id=351003 Repository: plasma-desktop Description

Re: [Kde-hardware-devel] Review Request 123263: WIP: KDE Connect backend for Solid

: https://git.reviewboard.kde.org/r/123263/#review83263 --- On Juli 31, 2015, 7:15 nachm., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: [Kde-hardware-devel] Review Request 123263: WIP: KDE Connect backend for Solid

. Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Review Request 124746: [KDesktopFile] add readMimeType

/kdesktopfile.cpp 254b59a autotests/kdesktopfiletest.cpp 1a9c1c3 src/core/kdesktopfile.h 2190051 Diff: https://git.reviewboard.kde.org/r/124746/diff/ Testing --- Test passes Thanks, Kai Uwe Broulik ___ Kde-frameworks-devel mailing list Kde

Re: Review Request 124397: Add today button to calendar

://git.reviewboard.kde.org/r/124397/#comment57008 ToolButton is square by default src/declarativeimports/calendar/qml/MonthView.qml (lines 161 - 164) https://git.reviewboard.kde.org/r/124397/#comment57007 ToolButton has a tooltip property, no need for a custom tooltip - Kai Uwe Broulik

Re: Review Request 124397: Add today button to calendar

think of this earlier :) - Kai Uwe Broulik On Juli 19, 2015, 5:06 nachm., Bernhard Friedreich wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124397

Review Request 125790: Recognize image/vnd.adobe.photoshop

Description --- This is the mimetype I get for .psd files Diffs - src/imageformats/psd.desktop 494b746 src/imageformats/psd.json 859eede Diff: https://git.reviewboard.kde.org/r/125790/diff/ Testing --- I still don't get any thumbnails for PSD files, though. Thanks, Kai Uwe

Review Request 125788: [kio thumbnailer] Recognize image/webp

, Kai Uwe Broulik ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125788: [kio thumbnailer] Recognize image/webp

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit b77547ad90467a7f0a37469e9a58417c4ea63b8a by Kai Uwe Broulik to branch Applications/15.08. Repository: kio-extras Description --- When I download a .webp file the system claims it to be image

Re: Review Request 125976: add an update() method

syntax in frameworks. src/kpackage/package.h (line 95) <https://git.reviewboard.kde.org/r/125976/#comment60485> NewerVersionAlreadyInstalledError src/kpackage/package.h (line 96) <https://git.reviewboard.kde.org/r/125976/#comment60486> +Error - Kai Uwe Broulik On Nov. 9

Re: Review Request 125790: Recognize image/vnd.adobe.photoshop

/125790/diff/ Testing --- I still don't get any thumbnails for PSD files, though. Thanks, Kai Uwe Broulik ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125790: Recognize image/vnd.adobe.photoshop

/125790/diff/ Testing --- I still don't get any thumbnails for PSD files, though. Thanks, Kai Uwe Broulik ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

AW: Install UdevQt headers in Solid

+1 but I guess we should review and cleanup that stuff whilst at it, however I don't really have time to make this stuff Frameworks ready Gesendet von meinem BlackBerry 10-Smartphone.   Originalnachricht   Von: David Rosca Gesendet: Donnerstag, 5. November 2015 14:27 An:

Re: [Kde-hardware-devel] Install UdevQt headers in Solid

+1 but I guess we should review and cleanup that stuff whilst at it, however I don't really have time to make this stuff Frameworks ready Gesendet von meinem BlackBerry 10-Smartphone.   Originalnachricht   Von: David Rosca Gesendet: Donnerstag, 5. November 2015 14:27 An:

Re: Review Request 124963: New widget: KNewPasswordWidget

> On Okt. 11, 2015, 9:16 nachm., David Faure wrote: > > src/knewpasswordwidget.cpp, line 101 > > > > > > qBound(pwstrength, 0, 100) :-) qBound(0, pwstrength, 100) actually - Kai Uwe

Re: Review Request 124307: Remove Theme tree debug entry

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124307/#review82273 --- +1 - Kai Uwe Broulik On Juli 9, 2015, 2:55 nachm., Aleix

Re: Review Request 124281: Remove KService and KIconThemes usage from KNotifications

://git.reviewboard.kde.org/r/124281/#comment56648 Unused - Kai Uwe Broulik On Juli 9, 2015, 1:10 nachm., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124281

Re: [Kde-hardware-devel] Review Request 124318: Load DPMSAction only on xcb platform

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124318/#review82314 --- Ship it! Thanks! - Kai Uwe Broulik On Juli 10, 2015, 9:21

Re: [Kde-hardware-devel] Review Request 123475: Execute KAuth jobs for brightness control in an async manner

work for me. - Kai Uwe Broulik On Juli 10, 2015, 1:23 nachm., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123475

Re: Review Request 124941: Reparse notification config only when actually needed

://git.reviewboard.kde.org/r/124941/#comment58447 It's 2015 now src/knotificationmanager.cpp (line 175) https://git.reviewboard.kde.org/r/124941/#comment58448 Given you already check whether the entry exists before adding it, a removeOne should be sufficient - Kai Uwe Broulik On Aug. 26, 2015, 9:05

Re: [Kde-hardware-devel] Review Request 125026: Wayland implementation for DPMS

ult not here? daemon/actions/dpms/powerdevildpmsaction.cpp (line 45) <https://git.reviewboard.kde.org/r/125026/#comment58650> Why this? daemon/actions/dpms/waylanddpmshelper.h (lines 41 - 42) <https://git.reviewboard.kde.org/r/125026/#comment58651> Add space - Kai Uwe Broulik

Re: Review Request 124746: [KDesktopFile] add readMimeType

est passes Thanks, Kai Uwe Broulik ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124746: [KDesktopFile] add readMimeType

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit f7a2eef8ac3758cce61717a74987219da6f5d94e by Kai Uwe Broulik to branch master. Repository: kconfig Description --- This allows to get the MimeType field of a desktop file to determin whether eg

Re: [Kde-hardware-devel] Review Request 125248: Display name of process which blocks umount / eject

59089> if (!pid) { continue; } ? dataengines/devicenotifications/ksolidnotify.cpp (line 157) <https://git.reviewboard.kde.org/r/125248/#comment59091> Could use plural handling: i18np("Could not … are opened in \"%1\".", "Could

Re: [Kde-hardware-devel] Review Request 125248: Display name of process which blocks umount / eject

> On Sept. 16, 2015, 10:11 vorm., Kai Uwe Broulik wrote: > > I really like that! > > > > The device notifier UI itself is questionable with the popup telling us > > "the device xyz failed to unmount" rather than just highlighting the device > > a

AW: folder icons where should they be set

Hi, Aren't these XDG standard dirs you can even configure? Just show the folder at XDG images with a pictures folder icon and so on.  If you use different folders without telling the system, it's your own fault ;) Cheers,  Kai Uwe‎

Re: Review Request 125268: Fix signal-slot connections in KNewFileMenuPrivate::confirmCreatingHiddenDir(QString)

, so we could spot things like these easier in the future. - Kai Uwe Broulik On Sept. 16, 2015, 8:22 nachm., Frank Reininghaus wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboa

Re: Review Request 124872: Default to Breeze colors

marked as submitted. Review request for KDE Frameworks, Plasma and KDE Usability. Changes --- Submitted with commit 0d6cc21a5685846be4af9491e10d47bd7ee12a65 by Kai Uwe Broulik to branch master. Bugs: 351530 https://bugs.kde.org/show_bug.cgi?id=351530 Repository: kconfigwidgets

Re: [OS X/Wayland] using WIds created by a different process to create KMessageBox'es and other widgets/windows

‎> On OS X (and MS Windows?),  And Wayland, so it affects Linux, too. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: [Kde-hardware-devel] Review Request 126146: [XRandRBrightness] Don't call for xrandr if it's not available

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126146/#review89281 --- Ping - Kai Uwe Broulik On Nov. 23, 2015, 4 nachm., Kai Uwe

Re: [Kde-hardware-devel] Review Request 126146: [XRandRBrightness] Don't call for xrandr if it's not available

marked as submitted. Review request for Solid and Thomas Lübking. Changes --- Submitted with commit dde0ecce02259a26655737e6674950e2e303bc6f by Kai Uwe Broulik to branch Plasma/5.5. Bugs: 352462 https://bugs.kde.org/show_bug.cgi?id=352462 Repository: powerdevil Description

Re: Review Request 126320: Read KPluginMetada's property X-Plasma-ComponentTypes as a stringlist

hours /o\ Do we need a respin of KF5 for this? It's pretty serious if Plasma just doesn't start for no apparent reason. - Kai Uwe Broulik On Dez. 11, 2015, 6:48 nachm., Martin Klapetek wrote: > > --- > This is an automatically ge

Re: [Kde-hardware-devel] Review Request 126381: kwayland backend for libkscreen

tps://git.reviewboard.kde.org/r/126381/#comment61443> [=] captures the this pointer and this->m_syncLoop is still the same syncLoop - Kai Uwe Broulik On Dez. 17, 2015, 6:53 nachm., Sebastian Kügler wrote: > > --- > This i

Re: Review Request 108442: [High-dpi issues] Fix KIconButton initial icon size and its occurence in KPropertiesDialog

and font scales perfectly and looks good. See screenshot. File Attachments KPropertiesDialog with Retina settings https://git.reviewboard.kde.org/media/uploaded/files/2013/01/16/iconbutton.png Thanks, Kai Uwe Broulik

Re: Review Request 110266: Cleanp Places Panel context menu

Comparison (left old, right new) https://git.reviewboard.kde.org/media/uploaded/files/2013/05/02/kdelibsplaces.png Thanks, Kai Uwe Broulik

Re: Review Request 102149: Improve Calculate/Stop buttons when folder Size is being calculated

kio/kfile/kpropertiesdialog.cpp ba56f18 Diff: https://git.reviewboard.kde.org/r/102149/diff/ Testing --- Compiles and the buttons toggle (and react) fine. Screenshots --- Screenshot of the dialog while it is calculating https://git.reviewboard.kde.org/r/102149/s/213/ Thanks, Kai Uwe Broulik

Re: Review Request 108433: [High-dpi issues] Fix color kcm list when using big fonts

media/uploaded/files/2013/01/16/colorbigsizeafter.png Thanks, Kai Uwe Broulik

Re: [Kde-hardware-devel] Review Request 106863: Silence "Profile foo could not activate bar which is a non-existent action" message

triggered, though. (Dunno how to get powerdevil debug console output) Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: RFC: split platformtheme plugin from frameworkintegration and move to kde/workspace

Hi,Mark, I think you completely misunderstood what move to kde/workspace means. This is not a repository, nobody wants to move that stuff into plasma-workspace. It just has semantic relevance, ie. no frameworks

Re: [Kde-hardware-devel] Review Request 126145: Wait 5s before enforcing inhibition

marked as submitted. Review request for Solid. Changes --- Submitted with commit eca79138c15575f6f523a8680919b407f84da2e2 by Kai Uwe Broulik to branch master. Bugs: 352235 https://bugs.kde.org/show_bug.cgi?id=352235 Repository: powerdevil Description --- Whenever Chrome plays

Re: [Kde-hardware-devel] Review Request 126145: Wait 5s before enforcing inhibition

- Kai Uwe --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126145/#review89497 --- On Dez. 14, 2015, 9:04 nachm., Kai Uwe Brou

Re: Review Request 126167: Expose QMimeType comment

marked as submitted. Review request for KDE Frameworks and Aleix Pol Gonzalez. Changes --- Submitted with commit aa412c02657828f68f2ac4a3a303853f255525a5 by Kai Uwe Broulik to branch master. Repository: kdeclarative Description --- This allows to show the pretty name ("text

Re: Review Request 126627: Replace screensaver inhibition by direct dbus calls

inwindow.cpp (line 747) <https://git.reviewboard.kde.org/r/126627/#comment61929> .value(); app/mainwindow.cpp (line 760) <https://git.reviewboard.kde.org/r/126627/#comment61931> setArguments({mScreenSaverInhibitionCookie}) - Kai Uwe Broulik On Jan. 4, 2016, 8:07 nachm

Re: Review Request 126595: [KFileMetaData] Allow querying for a file's origin URL

/CommonExtendedAttributes/ Diffs (updated) - src/properties.h 64ba0be src/propertyinfo.cpp 0b298b6 src/usermetadata.h ab58e16 src/usermetadata.cpp 51c87f8 Diff: https://git.reviewboard.kde.org/r/126595/diff/ Testing --- Works. Thanks, Kai Uwe Broulik

Re: Plugin install question

Hi, Try passing the argument -DKDE_INSTALL_USE_QT_SYS_PATHS=ON to cmake. Something 's weird on Kubuntu in this regard, took me ages to figure out. Cheers,  Kai Uwe >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 126595: [KFileMetaData] Allow querying for a file's origin URL

st entry of course must stay last. - Kai Uwe --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126595/#review90435 --- On Jan. 2, 2016,

Re: Review Request 126149: [Icon widget] Bring back properties dialog

is removed :) - Kai Uwe Broulik On Dez. 21, 2015, 11:31 nachm., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 126595: [KFileMetaData] Allow querying for a file's origin URL

/CommonExtendedAttributes/ Diffs (updated) - src/properties.h 64ba0be src/propertyinfo.cpp 0b298b6 src/usermetadata.h ab58e16 src/usermetadata.cpp 51c87f8 Diff: https://git.reviewboard.kde.org/r/126595/diff/ Testing --- Works. Thanks, Kai Uwe Broulik

Review Request 126595: [KFileMetaData] Allow querying for a file's origin URL

51c87f8 Diff: https://git.reviewboard.kde.org/r/126595/diff/ Testing --- Works. Thanks, Kai Uwe Broulik ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126650: [WIP] Add PM/ScreenSaver Inhibition capabilities to KIdleTime

e will have a spurious inhibition in that case. PowerDevil tracks when an application closes but it obviously cannot detect this case. src/inhibition.cpp (line 274) <https://git.reviewboard.kde.org/r/126650/#comment62002> perhaps an error signal and have the status enum only reflect activ

Re: Review Request 126568: [KNotifyConfigWidget] Allow selecting a specific event

src/knotifyconfigwidget.h 9c1bbfa src/knotifyconfigwidget.cpp 4653529 src/knotifyeventlist.h 9d9804c src/knotifyeventlist.cpp 6046d2d Diff: https://git.reviewboard.kde.org/r/126568/diff/ Testing --- Works Thanks, Kai Uwe Broulik

Re: Review Request 126516: Add StatusNotifier flag

://git.reviewboard.kde.org/r/126516/diff/ Testing --- Works. Thanks, Kai Uwe Broulik ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 126568: [KNotifyConfigWidget] Allow selecting a specific event

/knotifyeventlist.h 9d9804c src/knotifyeventlist.cpp 6046d2d Diff: https://git.reviewboard.kde.org/r/126568/diff/ Testing --- Works Thanks, Kai Uwe Broulik ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

ve at the right is a bit dated. - Kai Uwe --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126515/#review90316 ----------- On Dez. 2

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

> On Dez. 29, 2015, 11:56 nachm., Ken Vermette wrote: > > In regards to the message displayed (as mentioned in your G+ post) how > > about: > > > > "Sorry for the inconvenience. Please report the error to help improve this > > software." > > K

Re: Review Request 126459: Add a hint to skip notifications grouping

n sets it anyway. :) - Kai Uwe Broulik On Dez. 29, 2015, 8:07 nachm., Martin Klapetek wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboar

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

ou didn't bother to look after it by then, you probably forgot what you did to cause the crash anyway :) Thanks, Kai Uwe Broulik ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126459: Add a hint to skip notifications grouping

> On Dez. 29, 2015, 9:50 nachm., Kai Uwe Broulik wrote: > > src/knotification.h, line 251 > > <https://git.reviewboard.kde.org/r/126459/diff/1/?file=425181#file425181line251> > > > > This must be 0x10! > > > > 0x10 = 0b1 (one bit s

Re: Review Request 126568: [KNotifyConfigWidget] Allow selecting a specific event

marked as submitted. Review request for KDE Frameworks, Martin Klapetek and Olivier Goffart. Changes --- Submitted with commit ab4684e67689fe71e11aafad1af63fc966443b75 by Kai Uwe Broulik to branch master. Repository: knotifyconfig Description --- This allows to programmatically

Re: Review Request 126681: Duplicate the file descriptor while opening

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126681/#review90814 --- I think we should do a re-spin of KF 5.18? - Kai Uwe Broulik

Re: Review Request 126681: Duplicate the file descriptor while opening

> On Jan. 9, 2016, 1:28 nachm., Kai Uwe Broulik wrote: > > I think we should do a re-spin of KF 5.18? > > Luigi Toscano wrote: > I think it was already done: > https://mail.kde.org/pipermail/release-team/2016-January/009263.html ok, I was just wondering becaus

Re: Review Request 125158: add logic to use icons for default xdg user dirs

::iconNameForUrl as well - Kai Uwe Broulik On Okt. 22, 2015, 7:26 vorm., Harald Sitter wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 125910: Fix for Bug 334525 - Gwenview hangs when switching from normal to full screen mode

> On Dez. 30, 2015, 2:52 nachm., Kai Uwe Broulik wrote: > > kdeui/notifications/knotificationrestrictions.cpp, line 50 > > <https://git.reviewboard.kde.org/r/125910/diff/2/?file=414354#file414354line50> > > > > Note that this string can be shown t

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

marked as submitted. Review request for KDE Frameworks, Plasma, KDE Usability, and Martin Gräßlin. Changes --- Submitted with commit 555ff08dc1efaeb7d1f699856347f5e0e9aff1d0 by Kai Uwe Broulik to branch master. Repository: plasma-workspace Description --- This adds a new "--pa

Re: Review Request 125619: Refactor KNewPasswordDialog class

message which looks quite out of place otherwise. - Kai Uwe Broulik On Nov. 19, 2015, 11:04 vorm., Elvis Angelaccio wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 126149: [Icon widget] Bring back properties dialog

ile, allowing to rename it. The applet reflected the changes. Dropped an application from kickoff to the desktop -> dialog from a copy of the desktop file, allowing to change its icon and description. The applet reflected the changes. Thanks, Kai Uwe B

Review Request 126516: Add StatusNotifier flag

--- This adds a StatusNotifier flag that starts DrKonqi with the --passive argument introduced in Review 126515 Diffs - src/kcrash.cpp 7d3b8a2 src/kcrash.h e2b59f2 Diff: https://git.reviewboard.kde.org/r/126516/diff/ Testing --- Works. Thanks, Kai Uwe Broulik

Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

een, just the panel restarting. Afterwards I got a SNI which opened DrKonqi when tapped. The SNI disappears after 1 minute because if you didn't bother to look after it by then, you probably forgot what you did to cause the crash anyway :) Thanks, Kai Uwe Broulik

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

/drkonqipassive.png - Kai Uwe Broulik On Dez. 25, 2015, 4:24 nachm., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

atically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126515/#review90104 ----------- On Dez. 25, 2015, 4:24 nachm., Kai Uwe Broulik wrote: > > --- > This is a

Re: Review Request 126417: don't rely on char* to QString implicit conversion

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126417/#review89713 --- i'm wondering whether those are still needed - Kai Uwe

Re: [Kde-hardware-devel] Review Request 126381: kwayland backend for libkscreen

waylandconfigreader.cpp (line 33) <https://git.reviewboard.kde.org/r/126381/#comment61546> QVector - Kai Uwe Broulik On Dez. 18, 2015, 3:16 nachm., Sebastian Kügler wrote: > > -

Re: Review Request 126516: Add StatusNotifier flag

view90164 --- On Dez. 25, 2015, 4:24 nachm., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewb

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126515/#review90166 ----------- On Dez. 27, 2015, 4:11 nachm., Kai Uwe Broulik wrote: > > --- > T

Re: Review Request 126516: Add StatusNotifier flag

> On Dez. 27, 2015, 6:18 nachm., David Edmundson wrote: > > Ship It! > > Kai Uwe Broulik wrote: > I'll put this on hold until we decided whether we want DrKonqi vs SNI > (what this review is about) or Desktop Notification vs SNI (my second > approach, in wh

Re: Review Request 126523: Use a KMessageWidget in KNewPasswordDialog

10:18 vorm.) > > > Review request for KDE Frameworks, KDE Usability, Kai Uwe Broulik, and > Christoph Feck. > > > Repository: kwidgetsaddons > > > Description > --- > > Currently a KNewPasswordDialog makes use of a KTitleWidget to display > mes

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

> On Dez. 27, 2015, 6:24 nachm., David Edmundson wrote: > > drkonqi/main.cpp, line 159 > > <https://git.reviewboard.kde.org/r/126515/diff/2/?file=426276#file426276line159> > > > > and -> or surely? > > > > both

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

> On Dez. 25, 2015, 4:37 nachm., Kai Uwe Broulik wrote: > > Usability: I envisioned this to be used for auto-restarting shell services > > and not to be used by applications. > > Another interesting thought could be enabling this by default for all > > applications b

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

> On Dez. 27, 2015, 6:24 nachm., David Edmundson wrote: > > drkonqi/main.cpp, line 159 > > <https://git.reviewboard.kde.org/r/126515/diff/2/?file=426276#file426276line159> > > > > and -> or surely? > > > > both

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

y then, you probably forgot what you did to cause the crash anyway :) Thanks, Kai Uwe Broulik ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

> On Dez. 27, 2015, 6:24 nachm., David Edmundson wrote: > > drkonqi/main.cpp, line 159 > > <https://git.reviewboard.kde.org/r/126515/diff/2/?file=426276#file426276line159> > > > > and -> or surely? > > > > both

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

crashed plasmashell, it restarted so fast that you didn't even have a black screen inbetween, just the panel restarting. Afterwards I got a SNI which opened DrKonqi when tapped. The SNI disappears after 1 minute because if you didn't bother to look after it by then, you probably forgot what you d

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

nel restarting. Afterwards I got a SNI which opened DrKonqi when tapped. The SNI disappears after 1 minute because if you didn't bother to look after it by then, you probably forgot what you did to cause the crash anyway :) Thanks, Kai Uwe Broulik __

Re: [Kde-hardware-devel] Review Request 126381: kwayland backend for libkscreen

> On Dez. 20, 2015, 10:38 vorm., Daniel Vrátil wrote: > > tests/kwayland/waylandconfigreader.cpp, line 110 > > > > > > No need for .toList(), Q_FOREACH can iterate over values of a map. > > Sebastian Kügler

Re: [Kde-hardware-devel] Review Request 126381: kwayland backend for libkscreen

tps://git.reviewboard.kde.org/r/126381/#comment61512> Why this change? - Kai Uwe Broulik On Dez. 18, 2015, 3:16 nachm., Sebastian Kügler wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: [Kde-hardware-devel] Review Request 126381: kwayland backend for libkscreen

ndOutput backends/kwayland/waylandconfig.cpp (lines 234 - 235) <https://git.reviewboard.kde.org/r/126381/#comment61525> m_outputMap.take(kscreen_id) backends/kwayland/waylandconfig.cpp (line 252) <https://git.reviewboard.kde.org/r/126381/#comment61526> if (!m_outputMap.c

<    1   2   3   4   5   6   7   8   9   10   >