Re: Review Request 112451: Adapt the DocBook finders to newer naming conventions

2013-09-04 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112451/#review39357 --- Ship it! Ship It! - Luigi Toscano On Sept. 4, 2013, 1:55

Re: [kde-doc-english] Making KDocTools independent of KArchive

2013-09-30 Thread Luigi Toscano
Albert Astals Cid wrote: El Diumenge, 29 de setembre de 2013, a les 12:14:49, David Faure va escriure: On Monday 23 September 2013 20:23:13 Albert Astals Cid wrote: So we don't have a man page anymore? Debian will be happy :D Also we're losing the i18n-zation side of the man page, which the

Re: Review Request 114969: Add common files required for documentation generation

2014-01-15 Thread Luigi Toscano
for some files (especially the css) at this point, right? Otherwise, ship it from me. - Luigi Toscano On Jan. 15, 2014, 2:08 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 114971: Remove unused common files and do not install any of them

2014-01-15 Thread Luigi Toscano
that they are not used at all everywhere. - Luigi Toscano On Jan. 15, 2014, 2:08 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114971

Re: Review Request 115077: Rename Macros in KF5DocTools to KDE5_

2014-01-18 Thread Luigi Toscano
://git.reviewboard.kde.org/r/115077/ --- (Updated Jan. 18, 2014, 1:16 p.m.) Review request for Documentation, KDE Frameworks and Luigi Toscano. Repository: kdoctools Description --- Part of the overall task

Re: Review Request 115065: kdoctools renames to add 5 namespace to prevent clashes with kdelibs4

2014-01-18 Thread Luigi Toscano
. I don't see those options to be defined into Frameworks, which means that {kde|kf}5options should be removed; are some of them provided by Qt directly? If not, also qt5config should disappear. Can someone from the kde-frameworks-devel list shed some light on this? - Luigi Toscano On Jan. 17

Re: Review Request 115065: kdoctools renames to add 5 namespace to prevent clashes with kdelibs4

2014-01-19 Thread Luigi Toscano
On Jan. 19, 2014, 12:39 a.m., Luigi Toscano wrote: The patch looks ago, I have two remarks: - I think that kde5options should be kf5options (as it happened with kde4-config - kf5-config) - I'm not sure if the content of those manpages still applies. The special options described

Re: Review Request 115077: Rename Macros in KF5DocTools to KDE5_

2014-01-19 Thread Luigi Toscano
wrote: Well, most projects will start off depending on KDE4Support anyway, and if you don't use it I think you should just get an error about the macro not being found. Luigi Toscano wrote: My thoughts: - is the dependency on KDE4Support the first thing a ported application

Re: KF5 Update Meeting Minutes 2014-w4

2014-01-21 Thread Luigi Toscano
On Tuesday 21 of January 2014 16:42:42 Kevin Ottens wrote: * tosky found out that the validity of the qtoptions and kdeoptions man pages is in need of review; * he's also working with the doc team toward a switch to docbook 4.2; Quick patch: to docbook 4.5 (our documentation is based on 4.2

Re: Review Request 115202: Allow building KConfigWidgets on Windows

2014-01-21 Thread Luigi Toscano
and the not-iterator hack) unrelated? - Luigi Toscano On Jan. 21, 2014, 10:26 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115202

Re: Review Request 115202: Allow building KConfigWidgets on Windows

2014-01-21 Thread Luigi Toscano
On Jan. 21, 2014, 10:29 p.m., Luigi Toscano wrote: Jut to be sure, are the two changes (optional KDocTools and the not-iterator hack) unrelated? Alexander Richardson wrote: two separate commits, however kdoctools is broken on windows so I made it optional to allow building

Re: Review Request 115202: Allow building KConfigWidgets on Windows

2014-01-21 Thread Luigi Toscano
On Jan. 21, 2014, 10:29 p.m., Luigi Toscano wrote: Jut to be sure, are the two changes (optional KDocTools and the not-iterator hack) unrelated? Alexander Richardson wrote: two separate commits, however kdoctools is broken on windows so I made it optional to allow building

Re: Review Request 115209: Fix KDoctools build on Windows

2014-01-22 Thread Luigi Toscano
by redefining only docbookl10nhelper_EXE into the WIN32 block? Could you please add the kdewin group as reviewers so that they can check if it works with gcc too? - Luigi Toscano On Jan. 22, 2014, 1:26 a.m., Alexander Richardson wrote

Re: Review Request 115213: Remove KDE4_CREATE_HTML_HANDBOOK

2014-01-22 Thread Luigi Toscano
On Jan. 22, 2014, 11:32 a.m., Aleix Pol Gonzalez wrote: Well, but frameworks are not only for frameworks. They're all ported because I ported them. OTOH, there will be non-ported applications, that's why we provide this warning. Luigi Toscano wrote: You ported

Re: Review Request 115213: Remove KDE4_CREATE_HTML_HANDBOOK

2014-01-22 Thread Luigi Toscano
://git.reviewboard.kde.org/r/115213/ --- (Updated Jan. 22, 2014, 7:01 a.m.) Review request for KDE Frameworks and Luigi Toscano. Repository: kdoctools Description --- As discussed in Review Request 115077 Diffs

Re: Review Request 115213: Remove KDE4_CREATE_HTML_HANDBOOK

2014-01-22 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115213/#review48004 --- Ship it! Ship It! - Luigi Toscano On Jan. 22, 2014, 7:01

Re: Review Request 115237: Relocate KDE4_CREATE_HANDBOOK

2014-01-22 Thread Luigi Toscano
with me (other opinions are welcome of course!) - Luigi Toscano On Jan. 22, 2014, 9:28 p.m., David Narváez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115237

Re: Review Request 115239: Relocate KDE4_CREATE_HANDBOOK

2014-01-22 Thread Luigi Toscano
with me (other opinions are welcome of course!) - Luigi Toscano On Jan. 22, 2014, 9:29 p.m., David Narváez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115239

Re: Review Request 115234: Only set QT_STRICT_ITERATORS when not compiling with MSVC

2014-01-23 Thread Luigi Toscano
On Jan. 23, 2014, 9:28 a.m., David Faure wrote: Oh, OK, didn't know this was broken on MSVC. Worth a Qt fix or at least bugreport? Thiago reported it: see http://lists.kde.org/?l=kde-buildsystemm=139042097719628w=2 and https://codereview.qt-project.org/#change,76311 - Luigi

Re: Review Request 115209: Fix KDoctools build on Windows

2014-01-27 Thread Luigi Toscano
an opinion from kdewin group - Luigi Toscano On Jan. 22, 2014, 3:12 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115209

Re: Review Request 115440: Rename KDE4_SERIALIZE_TOOL to KDOCTOOLS_SERIALIZE_TOOL And Add Setter

2014-02-03 Thread Luigi Toscano
place, we can always rediscuss (and redefine this variable to use the generic one). I don't think it will happen but let's see :) - Luigi Toscano On Feb. 3, 2014, 8:26 a.m., David Narváez wrote: --- This is an automatically generated e

Review Request 115597: Move customization directory from ksgmltools2 to kdoctools5

2014-02-09 Thread Luigi Toscano
--- Documentation of higher level frameworks (kio) and applications (kate, konsole) compiles. Thanks, Luigi Toscano ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115597: Move customization directory from ksgmltools2 to kdoctools5

2014-02-11 Thread Luigi Toscano
/xslt.cpp 79578ed Diff: https://git.reviewboard.kde.org/r/115597/diff/ Testing --- Documentation of higher level frameworks (kio) and applications (kate, konsole) compiles. Thanks, Luigi Toscano ___ Kde-frameworks-devel mailing list Kde

Re: Review Request 115708: Build on Mac OS X

2014-02-12 Thread Luigi Toscano
. I have no idea about Windows and I don't have the resources to test it, but I hope this will be checked. - Luigi Toscano On Feb. 12, 2014, 9:46 p.m., Harald Fernengel wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request 115708: Build on Mac OS X

2014-02-12 Thread Luigi Toscano
: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115708/ --- (Updated Feb. 12, 2014, 9:46 p.m.) Review request for Documentation, KDE Frameworks and Luigi Toscano. Repository: kdoctools Description

Re: Review Request 115209: Fix KDoctools build on Windows

2014-02-13 Thread Luigi Toscano
it! src/xslt.cpp https://git.reviewboard.kde.org/r/115209/#comment34978 As you are here, can you please change this to const QString result = ... ? - Luigi Toscano On Feb. 13, 2014, 7:56 p.m., Alexander Richardson wrote

Re: Review Request 115744: The WIN32 part of this if statement doesn't seem to work - drop it

2014-02-14 Thread Luigi Toscano
is really needed. The origin of that code traces back to this commit (with a reference https://bugs.kde.org/show_bug.cgi?id=293610): http://quickgit.kde.org/?p=kdelibs.gita=commith=38b5e7f937b5d2c291c5b20a0c8648632084dde5 - Luigi Toscano On Feb. 14, 2014, 12:29 a.m., Alexander Richardson wrote

Review Request 115853: Remove unused definition

2014-02-17 Thread Luigi Toscano
--- DOCBOOK_XML_CURRDTD is not used, so remove its definition (leftover of kdelibs splitting). Diffs - src/ioslaves/help/config-help.h.cmake f2fe22c Diff: https://git.reviewboard.kde.org/r/115853/diff/ Testing --- kio compiles and installs. Thanks, Luigi Toscano

Re: Review Request 115853: Remove unused definition

2014-02-17 Thread Luigi Toscano
/115853/#review50115 --- On Feb. 17, 2014, 10:03 p.m., Luigi Toscano wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115853

Review Request 115876: More generic DocBookXML - DocBookXML4

2014-02-18 Thread Luigi Toscano
find-modules/FindDocBookXML4.cmake PRE-CREATION Diff: https://git.reviewboard.kde.org/r/115876/diff/ Testing --- Compiles (some changes are needed in KDocTools, I will add them to another review). Thanks, Luigi Toscano ___ Kde-frameworks

Review Request 115879: DocBookXML has been renamed, use the new exported variables

2014-02-18 Thread Luigi Toscano
-kdoctools.h.cmake f2fe22c src/CMakeLists.txt 241d56f src/customization/dtd/kdex.dtd.cmake c643d9b Diff: https://git.reviewboard.kde.org/r/115879/diff/ Testing --- Compiles, the relevant files (like customization/dtd/kdex.dtd) are generated Thanks, Luigi Toscano

Re: Review Request 115876: More generic DocBookXML - DocBookXML4

2014-02-18 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115876/#review50181 --- On Feb. 18, 2014, 10:52 p.m., Luigi Toscano wrote

Re: Review Request 115897: Remove FindDocBook*.cmake

2014-02-19 Thread Luigi Toscano
would like to make sure that the needed files (4.2) are really there, so I would like to call FindDocBookXML4 for that. - Luigi Toscano On Feb. 19, 2014, 12:47 p.m., Alex Merry wrote: --- This is an automatically generated e-mail

Re: Review Request 115896: Import FindDocBook*.cmake from extra-cmake-modules

2014-02-19 Thread Luigi Toscano
in CMakeLists.txt mean that they are going to exported? - Luigi Toscano On Feb. 19, 2014, 12:47 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115896

Re: Review Request 115897: Remove FindDocBook*.cmake

2014-02-19 Thread Luigi Toscano
On Feb. 19, 2014, 12:52 p.m., Luigi Toscano wrote: Uhm, well, not sure about the non-usage in kde4support: I would like to make sure that the needed files (4.2) are really there, so I would like to call FindDocBookXML4 for that. Alex Merry wrote: Oh, I see, it's going to look

Re: Review Request 115818: Support more catalogs and reduce code duplication

2014-02-19 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115818/#review50252 --- On Feb. 16, 2014, 8:16 p.m., Luigi Toscano wrote

Re: Review Request 115744: Fix projects using KDocTools on windows.

2014-02-19 Thread Luigi Toscano
/ --- (Updated Feb. 19, 2014, 7:45 p.m.) Review request for Documentation, KDE Frameworks and Luigi Toscano. Repository: kdoctools Description --- Fix projects using KDocTools on windows. If ${CMAKE_INSTALL_PREFIX}/${DATA_INSTALL_DIR} contained /../ elements file(RELATIVE_PATH

Re: Review Request 115897: Remove FindDocBook*.cmake

2014-02-19 Thread Luigi Toscano
On Feb. 19, 2014, 12:52 p.m., Luigi Toscano wrote: Uhm, well, not sure about the non-usage in kde4support: I would like to make sure that the needed files (4.2) are really there, so I would like to call FindDocBookXML4 for that. Alex Merry wrote: Oh, I see, it's going to look

Re: Review Request 115818: Support more catalogs and reduce code duplication

2014-02-19 Thread Luigi Toscano
- src/meinproc.cpp 86e83ae src/xslt.h 6fd2dae src/xslt.cpp 70e0d6a Diff: https://git.reviewboard.kde.org/r/115818/diff/ Testing --- Thanks, Luigi Toscano ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Re: Review Request 115897: Remove FindDocBook*.cmake

2014-02-20 Thread Luigi Toscano
On Feb. 19, 2014, 12:52 p.m., Luigi Toscano wrote: Uhm, well, not sure about the non-usage in kde4support: I would like to make sure that the needed files (4.2) are really there, so I would like to call FindDocBookXML4 for that. Alex Merry wrote: Oh, I see, it's going to look

Re: Review Request 115744: Fix projects using KDocTools on windows.

2014-02-20 Thread Luigi Toscano
, the change looks fine and it's windows only. There is enough time to fix it before the final release. - Luigi Toscano On Feb. 19, 2014, 7:45 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit

DocBookXML 4.5, the plan

2014-02-22 Thread Luigi Toscano
Hi all, these are the steps of plan for bumping the default DocBook XML version to 4.5 while keeping the compatibility on the old 4.2-based when kde4support is used: 1) commit rename/changes of FindDocBookXML (RR 115876 and 115879); 2) kde4support: copy files FindDocBookXML, catalog.xml,

Re: Review Request 115876: More generic DocBookXML - DocBookXML4

2014-02-22 Thread Luigi Toscano
On Feb. 21, 2014, 7:47 p.m., Luigi Toscano wrote: The files have been moved to kdoctools, should I open a new review against the kdoctools component or can I get a shipit here? :) Alex Merry wrote: I thought I'd already made this reply, but let's try again... (maybe I did

Re: Review Request 115876: More generic DocBookXML - DocBookXML4

2014-02-22 Thread Luigi Toscano
On Feb. 21, 2014, 7:47 p.m., Luigi Toscano wrote: The files have been moved to kdoctools, should I open a new review against the kdoctools component or can I get a shipit here? :) Alex Merry wrote: I thought I'd already made this reply, but let's try again... (maybe I did

Re: Review Request 115879: DocBookXML has been renamed, use the new exported variables

2014-02-22 Thread Luigi Toscano
customization/dtd/kdex.dtd) are generated Thanks, Luigi Toscano ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115876: More generic DocBookXML - DocBookXML4

2014-02-22 Thread Luigi Toscano
). Thanks, Luigi Toscano ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 115956: More generic (renamed) KDocBookXML4.cmake

2014-02-22 Thread Luigi Toscano
is generated. Thanks, Luigi Toscano ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115879: DocBookXML has been renamed, use the new exported variables

2014-02-22 Thread Luigi Toscano
/#review50436 --- On Feb. 22, 2014, 6:19 p.m., Luigi Toscano wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115879

Re: Review Request 115897: Remove FindDocBook*.cmake

2014-02-22 Thread Luigi Toscano
? - Luigi Toscano On Feb. 19, 2014, 11:45 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115897/ --- (Updated

Re: Review Request 115956: More generic (renamed) KDocBookXML4.cmake

2014-02-23 Thread Luigi Toscano
/customization/dtd/kdex.dtd.cmake c643d9b Diff: https://git.reviewboard.kde.org/r/115956/diff/ Testing --- Compiles, documentation is generated. Thanks, Luigi Toscano ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org

Re: Review Request 115897: Remove FindDocBook*.cmake

2014-02-23 Thread Luigi Toscano
On Feb. 22, 2014, 6:29 p.m., Luigi Toscano wrote: As this was already committed, can this RR be closed? Alex Merry wrote: Actually, I never committed this one, since I never got a ship it. I added the files to kdoctools, but never removed them from e-c-m. Is a shipit really needed

Re: Review Request 115956: More generic (renamed) DocBookXML4.cmake, few fixes

2014-02-23 Thread Luigi Toscano
/kdex.dtd.cmake c643d9b Diff: https://git.reviewboard.kde.org/r/115956/diff/ Testing --- Compiles, documentation is generated. Thanks, Luigi Toscano ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo

Re: KDocTools history import

2014-02-24 Thread Luigi Toscano
Alex Merry wrote: I screwed up the history import of the FindDocBook*.cmake files from e-c-m into KDocTools, so Luigi asked me to do it again. This involves removing those files, then merging in a more sensible history (that isn't curtailed like the other one was). This can be found at

Re: Review Request 116037: change entities to reflect new branding

2014-02-25 Thread Luigi Toscano
the final release), but please do *not* commit this until the changes described in KDocTools history import thread (kde-frameworks-devel) are pushed. - Luigi Toscano On Feb. 25, 2014, 1:02 a.m., T.C. Hollingsworth wrote

Re: Review Request 115956: More generic (renamed) DocBookXML4.cmake, few fixes

2014-02-25 Thread Luigi Toscano
. Thanks, Luigi Toscano ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115956: More generic (renamed) DocBookXML4.cmake, few fixes

2014-02-25 Thread Luigi Toscano
. Thanks, Luigi Toscano ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115897: Remove FindDocBook*.cmake

2014-02-25 Thread Luigi Toscano
to kdoctools, it's time to remove them from ecm. - Luigi Toscano On Feb. 19, 2014, 11:45 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115897

Re: KDE 5 versioning in documentation

2014-02-25 Thread Luigi Toscano
Martin Klapetek wrote: Hey, On Tue, Feb 25, 2014 at 1:32 AM, T.C. Hollingsworth wrote: Will the KDE Software Compilation still be a thing in the KF5 era, complete with its own versioned releases? If that's the case, we'll probably just want to change KDE to KDE SC in the

Review Request 116069: Compatibility support for DocBookXML 4.2

2014-02-25 Thread Luigi Toscano
PRE-CREATION Diff: https://git.reviewboard.kde.org/r/116069/diff/ Testing --- Compilation of kde4support (with RR116068), then compilation of konsole. Thanks, Luigi Toscano ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Review Request 116068: Bump supported DocBookXML version to 4.5

2014-02-25 Thread Luigi Toscano
/116068/diff/ Testing --- Compilation (including the other RR) Thanks, Luigi Toscano ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116069: Compatibility support for DocBookXML 4.2

2014-02-25 Thread Luigi Toscano
: https://git.reviewboard.kde.org/r/116069/diff/ Testing --- Compilation of kde4support (with RR116068), then compilation of konsole. Thanks, Luigi Toscano ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman

Re: Review Request 116037: change entities to reflect new branding

2014-02-27 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116037/#review51163 --- Ship it! This review can go in :) - Luigi Toscano On Feb

Re: Review Request 116068: Bump supported DocBookXML version to 4.5

2014-02-27 Thread Luigi Toscano
(including the other RR) Thanks, Luigi Toscano ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116069: Compatibility support for DocBookXML 4.2

2014-02-27 Thread Luigi Toscano
/catalog4.xml PRE-CREATION src/customization/dtd/kdex.dtd.cmake PRE-CREATION Diff: https://git.reviewboard.kde.org/r/116069/diff/ Testing --- Compilation of kde4support (with RR116068), then compilation of konsole. Thanks, Luigi Toscano ___ Kde

Re: Review Request 116124: Always compile static lib with -fPIC

2014-02-27 Thread Luigi Toscano
, my knowledge in this area is not so much but you convinced me, and we have some time for going back in case of issues. - Luigi Toscano On Feb. 27, 2014, 3:21 p.m., Kevin Funk wrote: --- This is an automatically generated e-mail

Re: Review Request 116037: change entities to reflect new branding

2014-02-28 Thread Luigi Toscano
/ --- (Updated Feb. 25, 2014, 1:02 a.m.) Review request for Documentation, KDE Frameworks, Luigi Toscano, Burkhard Lück, and Yuri Chornoivan. Repository: kdoctools Description --- -kde; is no longer semantically identified as an acronym

Re: kjsembed tier (Re: Build failed in Jenkins: kjsembed_master_qt5 #27)

2014-03-01 Thread Luigi Toscano
David Faure wrote: On Saturday 01 March 2014 12:49:02 Aurélien Gâteau wrote: If I am not mistaken, KJSEmbed depends on KDocTools because it uses kdoctools_create_manpage. Would it be an option to generate the man page without KDocTools. It's a bit sad to bump it from tier 2 to tier 3 just

Re: Review Request 116069: Compatibility support for DocBookXML 4.2

2014-03-04 Thread Luigi Toscano
: https://git.reviewboard.kde.org/r/116069/diff/ Testing --- Compilation of kde4support (with RR116068), then compilation of konsole. Thanks, Luigi Toscano ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org

DocBookXML version is 4.5 in KF5: check your documentation

2014-03-04 Thread Luigi Toscano
Hi all, the version of DocBookXML used by our documentation has been changed in Frameworks; our custom DTD is now based on 4.5 instead of 4.2. The change should be *almost* painless, because the new version is backward compatibile. Only the DTD needs to be changed. Exception: if your application

Review Request 116604: Allow directories with . as output for meinproc

2014-03-04 Thread Luigi Toscano
) with -o /something/with/a/.dotdir/myfile.txt (the directory must exist), no error anymore and the file is generated. Thanks, Luigi Toscano ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Re: Review Request 116604: Allow directories with . as output for meinproc

2014-03-06 Thread Luigi Toscano
: https://git.reviewboard.kde.org/r/116604/#review52091 --- On March 5, 2014, 1:06 a.m., Luigi Toscano wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 116604: Allow directories with . as output for meinproc

2014-03-08 Thread Luigi Toscano
Diff: https://git.reviewboard.kde.org/r/116604/diff/ Testing --- Run meinproc5 (and 4) with -o /something/with/a/.dotdir/myfile.txt (the directory must exist), no error anymore and the file is generated. Thanks, Luigi Toscano ___ Kde

Re: Review Request 116650: Remove unused targets from KDocToolsMacros.cmake

2014-03-08 Thread Luigi Toscano
://git.reviewboard.kde.org/r/116650/#comment37094 It is needed indeed... - Luigi Toscano On March 7, 2014, 3:05 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116650

Review Request 116670: Use absolute paths to refer to entities/elements defined in kdoctools

2014-03-09 Thread Luigi Toscano
documentation still uses the old DTD (oktate) compiles correctly. Thanks, Luigi Toscano ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 116681: Fix kio-help by adding a separator

2014-03-09 Thread Luigi Toscano
/kio_help.cpp 85b7975 Diff: https://git.reviewboard.kde.org/r/116681/diff/ Testing --- kioclient cat help:/kioslave/ftp (from frameworks branch of kde-runtime) now works. Thanks, Luigi Toscano ___ Kde-frameworks-devel mailing list Kde

Re: Review Request 116681: Fix kio-help by adding a separator

2014-03-09 Thread Luigi Toscano
other parts of code which use QStandardPaths should be checked. Diffs - src/ioslaves/help/kio_help.cpp 85b7975 Diff: https://git.reviewboard.kde.org/r/116681/diff/ Testing --- kioclient cat help:/kioslave/ftp (from frameworks branch of kde-runtime) now works. Thanks, Luigi

Review Request 116685: Import documentationnotfound in kio, used by kio-help

2014-03-09 Thread Luigi Toscano
/documentationnotfound/index.docbook PRE-CREATION src/ioslaves/help/kio_help.cpp d693442 Diff: https://git.reviewboard.kde.org/r/116685/diff/ Testing --- kioclient cat help:/foobar shows the content of documentationnotfound instead of There is no documentation available for /foobar. Thanks, Luigi

Re: Review Request 116685: Import documentationnotfound in kio, used by kio-help

2014-03-10 Thread Luigi Toscano
of There is no documentation available for /foobar. Thanks, Luigi Toscano ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116650: Give unique names to the targets created by KDocToolsMacros.cmake

2014-03-10 Thread Luigi Toscano
/116650/#comment37141 Does it work on Windows? - Luigi Toscano On March 10, 2014, 5:17 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116650

Re: Review Request 116650: Give unique names to the targets created by KDocToolsMacros.cmake

2014-03-11 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116650/#review52690 --- Ship it! Perfect, thanks! - Luigi Toscano On March 11

Re: Review Request 116685: Import documentationnotfound in kio, used by kio-help

2014-03-12 Thread Luigi Toscano
the content of documentationnotfound instead of There is no documentation available for /foobar. Thanks, Luigi Toscano ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116685: Import documentationnotfound in kio, used by kio-help

2014-03-12 Thread Luigi Toscano
the content of documentationnotfound instead of There is no documentation available for /foobar. Thanks, Luigi Toscano ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116781: List catalog from all install dirs

2014-03-13 Thread Luigi Toscano
; as a suggestion, I would explicitly mention that this is for environments where each module is installed using a different prefix as I wrote in the related commit (for https://git.reviewboard.kde.org/r/116670/). - Luigi Toscano On March 13, 2014, 12:59 p.m., Aurélien Gâteau wrote

Re: Review Request 116785: Unbreak bootstrapping

2014-03-13 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116785/#review52892 --- Ship it! Discussed on IRC - Luigi Toscano On March 13

Re: Review Request 116786: Make error handling more consistent and fail earlier

2014-03-13 Thread Luigi Toscano
/#comment37240 Please save the value of tss before the call, otherwise it will be always empty - Luigi Toscano On March 13, 2014, 5:39 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 116786: Make error handling more consistent and fail earlier

2014-03-14 Thread Luigi Toscano
/#comment37262 (spotted by Pino, thanks) could you please wrap the definition of the body of DIE using the 'do {} while(0)' syntax? http://stackoverflow.com/questions/257418/do-while-0-what-is-it-good-for After that, feel free to commit and thanks again! - Luigi Toscano On March

Re: Review Request 116037: change entities to reflect new branding

2014-03-22 Thread Luigi Toscano
: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116037/ --- (Updated Feb. 25, 2014, 2:02 a.m.) Review request for Documentation, KDE Frameworks, Luigi Toscano, Burkhard

Re: Review Request 116979: Rename the bootstrap CMake variable

2014-03-22 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116979/#review53769 --- Ship it! Well, nothing to say, thanks! - Luigi Toscano

Re: Review Request 117011: Use bin/../share on Windows as a workaround

2014-03-23 Thread Luigi Toscano
not sure this is the correct solution, but I would prefer if someone with more knowledge of QStandardPaths and Windows could speak up. - Luigi Toscano On March 24, 2014, 12:28 a.m., Andrius da Costa Ribas wrote

Re: Review Request 117061: Explicitly state link interface for libKF5XsltKde

2014-03-25 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117061/#review54133 --- Ship it! Ship It! - Luigi Toscano On March 25, 2014, 5:44

Re: Final kde-runtime splitting plan

2014-03-25 Thread Luigi Toscano
Àlex Fiestas ha scritto: Hi there Today Aleix and I are starting to split kde-runtime so we have gone through all the components again making sure that everything has a suitable destination. The result is this [1] wiki. Please, check that you are ok with the destination of each

Review Request 117106: Remove support for htdig index generation from meinproc

2014-03-26 Thread Luigi Toscano
Diff: https://git.reviewboard.kde.org/r/117106/diff/ Testing --- It compiles, documentation is generated (also for other higher level frameworks, tested with kio) Thanks, Luigi Toscano ___ Kde-frameworks-devel mailing list Kde-frameworks-devel

Re: Review Request 116037: change entities to reflect new branding

2014-03-27 Thread Luigi Toscano
to https://mail.kde.org/pipermail/kde-frameworks-devel/2014-February/012182.html Plus I've been a bit too busy to even reply to list mail. :-( Will try and finish this up by the end of the week. Luigi Toscano wrote: Ping? Friday 28th is the tag date for beta1. Kevin Ottens

Re: Review Request 117106: Remove support for htdig index generation from meinproc

2014-03-27 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117106/#review54327 --- On March 27, 2014, 9:49 p.m., Luigi Toscano wrote

Re: Review Request 117106: Remove support for htdig index generation from meinproc

2014-03-27 Thread Luigi Toscano
-meinproc5.8.docbook 7b4c535 src/customization/htdig_index.xsl 7aa9113 src/meinproc.cpp a7b2e07 Diff: https://git.reviewboard.kde.org/r/117106/diff/ Testing --- It compiles, documentation is generated (also for other higher level frameworks, tested with kio) Thanks, Luigi Toscano

Re: kcoreaddons5 extraction

2014-03-28 Thread Luigi Toscano
On Friday 28 of March 2014 19:28:16 Yuri Chornoivan wrote: Hi, https://projects.kde.org/projects/frameworks/kcoreaddons/repository/revision s/master/entry/src/lib/kaboutdata.cpp#L258 licenseShort = QCoreApplication::translate(KAboutLicense, @item license (short name), GPL v2); is

Re: [kde-frameworks-devel] Regarding entry.desktop files

2014-03-29 Thread Luigi Toscano
David Faure ha scritto: On Friday 28 March 2014 21:27:05 Jonathan Riddell wrote: Can you say if this is the right thing to do? It'll mean the other files in kde-l10n-* also need renamed. Yes. I'm a bit confused now: what files are to be renamed? The ones in the SVN repository under

Re: I broke kwin

2014-04-01 Thread Luigi Toscano
On Tuesday 01 of April 2014 15:01:20 David Faure wrote: but I can't fix it? ;) I removed a very old obsolete method from kwindowsystem, then I noticed kwin was still using it, but I can't push the fix? [...] To g...@git.kde.org:kde-workspace ! [remote rejected] master - master (hook

Re: Review Request 117328: Update the docbook

2014-04-02 Thread Luigi Toscano
and the documentation: Sonnet is Tier 1, KDocTools is Tier 2 (and even if it was Tier 1, the rule would forbid its usage) :( - Luigi Toscano On April 2, 2014, 1:05 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply

Review Request 117341: Update documentation templates for the KF5 world

2014-04-02 Thread Luigi Toscano
: kdoctools Description --- - adapt to the split world, no references to SC Diffs - src/man-template.docbook 6c2e995 src/template.docbook 3b5dc8a Diff: https://git.reviewboard.kde.org/r/117341/diff/ Testing --- Thanks, Luigi Toscano

  1   2   3   4   5   6   7   8   9   10   >