Plugin locator performance ballpark

2013-09-04 Thread Sebastian Kügler
Hi, I've had a look at the performance of loading plugins. First, some background: We've taken the first steps towards moving away from KSyCoCa for plugins. By including metadata in the plugin, we don't need to keep the metadata installed (via .desktop files) and indexed separately, but can

Re: Plugin locator performance ballpark

2013-09-09 Thread Sebastian Kügler
On Sunday, September 08, 2013 11:17:56 David Faure wrote: On Thursday 05 September 2013 01:04:52 Sebastian Kügler wrote: Reading just $PLUGINS/kf5, 52 plugins 21893.0 microsec (KServiceTypeTrader) 95835.0 microsec (Metadata) -- Reading metadata is 4-5 slower, ~100ms

Review Request 112660: KPluginInfo rework for KPluginTrader

2013-09-10 Thread Sebastian Kügler
tests still pass, no regressions encountered otherwise. Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112660: KPluginInfo rework for KPluginTrader

2013-09-11 Thread Sebastian Kügler
://git.reviewboard.kde.org/r/112660/#review39793 --- On Sept. 10, 2013, 11:32 p.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: http

Re: Review Request 112660: KPluginInfo rework for KPluginTrader

2013-09-11 Thread Sebastian Kügler
On Sept. 11, 2013, 6:22 a.m., David Gil Oliva wrote: staging/kservice/src/services/kplugininfo.cpp, line 61 http://git.reviewboard.kde.org/r/112660/diff/1/?file=188728#file188728line61 I think that two variables (hidden and _hidden) so similar are confusing. Sebastian Kügler

Review Request 112679: Make KTraderParseTree fit for searching in KPluginInfo::List

2013-09-11 Thread Sebastian Kügler
the querying in a real-world scenario, no regressions spotted - No regressions in existing tests Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112679: Make KTraderParseTree fit for searching in KPluginInfo::List

2013-09-11 Thread Sebastian Kügler
Kügler On Sept. 12, 2013, 1:33 a.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112679/ --- (Updated

Review Request 112680: KPluginTrader: QPluginLoader/metadata-based querying of Plugins

2013-09-11 Thread Sebastian Kügler
dataengine handling, it works without apparent regressions Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 112681: Tests for KPluginTrader and friends

2013-09-11 Thread Sebastian Kügler
staging/kservice/tests/pluginlocator/plugintest.h PRE-CREATION staging/kservice/tests/pluginlocator/plugintest.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112681/diff/ Testing --- make test =) All tests pass on top of my patches. Thanks, Sebastian Kügler

Re: Review Request 112660: KPluginInfo rework for KPluginTrader

2013-09-12 Thread Sebastian Kügler
pass, no regressions encountered otherwise. Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112680: KPluginTrader: QPluginLoader/metadata-based querying of Plugins

2013-09-12 Thread Sebastian Kügler
apparent regressions Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112660: KPluginInfo rework for KPluginTrader

2013-09-12 Thread Sebastian Kügler
On Sept. 11, 2013, 6:22 a.m., David Gil Oliva wrote: staging/kservice/src/services/kplugininfo.cpp, line 61 http://git.reviewboard.kde.org/r/112660/diff/1/?file=188728#file188728line61 I think that two variables (hidden and _hidden) so similar are confusing. Sebastian Kügler

Re: Review Request 112679: Make KTraderParseTree fit for searching in KPluginInfo::List

2013-09-14 Thread Sebastian Kügler
.) - Sebastian --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112679/#review39864 --- On Sept. 12, 2013, 1:33 a.m., Sebastian Kügler wrote

Re: Review Request 112679: Make KTraderParseTree fit for searching in KPluginInfo::List

2013-09-14 Thread Sebastian Kügler
pass - Ported Plasma::PluginLoader from KServiceTypeTrader to KPluginTrader and tested the querying in a real-world scenario, no regressions spotted - No regressions in existing tests Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde

Re: Review Request 112681: Tests for KPluginTrader and friends

2013-09-14 Thread Sebastian Kügler
, 2013, 3:35 a.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112681/ --- (Updated Sept. 12, 2013, 3

Re: Review Request 112681: Tests for KPluginTrader and friends

2013-09-14 Thread Sebastian Kügler
: http://git.reviewboard.kde.org/r/112681/diff/ Testing --- make test =) All tests pass on top of my patches. Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Re: Review Request 112681: Tests for KPluginTrader and friends

2013-09-16 Thread Sebastian Kügler
On Sunday, September 15, 2013 08:42:31 David Faure wrote: Data-driven tests *can* be run separately (and therefore qDebugs don't get confusing), using the methodName:rowName syntax as command-line argument. Data-driven tests have the huge benefit that they reduce code duplication, and they

Re: Review Request 112681: Tests for KPluginTrader and friends

2013-09-17 Thread Sebastian Kügler
-CREATION staging/kservice/tests/pluginlocator/plugintest.h PRE-CREATION staging/kservice/tests/pluginlocator/plugintest.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112681/diff/ Testing --- make test =) All tests pass on top of my patches. Thanks, Sebastian Kügler

Re: Review Request 112681: Tests for KPluginTrader and friends

2013-09-18 Thread Sebastian Kügler
tests pass on top of my patches. Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112681: Tests for KPluginTrader and friends

2013-09-19 Thread Sebastian Kügler
--- On Sept. 18, 2013, 12:12 p.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112681

Re: Review Request 112823: Move KPixmapSequencer to KWidgetsAddons

2013-09-19 Thread Sebastian Kügler
On Sept. 19, 2013, 2:27 p.m., Aurélien Gâteau wrote: tier1/kwidgetsaddons/tests/CMakeLists.txt, line 6 http://git.reviewboard.kde.org/r/112823/diff/1/?file=190546#file190546line6 In KDE4 days programs marked as test had a KDESRCDIR define set which pointed to

Re: kde4_add_plugin on KF5

2013-09-19 Thread Sebastian Kügler
On Thursday, September 19, 2013 18:26:54 Aleix Pol wrote: Well, I thought of something like that, but I checked and there are projects using the different arguments that kde4_add_plugin has. I don't see the point of oversimplifying there. I didn't mean oversimplifying, but: - to provide

kde-workspace master becomes Qt5-based

2013-09-19 Thread Sebastian Kügler
Hi all, We're planning to merge the frameworks-scratch branch of kde-workspace into master next Monday. That means if you're building your Plasma yourself from Git (and you're not yet ready for Plasma2 ;)), you should switch to the KDE/4.11 branch. The build will fail otherwise, so you will

Re: Frameworks Overview

2013-09-23 Thread Sebastian Kügler
Hey, On Monday, September 23, 2013 00:27:21 Cornelius Schumacher wrote: On Thursday 19 September 2013 Sebastian Kügler wrote: http://community.kde.org/Frameworks/Overview I have put the data on Inqlude (see http://inqlude.org/edge.html). Thanks. One issue though, we're duplicating

Re: Frameworks Overview

2013-09-24 Thread Sebastian Kügler
On Monday, September 23, 2013 15:08:57 Jos Poortvliet wrote: On Mon, Sep 23, 2013 at 11:43 AM, Sebastian Kügler se...@kde.org wrote: Technically, this is the current focus. We're splitting kdelibs. As to communication, it probably needs a bit of boilerplate. (Which the bits I wrote don't

Fwd: Reminder: use KF5::foo instead of ${foo_LIBRARIES} in CMakeLists

2013-09-25 Thread Sebastian Kügler
CMake-gods, can you confirm the below? (It's inconsistent with my understanding, and how we've done it in the past months, I'd like to have a specialist opinion before going around and changing every single CMakeLists.txt in Plasma.) Thanks, -- sebas -- Forwarded Message

Review Request 112929: Remove KPluginVerificationData

2013-09-25 Thread Sebastian Kügler
/kpluginloader.cpp 91a3857 Diff: http://git.reviewboard.kde.org/r/112929/diff/ Testing --- It builds, the warning is gone. Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman

Re: Review Request 112929: Remove KPluginVerificationData

2013-09-25 Thread Sebastian Kügler
216923e staging/kservice/src/plugin/kpluginloader.cpp 91a3857 Diff: http://git.reviewboard.kde.org/r/112929/diff/ Testing --- It builds, the warning is gone. Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel

Re: Review Request 112929: Remove KPluginVerificationData

2013-09-25 Thread Sebastian Kügler
216923e staging/kservice/src/plugin/kpluginloader.cpp 91a3857 Diff: http://git.reviewboard.kde.org/r/112929/diff/ Testing --- It builds, the warning is gone. Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel

Re: Fwd: Reminder: use KF5::foo instead of ${foo_LIBRARIES} in CMakeLists

2013-09-25 Thread Sebastian Kügler
On Wednesday, September 25, 2013 17:42:35 Aurélien Gâteau wrote: Replying to myself: this topic was discussed on IRC with Stephen Kelly, the result is the following: # Short version 1. To use the Foo framework within another framework whose code is in kdelibs, use Foo:

KParts / KIOConfig: Please unbreak plasma-framework

2013-09-26 Thread Sebastian Kügler
Hi, The recent changes in KParts and KIO have caused plasma-framework to fail building. First, KParts is not found, adding a find_package call makes it complain about KIOCore not being found. I've tried adding a KIOCoreConfig.cmake, but didn't manage to make it working. After about an hour of

Re: [kdelibs/frameworks] /: Find KParts in KDELibs4Config.cmake

2013-09-26 Thread Sebastian Kügler
On Thursday, September 26, 2013 14:23:01 Stephen Kelly wrote: Git commit aac41bc93595a0f341886692fba48717a1a9e2a9 by Stephen Kelly. Committed on 26/09/2013 at 14:22. Pushed by skelly into branch 'frameworks'. Find KParts in KDELibs4Config.cmake This seems to fix my build. Thanks, Steve! --

Re: KIOWidgets and KFile

2013-09-29 Thread Sebastian Kügler
On Sunday, September 29, 2013 20:50:28 David Faure wrote: This is clearly because kbookmarks was written as part of kio, and with konqueror in mind. I guess the question is how generic we want KBookmarks to be, i.e. should it work without KIO altogether (at the expense of losing automatic

Re: KIOWidgets and KFile

2013-09-30 Thread Sebastian Kügler
On Sunday, September 29, 2013 23:49:15 Mark wrote: If i'm not mistaken, Dolphin is also using KBookmarks. Would your suggestion keep it alive for dolphin? Or would that mean creating a plugin that can read/write bookmarks to any file? It would work just like it is now. -- sebas

Re: KIOWidgets and KFile

2013-09-30 Thread Sebastian Kügler
On Monday, September 30, 2013 09:03:36 David Faure wrote: On Sunday 29 September 2013 22:31:38 Sebastian Kügler wrote: [...] I imagine KBookmark being a more service-like thing, rather than a mechanism to store and read bookmarks. What you say makes sense, it sure sounds like a future

Re: kde-workspace master becomes Qt5-based

2013-10-01 Thread Sebastian Kügler
On Tuesday, October 01, 2013 15:11:51 Stephen Kelly wrote: We're planning to merge the frameworks-scratch branch of kde-workspace into master next Monday. I tried building the branch. It requires qimageblitz, which I didn't see a Qt 5 version for, and soprano which has a non-building

Re: Review Request 112880: Added KColorSchemeToken class.

2013-10-01 Thread Sebastian Kügler
int here loses the type-safety. Why no use the corresponding enums? It would also make the code more readable. (Same issue for all the other methods.) - Sebastian Kügler On Sept. 29, 2013, 4:27 p.m., Denis Kuplyakov wrote

Re: Review Request 113046: Move kconfigwidgets to tier3

2013-10-02 Thread Sebastian Kügler
On Wednesday, October 02, 2013 11:09:59 Stephen Kelly wrote: Aurélien Gâteau wrote: Move kconfigwidgets to tier3 When I suggested tiers, I proposed that tier2 frameworks could depend on other tier2 frameworks. http://thread.gmane.org/gmane.comp.kde.devel.core/67458/focus=67520

Re: Review Request 113086: KDeclarative cleanup

2013-10-04 Thread Sebastian Kügler
. I suppose we need to adjust the linker targets in plasma-framework and kde-workspace, too? If you don't have a patch for that as well, let me know, and I'll change it shortly after you've committed this one. - Sebastian Kügler On Oct. 3, 2013, 8:02 p.m., Aleix Pol Gonzalez wrote

Re: Review Request 113086: KDeclarative cleanup

2013-10-04 Thread Sebastian Kügler
On Oct. 4, 2013, 11:42 a.m., Sebastian Kügler wrote: Looking good, lots of incremental improvements, too. I suppose we need to adjust the linker targets in plasma-framework and kde-workspace, too? If you don't have a patch for that as well, let me know, and I'll change it shortly

Re: Review Request 113086: KDeclarative cleanup

2013-10-04 Thread Sebastian Kügler
On Oct. 4, 2013, 11:42 a.m., Sebastian Kügler wrote: Looking good, lots of incremental improvements, too. I suppose we need to adjust the linker targets in plasma-framework and kde-workspace, too? If you don't have a patch for that as well, let me know, and I'll change it shortly

kio-related build error in plasma-framework

2013-10-04 Thread Sebastian Kügler
Hi, I'm getting a build error in a few places in plasma-framework, kio isn't found. I can't seem to figure out why, maybe someone who has a better overview of what in KIO is where, and what I need to tell cmake to figure this out? The error is:

more build problems around KIO

2013-10-07 Thread Sebastian Kügler
Hi, I'm still struggling to get kde-workspace (and kde-runtime) to build after Friday's changes. Following Kevin's change in plasma-framework, I've removed KIO from the KF5 imports. The problem is now: CMake Warning at /home/sebas/kf5/install/lib64/cmake/Kross/KrossConfig.cmake:31

Re: more build problems around KIO

2013-10-07 Thread Sebastian Kügler
On Monday, October 07, 2013 19:13:02 Alexander Neundorf wrote: As the error message says, KDeclarative links against the imported target KF5::KIOCore, but that target has not been imported, so cmake errors out. How exactly do I import it? Putting a find_package(KIOCore ${KF5_VERSION}

kf5_add_kdeinit_executable broken?

2013-10-08 Thread Sebastian Kügler
Hi, in Kwin (kde-workspace) we're running into the following error: CMake Error: File /home/sebas/kf5/src/kde- workspace/kwin/kcmkwin/kwinrules/_KDE5INIT_DUMMY_FILEPATH-NOTFOUND does not exist. CMake Error at /home/sebas/kf5/install/lib64/cmake/KInit/KInitMacros.cmake:17 (configure_file):

Re: Review Request 112880: Added KColorSchemeToken class.

2013-10-08 Thread Sebastian Kügler
On Oct. 1, 2013, 2:47 p.m., Sebastian Kügler wrote: kdeui/colors/kcolorschemetoken.h, line 70 http://git.reviewboard.kde.org/r/112880/diff/6/?file=192050#file192050line70 using int here loses the type-safety. Why no use the corresponding enums? It would also make the code more

Re: Review Request 113179: Make the runners compile again

2013-10-08 Thread Sebastian Kügler
this refactoring, while the benefits of this patch are then just going away. Aaron can weigh in here to say what's easiest moving forward. Mirko is the best person to review the ThreadWeaver API changes you implement. Could you add him to the reviewers for this request? thanks... - Sebastian Kügler

Re: Review Request 113179: Make the runners compile again

2013-10-08 Thread Sebastian Kügler
On Oct. 8, 2013, 9:15 p.m., Aleix Pol Gonzalez wrote: There's also runner-related code in src/declarativeimports/{core,runnermodel}, these should be reenabled as well. Possibly, they also need changes to make built. I had disabled this after a discussion with Aaron (who has refactored

Re: Review Request 112929: Remove KPluginVerificationData

2013-10-09 Thread Sebastian Kügler
rid of it. Diffs - staging/kservice/src/plugin/kexportplugin.h 216923e staging/kservice/src/plugin/kpluginloader.cpp 91a3857 Diff: http://git.reviewboard.kde.org/r/112929/diff/ Testing --- It builds, the warning is gone. Thanks, Sebastian Kügler

libnm-qt Qt5 port: -fPIC or fPIE needed?

2013-10-09 Thread Sebastian Kügler
Hi, While porting libnm-qt to Qt5, I'm running into the following problem when building the tests. I've not seen this error before, and I'd like advice how to fix it. [ 59%] Building CXX object tests/CMakeFiles/test_8021xsetting.dir/8021xsetting.cpp.o In file included from

Re: [Kde-hardware-devel] libnm-qt Qt5 port: -fPIC or fPIE needed?

2013-10-09 Thread Sebastian Kügler
On Wednesday, October 09, 2013 18:14:10 Daniel Nicoletti wrote: I have added this to some of my qt5 projects and it worked: add_definitions(-fPIC) Thanks Daniel, that helps. :) 2013/10/9 Sebastian Kügler se...@kde.org: /home/sebas/kf5/qt5/qtbase/include/QtCore/../../src/corelib/global

Re: Review Request 113179: Make the runners compile again

2013-10-10 Thread Sebastian Kügler
be committed, as it's not going to cause merge conflicts. - Sebastian Kügler On Oct. 8, 2013, 5:14 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113179

Re: kio-related build error in plasma-framework

2013-10-10 Thread Sebastian Kügler
On Friday, October 04, 2013 17:56:52 Sebastian Kügler wrote: I'm getting a build error in a few places in plasma-framework, kio isn't found. I can't seem to figure out why, maybe someone who has a better overview of what in KIO is where, and what I need to tell cmake to figure this out

Review Request 113215: Fix casing in KPty cmake vars

2013-10-12 Thread Sebastian Kügler
--- KPTY_ vars were set as uppercase, while camelcase is in line with frameworks. Diffs - tier3/kpty/KPtyConfig.cmake.in a59bce8 Diff: http://git.reviewboard.kde.org/r/113215/diff/ Testing --- Fixes a cmake error when trying to build konsole. Thanks, Sebastian Kügler

KNotifyConfig cmake vars problem

2013-10-12 Thread Sebastian Kügler
Hey, I'm trying to build konsole, which requires KNotifyConfig, but I'm having trouble importing the target. When applying the attached patch to KNotifyConfig (which I believe should add the right variables), I'm getting CMake Error at /home/sebas/kf5/install/lib/x86_64-linux-

Re: Review Request 113215: Fix casing in KPty cmake vars

2013-10-12 Thread Sebastian Kügler
--- Fixes a cmake error when trying to build konsole. Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

plasma-framework build broken

2013-10-12 Thread Sebastian Kügler
Hi Steve, It seems that one of your recent commits to plasma-frameworks broke its build: /home/sebas/kf5/src/plasma- framework/src/declarativeimports/qtextracomponents/tests/columnproxymodeltest.cpp:23:23: fatal error: qtest_kde.h: No such file or directory Readding the things you removed

Re: plasma-framework build broken

2013-10-12 Thread Sebastian Kügler
On Saturday, October 12, 2013 21:48:28 Sebastian Kügler wrote: It seems that one of your recent commits to plasma-frameworks broke its build: /home/sebas/kf5/src/plasma- framework/src/declarativeimports/qtextracomponents/tests/columnproxymodeltes t.cpp:23:23: fatal error: qtest_kde.h

Re: KNotifyConfig cmake vars problem

2013-10-12 Thread Sebastian Kügler
On Saturday, October 12, 2013 14:29:19 Stephen Kelly wrote: Sebastian Kügler wrote: Hey, I'm trying to build konsole, which requires KNotifyConfig, but I'm having trouble importing the target. Update your ecm, and konsole repos and discard your patch. It is not needed. Thanks

Re: Review Request 113215: Fix casing in KPty cmake vars

2013-10-13 Thread Sebastian Kügler
., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113215/ --- (Updated Oct. 12, 2013, 6:55 p.m.) Review

Re: Review Request 113215: Fix casing in KPty cmake vars

2013-10-13 Thread Sebastian Kügler
--- Fixes a cmake error when trying to build konsole. Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Helping out with Frameworks 5

2013-10-16 Thread Sebastian Kügler
Hi Casian, On Wednesday, October 16, 2013 14:35:39 Casian Andrei wrote: I want to help out with Frameworks 5 and/or Plasma 2. Perhaps it is best to start writing some unit tests, since I am not too familiar with the code. My favorite activities include removing chunks of obsolete and ugly

Re: Review Request 113300: Improve porting to Qt/KF5 scripts

2013-10-17 Thread Sebastian Kügler
-edit cycles. - Sebastian Kügler On Oct. 17, 2013, 5:01 a.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113300

Re: Review Request 113181: Add KDebug porting notes to KDE5PORTING.html

2013-10-17 Thread Sebastian Kügler
On Oct. 16, 2013, 9:02 p.m., Mark Gaiser wrote: KDE5PORTING.html, lines 290-295 http://git.reviewboard.kde.org/r/113181/diff/2/?file=201374#file201374line290 This is not valid anymore. It should now be qCdebug/warning/notice/... and with a category. I think it;s best to just

Review Request 113377: Add KDeclarative to known KF5 tier3 modules

2013-10-21 Thread Sebastian Kügler
-cmake-modules Description --- Subject says it all. Diffs - find-modules/FindKF5.cmake 8f95469 Diff: http://git.reviewboard.kde.org/r/113377/diff/ Testing --- find_package(KF5 ... KDeclarative) works with this patch, it doesn't work without. Thanks, Sebastian Kügler

DBusMenuQt cmake *Config

2013-10-22 Thread Sebastian Kügler
Hi Aurelien, Let's try again to finally get this resolved. :) Attached, the necessary cmake foo to have find_package(DBusMenuQt NO_MODULE) work like other frameworks do. The .diff should work, but someone had problems applying it during testing, so I've attached the whole files as well.

Re: Review Request 113377: Add KDeclarative to known KF5 tier3 modules

2013-10-23 Thread Sebastian Kügler
... KDeclarative) works with this patch, it doesn't work without. Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113415: Port KSplashQML to Qt5 + remove XLib stuff + replace x11eventFilter with DBus interface (Wayland++)

2013-10-24 Thread Sebastian Kügler
On Oct. 24, 2013, 4:17 p.m., Fredrik Höglund wrote: What's the cold startup time like for KSplashQML compared to KSplashX? Let's not forget that the reason KPlash was rewritten to only depend on X + libjpeg + libpng was so that the startup time would be limited by the time it takes

Re: Build failed in Jenkins: plasma-framework_master_qt5 #862

2013-10-28 Thread Sebastian Kügler
On Monday, October 28, 2013 17:27:14 Marco Martin wrote: On Monday 28 October 2013 17:12:20 Kevin Ottens wrote: On Monday 28 October 2013 16:07:08 KDE CI System wrote: See http://build.kde.org/job/plasma-framework_master_qt5/862/ If someone has an idea about that failure on build.kde.org

Re: Getting ecm files from the ECM package

2013-11-01 Thread Sebastian Kügler
On Friday, November 01, 2013 11:57:35 Kevin Ottens wrote: Then it is time to think of a way to integrate cmake with the separate source of find_modules. Algorithmically, it would look like PROJECT(MyApplication) FIND_MODULES_REPOSITORY(http://ecm.kde.org;) FIND_PACKAGES(KF5

Re: KEmailSettings and ksendbugmail

2013-11-04 Thread Sebastian Kügler
On Monday, November 04, 2013 12:15:50 Kevin Ottens wrote: KEmailSettings definitely belongs to a core library, not to a gui one. OK then. I still think that semantically, it'd fit better in something more PIM or desktop consistency related... but since I can't find anything where it'd

Use kde-runtime[frameworks]!

2013-11-07 Thread Sebastian Kügler
Hey all, In order to achieve more consistency across repositories, we've renamed the branch frameworks-scratch to frameworks in kde-runtime. Please do not push to frameworks-scratch anymore. (Ben, could you block this branch, if it hasn't already happened?). So, all commits go into the

Re: KDE workspace users

2013-11-15 Thread Sebastian Kügler
Hey, On Thursday, November 14, 2013 18:50:35 Jonathan Riddell wrote: With KDE Frameworks taking shape and sceenshots of Plasma 2 starting to appear it's worth looking at what else will need to be done to allow distros to ship it all. kde-runtime needs ported and there's a desire to move its

error: KF5::KDBusAddons-NOTFOUND

2013-11-18 Thread Sebastian Kügler
It seems subject broke over the weekend. kactivities fails to compile: c++: error: KF5::KDBusAddons-NOTFOUND: No such file or directory kactivities uses: find_package (KF5 CONFIG REQUIRED KDBusAddons) so it's pretty bare-bones. Could someone have a look or suggest a fix? Thanks, -- sebas

Re: error: KF5::KDBusAddons-NOTFOUND

2013-11-19 Thread Sebastian Kügler
On Monday, November 18, 2013 19:00:33 Sebastian Kügler wrote: On Monday, November 18, 2013 17:53:07 Aleix Pol wrote: On Mon, Nov 18, 2013 at 5:43 PM, Sebastian Kügler se...@kde.org wrote: It seems subject broke over the weekend. kactivities fails to compile: c++: error: KF5

Re: error: KF5::KDBusAddons-NOTFOUND

2013-11-19 Thread Sebastian Kügler
On Tuesday, November 19, 2013 15:42:47 Sebastian Kügler wrote: On Tuesday, November 19, 2013 12:48:53 Stephen Kelly wrote: Try to construct a trivial testcase using one of the targets. If that fails, post it. If it passes, bisect the difference to kactivities. I've attached a bare example

Re: error: KF5::KDBusAddons-NOTFOUND

2013-11-19 Thread Sebastian Kügler
On Tuesday, November 19, 2013 17:01:32 Aleix Pol wrote: Maybe you have different CMAKE_BUILD_TYPE in kdelibs and other build directories? I'm using the same command for them all: cmake -DCMAKE_INSTALL_PREFIX=$KF5 -DCMAKE_PREFIX_PATH=$KF5 - DCMAKE_SYSTEM_PREFIX_PATH=/usr:/usr/local:${KF5} -

Re: Fwd: Tracking bugs in Frameworks

2013-12-16 Thread Sebastian Kügler
On Monday, December 16, 2013 19:30:25 Martin Graesslin wrote: On Monday 16 December 2013 19:01:25 David Edmundson wrote: On Mon, Dec 16, 2013 at 6:08 PM, Martin Graesslin mgraess...@kde.org On Monday 16 December 2013 11:58:35 David Edmundson wrote: I think if we did that it would be a

Re: Frameworks Performance Question

2013-12-31 Thread Sebastian Kügler
On Monday, December 30, 2013 12:54:20 Christoph Cullmann wrote: On Sunday 29 December 2013 20:07:38 Christoph Cullmann wrote: #10 0x73fbeaa0 in KConfig::reparseConfiguration (this=0x688130) at /home/cullmann/local/kf5/src/frameworks/kconfig/src/core/kconfig.cpp:633 #11

Re: Review Request 115063: Created missing manpage for desktoptojson binary

2014-01-17 Thread Sebastian Kügler
hasn't really settled down yet, adding a sentence like this would probably be enough already: For further reference how to use this programme and its underlying mechanism, please refer to the documentation for the KPluginTrader class in KDE's KService framework. - Sebastian Kügler

Re: Splitting kde-workspace and kde-runtime proposal

2014-01-21 Thread Sebastian Kügler
On Tuesday, January 21, 2014 11:03:57 Bhushan Shah wrote: On Tue, Jan 21, 2014 at 1:19 AM, Àlex Fiestas afies...@kde.org wrote: In the plasma sprint we have done a session to plan what we are going to do with kde-workspace/kde-runtime repositories, here is the proposal we came with.

Re: Review Request 115605: Rename plasmapkg

2014-02-10 Thread Sebastian Kügler
weird in the Plasma context. (Most of the other visible Plasma bits carry version 2.0). - Sebastian Kügler On Feb. 9, 2014, 7:45 p.m., Hrvoje Senjan wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 115605: Rename plasmapkg

2014-02-10 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115605/#review49433 --- Ship it! Ship It! - Sebastian Kügler On Feb. 10, 2014, 11

Re: let's get ready for Google Summer of Code 2014

2014-02-11 Thread Sebastian Kügler
On Monday, February 10, 2014 16:21:34 Mark Gaiser wrote: On Mon, Feb 10, 2014 at 4:13 PM, Vishesh Handa m...@vhanda.in wrote: On Monday, February 10, 2014 01:54:36 PM Mark Gaiser wrote: Done: http://community.kde.org/GSoC/2014/Ideas#Revive_KioFuse.2C_fuse_support_f or _KIO Lets

Review Request 115650: Add networkmanagement and plasmate to workspace source build for KF5

2014-02-11 Thread Sebastian Kügler
-build Description --- Adds the repos for plasma-nm, libnm-qt and plasmate to kdesrc-build's KF5 workspace definitions. Diffs - kf5-workspace-build-include ca9ba0c Diff: https://git.reviewboard.kde.org/r/115650/diff/ Testing --- Built it, and it built. Thanks, Sebastian

Re: Review Request 115650: Add networkmanagement and plasmate to workspace source build for KF5

2014-02-11 Thread Sebastian Kügler
://git.reviewboard.kde.org/r/115650/diff/ Testing --- Built it, and it built. Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: let's get ready for Google Summer of Code 2014

2014-02-11 Thread Sebastian Kügler
On Tuesday, February 11, 2014 11:03:39 Myriam Schweingruber wrote: On Tue, Feb 11, 2014 at 10:56 AM, Sebastian Kügler se...@kde.org wrote: On Monday, February 10, 2014 16:21:34 Mark Gaiser wrote: On Mon, Feb 10, 2014 at 4:13 PM, Vishesh Handa m...@vhanda.in wrote: No, certainly not. I

Review Request 115682: Add krunner to the workspace build

2014-02-11 Thread Sebastian Kügler
--- Built successfully using kdesrc-build krunner Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115682: Add krunner to the workspace build

2014-02-11 Thread Sebastian Kügler
6b0b638fe6f61e2589ea17c9a83d557efc7bb55d Diff: https://git.reviewboard.kde.org/r/115682/diff/ Testing --- Built successfully using kdesrc-build krunner Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Review Request 115840: Rename Platform to Frameworks in both about dialogs

2014-02-17 Thread Sebastian Kügler
kwrite, new names appear correctly. Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115840: Rename Platform to Frameworks in both about dialogs

2014-02-17 Thread Sebastian Kügler
-004ea7bdb654__aboutdialog.png Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115840: Rename Platform to Frameworks in both about dialogs

2014-02-17 Thread Sebastian Kügler
://git.reviewboard.kde.org/r/115840/#review50091 --- On Feb. 17, 2014, 7:04 p.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 115840: Rename Platform to Frameworks in both about dialogs

2014-02-19 Thread Sebastian Kügler
to a user. Yes to us and the informed developers it's clear, but from a user perspective I think development platform might be the better term to use. In the same way we didn't call it kdelibs there before the switch to frameworks. Sebastian Kügler wrote: Ah, maybe a bit of rationale, I

Re: Review Request 115840: Rename Platform to Frameworks in both about dialogs

2014-02-21 Thread Sebastian Kügler
-004ea7bdb654__aboutdialog.png Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115909: Remove unused dependency from krunner

2014-02-21 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115909/#review50475 --- Ship it! Ship It! - Sebastian Kügler On Feb. 20, 2014, 12

Re: c++ plugins with Frameworks 5

2014-03-04 Thread Sebastian Kügler
On Tuesday, March 04, 2014 09:22:11 David Faure wrote: What I don't know is how much do we need support for queries that filter this further, and whether just reading the json from all the plugins of type foo is good enough. In my tests it was expectedly slow: scaling linearly with number of

Re: Review Request 116696: Fix kservice_desktop_to_json when using cmake 2.8

2014-03-10 Thread Sebastian Kügler
. With this patch, it works. Can we get this in, please? :) - Sebastian Kügler On March 10, 2014, 2 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116696

Re: Review Request 116696: Fix kservice_desktop_to_json when using cmake 2.8

2014-03-10 Thread Sebastian Kügler
On March 10, 2014, 2:59 p.m., Aurélien Gâteau wrote: Strange, it works fine here. Which version of CMake are you using and which repository is failing? Aurélien Gâteau wrote: Oh, version is in the request title. /me tests with 2.8. Aurélien Gâteau wrote: Just tried with

Re: Review Request 116696: Fix kservice_desktop_to_json when using cmake 2.8

2014-03-10 Thread Sebastian Kügler
: cmake version 2.8.12.2 Aurélien Gâteau wrote: You still haven't answered the second part: which repository? Sebastian Kügler wrote: In my case, cmake-git (built with kdesrc-build). Aurélien Gâteau wrote: I meant: which framework fails to build? Aleix Pol Gonzalez wrote

kglobalaccel fixes

2014-03-11 Thread Sebastian Kügler
A quick heads-up: I'm looking into what's broken in our global shortcuts. Here's a quick run-down of my findings so far: kglobalaccel has some brokenness in it. It used to poke into the privates of KGlobalShortcutInfo in order to create its own object in a cast. This code is disabled right now

  1   2   3   4   5   6   7   8   9   >