D11137: overflow-menu as view-more-symbolic, and horizontal

mart created this revision. mart added a reviewer: VDG. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. mart requested review of this revision. REVISION SUMMARY use the 3 dots icons as view-more-symbolic, as traditionally in the

D11137: overflow-menu as view-more-symbolic, and horizontal

mart changed the visibility from "No One" to "Public (No Login Required)". REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D11137 To: mart, #vdg Cc: #frameworks, michaelh

KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.10 - Build # 15 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.10/15/ Project: Frameworks kio kf5-qt5 WindowsMSVCQt5.10 Date of build: Wed, 07 Mar 2018 16:13:52 + Build duration: 2 hr 12 min and counting JUnit Tests

D10747: Implement zwp_linux_dmabuf_v1

romangg added a comment. Please import the context. This makes reviews more easy. Either via -U9 flag to git diff or (for future diffs) by using arc directly on a feature branch. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D10747 To: fredrik, #kwin,

D10494: update handle- icons for kirigami

mart added a comment. As discussed on the channel, the icon should be one of these forms, for me are both ok F5744901: handle-right.png F5744903: handle-left.png REPOSITORY R266 Breeze Icons REVISION

D10747: Implement zwp_linux_dmabuf_v1

fredrik updated this revision to Diff 28986. fredrik added a comment. Import the context. REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10747?vs=27735=28986 REVISION DETAIL https://phabricator.kde.org/D10747 AFFECTED FILES

D11038: balooctl: Add pruneDb option to remove stale file index entries.

smithjd added a comment. In D11038#220486 , @michaelh wrote: > In D11038#219353 , @smithjd wrote: > > > All mounts must be manually made available by the user before running this option, or all

D11038: balooctl: Add pruneDb option to remove stale file index entries.

smithjd updated this revision to Diff 28987. smithjd added a comment. - balooctl: Clarify the prune option description. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11038?vs=28747=28987 BRANCH master-purgeDb (branched from master) REVISION DETAIL

D11038: balooctl: Add prune option to remove stale file index entries

smithjd retitled this revision from "balooctl: Add pruneDb option to remove stale file index entries." to "balooctl: Add prune option to remove stale file index entries". REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11038 To: smithjd, #baloo, #frameworks, michaelh

D11132: Avoid an asan runtime error

jtamate added inline comments. INLINE COMMENTS > apol wrote in kiconeffect.cpp:44 > To what does this initialize the array? effect: 0 value: 0 color: QColor(Invalid) trans: false key: "" color2: QColor(Invalid) REPOSITORY R302 KIconThemes REVISION DETAIL

D11050: Remove frames around media buttons

This revision was automatically updated to reflect the committed changes. Closed by commit R242:812b32fb0559: Remove frames around media buttons (authored by romangg). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11050?vs=28692=28899

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 89 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/89/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Wed, 07 Mar 2018 10:16:56 + Build duration: 13 min and counting JUnit

D11037: balooctl: checkDb should also verify the last known url for the documentId.

michaelh added a reviewer: michaelh. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11037 To: smithjd, #baloo, michaelh Cc: michaelh, #frameworks, ashaposhnikov, spoorun, nicolasfella, alexeymin

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 63 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/63/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 07 Mar 2018 09:34:05 + Build duration: 5 min 20 sec and counting

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 64 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/64/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 07 Mar 2018 10:16:56 + Build duration: 11 min and counting

D11038: balooctl: Add pruneDb option to remove stale file index entries.

michaelh requested changes to this revision. michaelh added a comment. This revision now requires changes to proceed. In D11038#219353 , @smithjd wrote: > All mounts must be manually made available by the user before running this option, or all

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 88 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/88/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Wed, 07 Mar 2018 09:34:06 + Build duration: 10 min and counting JUnit

D10712: balooctl monitor: Resume to wait for service

mwolff requested changes to this revision. mwolff added a comment. This revision now requires changes to proceed. some minor comments, otherwise lgtm INLINE COMMENTS > monitorcommand.cpp:45 > +connect(m_dbusServiceWatcher, ::serviceUnregistered, > [this]() { > +m_err <<

D11112: Hide KUrlNavigatorProtocolCombo if there is just one protocol supported

broulik created this revision. broulik added a reviewer: Frameworks. Restricted Application added a project: Frameworks. broulik requested review of this revision. REVISION SUMMARY There's no point in showing a drop down selection for exactly one protocol. TEST PLAN Follow-up to D1

D11037: balooctl: checkDb should also verify the last known url for the documentId.

michaelh accepted this revision as: michaelh. michaelh added a comment. This revision is now accepted and ready to land. In D11037#219358 , @smithjd wrote: > This change includes orphan file entries as invalid database entries in checkFsTree().

D10712: balooctl monitor: Resume to wait for service

michaelh added a comment. *ping* REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10712 To: michaelh, #baloo, #frameworks, dfaure, alexeymin Cc: ashaposhnikov, michaelh, spoorun, nicolasfella, alexeymin

Phabricator Notification Mails

Hi all, It has been brought to my attention that some find that they are receiving too much mail or other notifications from Phabricator. For those who are unaware there are numerous options available within Phabricator to allow you to control how much it notifies you of changes. To customise

Phabricator Notification Mails

Hi all, It has been brought to my attention that some find that they are receiving too much mail or other notifications from Phabricator. For those who are unaware there are numerous options available within Phabricator to allow you to control how much it notifies you of changes. To customise

D10776: Make it possible to generate po files in parallel

sitter added inline comments. INLINE COMMENTS > build-tsfiles.cmake:75 > ${pmapc_file} > RESULT_VARIABLE code > ) This doesn't belong here, does it? It's also defined in execute_process() and from looking at the docs it would only be set once. REPOSITORY R249

D11107: [KProtocolInfoFactory] Don't clear cache if it had just been built

hein added a comment. Good idea, but every time one of those state tracking bools get copied my mind screams "BAD PATTERN". It's not the fault of your patch but I don't like how this cache handling is written - it'd be cleaner if fillCache had a return value for "I actually did work" and if

D11099: Fix compilation on Android

vkrause added a comment. I also needed API level 21 to make this work, but this changes seemed necessary independent of that, and matches what the above method does for KSDC_TIMEOUTS_SUPPORTED. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D11099 To: vkrause,

D11111: Only show supported schemes in KUrlNavigatorProtocolCombo

broulik created this revision. broulik added a reviewer: Frameworks. Restricted Application added a project: Frameworks. broulik requested review of this revision. TEST PLAN Cleared address bar, clicked the protocol selector. Before I would get all protocols regardless of whether I could

D11049: Remove frame around media action icons

This revision was automatically updated to reflect the committed changes. Closed by commit R266:106b27347125: Remove frame around media action icons (authored by romangg). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D11049?vs=28689=28898#toc REPOSITORY R266 Breeze Icons CHANGES

D11054: Add media status icons

This revision was automatically updated to reflect the committed changes. Closed by commit R266:a8e858933ab9: Add media status icons (authored by romangg). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11054?vs=28704=28900 REVISION DETAIL

D11038: balooctl: Add pruneDb option to remove stale file index entries.

michaelh added a reviewer: michaelh. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11038 To: smithjd, #baloo, #frameworks, michaelh Cc: michaelh, ashaposhnikov, spoorun, nicolasfella, alexeymin

D11125: Add X-KDE-OnlyShowOnQtPlatforms to KCModule servicetype definition

kossebau created this revision. kossebau added reviewers: Plasma, mart. Restricted Application added a project: Frameworks. kossebau requested review of this revision. REVISION SUMMARY KCoreAddons' DesktopFileParser needs a definition of the types of all possible entries to do a proper

D11125: Add X-KDE-OnlyShowOnQtPlatforms to KCModule servicetype definition

kossebau added a comment. And seems there is also code for handling X-KDE-NotShowOnQtPlatforms in `KService::showOnCurrentPlatform()` (but not in kded custom code). lxr.kde.org tells that method is used by - plasma-phone-components/containments/homescreen/applicationlistmodel.cpp ->

D11123: Add X-KDE-OnlyShowOnQtPlatforms to KDEDModule servicetype definition

kossebau created this revision. kossebau added reviewers: Plasma, mart. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. kossebau requested review of this revision. REVISION SUMMARY KCoreAddons' DesktopFileParser needs a definition of

D10712: balooctl monitor: Resume to wait for service

mwolff accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH resume-wait (branched from master) REVISION DETAIL https://phabricator.kde.org/D10712 To: michaelh, #baloo, #frameworks, dfaure, alexeymin, mwolff Cc: mwolff, ashaposhnikov,

D10712: balooctl monitor: Resume to wait for service

This revision was automatically updated to reflect the committed changes. Closed by commit R293:add3284efdca: balooctl monitor: Resume to wait for service (authored by michaelh). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10712?vs=28909=28933 REVISION

D1231: Add Remote Access interface to KWayland

Kanedias added a comment. @graesslin , @davidedmundson , please approve this once again, this was updated numerous times after initial review REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D1231 To: Kanedias, graesslin, davidedmundson, romangg Cc: jgrulich,

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.9 - Build # 8 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.9/8/ Project: Frameworks baloo kf5-qt5 SUSEQt5.9 Date of build: Wed, 07 Mar 2018 13:49:12 + Build duration: 3 min 9 sec and counting JUnit Tests Name:

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.10 - Build # 41 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.10/41/ Project: Frameworks baloo kf5-qt5 SUSEQt5.10 Date of build: Wed, 07 Mar 2018 13:49:12 + Build duration: 5 min 7 sec and counting JUnit Tests Name:

D10712: balooctl monitor: Resume to wait for service

michaelh added inline comments. INLINE COMMENTS > mwolff wrote in monitorcommand.cpp:45 > just make it i18n("Baloo died"), though I personally think that message > should be improved - maybe "Baloo became unavailable" ? > > also, call `balooIsNotAvailable()` from the slot here, that way you

Re: GSOC 2018: KDE Season Website

Hello This is a gentle reminder to kindly look into my request to allow me to work under you in this summer of code. I shall be highly obliged. Thank you On 04-Mar-2018 2:10 AM, "Kanishkar J" wrote: > Hello, > > I am Kanishkar J, I am looking forward to contribute to

D10712: balooctl monitor: Resume to wait for service

michaelh updated this revision to Diff 28909. michaelh marked 8 inline comments as done. michaelh edited the test plan for this revision. michaelh added a comment. - Apply suggested changes REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10712?vs=27678=28909

D11107: [KProtocolInfoFactory] Don't clear cache if it had just been built

broulik added a comment. +1 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11107 To: hein, #frameworks, broulik Cc: michaelh

D11107: [KProtocolInfoFactory] Don't clear cache if it had just been built

hein updated this revision to Diff 28916. hein added a comment. Slightly cleaner approach. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11107?vs=28885=28916 BRANCH master REVISION DETAIL https://phabricator.kde.org/D11107 AFFECTED FILES

D11107: [KProtocolInfoFactory] Don't clear cache if it had just been built

hein commandeered this revision. hein edited reviewers, added: broulik; removed: hein. hein added a comment. Commandeering as agreed upon with Kai, new rev in a moment. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11107 To: hein, #frameworks, broulik Cc: michaelh

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 65 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/65/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 07 Mar 2018 14:54:12 + Build duration: 3 min 12 sec and counting

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 90 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/90/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Wed, 07 Mar 2018 14:54:12 + Build duration: 7 min 18 sec and counting

D11129: Mark kpackage_install_package undeprecated for plasma_install_package

kossebau added a dependent revision: D11130: Disable deprecation warning from kpackage_install_package for now. REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D11129 To: kossebau, mart, apol Cc: #frameworks, michaelh

D11130: Disable deprecation warning from kpackage_install_package for now

kossebau added a dependency: D11129: Mark kpackage_install_package undeprecated for plasma_install_package. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D11130 To: kossebau, mart, apol Cc: #frameworks, michaelh

D11123: Add X-KDE-OnlyShowOnQtPlatforms to KDEDModule servicetype definition

This revision was automatically updated to reflect the committed changes. Closed by commit R297:665c3dd5b248: Add X-KDE-OnlyShowOnQtPlatforms to KDEDModule servicetype definition (authored by kossebau). REPOSITORY R297 KDED CHANGES SINCE LAST UPDATE

D11132: Avoid an asan runtime error

jtamate created this revision. jtamate added a reviewer: Frameworks. Restricted Application added a project: Frameworks. jtamate requested review of this revision. REVISION SUMMARY Initialize the arrays to the maximum size of the enums and use c++11 initialization to ensure that all values are

D11130: Disable deprecation warning from kpackage_install_package for now

kossebau added a project: Plasma. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D11130 To: kossebau, mart, apol Cc: #frameworks, michaelh, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11123: Add X-KDE-OnlyShowOnQtPlatforms to KDEDModule servicetype definition

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R297 KDED BRANCH addmissingdefinitionX-KDE-OnlyShowOnQtPlatforms REVISION DETAIL https://phabricator.kde.org/D11123 To: kossebau, #plasma, mart, apol Cc: #frameworks, michaelh

D11125: Add X-KDE-OnlyShowOnQtPlatforms to KCModule servicetype definition

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R295 KCMUtils BRANCH addmissingdefinitionX-KDE-OnlyShowOnQtPlatforms REVISION DETAIL https://phabricator.kde.org/D11125 To: kossebau, #plasma, mart, apol Cc: #frameworks, michaelh

D11132: Avoid an asan runtime error

anthonyfieroni added inline comments. INLINE COMMENTS > kiconeffect.cpp:44-49 > +effect{{0}} > + ,value{{0.0}} > + ,color{{QColor()}} > + ,trans{{false}} > + ,key{{QString()}} > + ,color2{{QColor()}} You can use {{}} to all REPOSITORY R302 KIconThemes

D11132: Avoid an asan runtime error

jtamate updated this revision to Diff 28946. jtamate added a comment. Cleaner initialization, thanks anthonyfieroni. REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11132?vs=28943=28946 REVISION DETAIL https://phabricator.kde.org/D11132 AFFECTED

D11129: Mark kpackage_install_package undeprecated for plasma_install_package

kossebau created this revision. kossebau added reviewers: mart, apol. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. kossebau requested review of this revision. REVISION SUMMARY While no-one is working on porting plasma_install_package

D11130: Disable deprecation warning from kpackage_install_package for now

kossebau created this revision. kossebau added reviewers: mart, apol. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. kossebau requested review of this revision. REVISION SUMMARY Using a private flag just added for

D11125: Add X-KDE-OnlyShowOnQtPlatforms to KCModule servicetype definition

This revision was automatically updated to reflect the committed changes. Closed by commit R295:0182bc404807: Add X-KDE-OnlyShowOnQtPlatforms to KCModule servicetype definition (authored by kossebau). REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE

Phabricator Notification Mails

Hi all, It has been brought to my attention that some find that they are receiving too much mail or other notifications from Phabricator. For those who are unaware there are numerous options available within Phabricator to allow you to control how much it notifies you of changes. To customise

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 143 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/143/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 07 Mar 2018 16:13:52 + Build duration: 13 min and counting JUnit Tests Name:

D11132: Avoid an asan runtime error

apol added inline comments. INLINE COMMENTS > kiconeffect.cpp:44 > +KIconEffectPrivate(): > +effect{{}} > + ,value{{}} To what does this initialize the array? REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D11132 To: jtamate, #frameworks Cc:

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 14 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/14/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Wed, 07 Mar 2018 16:13:52 + Build duration: 17 min and counting JUnit Tests Name: (root)