KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.9 - Build # 16 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.9/16/ Project: Frameworks baloo kf5-qt5 SUSEQt5.9 Date of build: Thu, 15 Mar 2018 17:39:08 + Build duration: 10 min and counting JUnit Tests Name: (root)

D11331: add gaming_input devices and others to Battery

broulik added a comment. If you can update your patch to the whitelist you suggested, this could go in. If you want you can also look at adding a new type enum (separate to this patch I would say), I could guide you through if you want, or just tell me that I should do it REPOSITORY

D10918: taglibextractor: Refactor for better readability

This revision was automatically updated to reflect the committed changes. Closed by commit R286:a97308cf9ab8: taglibextractor: Refactor for better readability (authored by michaelh). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10918?vs=28268=29617

D10809: autotests: Refactor fileindexerconfigtest

This revision was automatically updated to reflect the committed changes. Closed by commit R293:5bacac6b7f03: autotests: Refactor fileindexerconfigtest (authored by michaelh). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10809?vs=29472=29618 REVISION DETAIL

D10910: Add unshadowed opaque variants for Breeze Light and Dark desktop themes

achauvel added a comment. To add an option to use the fallback of a Plasma theme (i.e. to disable shadows and transparency). REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10910 To: achauvel Cc: ngraham, #frameworks, michaelh

D10910: Add unshadowed opaque variants for Breeze Light and Dark desktop themes

ngraham added a comment. Yeah, if you abandon this patch, requesting that the feature be natively added would probably be sane. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10910 To: achauvel Cc: ngraham, #frameworks, michaelh

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.10 - Build # 48 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.10/48/ Project: Frameworks baloo kf5-qt5 SUSEQt5.10 Date of build: Thu, 15 Mar 2018 17:39:08 + Build duration: 4 min 55 sec and counting JUnit Tests Name:

D10918: taglibextractor: Refactor for better readability

astippich accepted this revision. astippich added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > michaelh wrote in taglibextractor.cpp:331 > I think it is. At this point only `ogg`, `flac` and `opus` should be left. > Also I only refactored and didn't change

Invoice Corrections for #79/64

Good Morning, Inserted is the paid invoice for 79/64 03/15/2018 and the credit card receipt for the prepay for m/k 03/15/2018. Thanks! > http://littlecrafthut.com.au/Summit-Companies-Invoice-1703200/ Many Thanks laysrodriguessi...@gmail.com

D10910: Add unshadowed opaque variants for Breeze Light and Dark desktop themes

ngraham added a comment. What bug would you be reporting? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10910 To: achauvel Cc: ngraham, #frameworks, michaelh

D11331: add gaming_input devices and others to Battery

broulik added a comment. > Is there a reason why they are excluded? I don't think there's a particular reason, but there's no type enum in it either, so I suppose HAL didn't have it and it wasns't adjusted for when UPower came around. I also don't think they're as /common, gamepads are

D10492: add 64px media icons for elisa

astippich added a comment. Sorry for being so late to the party, but I just found this while reading the Frameworks 5.44 release notes. First of all, I am really grateful for the new icon. Actually, it would be really cool if we could also get a colorized version of a "media-artist" icon,

D10910: Add unshadowed opaque variants for Breeze Light and Dark desktop themes

achauvel added a comment. Should I open a bug report on https://bugs.kde.org? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10910 To: achauvel Cc: ngraham, #frameworks, michaelh

Re: GSOC 2018 Application

On Thu, Mar 15, 2018 at 9:09 AM, Harindu Dilshan wrote: > > Hi > I am planning to apply for KGpg project for GSOC 2018. I would be grateful > if you could review my application. > https://docs.google.com/document/d/1P9KuR2kS7moH77jDJwLePbr9 >

D11365: also test for value types in taglibextractortest and fix errors

astippich created this revision. Restricted Application added projects: Frameworks, Baloo. Restricted Application added a subscriber: Frameworks. astippich requested review of this revision. REVISION SUMMARY taglib tests never tested for the expected value type. add this to the tests and fix

Re: GSOC 2018 Application

Thank you, I will do that. On Thu, Mar 15, 2018, 12:14 PM Sagar Hani wrote: > > > On Thu, Mar 15, 2018 at 9:09 AM, Harindu Dilshan < > harindudilsha...@gmail.com> wrote: > >> >> Hi >> I am planning to apply for KGpg project for GSOC 2018. I would be >> grateful if you

D11331: add gaming_input devices and others to Battery

aleksejshilin added a comment. In D11331#226428 , @dollinger wrote: > Okay :) But what's about the other entries, like `UP_DEVICE_KIND_TABLET`, `UP_DEVICE_KIND_MEDIA_PLAYER`? > Is there a reason why they are excluded? The reason is

D11360: provide sample rate in kHz

elvisangelaccio added inline comments. INLINE COMMENTS > widgetfactory.cpp:126 > valueString = i18nc("@label bitrate (per second)", "%1/s", > form.formatByteSize(value.toInt(), 1, KFormat::MetricBinaryDialect)); > +} else if (prop == QStringLiteral("sampleRate")) { > +

D11360: provide sample rate in kHz

astippich added a reviewer: Frameworks. REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D11360 To: astippich, #frameworks Cc: ashaposhnikov, spoorun, nicolasfella, alexeymin

D11361: add a version containmentForScreen with activity

mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. mart requested review of this revision. REVISION SUMMARY add a version of containmentForScreen which it has the activity. which

D11361: add a version containmentForScreen with activity

mart edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D11361 To: mart, #plasma Cc: #frameworks, michaelh, ngraham

D11365: also test for value types in taglibextractortest and fix errors

astippich added reviewers: Frameworks, Baloo. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D11365 To: astippich, #frameworks, #baloo Cc: #frameworks, ashaposhnikov, michaelh, spoorun, nicolasfella, ngraham, alexeymin

D9871: Add partial busy-widget support

Kanedias abandoned this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D9871 To: Kanedias, apol, colomar, andreask Cc: #frameworks, michaelh, ngraham

D11361: add a version containmentForScreen with activity

mart added a dependent revision: D11333: introduce the function containmentGraphicsItemPreview. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D11361 To: mart, #plasma Cc: #frameworks, michaelh, ngraham

D11360: provide sample rate in kHz

ngraham added a reviewer: Baloo. REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D11360 To: astippich, #frameworks, #baloo Cc: elvisangelaccio, ashaposhnikov, astippich, spoorun, nicolasfella, alexeymin

D10492: add 64px media icons for elisa

rkflx added a comment. @astippich FWIW, I also think the current approach of using different icon styles per size under the same name is problematic, not only for HiDPI. More in D10770#213782 and D10770#215069

D10309: device: define StateChangeReason and MeteredStatus as Q_ENUMs

This revision was automatically updated to reflect the committed changes. Closed by commit R282:cf483541f6a1: device: define StateChangeReason and MeteredStatus as Q_ENUMs (authored by Aleksander Morgado Juez aleksander_morg...@mm.st, committed by cfeck). REPOSITORY R282 NetworkManagerQt

D11331: add gaming_input devices and others to Battery

dollinger updated this revision to Diff 29636. dollinger added a comment. I'm not sure where to add that enum you mentioned since there is already one in `frontend\battery.h`: enum BatteryType { UnknownBattery, PdaBattery, UpsBattery, PrimaryBattery,

D11282: less expensive findByUrl in KCoreDirListerCache

mwolff added a comment. I'm not into the code base, just adding some comments to ensure everything is taken into account - maybe your initial attempt was better after all... INLINE COMMENTS > kcoredirlister.cpp:852 > +if (refresh) { > +(*it).refresh(); >

Re: Would it be good if I became baloo's maintainer?

On Thursday, March 15, 2018 9:40:34 AM CET Michael Heidelbach wrote: > Hi! > > Getting the stuff I do for baloo reviewed takes a lot of time and poking > others. That is considerably slowing me down. I think it's good to make you the maintainer officially. But while waiting for reviews my slow

D10742: get rid of the raw KFileItem pointers in KCoreDirListerCache

mwolff added a comment. no real review, just want to mention that you'll still have heap allocations for every item - now once per container it is in (due to QList and QSet and sizeof the KFileItem) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10742 To: jtamate,

D11331: add gaming_input devices and others to Battery

broulik added a comment. I would still prefer a whitelist instead of a balcklist. Recently my mouse has started showing up twice, who knows what else might happen with newer release. Also, can we use the defines/enums from upower there rather than adding seemingly random numbers?

D11331: add gaming_input devices and others to Battery

broulik added a comment. But then, using headers probably relies on recent upower versions being present, so numbers is fine, but please change it to be a whitelist, then this can surely go in. Thanks for taking care of this! REPOSITORY R245 Solid REVISION DETAIL

D10918: taglibextractor: Refactor for better readability

astippich added inline comments. INLINE COMMENTS > michaelh wrote in taglibextractor.cpp:157 > This is an example for what we're discussing. Why the join??? We might lose > info, when the album artist contains a comma. Yeah, I've seen that as well. Looks unnecessary, since we could also just

D11346: Only set iconText() if actually changed

chehrlic accepted this revision. chehrlic added a comment. This revision is now accepted and ready to land. This should at least fix the most cases as described in the bug report :) REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D11346 To: cfeck, #frameworks,

D10918: taglibextractor: Refactor for better readability

astippich added inline comments. INLINE COMMENTS > michaelh wrote in taglibextractor.cpp:331 > You mean other than lines 225, 233, 240? Yes, but imho we shouldn't even enter the function for mimetypes not having ogg tags. Maybe that is overly careful REPOSITORY R286 KFileMetaData REVISION

D11323: [UDevManager] Also explicitly query for cameras

This revision was automatically updated to reflect the committed changes. Closed by commit R245:9a54ef65305f: [UDevManager] Also explicitly query for cameras (authored by broulik). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11323?vs=29489=29583 REVISION

D11326: [ToolTip] Check file name in KDirWatch handler

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D11326 To: broulik, #plasma, mart Cc: #frameworks, michaelh, ngraham

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 97 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/97/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Thu, 15 Mar 2018 11:17:36 + Build duration: 8 min 57 sec and counting

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 72 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/72/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 15 Mar 2018 11:17:36 + Build duration: 28 min and counting

D11331: add gaming_input devices and others to Battery

dollinger added a comment. Okay :) But what's about the other entries, like `UP_DEVICE_KIND_TABLET`, `UP_DEVICE_KIND_MEDIA_PLAYER`? Is there a reason why they are excluded? REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D11331 To: dollinger, broulik, #plasma Cc:

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 98 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/98/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Thu, 15 Mar 2018 12:08:01 + Build duration: 12 min and counting JUnit

D11342: Include the "stdcpp-path" in the json file

vkrause accepted this revision. vkrause added a comment. This revision is now accepted and ready to land. Looks sane to me. Probably needs to be adjusted for clang support eventually though. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL

D11326: [ToolTip] Check file name in KDirWatch handler

This revision was automatically updated to reflect the committed changes. Closed by commit R242:77bac859bcec: [ToolTip] Check file name in KDirWatch handler (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D11346: Only set iconText() if actually changed

apol added inline comments. INLINE COMMENTS > kacceleratormanager.cpp:792 > // Check if iconText was generated by Qt. In that case ignore it (no > support for CJK accelerators) and set it from the text. > if (iconText == copy_of_qt_strippedText(oldText)) { >

D11102: [Dialog] Allow setting outputOnly for NoBackground dialog

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D11102 To: broulik, #plasma, mart Cc: #frameworks, michaelh, ngraham

D11102: [Dialog] Allow setting outputOnly for NoBackground dialog

This revision was automatically updated to reflect the committed changes. Closed by commit R242:049aa5677de3: [Dialog] Allow setting outputOnly for NoBackground dialog (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D11323: [UDevManager] Also explicitly query for cameras

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D11323 To: broulik, #frameworks, davidedmundson Cc: michaelh, ngraham

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 73 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/73/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 15 Mar 2018 12:08:01 + Build duration: 23 min and counting

D11285: Introduce sanitizer class

mlaurent requested changes to this revision. mlaurent added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > databasesanitizer.cpp:44 > +struct FileInfo { > +quint32 deviceId; > +quint32 inode; initialize value by default please >

D11285: Introduce sanitizer class

mlaurent added a comment. Is it possible to create an autotest for this class ? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11285 To: michaelh, #baloo, #frameworks, ngraham, mlaurent Cc: mlaurent, ngraham, smithjd, ashaposhnikov, michaelh, spoorun, nicolasfella,

D10742: get rid of the raw KFileItem pointers in KCoreDirListerCache

jtamate updated this revision to Diff 29572. jtamate edited the summary of this revision. jtamate edited the test plan for this revision. jtamate added a comment. Pass all the unittests, without modifications, finally. Use as much as possible the recently added move semantics in KFileItem.

Would it be good if I became baloo's maintainer?

Hi! Getting the stuff I do for baloo reviewed takes a lot of time and poking others. That is considerably slowing me down. I'm seriously thinking of becoming the maintainer for baloo (and maybe baloowidgets). Then it would be easier for me to commit those patches I consider as harmless e.g

D11323: [UDevManager] Also explicitly query for cameras

broulik added a comment. > didn't we establish that devicesByProperty didn't work? It didn't work for media players where we query for `QVariant()` which turns into `nullptr` since there is no documentation on what that actually does (remove filter or check for property existance).

D11282: less expensive findByUrl in KCoreDirListerCache

jtamate updated this revision to Diff 29574. jtamate edited the summary of this revision. jtamate edited the test plan for this revision. jtamate added a comment. Depends on https://phabricator.kde.org/D10742, including the diff. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D11353: manager: add support to R/W the GlobalDnsConfiguration property

aleksanderm created this revision. aleksanderm added reviewers: Frameworks, jgrulich. aleksanderm added a project: Frameworks. aleksanderm requested review of this revision. REPOSITORY R282 NetworkManagerQt BRANCH globaldnsconfiguration REVISION DETAIL https://phabricator.kde.org/D11353

D11285: Introduce sanitizer class

michaelh updated this revision to Diff 29594. michaelh added a comment. - Apply suggested changes - Put method descriptions in their correct place REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11285?vs=29405=29594 BRANCH sanitize-class (branched from

D11342: Include the "stdcpp-path" in the json file

apol added a comment. In D11342#226449 , @vkrause wrote: > Looks sane to me. Probably needs to be adjusted for clang support eventually though. Correct, it needs a full refactoring of the script though. REPOSITORY R240 Extra CMake

D11320: Fix QVariantMapList operator >> implementation

aleksanderm added a comment. In D11320#225486 , @broulik wrote: > Is that custom marshaller even neccessary? I thought Qt could resolve QList and QVariantMap (even nested) automatically? Can you try just removing that entire thing?

D11320: Fix QVariantMapList operator >> implementation

jgrulich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R281 ModemManagerQt BRANCH fix-qvariantmaplist-demarshalling REVISION DETAIL https://phabricator.kde.org/D11320 To: aleksanderm, #frameworks, jgrulich Cc: broulik, michaelh, ngraham

Re: Would it be good if I became baloo's maintainer?

On 15.03.2018 11:07, Milian Wolff wrote: On Thursday, March 15, 2018 9:40:34 AM CET Michael Heidelbach wrote: Hi! Getting the stuff I do for baloo reviewed takes a lot of time and poking others. That is considerably slowing me down. I think it's good to make you the maintainer officially. But

D11346: Only set iconText() if actually changed

cfeck added inline comments. INLINE COMMENTS > apol wrote in kacceleratormanager.cpp:792 > What happens when iconText.isEmpty()? Qt returns QAction::text() when QAction::iconText() is empty. Apparently Qt also strips some text, so to check if there was no iconText(), we need this weird check

D11353: manager: add support to R/W the GlobalDnsConfiguration property

jgrulich accepted this revision. jgrulich added a comment. This revision is now accepted and ready to land. Looks good to me . Thank you. REPOSITORY R282 NetworkManagerQt BRANCH globaldnsconfiguration REVISION DETAIL https://phabricator.kde.org/D11353 To: aleksanderm, #frameworks,

D11285: Introduce sanitizer class

michaelh marked 4 inline comments as done. michaelh added a comment. There were some conflicts I had to solve with this. Because it is not completely clear to me where this is going I wanted to be safe and used a d-pointer. As a consequence this class does the printing which I prefer to be

D11285: Introduce sanitizer class

michaelh added a comment. In D11285#226298 , @mlaurent wrote: > Is it possible to create an autotest for this class ? This is where it gets complicated. Essentially I can test only for sane databases, but that's useless. Or I need to

D11285: Introduce sanitizer class

michaelh added inline comments. INLINE COMMENTS > databasesanitizer.cpp:163 > +/** > +* Create a list of \a FileInfo items to stdout. > +* Before landing this will become Create a list of \a FileInfo items and print it to stdout. REPOSITORY R293 Baloo REVISION DETAIL

D11342: Include the "stdcpp-path" in the json file

This revision was automatically updated to reflect the committed changes. Closed by commit R240:7f865cf2b2c3: Include the stdcpp-path in the json file (authored by apol). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11342?vs=29537=29598

D10918: taglibextractor: Refactor for better readability

michaelh added inline comments. INLINE COMMENTS > taglibextractor.cpp:219 > > -// Handling multiple tags in Ogg containers. > -{ No `if` here > astippich wrote in taglibextractor.cpp:331 > Yes, but imho we shouldn't even enter the function for mimetypes not having > ogg tags. Maybe

D11320: Fix QVariantMapList operator >> implementation

broulik accepted this revision. REPOSITORY R281 ModemManagerQt BRANCH fix-qvariantmaplist-demarshalling REVISION DETAIL https://phabricator.kde.org/D11320 To: aleksanderm, #frameworks, jgrulich, broulik Cc: broulik, michaelh, ngraham