Re: Review Request 112519: trim KStyle

2013-09-04 Thread Christoph Feck
should not depend on the used style, so if the feature is really needed, it should be proposed upstream. Then you can also kill drawKStylePrimitive(). - Christoph Feck On Sept. 4, 2013, 7:45 p.m., Wojciech Kapuscinski wrote

Re: Review Request 112556: Move itemviews to tier2

2013-09-10 Thread Christoph Feck
On Sept. 10, 2013, 9:06 p.m., David Faure wrote: Ship It! So what about renaming itemmodels/itemviews to kitemmodels/kitemviews, or is it too late for that? Do we plan to have a proper/final let's look at what we did API review after everything has settled? - Christoph

Re: Review Request 112519: trim KStyle

2013-09-17 Thread Christoph Feck
://git.reviewboard.kde.org/r/112519/#comment29713 See above. - Christoph Feck On Sept. 6, 2013, 7:48 p.m., Wojciech Kapuscinski wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r

Re: Review Request 112519: trim KStyle

2013-09-17 Thread Christoph Feck
? Here, I see many red whitespace issues now. - Christoph Feck On Sept. 17, 2013, 1:54 p.m., Wojciech Kapuscinski wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112519

Re: kde-workspace master becomes Qt5-based

2013-10-01 Thread Christoph Feck
On Tuesday 01 October 2013 15:25:27 Sebastian Kügler wrote: On Tuesday, October 01, 2013 15:11:51 Stephen Kelly wrote: We're planning to merge the frameworks-scratch branch of kde-workspace into master next Monday. I tried building the branch. It requires qimageblitz, which I didn't

workspace fails in dateandtime kcm

2013-10-20 Thread Christoph Feck
Hi, I am getting this weird error during make (not make install): /bin/sh: /local/git/KDE/base/kde-workspace- frameworks/kcontrol/dateandtime/kcmclock_actions.actions: Permission denied make[2]: *** [kcontrol/dateandtime/org.kde.kcontrol.kcmclock.policy] Error 126

Re: workspace fails in dateandtime kcm

2013-10-20 Thread Christoph Feck
On Sunday 20 October 2013 12:30:05 Martin Graesslin wrote: On Sunday 20 October 2013 11:44:48 Christoph Feck wrote: Hi, I am getting this weird error during make (not make install): /bin/sh: /local/git/KDE/base/kde-workspace- frameworks/kcontrol/dateandtime/kcmclock_actions.actions

Review Request 113535: Fix build with latest ThreadWeaver

2013-11-01 Thread Christoph Feck
. Diffs - src/plasma/runnermanager.cpp ee4851f Diff: http://git.reviewboard.kde.org/r/113535/diff/ Testing --- Compiles, no further testing. Thanks, Christoph Feck ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Re: Review Request 113535: Fix build with latest ThreadWeaver

2013-11-01 Thread Christoph Feck
, Christoph Feck ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113535: Fix build with latest ThreadWeaver

2013-11-01 Thread Christoph Feck
, Christoph Feck ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 113583: Fix build after enabling C++11 standard

2013-11-02 Thread Christoph Feck
--- The standard says for C++ this is a function, I hope this is not a macro on some compilers... Diffs - khtml/src/xpath/predicate.cpp 3180fe5 Diff: http://git.reviewboard.kde.org/r/113583/diff/ Testing --- Thanks, Christoph Feck

Re: Review Request 113583: Fix build after enabling C++11 standard

2013-11-02 Thread Christoph Feck
for C++11, so it would break on older compilers. Is there a standard way to check if we have a C++11 compiler? - Christoph Feck On Nov. 2, 2013, 3:55 p.m., Christoph Feck wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request 113583: Fix build after enabling C++11 standard

2013-11-02 Thread Christoph Feck
/ Testing --- Thanks, Christoph Feck ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113583: Fix build after enabling C++11 standard

2013-11-02 Thread Christoph Feck
/diff/ Testing --- Thanks, Christoph Feck ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113601: Replace ${GENERIC_LIB_(SO)VERSION} with actual version variables

2013-11-05 Thread Christoph Feck
On Nov. 4, 2013, 4:54 p.m., Commit Hook wrote: This review has been submitted with commit 1e1b33ea862bcbcfdf24a769f36bfcc672bc0f02 by Martin Klapetek to branch frameworks. For whatever reason, it still installs libKPty.so.SOVERSION, instead of libKPty.so.5.0.0. - Christoph

Re: Review Request 113685: New KColorSchemeManager to support changing color scheme in app

2013-11-13 Thread Christoph Feck
On Nov. 12, 2013, 10:49 p.m., Albert Astals Cid wrote: About the .colors translations, we have this ./kdeui/colors/kcolordialog.cpp:104:{ 40.colors, I18N_NOOP2(palette name, Forty Colors) }, ./kdeui/colors/kcolordialog.cpp:105:{ Oxygen.colors, I18N_NOOP2(palette name,

Re: [kdelibs/frameworks] /: Move cmake legacy to KDE4Support

2013-11-13 Thread Christoph Feck
OpenEXR is needed by tier1/kguiaddons/src/plugins/imageformats, it now omits building EXR support. Christoph Feck (kdepepo) KDE Quality Team ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Re: Review Request 113260: Port KTimeZoned to Qt5/KF5

2013-11-13 Thread Christoph Feck
On Nov. 12, 2013, 10:39 a.m., Commit Hook wrote: This review has been submitted with commit 53e8e439af2483c86b21ad4d53ffe4da622e8c44 by Martin Klapetek to branch frameworks. Locally, I get this error: AUTOMOC: error: process for /local/build/kf5/runtime/ktimezoned/ktimezoned.moc

Re: Review Request 113260: Port KTimeZoned to Qt5/KF5

2013-11-15 Thread Christoph Feck
On Nov. 12, 2013, 10:39 a.m., Commit Hook wrote: This review has been submitted with commit 53e8e439af2483c86b21ad4d53ffe4da622e8c44 by Martin Klapetek to branch frameworks. Christoph Feck wrote: Locally, I get this error: AUTOMOC: error: process for /local/build

Re: Dialogs, QPT and Qt5

2013-11-29 Thread Christoph Feck
Qt 5.3 Designer, and those features did not appear. Christoph Feck (kdepepo) ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Tracking bugs in Frameworks

2013-12-16 Thread Christoph Feck
in bugzilla. * If new products/components are created for frameworks, the bug triaging team will help moving the old reports. Christoph Feck (kdepepo) KDE Quality Team openSUSE Review Team ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Re: KDE Frameworks: Moving toward 5.0 final and Governance

2014-01-06 Thread Christoph Feck
: - kiconthemes - kimageformats (including webp plugin from kde-runtime) - kplotting - kwidgetsaddons I may also be interested in kconfigwidgets, kcmutils, kcompletion, and kguiaddons in the future (I don't know the code good enough yet). Christoph Feck (kdepepo

Re: Review Request 115101: add signal KMessageWidget::hideAnimationFinished()

2014-01-18 Thread Christoph Feck
message without waiting for the animation to finish? I somehow feel that the queuing should be done inside KMessageWidget. - Christoph Feck On Jan. 18, 2014, 6:13 p.m., Dominik Haumann wrote: --- This is an automatically generated e-mail

Re: Review Request 115345: Fix kimageformats build with MSVC

2014-01-27 Thread Christoph Feck
://git.reviewboard.kde.org/r/115345/#comment34247 Missing qint16 ? (Question mark, because I am unsure, I did not look at either of the functions) - Christoph Feck On Jan. 27, 2014, 9:38 p.m., Alexander Richardson wrote

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

2014-02-05 Thread Christoph Feck
it. Christoph Feck (kdepepo) ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: HAVE_X11 usage in KIO/core

2014-02-08 Thread Christoph Feck
/4.0; Linux; i686; en_US) KHTML/4.0.1 (like Gecko) will anyone ever care? Had to check if there is a standard that mandates the order or presence of fields, but there is not. +1 for omitting the window system name in the default UA string. Christoph Feck (kdepepo

Re: let's get ready for Google Summer of Code 2014

2014-02-10 Thread Christoph Feck
only add projects where a mentor is willing to take part of GSoC. Looking at persons that are swamped with other work is nice, but that won't help the potential student who is interested in the project just to find out there is no mentor available. Christoph Feck (kdepepo

Re: Review Request 115613: Drop platform name from default user agent string

2014-02-10 Thread Christoph Feck
On Feb. 10, 2014, 7:37 p.m., Dawit Alemayehu wrote: Well the platform name was added for compatibility with what Firefox at the time. And Chromium seems to have adapted that as well. The latest stable version of Firefox (version 27) for example sends the following user agent string

Re: Review Request 115739: Make UDSEntry a Q_MOVABLE type, and add some benchmarks and tests

2014-02-13 Thread Christoph Feck
the items directly in the pointer array. - Christoph Feck On Feb. 13, 2014, 8:23 p.m., Frank Reininghaus wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115739

Re: Review Request 115739: Make UDSEntry a Q_MOVABLE type, and add some benchmarks and tests

2014-02-13 Thread Christoph Feck
On Feb. 13, 2014, 9:31 p.m., Christoph Feck wrote: Making the type movable does not make QList store it directly, how did you check this? http://qt-project.org/doc/qt-5/qlist.html says: Internally, QListT is represented as an array of pointers to items of type T. If T

Re: Review Request 115740: Fix build of KIconThemes on windows

2014-02-13 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115740/#review49758 --- Ship it! Ship It! - Christoph Feck On Feb. 13, 2014, 11

Re: Review Request 115686: Fix mimetype declarations in json files

2014-02-15 Thread Christoph Feck
On Feb. 15, 2014, 5:20 p.m., David Faure wrote: XV is the grand-father of image viewers, I didn't know it had an image format though. It's completely missing from shared-mime-info. I have the very strong feeling that this should be removed, it's completely obsolete :) Can't

Re: KPassivePopup should be in kwidgets ?

2014-02-18 Thread Christoph Feck
. Shouldn't it rather be in kwidgets? KWidgetsAddons? I quickly looked at KPassivePopup. Unfortunately, it has some X11 specific code, which needs to be ported and/or fixed. Otherwise, I agree that it could be moved. /Sune - hoping for a widgets free knotification Christoph Feck (kdepepo

Re: Review Request 115826: Add KMessageBox::setDontShowAskAgainConfig as deprecated method

2014-02-19 Thread Christoph Feck
to use an inline method? - Christoph Feck On Feb. 17, 2014, 10:02 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115826

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

2014-02-22 Thread Christoph Feck
On Feb. 22, 2014, 1:35 p.m., Chusslove Illich wrote: I tried to run a standalone non-GUI program using ki18n: #include QDebug #include KLocalizedString int main (int argc, char *argv[]) { setlocale (LC_ALL, );

Re: Review Request 115982: Add a tool that creates a Mac OS X icns (icon) file from a svg file

2014-02-24 Thread Christoph Feck
://git.reviewboard.kde.org/r/115982/#comment35628 Could you rename those variables? if (!path2.isEmpty() !image.save(path2)) is a bit clearer :) src/tools/ksvg2icns/ksvg2icns.cpp https://git.reviewboard.kde.org/r/115982/#comment35629 Use curly braces, even on single-line if body. - Christoph Feck On Feb

Re: Review Request 115982: Add a tool that creates a Mac OS X icns (icon) file from a svg file

2014-03-02 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115982/#review51721 --- Ship it! Ship It! - Christoph Feck On March 2, 2014, 7:13

Re: Review Request 116567: Implement fuzzy image matching in readtest

2014-03-03 Thread Christoph Feck
load-time. For those operations, an exception could be made, because blending could even be hardware-accelerated. - Christoph Feck On March 3, 2014, 1:04 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request 116603: Expose the QDialogButtonBox in KPasswordDialog

2014-03-04 Thread Christoph Feck
mark it as such. If not, please add some documentation. - Christoph Feck On March 4, 2014, 11:05 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116603

Re: Review Request 116608: KPasswordDialog: Add method to access the buttonBox

2014-03-05 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116608/#review52048 --- Ship it! Thanks, this supersedes 116603. - Christoph Feck

Re: KSpeech

2014-03-06 Thread Christoph Feck
/male/child voice via API (in addition to the ability to let the user reconfigure actual voices). Similar to letting the application request Sans, Sans Serif, and Monospaced font. For example, when generating different voices while reading out e-book stories. Christoph Feck (kdepepo

Re: Review Request 116729: Add a comment explaining the kde4 in the mime type

2014-03-11 Thread Christoph Feck
names (if that's even possible)? - Christoph Feck On March 11, 2014, 5 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116729

Re: Review Request 117004: Remove out-of-date design docs

2014-03-23 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117004/#review53884 --- Ship it! Ship It! - Christoph Feck On March 23, 2014, 5

Re: Review Request 117108: Deprecate KTextEdit clickmessage and use QTextEdit placeholder

2014-03-27 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117108/#review54288 --- Could the stubs be made inline? - Christoph Feck On March

Re: Review Request 117108: Deprecate KTextEdit clickmessage and use QTextEdit placeholder

2014-03-27 Thread Christoph Feck
the functions are used to access a property. src/widgets/ktextedit.cpp https://git.reviewboard.kde.org/r/117108/#comment37983 This variable can be removed. - Christoph Feck On March 27, 2014, 10:08 a.m., Benjamin Port wrote

Re: Review Request 117108: Deprecate KTextEdit clickmessage and use QTextEdit placeholder

2014-03-27 Thread Christoph Feck
/117108/#comment37999 This variable can be removed. - Christoph Feck On March 27, 2014, 1:02 p.m., Benjamin Port wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117108

Re: Review Request 117271: KIconDialog: do not connect to a signal that does not exist

2014-04-01 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117271/#review54745 --- Ship it! Thanks. - Christoph Feck On April 1, 2014, 12:25

Re: Review Request 117277: KDatePicker: override changeEvent() instead of setEnabled()

2014-04-01 Thread Christoph Feck
is going to be enabled? - Christoph Feck On April 1, 2014, 10:35 a.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117277

Re: Review Request 117277: KDatePicker: override changeEvent() instead of setEnabled()

2014-04-01 Thread Christoph Feck
the focus from a previous widget, if activating a disabled widget fails. - Christoph Feck On April 1, 2014, 10:35 a.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r

Re: git repo name in review request e-mail subject

2014-04-30 Thread Christoph Feck
TARGET_PEOPLE in its .reviewboardrc file, then you are mailed directly, while the other review request simply go to the list. Unfortunately, this doesn't always seem to work. Christoph Feck (kdepepo) ___ Kde-frameworks-devel mailing list Kde-frameworks-devel

Review Request 117987: Always return true for alphaBlending()

2014-05-04 Thread Christoph Feck
currently have no KF setup to test. Thanks, Christoph Feck ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117987: Always return true for alphaBlending()

2014-05-08 Thread Christoph Feck
/117987/#review57256 --- On May 4, 2014, 2:01 p.m., Christoph Feck wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117987

Re: Review Request 117987: Always return true for alphaBlending()

2014-05-12 Thread Christoph Feck
/kiconloader.cpp 501367a Diff: https://git.reviewboard.kde.org/r/117987/diff/ Testing --- None, I currently have no KF setup to test. Thanks, Christoph Feck ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman

Re: KConfigXT for QGroupBox?

2014-05-20 Thread Christoph Feck
buttons, and export the selected item ID as the user property from the containing widget (which can be a QGroupBox, but does not need to be). Christoph Feck (kdepepo) ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org

Re: Review Request 118289: Change titlewidget from bold to increased font size

2014-05-26 Thread Christoph Feck
, that the specified font size is not respected, so you either need to clarify in the API docs, or create a method setFontSizeFactor(), which defaults to 1.2, but can be changed back to 1.0. - Christoph Feck On May 26, 2014, 10 a.m., Sebastian Kügler wrote

Re: Review Request 118289: Change titlewidget from bold to increased font size

2014-05-26 Thread Christoph Feck
On May 26, 2014, 10:18 a.m., Christoph Feck wrote: The original screen shot looks bad, because the bold font looks smaller than the normal font. This might be because of wrong hinting settings, or because of a bad font design. Regarding the scaling factor, CSS recommends 1.2

Re: Review Request 118289: Change titlewidget from bold to increased font size

2014-05-27 Thread Christoph Feck
to the VDG. - Christoph Feck On May 27, 2014, midnight, Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118289

Re: Review Request 118415: Fix looking up icons

2014-05-30 Thread Christoph Feck
? - Christoph Feck On May 30, 2014, 8:23 a.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118415

Re: Review Request 118514: Add KColumnResizer to KWidgetsAddons

2014-06-04 Thread Christoph Feck
call addWidgetsFromLayout(). Remains the issue with layouts whose children could change... - Christoph Feck On June 4, 2014, 9:52 a.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 118514: Add KColumnResizer to KWidgetsAddons

2014-06-04 Thread Christoph Feck
/ --- (Updated June 4, 2014, 9:52 a.m.) Review request for KDE Frameworks and Christoph Feck. Repository: kwidgetsaddons Description --- I have been asked to add ColumnResizer to KWidgetAddons. ColumnResizer is a helper class I created long ago to help maintain uniform widths

Re: Review Request 118566: KAcceleratorManager: ignore Designer text fields

2014-06-05 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118566/#review59357 --- Ship it! Ship It! - Christoph Feck On June 5, 2014, 1:54

Re: Review Request 118561: Allow passing custom theme base path together with custom app themes

2014-06-05 Thread Christoph Feck
a separate call. src/kicontheme.h https://git.reviewboard.kde.org/r/118561/#comment41310 The comment does not clarify where the additional hint is included in the search chain (first or last). - Christoph Feck On June 5, 2014, 10:52 a.m., Martin Klapetek wrote

Re: Review Request 118514: Add KColumnResizer to KWidgetsAddons

2014-06-05 Thread Christoph Feck
On June 4, 2014, 11:41 a.m., Dominik Haumann wrote: What about adding something like this to Qt ? Christoph Feck wrote: First, I was thinking the same. The efforts with KF5 work was to get as much features as possible into Qt, and only keep the stuff that isn't accepted in our

Re: Review Request 118561: Allow passing custom theme base path together with custom app themes

2014-06-06 Thread Christoph Feck
all the time. - Christoph Feck On June 6, 2014, 12:02 p.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118561

Review Request 118740: Use standard message box icon size in password dialogs

2014-06-14 Thread Christoph Feck
, Christoph Feck ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118740: Use standard message box icon size in password dialogs

2014-06-17 Thread Christoph Feck
://git.reviewboard.kde.org/r/118740/diff/ Testing --- None, I still do not have a KF5 setup... Thanks, Christoph Feck ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118853: Log name + size of not found icons in debug output

2014-06-21 Thread Christoph Feck
in Qt, and how do we utilize that in our frameworks? If we are still simply using uncategorized qDebug(), please commit it. - Christoph Feck On June 21, 2014, 2:53 a.m., Elias Probst wrote: --- This is an automatically generated e-mail

Re: Review Request 119076: KIconLoader: start by clearing the output variable

2014-07-01 Thread Christoph Feck
, the path of the icon is stored here, *if the icon was found. If the icon was not found @p path_store *is unaltered even if the unknown pixmap was returned. - Christoph Feck On July 1, 2014, 6:57 p.m., David Faure wrote

Re: Allow to add a ActionButton in KPageDialog

2014-07-04 Thread Christoph Feck
even more freedom to customize the dialog. Christoph Feck (kdepepo) ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119126: KMimeTypeChooser: hide Edit button if keditfiletype5 isn't found.

2014-07-05 Thread Christoph Feck
explains why. - Christoph Feck On July 5, 2014, 10:30 a.m., David Faure wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119126

Re: Review Request 119126: KMimeTypeChooser: hide Edit button if keditfiletype5 isn't found.

2014-07-06 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119126/#review61686 --- Ship it! Ship It! - Christoph Feck On July 5, 2014, 10:30

Translations in frameworks released tarballs

2014-07-07 Thread Christoph Feck
:) Is there a way to detect and strip unused strings in the release tarballs? -- Christoph Feck http://kdepepo.wordpress.com/ KDE Quality Team ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks

Re: Translations in frameworks released tarballs

2014-07-08 Thread Christoph Feck
On Tuesday 08 July 2014 07:56:17 Alexander Potashev wrote: 2014-07-08 3:01 GMT+04:00 Christoph Feck christ...@maxiom.de: Is there a way to detect and strip unused strings in the release tarballs? Hi Christoph, Quick googling gives this: http://stackoverflow.com/questions/8149435/how

Re: Review Request 119337: Wait for KMainWindow size restoring before auto saving the size

2014-07-17 Thread Christoph Feck
On July 17, 2014, 1:42 p.m., Martin Gräßlin wrote: would it be possible to add a unit test for it? I know it's not easy as it depends on the window manager, but Openbox which is used on the CI system is quite decent. Martin Klapetek wrote: I may try Please add/close bug 337353.

Re: KIcon API replacement (Re: patches on kcolors)

2012-03-15 Thread Christoph Feck
icon() and Icon() then. ;-) I would prefer uppercase Icon(), because it's not an attribute getter, but a factory method for an object of a specific class. Think KDE::Icon as a class name. Christoph Feck (kdepepo) ___ Kde-frameworks-devel mailing list

Re: Porting the NETWM classes to xcb

2012-03-25 Thread Christoph Feck
/windowmanagement/netwm.h |4 + Is it really required to expose xcb headers to applications, that wish to use the netwm header file? If not, please move to netwm_p.h file. Christoph Feck (kdepepo) KDE Quality Team ___ Kde-frameworks-devel mailing list

Re: API review: KDBusApplicationStarter

2012-05-22 Thread Christoph Feck
, not sure there's really a need for waiting until the app registers to DBus in the KRun case so let's postpone this part. Christoph Feck (kdepepo) KDE Quality Team ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Re: Porting KWidgets to Qt5

2012-06-28 Thread Christoph Feck
(KColorPatch analog), Arora's ModelMenu/ModelToolBar (kde should have some analogs), WindowsMenu (menu with list of top-level windows and actions for minimizing/maximizing.closing of current window). Does anyone have any thoughts about what widgets can be added? Ivan Christoph Feck (kdepepo) KDE

Re: More work available

2012-08-02 Thread Christoph Feck
On Thursday 02 August 2012 17:26:27 David Faure wrote: For the last two weeks, I've been the only committer to kdelibs frameworks (one week working, one week on holidays, i.e. on my free time). It is actually more than two weeks ago that I coined the term DF5 ;) Christoph Feck (kdepepo

Re: Sonnet status?

2012-11-08 Thread Christoph Feck
by aliens. Natural Language Processing is a patent-loaded minefield anyway. Okey, seriously, what exactly do you have in mind for future direction of Sonnet? I am very interested in machine linguistics, but failed so far to have a concrete vision for useful/usable API. Christoph Feck (kdepepo

Re: Sonnet status?

2012-11-08 Thread Christoph Feck
The moment I clicked on Send, I realized this is frameworks list... so you probably were only interested in porting status... On Thursday 08 November 2012 23:16:44 Christoph Feck wrote: On Thursday 08 November 2012 20:24:50 Martin Sandsmark wrote: Anyone know the current status of Sonnet

Re: Build failed in Jenkins: kdelibs_frameworks_qt5 #370

2013-02-09 Thread Christoph Feck
the builds? This would cause higher stacks to fail when changes at a lower place are not compatible (which is good, because we want to fix them). At least that's what my local buildbot does for KDE 4, haven't yet the space to also compile Qt 5 + KF5. Christoph Feck (kdepepo

Re: lib or lib64?

2013-02-15 Thread Christoph Feck
libstreams.so.0 libattica.so.0.4.1 libsearchclient.so libstreams.so.0.7.8 Not answering your question, but shouldn't Qt 5 versions use a different .so number? They aren't binary compatible, after all. Christoph Feck (kdepepo) ___ Kde

Re: CamelCasing our libraries ?

2013-02-26 Thread Christoph Feck
On Tuesday 26 February 2013 21:11:43 Alexander Neundorf wrote: How is kjs CamelCased ? kjs, Kjs, KJs, KJS ? If kjs will be moved to kde4support, we should not bother renaming it. Christoph Feck (kdepepo) ___ Kde-frameworks-devel mailing list Kde

Re: Review Request 110997: Move KPageWidgets and KPageDialog to KWidgets

2013-06-13 Thread Christoph Feck
moved files, but it is impossible to see if there are any changes to them. Is there a way to view those changes, if any? - Christoph Feck On June 13, 2013, 2:57 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail

Re: Main Toolbar/Toolbar in QToolBar

2013-08-13 Thread Christoph Feck
, the Extra Toolbar or Bookmark Toolbar. So they are also children of QMainWindow. Christoph Feck (kdepepo) KDE Quality Team ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: oxygen vs kstyle

2013-08-20 Thread Christoph Feck
On Tuesday 20 August 2013 21:27:52 Hugo Pereira Da Costa wrote: Hi All, There is some traffic on the frameworks list concerning implementing new features in kstyle. It might be useful to mention that the current oxygen code (KDE's default widget style) derives from QCommonStyle and not

kdelibs fails

2013-08-26 Thread Christoph Feck
Hi, I started to test KF5 builds, but it fails with this error. Interestingly, it builds on Jenkins. Any idea? In file included from /local/qt5/include/QtCore/qvariant.h:50:0, from /local/qt5/include/QtCore/qabstractitemmodel.h:45, from

Re: kdelibs fails

2013-08-27 Thread Christoph Feck
On Tuesday 27 August 2013 17:12:08 Stephen Kelly wrote: Christoph Feck wrote: /local/qt5/include/QtCore/qhash.h:857:31: error: within this context while (bucketIterator != it) { ^ A recent commit in qtbase was buggy and introduced this error. Oh dear, and I was sure it was my bug

Re: Review Request 118514: Add KColumnResizer to KWidgetsAddons

2014-08-04 Thread Christoph Feck
/kcolumnresizer.h https://git.reviewboard.kde.org/r/118514/#comment44478 supports - Christoph Feck On June 5, 2014, 12:38 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: KDialog::spacingHint

2014-08-10 Thread Christoph Feck
, because no style and no widget are available here (spacingHint() it is a static function). Please use layoutSpacing() called on the style() of your dialog. Christoph Feck (kdepepo) ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Re: KDialog::spacingHint

2014-08-10 Thread Christoph Feck
On Sunday 10 August 2014 17:03:11 Christoph Feck wrote: On Sunday 10 August 2014 16:04:34 David Narvaez wrote: What's the correct way to port away from KDialog::spacingHint? I read the sources of it in KDELibs 4 and replaced it with QApplication::style()-pixelMetric( QStyle

Re: KPlotting and KUnitConversion

2014-08-10 Thread Christoph Feck
to be a particularly easy to use plotting library designed for C++, so KDE can set the standard here. What is the best way to get involved? First, please clarify why the other alternatives are inadequate. Then propose a plan, or a patch :) Christoph Feck (kdepepo

Re: KPlotting and KUnitConversion

2014-08-11 Thread Christoph Feck
get some additional input for improvements, without bloating it. Thanks for your interest. Christoph Feck (kdepepo) ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 114933: KF5 Port of kdeui/kmessagewidgetdemo

2014-08-12 Thread Christoph Feck
On Aug. 12, 2014, 9:33 a.m., Aleix Pol Gonzalez wrote: After some discussion with the SDK and Book groups in the sprint, I think we should move this into the kde:kwidgetsaddons repository, in an examples subdirectory. Laurent Navet wrote: do you want me to move this from

Re: Review Request 119871: Fix rendering glitches of TabButtons due to inconsistent option-state settings

2014-08-20 Thread Christoph Feck
worse. src/kmultitabbar.cpp https://git.reviewboard.kde.org/r/119871/#comment45367 Remove empty line - Christoph Feck On Aug. 20, 2014, 8:02 p.m., Hugo Pereira Da Costa wrote: --- This is an automatically generated e-mail

Re: Review Request 119879: call style()-drawControl rather than drawItemText to handle button painting in kmultitabbar

2014-08-21 Thread Christoph Feck
that it will look good. You will also rotate lightning/shadows, direction of gradients etc. - Christoph Feck On Aug. 21, 2014, 10:19 a.m., Hugo Pereira Da Costa wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 119867: Fix CustomStyleElement

2014-08-22 Thread Christoph Feck
/119867/#comment45452 You do not need to use { } around the case code, because it does not create a local variable. src/kstyle/kstyle.cpp https://git.reviewboard.kde.org/r/119867/#comment45450 We use if () { with braces, even for single line statements. - Christoph Feck On Aug. 22, 2014

Re: Review Request 120096: replace static arrays with dynamic size with QVector

2014-09-07 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120096/#review66006 --- I would suggest to use QVarLengthArray instead. - Christoph

Re: Removing border and background from KPageView

2014-09-09 Thread Christoph Feck
(!) contents of the list from the background, in other words, they are not at the same (z-axis) layer. Christoph Feck (kdepepo) ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

  1   2   3   4   5   6   7   8   9   10   >