D21831: Move Kruler from 'Graphics' category to 'Utilities'

ngraham commandeered this revision. ngraham edited reviewers, added: kishoreg; removed: ngraham. ngraham added a comment. This revision now requires review to proceed. Just committed this with Albert's suggested change in

D21831: Move Kruler from 'Graphics' category to 'Utilities'

ngraham abandoned this revision. REPOSITORY R375 KRuler REVISION DETAIL https://phabricator.kde.org/D21831 To: ngraham, #kde_applications, cfeck, kishoreg Cc: ltoscano, ngraham, aacid, jriddell, kde-doc-english, elvisangelaccio, dakon, gennad, fbampaloukas, skadinna

D29006: Allow to copy or move selection to the other split view

This revision was automatically updated to reflect the committed changes. Closed by commit R318:a291c5999035: Allow to copy or move selection to the other split view (authored by aprcela, committed by ngraham). REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE

D29006: Allow to copy or move selection to the other split view

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Thank you! REPOSITORY R318 Dolphin BRANCH arcpatch-D29006 REVISION DETAIL https://phabricator.kde.org/D29006 To: aprcela, #dolphin, elvisangelaccio, ngraham, meven, dfaure Cc:

D29006: Allow to copy or move selection to the other split view

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Actually sorry, I have a few more comments before I think this can land: INLINE COMMENTS > dolphintabwidget.h:196 > +/** Moves all selected items to the other view. */ > +

D29006: Allow to copy or move selection to the other split view

ngraham accepted this revision. ngraham added a comment. Thanks! REPOSITORY R318 Dolphin BRANCH arcpatch-D29006 REVISION DETAIL https://phabricator.kde.org/D29006 To: aprcela, #dolphin, elvisangelaccio, ngraham, meven, dfaure Cc: yurchor, kde-doc-english, dfaure, meven, kfm-devel,

D29006: Allow to copy or move selection to the other split view

ngraham added a comment. Nice feature. I would rename the menu items a bit: "Move to inactive split view" "Copy to inactive split view" No need to mention "the selection" because it's implicit. And I would mention that this is about the split view, or else when not using the split

D29220: Update docs for startup page of configuration

ngraham added a comment. Well, D29227 has not landed yet and it still under discussion. Doct will need to be changed for that, but it would be futile to do so now before the proposed UI changes are finalized. REPOSITORY R318 Dolphin REVISION DETAIL

D29220: Update docs for startup page of configuration

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Thanks! Sorry I forgot about this. REPOSITORY R318 Dolphin BRANCH master REVISION DETAIL https://phabricator.kde.org/D29220 To: yurchor, #dolphin, ngraham Cc: ngraham, kfm-devel,

D29220: Update docs for startup page of configuration

ngraham added a comment. Here's the image you requested elsewhere: F8264638: Screenshot_20200427_080843.png REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D29220 To: yurchor, #dolphin Cc: ngraham, kfm-devel, kde-doc-english,

D28652: [Cursors] Remove Resolution Dependant option

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. But please remove the BUG: keywords for bugs that this patch does not actually fix (and ideally fix them in follow-up patches :) ) REPOSITORY R119 Plasma Desktop REVISION DETAIL

D28712: Redo api.kde.org to look more like Aether

ngraham added a comment. Dang that looks way nicer. REPOSITORY R264 KApiDox REVISION DETAIL https://phabricator.kde.org/D28712 To: cblack, #vdg, ognarb, ochurlaud Cc: ngraham, kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, fbampaloukas, GB_2, michaelh, bruns,

D28652: [Cursors] Remove Resolution Dependant option

ngraham added a comment. Yes after restarting the session, the new cursor sized is fully applied everywhere. However 385920 413783 are about applying the cursor size everywhere immediately without having to restart the session, no? REPOSITORY R119 Plasma Desktop REVISION DETAIL

D28652: [Cursors] Remove Resolution Dependant option

ngraham added a comment. After locally fixing the compile error, applying this patch as well as all three others, and restarting KWin, I'm unfortunately seeing the bugs marked as fixed still happening: I change the cursor size, click Apply in the KCM, then the cursor size still changes back

D28652: [Cursors] Remove Resolution Dependant option

ngraham added inline comments. INLINE COMMENTS > ngraham wrote in x11_backend.cpp:145 > Would `size` ever be empty now (not a leading question; I'm genuinely asking) And of course now this fails to build too since you can't call `isEmpty` on an `int` REPOSITORY R119 Plasma Desktop REVISION

D28652: [Cursors] Remove Resolution Dependant option

ngraham added inline comments. INLINE COMMENTS > x11_backend.cpp:145 > } > if (!size.isEmpty()) { > +UpdateLaunchEnvJob launchEnvJob(QStringLiteral("XCURSOR_SIZE"), > QByteArray::number(size)); Would `size` ever be empty now (not a leading question; I'm genuinely asking)

D28652: [Cursors] Remove Resolution Dependant option

ngraham requested changes to this revision. ngraham added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > x11_backend.cpp:138 > } > applyCursorTheme(theme, intSize); > `intSize` is no longer defines so it fails to build REPOSITORY R119 Plasma

D28652: [Cursors] Remove Resolution Dependant option

ngraham added a comment. For them I guess we'll need a kconf update file to migrate them to the new 24 value. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28652 To: bport, #plasma, meven, davidedmundson Cc: ngraham, plasma-devel, kde-doc-english, Orage,

D28652: [Cursors] Remove Resolution Dependant option

ngraham added a task: T12040: "Resolution Dependent" cursor setting: fix it or delete it?. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28652 To: bport, #plasma, meven, davidedmundson Cc: plasma-devel, kde-doc-english, Orage, LeGast00n, The-Feren-OS-Dev,

D27658: Remove the "Candy" category and fold its contents into "Appearance"

This revision was automatically updated to reflect the committed changes. Closed by commit R108:04aff77f9426: Remove the Candy category and fold its contents into Appearance (authored by ngraham). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE

D27658: Remove the "Candy" category and fold its contents into "Appearance"

ngraham created this revision. ngraham added reviewers: KWin, VDG. Herald added projects: KWin, Documentation. Herald added subscribers: kde-doc-english, kwin. ngraham requested review of this revision. REVISION SUMMARY The "Candy" category suffers from some problems: - It does not need to

D15580: New annotation toolbar

ngraham added a comment. See also https://community.kde.org/Infrastructure/GitLab REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D15580 To: simgunz, #okular, #vdg, ngraham Cc: kde-doc-english, andreashurka, yurchor, trickyricky26, simgunz, ltoscano, cfeck, aacid,

D15580: New annotation toolbar

ngraham added a comment. Thanks! REPOSITORY R223 Okular BRANCH new-annotation-toolbar_ToggleActionMenu REVISION DETAIL https://phabricator.kde.org/D15580 To: simgunz, #okular, #vdg, ngraham Cc: kde-doc-english, andreashurka, yurchor, trickyricky26, simgunz, ltoscano, cfeck, aacid,

D15580: New annotation toolbar

ngraham added a comment. Looks like the dependent patch has landed, so we can more forward with this. Still LGTM. REPOSITORY R223 Okular BRANCH new-annotation-toolbar_ToggleActionMenu REVISION DETAIL https://phabricator.kde.org/D15580 To: simgunz, #okular, #vdg, ngraham Cc:

D26197: Display fully qualified class/namespace name as page header

ngraham added a comment. Looks sensible to me too FWIW. REPOSITORY R264 KApiDox REVISION DETAIL https://phabricator.kde.org/D26197 To: davidre Cc: ngraham, aacid, jucato, kde-frameworks-devel, kde-doc-english, LeGast00n, gennad, fbampaloukas, GB_2, michaelh, bruns, skadinna

D25987: Don't overload the word "Properties" to mean multiple things

ngraham added a comment. Good idea, I'll do that next. REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D25987 To: ngraham, #vdg, #dolphin, ndavis, elvisangelaccio Cc: meven, ndavis, kfm-devel, kde-doc-english, pberestov, iasensio, fprice, gennad, MrPepe,

D25987: Don't overload the word "Properties" to mean multiple things

This revision was automatically updated to reflect the committed changes. Closed by commit R318:f62295620884: Dont overload the word Properties to mean multiple things (authored by ngraham). REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25987?vs=71513=71600

D25987: Don't overload the word "Properties" to mean multiple things

ngraham created this revision. ngraham added reviewers: VDG, Dolphin. Herald added projects: Dolphin, Documentation. Herald added subscribers: kde-doc-english, kfm-devel. ngraham requested review of this revision. REVISION SUMMARY Generally "Properties" refers to information about a selected

D23837: Rename action name to make it consistent with other applications

ngraham added a comment. You can land this now, @shubham. REPOSITORY R7 Konversation REVISION DETAIL https://phabricator.kde.org/D23837 To: shubham, hein, ngraham Cc: ltoscano, kde-doc-english, gennad, fbampaloukas, skadinna

D22594: [Dolphin] Open Preferred Search Tool action

ngraham accepted this revision. ngraham added a comment. Okay, that makes sense. REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D22594 To: pdabrowski, #dolphin, ngraham, elvisangelaccio Cc: pkloc, kfm-devel, kde-doc-english, pberestov, iasensio, fprice, gennad,

D22594: [Dolphin] Open Preferred Search Tool action

ngraham added a comment. @elvisangelaccio, all good now? REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D22594 To: pdabrowski, #dolphin, ngraham, elvisangelaccio Cc: pkloc, kfm-devel, kde-doc-english, pberestov, iasensio, fprice, gennad, MrPepe, fbampaloukas,

D22594: [Dolphin] Open Preferred Search Tool action

ngraham added inline comments. INLINE COMMENTS > dolphinmainwindow.cpp:1162 > addActionToMenu(ac->action(QStringLiteral("show_filter_bar")), menu); > + > addActionToMenu(ac->action(QStringLiteral("open_preferred_search_tool")), > menu); >

D25229: Update docs to the new annotation toolbar

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R223 Okular BRANCH master REVISION DETAIL https://phabricator.kde.org/D25229 To: yurchor, #okular, ngraham Cc: ngraham, okular-devel, kde-doc-english, johnzh, andisa, siddharthmanthan, maguirre,

D25229: Update docs to the new annotation toolbar

ngraham edited the summary of this revision. ngraham added a dependency: D15580: New annotation toolbar. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D25229 To: yurchor, #okular Cc: ngraham, okular-devel, kde-doc-english, johnzh, andisa, siddharthmanthan, maguirre,

D15580: New annotation toolbar

ngraham added a dependent revision: D25229: Update docs to the new annotation toolbar. REPOSITORY R223 Okular BRANCH new-annotation-toolbar_ToggleActionMenu REVISION DETAIL https://phabricator.kde.org/D15580 To: simgunz, #okular, #vdg, ngraham Cc: kde-doc-english, andreashurka, yurchor,

D25229: Update docs to the new annotation toolbar

ngraham added a comment. Wow, this must have been a huge amount of work. Very nice. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D25229 To: yurchor, #okular Cc: ngraham, okular-devel, kde-doc-english, johnzh, andisa, siddharthmanthan, maguirre, gennad,

D15580: New annotation toolbar

ngraham added a comment. Still looks great to me in testing. REPOSITORY R223 Okular BRANCH new-annotation-toolbar_ToggleActionMenu REVISION DETAIL https://phabricator.kde.org/D15580 To: simgunz, #okular, #vdg, ngraham Cc: kde-doc-english, andreashurka, yurchor, trickyricky26,

D23415: Improve comprehensibility and consistency of window placement mode names

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit R108:2dae153558b3: Improve comprehensibility and consistency of window placement mode names (authored by ngraham).

D23415: Improve comprehensibility and consistency of window placement mode names

ngraham added a comment. Just talked to David and he says it's not necessary. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D23415 To: ngraham, #kwin, #vdg, ndavis, filipf, zzag Cc: gladhorn, alexeymin, IlyaBizyaev, broulik, hein, hpereiradacosta, GB_2, alexde,

D23415: Improve comprehensibility and consistency of window placement mode names

ngraham added a comment. Plasma 5.17 has now branched, so we can now move forward with @romangg's plan and target this for Plasma 5.18. @davidedmundson, can I get the final word on whether or not we should rename the enums in this patch? Yea/nay? REPOSITORY R108 KWin REVISION DETAIL

D23415: Improve comprehensibility and consistency of window placement mode names

ngraham added a comment. The fact that multiple longtime KDE developers didn't know what the "Smart" placement mode did until they read the proposed new string in this patch is probably a better argument for it than I could ever make. :) I woudn't mind getting this in for 5.17 of course,

D22894: Rename "Desktop Effects" to "Graphical Effects"

ngraham abandoned this revision. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D22894 To: ngraham, #vdg, #kwin, GB_2, zzag Cc: zzag, GB_2, kwin, kde-doc-english, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, gennad, fbampaloukas, mkulinski, ragreen, jackyalcine,

D23415: Improve comprehensibility and consistency of window placement mode names

ngraham updated this revision to Diff 66007. ngraham added a comment. Better rebase REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23415?vs=66006=66007 BRANCH better-window-placement-text (branched from master) REVISION DETAIL

D23415: Improve comprehensibility and consistency of window placement mode names

ngraham updated this revision to Diff 66006. ngraham added a comment. Rebase REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23415?vs=64610=66006 BRANCH better-window-placement-text (branched from master) REVISION DETAIL

D23837: Rename action name to make it consistent with other applications

ngraham added a comment. In D23837#529369 , @shubham wrote: > Sorry for inconvenience caused, I thought blocking reviewer means that person can not review any longer Heh, no' it's the opposite. :) It means, "Do not land this patch

D23837: Rename action name to make it consistent with other applications

ngraham added 1 blocking reviewer(s): hein. ngraham accepted this revision. REPOSITORY R7 Konversation REVISION DETAIL https://phabricator.kde.org/D23837 To: shubham, hein, ngraham Cc: kde-doc-english, gennad, fbampaloukas, skadinna

D22444: Add Reset Zoom Level action inside View menu

This revision was automatically updated to reflect the committed changes. Closed by commit R318:7165ea7afdf1: Add Reset Zoom Level action inside View menu (authored by ngraham). REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22444?vs=65468=65746 REVISION

D22444: Add Reset Zoom Level action inside View menu

ngraham updated this revision to Diff 65468. ngraham added a comment. Fix it for realsies REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22444?vs=65465=65468 BRANCH arcpatch-D22444 REVISION DETAIL https://phabricator.kde.org/D22444 AFFECTED FILES

D22444: Add Reset Zoom Level action inside View menu

ngraham updated this revision to Diff 65465. ngraham added a comment. Fix action not getting added to menu REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22444?vs=65136=65465 BRANCH arcpatch-D22444 REVISION DETAIL https://phabricator.kde.org/D22444

D22444: Add Reset Zoom Level action inside View menu

ngraham updated this revision to Diff 65136. ngraham added a comment. Rebase REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22444?vs=64868=65136 BRANCH arcpatch-D22444 REVISION DETAIL https://phabricator.kde.org/D22444 AFFECTED FILES

D22444: Add Reset Zoom Level action inside View menu

ngraham added a comment. That's strange, it worked before (see the screenshot), but not I don't see it there either. :/ Will investigate and fix. REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D22444 To: ngraham, elvisangelaccio, shubham, #dolphin Cc: broulik,

D23415: Improve comprehensibility and consistency of window placement mode names

ngraham added a comment. In fact, the HIG already says that: > https://hig.kde.org/style/writing/labels.html#guidelines > Don’t shorten your labels to the point of losing meaning. A three-word label that provides clear information is better than a one-word label that is ambiguous or

D22616: Remove phonon KCM

ngraham added a task: T9091: Merge PulseAudio and Phonon KCM. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D22616 To: nicolasfella, sitter Cc: ngraham, kde-doc-english, pino, plasma-devel, sitter, LeGast00n, The-Feren-OS-Dev, jraleigh, gennad, fbampaloukas,

D22444: Add Reset Zoom Level action inside View menu

ngraham marked 3 inline comments as done. REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D22444 To: ngraham, elvisangelaccio, shubham, #dolphin Cc: broulik, cfeck, kfm-devel, kde-doc-english, aprcela, vmarinescu, fprice, gennad, MrPepe, fbampaloukas, alexde, Codezela,

D22444: Add Reset Zoom Level action inside View menu

ngraham updated this revision to Diff 64868. ngraham added a comment. - Rebase - Address review comments REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22444?vs=63767=64868 BRANCH arcpatch-D22444 REVISION DETAIL https://phabricator.kde.org/D22444

D22444: Add Reset Zoom Level action inside View menu

ngraham added a comment. @elvisangelaccio Ping. REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D22444 To: ngraham, elvisangelaccio, shubham, #dolphin Cc: cfeck, kfm-devel, kde-doc-english, aprcela, vmarinescu, fprice, gennad, MrPepe, fbampaloukas, alexde, Codezela,

D23415: Improve comprehensibility and consistency of window placement mode names

ngraham added a comment. In D23415#521038 , @zzag wrote: > My problem is that VDG goes way overboard with user-visible strings. For example, we didn't receive any complaints about "Desktop Effects" string. Linux community settled on using that

D23415: Improve comprehensibility and consistency of window placement mode names

ngraham added a comment. In D23415#520256 , @davidedmundson wrote: > >And "Smart" is a bad name because unlike all the other window placement modes, it is a generic meaningless term whose name does not explain or hint at what it will do >

D23415: Improve comprehensibility and consistency of window placement mode names

ngraham added a comment. In D23415#519911 , @zzag wrote: > > Also I don't think renaming the enums is a good idea: > > > > - If the point is to retain naming consistency throughout the codebase, then we'd need to update the strings written

D23415: Improve comprehensibility and consistency of window placement mode names

ngraham added a comment. "In Top-Left Screen Corner?" "Northwest" seems like kind of a funny term to use for screen geometry. REPOSITORY R108 KWin BRANCH better-window-placement-text (branched from master) REVISION DETAIL https://phabricator.kde.org/D23415 To: ngraham, #kwin,

D23415: Improve comprehensibility and consistency of window placement mode names

ngraham added a comment. I've standardized on the descriptive mood now. But I have not reverted back to "Smart" because it's simply a bad name, and it doesn't make sense to keep it. It doesn't matter what the feature is called internally, and how long it's had that name is irrelevant if

D23415: Improve comprehensibility and consistency of window placement mode names

ngraham edited the test plan for this revision. REPOSITORY R108 KWin BRANCH better-window-placement-text (branched from master) REVISION DETAIL https://phabricator.kde.org/D23415 To: ngraham, #kwin, #vdg, ndavis Cc: zzag, ndavis, kwin, kde-doc-english, LeGast00n, The-Feren-OS-Dev,

D23415: Improve comprehensibility and consistency of window placement mode names

ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R108 KWin BRANCH better-window-placement-text (branched from master) REVISION DETAIL https://phabricator.kde.org/D23415 To: ngraham, #kwin, #vdg, ndavis Cc: zzag, ndavis, kwin,

D23415: Improve comprehensibility and consistency of window placement mode names

ngraham updated this revision to Diff 64610. ngraham added a comment. Update strings again REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23415?vs=64526=64610 BRANCH better-window-placement-text (branched from master) REVISION DETAIL

D23415: Improve comprehensibility and consistency of window placement mode names

ngraham added a comment. "Smart" is meaningless and must be replaced. "Zero-cornered" is technobabble comprehensible only to KWin developers and must be replaced. Others are judgment calls, but you're right that the moods are inconsistent (e.g. "centered" is descriptive and

D23415: Improve comprehensibility and consistency of window placement mode names

ngraham marked an inline comment as done. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D23415 To: ngraham, #kwin, #vdg Cc: ndavis, kwin, kde-doc-english, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, gennad, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine,

D23415: Improve comprehensibility and consistency of window placement mode names

ngraham updated this revision to Diff 64526. ngraham added a comment. Use Title Case Where Appropriate REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23415?vs=64525=64526 BRANCH better-window-placement-text (branched from master) REVISION DETAIL

D23415: Improve comprehensibility and consistency of window placement mode names

ngraham created this revision. ngraham added reviewers: KWin, VDG. Herald added projects: KWin, Documentation. Herald added subscribers: kde-doc-english, kwin. ngraham requested review of this revision. REVISION SUMMARY Right now a few of the window placement modes suffer one or more of the

D22444: Add Reset Zoom Level action inside View menu

ngraham added a comment. OK, it's ready again now. :) REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D22444 To: ngraham, elvisangelaccio, shubham, #dolphin Cc: cfeck, kfm-devel, kde-doc-english, aprcela, vmarinescu, fprice, gennad, MrPepe, fbampaloukas, alexde,

D22444: Add Reset Zoom Level action inside View menu

ngraham updated this revision to Diff 63767. ngraham added a comment. Clean up remaining whitespace issues REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22444?vs=63766=63767 BRANCH arcpatch-D22444 REVISION DETAIL https://phabricator.kde.org/D22444

D22444: Add Reset Zoom Level action inside View menu

ngraham updated this revision to Diff 63766. ngraham added a comment. Rebase REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22444?vs=63765=63766 BRANCH arcpatch-D22444 REVISION DETAIL https://phabricator.kde.org/D22444 AFFECTED FILES

D22444: Add Reset Zoom Level action inside View menu

ngraham updated this revision to Diff 63765. ngraham added a comment. Undo unnecessary CMake changes REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22444?vs=63764=63765 BRANCH arcpatch-D22444 REVISION DETAIL https://phabricator.kde.org/D22444

D22444: Add Reset Zoom Level action inside View menu

ngraham updated this revision to Diff 63764. ngraham marked 3 inline comments as done and 2 inline comments as done. ngraham added a comment. Use a more typical approach REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22444?vs=62548=63764 BRANCH

D22594: [Dolphin] Open Preferred Search Tool action

ngraham added a comment. @elvisangaleccio? REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D22594 To: pdabrowski, #dolphin, ngraham, elvisangelaccio Cc: pkloc, kfm-devel, kde-doc-english, aprcela, vmarinescu, fprice, gennad, fbampaloukas, alexde, feverfew, meven,

D22894: Rename "Desktop Effects" to "Graphical Effects"

ngraham added a comment. In D22894#509781 , @GB_2 wrote: > What about just "Effects"? I'd be okay with that. REPOSITORY R108 KWin BRANCH desktop-to-graphical (branched from master) REVISION DETAIL

D22894: Rename "Desktop Effects" to "Graphical Effects"

ngraham added a comment. Ah. My claim is that when your typical user sees the word "desktop", they don't think of the generic concept of the desktop metaphor (which is a developer concept). They think of the specific thing with the wallpaper where they put their files and folders. With

D22894: Rename "Desktop Effects" to "Graphical Effects"

ngraham added a comment. In D22894#506688 , @zzag wrote: > > - Inappropriate use of the word "Desktop." In the typical user's understanding, the desktop is the thing with a wallpaper and icons on it. > > "Desktop" is a metaphor. "Desktop

D22894: Rename "Desktop Effects" to "Graphical Effects"

ngraham added a comment. In general I don't think it's a valid argument that you should leave something alone just because people are used to it. If it's already good, then that's the reason not to change it. But if people have gotten used to something bad, then changing it is definitely

D22880: Rename "Plasma Theme" to "Plasma Style"

ngraham marked an inline comment as done. ngraham added inline comments. INLINE COMMENTS > GB_2 wrote in kcm_desktoptheme.desktop:41 > You forgot to change the name here too. Oops, sorry! Fixed in 2bedabd96d37c48a67a80dcc48f3368b1e9713ef

D22880: Rename "Plasma Theme" to "Plasma Style"

This revision was automatically updated to reflect the committed changes. Closed by commit R119:5b7a43d2ad8d: Rename Plasma Theme to Plasma Style (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22880?vs=62927=62999 REVISION

D22894: Rename "Desktop Effects" to "Graphical Effects"

ngraham added a comment. Yep. REPOSITORY R108 KWin BRANCH desktop-to-graphical (branched from master) REVISION DETAIL https://phabricator.kde.org/D22894 To: ngraham, #vdg, #kwin, GB_2 Cc: GB_2, kwin, kde-doc-english, LeGast00n, fmonteiro, sbergeron, jraleigh, gennad, fbampaloukas,

D22894: Rename "Desktop Effects" to "Graphical Effects"

ngraham created this revision. ngraham added reviewers: VDG, KWin. Herald added projects: KWin, Documentation. Herald added subscribers: kde-doc-english, kwin. ngraham requested review of this revision. REVISION SUMMARY KWin's Desktop Effects suffer from the following UI issues: -

D22444: Add Reset Zoom Level action inside View menu

ngraham added a comment. @elvisangelaccio ping. REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D22444 To: ngraham, elvisangelaccio, shubham, #dolphin Cc: cfeck, kfm-devel, kde-doc-english, aprcela, vmarinescu, fprice, gennad, fbampaloukas, alexde, feverfew, meven,

D22871: Use better Workspace Behavior KCM title and icon

ngraham added a task: T11316: Systematic KCM reorganisation: Workspace section. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D22871 To: GB_2, #plasma, #vdg, filipf, ngraham Cc: filipf, kde-doc-english, ngraham, #vdg, plasma-devel, #plasma, LeGast00n, jraleigh,

D22871: Use better Workspace Behavior KCM title and icon

ngraham accepted this revision. ngraham added a comment. Ah right. Okay, this is fine then. REPOSITORY R119 Plasma Desktop BRANCH use-better-global-workspace-behavior-kcm-title-and-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D22871 To: GB_2, #plasma, #vdg,

D22871: Use better Workspace Behavior KCM title and icon

ngraham added a comment. If we're going to make it "General", do we even need the word "Behavior" in there? It's implied by its category, no? I suppose there would be no visible parent category when running in kcmshell, but that doesn't seem like the hugest problem to me. REPOSITORY R119

D22880: Rename "Plasma Theme" to "Plasma Style"

ngraham added a subscriber: leinir. ngraham added inline comments. INLINE COMMENTS > plasma-themes.knsrc:42 > ProvidersUrl=https://download.kde.org/ocs/providers.xml > Categories=Plasma Theme > StandardResource=tmp > The KDE Store category name should probably be updated too. You mean here?

D22594: [Dolphin] Open Preferred Search Tool action

ngraham accepted this revision. REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D22594 To: pdabrowski, #dolphin, ngraham, elvisangelaccio Cc: pkloc, kfm-devel, kde-doc-english, aprcela, vmarinescu, fprice, gennad, fbampaloukas, alexde, feverfew, meven, spoorun,

D22880: Rename "Plasma Theme" to "Plasma Style"

ngraham edited the summary of this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D22880 To: ngraham, #vdg, #plasma Cc: plasma-devel, kde-doc-english, LeGast00n, jraleigh, gennad, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, skadinna, himcesjf,

D22880: Rename "Plasma Theme" to "Plasma Style"

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added projects: Plasma, Documentation. Herald added subscribers: kde-doc-english, plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This implements one of the changes decided upon in T11314

D21196: [RFC] Move Continuous option to View Mode submenu

ngraham added a comment. The new icons will land in KDE Frameworks 5.61. If you request icons that don't exist, nothing bad happens, they just don't get displayed. So you should be able to add your `setIcon()` calls anyway, and users with frameworks 5.61 will get them, and everyone else

D22444: Add Reset Zoom Level action inside View menu

ngraham added a comment. You're not blind, but that's how keyboard shortcuts look in KDE software. F7096840: Screenshot_20190725_114012.png REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D22444 To: ngraham,

D22444: Add Reset Zoom Level action inside View menu

ngraham added a comment. In D22444#502241 , @shubham wrote: > Shouldn't the zoom out shortcut be ctrl-- or is it already occupied? Um, it already is. :) The screenshot even shows it. :) REPOSITORY R318 Dolphin REVISION DETAIL

D22444: Add Reset Zoom Level action inside View menu

ngraham added a comment. The HIG is silent on the matter, but Okular and Konsole put the reset action in the middle, so I think it makes sense to do the same here. REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D22444 To: ngraham, elvisangelaccio, shubham, #dolphin

D22444: Add Reset Zoom Level action inside View menu

ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D22444 To: ngraham, elvisangelaccio, shubham, #dolphin Cc: kfm-devel, kde-doc-english, aprcela, fprice, gennad, fbampaloukas,

D22444: Add Reset Zoom Level action inside View menu

ngraham added a comment. @elvisangelaccio This is now ready for review. REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D22444 To: ngraham, elvisangelaccio, shubham, #dolphin Cc: kfm-devel, kde-doc-english, aprcela, fprice, gennad, fbampaloukas, alexde, feverfew,

D22444: Add Reset Zoom Level action inside View menu

ngraham added a reviewer: Dolphin. ngraham marked 2 inline comments as done. REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D22444 To: ngraham, elvisangelaccio, shubham, #dolphin Cc: kfm-devel, kde-doc-english, aprcela, fprice, gennad, fbampaloukas, alexde, feverfew,

D22444: Add Reset Zoom Level action inside View menu

ngraham commandeered this revision. ngraham edited reviewers, added: shubham; removed: ngraham. ngraham added a comment. Sure, I'd be happy to. REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D22444 To: ngraham, elvisangelaccio, shubham Cc: kfm-devel,

D22669: Tweak tab title options: home and Bourne prompt sigils

ngraham added a comment. Thanks, you did it perfectly! REPOSITORY R319 Konsole REVISION DETAIL https://phabricator.kde.org/D22669 To: rrosch, #konsole Cc: ngraham, konsole-devel, kde-doc-english, gennad, fbampaloukas, thsurrel, skadinna, maximilianocuria, hindenburg

D22444: Add Reset Zoom Level action inside View menu

ngraham added a comment. @shubham are you able to make those changes? REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D22444 To: shubham, ngraham, elvisangelaccio Cc: kfm-devel, kde-doc-english, aprcela, fprice, gennad, fbampaloukas, alexde, feverfew, meven,

  1   2   3   >