D19770: Use placeholder for search action

ngraham added a comment. JFYI it's generally considered polite to wait until all reviewers with an outstanding "Changes Requested" status to change it to "Accepted" before committing. :) REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D19770 To: ognarb, #dolphin,

D19770: Use placeholder for search action

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R318:8dc5c7a199ae: Use placeholder for search action (authored by ognarb). REPOSITORY R318 Dolphin CHANGES SINCE LAST

D19770: Use placeholder for search action

ngraham accepted this revision. REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D19770 To: ognarb, #dolphin, #vdg, ngraham, elvisangelaccio Cc: GB_2, kde-doc-english, elvisangelaccio, ngraham, yurchor, kfm-devel, gennad, alexde, feverfew, meven, spoorun, navarromorales,

D19770: Use placeholder for search action

ognarb updated this revision to Diff 56766. ognarb marked 2 inline comments as done. ognarb added a comment. Rebase and rename search variable to searchAction. Still compile and run fine REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19770?vs=54153=56766

D19770: Use placeholder for search action

elvisangelaccio added a comment. In D19770#453747 , @ngraham wrote: > In D19770#453371 , @elvisangelaccio wrote: > > > I still think that the rename from "Search" to "Find" should be done either

D19770: Use placeholder for search action

ngraham added a comment. In D19770#453371 , @elvisangelaccio wrote: > I still think that the rename from "Search" to "Find" should be done either upstream/globally or not at all. > > Anyway, it's unrelated from this commit, which is just

D19770: Use placeholder for search action

elvisangelaccio requested changes to this revision. elvisangelaccio added a comment. This revision now requires changes to proceed. I still think that the rename from "Search" to "Find" should be done either upstream/globally or not at all. Anyway, it's unrelated from this commit, which

D19770: Use placeholder for search action

ngraham accepted this revision. ngraham added a comment. Still LGTM. @elvisangelaccio? REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D19770 To: ognarb, #dolphin, #vdg, ngraham, elvisangelaccio Cc: GB_2, kde-doc-english, elvisangelaccio, ngraham, yurchor, kfm-devel,

D19770: Use placeholder for search action

GB_2 added a comment. Ping @elvisangelaccio REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D19770 To: ognarb, #dolphin, #vdg, ngraham, elvisangelaccio Cc: GB_2, kde-doc-english, elvisangelaccio, ngraham, yurchor, kfm-devel, gennad, alexde, feverfew, meven, spoorun,

D19770: Use placeholder for search action

ngraham accepted this revision as: VDG, ngraham. ngraham added a comment. Thanks. :) Let's wait for @elvisangelaccio now. REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D19770 To: ognarb, #dolphin, #vdg, ngraham, elvisangelaccio Cc: kde-doc-english,

D19770: Use placeholder for search action

ognarb updated this revision to Diff 54153. ognarb edited the summary of this revision. ognarb added a comment. Now compile. Sorry :/ REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19770?vs=54128=54153 BRANCH master REVISION DETAIL

D19770: Use placeholder for search action

ngraham added a comment. Now Dolphin doesn't compile: /home/nate/kde/src/dolphin/src/dolphinmainwindow.cpp: In member function ‘void DolphinMainWindow::setupActions()’: /home/nate/kde/src/dolphin/src/dolphinmainwindow.cpp:1145:5: error: invalid use of member function ‘void

D19770: Use placeholder for search action

ognarb marked 2 inline comments as done. REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D19770 To: ognarb, #dolphin, #vdg, ngraham, elvisangelaccio Cc: kde-doc-english, elvisangelaccio, ngraham, yurchor, kfm-devel, gennad, alexde, feverfew, spoorun, navarromorales,

D19770: Use placeholder for search action

ognarb edited the summary of this revision. REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D19770 To: ognarb, #dolphin, #vdg, ngraham, elvisangelaccio Cc: kde-doc-english, elvisangelaccio, ngraham, yurchor, kfm-devel, gennad, alexde, feverfew, spoorun, navarromorales,

D19770: Use placeholder for search action

ognarb edited the summary of this revision. REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D19770 To: ognarb, #dolphin, #vdg, ngraham, elvisangelaccio Cc: kde-doc-english, elvisangelaccio, ngraham, yurchor, kfm-devel, gennad, alexde, feverfew, spoorun, navarromorales,

D19770: Use placeholder for search action

ognarb updated this revision to Diff 54128. ognarb added a comment. Use better variable name REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19770?vs=54127=54128 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19770 AFFECTED FILES

D19770: Use placeholder for search action

ognarb updated this revision to Diff 54127. ognarb added a comment. - Use 3 dots instead of unicode - Apply same change to filter bar - This time change Find to Search correctly REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19770?vs=54086=54127

D19770: Use placeholder for search action

ngraham added a comment. Hmm, the menu and toolbar items still say "Find..." INLINE COMMENTS > yurchor wrote in dolphinsearchbox.cpp:362 > Should it be "Search..." or even "Search…" (GNOME has already switched to the > Unicode ellipsis)? > > Thanks in advance for your answer. I think we

D19770: Use placeholder for search action

ognarb marked an inline comment as done. REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D19770 To: ognarb, #dolphin, #vdg, ngraham, elvisangelaccio Cc: kde-doc-english, elvisangelaccio, ngraham, yurchor, kfm-devel, gennad, alexde, feverfew, spoorun, navarromorales,

D19770: Use placeholder for search action

ognarb updated this revision to Diff 54086. ognarb added a comment. Herald added a project: Documentation. Herald added a subscriber: kde-doc-english. - Translate Search - Update doc REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19770?vs=53920=54086