D22594: [Dolphin] Open Preferred Search Tool action

firef added a comment. In D22594#498890 , @ngraham wrote: > As for the feature itself, for the past few years I'd been opposed to this, on the basis that people should just use the built-in Baloo-based search instead. But unfortunately the

D22594: [Dolphin] Open Preferred Search Tool action

pdabrowski added inline comments. INLINE COMMENTS > broulik wrote in dolphinmainwindow.cpp:2289 > > It is still impossible to detect (un)installation of such tool. > > There's signals when the KSycoca service database changes which we use in the > application menu to update when apps are

D22594: [Dolphin] Open Preferred Search Tool action

elvisangelaccio added inline comments. INLINE COMMENTS > broulik wrote in dolphinmainwindow.cpp:2289 > > It is still impossible to detect (un)installation of such tool. > > There's signals when the KSycoca service database changes which we use in the > application menu to update when apps are

D22594: [Dolphin] Open Preferred Search Tool action

broulik added inline comments. INLINE COMMENTS > pdabrowski wrote in dolphinmainwindow.cpp:2289 > It is still impossible to detect (un)installation of such tool. > "More Search Tools" menu currently recreates the menu from > KMoreToolsMenuFactory when it is shown. > It is still impossible to

D22594: [Dolphin] Open Preferred Search Tool action

pdabrowski added inline comments. INLINE COMMENTS > broulik wrote in dolphinmainwindow.cpp:2289 > > (can be modified with More Search Tools -> More -> Configure) > > Then there should be a signal in `KMoreTools` a user of this class can > connect to to get notified when user preference

D22594: [Dolphin] Open Preferred Search Tool action

broulik added inline comments. INLINE COMMENTS > pdabrowski wrote in dolphinmainwindow.cpp:2289 > > So, the URL does not have any impact on the search tool chosen? I thought > > that was the main reason for using the URL and updating it all the time. > > This depends on KMoreToolsMenuFactory.

D22594: [Dolphin] Open Preferred Search Tool action

pdabrowski added inline comments. INLINE COMMENTS > broulik wrote in dolphinmainwindow.cpp:2289 > > It is a rare occasion that user changes preferred search tools, > > So, the URL does not have any impact on the search tool chosen? I thought > that was the main reason for using the URL and

D22594: [Dolphin] Open Preferred Search Tool action

broulik added inline comments. INLINE COMMENTS > pdabrowski wrote in dolphinmainwindow.cpp:2289 > It was added to handle this action as a button in toolbar (can be added by > user, and this was requested in #384798). > > I didn't notice this causes such a problem with remote connections,

D22594: [Dolphin] Open Preferred Search Tool action

pdabrowski added inline comments. INLINE COMMENTS > broulik wrote in dolphinmainwindow.cpp:943 > `exec()` on a job is generally bad, but looks like it was like this already? Yes, it was like that in DolphinMainWindow::openTerminal() before. It was needed as explained in this comment: // If

D22594: [Dolphin] Open Preferred Search Tool action

broulik added inline comments. INLINE COMMENTS > dolphinmainwindow.cpp:943 > KJobWidgets::setWindow(statJob, this); > statJob->exec(); > QUrl url = statJob->mostLocalUrl(); `exec()` on a job is generally bad, but looks like it was like this already? > dolphinmainwindow.cpp:2289

D22594: [Dolphin] Open Preferred Search Tool action

This revision was automatically updated to reflect the committed changes. Closed by commit R318:537dc7864ae3: [Dolphin] Open Preferred Search Tool action (authored by pdabrowski, committed by elvisangelaccio). REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE

D22594: [Dolphin] Open Preferred Search Tool action

elvisangelaccio accepted this revision. This revision is now accepted and ready to land. REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D22594 To: pdabrowski, #dolphin, ngraham, elvisangelaccio Cc: pkloc, kfm-devel, kde-doc-english, pberestov, iasensio, fprice, gennad,

D22594: [Dolphin] Open Preferred Search Tool action

ngraham accepted this revision. ngraham added a comment. Okay, that makes sense. REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D22594 To: pdabrowski, #dolphin, ngraham, elvisangelaccio Cc: pkloc, kfm-devel, kde-doc-english, pberestov, iasensio, fprice, gennad,

D22594: [Dolphin] Open Preferred Search Tool action

ngraham added a comment. @elvisangelaccio, all good now? REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D22594 To: pdabrowski, #dolphin, ngraham, elvisangelaccio Cc: pkloc, kfm-devel, kde-doc-english, pberestov, iasensio, fprice, gennad, MrPepe, fbampaloukas,

D22594: [Dolphin] Open Preferred Search Tool action

pdabrowski added inline comments. INLINE COMMENTS > ngraham wrote in dolphinmainwindow.cpp:1162 > Since this patch was made, we've re-organized the hamburger menu a bit to > simplify it and hide not-commonly-used functionality. I think this feature > counts, since it's an alternative to the

D22594: [Dolphin] Open Preferred Search Tool action

pdabrowski added inline comments. INLINE COMMENTS > ngraham wrote in dolphinmainwindow.cpp:1162 > Since this patch was made, we've re-organized the hamburger menu a bit to > simplify it and hide not-commonly-used functionality. I think this feature > counts, since it's an alternative to the

D22594: [Dolphin] Open Preferred Search Tool action

ngraham added inline comments. INLINE COMMENTS > dolphinmainwindow.cpp:1162 > addActionToMenu(ac->action(QStringLiteral("show_filter_bar")), menu); > + > addActionToMenu(ac->action(QStringLiteral("open_preferred_search_tool")), > menu); >

D22594: [Dolphin] Open Preferred Search Tool action

pdabrowski updated this revision to Diff 69855. pdabrowski marked 5 inline comments as done. REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22594?vs=67500=69855 REVISION DETAIL https://phabricator.kde.org/D22594 AFFECTED FILES doc/index.docbook

D22594: [Dolphin] Open Preferred Search Tool action

elvisangelaccio requested changes to this revision. elvisangelaccio added a comment. This revision now requires changes to proceed. Almost there! INLINE COMMENTS > pdabrowski wrote in dolphinmainwindow.cpp:916-919 > There is no other way to update the open_preferred_search_tool action >

D22594: [Dolphin] Open Preferred Search Tool action

pdabrowski marked 2 inline comments as done. pdabrowski added inline comments. INLINE COMMENTS > elvisangelaccio wrote in dolphinmainwindow.cpp:916-919 > I don't get this connection. Can you explain what's needed for? There is no other way to update the open_preferred_search_tool action

D22594: [Dolphin] Open Preferred Search Tool action

pdabrowski updated this revision to Diff 67500. pdabrowski marked 4 inline comments as done. REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22594?vs=66163=67500 REVISION DETAIL https://phabricator.kde.org/D22594 AFFECTED FILES doc/index.docbook

D22594: [Dolphin] Open Preferred Search Tool action

elvisangelaccio requested changes to this revision. elvisangelaccio added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > dolphinmainwindow.cpp:894 > +KMoreToolsMenuFactory("dolphin/search-tools").fillMenuFromGroupingNames( > +_searchTools, {

D22594: [Dolphin] Open Preferred Search Tool action

pdabrowski updated this revision to Diff 66163. pdabrowski added a comment. Rebased. REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22594?vs=66098=66163 REVISION DETAIL https://phabricator.kde.org/D22594 AFFECTED FILES doc/index.docbook

D22594: [Dolphin] Open Preferred Search Tool action

elvisangelaccio added a comment. Needs one more rebase, sorry REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D22594 To: pdabrowski, #dolphin, ngraham, elvisangelaccio Cc: pkloc, kfm-devel, kde-doc-english, iasensio, fprice, gennad, MrPepe, fbampaloukas, alexde,

D22594: [Dolphin] Open Preferred Search Tool action

pdabrowski added a comment. Done. REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D22594 To: pdabrowski, #dolphin, ngraham, elvisangelaccio Cc: pkloc, kfm-devel, kde-doc-english, iasensio, fprice, gennad, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven,

D22594: [Dolphin] Open Preferred Search Tool action

pdabrowski updated this revision to Diff 66098. pdabrowski marked 2 inline comments as done. REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22594?vs=62910=66098 REVISION DETAIL https://phabricator.kde.org/D22594 AFFECTED FILES doc/index.docbook

D22594: [Dolphin] Open Preferred Search Tool action

elvisangelaccio added inline comments. INLINE COMMENTS > dolphinui.rc:2 > > - > + > Please rebase, thanks! REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D22594 To: pdabrowski, #dolphin, ngraham, elvisangelaccio Cc: pkloc, kfm-devel, kde-doc-english,

D22594: [Dolphin] Open Preferred Search Tool action

elvisangelaccio added a comment. I'll be AFK for a week for vacation. Will do a proper review once I'm back ;) INLINE COMMENTS > dolphinmainwindow.cpp:874 > + > +void DolphinMainWindow::setupUpdateOpenPreferredSearchToolAction() { > +QAction* openPreferredSearchTool = >

D22594: [Dolphin] Open Preferred Search Tool action

ngraham added a comment. @elvisangaleccio? REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D22594 To: pdabrowski, #dolphin, ngraham, elvisangelaccio Cc: pkloc, kfm-devel, kde-doc-english, aprcela, vmarinescu, fprice, gennad, fbampaloukas, alexde, feverfew, meven,

D22594: [Dolphin] Open Preferred Search Tool action

ngraham accepted this revision. REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D22594 To: pdabrowski, #dolphin, ngraham, elvisangelaccio Cc: pkloc, kfm-devel, kde-doc-english, aprcela, vmarinescu, fprice, gennad, fbampaloukas, alexde, feverfew, meven, spoorun,

D22594: [Dolphin] Open Preferred Search Tool action

pdabrowski edited the summary of this revision. REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D22594 To: pdabrowski, #dolphin, ngraham, elvisangelaccio Cc: pkloc, kfm-devel, kde-doc-english, aprcela, vmarinescu, fprice, gennad, fbampaloukas, alexde, feverfew, meven,

D22594: [Dolphin] Open Preferred Search Tool action

pdabrowski updated this revision to Diff 62910. pdabrowski added a comment. Small fix for the "Open Preferred Search Tool" as a toolbar button. REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22594?vs=62212=62910 REVISION DETAIL

D22594: [Dolphin] Open Preferred Search Tool action

pdabrowski edited the summary of this revision. REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D22594 To: pdabrowski, #dolphin, ngraham, elvisangelaccio Cc: pkloc, kfm-devel, kde-doc-english, aprcela, vmarinescu, fprice, gennad, fbampaloukas, alexde, feverfew, meven,

D22594: [Dolphin] Open Preferred Search Tool action

pkloc added a comment. As a person who opened https://bugs.kde.org/show_bug.cgi?id=391677 I would like to note that it is not in fact a duplicate of https://bugs.kde.org/show_bug.cgi?id=391677 My reasoning for opening that bug was because baloo is sometimes very unreliable at finding

D22594: [Dolphin] Open Preferred Search Tool action

pdabrowski added a comment. In D22594#503270 , @elvisangelaccio wrote: > In D22594#498890 , @ngraham wrote: > > > As for the feature itself, for the past few years I'd been opposed to this, on the

D22594: [Dolphin] Open Preferred Search Tool action

pdabrowski added a comment. In D22594#503270 , @elvisangelaccio wrote: > I'd like to remind that the menubar is hidden by default and the average user won't know about the `CTRL+Shift+F` shortcut. > So is this feature only aimed at advanced

D22594: [Dolphin] Open Preferred Search Tool action

elvisangelaccio added a comment. In D22594#498890 , @ngraham wrote: > As for the feature itself, for the past few years I'd been opposed to this, on the basis that people should just use the built-in Baloo-based search instead. But

D22594: [Dolphin] Open Preferred Search Tool action

pdabrowski added a comment. I did some more testing, and everything seems to work fine: sudo su cd /usr/share/applications sleep 2 && mv org.kde.kfind.desktop org.kde.kfind.desktop_# no KFind now sleep 2 && mv org.kde.kfind.desktop_ org.kde.kfind.desktop# KFind

D22594: [Dolphin] Open Preferred Search Tool action

pdabrowski added a comment. No problem. I'm glad it works :) REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D22594 To: pdabrowski, #dolphin, ngraham, elvisangelaccio Cc: kfm-devel, kde-doc-english, aprcela, fprice, gennad, fbampaloukas, alexde, feverfew, meven,

D22594: [Dolphin] Open Preferred Search Tool action

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Well now I'm embarrassed to admit that I probably didn't. I think I updated it but forgot to compile lol. Sorry for wasting your time! This looks great to me now. @elvisangelaccio do

D22594: [Dolphin] Open Preferred Search Tool action

pdabrowski added a comment. Hmm... Are you using the latest diff (https://phabricator.kde.org/D22594?id=62212)? REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D22594 To: pdabrowski, #dolphin, ngraham, elvisangelaccio Cc: kfm-devel, kde-doc-english, aprcela, fprice,

D22594: [Dolphin] Open Preferred Search Tool action

ngraham added a comment. No, I already had KFind installed. I just opened Dolphin and looked at the menu item, nothing fancy. :/ F7070963: repro-2019-07-21_16.08.02.webm REPOSITORY R318 Dolphin REVISION DETAIL

D22594: [Dolphin] Open Preferred Search Tool action

pdabrowski added a comment. > The way you've implemented the menu item naming seems a bit fragile though True. It's really hard to update it reliably. KMoreTools* do not provide an easy way to get notified that the tools changed. Even current solution in "More Search Tools" menu

D22594: [Dolphin] Open Preferred Search Tool action

ngraham added a comment. All right, you've convinced me on the shortcut. The way you've implemented the menu item naming seems a bit fragile though (and in line 1410 of `src/dolphinmainwindow.cpp`, it's not used at all). In my testing, the name doesn't show up and it falls back to the

D22594: [Dolphin] Open Preferred Search Tool action

pdabrowski added a comment. > 2. For the keyboard shortcut let's use Alt instead of Shift. It is an alternate search, after all. I found `Ctrl+Shift+F` to be much more popular for "search", "advanced search", "search in all ...", "find in ...", "advanced find", etc.:

D22594: [Dolphin] Open Preferred Search Tool action

pdabrowski updated this revision to Diff 62212. pdabrowski edited the summary of this revision. pdabrowski added a comment. > 1. Instead of showing a generic text, how about making it actually say "Search with https://phabricator.kde.org/D22594?vs=62211=62212 REVISION DETAIL

D22594: [Dolphin] Open Preferred Search Tool action

pdabrowski updated this revision to Diff 62211. pdabrowski added a comment. > 3. Whenever you change anything in a .rc file, you need to bump the version number that appears at the top of the file. Done. REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE

D22594: [Dolphin] Open Preferred Search Tool action

ngraham requested changes to this revision. ngraham added a reviewer: elvisangelaccio. ngraham added a comment. This revision now requires changes to proceed. This is a very well-formed patch, with good code (including correct usage of KUIT markup!), a good commit message, and a good

D22594: [Dolphin] Open Preferred Search Tool action

pdabrowski edited the summary of this revision. REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D22594 To: pdabrowski, #dolphin, ngraham Cc: kfm-devel, kde-doc-english, aprcela, fprice, gennad, fbampaloukas, alexde, feverfew, meven, spoorun, navarromorales, firef,

D22594: [Dolphin] Open Preferred Search Tool action

pdabrowski created this revision. pdabrowski added reviewers: Dolphin, ngraham. Herald added projects: Dolphin, Documentation. Herald added subscribers: kde-doc-english, kfm-devel. pdabrowski requested review of this revision. REVISION SUMMARY Added "Open Preferred Search Tool" action to Tools