D23415: Improve comprehensibility and consistency of window placement mode names

2019-08-28 Thread Nathaniel Graham
ngraham added a comment. In fact, the HIG already says that: > https://hig.kde.org/style/writing/labels.html#guidelines > Don’t shorten your labels to the point of losing meaning. A three-word label that provides clear information is better than a one-word label that is ambiguous or

D23415: Improve comprehensibility and consistency of window placement mode names

2019-08-28 Thread Eike Hein
hein added a comment. "Smart" is a non-label to me and pretty lazy; it's like someone did a lame attempt at branding an option as cool instead of just putting some effort into finding a succinct description of what it aims for. The strings suggested by the patch seem like a nice

D23415: Improve comprehensibility and consistency of window placement mode names

2019-08-28 Thread Hugo Pereira Da Costa
hpereiradacosta added a comment. for what its worth: to me smart means: there has been some thought put in this placement policy and it should be the best one for you. If you don't like it, you might want to try the alternatives. When I read "smart" as an option, immediately I think "that's

D22616: Remove phonon KCM

2019-08-28 Thread Nathaniel Graham
ngraham added a task: T9091: Merge PulseAudio and Phonon KCM. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D22616 To: nicolasfella, sitter Cc: ngraham, kde-doc-english, pino, plasma-devel, sitter, LeGast00n, The-Feren-OS-Dev, jraleigh, gennad, fbampaloukas,

D23415: Improve comprehensibility and consistency of window placement mode names

2019-08-28 Thread Björn Feber
GB_2 added a comment. In D23415#521275 , @alexde wrote: > I am not sure if I am allowed to intervene in this discussion, but "smart" is a really "dumb" description as it says nothing about what it actually does. > As a user I am left to do

D23415: Improve comprehensibility and consistency of window placement mode names

2019-08-28 Thread Alex Debus
alexde added a comment. I am not sure if I am allowed to intervene in this discussion, but "smart" is a really "dumb" description as it says nothing about what it actually does. As a user I am left to do four things to find out, what it means: 1. Activate the option, observe the result

D22444: Add Reset Zoom Level action inside View menu

2019-08-28 Thread Nathaniel Graham
ngraham marked 3 inline comments as done. REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D22444 To: ngraham, elvisangelaccio, shubham, #dolphin Cc: broulik, cfeck, kfm-devel, kde-doc-english, aprcela, vmarinescu, fprice, gennad, MrPepe, fbampaloukas, alexde, Codezela,

D22444: Add Reset Zoom Level action inside View menu

2019-08-28 Thread Nathaniel Graham
ngraham updated this revision to Diff 64868. ngraham added a comment. - Rebase - Address review comments REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22444?vs=63767=64868 BRANCH arcpatch-D22444 REVISION DETAIL https://phabricator.kde.org/D22444

D22444: Add Reset Zoom Level action inside View menu

2019-08-28 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > dolphinui.rc:2 > > - > + > Careful, this clashes with the recent toolbar shuffling > dolphinview.cpp:1351 > +default:mode = ViewModeSettings::IconsMode; > +Q_ASSERT(false); > +

D22444: Add Reset Zoom Level action inside View menu

2019-08-28 Thread Nathaniel Graham
ngraham added a comment. @elvisangelaccio Ping. REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D22444 To: ngraham, elvisangelaccio, shubham, #dolphin Cc: cfeck, kfm-devel, kde-doc-english, aprcela, vmarinescu, fprice, gennad, MrPepe, fbampaloukas, alexde, Codezela,

D23415: Improve comprehensibility and consistency of window placement mode names

2019-08-28 Thread Nathaniel Graham
ngraham added a comment. In D23415#521038 , @zzag wrote: > My problem is that VDG goes way overboard with user-visible strings. For example, we didn't receive any complaints about "Desktop Effects" string. Linux community settled on using that

[spectacle] doc: Update docs to the latest version in git

2019-08-28 Thread Yuri Chornoivan
Git commit 76e180e9be83b4bb20922ad148ab83e72e7fad8f by Yuri Chornoivan. Committed on 28/08/2019 at 15:28. Pushed by yurchor into branch 'master'. Update docs to the latest version in git M +---doc/ApplicationPreferences.png M +---doc/MainWindow.png M +---

D23415: Improve comprehensibility and consistency of window placement mode names

2019-08-28 Thread Vlad Zagorodniy
zzag added a comment. In D23415#520175 , @ngraham wrote: > But that doesn't make sense to me. The reason to rename it in the code as well is to preserve internal consistency with the user-displayed strings. If we only rename the enums and not

[plasma-desktop] /: Remove phonon KCM

2019-08-28 Thread Nicolas Fella
Git commit 973306c7bb7df2f9be19c1417484361511a87c67 by Nicolas Fella. Committed on 28/08/2019 at 10:05. Pushed by nicolasfella into branch 'master'. Remove phonon KCM Summary: Most of the Phonon KCM settings have been moved to plasma-pa. The remaining settings server very specific use cases

D22616: Remove phonon KCM

2019-08-28 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes. Closed by commit R119:973306c7bb7d: Remove phonon KCM (authored by nicolasfella). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22616?vs=64811=64813 REVISION DETAIL

D22616: Remove phonon KCM

2019-08-28 Thread Harald Sitter
sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. Good to land. Phonon 4.11 replaces this KCM with a new phononsettings application, which is a simple port of the KCM to a standalone application. REPOSITORY R119 Plasma Desktop BRANCH

D22616: Remove phonon KCM

2019-08-28 Thread Nicolas Fella
nicolasfella updated this revision to Diff 64811. nicolasfella added a comment. Herald added a project: Documentation. Herald added a subscriber: kde-doc-english. - Remove unused stuff REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE