subject:"Keys"

[khelpcenter] [Bug 461468] Crash when pressing particular sequence of function keys

2022-11-06 Thread Albert Astals Cid

https://bugs.kde.org/show_bug.cgi?id=461468

Albert Astals Cid  changed:

   What|Removed |Added

 CC||aa...@kde.org

--- Comment #4 from Albert Astals Cid  ---
That's a KHTML shortcut, may have to do with the khelpcenter<->khtml or khtml
itself is broken

-- 
You are receiving this mail because:
You are the assignee for the bug.

[khelpcenter] [Bug 461468] Crash when pressing particular sequence of function keys

2022-11-05 Thread Jack

https://bugs.kde.org/show_bug.cgi?id=461468

--- Comment #3 from Jack  ---
Settings/Configure Keyboard Shortcuts says F7 is "Toggle caret mode."  I can't
find any mention about khelpcenter having caret mode.  Even searching the
source files, the only mention I see of F7 is for Ctl-F7 "Present Windows of
current application only" in the section on  "Moving Around."  I wonder if the
system is getting confused because that key combination (just F7) doesn't
actually map to anything in khelpcenter.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[khelpcenter] [Bug 461468] Crash when pressing particular sequence of function keys

2022-11-05 Thread Jack

https://bugs.kde.org/show_bug.cgi?id=461468

Jack  changed:

   What|Removed |Added

 CC||ostroffjh@users.sourceforge
   ||.net

--- Comment #2 from Jack  ---
I get the same crash just typing F7 twice.

Artix Linux, kernel 6.0.7
khelpcenter 22.08.2
KDE Frameworks 5.99.0
KDE Plasma 5.26.2
Qt 5.15.7
Xorg Server 21.1.4

Application: Help Center (khelpcenter), signal: Segmentation fault
Content of s_kcrashErrorMessage: std::unique_ptr = {get() = }
[KCrash Handler]
#6  setCaretInvisibleIfNeeded (part=0x55d9148a1830) at
/usr/src/debug/khtml/khtml-5.99.0/src/misc/shared.h:98
#7  0x7f9ea8ebe1c0 in doActivate (sender=0x55d914abd580,
signal_index=4, argv=0x7ffec1e52d10) at kernel/qobject.cpp:3931
#8  0x7f9ea9b6bec7 in QAction::triggered (this=this@entry=0x55d914abd580,
_t1=) at .moc/moc_qaction.cpp:376
#9  0x7f9ea9b718c7 in QAction::activate (this=0x55d914abd580,
event=) at kernel/qaction.cpp:1161
#10 0x7f9ea9b7198e in QAction::event (e=, this=) at kernel/qaction.cpp:1086
#11 QAction::event (this=, e=) at
kernel/qaction.cpp:1075
#12 0x7f9ea9b78b1c in QApplicationPrivate::notify_helper (this=, receiver=0x55d914abd580, e=0x7ffec1e52ea0) at
kernel/qapplication.cpp:3637
#13 0x7f9ea8e8d578 in QCoreApplication::notifyInternal2
(receiver=0x55d914abd580, event=0x7ffec1e52ea0) at
kernel/qcoreapplication.cpp:1064
#14 0x7f9ea93742cd in QShortcutMap::dispatchEvent (this=,
e=) at kernel/qshortcutmap.cpp:675
#15 0x7f9ea936ab27 in QShortcutMap::tryShortcut (this=0x55d9145252c8,
e=0x7ffec1e52f60) at kernel/qshortcutmap.cpp:343
#16 0x7f9ea932a168 in QWindowSystemInterface::handleShortcutEvent
(window=, timestamp=33169991, keyCode=16777270, modifiers=...,
nativeScanCode=73, nativeVirtualKey=65476, nativeModifiers=0, text=...,
autorepeat=false, count=1) at kernel/qwindowsysteminterface.cpp:477
#17 0x7f9ea933fb22 in QGuiApplicationPrivate::processKeyEvent
(e=0x55d914ff5820) at kernel/qguiapplication.cpp:2398
#18 0x7f9ea93289b5 in QWindowSystemInterface::sendWindowSystemEvents
(flags=flags@entry=...) at kernel/qwindowsysteminterface.cpp:1169
#19 0x7f9ea35d6630 in xcbSourceDispatch (source=) at
/usr/src/debug/qt5-base/qtbase/src/plugins/platforms/xcb/qxcbeventdispatcher.cpp:105
#20 0x7f9ea6f0f87b in g_main_dispatch (context=0x7f9e9c005010) at
../glib/glib/gmain.c:3444
#21 g_main_context_dispatch (context=0x7f9e9c005010) at
../glib/glib/gmain.c:4162
#22 0x7f9ea6f66279 in g_main_context_iterate.constprop.0
(context=0x7f9e9c005010, block=1, dispatch=1, self=) at
../glib/glib/gmain.c:4238
#23 0x7f9ea6f0e132 in g_main_context_iteration (context=0x7f9e9c005010,
may_block=1) at ../glib/glib/gmain.c:4303
#24 0x7f9ea8ed820c in QEventDispatcherGlib::processEvents
(this=0x55d9145f5260, flags=...) at kernel/qeventdispatcher_glib.cpp:423
#25 0x7f9ea8e85d2c in QEventLoop::exec (this=0x7ffec1e53310, flags=...) at
../../include/QtCore/../../src/corelib/global/qflags.h:69
#26 0x7f9ea8e90849 in QCoreApplication::exec () at
../../include/QtCore/../../src/corelib/global/qflags.h:121
#27 0x7f9ea933a112 in QGuiApplication::exec () at
kernel/qguiapplication.cpp:1870
#28 0x7f9ea9b76f2a in QApplication::exec () at kernel/qapplication.cpp:2829
#29 0x55d912a41a0f in main (argc=, argv=) at
/usr/src/debug/khelpcenter/khelpcenter-22.08.2/application.cpp:145
[Inferior 1 (process 18699) detached]

-- 
You are receiving this mail because:
You are the assignee for the bug.

[khelpcenter] [Bug 461468] Crash when pressing particular sequence of function keys

2022-11-05 Thread Enrico

https://bugs.kde.org/show_bug.cgi?id=461468

Enrico  changed:

   What|Removed |Added

 Status|REPORTED|CONFIRMED
 Ever confirmed|0   |1
 CC||enric...@hotmail.com

--- Comment #1 from Enrico  ---
Nice! :) I can reproduce this bug

Operating System: KDE neon 5.26
KDE Plasma Version: 5.26.2
KDE Frameworks Version: 5.99.0
Qt Version: 5.15.7
Kernel Version: 5.15.0-52-generic (64-bit)
Graphics Platform: Wayland

-- 
You are receiving this mail because:
You are the assignee for the bug.

[khelpcenter] [Bug 461468] Crash when pressing particular sequence of function keys

2022-11-05 Thread Bug Janitor Service

https://bugs.kde.org/show_bug.cgi?id=461468

Bug Janitor Service  changed:

   What|Removed |Added

   Severity|normal  |crash

-- 
You are receiving this mail because:
You are the assignee for the bug.

[khelpcenter] [Bug 461468] Crash when pressing particular sequence of function keys

2022-11-05 Thread David Korth

https://bugs.kde.org/show_bug.cgi?id=461468

David Korth  changed:

   What|Removed |Added

Summary|Crash while pressing random |Crash when pressing
   |function keys   |particular sequence of
   ||function keys

-- 
You are receiving this mail because:
You are the assignee for the bug.

[khelpcenter] [Bug 461468] New: Crash while pressing random function keys

2022-11-05 Thread David Korth

https://bugs.kde.org/show_bug.cgi?id=461468

Bug ID: 461468
   Summary: Crash while pressing random function keys
Classification: Applications
   Product: khelpcenter
   Version: unspecified
  Platform: Gentoo Packages
OS: Linux
Status: REPORTED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: kde-doc-english@kde.org
  Reporter: gerbils...@gerbilsoft.com
  Target Milestone: ---

While cleaning my keyboard, I managed to somehow crash KHelpCenter (22.08.3;
this version isn't in the list).

I've narrowed it down to the following steps:
* Open KHelpCenter (e.g. by pressing F1 in KWrite).
* Press the following keys in sequence: F3, F1, F7
* Repeat the sequence: F3, F1, F7

Application: Help Center (khelpcenter), signal: Segmentation fault

[KCrash Handler]
#4  0x7f7762160ad2 in setCaretInvisibleIfNeeded(KHTMLPart*) () from
/usr/lib64/libKF5KHtml.so.5
#5  0x7f7760676bd4 in doActivate (sender=0x55a83a195f40,
signal_index=4, argv=0x7b9870c0) at
/var/tmp/portage/dev-qt/qtcore-5.15.5-r3/work/qtbase-everywhere-src-5.15.5/src/corelib/kernel/qobject.cpp:3898
#6  0x7f77612f2a42 in QAction::triggered (this=this@entry=0x55a83a195f40,
_t1=) at .moc/moc_qaction.cpp:376
#7  0x7f77612f80fb in QAction::activate (this=0x55a83a195f40,
event=) at
/var/tmp/portage/dev-qt/qtwidgets-5.15.5-r1/work/qtbase-everywhere-src-5.15.5/src/widgets/kernel/qaction.cpp:1161
#8  0x7f77612f81cd in QAction::event (e=, this=) at
/var/tmp/portage/dev-qt/qtwidgets-5.15.5-r1/work/qtbase-everywhere-src-5.15.5/src/widgets/kernel/qaction.cpp:1086
#9  QAction::event (this=, e=) at
/var/tmp/portage/dev-qt/qtwidgets-5.15.5-r1/work/qtbase-everywhere-src-5.15.5/src/widgets/kernel/qaction.cpp:1075
#10 0x7f77612feeeb in QApplicationPrivate::notify_helper (this=, receiver=0x55a83a195f40, e=0x7b987260) at
/var/tmp/portage/dev-qt/qtwidgets-5.15.5-r1/work/qtbase-everywhere-src-5.15.5/src/widgets/kernel/qapplication.cpp:3637
#11 0x7f7760646cb8 in QCoreApplication::notifyInternal2
(receiver=0x55a83a195f40, event=0x7b987260) at
/var/tmp/portage/dev-qt/qtcore-5.15.5-r3/work/qtbase-everywhere-src-5.15.5/src/corelib/kernel/qcoreapplication.cpp:1064
#12 0x7f7760d35dfe in QShortcutMap::dispatchEvent (this=,
e=) at
/var/tmp/portage/dev-qt/qtgui-5.15.5-r2/work/qtbase-everywhere-src-5.15.5/src/gui/kernel/qshortcutmap.cpp:675
#13 0x7f7760d36133 in QShortcutMap::tryShortcut (this=0x55a839a84908,
e=0x7b987320) at
/var/tmp/portage/dev-qt/qtgui-5.15.5-r2/work/qtbase-everywhere-src-5.15.5/src/gui/kernel/qshortcutmap.cpp:343
#14 0x7f7760cf0a3a in QWindowSystemInterface::handleShortcutEvent
(window=, timestamp=311139463, keyCode=16777270, modifiers=...,
nativeScanCode=73, nativeVirtualKey=65476, nativeModifiers=2, text=...,
autorepeat=false, count=1) at
/var/tmp/portage/dev-qt/qtgui-5.15.5-r2/work/qtbase-everywhere-src-5.15.5/src/gui/kernel/qwindowsysteminterface.cpp:477
#15 0x7f7760d08481 in QGuiApplicationPrivate::processKeyEvent
(e=0x55a83a71d650) at
/var/tmp/portage/dev-qt/qtgui-5.15.5-r2/work/qtbase-everywhere-src-5.15.5/src/gui/kernel/qguiapplication.cpp:2395
#16 0x7f7760cec59c in QWindowSystemInterface::sendWindowSystemEvents
(flags=...) at
/var/tmp/portage/dev-qt/qtgui-5.15.5-r2/work/qtbase-everywhere-src-5.15.5/src/gui/kernel/qwindowsysteminterface.cpp:1169
#17 0x7f775e176960 in userEventSourceDispatch (source=) at
/var/tmp/portage/dev-qt/qtgui-5.15.5/work/qtbase-everywhere-src-5.15.5/src/platformsupport/eventdispatchers/qeventdispatcher_glib.cpp:74
#18 0x7f775e91e269 in g_main_dispatch (context=0x55a839aa4d70) at
../glib-2.74.1/glib/gmain.c:3444
#19 g_main_context_dispatch (context=0x55a839aa4d70) at
../glib-2.74.1/glib/gmain.c:4162
#20 0x7f775e973418 in g_main_context_iterate.constprop.0
(context=0x55a839aa4d70, block=, dispatch=1, self=) at ../glib-2.74.1/glib/gmain.c:4238
#21 0x7f775e91c880 in g_main_context_iteration (context=0x55a839aa4d70,
may_block=1) at ../glib-2.74.1/glib/gmain.c:4303
#22 0x7f776068fc26 in QEventDispatcherGlib::processEvents
(this=0x55a839aa4610, flags=...) at
/var/tmp/portage/dev-qt/qtcore-5.15.5-r3/work/qtbase-everywhere-src-5.15.5/src/corelib/kernel/qeventdispatcher_glib.cpp:425
#23 0x7f7760645f7b in QEventLoop::exec (this=0x7b987670, flags=...) at
/var/tmp/portage/dev-qt/qtcore-5.15.5-r3/work/qtbase-everywhere-src-5.15.5/include/QtCore/../../src/corelib/global/qflags.h:69
#24 0x7f776064726a in QCoreApplication::exec () at
/var/tmp/portage/dev-qt/qtcore-5.15.5-r3/work/qtbase-everywhere-src-5.15.5/include/QtCore/../../src/corelib/global/qflags.h:121
#25 0x55a838ac1bb3 in main ()
[Inferior 1 (process 3018290) detached]

-- 
You are receiving this mail because:
You are the assignee for the bug.

[plasma-nm/Plasma/5.15] kded: Reject invalid keys

2019-04-30 Thread Oleg Solovyov

Git commit 257b03b185d30312a8c3308092f77ca7a6b9c84d by Oleg Solovyov.
Committed on 30/04/2019 at 13:21.
Pushed by osolovyov into branch 'Plasma/5.15'.

Reject invalid keys

Summary:
PasswordDialog accepted invalid keys, which causes storing them in user's
wallet. In that case, no new secrets will be requested from user:
plasma-nm will silently fail to connect unless key is edited or deleted.

GUI: OK button is disabled when key is invalid

Reviewers: jgrulich

Reviewed By: jgrulich

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D20900

M  +24   -0kded/passworddialog.cpp

https://commits.kde.org/plasma-nm/257b03b185d30312a8c3308092f77ca7a6b9c84d

diff --git a/kded/passworddialog.cpp b/kded/passworddialog.cpp
index 410d7085..59992ebc 100644
--- a/kded/passworddialog.cpp
+++ b/kded/passworddialog.cpp
@@ -28,6 +28,7 @@
 
 #include 
 #include 
+#include 
 
 #include 
 #include 
@@ -69,6 +70,29 @@ void PasswordDialog::initializeUi()
 
 connect(m_ui->buttonBox, ::accepted, this, 
::accept);
 connect(m_ui->buttonBox, ::rejected, this, 
::reject);
+connect(m_ui->password, ::textChanged, [this](const QString 
){
+if (m_connectionSettings->connectionType() == 
NetworkManager::ConnectionSettings::Wireless) {
+NetworkManager::WirelessSecuritySetting::Ptr 
wirelessSecuritySetting =
+
m_connectionSettings->setting(NetworkManager::Setting::WirelessSecurity).staticCast();
+bool valid = true;
+
+if (wirelessSecuritySetting) {
+switch (wirelessSecuritySetting->keyMgmt()) {
+case NetworkManager::WirelessSecuritySetting::WpaPsk:
+valid = wpaPskIsValid(text);
+break;
+case NetworkManager::WirelessSecuritySetting::Wep:
+valid = wepKeyIsValid(text, 
wirelessSecuritySetting->wepKeyType());
+break;
+default:
+break;
+}
+}
+
+// disable button if key is not valid
+m_ui->buttonBox->button(QDialogButtonBox::Ok)->setDisabled(!valid);
+}
+});
 
 if (m_connectionSettings->connectionType() != 
NetworkManager::ConnectionSettings::Vpn) {
 NetworkManager::Setting::Ptr setting = 
m_connectionSettings->setting(m_settingName);

D13450: Add arrow keys to move and resize selection rectangle

2018-07-19 Thread Scott Harvey

sharvey added a comment.

  In D13450#294820 , @rkflx wrote:

  > It seems you forgot to merge stable into master, which I now have done with

  I was actually in the process of trying to figure that out... I got a lengthy 
list of warnings when I tried it and the wiki is a bit vague on what to do in 
that case. I was hunting through the diff history trying to figure out if it 
was necessary in this case. Regardless, thanks for taking care of it.

  > Thanks again for the quick update so we could get the string changes in in 
time, and hopefully for the RC in two weeks you'll be able to solve the 
remaining problems with `checkBounds`.

  `checkBounds` seemed so simple, yet it frustrated me endlessly. I'll dig into 
it and see what's going on. I have a few suspicions.

  ---

  If you have time, would you mind dropping me a line at `sc...@spharvey.me`? I 
have some unrelated questions I'd like to get your opinion on. Thanks in 
advance.

REPOSITORY
  R166 Spectacle

REVISION DETAIL
  https://phabricator.kde.org/D13450

To: sharvey, rkflx, ngraham, #spectacle, yurchor
Cc: ltoscano, kde-doc-english, abalaji, #spectacle, skadinna

D13450: Add arrow keys to move and resize selection rectangle

2018-07-19 Thread Henrik Fehlauer

rkflx added a comment.


  It seems you forgot to merge stable into master, which I now have done with
  
git checkout master
git pull
git merge -Xours origin/Applications/18.08
git push
  
  Thanks again for the quick update so we could get the string changes in in 
time, and hopefully for the RC in two weeks you'll be able to solve the 
remaining problems with `checkBounds`.

REPOSITORY
  R166 Spectacle

REVISION DETAIL
  https://phabricator.kde.org/D13450

To: sharvey, rkflx, ngraham, #spectacle, yurchor
Cc: ltoscano, kde-doc-english, abalaji, #spectacle, skadinna

[spectacle/Applications/18.08] /: Add arrow keys to move and resize selection rectangle

2018-07-19 Thread Scott Harvey

Git commit 48eacd1ba1495a9167dd9f9cd8097e86ae6ff6dd by Scott Harvey.
Committed on 19/07/2018 at 10:38.
Pushed by sharvey into branch 'Applications/18.08'.

Add arrow keys to move and resize selection rectangle

Summary:
Add arrow keys to move and resize selection rectangle.
{key Arrows} alone moves in large increment
{key Shift} + {key Arrows} moves in small (single pixel) increments
{key ALT} + {key Arrows} resize rectangle in large increment
{key ALT} + {key Shift} + {key Arrows} resize rectangle in small increment

BUG: 394947

Test Plan:
- Apply patch
 - Launch Spectacle; begin Rectangular Selection
 - Select a rectangle with the mouse
 - Use {key Arrows} to move rectangle (large increment)
 - Use {key Shift} + {key Arrows} to move in small increment
 - Use {key ALT} + {key Arrows} to resize rectangle (large increment
 - Use {key ALT} + {key Shift} + {key Arrows} to resize rectangle in small 
increment
 - Complete capture with mouse or {key Enter} key
 - Ensure right selection is captured after moving and resizing rectangle

Reviewers: rkflx, ngraham, #spectacle, yurchor

Reviewed By: rkflx, ngraham, #spectacle, yurchor

Subscribers: ltoscano, kde-doc-english, abalaji, #spectacle

Tags: #documentation

Differential Revision: https://phabricator.kde.org/D13450

M  +5-2doc/index.docbook
M  +202  -3src/QuickEditor/EditorRoot.qml

https://commits.kde.org/spectacle/48eacd1ba1495a9167dd9f9cd8097e86ae6ff6dd

diff --git a/doc/index.docbook b/doc/index.docbook
index 4fcfb40..0331d5f 100644
--- a/doc/index.docbook
+++ b/doc/index.docbook
@@ -29,8 +29,8 @@
 
 
 
-2018-03-06
-Applications 18.04
+2018-07-17
+Applications 18.08
 
 
  is a simple application for capturing desktop 
screenshots. It can capture images of the entire desktop, a single monitor, the 
currently active window, the window currently under the mouse, or a rectangular 
region of the screen. The images can then be printed, sent to other 
applications for manipulation, or quickly be saved as-is.
@@ -150,6 +150,9 @@
 The Rectangular Region 
option allows you to select a rectangular region of your desktop with your 
mouse. This region may be spread across different outputs.
 
 This mode does not immediately take a screenshot 
but allows you to draw a rectangle on your screen, which can be moved and 
resized as needed. Once the desired selection rectangle has been drawn, 
double-clicking anywhere on the screen, or pressing the  button on the 
keyboard will capture the screenshot.
+
+You can use the arrow keys to move and adjust 
the rectangle. Pressing the arrow keys will move the rectangle. Holding the 
Shift key while pressing the arrow keys will move the 
rectangle slowly, for fine-tuning your selection. Holding the 
Alt key while pressing the arrow keys will adjust the size of 
the rectangle.
+
 
 
 
diff --git a/src/QuickEditor/EditorRoot.qml b/src/QuickEditor/EditorRoot.qml
index 583bc37..10560ab 100644
--- a/src/QuickEditor/EditorRoot.qml
+++ b/src/QuickEditor/EditorRoot.qml
@@ -38,6 +38,8 @@ Item {
 property int magZoom: 5;
 property int magPixels: 16;
 property int magOffset: 32;
+property double largeChange: 15;
+property double smallChange: 1 / Screen.devicePixelRatio;
 
 SystemPalette {
 id: systemPalette;
@@ -78,11 +80,202 @@ Item {
 }
 
 Keys.onPressed: {
+
+var change;
+
+// shift key alone = magnifier toggle
 if (event.modifiers & Qt.ShiftModifier) {
 toggleMagnifier = true;
-cropDisplayCanvas.requestPaint();
 }
-}
+
+// nested switches for arrow keys based on modifier keys
+switch(event.modifiers) {
+
+   case Qt.NoModifier:
+   switch (event.key) {
+
+   case Qt.Key_Left:
+change = checkBounds(-largeChange, 0.0, "left");
+selection.x += change;
+break;
+case Qt.Key_Right:
+change = checkBounds(largeChange, 0.0, "right");
+selection.x += change;
+break;
+case Qt.Key_Up:
+change = checkBounds(0.0, -largeChange, "up");
+selection.y += change;
+break;
+case Qt.Key_Down:
+change = checkBounds(0.0, largeChange, "down");
+selection.y += change;
+break;
+}
+
+break; // end no modifier (just arrows)
+
+case Qt.ShiftModifier:
+switch (event.key) {
+
+case Qt.Key_Left:
+ change = checkBounds(-smallChange, 0.0, "left");
+

D13450: Add arrow keys to move and resize selection rectangle

2018-07-19 Thread Scott Harvey

This revision was automatically updated to reflect the committed changes.
Closed by commit R166:48eacd1ba149: Add arrow keys to move and resize selection 
rectangle (authored by sharvey).

REPOSITORY
  R166 Spectacle

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13450?vs=38082=38083

REVISION DETAIL
  https://phabricator.kde.org/D13450

AFFECTED FILES
  doc/index.docbook
  src/QuickEditor/EditorRoot.qml

To: sharvey, rkflx, ngraham, #spectacle, yurchor
Cc: ltoscano, kde-doc-english, abalaji, #spectacle, skadinna

D13450: Add arrow keys to move and resize selection rectangle

2018-07-19 Thread Scott Harvey

sharvey added a comment.


  In D13450#294808 , @rkflx wrote:
  
  > Thanks, looking much better now.
  >
  > Please make sure to commit to the stable branch, i.e. `Applications/18.08` 
(let me know if you are unsure what that means).
  
  
  Following the Arcanist/Phabricator docs on the KDE wiki...

REPOSITORY
  R166 Spectacle

BRANCH
  arcpatch-D13450

REVISION DETAIL
  https://phabricator.kde.org/D13450

To: sharvey, rkflx, ngraham, #spectacle, yurchor
Cc: ltoscano, kde-doc-english, abalaji, #spectacle, skadinna

D13450: Add arrow keys to move and resize selection rectangle

2018-07-19 Thread Scott Harvey

sharvey updated this revision to Diff 38082.
sharvey added a comment.


  - Minor whitespace cleanup

REPOSITORY
  R166 Spectacle

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13450?vs=38080=38082

BRANCH
  arcpatch-D13450

REVISION DETAIL
  https://phabricator.kde.org/D13450

AFFECTED FILES
  doc/index.docbook
  src/QuickEditor/EditorRoot.qml

To: sharvey, rkflx, ngraham, #spectacle, yurchor
Cc: ltoscano, kde-doc-english, abalaji, #spectacle, skadinna

D13450: Add arrow keys to move and resize selection rectangle

2018-07-19 Thread Henrik Fehlauer

rkflx accepted this revision.
rkflx added a comment.
This revision is now accepted and ready to land.


  Thanks, looking much better now.
  
  Please make sure to commit to the stable branch, i.e. `Applications/18.08` 
(let me know if you are unsure what that means).

REPOSITORY
  R166 Spectacle

BRANCH
  arcpatch-D13450

REVISION DETAIL
  https://phabricator.kde.org/D13450

To: sharvey, rkflx, ngraham, #spectacle, yurchor
Cc: ltoscano, kde-doc-english, abalaji, #spectacle, skadinna

D13450: Add arrow keys to move and resize selection rectangle

2018-07-19 Thread Scott Harvey

sharvey marked 2 inline comments as done.

REPOSITORY
  R166 Spectacle

REVISION DETAIL
  https://phabricator.kde.org/D13450

To: sharvey, rkflx, ngraham, #spectacle, yurchor
Cc: ltoscano, kde-doc-english, abalaji, #spectacle, skadinna

D13450: Add arrow keys to move and resize selection rectangle

2018-07-19 Thread Scott Harvey

sharvey updated this revision to Diff 38080.
sharvey added a comment.


  - Fix Alt + Down; Undo layout changes for help text; Reorder help text items

REPOSITORY
  R166 Spectacle

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13450?vs=38014=38080

BRANCH
  arcpatch-D13450

REVISION DETAIL
  https://phabricator.kde.org/D13450

AFFECTED FILES
  doc/index.docbook
  src/QuickEditor/EditorRoot.qml

To: sharvey, rkflx, ngraham, #spectacle, yurchor
Cc: ltoscano, kde-doc-english, abalaji, #spectacle, skadinna

D13450: Add arrow keys to move and resize selection rectangle

2018-07-18 Thread Henrik Fehlauer

rkflx added a comment.

  In D13450#294541 , @sharvey wrote:

  > In D13450#294538 , @rkflx wrote:
  >
  > > - Revert unnecessary layout changes.
  >
  >
  > Please clarify... layout for the help text? I don’t want to waste time.

  I was referring to the following inline comment: D13450#inline-74855 
, e.g. the addition of 
`RowLayout` etc., which should not be necessary if I understand things 
correctly.

REPOSITORY
  R166 Spectacle

REVISION DETAIL
  https://phabricator.kde.org/D13450

To: sharvey, rkflx, ngraham, #spectacle, yurchor
Cc: ltoscano, kde-doc-english, abalaji, #spectacle, skadinna

D13450: Add arrow keys to move and resize selection rectangle

2018-07-18 Thread Scott Harvey

sharvey added a comment.

  In D13450#294538 , @rkflx wrote:

  > Tagging is on Thursday at 23:59 UTC. I will accept the patch tomorrow so 
you can still land it in time (let me know if you are busy and I should commit 
on your behalf).

  That’ll be 6:59pm in my world. I’ll see what I can accomplish in the next 24 
hours.

  > - Revert unnecessary layout changes.

  Please clarify... layout for the help text? I don’t want to waste time.

  > The rest can be improved upon later.

  If it’s not ready (E.g. the edge-touching issue), then it’s not ready. I 
don’t want to see anything released (even as a beta) that’s got bugs. 
Especially known bugs that we just ran out of time to fix. If it has to wait, 
it can wait. I don’t want to be responsible for any bending or breaking of 
rules, and I certainly don’t want to release dodgy software.

REPOSITORY
  R166 Spectacle

REVISION DETAIL
  https://phabricator.kde.org/D13450

To: sharvey, rkflx, ngraham, #spectacle, yurchor
Cc: ltoscano, kde-doc-english, abalaji, #spectacle, skadinna

D13450: Add arrow keys to move and resize selection rectangle

2018-07-18 Thread Henrik Fehlauer

rkflx added a comment.


  Tagging is on Thursday at 23:59 UTC. I will accept the patch tomorrow so you 
can still land it in time (let me know if you are busy and I should commit on 
your behalf).
  
  It would be great if you could still implement three changes until then:
  
  - Move one line in the help text around (see inline comment).
  - Fix [Alt] + [↓].
  - Revert unnecessary layout changes.
  
  The rest can be improved upon later.

REPOSITORY
  R166 Spectacle

REVISION DETAIL
  https://phabricator.kde.org/D13450

To: sharvey, rkflx, ngraham, #spectacle, yurchor
Cc: ltoscano, kde-doc-english, abalaji, #spectacle, skadinna

D13450: Add arrow keys to move and resize selection rectangle

2018-07-18 Thread Henrik Fehlauer

rkflx added a comment.

  Thanks for the updates. Found one more problem, the other changes are fine.

  In D13450#294047 <https://phabricator.kde.org/D13450#294047>, @rkflx wrote:

  > - When the rectangle covers the whole screen, I'm unable to resize, i.e. 
make the rectangle smaller again.

  Note that this problem is more general: Once an edge of the selection touches 
the border of the screen, decreasing the size in that direction is blocked, 
only increasing the size works.

  In D13450#294068 <https://phabricator.kde.org/D13450#294068>, @sharvey wrote:

  > In D13450#294047 <https://phabricator.kde.org/D13450#294047>, @rkflx wrote:
  >
  > > - Selecting with the mouse sets a minimum size, however resizing with the 
arrow keys allows to resize to 0x0px.
  >
  >
  > Where should it stop? 1x1?

  It should be consistent with how it works for selecting with the mouse (grep 
for `minRectSize`).

  In D13450#294279 <https://phabricator.kde.org/D13450#294279>, @sharvey wrote:

  > - Change default adjustment to `largeChange`, [⇧] uses `smallChange` for 
fine tuning

  Thanks, appreciated!

  In D13450#294291 <https://phabricator.kde.org/D13450#294291>, @ngraham wrote:

  > I'm noticing that the magnifier doesn't er show up while you're using the 
keyboard to resize the selection rect. Might wanna hook that up.

  Yeah, I also had that idea a couple of weeks back, but decided to not bring 
it up in the review, because for conceptual reasons I doubt that's so easy to 
implement like you make it sound: The magnifier shows up at the cursor 
position, which for the mouse case is either at one of the corners, or at an 
arbitrary position along one of the edges. Since with the arrow keys you can 
only control horizontal/vertical movement of the edges (this is true both for 
resizing and moving), there is no well-defined corner, i.e. it does not make 
any sense to show a square magnifier at a random position on the edge. You'd 
have to show a magnifier covering the complete width/height of the respective 
edge, because you cannot know where the user is looking at and which part of 
the screenshot he wants to align the selection to (it might not be the corner).

  One way forward could be to not only show the magnifier when resizing (i.e. 
clicking on a handle) as it is implemented currently, but in addition show the 
magnifier directly attached to the cursor as soon as Shift is hold down, e.g. 
more like KWin's magnifying glass. However, this has a couple of drawbacks: In 
case you checked the checkbox to show the magnifier by default, Shift will 
confusingly trigger hiding the magnifier for clicking, but trigger showing when 
not clicking (because without any click or modifier the magnifier should never 
be shown at all). Next, for resizing by keyboard you'd have to first 
move/resize the selection rectangle, and then reach for the mouse to position 
the magnifier where you want it, and iterate as needed. That's pretty awkward, 
if you ask me.

  @ngraham Feel free to send a follow-up patch if you can get it working in a 
non-confusing way and have a convincing answer to the question where to show 
the magnifier (or rather what to magnify).

  ---

  In D13450#294305 <https://phabricator.kde.org/D13450#294305>, @sharvey wrote:

  > You suggested multiple changes to the `checkBounds` function, all of which 
I understand and agree with. This function caused me the most heartburn and I 
feel uncomfortable attempting to rework it while under a time crunch. 
Unfortunately, this leaves the `0x0px` resize and the "cannot resize when 
expanded to full screen` bugs unresolved.

  Indeed, those are not critical and can be worked on for the RC (although 
that's a huge responsibility, as normally you are not supposed to ship broken 
stuff where the fix is only promised for the future…).

  > (Again, thank you for the code optimization suggestions. They are 
appreciated.)

  Glad you find them useful. It's not always easy to find the correct 
abstractions to get concise, readable and maintainable code, but practice makes 
perfect ;)

INLINE COMMENTS

> EditorRoot.qml:169
> + case Qt.Key_Down:
> + change = checkBounds(0.0, smallChange, "down");
> + selection.height = selection.height + change;

[Alt] + [↓] is broken (should be fast, not slow)

> rkflx wrote in EditorRoot.qml:92
> Insert space after `switch`, please. Repeat for all other occurrences.

Not done, but maybe I should have given you an example. This is how I meant it:

  switch (event.modifiers) {

IOW, this should be consistent with how the spacing works for `if`.

> rkflx wrote in EditorRoot.qml:173
> Insert space after `case`.

Not yet done.

> rkflx wrote in EditorRoot.qml:443-507
> Currently I don't understand what all those changes

D13450: Add arrow keys to move and resize selection rectangle

2018-07-18 Thread Scott Harvey

sharvey added a comment.


  In D13450#294304 <https://phabricator.kde.org/D13450#294304>, @ngraham wrote:
  
  > Yeah, the magnifier shows up while dragging the selection rect (or not, 
depending on whether or not you've holding down [⇧]), but it currently doesn't 
show up when you're using [Alt] to resize the rect using the keyboard arrow 
keys.
  >
  > IMHO, if you have the magnifier turned on in the settings, it should show 
up when you're in "fine tune" mode (holding down both [⇧] and [Alt] and using 
the arrow keys to resize the rect by single pixels), because conceptually, if 
you're doing this, it's because you want a pixel-perfect rect.
  
  
  Let's get @rkflx 's input on this. I'm not sure how easily it will be to 
implement. There's a deadline hanging over our heads.

REPOSITORY
  R166 Spectacle

REVISION DETAIL
  https://phabricator.kde.org/D13450

To: sharvey, rkflx, ngraham, #spectacle, yurchor
Cc: ltoscano, kde-doc-english, abalaji, #spectacle, skadinna

D13450: Add arrow keys to move and resize selection rectangle

2018-07-18 Thread Scott Harvey

sharvey added a comment.

  In D13450#294047 , @rkflx wrote:

  > I still disagree regarding the default speed selection. We determined by 
looking at other apps that [⇧] is the modifier to use, and I argued (in line 
with what I meant when triaging the bug) that for making the rectangle feature 
useful for keyboard users by default the movement should be fast. BTW, this is 
also what KWin is doing, and I see no reason at all why Spectacle should 
deviate from that standard. (See above for even more arguments.) I don't feel 
comfortable approving the current default, sorry.

  Fixed. The default movement - [Arrows] alone - is `largeChange`, and [⇧] + 
[Arrows] is a single pixel move.

  > To summarize, here's what I propose: If we can reach agreement on the 
default and you are fast with the string changes still required, the patch can 
go in for the Beta. Then you have time to work on the other points until the RC 
(at which point we have to decide whether to ship or to revert again, based on 
your progress)

  The help text box has been reformatted to match the prior layout. `Esc` has 
been moved to the bottom of the list. Also, the docbook entry for this patch 
has been rewritten and is hopefully clearer and more consistent.

  ---

  You suggested multiple changes to the `checkBounds` function, all of which I 
understand and agree with. This function caused me the most heartburn and I 
feel uncomfortable attempting to rework it while under a time crunch. 
Unfortunately, this leaves the `0x0px` resize and the "cannot resize when 
expanded to full screen` bugs unresolved.

REPOSITORY
  R166 Spectacle

REVISION DETAIL
  https://phabricator.kde.org/D13450

To: sharvey, rkflx, ngraham, #spectacle, yurchor
Cc: ltoscano, kde-doc-english, abalaji, #spectacle, skadinna

D13450: Add arrow keys to move and resize selection rectangle

2018-07-18 Thread Nathaniel Graham

ngraham added a comment.


  Yeah, the magnifier shows up while dragging the selection rect (or not, 
depending on whether or not you've holding down [⇧]), but it currently doesn't 
show up when you're using [Alt] to resize the rect using the keyboard arrow 
keys.
  
  IMHO, if you have the magnifier turned on in the settings, it should show up 
when you're in "fine tune" mode (holding down both [⇧] and [Alt] and using the 
arrow keys to resize the rect by single pixels), because conceptually, if 
you're doing this, it's because you want a pixel-perfect rect.

REPOSITORY
  R166 Spectacle

REVISION DETAIL
  https://phabricator.kde.org/D13450

To: sharvey, rkflx, ngraham, #spectacle, yurchor
Cc: ltoscano, kde-doc-english, abalaji, #spectacle, skadinna

D13450: Add arrow keys to move and resize selection rectangle

2018-07-18 Thread Scott Harvey

sharvey added a comment.


  In D13450#294291 , @ngraham wrote:
  
  > I'm noticing that the magnifier doesn't er show up while you're using the 
keyboard to resize the selection rect. Might wanna hook that up.
  
  
  It works for me when holding [⇧] and dragging a new rectangle. I'm a little 
fuzzy on how the magnifier is intended to work.
  
  We've already commandeers [⇧] for small adjustments, so that's likely 
overriding the magnifier.
  
  How do we think this should work?

REPOSITORY
  R166 Spectacle

REVISION DETAIL
  https://phabricator.kde.org/D13450

To: sharvey, rkflx, ngraham, #spectacle, yurchor
Cc: ltoscano, kde-doc-english, abalaji, #spectacle, skadinna

D13450: Add arrow keys to move and resize selection rectangle

2018-07-18 Thread Nathaniel Graham

ngraham added a comment.


  I'm noticing that the magnifier doesn't er show up while you're using the 
keyboard to resize the selection rect. Might wanna hook that up.

REPOSITORY
  R166 Spectacle

REVISION DETAIL
  https://phabricator.kde.org/D13450

To: sharvey, rkflx, ngraham, #spectacle, yurchor
Cc: ltoscano, kde-doc-english, abalaji, #spectacle, skadinna

D13450: Add arrow keys to move and resize selection rectangle

2018-07-18 Thread Scott Harvey

sharvey marked 7 inline comments as done.

REPOSITORY
  R166 Spectacle

REVISION DETAIL
  https://phabricator.kde.org/D13450

To: sharvey, rkflx, ngraham, #spectacle, yurchor
Cc: ltoscano, kde-doc-english, abalaji, #spectacle, skadinna

D13450: Add arrow keys to move and resize selection rectangle

2018-07-18 Thread Scott Harvey

sharvey edited the summary of this revision.
sharvey edited the test plan for this revision.

REPOSITORY
  R166 Spectacle

REVISION DETAIL
  https://phabricator.kde.org/D13450

To: sharvey, rkflx, ngraham, #spectacle, yurchor
Cc: ltoscano, kde-doc-english, abalaji, #spectacle, skadinna

D13450: Add arrow keys to move and resize selection rectangle

2018-07-18 Thread Scott Harvey

sharvey marked 9 inline comments as done.
sharvey added inline comments.

INLINE COMMENTS

> rkflx wrote in index.docbook:154
> "Holding the Shift while": Either remove "the", or add "key".
> 
> "using the arrows": Change to "Using the arrow keys"?

Typos and/error sloppy grammar. Rewritten.

REPOSITORY
  R166 Spectacle

REVISION DETAIL
  https://phabricator.kde.org/D13450

To: sharvey, rkflx, ngraham, #spectacle, yurchor
Cc: ltoscano, kde-doc-english, abalaji, #spectacle, skadinna

D13450: Add arrow keys to move and resize selection rectangle

2018-07-18 Thread Scott Harvey

sharvey updated this revision to Diff 38014.
sharvey marked an inline comment as done.
sharvey added a comment.


  - Change default adjustment to `largeChange`, [⇧] uses `smallChange` for fine 
tuning
  - Numerous miscellaneous changes per reviewer comments, including:
- Condensed adjustment calculations to use `+=`
- Reverted help text box to match original layout
- Revised docbook entry for clarity and consistency

REPOSITORY
  R166 Spectacle

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13450?vs=37965=38014

BRANCH
  arcpatch-D13450

REVISION DETAIL
  https://phabricator.kde.org/D13450

AFFECTED FILES
  doc/index.docbook
  src/QuickEditor/EditorRoot.qml

To: sharvey, rkflx, ngraham, #spectacle, yurchor
Cc: ltoscano, kde-doc-english, abalaji, #spectacle, skadinna

D13450: Add arrow keys to move and resize selection rectangle

2018-07-18 Thread Scott Harvey

sharvey added inline comments.

INLINE COMMENTS

> rkflx wrote in EditorRoot.qml:443-507
> Currently I don't understand what all those changes are for and how they 
> relate to the topic of the patch (and I would disagree with some).
> 
> Contrary to @ngraham I'd say this actually is a visual regression.

These are remnants (which will be reverted) from when the help text box was two 
columns wide.

REPOSITORY
  R166 Spectacle

REVISION DETAIL
  https://phabricator.kde.org/D13450

To: sharvey, rkflx, ngraham, #spectacle, yurchor
Cc: ltoscano, kde-doc-english, abalaji, #spectacle, skadinna

D13450: Add arrow keys to move and resize selection rectangle

2018-07-18 Thread Scott Harvey

sharvey added inline comments.

INLINE COMMENTS

> rkflx wrote in EditorRoot.qml:41
> That does not seem right, because this will result in slower movement on a 
> HiDPI screen compared to a regular screen of the same size. (It's needed for 
> the 1px case, of course.)

This was suggested by @abalaji based on his work on reworking the selection 
rectangle. Should it be removed?

REPOSITORY
  R166 Spectacle

REVISION DETAIL
  https://phabricator.kde.org/D13450

To: sharvey, rkflx, ngraham, #spectacle, yurchor
Cc: ltoscano, kde-doc-english, abalaji, #spectacle, skadinna

D13450: Add arrow keys to move and resize selection rectangle

2018-07-17 Thread Scott Harvey

sharvey added a comment.


  In D13450#294047 <https://phabricator.kde.org/D13450#294047>, @rkflx wrote:
  
  > - Selecting with the mouse sets a minimum size, however resizing with the 
arrow keys allows to resize to 0x0px.
  
  
  Where should it stop? 1x1?

REPOSITORY
  R166 Spectacle

REVISION DETAIL
  https://phabricator.kde.org/D13450

To: sharvey, rkflx, ngraham, #spectacle, yurchor
Cc: ltoscano, kde-doc-english, abalaji, #spectacle, skadinna

D13450: Add arrow keys to move and resize selection rectangle

2018-07-17 Thread Scott Harvey

sharvey added a comment.


  I will attempt to get these completed early tomorrow morning (my time). It's 
already the end of the day here and I know (from unfortunate experience) that I 
don't do my best work "after hours".

REPOSITORY
  R166 Spectacle

REVISION DETAIL
  https://phabricator.kde.org/D13450

To: sharvey, rkflx, ngraham, #spectacle, yurchor
Cc: ltoscano, kde-doc-english, abalaji, #spectacle, skadinna

D13450: Add arrow keys to move and resize selection rectangle

2018-07-17 Thread Henrik Fehlauer

rkflx requested changes to this revision.
rkflx added a comment.
This revision now requires changes to proceed.

  @sharvey Thanks for the updates. As always, first I'd like to iterate to get 
the patch working properly, and then I'll look at the code in detail. As I'm 
now put under pressure again to squeeze the patch into 18.08, we'll see how it 
goes (in general rushing leads to bugs, see last Plasma release…). First of all:

  I still disagree regarding the default speed selection. We determined by 
looking at other apps that [⇧] is the modifier to use, and I argued (in line 
with what I meant when triaging the bug) that for making the rectangle feature 
useful for keyboard users by default the movement should be fast. BTW, this is 
also what KWin is doing, and I see no reason at all why Spectacle should 
deviate from that standard. (See above for even more arguments.) I don't feel 
comfortable approving the current default, sorry.

  Apart from that, the patch now works well for the most part, good job (and 
thanks to @abalaji for commenting on some things). In addition to some inline 
comments below, I found those issues:

  - When the rectangle covers the whole screen, I'm unable to resize, i.e. make 
the rectangle smaller again.
  - I'm unable to fine-tune both size and position with HiDPI scaling active 
(see also inline comment for the likely cause).
  - Selecting with the mouse sets a minimum size, however resizing with the 
arrow keys allows to resize to 0x0px.

  ---

  To summarize, here's what I propose: If we can reach agreement on the default 
and you are fast with the string changes still required, the patch can go in 
for the Beta. Then you have time to work on the other points until the RC (at 
which point we have to decide whether to ship or to revert again, based on your 
progress).

  ---

  In D13450#283620 <https://phabricator.kde.org/D13450#283620>, @abalaji wrote:

  > A few thing tho @sharvey, it looks like currently the resize functionality 
only moves the bottom right corner, and I've preserved that. But was wondering 
if we can add in Ctrl or something to control that. Maybe something like:
  >
  > When Alt is pressed down:
  >
  > - We are in "expand" mode by default. Pressing left expands selection on 
the left by moving the left border outwards to the left, etc.
  > - Also holding Ctrl enables a "shrink" mode. Now pressing left shrinks the 
selection from the right by moving the right border inwards, as if we are 
nudging it from the right towards the left, etc.

  I think that's too complicated, and you still need two steps to get to the 
final selection (just like setting one corner by moving and the other corner by 
resizing are two steps too).

INLINE COMMENTS

> index.docbook:154
> +
> +You can use the arrow keys to move and adjust 
> the rectangle. Pressing the arrow keys will slowly move the rectangle. 
> Holding the Shift while using the arrow keys will move the 
> rectangle more quickly. Holding the Alt key while using the 
> arrows will adjust the size of the rectangle. 
> +

"Holding the Shift while": Either remove "the", or add "key".

"using the arrows": Change to "Using the arrow keys"?

> EditorRoot.qml:41
>  property int magOffset: 32;
> +property int largeChange: 15 / Screen.devicePixelRatio;
> +property int smallChange: 1 / Screen.devicePixelRatio

That does not seem right, because this will result in slower movement on a 
HiDPI screen compared to a regular screen of the same size. (It's needed for 
the 1px case, of course.)

> EditorRoot.qml:42
> +property int largeChange: 15 / Screen.devicePixelRatio;
> +property int smallChange: 1 / Screen.devicePixelRatio
>  

That looks suspicious: How will you be able to store the result accurately in 
an `int`?

> EditorRoot.qml:54-57
> + "x":   xx,
> + "y":   yy,
> + "height":  hh,
> + "width":   ww

Unrelated whitespace change, please revert.

> EditorRoot.qml:84
> +
> +var delta;  // valid for either direction
> +

Without the context of the patch in mind, this is a bit hard to understand what 
it is about when you stumble upon this while reading the code.  Could you come 
up with a better name and/or comment?

> EditorRoot.qml:92
> +// nested switches for arrow keys based on modifier keys
> +switch(event.modifiers) {
> +

Insert space after `switch`, please. Repeat for all other occurrences.

> EditorRoot.qml:98
> +delta = checkBounds(-smallChange, 0, "left");
> +selection.x = selection.x + delta;
> +

D13450: Add arrow keys to move and resize selection rectangle

2018-07-17 Thread Nathaniel Graham

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Excellent. @rkflx, any last comments or objections, or shall we push this to 
the 18.08 branch?

REPOSITORY
  R166 Spectacle

BRANCH
  arcpatch-D13450

REVISION DETAIL
  https://phabricator.kde.org/D13450

To: sharvey, rkflx, ngraham, #spectacle, yurchor
Cc: ltoscano, kde-doc-english, abalaji, #spectacle, skadinna

D13450: Add arrow keys to move and resize selection rectangle

2018-07-17 Thread Scott Harvey

sharvey marked 2 inline comments as done.

REPOSITORY
  R166 Spectacle

REVISION DETAIL
  https://phabricator.kde.org/D13450

To: sharvey, rkflx, ngraham, #spectacle, yurchor
Cc: ltoscano, kde-doc-english, abalaji, #spectacle, skadinna

D13450: Add arrow keys to move and resize selection rectangle

2018-07-17 Thread Nathaniel Graham

ngraham added inline comments.

INLINE COMMENTS

> ngraham wrote in index.docbook:154
> Two sentences use the descriptive mood ("Pressing the arrow keys...", 
> "Holding the Alt key..."), while the middle one uses the imperative mood 
> ("Hold down the Shift key..."). We should pick one and be consistent.

Alternatively, we could use the imperative mood for the top-level feature 
description (Press the arrow keys to slowly move the rectangle" and the 
descriptive mood for the possible modifications. Your choice. :)

REPOSITORY
  R166 Spectacle

REVISION DETAIL
  https://phabricator.kde.org/D13450

To: sharvey, rkflx, ngraham, #spectacle, yurchor
Cc: ltoscano, kde-doc-english, abalaji, #spectacle, skadinna

D13450: Add arrow keys to move and resize selection rectangle

2018-07-17 Thread Nathaniel Graham

ngraham added inline comments.

INLINE COMMENTS

> index.docbook:154
> +
> +You can use the arrow keys to move and adjust 
> the rectangle. Pressing the arrow keys will slowly move the rectangle. Hold 
> down the Shift to move in larger increments. Holding the 
> +Alt key while using the arrows will 
> adjust the size of the rectangle. 

Two sentences use the descriptive mood ("Pressing the arrow keys...", "Holding 
the Alt key..."), while the middle one uses the imperative mood ("Hold down the 
Shift key..."). We should pick one and be consistent.

REPOSITORY
  R166 Spectacle

REVISION DETAIL
  https://phabricator.kde.org/D13450

To: sharvey, rkflx, ngraham, #spectacle, yurchor
Cc: ltoscano, kde-doc-english, abalaji, #spectacle, skadinna

D13450: Add arrow keys to move and resize selection rectangle

2018-07-17 Thread Scott Harvey

sharvey added a comment.


  In D13450#293854 , @ltoscano wrote:
  
  > About the date: that's not the release date, but the date where the 
document was last updated.
  
  
  Thanks. I corrected it to today's date.

REPOSITORY
  R166 Spectacle

REVISION DETAIL
  https://phabricator.kde.org/D13450

To: sharvey, rkflx, ngraham, #spectacle, yurchor
Cc: ltoscano, kde-doc-english, abalaji, #spectacle, skadinna

D13450: Add arrow keys to move and resize selection rectangle

2018-07-17 Thread Scott Harvey

sharvey updated this revision to Diff 37964.
sharvey added a comment.


  - Correct revision date in docbook

REPOSITORY
  R166 Spectacle

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13450?vs=37963=37964

BRANCH
  arcpatch-D13450

REVISION DETAIL
  https://phabricator.kde.org/D13450

AFFECTED FILES
  doc/index.docbook
  src/QuickEditor/EditorRoot.qml

To: sharvey, rkflx, ngraham, #spectacle, yurchor
Cc: ltoscano, kde-doc-english, abalaji, #spectacle, skadinna

D13450: Add arrow keys to move and resize selection rectangle

2018-07-17 Thread Luigi Toscano

ltoscano added a comment.


  In D13450#293846 <https://phabricator.kde.org/D13450#293846>, @sharvey wrote:
  
  > In D13450#293781 <https://phabricator.kde.org/D13450#293781>, @ngraham 
wrote:
  >
  > > There's only one remaining thing to do from my perspective: update the 
docbook to document this nice new feature! It would be great if you could do 
that in this patch. Keep in mind that 18.08 has already been branched and the 
freeze is in two days, so if you'd like to get this in for the next release, 
you'll have to work quickly. :)
  >
  >
  > Arrow keys information added. I checked the `.docbook` file with the doc 
tools and it parsed properly and generated correct HTML files.
  >
  > I changed the release tag in the docbook file to 18.08 and set the date to 
2018-08-09 based on the `Applications Tagging` date on the Application Release 
Schedule 
<https://community.kde.org/Schedules/Applications/18.08_Release_Schedule> page. 
That was an educated guess. If it should be something else, just let me know 
and I'll change it.
  
  
  You probably just need checkXML5 to check the document.
  About the date: that's not the release date, but the date where the document 
was last updated.
  The release is the first available release where the change will show.

REPOSITORY
  R166 Spectacle

REVISION DETAIL
  https://phabricator.kde.org/D13450

To: sharvey, rkflx, ngraham, #spectacle, yurchor
Cc: ltoscano, kde-doc-english, abalaji, #spectacle, skadinna

D13450: Add arrow keys to move and resize selection rectangle

2018-07-17 Thread Scott Harvey

sharvey added a comment.


  In D13450#293781 <https://phabricator.kde.org/D13450#293781>, @ngraham wrote:
  
  > There's only one remaining thing to do from my perspective: update the 
docbook to document this nice new feature! It would be great if you could do 
that in this patch. Keep in mind that 18.08 has already been branched and the 
freeze is in two days, so if you'd like to get this in for the next release, 
you'll have to work quickly. :)
  
  
  Arrow keys information added. I checked the `.docbook` file with the doc 
tools and it parsed properly and generated correct HTML files.
  
  I changed the release tag in the docbook file to 18.08 and set the date to 
2018-08-09 based on the `Applications Tagging` date on the Application Release 
Schedule 
<https://community.kde.org/Schedules/Applications/18.08_Release_Schedule> page. 
That was an educated guess. If it should be something else, just let me know 
and I'll change it.

REPOSITORY
  R166 Spectacle

REVISION DETAIL
  https://phabricator.kde.org/D13450

To: sharvey, rkflx, ngraham, #spectacle, yurchor
Cc: kde-doc-english, abalaji, #spectacle, skadinna

D13450: Add arrow keys to move and resize selection rectangle

2018-07-17 Thread Yuri Chornoivan

yurchor accepted this revision.

REPOSITORY
  R166 Spectacle

REVISION DETAIL
  https://phabricator.kde.org/D13450

To: sharvey, rkflx, ngraham, #spectacle, yurchor
Cc: kde-doc-english, abalaji, #spectacle, skadinna

D13450: Add arrow keys to move and resize selection rectangle

2018-07-17 Thread Scott Harvey

sharvey updated this revision to Diff 37963.
sharvey added a comment.
Restricted Application added a project: Documentation.
Restricted Application added a subscriber: kde-doc-english.


  - Edit docbook to include arrow key usage; update release number and date

REPOSITORY
  R166 Spectacle

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13450?vs=37944=37963

BRANCH
  arcpatch-D13450

REVISION DETAIL
  https://phabricator.kde.org/D13450

AFFECTED FILES
  doc/index.docbook
  src/QuickEditor/EditorRoot.qml

To: sharvey, rkflx, ngraham, #spectacle
Cc: kde-doc-english, abalaji, #spectacle, skadinna

[plasma-desktop/Plasma/5.12] doc/kcontrol/keys: Update keys docbook to 5.12

2018-05-30 Thread Burkhard Lück

Git commit b35d8880cdf90f445c5242ca78cf4453286cb1f5 by Burkhard Lück.
Committed on 30/05/2018 at 10:13.
Pushed by lueck into branch 'Plasma/5.12'.

Update keys docbook to 5.12

proofread + update
bump date + releseinfo
add a para about adding components from https://phabricator.kde.org/D2111

Differential Revision: https://phabricator.kde.org/D11690

(cherry picked from commit 4edcfeb171f3d32fdbb869855112ee7913ab00c2)

backport to 5.12 LTS

M  +8-2doc/kcontrol/keys/index.docbook

https://commits.kde.org/plasma-desktop/b35d8880cdf90f445c5242ca78cf4453286cb1f5

diff --git a/doc/kcontrol/keys/index.docbook b/doc/kcontrol/keys/index.docbook
index 0ea336af..ece08ade 100644
--- a/doc/kcontrol/keys/index.docbook
+++ b/doc/kcontrol/keys/index.docbook
@@ -14,8 +14,8 @@
 
 
 
-2016-09-17
-Plasma 5.8
+2018-03-25
+Plasma 5.12
 
 
 Plasma
@@ -95,6 +95,12 @@ Shortcuts tab.
 or 
 to add or remove a component.
 
+
+Adding a component opens a dialog to pick applications from the start 
menu structure to
+add launchers to be usable as shortcuts.
+If an application has jumplist options they will be available as actions.
+
+
 Click the File drop down box at the right to 
import/export a 
 Scheme, set all shortcuts to none.
 Global shortcuts can now be configured to jump to specific tasks within 
an application.

[plasma-desktop] doc/kcontrol/keys: Update keys docbook to 5.12

2018-03-30 Thread Burkhard Lück

Git commit 4edcfeb171f3d32fdbb869855112ee7913ab00c2 by Burkhard Lück.
Committed on 30/03/2018 at 12:15.
Pushed by lueck into branch 'master'.

Update keys docbook to 5.12

proofread + update
bump date + releseinfo
add a para about adding components from https://phabricator.kde.org/D2111

Differential Revision: https://phabricator.kde.org/D11690

M  +8-2doc/kcontrol/keys/index.docbook

https://commits.kde.org/plasma-desktop/4edcfeb171f3d32fdbb869855112ee7913ab00c2

diff --git a/doc/kcontrol/keys/index.docbook b/doc/kcontrol/keys/index.docbook
index 0ea336af..ece08ade 100644
--- a/doc/kcontrol/keys/index.docbook
+++ b/doc/kcontrol/keys/index.docbook
@@ -14,8 +14,8 @@
 
 
 
-2016-09-17
-Plasma 5.8
+2018-03-25
+Plasma 5.12
 
 
 Plasma
@@ -95,6 +95,12 @@ Shortcuts tab.
 or 
 to add or remove a component.
 
+
+Adding a component opens a dialog to pick applications from the start 
menu structure to
+add launchers to be usable as shortcuts.
+If an application has jumplist options they will be available as actions.
+
+
 Click the File drop down box at the right to 
import/export a 
 Scheme, set all shortcuts to none.
 Global shortcuts can now be configured to jump to specific tasks within 
an application.

D11690: Update keys docbook to 5.12

2018-03-30 Thread Burkhard Lück

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:4edcfeb171f3: Update keys docbook to 5.12 (authored by 
lueck).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11690?vs=30523=30922

REVISION DETAIL
  https://phabricator.kde.org/D11690

AFFECTED FILES
  doc/kcontrol/keys/index.docbook

To: lueck, #plasma, #documentation, mart
Cc: plasma-devel, kde-doc-english, ragreen, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11690: Update keys docbook to 5.12

2018-03-30 Thread Marco Martin

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11690

To: lueck, #plasma, #documentation, mart
Cc: plasma-devel, kde-doc-english, ragreen, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11690: Update keys docbook to 5.12

2018-03-25 Thread Burkhard Lück

lueck retitled this revision from "Update mouse docbook to 5.12" to "Update 
keys docbook to 5.12".

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11690

To: lueck, #plasma, #documentation
Cc: plasma-devel, kde-doc-english, ragreen, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

[kmymoney/5.0] kmymoney: Allow to select keys during File/Save As

2018-02-16 Thread Thomas Baumgart

Git commit 03831143604ffb5f49267fc5dfdde97bb7059866 by Thomas Baumgart.
Committed on 16/02/2018 at 19:19.
Pushed by tbaumgart into branch '5.0'.

Allow to select keys during File/Save As

Due to the change in the KDE file save dialog the additional widgets
could not be inserted dynamically into the dialog as we did in KDE4.
This has been solved by an additional dialog when GPG encryption has
been enabled in the settings and is available.

BUG: 390467
FIXED-IN: 5.0.1
GUI:

M  +1-0kmymoney/dialogs/CMakeLists.txt
M  +77   -88   kmymoney/dialogs/kgpgkeyselectiondlg.cpp
M  +15   -3kmymoney/dialogs/kgpgkeyselectiondlg.h
A  +139  -0kmymoney/dialogs/kgpgkeyselectiondlg.ui
M  +19   -89   kmymoney/kmymoney.cpp
M  +1-6kmymoney/kmymoney.h

https://commits.kde.org/kmymoney/03831143604ffb5f49267fc5dfdde97bb7059866

diff --git a/kmymoney/dialogs/CMakeLists.txt b/kmymoney/dialogs/CMakeLists.txt
index 043f00c9..9726a1a5 100644
--- a/kmymoney/dialogs/CMakeLists.txt
+++ b/kmymoney/dialogs/CMakeLists.txt
@@ -64,6 +64,7 @@ set(dialogs_UI
   kenterscheduledlg.ui
   kequitypriceupdatedlg.ui kequitypriceupdateconfdlg.ui
   kfindtransactiondlg.ui kgeneratesqldlg.ui
+  kgpgkeyselectiondlg.ui
   kloadtemplatedlg.ui
   kmymoneyfileinfodlg.ui kmymoneypricedlg.ui
   knewaccountdlg.ui knewbankdlg.ui knewbudgetdlg.ui
diff --git a/kmymoney/dialogs/kgpgkeyselectiondlg.cpp 
b/kmymoney/dialogs/kgpgkeyselectiondlg.cpp
index ca15228e..34e820bb 100644
--- a/kmymoney/dialogs/kgpgkeyselectiondlg.cpp
+++ b/kmymoney/dialogs/kgpgkeyselectiondlg.cpp
@@ -19,25 +19,17 @@
 
 // 
 // QT Includes
-
-#include 
-#include 
-#include 
-#include 
+#include 
+#include 
 
 // 
 // KDE Includes
 
-#include 
-#include 
-#include 
-
 // 
 // Project Includes
 
 #include 
-#include 
-#include 
+#include 
 
 class KGpgKeySelectionDlgPrivate
 {
@@ -45,6 +37,10 @@ class KGpgKeySelectionDlgPrivate
 
 public:
   KGpgKeySelectionDlgPrivate()
+  : ui(new Ui::KGpgKeySelectionDlg)
+  , needCheckList(true)
+  , listOk(false)
+  , checkCount(0)
   {
   }
 
@@ -52,11 +48,10 @@ public:
   {
   }
 
-  KEditListWidget*   m_listWidget;
-  KLed*   m_keyLed;
-  boolm_needCheckList;
-  boolm_listOk;
-  int m_checkCount;
+  Ui::KGpgKeySelectionDlg*  ui;
+  bool  needCheckList;
+  bool  listOk;
+  int   checkCount;
 };
 
 
@@ -65,57 +60,11 @@ KGpgKeySelectionDlg::KGpgKeySelectionDlg(QWidget *parent) :
 d_ptr(new KGpgKeySelectionDlgPrivate)
 {
   Q_D(KGpgKeySelectionDlg);
-  d->m_needCheckList = true;
-  d->m_listOk = false;
-  d->m_checkCount = 0;
-  // TODO: check port to kf5
-  setWindowTitle(i18n("Select additional keys"));
-  QDialogButtonBox *buttonBox = new 
QDialogButtonBox(QDialogButtonBox::Ok|QDialogButtonBox::Cancel);
-  QWidget *mainWidget = new QWidget(this);
-  QVBoxLayout *mainLayout = new QVBoxLayout;
-  setLayout(mainLayout);
-  mainLayout->addWidget(mainWidget);
-  QPushButton *okButton = buttonBox->button(QDialogButtonBox::Ok);
-  okButton->setDefault(true);
-  okButton->setShortcut(Qt::CTRL | Qt::Key_Return);
-  connect(buttonBox, ::accepted, this, ::accept);
-  connect(buttonBox, ::rejected, this, ::reject);
-  buttonBox->button(QDialogButtonBox::Ok)->setDefault(true);
-  setModal(true);
-  QWidget* page = new QWidget(this);
-  mainLayout->addWidget(page);
-  mainLayout->addWidget(buttonBox);
-
-  QGroupBox *listBox = new QGroupBox(i18n("User identification"), page);
-  QVBoxLayout *verticalLayout = new QVBoxLayout(listBox);
-  verticalLayout->setSpacing(6);
-  verticalLayout->setContentsMargins(0, 0, 0, 0);
-  d->m_listWidget = new KEditListWidget(listBox);
-  d->m_listWidget->connect(buttonBox, ::accepted, this, 
::accept);
-  d->m_listWidget->connect(buttonBox, ::rejected, this, 
::reject);
-  d->m_listWidget->setWhatsThis(i18n("Enter the id of the key you want to use 
for data encryption. This can either be an e-mail address or the hexadecimal 
key id. In case of the key id, do not forget the leading 0x."));
-  verticalLayout->addWidget(d->m_listWidget);
-
-  // add a LED for the availability of all keys
-  QHBoxLayout* ledBox = new QHBoxLayout();
-  ledBox->setContentsMargins(0, 0, 0, 0);
-  ledBox->setSpacing(6);
-  ledBox->setObjectName("ledBoxLayout");
-
-  d->m_keyLed = new KLed(page);
-  mainLayout->addWidget(d->m_keyLed);
-  d->m_keyLed->setShape(KLed::Circular);
-  d->m_keyLed->setLook(KLed::Sunken);
-
-  ledBox->addWidget(d->m_keyLed);
-  ledBox->addWidget(new QLabel(i18n("Keys for all of the above user ids 
found"), page));
-  ledBox->ad

[kruler] doc: D6285 New Alt+Arrow keys shortcuts for KRuler

2017-07-02 Thread Aurélien Gâteau

Git commit c0426f7df330469416abcdc081474e304885aea4 by Aurélien Gâteau.
Committed on 02/07/2017 at 07:58.
Pushed by gateau into branch 'master'.

D6285 New Alt+Arrow keys shortcuts for KRuler

M  +11   -0doc/index.docbook

https://commits.kde.org/kruler/c0426f7df330469416abcdc081474e304885aea4

Re: Keys

2016-12-01 Thread Yuri Chornoivan

п'ятниця, 02-гру-2016 07:33:27 frankb022...@yahoo.com написано:
>  Maybe this is the wrong place for this but perhaps you can direct me for
> help. I have repeated the processes several times but I can't find my
> backed up "keys" for the life of me. I have saved them to documents and
> places from that little browser like bin, and up and down the line and when
> I open these places nothing is there.

Hi,

I might be wrong, but it is possible that you are talking about folder views:

https://userbase.kde.org/Plasma#Folder_Views

or the yellow notes widget:

https://userbase.kde.org/KNotes

The Folder views are just like windows to your file system, so nothing should 
be lost. Your files are in their folders. If indexing is enabled then you can 
easily find them by pressing Alt+F2 then typing some keywords.

On the other hand, the content of notes is lost as soon as the sticky note 
widget is closed.

This mailing list is for documentation writers so your question is slightly off 
topic here. Please use support channels:

https://userbase.kde.org/Getting_Help

Hope this helps.

Best regards,
Yuri

Keys

2016-12-01 Thread frankb022000

 Maybe this is the wrong place for this but perhaps you can direct me for help. 
I have repeated the processes several times but I can't find my backed up 
"keys" for the life of me. I have saved them to documents and places from that 
little browser like bin, and up and down the line and when I open these places 
nothing is there.

[plasma-desktop] doc/kcontrol/keys: Update shortcuts kcm docbook

2016-09-21 Thread Burkhard Lück

Git commit 6c3de2f1ffaf681533e4c624c11581702ce601ff by Burkhard Lück.
Committed on 21/09/2016 at 10:11.
Pushed by lueck into branch 'master'.

Update shortcuts kcm docbook

adapt to changes in 5.8
Resort para in section key-bindings-global
REVIEW:128948

M  +21   -80   doc/kcontrol/keys/index.docbook
A  +---doc/kcontrol/keys/list-add.png
A  +---doc/kcontrol/keys/remove.png

http://commits.kde.org/plasma-desktop/6c3de2f1ffaf681533e4c624c11581702ce601ff

diff --git a/doc/kcontrol/keys/index.docbook b/doc/kcontrol/keys/index.docbook
index 27eab50..0ea336a 100644
--- a/doc/kcontrol/keys/index.docbook
+++ b/doc/kcontrol/keys/index.docbook
@@ -14,11 +14,11 @@
 
 
 
-2015-04-08
-Plasma 5.3
+2016-09-17
+Plasma 5.8
 
 
-KDE
+Plasma
 KControl
 key bindings
 bindings
@@ -32,7 +32,7 @@
  
 Introduction 
 
-While most of the functionality offered by  can be accessed
+While most of the functionality offered by  can be accessed
 using a simple point and click interface, many people
 prefer using the keyboard for some tasks.  Pressing something like
  F is often
@@ -41,7 +41,7 @@ opening the Edit menu and selecting
 Find.
 
  As different people have different preferences about keyboard
-shortcuts,  offers full customization of key
+shortcuts,  offers full customization of key
 bindings. A key binding or shortcut is a combination of an
 action with a key or a combination of keys.
 
@@ -56,7 +56,7 @@ Actually, in a certain way standard or application shortcuts 
are
 difference is:
 
 
-Standard keyboard shortcuts refer to actions
+Standard shortcuts refer to actions
 that are often available in applications, such as Save, Print, Copy
  
 Global shortcuts are shortcuts for
@@ -72,29 +72,35 @@ for which you have to customize key bindings using the 
application's
 key bindings dialog.
 
 
-Standard Keyboard Shortcuts page
+Standard Shortcuts page
 At the top of this dialog you see an input box, where you can
 search interactively for shortcut names ( Copy) or combination of keys 
 ( Ctrl+C) by typing them literally 
here.
 Below the search box you can see a list of key bindings,  
associations between actions 
-( Copy) shown in the Actions column and keys or 
combination of keys 
+( Copy) shown in the Action column and keys or 
combination of keys 
 ( C ) shown in 
the 
 Shortcut or Alternate column.
 
-
 
 
 
 Global Shortcuts page
-At the top of this page is a drop down box which allows you
-to select a KDE component like KWin, Plasma Desktop 
+At the left of this page is a list box which allows you
+to select a Component like KWin, Plasma Desktop 
 The defined shortcuts for the selected component are displayed in the 
-Action and Global column in the list 
view. 
-Click the File drop down box at the right to 
import/export a 
-Scheme, set all shortcuts to none and remove a component.
-This page has the same search box as the Standard Keyboard 
+Action and Global column in the list 
view.
+This page has the same search box as the Standard 
 Shortcuts tab.
+Use 
+or 
+to add or remove a component.
+
+Click the File drop down box at the right to 
import/export a 
+Scheme, set all shortcuts to none.
+Global shortcuts can now be configured to jump to specific tasks within 
an application.
 
+By default you can open the application menu by just pressing the 
Meta key.
+
 
 
 
@@ -131,71 +137,6 @@ allows to edit the second shortcut for the 
action.
 
 
 
-
-
 
 
 
diff --git a/doc/kcontrol/keys/list-add.png b/doc/kcontrol/keys/list-add.png
new file mode 100644
index 000..e06ff25
Binary files /dev/null and b/doc/kcontrol/keys/list-add.png differ
diff --git a/doc/kcontrol/keys/remove.png b/doc/kcontrol/keys/remove.png
new file mode 100644
index 000..762f0b2
Binary files /dev/null and b/doc/kcontrol/keys/remove.png differ

Re: [kde-doc-english] Review Request 127730: Add commonly used entities for keys to en/user.entities

2016-06-05 Thread Burkhard Lück


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127730/
---

(Updated Juni 6, 2016, 4:47 vorm.)


Status
--

This change has been marked as submitted.


Review request for Documentation and Localization and Translation (l10n).


Repository: kdoctools


Description
---

Del 25 x in l10n-kf5/documentation
Ins 13 x in l10n-kf5/documentation


Diffs
-

  src/customization/en/user.entities de68e30 

Diff: https://git.reviewboard.kde.org/r/127730/diff/


Testing
---


Thanks,

Burkhard Lück

___
kde-doc-english mailing list
kde-doc-english@kde.org
https://mail.kde.org/mailman/listinfo/kde-doc-english

Re: [kde-doc-english] Review Request 127730: Add commonly used entities for keys to en/user.entities

2016-06-05 Thread Luigi Toscano

> On Mag. 26, 2016, 10:33 p.m., Burkhard Lück wrote:
> > any objections to commit?

No objections; just remember to not use those entities when a module does not 
depend on the version of KDocTools that define them. This most likely means 
that we can't use them for everything that does not require Frameworks 5.24. As 
a temporary measure we can define the entities in document itself until the 
proper dependencies is in place (raising the general requirement of a module 
just for this specific documentation issue is not an option.

- Luigi

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127730/#review95886
---

On Mag. 6, 2016, 9:11 a.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127730/
> ---
> 
> (Updated Mag. 6, 2016, 9:11 a.m.)
> 
> 
> Review request for Documentation and Localization and Translation (l10n).
> 
> 
> Repository: kdoctools
> 
> 
> Description
> ---
> 
> Del 25 x in l10n-kf5/documentation
> Ins 13 x in l10n-kf5/documentation
> 
> 
> Diffs
> -
> 
>   src/customization/en/user.entities de68e30 
> 
> Diff: https://git.reviewboard.kde.org/r/127730/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

___
kde-doc-english mailing list
kde-doc-english@kde.org
https://mail.kde.org/mailman/listinfo/kde-doc-english

Re: [kde-doc-english] Review Request 127730: Add commonly used entities for keys to en/user.entities

2016-05-26 Thread Burkhard Lück


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127730/#review95886
---



any objections to commit?

- Burkhard Lück


On Mai 6, 2016, 7:11 vorm., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127730/
> ---
> 
> (Updated Mai 6, 2016, 7:11 vorm.)
> 
> 
> Review request for Documentation and Localization and Translation (l10n).
> 
> 
> Repository: kdoctools
> 
> 
> Description
> ---
> 
> Del 25 x in l10n-kf5/documentation
> Ins 13 x in l10n-kf5/documentation
> 
> 
> Diffs
> -
> 
>   src/customization/en/user.entities de68e30 
> 
> Diff: https://git.reviewboard.kde.org/r/127730/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

___
kde-doc-english mailing list
kde-doc-english@kde.org
https://mail.kde.org/mailman/listinfo/kde-doc-english

Re: [kde-doc-english] Review Request 127730: Add commonly used entities for keys to en/user.entities

2016-05-16 Thread Burkhard Lück


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127730/#review95513
---



@translators:
keep in mind you need to add these new entities to [yourlang]/user.entities

- Burkhard Lück


On Mai 6, 2016, 7:11 vorm., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127730/
> ---
> 
> (Updated Mai 6, 2016, 7:11 vorm.)
> 
> 
> Review request for Documentation and Localization and Translation (l10n).
> 
> 
> Repository: kdoctools
> 
> 
> Description
> ---
> 
> Del 25 x in l10n-kf5/documentation
> Ins 13 x in l10n-kf5/documentation
> 
> 
> Diffs
> -
> 
>   src/customization/en/user.entities de68e30 
> 
> Diff: https://git.reviewboard.kde.org/r/127730/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

___
kde-doc-english mailing list
kde-doc-english@kde.org
https://mail.kde.org/mailman/listinfo/kde-doc-english

Re: [kde-doc-english] Review Request 127730: Add commonly used entities for keys to en/user.entities

2016-05-09 Thread Frederik Schwarzer



> On May 8, 2016, 7:27 p.m., Frederik Schwarzer wrote:
> > src/customization/en/user.entities, lines 11-19
> > 
> >
> > On ANSI and US keyboards, Backspace and Enter is actually printed on 
> > the key, so keycap might be the better choice here?
> 
> Burkhard Lück wrote:
> Afaik US keyboards have the text Backspace + arrow left and Enter + arrow 
> down left, see https://en.wikipedia.org/wiki/File:Unicomp_keyboard.jpg
> On all german keyboards I've seen the Backspace key has no text only an 
> arrow left and the Enter key only an arrow down left.
> Therefore from my pov keysym markup is is appropriate here.

Albeit being German, I did not take German keyboards into account. :)
>From the US-layout perspective however, the situation is that most keyboards 
>have both name and sign and some keyboards have the words only. An example for 
>the latter would be my laptop keyboard, which comes with a 2 years old laptop.
[...]
Now, after searching on google a bit more, I also found some US layout 
keyboards with the sign only.
So none of keycap or keysym is exactly right for all keyboards. So I'll leave 
this change it to your judgement.


- Frederik


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127730/#review95282
---


On May 6, 2016, 7:11 a.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127730/
> ---
> 
> (Updated May 6, 2016, 7:11 a.m.)
> 
> 
> Review request for Documentation and Localization and Translation (l10n).
> 
> 
> Repository: kdoctools
> 
> 
> Description
> ---
> 
> Del 25 x in l10n-kf5/documentation
> Ins 13 x in l10n-kf5/documentation
> 
> 
> Diffs
> -
> 
>   src/customization/en/user.entities de68e30 
> 
> Diff: https://git.reviewboard.kde.org/r/127730/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

___
kde-doc-english mailing list
kde-doc-english@kde.org
https://mail.kde.org/mailman/listinfo/kde-doc-english

Re: [kde-doc-english] Review Request 127730: Add commonly used entities for keys to en/user.entities

2016-05-08 Thread Freek de Kruijf

Op zondag 8 mei 2016 19:43:58 schreef Burkhard Lück:
> > On Mai 8, 2016, 7:27 nachm., Frederik Schwarzer wrote:
> > > src/customization/en/user.entities, lines 11-19
> > > <https://git.reviewboard.kde.org/r/127730/diff/3/?file=464404#file464404
> > > line11>> > 
> > > On ANSI and US keyboards, Backspace and Enter is actually printed on
> > > the key, so keycap might be the better choice here?
> Afaik US keyboards have the text Backspace + arrow left and Enter + arrow
> down left, see https://en.wikipedia.org/wiki/File:Unicomp_keyboard.jpg On
> all german keyboards I've seen the Backspace key has no text only an arrow
> left and the Enter key only an arrow down left. Therefore from my pov
> keysym markup is is appropriate here.
> 
> 
> - Burkhard

Keyboards used in The Netherlands and the Dutch speaking part of Belgium are 
mainly US keyboards, which are not always the same with respect to symbols or 
text on the keys. So normally Dutch translators do not define new entities for 
keys on the keyboard.

-- 
fr.gr.

Freek de Kruijf

___
kde-doc-english mailing list
kde-doc-english@kde.org
https://mail.kde.org/mailman/listinfo/kde-doc-english

Re: [kde-doc-english] Review Request 127730: Add commonly used entities for keys to en/user.entities

2016-05-08 Thread Burkhard Lück



> On Mai 8, 2016, 7:27 nachm., Frederik Schwarzer wrote:
> > src/customization/en/user.entities, lines 11-19
> > 
> >
> > On ANSI and US keyboards, Backspace and Enter is actually printed on 
> > the key, so keycap might be the better choice here?

Afaik US keyboards have the text Backspace + arrow left and Enter + arrow down 
left, see https://en.wikipedia.org/wiki/File:Unicomp_keyboard.jpg
On all german keyboards I've seen the Backspace key has no text only an arrow 
left and the Enter key only an arrow down left.
Therefore from my pov keysym markup is is appropriate here.


- Burkhard


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127730/#review95282
---


On Mai 6, 2016, 7:11 vorm., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127730/
> ---
> 
> (Updated Mai 6, 2016, 7:11 vorm.)
> 
> 
> Review request for Documentation and Localization and Translation (l10n).
> 
> 
> Repository: kdoctools
> 
> 
> Description
> ---
> 
> Del 25 x in l10n-kf5/documentation
> Ins 13 x in l10n-kf5/documentation
> 
> 
> Diffs
> -
> 
>   src/customization/en/user.entities de68e30 
> 
> Diff: https://git.reviewboard.kde.org/r/127730/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

___
kde-doc-english mailing list
kde-doc-english@kde.org
https://mail.kde.org/mailman/listinfo/kde-doc-english

Re: [kde-doc-english] Review Request 127730: Add commonly used entities for keys to en/user.entities

2016-05-08 Thread Frederik Schwarzer


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127730/#review95282
---




src/customization/en/user.entities (lines 11 - 19)


On ANSI and US keyboards, Backspace and Enter is actually printed on the 
key, so keycap might be the better choice here?


- Frederik Schwarzer


On May 6, 2016, 7:11 a.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127730/
> ---
> 
> (Updated May 6, 2016, 7:11 a.m.)
> 
> 
> Review request for Documentation and Localization and Translation (l10n).
> 
> 
> Repository: kdoctools
> 
> 
> Description
> ---
> 
> Del 25 x in l10n-kf5/documentation
> Ins 13 x in l10n-kf5/documentation
> 
> 
> Diffs
> -
> 
>   src/customization/en/user.entities de68e30 
> 
> Diff: https://git.reviewboard.kde.org/r/127730/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

___
kde-doc-english mailing list
kde-doc-english@kde.org
https://mail.kde.org/mailman/listinfo/kde-doc-english

Re: [kde-doc-english] Review Request 127730: Add commonly used entities for keys to en/user.entities

2016-05-08 Thread Burkhard Lück


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127730/#review95281
---



translators @kde-i18n-doc, any comment?

- Burkhard Lück


On Mai 6, 2016, 7:11 vorm., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127730/
> ---
> 
> (Updated Mai 6, 2016, 7:11 vorm.)
> 
> 
> Review request for Documentation and Localization and Translation (l10n).
> 
> 
> Repository: kdoctools
> 
> 
> Description
> ---
> 
> Del 25 x in l10n-kf5/documentation
> Ins 13 x in l10n-kf5/documentation
> 
> 
> Diffs
> -
> 
>   src/customization/en/user.entities de68e30 
> 
> Diff: https://git.reviewboard.kde.org/r/127730/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

___
kde-doc-english mailing list
kde-doc-english@kde.org
https://mail.kde.org/mailman/listinfo/kde-doc-english

Re: [kde-doc-english] Review Request 127730: Add commonly used entities for keys to en/user.entities

2016-05-06 Thread Burkhard Lück


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127730/
---

(Updated Mai 6, 2016, 7:11 vorm.)


Review request for Documentation and Localization and Translation (l10n).


Changes
---

add accidentally removed entity plasmapa again


Repository: kdoctools


Description
---

Del 25 x in l10n-kf5/documentation
Ins 13 x in l10n-kf5/documentation


Diffs (updated)
-

  src/customization/en/user.entities de68e30 

Diff: https://git.reviewboard.kde.org/r/127730/diff/


Testing
---


Thanks,

Burkhard Lück

___
kde-doc-english mailing list
kde-doc-english@kde.org
https://mail.kde.org/mailman/listinfo/kde-doc-english

Re: [kde-doc-english] Review Request 127730: Add commonly used entities for keys to en/user.entities

2016-05-06 Thread Burkhard Lück



> On Mai 5, 2016, 9:42 nachm., Luigi Toscano wrote:
> > I think you removed .
> > 
> > No objections on this (let's hear others), just remember we should wait a 
> > bit to use them (or we will force a dependency on the version of frameworks 
> > where they are introduced).

You are right with plasmapa, will readd it.

But when it is save to use them without forcing a dependency on the version of 
frameworks where these entities are introduced?

workspace/plasma: only 13 repos of 45 with a KF5_MIN_VERSION in the range from 
5.5.0 to 5.20.0

applications: only 33 repos of 147 kf5 based repos with a KF5_MIN_VERSION in 
the range from 5.0.0 to 5.18.0


- Burkhard


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127730/#review95218
---


On Mai 5, 2016, 12:08 nachm., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127730/
> ---
> 
> (Updated Mai 5, 2016, 12:08 nachm.)
> 
> 
> Review request for Documentation and Localization and Translation (l10n).
> 
> 
> Repository: kdoctools
> 
> 
> Description
> ---
> 
> Del 25 x in l10n-kf5/documentation
> Ins 13 x in l10n-kf5/documentation
> 
> 
> Diffs
> -
> 
>   src/customization/en/user.entities de68e30 
> 
> Diff: https://git.reviewboard.kde.org/r/127730/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

___
kde-doc-english mailing list
kde-doc-english@kde.org
https://mail.kde.org/mailman/listinfo/kde-doc-english

Re: [kde-doc-english] Review Request 127730: Add commonly used entities for keys to en/user.entities

2016-05-05 Thread Luigi Toscano


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127730/#review95218
---



I think you removed .

No objections on this (let's hear others), just remember we should wait a bit 
to use them (or we will force a dependency on the version of frameworks where 
they are introduced).

- Luigi Toscano


On Mag. 5, 2016, 2:08 p.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127730/
> ---
> 
> (Updated Mag. 5, 2016, 2:08 p.m.)
> 
> 
> Review request for Documentation and Localization and Translation (l10n).
> 
> 
> Repository: kdoctools
> 
> 
> Description
> ---
> 
> Del 25 x in l10n-kf5/documentation
> Ins 13 x in l10n-kf5/documentation
> 
> 
> Diffs
> -
> 
>   src/customization/en/user.entities de68e30 
> 
> Diff: https://git.reviewboard.kde.org/r/127730/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

___
kde-doc-english mailing list
kde-doc-english@kde.org
https://mail.kde.org/mailman/listinfo/kde-doc-english

Re: [kde-doc-english] Review Request 127730: Add commonly used entities for keys to en/user.entities

2016-05-05 Thread Burkhard Lück


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127730/
---

(Updated Mai 5, 2016, 12:08 nachm.)


Review request for Documentation and Localization and Translation (l10n).


Changes
---

add more commonly used entities for keys

makes docs consistent
easy and consistent to translate with Ctrl+T

add translators as their work is affected as well


Summary (updated)
-

Add commonly used entities for keys to en/user.entities


Repository: kdoctools


Description
---

Del 25 x in l10n-kf5/documentation
Ins 13 x in l10n-kf5/documentation


Diffs (updated)
-

  src/customization/en/user.entities de68e30 

Diff: https://git.reviewboard.kde.org/r/127730/diff/


Testing
---


Thanks,

Burkhard Lück

___
kde-doc-english mailing list
kde-doc-english@kde.org
https://mail.kde.org/mailman/listinfo/kde-doc-english

Re: [kde-doc-english] Review Request 127730: Add keys Del + Ins to en/user.entities

2016-04-23 Thread Burkhard Lück


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127730/#review94793
---



Some more Numbers for other often used keycap/keysy we do not have in 
en/user.entities:

trunk l10n-kf5/documentation
PageUp / PgUp 4x + 15x
PageDown / PgDn 6x + 15x

Cursor keys
Up 25 x
Down 21x
Left 30x
Right 29x

Home 26x
End 18x

Num, PrrScr/PrintScreen and others (Meta?)

- Burkhard Lück


On April 23, 2016, 6:35 nachm., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127730/
> ---
> 
> (Updated April 23, 2016, 6:35 nachm.)
> 
> 
> Review request for Documentation.
> 
> 
> Repository: kdoctools
> 
> 
> Description
> ---
> 
> Del 25 x in l10n-kf5/documentation
> Ins 13 x in l10n-kf5/documentation
> 
> 
> Diffs
> -
> 
>   src/customization/en/user.entities de68e30 
> 
> Diff: https://git.reviewboard.kde.org/r/127730/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

___
kde-doc-english mailing list
kde-doc-english@kde.org
https://mail.kde.org/mailman/listinfo/kde-doc-english

[kde-doc-english] Review Request 127730: Add keys Del + Ins to en/user.entities

2016-04-23 Thread Burkhard Lück


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127730/
---

Review request for Documentation.


Repository: kdoctools


Description
---

Del 25 x in l10n-kf5/documentation
Ins 13 x in l10n-kf5/documentation


Diffs
-

  src/customization/en/user.entities de68e30 

Diff: https://git.reviewboard.kde.org/r/127730/diff/


Testing
---


Thanks,

Burkhard Lück

___
kde-doc-english mailing list
kde-doc-english@kde.org
https://mail.kde.org/mailman/listinfo/kde-doc-english

[kde-doc-english] [plasma-desktop] doc/kcontrol/keys: check + bump version

2015-04-08 Thread Burkhard Lück

Git commit 0b5244d1f838bc382124cc170ee31d45f4eed4c4 by Burkhard LÃ¼ck.
Committed on 08/04/2015 at 21:01.
Pushed by lueck into branch 'master'.

check + bump version

M  +2-2doc/kcontrol/keys/index.docbook

http://commits.kde.org/plasma-desktop/0b5244d1f838bc382124cc170ee31d45f4eed4c4

diff --git a/doc/kcontrol/keys/index.docbook b/doc/kcontrol/keys/index.docbook
index f634c93..242e8ce 100644
--- a/doc/kcontrol/keys/index.docbook
+++ b/doc/kcontrol/keys/index.docbook
@@ -14,8 +14,8 @@
 !-- TRANS:ROLES_OF_TRANSLATORS --
 /authorgroup
 
-date2013-12-05/date
-releaseinfokde; 4.12/releaseinfo
+date2015-04-08/date
+releaseinfoPlasma 5.3/releaseinfo
 
 keywordset
 keywordKDE/keyword

[kde-doc-english] Way to backup my Kleopatra keys

2013-11-08 Thread Philipp Schaumann

Hi,

 

I have imported a number of keys into Kleopatra, but I have not found some
option to specify where Kleopatra stores its database so that I can do a
backup / export all, or similar. I have looked through the documentation but
did not find something.

 

B.R.

Philipp Schaumann 

http://sicherheitskultur.at/

 

mein ?ffentlicher PGP/GnuPG Schl?ssel liegt auf

http://sicherheitskultur.at/Newsletter/Pub_key.htm 

 

-- next part --
An HTML attachment was scrubbed...
URL: 
http://mail.kde.org/pipermail/kde-doc-english/attachments/20131108/b242811c/attachment.html

[kde-doc-english] Way to backup my Kleopatra keys

2013-11-08 Thread Yuri Chornoivan

 Fri, 08 Nov 2013 13:16:49 +0200, Philipp Schaumann  
philippschaumann at hotmail.com:

 Hi,


 I have imported a number of keys into Kleopatra, but I have not found  
 some
 option to specify where Kleopatra stores its database so that I can do a
 backup / export all, or similar. I have looked through the documentation  
 but
 did not find something.


 B.R.

 Philipp Schaumann

Hi,

Kleopatra is GnuPG frontend so it stores the data using GnuPG tools.

Your public keys are stored in ~/.gnupg/pubring.gpg

Your secret keys are stored in ~/.gnupg/secring.gpg

This is from GnuPG docs:

http://www.gnupg.org/documentation/

Hope this helps.

Best regards,
Yuri

[kde-doc-english] keys FN do not work

2012-09-23 Thread Angelo Cerrone

hello I have a problem with the FN keys on Toshiba Equium A100-331

system installed kubunto 12:04

the FN key does not work, I tried various guides but does not work


thanks angel
-- next part --
An HTML attachment was scrubbed...
URL: 
http://mail.kde.org/pipermail/kde-doc-english/attachments/20120922/bd849fda/attachment.html

[kde-doc-english] keys FN do not work

2012-09-23 Thread Yuri Chornoivan

 Sun, 23 Sep 2012 00:23:20 +0300, Angelo Cerrone  
angelo.cerr at gmail.com:

 hello I have a problem with the FN keys on Toshiba Equium A100-331

 system installed kubunto 12:04

 the FN key does not work, I tried various guides but does not work


 thanks angel

Hi,

This list is for KDE documentation writers, so your question is off topic  
here.

It would be easier to answer if you at least give a short list of the  
methods you have already tried to avoid confusion of advices that do not  
work.

Please use kubuntu-users mailing list

https://lists.ubuntu.com/mailman/listinfo/kubuntu-users

or better ubuntu-users mailing list

https://lists.ubuntu.com/mailman/listinfo/ubuntu-users

for your question. Please subscribe first to avoid message bouncing and  
receive answers without unnecessary delays.

Hope this helps.

Best regards,
Yuri

[kde-doc-english] Changes for tag keys: keycap to keysym

2012-09-16 Thread Burkhard Lück

Am Freitag, 14. September 2012 17:52:49 schrieb Antoni Bella P?rez:
 
   This command shows the necessary changes to the documentation set
 keys labeled keysym:
 
 find templates/docmessages/* -type f -name *.pot | xargs egrep --color  -iR
 keycap.?(Down|Left|Right|Up)(\sArrow)?.?/keycap
 
   Please apply necessary changes to the sources (KDE 4.9 and 4.10). Is this
 correct?
 
This kind of changes from keycap to keysym markup does not change the visual 
appearance of a documentation for the users, but of course helps to maintain 
the docbooks and keep markup consistent.

These fixes can not go directly into 4.9 (stable), only via backports from 4.10 
(trunk/master) done by the translators at certain times.

I prefer to do this kind of fixes only together with 
updating/proofreading/correcting the content of a docbook.

-- 
Burkhard L?ck

[kde-doc-english] Changes for tag keys: keycap to keysym

2012-09-16 Thread Antoni Bella Pérez

On Sunday, 16 of September de 2012 21:33:40 Burkhard L?ck wrote:
 Am Freitag, 14. September 2012 17:52:49 schrieb Antoni Bella P?rez:
This command shows the necessary changes to the documentation set
  
  keys labeled keysym:
  
  find templates/docmessages/* -type f -name *.pot | xargs egrep --color 
  -iR
  keycap.?(Down|Left|Right|Up)(\sArrow)?.?/keycap
  
Please apply necessary changes to the sources (KDE 4.9 and 4.10). Is
this
  
  correct?
 
 This kind of changes from keycap to keysym markup does not change the visual
 appearance of a documentation for the users, but of course helps to
 maintain the docbooks and keep markup consistent.
 
 These fixes can not go directly into 4.9 (stable), only via backports from
 4.10 (trunk/master) done by the translators at certain times.
 
 I prefer to do this kind of fixes only together with
 updating/proofreading/correcting the content of a docbook.

  Hi Burkhard

  Naturally, it helps to review the context is kept updated.

  From the Catalan translation team have created rules for keys (for pology 
tool) that could be exported to other languages. If someone finds them useful.

http://websvn.kde.org/trunk/l10n-
support/pology/lang/ca/rules/keys.rules?view=markup

  Toni

[kde-doc-english] kcontrol/keys#global: component menu position is inadequate

2010-09-16 Thread Krzysztof Żelechowski

Regarding the Keyboard Shortcuts Manual [1]: the section Global Keyboard 
Shortcuts [2] says:

# At the bottom of this page is a drop down box?

whereas the pop-up menu is really at the top.

Besides, the style of Ctrl+C in the section Standard Keyboard Shortcuts 
implies that it is a key combination, whereas it is a literal string to be 
typed (pressing the actual key combination in the search box obviously has the 
effect of invoking the corresponding action, so this advice is pretty unsafe).

Please fix,
Chris
__
[1] URL:help:/kcontrol/keys/index.html#key-bindings
[2] URL:help:/kcontrol/keys/index.html#key-bindings-use-globapp

[kde-doc-english] kcontrol/keys#global: component menu position is inadequate

2010-09-16 Thread Yuri Chornoivan

 Thu, 16 Sep 2010 12:02:57 +0300, Krzysztof ?elechowski  
giecrilj at stegny.2a.pl:

 Regarding the Keyboard Shortcuts Manual [1]: the section Global  
 Keyboard Shortcuts [2] says:

 # At the bottom of this page is a drop down box?

 whereas the pop-up menu is really at the top.

 Besides, the style of Ctrl+C in the section Standard Keyboard  
 Shortcuts implies that it is a key combination, whereas it is a literal  
 string to be typed (pressing the actual key combination in the search  
 box obviously has the effect of invoking the corresponding action, so  
 this advice is pretty unsafe).

 Please fix,
 Chris

Fixed. Thanks once again. :)

[kde-doc-english] how can i get off slow keys There is nothing in Documentation

2009-01-12 Thread Burkhard Lück

Systemsettings-Accessibility-Accessibility-Activation Gestures
uncheck Use gestures for activating stickx keys and slow keys

Thanks for the hint, the documentation for the Accessibility page in 
systemsettings is really outdated, please file a report on bugs.kde.org.

-- 
Burkhard L?ck

[kde-doc-english] how can i get off slow keys There is nothing in Documentation

2009-01-10 Thread Helmut Kohlhepp

kind  regards

[kde-doc-english] [Bug 129925] New: Typo /nit pick - should letter keys be capitalized?

2006-06-27 Thread Natalie

--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.
 
http://bugs.kde.org/show_bug.cgi?id=129925 
   Summary: Typo /nit pick - should letter keys be capitalized?
   Product: docs
   Version: unspecified
  Platform: unspecified
OS/Version: Linux
Status: NEW
  Severity: normal
  Priority: NOR
 Component: general
AssignedTo: kde-doc-english kde org
ReportedBy: nat switch demon nl


Version:(using KDE KDE 3.5.2)
OS:Linux

kcontrol_kcmaccess

index.docbook:124

  - Now if you type a keycapp/keycap,

  - Shouldn't letter keys be capitalized? 
  keycapP/keycap
  In descriptions about menus we use capitals as well: 
  keycombo action=\simul\Ctrl;keycapN/keycap/keycombo

[kde-doc-english] [Bug 129925] Typo /nit pick - should letter keys be capitalized?

2006-06-27 Thread Burkhard Lueck

--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.
 
http://bugs.kde.org/show_bug.cgi?id=129925 
lueck hube-lueck de changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED



--- Additional Comments From lueck hube-lueck de  2006-06-28 00:20 ---
SVN commit 84 by lueck:

fixed wrong capitalization of keycap, found by Natalie
BUG:129925

 M  +1 -1  index.docbook  


--- trunk/KDE/kdebase/doc/kcontrol/kcmaccess/index.docbook #83:84
 @ -124,7 +124,7  @
 paraIf you press the Shift; key then press the
 keycapF/keycap key, the computer interprets this as keycombo
 action=simulShift;keycapF/keycap/keycombo.  Now if you
-type a keycapp/keycap, the computer interprets this as the letter p
+type a keycapP/keycap, the computer interprets this as the letter p
 (no shift).
 /para
 /listitem

[kde-doc-english] [Bug 34991] lock sticky keys does not work

2005-12-19 Thread Philip Rodrigues

--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.
 
http://bugs.kde.org/show_bug.cgi?id=34991 




--- Additional Comments From phil kde org  2005-12-19 17:39 ---
I think the following patch describes the behaviour correctly. Please check, 
since I got myself a bit confused about this :-). If you agree, I'll commit 
during the current string unfreeze.

Index: index.docbook
===
--- index.docbook   (revision 489112)
+++ index.docbook   (working copy)
 @ -134,11 +134,12  @
 termWith guilabelLock Sticky Keys/guilabel enabled:/term
 listitem
 para
-The user presses the Shift; key, then presses the keycapF/keycap key.
+The user presses the Shift; key emphasistwice/emphasis, then presses the 
keycapF/keycap key.
 The computer translates this into keycombo
 action=simulShift;keycapF/keycap/keycombo.  Now if the user
 types a keycapp/keycap, the computer interprets this as the letter P
-(keycombo action=simulShift;keycapP/keycap/keycombo).
+(keycombo action=simulShift;keycapP/keycap/keycombo). To
+de-select the Shift; key, press it again.
 /para
 /listitem
 /varlistentry

[kde-doc-english] [Bug 34991] lock sticky keys does not work

2005-12-19 Thread Thomas Reitelbach

--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.
 
http://bugs.kde.org/show_bug.cgi?id=34991 




--- Additional Comments From tr erdfunkstelle de  2005-12-19 22:41 ---
Yes, this patch describes the correct behaviour.
Please commit it :)

[kde-doc-english] [Bug 34991] lock sticky keys does not work

2005-08-28 Thread Thomas Reitelbach

--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.
 
http://bugs.kde.org/show_bug.cgi?id=34991 
tr erdfunkstelle de changed:

   What|Removed |Added

 CC||tr erdfunkstelle de
 AssignedTo|hoelzer kde org |kde-doc-english kde org
 Status|UNCONFIRMED |NEW
  everconfirmed|0   |1

[kde-doc-english] [Bug 111002] New: Typos/errors in KControl :: kcmnotify and :: keys

2005-08-18 Thread Sander Koning

--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.
 
http://bugs.kde.org/show_bug.cgi?id=111002 
   Summary: Typos/errors in KControl :: kcmnotify and :: keys
   Product: docs
   Version: unspecified
  Platform: Compiled Sources
OS/Version: Linux
Status: NEW
  Severity: normal
  Priority: NOR
 Component: Corrections
AssignedTo: kde-doc-english kde org
ReportedBy: skoning ch its tudelft nl


Version:(using KDE Devel)
Installed from:Compiled sources

Typo in kcmnotify, docbook line 64:
retreival should be retrieval

Error in keys, docbook line 127:
kde; comes with one pre-defined key binding scheme [...]
Outdated? My 3.4.0 has seven.

[kde-doc-english] [Bug 111002] Typos/errors in KControl :: kcmnotify and :: keys

2005-08-18 Thread Danny Allen

--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.
 
http://bugs.kde.org/show_bug.cgi?id=111002 
dannya40uk yahoo co uk changed:

   What|Removed |Added

 AssignedTo|kde-doc-english kde org |dannya40uk yahoo co uk

88 matches

Mail list logo