Re: Review Request 111210: Move the XMLGUI technology to xmlgui/

2013-07-10 Thread Andrea Scarpino
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111210/ --- (Updated July 10, 2013, 8:53 a.m.) Review request for KDE Frameworks.

Re: Review Request 110988: Port kio-file to QFile

2013-07-10 Thread David Faure
On July 9, 2013, 9:39 p.m., David Faure wrote: kioslave/file/file.cpp, line 476 http://git.reviewboard.kde.org/r/110988/diff/5/?file=169752#file169752line476 coding style: no spaces inside parenthesis (same in a few other places). Martin Klapetek wrote: Fwiw, the coding

Re: Review Request 111210: Move the XMLGUI technology to xmlgui/

2013-07-10 Thread Andrea Scarpino
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111210/ --- (Updated July 10, 2013, 10:08 a.m.) Review request for KDE Frameworks.

Re: Review Request 111409: Deprecate KGlobalSettings::*Font methods in favor of QFontsDatabase::systemFont

2013-07-10 Thread Kevin Ottens
On July 8, 2013, 11:19 a.m., Kevin Ottens wrote: khtml/khtml_settings.cpp, line 30 http://git.reviewboard.kde.org/r/111409/diff/2/?file=169204#file169204line30 Huh? Shouldn't be needed anymore. Aleix Pol Gonzalez wrote: It's needed for KDE_DEFAULT_CHANGECURSOR. OK, can be

Re: Review Request 111456: Create KCrash framework

2013-07-10 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111456/#review35828 --- kdeui/util/kcrash.h

Re: Review Request 111210: Move the XMLGUI technology to xmlgui/

2013-07-10 Thread Andrea Scarpino
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111210/ --- (Updated July 10, 2013, 11:48 a.m.) Review request for KDE Frameworks.

Re: Review Request 110988: Port kio-file to QFile

2013-07-10 Thread Martin Klapetek
On July 9, 2013, 9:39 p.m., David Faure wrote: kioslave/file/file.cpp, line 476 http://git.reviewboard.kde.org/r/110988/diff/5/?file=169752#file169752line476 coding style: no spaces inside parenthesis (same in a few other places). Martin Klapetek wrote: Fwiw, the coding

Re: Review Request 110988: Port kio-file to QFile

2013-07-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110988/#review35833 --- Ship it! kioslave/file/file.cpp

Re: Review Request 110988: Port kio-file to QFile

2013-07-10 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110988/#review35835 --- This review has been submitted with commit

Re: Review Request 110988: Port kio-file to QFile

2013-07-10 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110988/ --- (Updated July 10, 2013, 10:41 a.m.) Status -- This change has been

Re: Review Request 110988: Port kio-file to QFile

2013-07-10 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110988/#review35834 --- This review has been submitted with commit

Re: KIO progress towards tier 1 framework?

2013-07-10 Thread Chusslove Illich
[: Kevin Ottens :] [ki18n not being tier 1] Means the set of frameworks which will use ki18n will be reduced though. Maybe not a big deal, our needs for advanced i18n features are likely not as high there than in applications (I'm unsure about that statement honestly). I'm not terribly

Re: KIO progress towards tier 1 framework?

2013-07-10 Thread Kevin Ottens
On Wednesday 10 July 2013 13:30:17 Chusslove Illich wrote: [: Kevin Ottens :] For locale it should be QLocale really. KLocale is likely to disappear at some point. QLocale might not fulfill all your needs yet, but we'd need to know what you miss sooner than later. I don't have in mind

Re: Review Request 111210: Move the XMLGUI technology to xmlgui/

2013-07-10 Thread Andrea Scarpino
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111210/ --- (Updated July 10, 2013, 8:44 p.m.) Review request for KDE Frameworks.

Re: Review Request 111456: Create KCrash framework

2013-07-10 Thread Benjamin Port
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111456/ --- (Updated July 10, 2013, 6:54 p.m.) Review request for KDE Frameworks.

Re: Review Request 111456: Create KCrash framework

2013-07-10 Thread Benjamin Port
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111456/ --- (Updated July 10, 2013, 7:02 p.m.) Review request for KDE Frameworks.

Re: Review Request 111424: Move KRichTextWidget to KTextWidgets

2013-07-10 Thread Andrea Scarpino
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111424/ --- (Updated July 10, 2013, 10:36 p.m.) Review request for KDE Frameworks.